ctdb-protocol: Fix compilation issue with strncpy()
authorMartin Schwenke <martin@meltin.net>
Thu, 26 Jul 2018 01:01:30 +0000 (11:01 +1000)
committerAmitay Isaacs <amitay@samba.org>
Fri, 27 Jul 2018 03:45:20 +0000 (05:45 +0200)
commit3b56f2002a35b55b46958178c79aee519f0c5880
tree58f381853c5841880fa6c6290ea157e84e33217c
parent5dd84bf5d73e4afab094834bc317da7884b9b9b3
ctdb-protocol: Fix compilation issue with strncpy()

When configured with --picky-developer and using -O3 with gcc 8.1:

../protocol/protocol_util.c: In function ‘ctdb_sock_addr_from_string’:
../protocol/protocol_util.c:282:2: error: ‘strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
  strncpy(s, str, len+1);
  ^~~~~~~~~~~~~~~~~~~~~~
../protocol/protocol_util.c:277:8: note: length computed here
  len = strlen(str);
        ^~~~~~~~~~~

Use strlcpy() instead and check the result.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13545

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb/protocol/protocol_util.c