git.samba.org / sfrench / cifs-2.6.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 468ec44) | patch
[NETFILTER]: ip_conntrack: fix NAT helper unload races
authorPatrick McHardy <kaber@trash.net>
Wed, 29 Nov 2006 01:35:25 +0000 (02:35 +0100)
committerDavid S. Miller <davem@sunset.davemloft.net>
Sun, 3 Dec 2006 05:31:22 +0000 (21:31 -0800)
commit337fbc4166967a72c3cc71c597bdde7e6a8633ab
tree95b2d47e55db3991f66090525b7e28455a6ca39btree
parent468ec44bd5a863736d955f78b8c38896f26864a1commit | diff
[NETFILTER]: ip_conntrack: fix NAT helper unload races

The NAT helpr hooks are protected by RCU, but all of the
conntrack helpers test and use the global pointers instead
of copying them first using rcu_dereference()

Also replace synchronize_net() by synchronize_rcu() for clarity
since sychronizing only with packet receive processing is
insufficient to prevent races.

Signed-off-by: Patrick McHardy <kaber@trash.net>
15 files changed:
net/ipv4/netfilter/ip_conntrack_amanda.c diff | blob | history
net/ipv4/netfilter/ip_conntrack_ftp.c diff | blob | history
net/ipv4/netfilter/ip_conntrack_helper_h323.c diff | blob | history
net/ipv4/netfilter/ip_conntrack_helper_pptp.c diff | blob | history
net/ipv4/netfilter/ip_conntrack_irc.c diff | blob | history
net/ipv4/netfilter/ip_conntrack_sip.c diff | blob | history
net/ipv4/netfilter/ip_conntrack_tftp.c diff | blob | history
net/ipv4/netfilter/ip_nat_amanda.c diff | blob | history
net/ipv4/netfilter/ip_nat_ftp.c diff | blob | history
net/ipv4/netfilter/ip_nat_helper_h323.c diff | blob | history
net/ipv4/netfilter/ip_nat_helper_pptp.c diff | blob | history
net/ipv4/netfilter/ip_nat_irc.c diff | blob | history
net/ipv4/netfilter/ip_nat_sip.c diff | blob | history
net/ipv4/netfilter/ip_nat_tftp.c diff | blob | history
net/netfilter/nf_conntrack_ftp.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.