git.samba.org / sfrench / cifs-2.6.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: d85ea93) | patch
pkt_sched: fq: do not hold qdisc lock while allocating memory
authorEric Dumazet <edumazet@google.com>
Fri, 7 Mar 2014 06:57:52 +0000 (22:57 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 9 Mar 2014 00:09:10 +0000 (19:09 -0500)
commit2d8d40afd187bced0a3d056366fb58d66fe845e3
treec42c299205f38d9a6ab275d53de74583f56e2119tree
parentd85ea93ffb7e8bb6855d60c0901e4b6571689085commit | diff
pkt_sched: fq: do not hold qdisc lock while allocating memory

Resizing fq hash table allocates memory while holding qdisc spinlock,
with BH disabled.

This is definitely not good, as allocation might sleep.

We can drop the lock and get it when needed, we hold RTNL so no other
changes can happen at the same time.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: afe4fd062416 ("pkt_sched: fq: Fair Queue packet scheduler")
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_fq.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.