x86/resctrl: Fix event counts regression in reused RMIDs
authorPeter Newman <peternewman@google.com>
Tue, 20 Dec 2022 16:41:31 +0000 (17:41 +0100)
committerBorislav Petkov (AMD) <bp@alien8.de>
Tue, 10 Jan 2023 18:51:59 +0000 (19:51 +0100)
commit2a81160d29d65b5876ab3f824fda99ae0219f05e
tree0ab7e380b797e025c2ed4141254e06d68b07a73b
parentfe1f0714385fbcf76b0cbceb02b7277d842014fc
x86/resctrl: Fix event counts regression in reused RMIDs

When creating a new monitoring group, the RMID allocated for it may have
been used by a group which was previously removed. In this case, the
hardware counters will have non-zero values which should be deducted
from what is reported in the new group's counts.

resctrl_arch_reset_rmid() initializes the prev_msr value for counters to
0, causing the initial count to be charged to the new group. Resurrect
__rmid_read() and use it to initialize prev_msr correctly.

Unlike before, __rmid_read() checks for error bits in the MSR read so
that callers don't need to.

Fixes: 1d81d15db39c ("x86/resctrl: Move mbm_overflow_count() into resctrl_arch_rmid_read()")
Signed-off-by: Peter Newman <peternewman@google.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Tested-by: Babu Moger <babu.moger@amd.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20221220164132.443083-1-peternewman@google.com
arch/x86/kernel/cpu/resctrl/monitor.c