dmaengine: stm32-dma: avoid 64-bit division in stm32_dma_get_max_width
authorArnd Bergmann <arnd@arndb.de>
Wed, 3 Nov 2021 15:33:12 +0000 (16:33 +0100)
committerVinod Koul <vkoul@kernel.org>
Tue, 9 Nov 2021 05:50:35 +0000 (11:20 +0530)
commit2498363310e9b5e5de0e104709adc35c9f3ff7d9
treee84ac41c5fb21ec3da618b6b467f05a3a823e935
parente0674853943287669a82d1ffe09a700944615978
dmaengine: stm32-dma: avoid 64-bit division in stm32_dma_get_max_width

Using the % operator on a 64-bit variable is expensive and can
cause a link failure:

arm-linux-gnueabi-ld: drivers/dma/stm32-dma.o: in function `stm32_dma_get_max_width':
stm32-dma.c:(.text+0x170): undefined reference to `__aeabi_uldivmod'
arm-linux-gnueabi-ld: drivers/dma/stm32-dma.o: in function `stm32_dma_set_xfer_param':
stm32-dma.c:(.text+0x1cd4): undefined reference to `__aeabi_uldivmod'

As we know that we just want to check the alignment in
stm32_dma_get_max_width(), there is no need for a full division, and
using a simple mask is a faster replacement.

Same in stm32_dma_set_xfer_param(), change this to only allow burst
transfers if the address is a multiple of the length.
stm32_dma_get_best_burst just after will take buf_len into account to fix
burst in case of misalignment.

Fixes: b20fd5fa310c ("dmaengine: stm32-dma: fix stm32_dma_get_max_width")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
Link: https://lore.kernel.org/r/20211103153312.41483-1-amelie.delaunay@foss.st.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/stm32-dma.c