x86/sgx: Do not fail on incomplete sanitization on premature stop of ksgxd
authorJarkko Sakkinen <jarkko@kernel.org>
Tue, 6 Sep 2022 00:02:20 +0000 (03:02 +0300)
committerDave Hansen <dave.hansen@linux.intel.com>
Thu, 8 Sep 2022 20:27:44 +0000 (13:27 -0700)
commit133e049a3f8c91b175029fb6a59b6039d5e79cba
tree3e4e12570082dcf29828225a6226ce85a75a09a0
parent5515d21c6817bc27b0b13c61edf22b09b58bc647
x86/sgx: Do not fail on incomplete sanitization on premature stop of ksgxd

Unsanitized pages trigger WARN_ON() unconditionally, which can panic the
whole computer, if /proc/sys/kernel/panic_on_warn is set.

In sgx_init(), if misc_register() fails or misc_register() succeeds but
neither sgx_drv_init() nor sgx_vepc_init() succeeds, then ksgxd will be
prematurely stopped. This may leave unsanitized pages, which will result a
false warning.

Refine __sgx_sanitize_pages() to return:

1. Zero when the sanitization process is complete or ksgxd has been
   requested to stop.
2. The number of unsanitized pages otherwise.

Fixes: 51ab30eb2ad4 ("x86/sgx: Replace section->init_laundry_list with sgx_dirty_page_list")
Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/linux-sgx/20220825051827.246698-1-jarkko@kernel.org/T/#u
Link: https://lkml.kernel.org/r/20220906000221.34286-2-jarkko@kernel.org
arch/x86/kernel/cpu/sgx/main.c