rtl8192u: Don't use create_proc_read_entry()
authorDavid Howells <dhowells@redhat.com>
Mon, 8 Apr 2013 14:17:33 +0000 (15:17 +0100)
committerAl Viro <viro@zeniv.linux.org.uk>
Mon, 29 Apr 2013 19:41:50 +0000 (15:41 -0400)
commit0541f9d08acfcf68b589e93cc26c3117d0b594c4
tree42cf86191b85db8b1a3b9080c2cae2ee0dd6283c
parentd0206fb55540cfdc3a2634ffdafc6f1d86cf1f15
rtl8192u: Don't use create_proc_read_entry()

Don't use create_proc_read_entry() as that is deprecated, but rather use
proc_create_data() and seq_file instead.  Whilst we're at it, reduce the
number of show functions where we can share them.

Note: proc_get_stats_ap() should probably use seq_file iteration rather than
list_for_each_entry().

Further note: There appears to be a lot of locking missing in this file to
defend against concurrent access by the driver doing normal operations.
Notably, ieee->network_list traversal and RWCAM/RCAMO command/response access.
Further, do any of the registers read have side effects upon reading?

Signed-off-by: David Howells <dhowells@redhat.com>
cc: Jerry Chuang <jerry-chuang@realtek.com>
cc: Mauro Carvalho Chehab <mchehab@redhat.com>
cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
cc: linux-wireless@vger.kernel.org
cc: devel@driverdev.osuosl.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
drivers/staging/rtl8192u/r8192U_core.c