usb: cdns3: fix missing assignment of ret before error check on ret
authorColin Ian King <colin.king@canonical.com>
Mon, 2 Sep 2019 14:50:35 +0000 (15:50 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 Sep 2019 13:46:46 +0000 (15:46 +0200)
commit04db1d2057c8799ab4e732246ed45ca0b283aa6f
tree0ed6fddcc33829e41eb49512f30191ee898e52c8
parent4d2233ecec8e5e2ac3e2efd5bf8fdfaf1dab30d9
usb: cdns3: fix missing assignment of ret before error check on ret

Currently the check on a non-zero return code in ret is false because
ret has been initialized to zero.  I believe that ret should be assigned
to the return from the call to readl_poll_timeout_atomic before the
check on ret.  Since ret is being re-assinged the original initialization
of ret to zero can be removed.

Addresses-Coverity: ("'Constant' variable guards dead code")
Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20190902145035.18200-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/cdns3/gadget.c