r19507: Merge my DSO fixes branch. Building Samba's libraries as shared libraries
[sfrench/samba-autobuild/.git] / source4 / torture / raw / search.c
index 84466d0cdeb5f01c7b41f6d73c746a7d038af17e..56a496632866dfb4949b3388a738ae1be5caa77b 100644 (file)
 */
 
 #include "includes.h"
+#include "torture/torture.h"
+#include "system/filesys.h"
 #include "libcli/raw/libcliraw.h"
+#include "libcli/libcli.h"
+#include "torture/util.h"
 
 
 #define BASEDIR "\\testsearch"
@@ -39,29 +43,41 @@ static BOOL single_search_callback(void *private, union smb_search_data *file)
 /*
   do a single file (non-wildcard) search 
 */
-static NTSTATUS single_search(struct smbcli_state *cli, 
-                             TALLOC_CTX *mem_ctx,
-                             const char *pattern,
-                             enum smb_search_level level,
-                             union smb_search_data *data)
+_PUBLIC_ NTSTATUS torture_single_search(struct smbcli_state *cli, 
+                              TALLOC_CTX *mem_ctx,
+                              const char *pattern,
+                              enum smb_search_level level,
+                              enum smb_search_data_level data_level,
+                              uint16_t attrib,
+                              union smb_search_data *data)
 {
        union smb_search_first io;
        union smb_search_close c;
        NTSTATUS status;
 
-       io.generic.level = level;
-       if (level == RAW_SEARCH_SEARCH ||
-           level == RAW_SEARCH_FFIRST ||
-           level == RAW_SEARCH_FUNIQUE) {
+       switch (level) {
+       case RAW_SEARCH_SEARCH:
+       case RAW_SEARCH_FFIRST:
+       case RAW_SEARCH_FUNIQUE:
+               io.search_first.level = level;
+               io.search_first.data_level = RAW_SEARCH_DATA_SEARCH;
                io.search_first.in.max_count = 1;
-               io.search_first.in.search_attrib = 0;
+               io.search_first.in.search_attrib = attrib;
                io.search_first.in.pattern = pattern;
-       } else {
-               io.t2ffirst.in.search_attrib = 0;
+               break;
+
+       case RAW_SEARCH_TRANS2:
+               io.t2ffirst.level = RAW_SEARCH_TRANS2;
+               io.t2ffirst.data_level = data_level;
+               io.t2ffirst.in.search_attrib = attrib;
                io.t2ffirst.in.max_count = 1;
                io.t2ffirst.in.flags = FLAG_TRANS2_FIND_CLOSE;
                io.t2ffirst.in.storage_type = 0;
                io.t2ffirst.in.pattern = pattern;
+               break;
+
+       case RAW_SEARCH_SMB2:
+               return NT_STATUS_INVALID_LEVEL;
        }
 
        status = smb_raw_search_first(cli->tree, mem_ctx,
@@ -82,24 +98,124 @@ static NTSTATUS single_search(struct smbcli_state *cli,
 static struct {
        const char *name;
        enum smb_search_level level;
+       enum smb_search_data_level data_level;
+       int name_offset;
+       int resume_key_offset;
        uint32_t capability_mask;
        NTSTATUS status;
        union smb_search_data data;
 } levels[] = {
-       {"FFIRST",                 RAW_SEARCH_FFIRST, },
-       {"FUNIQUE",                RAW_SEARCH_FUNIQUE, },
-       {"SEARCH",                 RAW_SEARCH_SEARCH, },
-       {"STANDARD",               RAW_SEARCH_STANDARD, },
-       {"EA_SIZE",                RAW_SEARCH_EA_SIZE, },
-       {"DIRECTORY_INFO",         RAW_SEARCH_DIRECTORY_INFO, },
-       {"FULL_DIRECTORY_INFO",    RAW_SEARCH_FULL_DIRECTORY_INFO, },
-       {"NAME_INFO",              RAW_SEARCH_NAME_INFO, },
-       {"BOTH_DIRECTORY_INFO",    RAW_SEARCH_BOTH_DIRECTORY_INFO, },
-       {"ID_FULL_DIRECTORY_INFO", RAW_SEARCH_ID_FULL_DIRECTORY_INFO, },
-       {"ID_BOTH_DIRECTORY_INFO", RAW_SEARCH_ID_BOTH_DIRECTORY_INFO, },
-       {"UNIX_INFO",              RAW_SEARCH_UNIX_INFO, CAP_UNIX}
+       {"FFIRST",
+        RAW_SEARCH_FFIRST, RAW_SEARCH_DATA_SEARCH,
+        offsetof(union smb_search_data, search.name),
+        -1,
+       },
+       {"FUNIQUE",
+        RAW_SEARCH_FUNIQUE, RAW_SEARCH_DATA_SEARCH,
+        offsetof(union smb_search_data, search.name),
+        -1,
+       },
+       {"SEARCH",
+        RAW_SEARCH_SEARCH, RAW_SEARCH_DATA_SEARCH,
+        offsetof(union smb_search_data, search.name),
+        -1,
+       },
+       {"STANDARD",
+        RAW_SEARCH_TRANS2, RAW_SEARCH_DATA_STANDARD, 
+        offsetof(union smb_search_data, standard.name.s),
+        offsetof(union smb_search_data, standard.resume_key),
+       },
+       {"EA_SIZE",
+        RAW_SEARCH_TRANS2, RAW_SEARCH_DATA_EA_SIZE, 
+        offsetof(union smb_search_data, ea_size.name.s),
+        offsetof(union smb_search_data, ea_size.resume_key),
+       },
+       {"DIRECTORY_INFO",
+        RAW_SEARCH_TRANS2, RAW_SEARCH_DATA_DIRECTORY_INFO, 
+        offsetof(union smb_search_data, directory_info.name.s),
+        offsetof(union smb_search_data, directory_info.file_index),
+       },
+       {"FULL_DIRECTORY_INFO",
+        RAW_SEARCH_TRANS2, RAW_SEARCH_DATA_FULL_DIRECTORY_INFO, 
+        offsetof(union smb_search_data, full_directory_info.name.s),
+        offsetof(union smb_search_data, full_directory_info.file_index),
+       },
+       {"NAME_INFO",
+        RAW_SEARCH_TRANS2, RAW_SEARCH_DATA_NAME_INFO, 
+        offsetof(union smb_search_data, name_info.name.s),
+        offsetof(union smb_search_data, name_info.file_index),
+       },
+       {"BOTH_DIRECTORY_INFO",
+        RAW_SEARCH_TRANS2, RAW_SEARCH_DATA_BOTH_DIRECTORY_INFO, 
+        offsetof(union smb_search_data, both_directory_info.name.s),
+        offsetof(union smb_search_data, both_directory_info.file_index),
+       },
+       {"ID_FULL_DIRECTORY_INFO",
+        RAW_SEARCH_TRANS2, RAW_SEARCH_DATA_ID_FULL_DIRECTORY_INFO, 
+        offsetof(union smb_search_data, id_full_directory_info.name.s),
+        offsetof(union smb_search_data, id_full_directory_info.file_index),
+       },
+       {"ID_BOTH_DIRECTORY_INFO",
+        RAW_SEARCH_TRANS2, RAW_SEARCH_DATA_ID_BOTH_DIRECTORY_INFO, 
+        offsetof(union smb_search_data, id_both_directory_info.name.s),
+        offsetof(union smb_search_data, id_both_directory_info.file_index),
+       },
+       {"UNIX_INFO",
+        RAW_SEARCH_TRANS2, RAW_SEARCH_DATA_UNIX_INFO, 
+        offsetof(union smb_search_data, unix_info.name),
+        offsetof(union smb_search_data, unix_info.file_index),
+        CAP_UNIX}
 };
 
+
+/*
+  return level name
+*/
+static const char *level_name(enum smb_search_level level,
+                             enum smb_search_data_level data_level)
+{
+       int i;
+       for (i=0;i<ARRAY_SIZE(levels);i++) {
+               if (level == levels[i].level &&
+                   data_level == levels[i].data_level) {
+                       return levels[i].name;
+               }
+       }
+       return NULL;
+}
+
+/*
+  extract the name from a smb_data structure and level
+*/
+static const char *extract_name(void *data, enum smb_search_level level,
+                               enum smb_search_data_level data_level)
+{
+       int i;
+       for (i=0;i<ARRAY_SIZE(levels);i++) {
+               if (level == levels[i].level &&
+                   data_level == levels[i].data_level) {
+                       return *(const char **)(levels[i].name_offset + (char *)data);
+               }
+       }
+       return NULL;
+}
+
+/*
+  extract the name from a smb_data structure and level
+*/
+static uint32_t extract_resume_key(void *data, enum smb_search_level level,
+                                  enum smb_search_data_level data_level)
+{
+       int i;
+       for (i=0;i<ARRAY_SIZE(levels);i++) {
+               if (level == levels[i].level &&
+                   data_level == levels[i].data_level) {
+                       return *(uint32_t *)(levels[i].resume_key_offset + (char *)data);
+               }
+       }
+       return 0;
+}
+
 /* find a level in the table by name */
 static union smb_search_data *find(const char *name)
 {
@@ -143,8 +259,11 @@ static BOOL test_one_file(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
 
                printf("testing %s\n", levels[i].name);
 
-               levels[i].status = single_search(cli, mem_ctx, fname, 
-                                                levels[i].level, &levels[i].data);
+               levels[i].status = torture_single_search(cli, mem_ctx, fname, 
+                                                        levels[i].level,
+                                                        levels[i].data_level,
+                                                        0,
+                                                        &levels[i].data);
 
                /* see if this server claims to support this level */
                if ((cap & levels[i].capability_mask) != levels[i].capability_mask) {
@@ -161,8 +280,11 @@ static BOOL test_one_file(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
                        continue;
                }
 
-               status = single_search(cli, mem_ctx, fname2, 
-                                      levels[i].level, &levels[i].data);
+               status = torture_single_search(cli, mem_ctx, fname2, 
+                                              levels[i].level,
+                                              levels[i].data_level,
+                                              0,
+                                              &levels[i].data);
                
                expected_status = NT_STATUS_NO_SUCH_FILE;
                if (levels[i].level == RAW_SEARCH_SEARCH ||
@@ -181,7 +303,7 @@ static BOOL test_one_file(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
 
        /* get the all_info file into to check against */
        all_info.generic.level = RAW_FILEINFO_ALL_INFO;
-       all_info.generic.in.fname = fname;
+       all_info.generic.in.file.path = fname;
        status = smb_raw_pathinfo(cli->tree, mem_ctx, &all_info);
        if (!NT_STATUS_IS_OK(status)) {
                printf("RAW_FILEINFO_ALL_INFO failed - %s\n", nt_errstr(status));
@@ -190,7 +312,7 @@ static BOOL test_one_file(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        }
 
        alt_info.generic.level = RAW_FILEINFO_ALT_NAME_INFO;
-       alt_info.generic.in.fname = fname;
+       alt_info.generic.in.file.path = fname;
        status = smb_raw_pathinfo(cli->tree, mem_ctx, &alt_info);
        if (!NT_STATUS_IS_OK(status)) {
                printf("RAW_FILEINFO_ALT_NAME_INFO failed - %s\n", nt_errstr(status));
@@ -199,7 +321,7 @@ static BOOL test_one_file(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        }
 
        internal_info.generic.level = RAW_FILEINFO_INTERNAL_INFORMATION;
-       internal_info.generic.in.fname = fname;
+       internal_info.generic.in.file.path = fname;
        status = smb_raw_pathinfo(cli->tree, mem_ctx, &internal_info);
        if (!NT_STATUS_IS_OK(status)) {
                printf("RAW_FILEINFO_INTERNAL_INFORMATION failed - %s\n", nt_errstr(status));
@@ -208,7 +330,7 @@ static BOOL test_one_file(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        }
 
        name_info.generic.level = RAW_FILEINFO_NAME_INFO;
-       name_info.generic.in.fname = fname;
+       name_info.generic.in.file.path = fname;
        status = smb_raw_pathinfo(cli->tree, mem_ctx, &name_info);
        if (!NT_STATUS_IS_OK(status)) {
                printf("RAW_FILEINFO_NAME_INFO failed - %s\n", nt_errstr(status));
@@ -341,11 +463,11 @@ static BOOL test_one_file(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        CHECK_NTTIME("ID_FULL_DIRECTORY_INFO", id_full_directory_info,           access_time, all_info, all_info, access_time);
        CHECK_NTTIME("ID_BOTH_DIRECTORY_INFO", id_both_directory_info,           access_time, all_info, all_info, access_time);
 
-       CHECK_NTTIME("DIRECTORY_INFO",      directory_info,      create_time, all_info, all_info, create_time);
-       CHECK_NTTIME("FULL_DIRECTORY_INFO", full_directory_info, create_time, all_info, all_info, create_time);
-       CHECK_NTTIME("BOTH_DIRECTORY_INFO", both_directory_info, create_time, all_info, all_info, create_time);
-       CHECK_NTTIME("ID_FULL_DIRECTORY_INFO", id_full_directory_info,           create_time, all_info, all_info, create_time);
-       CHECK_NTTIME("ID_BOTH_DIRECTORY_INFO", id_both_directory_info,           create_time, all_info, all_info, create_time);
+       CHECK_NTTIME("DIRECTORY_INFO",      directory_info,      change_time, all_info, all_info, change_time);
+       CHECK_NTTIME("FULL_DIRECTORY_INFO", full_directory_info, change_time, all_info, all_info, change_time);
+       CHECK_NTTIME("BOTH_DIRECTORY_INFO", both_directory_info, change_time, all_info, all_info, change_time);
+       CHECK_NTTIME("ID_FULL_DIRECTORY_INFO", id_full_directory_info,           change_time, all_info, all_info, change_time);
+       CHECK_NTTIME("ID_BOTH_DIRECTORY_INFO", id_both_directory_info,           change_time, all_info, all_info, change_time);
 
        CHECK_VAL("SEARCH",              search,              size, all_info, all_info, size);
        CHECK_VAL("STANDARD",            standard,            size, all_info, all_info, size);
@@ -411,7 +533,7 @@ static BOOL multiple_search_callback(void *private, union smb_search_data *file)
 
 
        data->count++;
-       data->list = talloc_realloc_p(data->mem_ctx,
+       data->list = talloc_realloc(data->mem_ctx,
                                      data->list, 
                                      union smb_search_data,
                                      data->count);
@@ -429,22 +551,25 @@ enum continue_type {CONT_FLAGS, CONT_NAME, CONT_RESUME_KEY};
 static NTSTATUS multiple_search(struct smbcli_state *cli, 
                                TALLOC_CTX *mem_ctx,
                                const char *pattern,
-                               enum smb_search_level level,
+                               enum smb_search_data_level data_level,
                                enum continue_type cont_type,
                                void *data)
 {
        union smb_search_first io;
        union smb_search_next io2;
        NTSTATUS status;
-       const int per_search = 300;
+       const int per_search = 100;
        struct multiple_result *result = data;
 
-       io.generic.level = level;
-       if (level == RAW_SEARCH_SEARCH) {
+       if (data_level == RAW_SEARCH_DATA_SEARCH) {
+               io.search_first.level = RAW_SEARCH_SEARCH;
+               io.search_first.data_level = RAW_SEARCH_DATA_SEARCH;
                io.search_first.in.max_count = per_search;
                io.search_first.in.search_attrib = 0;
                io.search_first.in.pattern = pattern;
        } else {
+               io.t2ffirst.level = RAW_SEARCH_TRANS2;
+               io.t2ffirst.data_level = data_level;
                io.t2ffirst.in.search_attrib = 0;
                io.t2ffirst.in.max_count = per_search;
                io.t2ffirst.in.flags = FLAG_TRANS2_FIND_CLOSE_IF_END;
@@ -461,12 +586,15 @@ static NTSTATUS multiple_search(struct smbcli_state *cli,
        
 
        while (NT_STATUS_IS_OK(status)) {
-               io2.generic.level = level;
-               if (level == RAW_SEARCH_SEARCH) {
+               if (data_level == RAW_SEARCH_DATA_SEARCH) {
+                       io2.search_next.level = RAW_SEARCH_SEARCH;
+                       io2.search_next.data_level = RAW_SEARCH_DATA_SEARCH;
                        io2.search_next.in.max_count = per_search;
                        io2.search_next.in.search_attrib = 0;
                        io2.search_next.in.id = result->list[result->count-1].search.id;
                } else {
+                       io2.t2fnext.level = RAW_SEARCH_TRANS2;
+                       io2.t2fnext.data_level = data_level;
                        io2.t2fnext.in.handle = io.t2ffirst.out.handle;
                        io2.t2fnext.in.max_count = per_search;
                        io2.t2fnext.in.resume_key = 0;
@@ -474,40 +602,19 @@ static NTSTATUS multiple_search(struct smbcli_state *cli,
                        io2.t2fnext.in.last_name = "";
                        switch (cont_type) {
                        case CONT_RESUME_KEY:
-                               if (level == RAW_SEARCH_STANDARD) {
-                                       io2.t2fnext.in.resume_key = 
-                                               result->list[result->count-1].standard.resume_key;
-                               } else if (level == RAW_SEARCH_EA_SIZE) {
-                                       io2.t2fnext.in.resume_key = 
-                                               result->list[result->count-1].ea_size.resume_key;
-                               } else if (level == RAW_SEARCH_DIRECTORY_INFO) {
-                                       io2.t2fnext.in.resume_key = 
-                                               result->list[result->count-1].directory_info.file_index;
-                               } else {
-                                       io2.t2fnext.in.resume_key = 
-                                               result->list[result->count-1].both_directory_info.file_index;
-                               }
+                               io2.t2fnext.in.resume_key = extract_resume_key(&result->list[result->count-1],
+                                                                              io2.t2fnext.level, io2.t2fnext.data_level);
                                if (io2.t2fnext.in.resume_key == 0) {
-                                       printf("Server does not support resume by key\n");
+                                       printf("Server does not support resume by key for level %s\n",
+                                              level_name(io2.t2fnext.level, io2.t2fnext.data_level));
                                        return NT_STATUS_NOT_SUPPORTED;
                                }
                                io2.t2fnext.in.flags |= FLAG_TRANS2_FIND_REQUIRE_RESUME |
                                        FLAG_TRANS2_FIND_BACKUP_INTENT;
                                break;
                        case CONT_NAME:
-                               if (level == RAW_SEARCH_STANDARD) {
-                                       io2.t2fnext.in.last_name = 
-                                               result->list[result->count-1].standard.name.s;
-                               } else if (level == RAW_SEARCH_EA_SIZE) {
-                                       io2.t2fnext.in.last_name = 
-                                               result->list[result->count-1].ea_size.name.s;
-                               } else if (level == RAW_SEARCH_DIRECTORY_INFO) {
-                                       io2.t2fnext.in.last_name = 
-                                               result->list[result->count-1].directory_info.name.s;
-                               } else {
-                                       io2.t2fnext.in.last_name = 
-                                               result->list[result->count-1].both_directory_info.name.s;
-                               }
+                               io2.t2fnext.in.last_name = extract_name(&result->list[result->count-1],
+                                                                       io2.t2fnext.level, io2.t2fnext.data_level);
                                break;
                        case CONT_FLAGS:
                                io2.t2fnext.in.flags |= FLAG_TRANS2_FIND_CONTINUE;
@@ -520,7 +627,7 @@ static NTSTATUS multiple_search(struct smbcli_state *cli,
                if (!NT_STATUS_IS_OK(status)) {
                        break;
                }
-               if (level == RAW_SEARCH_SEARCH) {
+               if (data_level == RAW_SEARCH_DATA_SEARCH) {
                        if (io2.search_next.out.count == 0) {
                                break;
                        }
@@ -543,43 +650,38 @@ static NTSTATUS multiple_search(struct smbcli_state *cli,
 
 #define CHECK_VALUE(v, correct) do { \
        if ((v) != (correct)) { \
-               printf("(%s) Incorrect value %s=%d - should be %d\n", \
-                      __location__, #v, v, correct); \
+               printf("(%s) Incorrect value %s=%ld - should be %ld\n", \
+                      __location__, #v, (long)v, (long)correct); \
                ret = False; \
+               goto done; \
        }} while (0)
 
 #define CHECK_STRING(v, correct) do { \
-       if (StrCaseCmp(v, correct) != 0) { \
+       if (strcasecmp_m(v, correct) != 0) { \
                printf("(%s) Incorrect value %s='%s' - should be '%s'\n", \
                       __location__, #v, v, correct); \
                ret = False; \
        }} while (0)
 
 
-static int search_both_compare(union smb_search_data *d1, union smb_search_data *d2)
-{
-       return strcmp_safe(d1->both_directory_info.name.s, d2->both_directory_info.name.s);
-}
+static enum smb_search_data_level compare_data_level;
 
-static int search_standard_compare(union smb_search_data *d1, union smb_search_data *d2)
+static int search_compare(union smb_search_data *d1, union smb_search_data *d2)
 {
-       return strcmp_safe(d1->standard.name.s, d2->standard.name.s);
-}
+       const char *s1, *s2;
+       enum smb_search_level level;
 
-static int search_ea_size_compare(union smb_search_data *d1, union smb_search_data *d2)
-{
-       return strcmp_safe(d1->ea_size.name.s, d2->ea_size.name.s);
-}
+       if (compare_data_level == RAW_SEARCH_DATA_SEARCH) {
+               level = RAW_SEARCH_SEARCH;
+       } else {
+               level = RAW_SEARCH_TRANS2;
+       }
 
-static int search_directory_info_compare(union smb_search_data *d1, union smb_search_data *d2)
-{
-       return strcmp_safe(d1->directory_info.name.s, d2->directory_info.name.s);
+       s1 = extract_name(d1, level, compare_data_level);
+       s2 = extract_name(d2, level, compare_data_level);
+       return strcmp_safe(s1, s2);
 }
 
-static int search_old_compare(union smb_search_data *d1, union smb_search_data *d2)
-{
-       return strcmp_safe(d1->search.name, d2->search.name);
-}
 
 
 /* 
@@ -596,39 +698,48 @@ static BOOL test_many_files(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        struct {
                const char *name;
                const char *cont_name;
-               enum smb_search_level level;
+               enum smb_search_data_level data_level;
                enum continue_type cont_type;
        } search_types[] = {
-               {"SEARCH",              "ID",    RAW_SEARCH_SEARCH,              CONT_RESUME_KEY},
-               {"BOTH_DIRECTORY_INFO", "NAME",  RAW_SEARCH_BOTH_DIRECTORY_INFO, CONT_NAME},
-               {"BOTH_DIRECTORY_INFO", "FLAGS", RAW_SEARCH_BOTH_DIRECTORY_INFO, CONT_FLAGS},
-               {"BOTH_DIRECTORY_INFO", "KEY",   RAW_SEARCH_BOTH_DIRECTORY_INFO, CONT_RESUME_KEY},
-               {"STANDARD",            "FLAGS", RAW_SEARCH_STANDARD,            CONT_FLAGS},
-               {"STANDARD",            "KEY",   RAW_SEARCH_STANDARD,            CONT_RESUME_KEY},
-               {"STANDARD",            "NAME",  RAW_SEARCH_STANDARD,            CONT_NAME},
-               {"EA_SIZE",             "FLAGS", RAW_SEARCH_EA_SIZE,             CONT_FLAGS},
-               {"EA_SIZE",             "KEY",   RAW_SEARCH_EA_SIZE,             CONT_RESUME_KEY},
-               {"EA_SIZE",             "NAME",  RAW_SEARCH_EA_SIZE,             CONT_NAME},
-               {"DIRECTORY_INFO",      "FLAGS", RAW_SEARCH_DIRECTORY_INFO,      CONT_FLAGS},
-               {"DIRECTORY_INFO",      "KEY",   RAW_SEARCH_DIRECTORY_INFO,      CONT_RESUME_KEY},
-               {"DIRECTORY_INFO",      "NAME",  RAW_SEARCH_DIRECTORY_INFO,      CONT_NAME}
+               {"SEARCH",              "ID",    RAW_SEARCH_DATA_SEARCH,              CONT_RESUME_KEY},
+               {"BOTH_DIRECTORY_INFO", "NAME",  RAW_SEARCH_DATA_BOTH_DIRECTORY_INFO, CONT_NAME},
+               {"BOTH_DIRECTORY_INFO", "FLAGS", RAW_SEARCH_DATA_BOTH_DIRECTORY_INFO, CONT_FLAGS},
+               {"BOTH_DIRECTORY_INFO", "KEY",   RAW_SEARCH_DATA_BOTH_DIRECTORY_INFO, CONT_RESUME_KEY},
+               {"STANDARD",            "FLAGS", RAW_SEARCH_DATA_STANDARD,            CONT_FLAGS},
+               {"STANDARD",            "KEY",   RAW_SEARCH_DATA_STANDARD,            CONT_RESUME_KEY},
+               {"STANDARD",            "NAME",  RAW_SEARCH_DATA_STANDARD,            CONT_NAME},
+               {"EA_SIZE",             "FLAGS", RAW_SEARCH_DATA_EA_SIZE,             CONT_FLAGS},
+               {"EA_SIZE",             "KEY",   RAW_SEARCH_DATA_EA_SIZE,             CONT_RESUME_KEY},
+               {"EA_SIZE",             "NAME",  RAW_SEARCH_DATA_EA_SIZE,             CONT_NAME},
+               {"DIRECTORY_INFO",      "FLAGS", RAW_SEARCH_DATA_DIRECTORY_INFO,      CONT_FLAGS},
+               {"DIRECTORY_INFO",      "KEY",   RAW_SEARCH_DATA_DIRECTORY_INFO,      CONT_RESUME_KEY},
+               {"DIRECTORY_INFO",      "NAME",  RAW_SEARCH_DATA_DIRECTORY_INFO,      CONT_NAME},
+               {"FULL_DIRECTORY_INFO",    "FLAGS", RAW_SEARCH_DATA_FULL_DIRECTORY_INFO,    CONT_FLAGS},
+               {"FULL_DIRECTORY_INFO",    "KEY",   RAW_SEARCH_DATA_FULL_DIRECTORY_INFO,    CONT_RESUME_KEY},
+               {"FULL_DIRECTORY_INFO",    "NAME",  RAW_SEARCH_DATA_FULL_DIRECTORY_INFO,    CONT_NAME},
+               {"ID_FULL_DIRECTORY_INFO", "FLAGS", RAW_SEARCH_DATA_ID_FULL_DIRECTORY_INFO, CONT_FLAGS},
+               {"ID_FULL_DIRECTORY_INFO", "KEY",   RAW_SEARCH_DATA_ID_FULL_DIRECTORY_INFO, CONT_RESUME_KEY},
+               {"ID_FULL_DIRECTORY_INFO", "NAME",  RAW_SEARCH_DATA_ID_FULL_DIRECTORY_INFO, CONT_NAME},
+               {"ID_BOTH_DIRECTORY_INFO", "NAME",  RAW_SEARCH_DATA_ID_BOTH_DIRECTORY_INFO, CONT_NAME},
+               {"ID_BOTH_DIRECTORY_INFO", "FLAGS", RAW_SEARCH_DATA_ID_BOTH_DIRECTORY_INFO, CONT_FLAGS},
+               {"ID_BOTH_DIRECTORY_INFO", "KEY",   RAW_SEARCH_DATA_ID_BOTH_DIRECTORY_INFO, CONT_RESUME_KEY}
        };
 
        if (!torture_setup_dir(cli, BASEDIR)) {
                return False;
        }
 
-       printf("Creating %d files\n", num_files);
+       printf("Testing with %d files\n", num_files);
 
        for (i=0;i<num_files;i++) {
-               asprintf(&fname, BASEDIR "\\t%03d-%d.txt", i, i);
+               fname = talloc_asprintf(cli, BASEDIR "\\t%03d-%d.txt", i, i);
                fnum = smbcli_open(cli->tree, fname, O_CREAT|O_RDWR, DENY_NONE);
                if (fnum == -1) {
                        printf("Failed to create %s - %s\n", fname, smbcli_errstr(cli->tree));
                        ret = False;
                        goto done;
                }
-               free(fname);
+               talloc_free(fname);
                smbcli_close(cli->tree, fnum);
        }
 
@@ -640,54 +751,40 @@ static BOOL test_many_files(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
                printf("Continue %s via %s\n", search_types[t].name, search_types[t].cont_name);
 
                status = multiple_search(cli, mem_ctx, BASEDIR "\\*.*", 
-                                        search_types[t].level,
+                                        search_types[t].data_level,
                                         search_types[t].cont_type,
                                         &result);
        
                if (!NT_STATUS_IS_OK(status)) {
-                       printf("search failed - %s\n", nt_errstr(status));
+                       printf("search type %s failed - %s\n", 
+                              search_types[t].name,
+                              nt_errstr(status));
                        ret = False;
                        continue;
                }
                CHECK_VALUE(result.count, num_files);
 
-               if (search_types[t].level == RAW_SEARCH_BOTH_DIRECTORY_INFO) {
-                       qsort(result.list, result.count, sizeof(result.list[0]), 
-                             QSORT_CAST  search_both_compare);
-               } else if (search_types[t].level == RAW_SEARCH_STANDARD) {
-                       qsort(result.list, result.count, sizeof(result.list[0]), 
-                             QSORT_CAST search_standard_compare);
-               } else if (search_types[t].level == RAW_SEARCH_EA_SIZE) {
-                       qsort(result.list, result.count, sizeof(result.list[0]), 
-                             QSORT_CAST search_ea_size_compare);
-               } else if (search_types[t].level == RAW_SEARCH_DIRECTORY_INFO) {
-                       qsort(result.list, result.count, sizeof(result.list[0]), 
-                             QSORT_CAST search_directory_info_compare);
-               } else {
-                       qsort(result.list, result.count, sizeof(result.list[0]), 
-                             QSORT_CAST search_old_compare);
-               }
+               compare_data_level = search_types[t].data_level;
+
+               qsort(result.list, result.count, sizeof(result.list[0]), 
+                     QSORT_CAST  search_compare);
 
                for (i=0;i<result.count;i++) {
                        const char *s;
-                       if (search_types[t].level == RAW_SEARCH_BOTH_DIRECTORY_INFO) {
-                               s = result.list[i].both_directory_info.name.s;
-                       } else if (search_types[t].level == RAW_SEARCH_STANDARD) {
-                               s = result.list[i].standard.name.s;
-                       } else if (search_types[t].level == RAW_SEARCH_EA_SIZE) {
-                               s = result.list[i].ea_size.name.s;
-                       } else if (search_types[t].level == RAW_SEARCH_DIRECTORY_INFO) {
-                               s = result.list[i].directory_info.name.s;
+                       enum smb_search_level level;
+                       if (compare_data_level == RAW_SEARCH_DATA_SEARCH) {
+                               level = RAW_SEARCH_SEARCH;
                        } else {
-                               s = result.list[i].search.name;
+                               level = RAW_SEARCH_TRANS2;
                        }
-                       asprintf(&fname, "t%03d-%d.txt", i, i);
+                       s = extract_name(&result.list[i], level, compare_data_level);
+                       fname = talloc_asprintf(cli, "t%03d-%d.txt", i, i);
                        if (strcmp(fname, s)) {
                                printf("Incorrect name %s at entry %d\n", s, i);
                                ret = False;
                                break;
                        }
-                       free(fname);
+                       talloc_free(fname);
                }
                talloc_free(result.mem_ctx);
        }
@@ -754,14 +851,14 @@ static BOOL test_modify_search(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        printf("Creating %d files\n", num_files);
 
        for (i=num_files-1;i>=0;i--) {
-               asprintf(&fname, BASEDIR "\\t%03d-%d.txt", i, i);
+               fname = talloc_asprintf(cli, BASEDIR "\\t%03d-%d.txt", i, i);
                fnum = smbcli_open(cli->tree, fname, O_CREAT|O_RDWR, DENY_NONE);
                if (fnum == -1) {
                        printf("Failed to create %s - %s\n", fname, smbcli_errstr(cli->tree));
                        ret = False;
                        goto done;
                }
-               free(fname);
+               talloc_free(fname);
                smbcli_close(cli->tree, fnum);
        }
 
@@ -769,7 +866,8 @@ static BOOL test_modify_search(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        ZERO_STRUCT(result);
        result.mem_ctx = talloc_new(mem_ctx);
 
-       io.generic.level = RAW_SEARCH_BOTH_DIRECTORY_INFO;
+       io.t2ffirst.level = RAW_SEARCH_TRANS2;
+       io.t2ffirst.data_level = RAW_SEARCH_DATA_BOTH_DIRECTORY_INFO;
        io.t2ffirst.in.search_attrib = 0;
        io.t2ffirst.in.max_count = 0;
        io.t2ffirst.in.flags = 0;
@@ -782,22 +880,21 @@ static BOOL test_modify_search(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        CHECK_VALUE(result.count, 1);
        
        printf("pulling the second file\n");
-       io2.generic.level = RAW_SEARCH_BOTH_DIRECTORY_INFO;
+       io2.t2fnext.level = RAW_SEARCH_TRANS2;
+       io2.t2fnext.data_level = RAW_SEARCH_DATA_BOTH_DIRECTORY_INFO;
        io2.t2fnext.in.handle = io.t2ffirst.out.handle;
        io2.t2fnext.in.max_count = 1;
        io2.t2fnext.in.resume_key = 0;
        io2.t2fnext.in.flags = 0;
-       if (result.count == 0) {
-               io2.t2fnext.in.last_name = "";
-       } else {
-               io2.t2fnext.in.last_name = result.list[result.count-1].both_directory_info.name.s;
-       }
+       io2.t2fnext.in.last_name = result.list[result.count-1].both_directory_info.name.s;
 
        status = smb_raw_search_next(cli->tree, mem_ctx,
                                     &io2, &result, multiple_search_callback);
        CHECK_STATUS(status, NT_STATUS_OK);
        CHECK_VALUE(result.count, 2);
 
+       result.count = 0;
+
        printf("Changing attributes and deleting\n");
        smbcli_open(cli->tree, BASEDIR "\\T003-03.txt.2", O_CREAT|O_RDWR, DENY_NONE);
        smbcli_open(cli->tree, BASEDIR "\\T013-13.txt.2", O_CREAT|O_RDWR, DENY_NONE);
@@ -808,22 +905,23 @@ static BOOL test_modify_search(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        torture_set_file_attribute(cli->tree, BASEDIR "\\T017-17.txt", FILE_ATTRIBUTE_SYSTEM);  
        torture_set_file_attribute(cli->tree, BASEDIR "\\T018-18.txt", 0);      
        sfinfo.generic.level = RAW_SFILEINFO_DISPOSITION_INFORMATION;
-       sfinfo.generic.file.fnum = fnum;
+       sfinfo.generic.in.file.fnum = fnum;
        sfinfo.disposition_info.in.delete_on_close = 1;
        status = smb_raw_setfileinfo(cli->tree, &sfinfo);
        CHECK_STATUS(status, NT_STATUS_OK);
 
-       io2.generic.level = RAW_SEARCH_BOTH_DIRECTORY_INFO;
+       io2.t2fnext.level = RAW_SEARCH_TRANS2;
+       io2.t2fnext.data_level = RAW_SEARCH_DATA_BOTH_DIRECTORY_INFO;
        io2.t2fnext.in.handle = io.t2ffirst.out.handle;
-       io2.t2fnext.in.max_count = num_files - 1;
+       io2.t2fnext.in.max_count = num_files + 3;
        io2.t2fnext.in.resume_key = 0;
        io2.t2fnext.in.flags = 0;
-       io2.t2fnext.in.last_name = result.list[result.count-2].both_directory_info.name.s;
+       io2.t2fnext.in.last_name = ".";
 
        status = smb_raw_search_next(cli->tree, mem_ctx,
                                     &io2, &result, multiple_search_callback);
        CHECK_STATUS(status, NT_STATUS_OK);
-       CHECK_VALUE(result.count, 21);
+       CHECK_VALUE(result.count, 20);
 
        ret &= check_result(&result, "t009-9.txt", True, FILE_ATTRIBUTE_ARCHIVE);
        ret &= check_result(&result, "t014-14.txt", False, 0);
@@ -872,14 +970,14 @@ static BOOL test_sorted(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        printf("Creating %d files\n", num_files);
 
        for (i=0;i<num_files;i++) {
-               asprintf(&fname, BASEDIR "\\%s.txt", generate_random_str_list(mem_ctx, 10, "abcdefgh"));
+               fname = talloc_asprintf(cli, BASEDIR "\\%s.txt", generate_random_str_list(mem_ctx, 10, "abcdefgh"));
                fnum = smbcli_open(cli->tree, fname, O_CREAT|O_RDWR, DENY_NONE);
                if (fnum == -1) {
                        printf("Failed to create %s - %s\n", fname, smbcli_errstr(cli->tree));
                        ret = False;
                        goto done;
                }
-               free(fname);
+               talloc_free(fname);
                smbcli_close(cli->tree, fnum);
        }
 
@@ -888,7 +986,7 @@ static BOOL test_sorted(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        result.mem_ctx = mem_ctx;
        
        status = multiple_search(cli, mem_ctx, BASEDIR "\\*.*", 
-                                RAW_SEARCH_BOTH_DIRECTORY_INFO,
+                                RAW_SEARCH_DATA_BOTH_DIRECTORY_INFO,
                                 CONT_NAME, &result);   
        CHECK_STATUS(status, NT_STATUS_OK);
        CHECK_VALUE(result.count, num_files);
@@ -897,7 +995,7 @@ static BOOL test_sorted(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
                const char *name1, *name2;
                name1 = result.list[i].both_directory_info.name.s;
                name2 = result.list[i+1].both_directory_info.name.s;
-               if (StrCaseCmp(name1, name2) > 0) {
+               if (strcasecmp_m(name1, name2) > 0) {
                        printf("non-alphabetical order at entry %d  '%s' '%s'\n", 
                               i, name1, name2);
                        printf("Server does not produce sorted directory listings (not an error)\n");
@@ -921,7 +1019,7 @@ done:
 */
 static BOOL test_many_dirs(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
 {
-       const int num_dirs = 300;
+       const int num_dirs = 20;
        int i, fnum, n;
        char *fname, *dname;
        BOOL ret = True;
@@ -935,7 +1033,7 @@ static BOOL test_many_dirs(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        printf("Creating %d dirs\n", num_dirs);
 
        for (i=0;i<num_dirs;i++) {
-               asprintf(&dname, BASEDIR "\\d%d", i);
+               dname = talloc_asprintf(cli, BASEDIR "\\d%d", i);
                status = smbcli_mkdir(cli->tree, dname);
                if (!NT_STATUS_IS_OK(status)) {
                        printf("(%s) Failed to create %s - %s\n", 
@@ -945,7 +1043,7 @@ static BOOL test_many_dirs(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
                }
 
                for (n=0;n<3;n++) {
-                       asprintf(&fname, BASEDIR "\\d%d\\f%d-%d.txt", i, i, n);
+                       fname = talloc_asprintf(cli, BASEDIR "\\d%d\\f%d-%d.txt", i, i, n);
                        fnum = smbcli_open(cli->tree, fname, O_CREAT|O_RDWR, DENY_NONE);
                        if (fnum == -1) {
                                printf("(%s) Failed to create %s - %s\n", 
@@ -953,11 +1051,11 @@ static BOOL test_many_dirs(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
                                ret = False;
                                goto done;
                        }
-                       free(fname);
+                       talloc_free(fname);
+                       smbcli_close(cli->tree, fnum);
                }
 
-               free(dname);
-               smbcli_close(cli->tree, fnum);
+               talloc_free(dname);
        }
 
        file  = talloc_zero_array(mem_ctx, union smb_search_data, num_dirs);
@@ -968,7 +1066,8 @@ static BOOL test_many_dirs(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
 
        for (i=0;i<num_dirs;i++) {
                union smb_search_first io;
-               io.generic.level = RAW_SEARCH_SEARCH;
+               io.search_first.level = RAW_SEARCH_SEARCH;
+               io.search_first.data_level = RAW_SEARCH_DATA_SEARCH;
                io.search_first.in.max_count = 1;
                io.search_first.in.search_attrib = 0;
                io.search_first.in.pattern = talloc_asprintf(mem_ctx, BASEDIR "\\d%d\\*.txt", i);
@@ -1000,7 +1099,8 @@ static BOOL test_many_dirs(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        for (i=0;i<num_dirs;i++) {
                union smb_search_next io2;
 
-               io2.generic.level = RAW_SEARCH_SEARCH;
+               io2.search_next.level = RAW_SEARCH_SEARCH;
+               io2.search_next.data_level = RAW_SEARCH_DATA_SEARCH;
                io2.search_next.in.max_count = 1;
                io2.search_next.in.search_attrib = 0;
                io2.search_next.in.id = file[i].search.id;
@@ -1033,7 +1133,8 @@ static BOOL test_many_dirs(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        for (i=0;i<num_dirs;i++) {
                union smb_search_next io2;
 
-               io2.generic.level = RAW_SEARCH_SEARCH;
+               io2.search_next.level = RAW_SEARCH_SEARCH;
+               io2.search_next.data_level = RAW_SEARCH_DATA_SEARCH;
                io2.search_next.in.max_count = 1;
                io2.search_next.in.search_attrib = 0;
                io2.search_next.in.id = file[i].search.id;
@@ -1099,14 +1200,14 @@ static BOOL test_os2_delete(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        printf("Testing OS/2 style delete on %d files\n", num_files);
 
        for (i=0;i<num_files;i++) {
-               asprintf(&fname, BASEDIR "\\file%u.txt", i);
+               fname = talloc_asprintf(cli, BASEDIR "\\file%u.txt", i);
                fnum = smbcli_open(cli->tree, fname, O_CREAT|O_RDWR, DENY_NONE);
                if (fnum == -1) {
                        printf("Failed to create %s - %s\n", fname, smbcli_errstr(cli->tree));
                        ret = False;
                        goto done;
                }
-               free(fname);
+               talloc_free(fname);
                smbcli_close(cli->tree, fnum);
        }
 
@@ -1114,7 +1215,8 @@ static BOOL test_os2_delete(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        ZERO_STRUCT(result);
        result.mem_ctx = mem_ctx;
 
-       io.t2ffirst.level = RAW_SEARCH_EA_SIZE;
+       io.t2ffirst.level = RAW_SEARCH_TRANS2;
+       io.t2ffirst.data_level = RAW_SEARCH_DATA_EA_SIZE;
        io.t2ffirst.in.search_attrib = 0;
        io.t2ffirst.in.max_count = 100;
        io.t2ffirst.in.flags = FLAG_TRANS2_FIND_REQUIRE_RESUME;
@@ -1126,13 +1228,15 @@ static BOOL test_os2_delete(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        CHECK_STATUS(status, NT_STATUS_OK);
 
        for (i=0;i<MIN(result.count, delete_count);i++) {
-               asprintf(&fname, BASEDIR "\\%s", result.list[i].ea_size.name.s);
+               fname = talloc_asprintf(cli, BASEDIR "\\%s", result.list[i].ea_size.name.s);
                status = smbcli_unlink(cli->tree, fname);
                CHECK_STATUS(status, NT_STATUS_OK);
                total_deleted++;
+               talloc_free(fname);
        }
 
-       io2.t2fnext.level = RAW_SEARCH_EA_SIZE;
+       io2.t2fnext.level = RAW_SEARCH_TRANS2;
+       io2.t2fnext.data_level = RAW_SEARCH_DATA_EA_SIZE;
        io2.t2fnext.in.handle = io.t2ffirst.out.handle;
        io2.t2fnext.in.max_count = 100;
        io2.t2fnext.in.resume_key = result.list[i-1].ea_size.resume_key;
@@ -1150,10 +1254,11 @@ static BOOL test_os2_delete(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
                }
 
                for (i=0;i<MIN(result.count, delete_count);i++) {
-                       asprintf(&fname, BASEDIR "\\%s", result.list[i].ea_size.name.s);
+                       fname = talloc_asprintf(cli, BASEDIR "\\%s", result.list[i].ea_size.name.s);
                        status = smbcli_unlink(cli->tree, fname);
                        CHECK_STATUS(status, NT_STATUS_OK);
                        total_deleted++;
+                       talloc_free(fname);
                }
 
                if (i>0) {
@@ -1178,6 +1283,11 @@ done:
 }
 
 
+static int ealist_cmp(union smb_search_data *r1, union smb_search_data *r2)
+{
+       return strcmp(r1->ea_list.name.s, r2->ea_list.name.s);
+}
+
 /* 
    testing of the rather strange ea_list level
 */
@@ -1207,9 +1317,9 @@ static BOOL test_ea_list(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        smbcli_close(cli->tree, fnum);
 
        setfile.generic.level = RAW_SFILEINFO_EA_SET;
-       setfile.generic.file.fname = BASEDIR "\\file2.txt";
+       setfile.generic.in.file.path = BASEDIR "\\file2.txt";
        setfile.ea_set.in.num_eas = 2;
-       setfile.ea_set.in.eas = talloc_array_p(mem_ctx, struct ea_struct, 2);
+       setfile.ea_set.in.eas = talloc_array(mem_ctx, struct ea_struct, 2);
        setfile.ea_set.in.eas[0].flags = 0;
        setfile.ea_set.in.eas[0].name.s = "EA ONE";
        setfile.ea_set.in.eas[0].value = data_blob_string_const("VALUE 1");
@@ -1220,21 +1330,22 @@ static BOOL test_ea_list(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        status = smb_raw_setpathinfo(cli->tree, &setfile);
        CHECK_STATUS(status, NT_STATUS_OK);
 
-       setfile.generic.file.fname = BASEDIR "\\file3.txt";
+       setfile.generic.in.file.path = BASEDIR "\\file3.txt";
        status = smb_raw_setpathinfo(cli->tree, &setfile);
        CHECK_STATUS(status, NT_STATUS_OK);
        
        ZERO_STRUCT(result);
        result.mem_ctx = mem_ctx;
 
-       io.t2ffirst.level = RAW_SEARCH_EA_LIST;
+       io.t2ffirst.level = RAW_SEARCH_TRANS2;
+       io.t2ffirst.data_level = RAW_SEARCH_DATA_EA_LIST;
        io.t2ffirst.in.search_attrib = 0;
        io.t2ffirst.in.max_count = 2;
        io.t2ffirst.in.flags = FLAG_TRANS2_FIND_REQUIRE_RESUME;
        io.t2ffirst.in.storage_type = 0;
        io.t2ffirst.in.pattern = BASEDIR "\\*";
        io.t2ffirst.in.num_names = 2;
-       io.t2ffirst.in.ea_names = talloc_array_p(mem_ctx, struct ea_name, 2);
+       io.t2ffirst.in.ea_names = talloc_array(mem_ctx, struct ea_name, 2);
        io.t2ffirst.in.ea_names[0].name.s = "SECOND EA";
        io.t2ffirst.in.ea_names[1].name.s = "THIRD EA";
 
@@ -1243,14 +1354,15 @@ static BOOL test_ea_list(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        CHECK_STATUS(status, NT_STATUS_OK);
        CHECK_VALUE(result.count, 2);
 
-       nxt.t2fnext.level = RAW_SEARCH_EA_LIST;
+       nxt.t2fnext.level = RAW_SEARCH_TRANS2;
+       nxt.t2fnext.data_level = RAW_SEARCH_DATA_EA_LIST;
        nxt.t2fnext.in.handle = io.t2ffirst.out.handle;
        nxt.t2fnext.in.max_count = 2;
        nxt.t2fnext.in.resume_key = result.list[1].ea_list.resume_key;
        nxt.t2fnext.in.flags = FLAG_TRANS2_FIND_REQUIRE_RESUME | FLAG_TRANS2_FIND_CONTINUE;
-       nxt.t2fnext.in.last_name = "file2.txt";
+       nxt.t2fnext.in.last_name = result.list[1].ea_list.name.s;
        nxt.t2fnext.in.num_names = 2;
-       nxt.t2fnext.in.ea_names = talloc_array_p(mem_ctx, struct ea_name, 2);
+       nxt.t2fnext.in.ea_names = talloc_array(mem_ctx, struct ea_name, 2);
        nxt.t2fnext.in.ea_names[0].name.s = "SECOND EA";
        nxt.t2fnext.in.ea_names[1].name.s = "THIRD EA";
 
@@ -1258,6 +1370,10 @@ static BOOL test_ea_list(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
                                     &nxt, &result, multiple_search_callback);
        CHECK_STATUS(status, NT_STATUS_OK);
 
+       /* we have to sort the result as different servers can return directories
+          in different orders */
+       qsort(result.list, result.count, sizeof(result.list[0]), 
+             (comparison_fn_t)ealist_cmp);
 
        CHECK_VALUE(result.count, 3);
        CHECK_VALUE(result.list[0].ea_list.eas.num_eas, 2);
@@ -1270,14 +1386,14 @@ static BOOL test_ea_list(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        CHECK_STRING(result.list[1].ea_list.name.s, "file2.txt");
        CHECK_STRING(result.list[1].ea_list.eas.eas[0].name.s, "SECOND EA");
        CHECK_VALUE(result.list[1].ea_list.eas.eas[0].value.length, 9);
-       CHECK_STRING(result.list[1].ea_list.eas.eas[0].value.data, "Value Two");
+       CHECK_STRING((const char *)result.list[1].ea_list.eas.eas[0].value.data, "Value Two");
        CHECK_STRING(result.list[1].ea_list.eas.eas[1].name.s, "THIRD EA");
        CHECK_VALUE(result.list[1].ea_list.eas.eas[1].value.length, 0);
 
        CHECK_STRING(result.list[2].ea_list.name.s, "file3.txt");
        CHECK_STRING(result.list[2].ea_list.eas.eas[0].name.s, "SECOND EA");
        CHECK_VALUE(result.list[2].ea_list.eas.eas[0].value.length, 9);
-       CHECK_STRING(result.list[2].ea_list.eas.eas[0].value.data, "Value Two");
+       CHECK_STRING((const char *)result.list[2].ea_list.eas.eas[0].value.data, "Value Two");
        CHECK_STRING(result.list[2].ea_list.eas.eas[1].name.s, "THIRD EA");
        CHECK_VALUE(result.list[2].ea_list.eas.eas[1].value.length, 0);
 
@@ -1293,13 +1409,13 @@ done:
 /* 
    basic testing of all RAW_SEARCH_* calls using a single file
 */
-BOOL torture_raw_search(void)
+BOOL torture_raw_search(struct torture_context *torture)
 {
        struct smbcli_state *cli;
        BOOL ret = True;
        TALLOC_CTX *mem_ctx;
 
-       if (!torture_open_connection(&cli)) {
+       if (!torture_open_connection(&cli, 0)) {
                return False;
        }
 
@@ -1314,7 +1430,7 @@ BOOL torture_raw_search(void)
        ret &= test_ea_list(cli, mem_ctx);
 
        torture_close_connection(cli);
-       talloc_destroy(mem_ctx);
+       talloc_free(mem_ctx);
        
        return ret;
 }