s4:dsdb Ensure we free old schema copies
[samba.git] / source4 / dsdb / schema / schema_set.c
index e8fe7c4c65098f1913fe886ca7d704c6a82ae253..da5ad3ce9248e50737835dc8afbee922bc73ae2b 100644 (file)
@@ -83,7 +83,7 @@ static int dsdb_schema_set_attributes(struct ldb_context *ldb, struct dsdb_schem
                ldb_oom(ldb);
                goto op_error;
        }
-       msg_idx->dn = ldb_dn_new(msg, ldb, "@INDEXLIST");
+       msg_idx->dn = ldb_dn_new(msg_idx, ldb, "@INDEXLIST");
        if (!msg_idx->dn) {
                ldb_oom(ldb);
                goto op_error;
@@ -140,6 +140,7 @@ static int dsdb_schema_set_attributes(struct ldb_context *ldb, struct dsdb_schem
                if (mod_msg->num_elements > 0) {
                        ret = dsdb_replace(ldb, mod_msg, 0);
                }
+               talloc_free(mod_msg);
        }
 
        if (ret == LDB_ERR_OPERATIONS_ERROR || ret == LDB_ERR_INSUFFICIENT_ACCESS_RIGHTS || ret == LDB_ERR_INVALID_DN_SYNTAX) {
@@ -168,6 +169,7 @@ static int dsdb_schema_set_attributes(struct ldb_context *ldb, struct dsdb_schem
                if (mod_msg->num_elements > 0) {
                        ret = dsdb_replace(ldb, mod_msg, 0);
                }
+               talloc_free(mod_msg);
        }
        if (ret == LDB_ERR_OPERATIONS_ERROR || ret == LDB_ERR_INSUFFICIENT_ACCESS_RIGHTS || ret == LDB_ERR_INVALID_DN_SYNTAX) {
                /* We might be on a read-only DB */
@@ -221,6 +223,24 @@ static int dsdb_compare_attribute_by_linkID(struct dsdb_attribute **a1, struct d
        return uint32_cmp((*a1)->linkID, (*a2)->linkID);
 }
 
+/**
+ * Clean up Classes and Attributes accessor arrays
+ */
+static void dsdb_sorted_accessors_free(struct dsdb_schema *schema)
+{
+       /* free classes accessors */
+       TALLOC_FREE(schema->classes_by_lDAPDisplayName);
+       TALLOC_FREE(schema->classes_by_governsID_id);
+       TALLOC_FREE(schema->classes_by_governsID_oid);
+       TALLOC_FREE(schema->classes_by_cn);
+       /* free attribute accessors */
+       TALLOC_FREE(schema->attributes_by_lDAPDisplayName);
+       TALLOC_FREE(schema->attributes_by_attributeID_id);
+       TALLOC_FREE(schema->attributes_by_msDS_IntId);
+       TALLOC_FREE(schema->attributes_by_attributeID_oid);
+       TALLOC_FREE(schema->attributes_by_linkID);
+}
+
 /*
   create the sorted accessor arrays for the schema
  */
@@ -230,11 +250,10 @@ static int dsdb_setup_sorted_accessors(struct ldb_context *ldb,
        struct dsdb_class *cur;
        struct dsdb_attribute *a;
        unsigned int i;
+       unsigned int num_int_id;
 
-       talloc_free(schema->classes_by_lDAPDisplayName);
-       talloc_free(schema->classes_by_governsID_id);
-       talloc_free(schema->classes_by_governsID_oid);
-       talloc_free(schema->classes_by_cn);
+       /* free all caches */
+       dsdb_sorted_accessors_free(schema);
 
        /* count the classes */
        for (i=0, cur=schema->classes; cur; i++, cur=cur->next) /* noop */ ;
@@ -266,51 +285,58 @@ static int dsdb_setup_sorted_accessors(struct ldb_context *ldb,
        TYPESAFE_QSORT(schema->classes_by_cn, schema->num_classes, dsdb_compare_class_by_cn);
 
        /* now build the attribute accessor arrays */
-       talloc_free(schema->attributes_by_lDAPDisplayName);
-       talloc_free(schema->attributes_by_attributeID_id);
-       talloc_free(schema->attributes_by_attributeID_oid);
-       talloc_free(schema->attributes_by_linkID);
 
-       /* count the attributes */
-       for (i=0, a=schema->attributes; a; i++, a=a->next) /* noop */ ;
+       /* count the attributes
+        * and attributes with msDS-IntId set */
+       num_int_id = 0;
+       for (i=0, a=schema->attributes; a; i++, a=a->next) {
+               if (a->msDS_IntId != 0) {
+                       num_int_id++;
+               }
+       }
        schema->num_attributes = i;
+       schema->num_int_id_attr = num_int_id;
 
        /* setup attributes_by_* */
        schema->attributes_by_lDAPDisplayName = talloc_array(schema, struct dsdb_attribute *, i);
        schema->attributes_by_attributeID_id    = talloc_array(schema, struct dsdb_attribute *, i);
+       schema->attributes_by_msDS_IntId        = talloc_array(schema,
+                                                              struct dsdb_attribute *, num_int_id);
        schema->attributes_by_attributeID_oid   = talloc_array(schema, struct dsdb_attribute *, i);
        schema->attributes_by_linkID              = talloc_array(schema, struct dsdb_attribute *, i);
        if (schema->attributes_by_lDAPDisplayName == NULL ||
            schema->attributes_by_attributeID_id == NULL ||
+           schema->attributes_by_msDS_IntId == NULL ||
            schema->attributes_by_attributeID_oid == NULL ||
            schema->attributes_by_linkID == NULL) {
                goto failed;
        }
 
+       num_int_id = 0;
        for (i=0, a=schema->attributes; a; i++, a=a->next) {
                schema->attributes_by_lDAPDisplayName[i] = a;
                schema->attributes_by_attributeID_id[i]    = a;
                schema->attributes_by_attributeID_oid[i]   = a;
                schema->attributes_by_linkID[i]          = a;
+               /* append attr-by-msDS-IntId values */
+               if (a->msDS_IntId != 0) {
+                       schema->attributes_by_msDS_IntId[num_int_id] = a;
+                       num_int_id++;
+               }
        }
+       SMB_ASSERT(num_int_id == schema->num_int_id_attr);
 
        /* sort the arrays */
        TYPESAFE_QSORT(schema->attributes_by_lDAPDisplayName, schema->num_attributes, dsdb_compare_attribute_by_lDAPDisplayName);
        TYPESAFE_QSORT(schema->attributes_by_attributeID_id, schema->num_attributes, dsdb_compare_attribute_by_attributeID_id);
+       TYPESAFE_QSORT(schema->attributes_by_msDS_IntId, schema->num_int_id_attr, dsdb_compare_attribute_by_attributeID_id);
        TYPESAFE_QSORT(schema->attributes_by_attributeID_oid, schema->num_attributes, dsdb_compare_attribute_by_attributeID_oid);
        TYPESAFE_QSORT(schema->attributes_by_linkID, schema->num_attributes, dsdb_compare_attribute_by_linkID);
 
        return LDB_SUCCESS;
 
 failed:
-       schema->classes_by_lDAPDisplayName = NULL;
-       schema->classes_by_governsID_id = NULL;
-       schema->classes_by_governsID_oid = NULL;
-       schema->classes_by_cn = NULL;
-       schema->attributes_by_lDAPDisplayName = NULL;
-       schema->attributes_by_attributeID_id = NULL;
-       schema->attributes_by_attributeID_oid = NULL;
-       schema->attributes_by_linkID = NULL;
+       dsdb_sorted_accessors_free(schema);
        ldb_oom(ldb);
        return LDB_ERR_OPERATIONS_ERROR;
 }
@@ -340,6 +366,7 @@ int dsdb_setup_schema_inversion(struct ldb_context *ldb, struct dsdb_schema *sch
 
 int dsdb_set_schema(struct ldb_context *ldb, struct dsdb_schema *schema)
 {
+       struct dsdb_schema *old_schema;
        int ret;
 
        ret = dsdb_setup_sorted_accessors(ldb, schema);
@@ -352,10 +379,22 @@ int dsdb_set_schema(struct ldb_context *ldb, struct dsdb_schema *schema)
                return ret;
        }
 
+       old_schema = ldb_get_opaque(ldb, "dsdb_schema");
+
        ret = ldb_set_opaque(ldb, "dsdb_schema", schema);
        if (ret != LDB_SUCCESS) {
                return ret;
        }
+       /* Remove the refernece to the schema we just overwrote - if there was none, NULL is harmless here */
+       if (old_schema != schema) {
+               talloc_unlink(ldb, old_schema);
+               talloc_steal(ldb, schema);
+       }
+
+       ret = ldb_set_opaque(ldb, "dsdb_use_global_schema", NULL);
+       if (ret != LDB_SUCCESS) {
+               return ret;
+       }
 
        /* Set the new attributes based on the new schema */
        ret = dsdb_schema_set_attributes(ldb, schema, true);
@@ -363,8 +402,6 @@ int dsdb_set_schema(struct ldb_context *ldb, struct dsdb_schema *schema)
                return ret;
        }
 
-       talloc_steal(ldb, schema);
-
        return LDB_SUCCESS;
 }
 
@@ -380,22 +417,25 @@ int dsdb_reference_schema(struct ldb_context *ldb, struct dsdb_schema *schema,
                          bool write_attributes)
 {
        int ret;
+       struct dsdb_schema *old_schema;
+       old_schema = ldb_get_opaque(ldb, "dsdb_schema");
        ret = ldb_set_opaque(ldb, "dsdb_schema", schema);
        if (ret != LDB_SUCCESS) {
                return ret;
        }
 
-       /* Set the new attributes based on the new schema */
-       ret = dsdb_schema_set_attributes(ldb, schema, write_attributes);
-       if (ret != LDB_SUCCESS) {
-               return ret;
-       }
+       /* Remove the refernece to the schema we just overwrote - if there was none, NULL is harmless here */
+       talloc_unlink(ldb, old_schema);
 
-       /* Keep a reference to this schema, just incase the original copy is replaced */
        if (talloc_reference(ldb, schema) == NULL) {
                return LDB_ERR_OPERATIONS_ERROR;
        }
 
+       ret = dsdb_schema_set_attributes(ldb, schema, write_attributes);
+       if (ret != LDB_SUCCESS) {
+               return ret;
+       }
+
        return LDB_SUCCESS;
 }
 
@@ -404,11 +444,26 @@ int dsdb_reference_schema(struct ldb_context *ldb, struct dsdb_schema *schema,
  */
 int dsdb_set_global_schema(struct ldb_context *ldb)
 {
+       int ret;
+       void *use_global_schema = (void *)1;
        if (!global_schema) {
                return LDB_SUCCESS;
        }
+       ret = ldb_set_opaque(ldb, "dsdb_use_global_schema", use_global_schema);
+       if (ret != LDB_SUCCESS) {
+               return ret;
+       }
 
-       return dsdb_reference_schema(ldb, global_schema, false /* Don't write attributes, it's expensive */);
+       /* Set the new attributes based on the new schema */
+       ret = dsdb_schema_set_attributes(ldb, global_schema, false /* Don't write attributes, it's expensive */);
+       if (ret == LDB_SUCCESS) {
+               /* Keep a reference to this schema, just incase the original copy is replaced */
+               if (talloc_reference(ldb, global_schema) == NULL) {
+                       return LDB_ERR_OPERATIONS_ERROR;
+               }
+       }
+
+       return ret;
 }
 
 /**
@@ -420,23 +475,50 @@ int dsdb_set_global_schema(struct ldb_context *ldb)
 struct dsdb_schema *dsdb_get_schema(struct ldb_context *ldb, TALLOC_CTX *reference_ctx)
 {
        const void *p;
-       struct dsdb_schema *schema;
+       struct dsdb_schema *schema_out;
+       struct dsdb_schema *schema_in;
+       bool use_global_schema;
+       TALLOC_CTX *tmp_ctx = talloc_new(reference_ctx);
+       if (!tmp_ctx) {
+               return NULL;
+       }
 
        /* see if we have a cached copy */
-       p = ldb_get_opaque(ldb, "dsdb_schema");
-       if (!p) {
-               return NULL;
+       use_global_schema = (ldb_get_opaque(ldb, "dsdb_use_global_schema") != NULL);
+       if (use_global_schema) {
+               schema_in = global_schema;
+       } else {
+               p = ldb_get_opaque(ldb, "dsdb_schema");
+
+               schema_in = talloc_get_type(p, struct dsdb_schema);
+               if (!schema_in) {
+                       talloc_free(tmp_ctx);
+                       return NULL;
+               }
        }
 
-       schema = talloc_get_type(p, struct dsdb_schema);
-       if (!schema) {
-               return NULL;
+       if (schema_in->refresh_fn && !schema_in->refresh_in_progress) {
+               if (!talloc_reference(tmp_ctx, schema_in)) {
+                       /* ensure that the schema_in->refresh_in_progress remains valid for the right amount of time */
+                       talloc_free(tmp_ctx);
+                       return NULL;
+               }
+               schema_in->refresh_in_progress = true;
+               /* This may change schema, if it needs to reload it from disk */
+               schema_out = schema_in->refresh_fn(schema_in->loaded_from_module,
+                                                  schema_in,
+                                                  use_global_schema);
+               schema_in->refresh_in_progress = false;
+       } else {
+               schema_out = schema_in;
        }
 
+       /* This removes the extra reference above */
+       talloc_free(tmp_ctx);
        if (!reference_ctx) {
-               return schema;
+               return schema_out;
        } else {
-               return talloc_reference(reference_ctx, schema);
+               return talloc_reference(reference_ctx, schema_out);
        }
 }
 
@@ -444,9 +526,8 @@ struct dsdb_schema *dsdb_get_schema(struct ldb_context *ldb, TALLOC_CTX *referen
  * Make the schema found on this ldb the 'global' schema
  */
 
-void dsdb_make_schema_global(struct ldb_context *ldb)
+void dsdb_make_schema_global(struct ldb_context *ldb, struct dsdb_schema *schema)
 {
-       struct dsdb_schema *schema = dsdb_get_schema(ldb, NULL);
        if (!schema) {
                return;
        }
@@ -455,11 +536,14 @@ void dsdb_make_schema_global(struct ldb_context *ldb)
                talloc_unlink(talloc_autofree_context(), global_schema);
        }
 
-       /* we want the schema to be around permanently */
-       talloc_reparent(talloc_parent(schema), talloc_autofree_context(), schema);
+       /* Wipe any reference to the exact schema - we will set 'use the global schema' below */
+       ldb_set_opaque(ldb, "dsdb_schema", NULL);
 
+       /* we want the schema to be around permanently */
+       talloc_reparent(ldb, talloc_autofree_context(), schema);
        global_schema = schema;
 
+       /* This calls the talloc_reference() of the global schema back onto the ldb */
        dsdb_set_global_schema(ldb);
 }
 
@@ -510,24 +594,11 @@ int dsdb_schema_fill_extended_dn(struct ldb_context *ldb, struct dsdb_schema *sc
 WERROR dsdb_schema_set_el_from_ldb_msg(struct ldb_context *ldb, struct dsdb_schema *schema, 
                                       struct ldb_message *msg) 
 {
-       static struct ldb_parse_tree *attr_tree, *class_tree;
-       if (!attr_tree) {
-               attr_tree = ldb_parse_tree(talloc_autofree_context(), "(objectClass=attributeSchema)");
-               if (!attr_tree) {
-                       return WERR_NOMEM;
-               }
-       }
-
-       if (!class_tree) {
-               class_tree = ldb_parse_tree(talloc_autofree_context(), "(objectClass=classSchema)");
-               if (!class_tree) {
-                       return WERR_NOMEM;
-               }
-       }
-
-       if (ldb_match_msg(ldb, msg, attr_tree, NULL, LDB_SCOPE_BASE)) {
+       if (samdb_find_attribute(ldb, msg,
+                                "objectclass", "attributeSchema") != NULL) {
                return dsdb_attribute_from_ldb(ldb, schema, msg);
-       } else if (ldb_match_msg(ldb, msg, class_tree, NULL, LDB_SCOPE_BASE)) {
+       } else if (samdb_find_attribute(ldb, msg,
+                                "objectclass", "classSchema") != NULL) {
                return dsdb_class_from_ldb(schema, msg);
        }
 
@@ -559,7 +630,7 @@ WERROR dsdb_set_schema_from_ldif(struct ldb_context *ldb, const char *pf, const
                goto nomem;
        }
 
-       schema = dsdb_new_schema(mem_ctx, lp_iconv_convenience(ldb_get_opaque(ldb, "loadparm")));
+       schema = dsdb_new_schema(mem_ctx);
 
        schema->fsmo.we_are_master = true;
        schema->fsmo.master_dn = ldb_dn_new_fmt(schema, ldb, "@PROVISION_SCHEMA_MASTER");
@@ -592,15 +663,14 @@ WERROR dsdb_set_schema_from_ldif(struct ldb_context *ldb, const char *pf, const
 
        info_val = ldb_msg_find_ldb_val(msg, "schemaInfo");
        if (!info_val) {
-               info_val_default = strhex_to_data_blob(mem_ctx, "FF0000000000000000000000000000000000000000");
-               if (!info_val_default.data) {
-                       goto nomem;
-               }
+               status = dsdb_schema_info_blob_new(mem_ctx, &info_val_default);
+               W_ERROR_NOT_OK_GOTO(status, failed);
                info_val = &info_val_default;
        }
 
        status = dsdb_load_oid_mappings_ldb(schema, prefix_val, info_val);
        if (!W_ERROR_IS_OK(status)) {
+               DEBUG(0,("ERROR: dsdb_load_oid_mappings_ldb() failed with %s\n", win_errstr(status)));
                goto failed;
        }