CVE-2022-32746 ldb: Make use of functions for appending to an ldb_message

[samba.git] / source4 / dsdb / samdb / ldb_modules / descriptor.c

diff --git a/source4/dsdb/samdb/ldb_modules/descriptor.c b/source4/dsdb/samdb/ldb_modules/descriptor.c
index daa08c2ebc77a5566114ea58f5d36fe973b35cbf..4b01961dcb025985c1b790802cc44b5c47bf1973 100644 (file)
--- a/source4/dsdb/samdb/ldb_modules/descriptor.c
+++ b/source4/dsdb/samdb/ldb_modules/descriptor.c
@@ -857,14 +857,8 @@ static int descriptor_modify(struct ldb_module *module, struct ldb_request *req)
                        return ldb_module_done(req, NULL, NULL, LDB_SUCCESS);
                }
 
-               ret = ldb_msg_add_empty(msg, "nTSecurityDescriptor",
-                                       LDB_FLAG_MOD_REPLACE,
-                                       &sd_element);
-               if (ret != LDB_SUCCESS) {
-                       return ldb_oom(ldb);
-               }
-               ret = ldb_msg_add_value(msg, "nTSecurityDescriptor",
-                                       sd, NULL);
+               ret = ldb_msg_append_value(msg, "nTSecurityDescriptor",
+                                          sd, LDB_FLAG_MOD_REPLACE);
                if (ret != LDB_SUCCESS) {
                        return ldb_oom(ldb);
                }