r11452: Update Heimdal to current lorikeet, including removing the ccache side
[gd/samba-autobuild/.git] / source4 / auth / gensec / gensec_gssapi.c
index 0a98b69f8294b4516c3bbd8ec1e9bf91bc25d6ea..4608b62db5fe797ad81dcd31565b2caa958b1b53 100644 (file)
@@ -29,9 +29,6 @@
 #include "librpc/gen_ndr/ndr_krb5pac.h"
 #include "auth/auth.h"
 
-#undef DBGC_CLASS
-#define DBGC_CLASS DBGC_AUTH
-
 struct gensec_gssapi_state {
        gss_ctx_id_t gssapi_context;
        struct gss_channel_bindings_struct *input_chan_bindings;
@@ -46,9 +43,11 @@ struct gensec_gssapi_state {
        struct smb_krb5_context *smb_krb5_context;
        krb5_ccache ccache;
        const char *ccache_name;
-       krb5_keytab keytab;
+       struct keytab_container *keytab;
+       struct gssapi_creds_container *client_cred;
 
        gss_cred_id_t cred;
+       gss_cred_id_t delegated_cred_handle;
 };
 
 static char *gssapi_error_string(TALLOC_CTX *mem_ctx, 
@@ -86,6 +85,10 @@ static int gensec_gssapi_destory(void *ptr)
                maj_stat = gss_release_cred(&min_stat, 
                                            &gensec_gssapi_state->cred);
        }
+       if (gensec_gssapi_state->delegated_cred_handle != GSS_C_NO_CREDENTIAL) {
+               maj_stat = gss_release_cred(&min_stat, 
+                                           &gensec_gssapi_state->delegated_cred_handle);
+       }
 
        if (gensec_gssapi_state->gssapi_context != GSS_C_NO_CONTEXT) {
                maj_stat = gss_delete_sec_context (&min_stat,
@@ -121,24 +124,17 @@ static NTSTATUS gensec_gssapi_start(struct gensec_security *gensec_security)
        /* TODO: Fill in channel bindings */
        gensec_gssapi_state->input_chan_bindings = GSS_C_NO_CHANNEL_BINDINGS;
        
-       gensec_gssapi_state->want_flags = 0;
+       gensec_gssapi_state->want_flags = GSS_C_MUTUAL_FLAG | GSS_C_DELEG_FLAG;
        gensec_gssapi_state->got_flags = 0;
 
        gensec_gssapi_state->session_key = data_blob(NULL, 0);
        gensec_gssapi_state->pac = data_blob(NULL, 0);
 
        gensec_gssapi_state->cred = GSS_C_NO_CREDENTIAL;
+       gensec_gssapi_state->delegated_cred_handle = GSS_C_NO_CREDENTIAL;
 
        talloc_set_destructor(gensec_gssapi_state, gensec_gssapi_destory); 
 
-       if (gensec_security->want_features & GENSEC_FEATURE_SESSION_KEY) {
-#ifndef HAVE_GSSKRB5_GET_INITIATOR_SUBKEY
-               /* GSSAPI won't give us the session keys, without the
-                * right hooks.  This is critical when requested, so
-                * fail outright. */
-               return NT_STATUS_INVALID_PARAMETER;
-#endif
-       }
        if (gensec_security->want_features & GENSEC_FEATURE_SIGN) {
                gensec_gssapi_state->want_flags |= GSS_C_INTEG_FLAG;
        }
@@ -146,13 +142,7 @@ static NTSTATUS gensec_gssapi_start(struct gensec_security *gensec_security)
                gensec_gssapi_state->want_flags |= GSS_C_CONF_FLAG;
        }
        if (gensec_security->want_features & GENSEC_FEATURE_DCE_STYLE) {
-#ifndef GSS_C_DCE_STYLE
-               /* GSSAPI DCE_STYLE is critical when requested, so
-                * fail outright */
-               return NT_STATUS_INVALID_PARAMETER;
-#else
                gensec_gssapi_state->want_flags |= GSS_C_DCE_STYLE;
-#endif
        }
 
        gensec_gssapi_state->gss_oid = gss_mech_krb5;
@@ -171,6 +161,8 @@ static NTSTATUS gensec_gssapi_server_start(struct gensec_security *gensec_securi
 {
        NTSTATUS nt_status;
        OM_uint32 maj_stat, min_stat;
+       int ret;
+       const char *principal;
        struct gensec_gssapi_state *gensec_gssapi_state;
        struct cli_credentials *machine_account;
 
@@ -181,30 +173,47 @@ static NTSTATUS gensec_gssapi_server_start(struct gensec_security *gensec_securi
 
        gensec_gssapi_state = gensec_security->private_data;
 
-       machine_account = cli_credentials_init(gensec_gssapi_state);
-       cli_credentials_set_conf(machine_account);
-       nt_status = cli_credentials_set_machine_account(machine_account);
+       machine_account = gensec_get_credentials(gensec_security);
        
-       if (!NT_STATUS_IS_OK(nt_status)) {
-               DEBUG(3, ("Could not obtain machine account credentials from the local database\n"));
-               talloc_free(machine_account);
-               return nt_status;
+       if (!machine_account) {
+               DEBUG(3, ("No machine account credentials specified\n"));
+               return NT_STATUS_INVALID_PARAMETER;
        } else {
-               nt_status = create_memory_keytab(gensec_gssapi_state,
-                                                machine_account, 
-                                                gensec_gssapi_state->smb_krb5_context,
-                                                &gensec_gssapi_state->keytab);
-               talloc_free(machine_account);
-               if (!NT_STATUS_IS_OK(nt_status)) {
+               ret = cli_credentials_get_keytab(machine_account, &gensec_gssapi_state->keytab);
+               if (ret) {
                        DEBUG(3, ("Could not create memory keytab!\n"));
-                       talloc_free(machine_account);
-                       return nt_status;
+                       return NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
                }
        }
 
+       principal = cli_credentials_get_principal(machine_account, 
+                                                 machine_account);
+
+       /* This might have been explicity set to NULL, ie use what the client calls us */
+       if (principal) {
+               gss_buffer_desc name_token;
+
+               name_token.value  = discard_const_p(uint8_t, principal);
+               name_token.length = strlen(principal);
+               
+               maj_stat = gss_import_name (&min_stat,
+                                           &name_token,
+                                           GSS_C_NT_USER_NAME,
+                                           &gensec_gssapi_state->server_name);
+
+               if (maj_stat) {
+                       DEBUG(2, ("GSS Import name of %s failed: %s\n",
+                                 (char *)name_token.value,
+                                 gssapi_error_string(gensec_gssapi_state, maj_stat, min_stat)));
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
+       } else {
+               gensec_gssapi_state->server_name = GSS_C_NO_NAME;
+       }
+
        maj_stat = gsskrb5_acquire_cred(&min_stat, 
-                                       gensec_gssapi_state->keytab, NULL,
-                                       NULL,
+                                       gensec_gssapi_state->keytab->keytab, 
+                                       gensec_gssapi_state->server_name,
                                        GSS_C_INDEFINITE,
                                        GSS_C_NULL_OID_SET,
                                        GSS_C_ACCEPT,
@@ -225,17 +234,25 @@ static NTSTATUS gensec_gssapi_client_start(struct gensec_security *gensec_securi
 {
        struct gensec_gssapi_state *gensec_gssapi_state;
        struct cli_credentials *creds = gensec_get_credentials(gensec_security);
+       krb5_error_code ret;
        NTSTATUS nt_status;
        gss_buffer_desc name_token;
+       gss_OID name_type;
        OM_uint32 maj_stat, min_stat;
        const char *hostname = gensec_get_target_hostname(gensec_security);
+       const char *principal;
+       struct gssapi_creds_container *gcc;
 
        if (!hostname) {
                DEBUG(1, ("Could not determine hostname for target computer, cannot use kerberos\n"));
                return NT_STATUS_INVALID_PARAMETER;
        }
        if (is_ipaddress(hostname)) {
-               DEBUG(2, ("Cannot do GSSAPI to a IP address"));
+               DEBUG(2, ("Cannot do GSSAPI to an IP address\n"));
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+       if (strequal(hostname, "localhost")) {
+               DEBUG(2, ("GSSAPI to 'localhost' does not make sense\n"));
                return NT_STATUS_INVALID_PARAMETER;
        }
 
@@ -246,14 +263,26 @@ static NTSTATUS gensec_gssapi_client_start(struct gensec_security *gensec_securi
 
        gensec_gssapi_state = gensec_security->private_data;
 
-       name_token.value = talloc_asprintf(gensec_gssapi_state, "%s@%s", 
-                                          gensec_get_target_service(gensec_security), 
-                                          hostname);
-       name_token.length = strlen(name_token.value);
+       principal = gensec_get_target_principal(gensec_security);
+       if (principal && lp_client_use_spnego_principal()) {
+               name_token.value  = discard_const_p(uint8_t, principal);
+               name_token.length = strlen(principal);
+
+               name_type = GSS_C_NULL_OID;
+       } else {
+               principal = talloc_asprintf(gensec_gssapi_state, "%s@%s", 
+                                           gensec_get_target_service(gensec_security), 
+                                           hostname);
+
+               name_token.value  = discard_const_p(uint8_t, principal);
+               name_token.length = strlen(principal);
+
+               name_type = GSS_C_NT_HOSTBASED_SERVICE;
+       }               
 
        maj_stat = gss_import_name (&min_stat,
                                    &name_token,
-                                   GSS_C_NT_HOSTBASED_SERVICE,
+                                   name_type,
                                    &gensec_gssapi_state->server_name);
        if (maj_stat) {
                DEBUG(2, ("GSS Import name of %s failed: %s\n",
@@ -262,43 +291,19 @@ static NTSTATUS gensec_gssapi_client_start(struct gensec_security *gensec_securi
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       name_token.value = cli_credentials_get_principal(creds, 
-                                                        gensec_gssapi_state);
-       name_token.length = strlen(name_token.value);
-
-       maj_stat = gss_import_name (&min_stat,
-                                   &name_token,
-                                   GSS_C_NT_USER_NAME,
-                                   &gensec_gssapi_state->client_name);
-       if (maj_stat) {
-               DEBUG(2, ("GSS Import name of %s failed: %s\n",
-                         (char *)name_token.value,
-                         gssapi_error_string(gensec_gssapi_state, maj_stat, min_stat)));
+       ret = cli_credentials_get_client_gss_creds(creds, &gcc);
+       switch (ret) {
+       case 0:
+               break;
+       case KRB5_KDC_UNREACH:
+               DEBUG(3, ("Cannot reach a KDC we require\n"));
+               return NT_STATUS_INVALID_PARAMETER; /* Make SPNEGO ignore us, we can't go any further here */
+       default:
+               DEBUG(1, ("Aquiring initiator credentails failed\n"));
                return NT_STATUS_UNSUCCESSFUL;
        }
 
-       nt_status = kinit_to_ccache(gensec_gssapi_state, 
-                                   creds,
-                                   gensec_gssapi_state->smb_krb5_context, 
-                                   &gensec_gssapi_state->ccache, &gensec_gssapi_state->ccache_name);
-       if (!NT_STATUS_IS_OK(nt_status)) {
-               return nt_status;
-       }
-
-       maj_stat = gsskrb5_acquire_cred(&min_stat, 
-                                       NULL, gensec_gssapi_state->ccache,
-                                       gensec_gssapi_state->client_name,
-                                       GSS_C_INDEFINITE,
-                                       GSS_C_NULL_OID_SET,
-                                       GSS_C_INITIATE,
-                                       &gensec_gssapi_state->cred,
-                                       NULL, 
-                                       NULL);
-       if (maj_stat) {
-               DEBUG(1, ("Aquiring initiator credentails failed: %s\n", 
-                         gssapi_error_string(gensec_gssapi_state, maj_stat, min_stat)));
-               return NT_STATUS_UNSUCCESSFUL;
-       }
+       gensec_gssapi_state->client_cred = gcc;
 
        return NT_STATUS_OK;
 }
@@ -340,7 +345,7 @@ static NTSTATUS gensec_gssapi_update(struct gensec_security *gensec_security,
                                   const DATA_BLOB in, DATA_BLOB *out) 
 {
        struct gensec_gssapi_state *gensec_gssapi_state = gensec_security->private_data;
-       NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL;
+       NTSTATUS nt_status = NT_STATUS_LOGON_FAILURE;
        OM_uint32 maj_stat, min_stat;
        OM_uint32 min_stat2;
        gss_buffer_desc input_token, output_token;
@@ -352,7 +357,7 @@ static NTSTATUS gensec_gssapi_update(struct gensec_security *gensec_security,
        case GENSEC_CLIENT:
        {
                maj_stat = gss_init_sec_context(&min_stat, 
-                                               gensec_gssapi_state->cred,
+                                               gensec_gssapi_state->client_cred->creds,
                                                &gensec_gssapi_state->gssapi_context, 
                                                gensec_gssapi_state->server_name, 
                                                discard_const_p(gss_OID_desc, gensec_gssapi_state->gss_oid),
@@ -378,7 +383,7 @@ static NTSTATUS gensec_gssapi_update(struct gensec_security *gensec_security,
                                                  &output_token, 
                                                  &gensec_gssapi_state->got_flags, 
                                                  NULL, 
-                                                 NULL);
+                                                 &gensec_gssapi_state->delegated_cred_handle);
                gensec_gssapi_state->gss_oid = gss_oid_p;
                break;
        }
@@ -387,19 +392,43 @@ static NTSTATUS gensec_gssapi_update(struct gensec_security *gensec_security,
                
        }
 
-       *out = data_blob_talloc(out_mem_ctx, output_token.value, output_token.length);
-       gss_release_buffer(&min_stat2, &output_token);
-
        if (maj_stat == GSS_S_COMPLETE) {
+               *out = data_blob_talloc(out_mem_ctx, output_token.value, output_token.length);
+               gss_release_buffer(&min_stat2, &output_token);
+
+               if (gensec_gssapi_state->got_flags & GSS_C_DELEG_FLAG) {
+                       DEBUG(5, ("gensec_gssapi: credentials were delegated\n"));
+               } else {
+                       DEBUG(5, ("gensec_gssapi: NO credentials were delegated\n"));
+               }
+
                return NT_STATUS_OK;
        } else if (maj_stat == GSS_S_CONTINUE_NEEDED) {
+               *out = data_blob_talloc(out_mem_ctx, output_token.value, output_token.length);
+               gss_release_buffer(&min_stat2, &output_token);
+
                return NT_STATUS_MORE_PROCESSING_REQUIRED;
-       } else {
-               if (maj_stat == GSS_S_FAILURE
-                   && (min_stat == KRB5KRB_AP_ERR_BADVERSION || min_stat == KRB5KRB_AP_ERR_MSG_TYPE)) {
+       } else if ((gensec_gssapi_state->gss_oid->length == gss_mech_krb5->length)
+           && (memcmp(gensec_gssapi_state->gss_oid->elements, gss_mech_krb5->elements, 
+                      gensec_gssapi_state->gss_oid->length) == 0)) {
+               switch (min_stat) {
+               case KRB5_KDC_UNREACH:
+                       DEBUG(3, ("Cannot reach a KDC we require: %s\n",
+                                 gssapi_error_string(gensec_gssapi_state, maj_stat, min_stat)));
+                       return NT_STATUS_INVALID_PARAMETER; /* Make SPNEGO ignore us, we can't go any further here */
+               case KRB5KDC_ERR_S_PRINCIPAL_UNKNOWN:
+                       DEBUG(3, ("Server is not registered with our KDC: %s\n", 
+                                 gssapi_error_string(gensec_gssapi_state, maj_stat, min_stat)));
+                       return NT_STATUS_INVALID_PARAMETER; /* Make SPNEGO ignore us, we can't go any further here */
+               case KRB5KRB_AP_ERR_MSG_TYPE:
                        /* garbage input, possibly from the auto-mech detection */
                        return NT_STATUS_INVALID_PARAMETER;
+               default:
+                       DEBUG(1, ("GSS(krb5) Update failed: %s\n", 
+                                 gssapi_error_string(out_mem_ctx, maj_stat, min_stat)));
+                       return nt_status;
                }
+       } else {
                DEBUG(1, ("GSS Update failed: %s\n", 
                          gssapi_error_string(out_mem_ctx, maj_stat, min_stat)));
                return nt_status;
@@ -426,12 +455,12 @@ static NTSTATUS gensec_gssapi_wrap(struct gensec_security *gensec_security,
                            &conf_state,
                            &output_token);
        if (GSS_ERROR(maj_stat)) {
-               DEBUG(1, ("GSS Wrap failed: %s\n", 
+               DEBUG(1, ("gensec_gssapi_wrap: GSS Wrap failed: %s\n", 
                          gssapi_error_string(mem_ctx, maj_stat, min_stat)));
                return NT_STATUS_ACCESS_DENIED;
        }
-       *out = data_blob_talloc(mem_ctx, output_token.value, output_token.length);
 
+       *out = data_blob_talloc(mem_ctx, output_token.value, output_token.length);
        gss_release_buffer(&min_stat, &output_token);
 
        if (gensec_have_feature(gensec_security, GENSEC_FEATURE_SEAL)
@@ -461,12 +490,12 @@ static NTSTATUS gensec_gssapi_unwrap(struct gensec_security *gensec_security,
                              &conf_state,
                              &qop_state);
        if (GSS_ERROR(maj_stat)) {
-               DEBUG(1, ("GSS UnWrap failed: %s\n", 
+               DEBUG(1, ("gensec_gssapi_unwrap: GSS UnWrap failed: %s\n", 
                          gssapi_error_string(mem_ctx, maj_stat, min_stat)));
                return NT_STATUS_ACCESS_DENIED;
        }
-       *out = data_blob_talloc(mem_ctx, output_token.value, output_token.length);
 
+       *out = data_blob_talloc(mem_ctx, output_token.value, output_token.length);
        gss_release_buffer(&min_stat, &output_token);
        
        if (gensec_have_feature(gensec_security, GENSEC_FEATURE_SEAL)
@@ -476,10 +505,38 @@ static NTSTATUS gensec_gssapi_unwrap(struct gensec_security *gensec_security,
        return NT_STATUS_OK;
 }
 
-static size_t gensec_gssapi_sig_size(struct gensec_security *gensec_security) 
+static size_t gensec_gssapi_sig_size(struct gensec_security *gensec_security, size_t data_size
 {
-       /* not const but work for DCERPC packets and arcfour */
-       return 45;
+       struct gensec_gssapi_state *gensec_gssapi_state = gensec_security->private_data;
+       OM_uint32 maj_stat, min_stat;
+       OM_uint32 output_size;
+       if ((gensec_gssapi_state->gss_oid->length != gss_mech_krb5->length)
+           || (memcmp(gensec_gssapi_state->gss_oid->elements, gss_mech_krb5->elements, 
+                      gensec_gssapi_state->gss_oid->length) != 0)) {
+               DEBUG(1, ("NO sig size available for this mech\n"));
+               return 0;
+       }
+               
+       maj_stat = gsskrb5_wrap_size(&min_stat, 
+                                    gensec_gssapi_state->gssapi_context,
+                                    gensec_have_feature(gensec_security, GENSEC_FEATURE_SEAL),
+                                    GSS_C_QOP_DEFAULT,
+                                    data_size, 
+                                    &output_size);
+       if (GSS_ERROR(maj_stat)) {
+               TALLOC_CTX *mem_ctx = talloc_new(NULL); 
+               DEBUG(1, ("gensec_gssapi_seal_packet: determinaing signature size with gss_wrap_size_limit failed: %s\n", 
+                         gssapi_error_string(mem_ctx, maj_stat, min_stat)));
+               talloc_free(mem_ctx);
+               return 0;
+       }
+
+       if (output_size < data_size) {
+               return 0;
+       }
+
+       /* The difference between the max output and the max input must be the signature */
+       return output_size - data_size;
 }
 
 static NTSTATUS gensec_gssapi_seal_packet(struct gensec_security *gensec_security, 
@@ -492,7 +549,7 @@ static NTSTATUS gensec_gssapi_seal_packet(struct gensec_security *gensec_securit
        OM_uint32 maj_stat, min_stat;
        gss_buffer_desc input_token, output_token;
        int conf_state;
-       ssize_t sig_length = 0;
+       ssize_t sig_length;
 
        input_token.length = length;
        input_token.value = data;
@@ -505,17 +562,20 @@ static NTSTATUS gensec_gssapi_seal_packet(struct gensec_security *gensec_securit
                            &conf_state,
                            &output_token);
        if (GSS_ERROR(maj_stat)) {
-               DEBUG(1, ("GSS Wrap failed: %s\n", 
+               DEBUG(1, ("gensec_gssapi_seal_packet: GSS Wrap failed: %s\n", 
                          gssapi_error_string(mem_ctx, maj_stat, min_stat)));
                return NT_STATUS_ACCESS_DENIED;
        }
 
-       if (output_token.length < length) {
+       sig_length = gensec_gssapi_sig_size(gensec_security, length);
+
+       /* Caller must pad to right boundary */
+       if (output_token.length != (length + sig_length)) {
+               DEBUG(1, ("gensec_gssapi_seal_packet: GSS Wrap length [%d] does not match caller length [%d] plus sig size [%d] = [%d]\n", 
+                         output_token.length, length, sig_length, length + sig_length));
                return NT_STATUS_INTERNAL_ERROR;
        }
 
-       sig_length = 45;
-
        memcpy(data, ((uint8_t *)output_token.value) + sig_length, length);
        *sig = data_blob_talloc(mem_ctx, (uint8_t *)output_token.value, sig_length);
 
@@ -545,7 +605,7 @@ static NTSTATUS gensec_gssapi_unseal_packet(struct gensec_security *gensec_secur
        gss_qop_t qop_state;
        DATA_BLOB in;
 
-       dump_data_pw("gensec_gssapi_seal_packet: sig\n", sig->data, sig->length);
+       dump_data_pw("gensec_gssapi_unseal_packet: sig\n", sig->data, sig->length);
 
        in = data_blob_talloc(mem_ctx, NULL, sig->length + length);
 
@@ -562,7 +622,7 @@ static NTSTATUS gensec_gssapi_unseal_packet(struct gensec_security *gensec_secur
                              &conf_state,
                              &qop_state);
        if (GSS_ERROR(maj_stat)) {
-               DEBUG(1, ("GSS UnWrap failed: %s\n", 
+               DEBUG(1, ("gensec_gssapi_unseal_packet: GSS UnWrap failed: %s\n", 
                          gssapi_error_string(mem_ctx, maj_stat, min_stat)));
                return NT_STATUS_ACCESS_DENIED;
        }
@@ -614,9 +674,15 @@ static NTSTATUS gensec_gssapi_sign_packet(struct gensec_security *gensec_securit
                return NT_STATUS_INTERNAL_ERROR;
        }
 
-       sig_length = 45;
+       sig_length = gensec_gssapi_sig_size(gensec_security, length);
+
+       /* Caller must pad to right boundary */
+       if (output_token.length != (length + sig_length)) {
+               DEBUG(1, ("gensec_gssapi_sign_packet: GSS Wrap length [%d] does not match caller length [%d] plus sig size [%d] = [%d]\n", 
+                         output_token.length, length, sig_length, length + sig_length));
+               return NT_STATUS_INTERNAL_ERROR;
+       }
 
-       /*memcpy(data, ((uint8_t *)output_token.value) + sig_length, length);*/
        *sig = data_blob_talloc(mem_ctx, (uint8_t *)output_token.value, sig_length);
 
        dump_data_pw("gensec_gssapi_seal_packet: sig\n", sig->data, sig->length);
@@ -681,12 +747,16 @@ static BOOL gensec_gssapi_have_feature(struct gensec_security *gensec_security,
                return gensec_gssapi_state->got_flags & GSS_C_CONF_FLAG;
        }
        if (feature & GENSEC_FEATURE_SESSION_KEY) {
-#ifdef HAVE_GSSKRB5_GET_INITIATOR_SUBKEY
                if ((gensec_gssapi_state->gss_oid->length == gss_mech_krb5->length)
                    && (memcmp(gensec_gssapi_state->gss_oid->elements, gss_mech_krb5->elements, gensec_gssapi_state->gss_oid->length) == 0)) {
                        return True;
                }
-#endif 
+       }
+       if (feature & GENSEC_FEATURE_DCE_STYLE) {
+               return gensec_gssapi_state->got_flags & GSS_C_DCE_STYLE;
+       }
+       if (feature & GENSEC_FEATURE_ASYNC_REPLIES) {
+               return True;
        }
        return False;
 }
@@ -701,7 +771,6 @@ static NTSTATUS gensec_gssapi_session_key(struct gensec_security *gensec_securit
                return NT_STATUS_OK;
        }
 
-#ifdef HAVE_GSSKRB5_GET_INITIATOR_SUBKEY
        /* Ensure we only call this for GSSAPI/krb5, otherwise things could get very ugly */
        if ((gensec_gssapi_state->gss_oid->length == gss_mech_krb5->length)
            && (memcmp(gensec_gssapi_state->gss_oid->elements, gss_mech_krb5->elements, 
@@ -726,7 +795,6 @@ static NTSTATUS gensec_gssapi_session_key(struct gensec_security *gensec_securit
                }
                return NT_STATUS_NO_USER_SESSION_KEY;
        }
-#endif
        
        DEBUG(1, ("NO session key for this mech\n"));
        return NT_STATUS_NO_USER_SESSION_KEY;
@@ -741,15 +809,22 @@ static NTSTATUS gensec_gssapi_session_info(struct gensec_security *gensec_securi
        struct auth_serversupplied_info *server_info = NULL;
        struct auth_session_info *session_info = NULL;
        struct PAC_LOGON_INFO *logon_info;
-       char *p;
-       char *principal;
-       const char *account_name;
-       const char *realm;
        OM_uint32 maj_stat, min_stat;
        gss_buffer_desc name_token;
        gss_buffer_desc pac;
        krb5_keyblock *keyblock;
+       time_t authtime;
+       krb5_principal principal;
+       char *principal_string;
+       DATA_BLOB pac_blob;
        
+       if ((gensec_gssapi_state->gss_oid->length != gss_mech_krb5->length)
+           || (memcmp(gensec_gssapi_state->gss_oid->elements, gss_mech_krb5->elements, 
+                      gensec_gssapi_state->gss_oid->length) != 0)) {
+               DEBUG(1, ("NO session info available for this mech\n"));
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+               
        mem_ctx = talloc_named(gensec_gssapi_state, 0, "gensec_gssapi_session_info context"); 
        NT_STATUS_HAVE_NO_MEMORY(mem_ctx);
 
@@ -761,49 +836,62 @@ static NTSTATUS gensec_gssapi_session_info(struct gensec_security *gensec_securi
                return NT_STATUS_FOOBAR;
        }
 
-       principal = talloc_strndup(mem_ctx, name_token.value, name_token.length);
+       principal_string = talloc_strndup(mem_ctx, name_token.value, name_token.length);
 
        gss_release_buffer(&min_stat, &name_token);
 
-       if (!principal) {
+       if (!principal_string) {
                talloc_free(mem_ctx);
                return NT_STATUS_NO_MEMORY;
        }
 
-       p = strchr(principal, '@');
-       if (p) {
-               *p = '\0';
-               p++;
-               realm = p;
-       } else {
-               realm = lp_realm();
-       }
-       account_name = principal;
-       
        maj_stat = gss_krb5_copy_service_keyblock(&min_stat, 
                                                  gensec_gssapi_state->gssapi_context, 
                                                  &keyblock);
 
-       maj_stat = gsskrb5_extract_authz_data_from_sec_context(&min_stat, 
-                                                              gensec_gssapi_state->gssapi_context, 
-                                                              KRB5_AUTHDATA_IF_RELEVANT,
-                                                              &pac);
-       
        if (maj_stat == 0) {
-               DATA_BLOB pac_blob = data_blob_talloc(mem_ctx, pac.value, pac.length);
-               pac_blob = unwrap_pac(mem_ctx, &pac_blob);
+               maj_stat = gsskrb5_extract_authtime_from_sec_context(&min_stat,
+                                                                    gensec_gssapi_state->gssapi_context, 
+                                                                    &authtime);
+       }
+
+       if (maj_stat == 0) {
+               maj_stat = gsskrb5_extract_authz_data_from_sec_context(&min_stat, 
+                                                                      gensec_gssapi_state->gssapi_context, 
+                                                                      KRB5_AUTHDATA_WIN2K_PAC,
+                                                                      &pac);
+       }
+
+       if (maj_stat == 0) {
+               pac_blob = data_blob_talloc(mem_ctx, pac.value, pac.length);
                gss_release_buffer(&min_stat, &pac);
+       }
+       
+       /* IF we have the PAC - otherwise we need to get this
+        * data from elsewere - local ldb, or (TODO) lookup of some
+        * kind... 
+        */
+       if (maj_stat == 0) {
+               krb5_error_code ret;
+
+               ret = krb5_parse_name(gensec_gssapi_state->smb_krb5_context->krb5_context,
+                                     principal_string, &principal);
+               if (ret) {
+                       talloc_free(mem_ctx);
+                       return NT_STATUS_INVALID_PARAMETER;
+               }
                
                /* decode and verify the pac */
-               nt_status = kerberos_decode_pac(mem_ctx, &logon_info, pac_blob,
-                                               gensec_gssapi_state->smb_krb5_context,
-                                               NULL, keyblock);
+               nt_status = kerberos_pac_logon_info(mem_ctx, &logon_info, pac_blob,
+                                                   gensec_gssapi_state->smb_krb5_context->krb5_context,
+                                                   NULL, keyblock, principal, authtime);
+               krb5_free_principal(gensec_gssapi_state->smb_krb5_context->krb5_context, principal);
 
                if (NT_STATUS_IS_OK(nt_status)) {
                        union netr_Validation validation;
                        validation.sam3 = &logon_info->info3;
                        nt_status = make_server_info_netlogon_validation(gensec_gssapi_state, 
-                                                                        account_name,
+                                                                        NULL,
                                                                         3, &validation,
                                                                         &server_info); 
                        if (!NT_STATUS_IS_OK(nt_status)) {
@@ -816,20 +904,10 @@ static NTSTATUS gensec_gssapi_session_info(struct gensec_security *gensec_securi
        }
        
        if (maj_stat) {
-               /* IF we have the PAC - otherwise we need to get this
-                * data from elsewere - local ldb, or (TODO) lookup of some
-                * kind... 
-                *
-                * when heimdal can generate the PAC, we should fail if there's
-                * no PAC present
-                */
-
-               DATA_BLOB user_sess_key = data_blob(NULL, 0);
-               DATA_BLOB lm_sess_key = data_blob(NULL, 0);
-               /* TODO: should we pass the krb5 session key in here? */
-               nt_status = sam_get_server_info(mem_ctx, account_name, realm,
-                                               user_sess_key, lm_sess_key,
-                                               &server_info);
+               DEBUG(1, ("Unable to use PAC, resorting to local user lookup!\n"));
+               nt_status = sam_get_server_info_principal(mem_ctx, principal_string,
+                                                         &server_info);
+
                if (!NT_STATUS_IS_OK(nt_status)) {
                        talloc_free(mem_ctx);
                        return nt_status;
@@ -838,18 +916,40 @@ static NTSTATUS gensec_gssapi_session_info(struct gensec_security *gensec_securi
 
        /* references the server_info into the session_info */
        nt_status = auth_generate_session_info(gensec_gssapi_state, server_info, &session_info);
+       talloc_free(mem_ctx);
        talloc_free(server_info);
        NT_STATUS_NOT_OK_RETURN(nt_status);
 
        nt_status = gensec_gssapi_session_key(gensec_security, &session_info->session_key);
        NT_STATUS_NOT_OK_RETURN(nt_status);
 
+       if (!(gensec_gssapi_state->got_flags & GSS_C_DELEG_FLAG)) {
+               DEBUG(10, ("gensec_gssapi: NO delegated credentials supplied by client"));
+       } else {
+               krb5_error_code ret;
+               DEBUG(10, ("gensec_gssapi: delegated credentials supplied by client\n"));
+               session_info->credentials = cli_credentials_init(session_info);
+               if (!session_info->credentials) {
+                       return NT_STATUS_NO_MEMORY;
+               }
+
+               cli_credentials_set_conf(session_info->credentials);
+               
+               ret = cli_credentials_set_client_gss_creds(session_info->credentials, 
+                                                          gensec_gssapi_state->delegated_cred_handle,
+                                                          CRED_SPECIFIED);
+               if (ret) {
+                       return NT_STATUS_NO_MEMORY;
+               }
+               /* It has been taken from this place... */
+               gensec_gssapi_state->delegated_cred_handle = GSS_C_NO_CREDENTIAL;
+       }
        *_session_info = session_info;
 
        return NT_STATUS_OK;
 }
 
-static const char *gensec_krb5_oids[] = { 
+static const char *gensec_gssapi_krb5_oids[] = { 
        GENSEC_OID_KERBEROS5,
        GENSEC_OID_KERBEROS5_OLD,
        NULL 
@@ -858,7 +958,8 @@ static const char *gensec_krb5_oids[] = {
 /* As a server, this could in theory accept any GSSAPI mech */
 static const struct gensec_security_ops gensec_gssapi_krb5_security_ops = {
        .name           = "gssapi_krb5",
-       .oid            = gensec_krb5_oids,
+       .auth_type      = DCERPC_AUTH_TYPE_KRB5,
+       .oid            = gensec_gssapi_krb5_oids,
        .client_start   = gensec_gssapi_client_start,
        .server_start   = gensec_gssapi_server_start,
        .magic          = gensec_gssapi_magic,
@@ -873,7 +974,7 @@ static const struct gensec_security_ops gensec_gssapi_krb5_security_ops = {
        .wrap           = gensec_gssapi_wrap,
        .unwrap         = gensec_gssapi_unwrap,
        .have_feature   = gensec_gssapi_have_feature,
-       .enabled        = False
+       .enabled        = True
 };
 
 NTSTATUS gensec_gssapi_init(void)