Merge commit 'master/master'
[kai/samba.git] / source3 / winbindd / winbindd_util.c
index 0175990f0ccee6389119b4e0ac2c5b29f5761b77..fdfc8ed9d13dd3d076efa461d270da73d150b8ff 100644 (file)
@@ -27,7 +27,9 @@
 #define DBGC_CLASS DBGC_WINBIND
 
 extern struct winbindd_methods cache_methods;
-extern struct winbindd_methods passdb_methods;
+extern struct winbindd_methods builtin_passdb_methods;
+extern struct winbindd_methods sam_passdb_methods;
+
 
 /**
  * @file winbindd_util.c
@@ -35,12 +37,13 @@ extern struct winbindd_methods passdb_methods;
  * Winbind daemon for NT domain authentication nss module.
  **/
 
+
 /* The list of trusted domains.  Note that the list can be deleted and
    recreated using the init_domain_list() function so pointers to
    individual winbindd_domain structures cannot be made.  Keep a copy of
    the domain name instead. */
 
-static struct winbindd_domain *_domain_list;
+static struct winbindd_domain *_domain_list = NULL;
 
 /**
    When was the last scan of trusted domains done?
@@ -76,7 +79,7 @@ void free_domain_list(void)
        }
 }
 
-static BOOL is_internal_domain(const DOM_SID *sid)
+static bool is_internal_domain(const DOM_SID *sid)
 {
        if (sid == NULL)
                return False;
@@ -87,7 +90,7 @@ static BOOL is_internal_domain(const DOM_SID *sid)
        return (sid_check_is_domain(sid) || sid_check_is_builtin(sid));
 }
 
-static BOOL is_in_internal_domain(const DOM_SID *sid)
+static bool is_in_internal_domain(const DOM_SID *sid)
 {
        if (sid == NULL)
                return False;
@@ -106,7 +109,18 @@ static struct winbindd_domain *add_trusted_domain(const char *domain_name, const
 {
        struct winbindd_domain *domain;
        const char *alternative_name = NULL;
+       char *idmap_config_option;
+       const char *param;
+       const char **ignored_domains, **dom;
        
+       ignored_domains = lp_parm_string_list(-1, "winbind", "ignore domains", NULL);
+       for (dom=ignored_domains; dom && *dom; dom++) {
+               if (gen_fnmatch(*dom, domain_name) == 0) {
+                       DEBUG(2,("Ignoring domain '%s'\n", domain_name));
+                       return NULL;
+               }
+       }
+
        /* ignore alt_name if we are not in an AD domain */
        
        if ( (lp_security() == SEC_ADS) && alt_name && *alt_name) {
@@ -162,15 +176,9 @@ static struct winbindd_domain *add_trusted_domain(const char *domain_name, const
         
        ZERO_STRUCTP(domain);
 
-       /* prioritise the short name */
-       if (strchr_m(domain_name, '.') && alternative_name && *alternative_name) {
-               fstrcpy(domain->name, alternative_name);
-               fstrcpy(domain->alt_name, domain_name);
-       } else {
-               fstrcpy(domain->name, domain_name);
-               if (alternative_name) {
-                       fstrcpy(domain->alt_name, alternative_name);
-               }
+       fstrcpy(domain->name, domain_name);
+       if (alternative_name) {
+               fstrcpy(domain->alt_name, alternative_name);
        }
 
        domain->methods = methods;
@@ -181,18 +189,50 @@ static struct winbindd_domain *add_trusted_domain(const char *domain_name, const
        domain->initialized = False;
        domain->online = is_internal_domain(sid);
        domain->check_online_timeout = 0;
+       domain->dc_probe_pid = (pid_t)-1;
        if (sid) {
                sid_copy(&domain->sid, sid);
        }
-       
+
        /* Link to domain list */
-       DLIST_ADD(_domain_list, domain);
+       DLIST_ADD_END(_domain_list, domain, struct winbindd_domain *);
         
        wcache_tdc_add_domain( domain );
         
+       idmap_config_option = talloc_asprintf(talloc_tos(), "idmap config %s",
+                                             domain->name);
+       if (idmap_config_option == NULL) {
+               DEBUG(0, ("talloc failed, not looking for idmap config\n"));
+               goto done;
+       }
+
+       param = lp_parm_const_string(-1, idmap_config_option, "range", NULL);
+
+       DEBUG(10, ("%s : range = %s\n", idmap_config_option,
+                  param ? param : "not defined"));
+
+       if (param != NULL) {
+               unsigned low_id, high_id;
+               if (sscanf(param, "%u - %u", &low_id, &high_id) != 2) {
+                       DEBUG(1, ("invalid range syntax in %s: %s\n",
+                                 idmap_config_option, param));
+                       goto done;
+               }
+               if (low_id > high_id) {
+                       DEBUG(1, ("invalid range in %s: %s\n",
+                                 idmap_config_option, param));
+                       goto done;
+               }
+               domain->have_idmap_config = true;
+               domain->id_range_low = low_id;
+               domain->id_range_high = high_id;
+       }
+
+done:
+
        DEBUG(2,("Added domain %s %s %s\n", 
                 domain->name, domain->alt_name,
-                &domain->sid?sid_string_static(&domain->sid):""));
+                &domain->sid?sid_string_dbg(&domain->sid):""));
         
        return domain;
 }
@@ -203,12 +243,12 @@ static struct winbindd_domain *add_trusted_domain(const char *domain_name, const
 
 struct trustdom_state {
        TALLOC_CTX *mem_ctx;
-       BOOL primary;   
-       BOOL forest_root;       
+       bool primary;   
+       bool forest_root;       
        struct winbindd_response *response;
 };
 
-static void trustdom_recv(void *private_data, BOOL success);
+static void trustdom_recv(void *private_data, bool success);
 static void rescan_forest_root_trusts( void );
 static void rescan_forest_trusts( void );
 
@@ -217,7 +257,7 @@ static void add_trusted_domains( struct winbindd_domain *domain )
        TALLOC_CTX *mem_ctx;
        struct winbindd_request *request;
        struct winbindd_response *response;
-       uint32 fr_flags = (DS_DOMAIN_TREE_ROOT|DS_DOMAIN_IN_FOREST);    
+       uint32 fr_flags = (NETR_TRUST_FLAG_TREEROOT|NETR_TRUST_FLAG_IN_FOREST);
 
        struct trustdom_state *state;
 
@@ -252,7 +292,7 @@ static void add_trusted_domains( struct winbindd_domain *domain )
                             trustdom_recv, state);
 }
 
-static void trustdom_recv(void *private_data, BOOL success)
+static void trustdom_recv(void *private_data, bool success)
 {
        struct trustdom_state *state =
                talloc_get_type_abort(private_data, struct trustdom_state);
@@ -324,7 +364,8 @@ static void trustdom_recv(void *private_data, BOOL success)
                                                    &cache_methods,
                                                    &sid);
                        if (domain) {
-                               setup_domain_child(domain, &domain->child, NULL);
+                               setup_domain_child(domain,
+                                                  &domain->child);
                        }
                }
                p=q;
@@ -343,7 +384,7 @@ static void trustdom_recv(void *private_data, BOOL success)
        */
 
        if ( state->primary ) {
-               /* If this is our primary domain and we are not the in the
+               /* If this is our primary domain and we are not in the
                   forest root, we have to scan the root trusts first */
 
                if ( !state->forest_root )
@@ -353,7 +394,7 @@ static void trustdom_recv(void *private_data, BOOL success)
 
        } else if ( state->forest_root ) {
                /* Once we have done root forest trust search, we can
-                  go on to search thing trusted forests */
+                  go on to search the trusted forests */
 
                rescan_forest_trusts();
        }
@@ -389,8 +430,8 @@ static void rescan_forest_root_trusts( void )
                   the domain_list() as our primary domain may not 
                   have been initialized. */
 
-               if ( !(dom_list[i].trust_flags & DS_DOMAIN_TREE_ROOT) ) {
-                       continue;                       
+               if ( !(dom_list[i].trust_flags & NETR_TRUST_FLAG_TREEROOT) ) {
+                       continue;
                }
        
                /* Here's the forest root */
@@ -404,6 +445,10 @@ static void rescan_forest_root_trusts( void )
                                                &dom_list[i].sid );
                }
 
+               if (d == NULL) {
+                       continue;
+               }
+
                        DEBUG(10,("rescan_forest_root_trusts: Following trust path "
                          "for domain tree root %s (%s)\n",
                          d->name, d->alt_name ));
@@ -423,7 +468,7 @@ static void rescan_forest_root_trusts( void )
 }
 
 /********************************************************************
- scan the transitive forest trists (not our own)
+ scan the transitive forest trusts (not our own)
 ********************************************************************/
 
 
@@ -454,10 +499,10 @@ static void rescan_forest_trusts( void )
 
                if ( d && (d->internal || d->primary ) )
                        continue;               
-               
-               if ( (flags & DS_DOMAIN_DIRECT_INBOUND) &&
-                    (type == DS_DOMAIN_TRUST_TYPE_UPLEVEL) &&
-                    (attribs == DS_DOMAIN_TRUST_ATTRIB_FOREST_TRANSITIVE) )
+
+               if ( (flags & NETR_TRUST_FLAG_INBOUND) &&
+                    (type == NETR_TRUST_TYPE_UPLEVEL) &&
+                    (attribs == NETR_TRUST_ATTRIBUTE_FOREST_TRANSITIVE) )
                {
                        /* add the trusted domain if we don't know
                           about it */
@@ -468,6 +513,10 @@ static void rescan_forest_trusts( void )
                                                        &cache_methods,
                                                        &dom_list[i].sid );
                        }
+
+                       if (d == NULL) {
+                               continue;
+                       }
                        
                        DEBUG(10,("Following trust path for domain %s (%s)\n",
                                  d->name, d->alt_name ));
@@ -498,9 +547,13 @@ void rescan_trusted_domains( void )
            ((now-last_trustdom_scan) < WINBINDD_RESCAN_FREQ) )
                return;
                
-       /* clear the TRUSTDOM cache first */
-
-       wcache_tdc_clear();
+       /* I use to clear the cache here and start over but that
+          caused problems in child processes that needed the
+          trust dom list early on.  Removing it means we
+          could have some trusted domains listed that have been
+          removed from our primary domain's DC until a full
+          restart.  This should be ok since I think this is what
+          Windows does as well. */
 
        /* this will only add new domains we didn't already know about
           in the domain_list()*/
@@ -517,16 +570,16 @@ struct init_child_state {
        struct winbindd_domain *domain;
        struct winbindd_request *request;
        struct winbindd_response *response;
-       void (*continuation)(void *private_data, BOOL success);
+       void (*continuation)(void *private_data, bool success);
        void *private_data;
 };
 
-static void init_child_recv(void *private_data, BOOL success);
-static void init_child_getdc_recv(void *private_data, BOOL success);
+static void init_child_recv(void *private_data, bool success);
+static void init_child_getdc_recv(void *private_data, bool success);
 
 enum winbindd_result init_child_connection(struct winbindd_domain *domain,
                                           void (*continuation)(void *private_data,
-                                                               BOOL success),
+                                                               bool success),
                                           void *private_data)
 {
        TALLOC_CTX *mem_ctx;
@@ -565,7 +618,7 @@ enum winbindd_result init_child_connection(struct winbindd_domain *domain,
                /* The primary domain has to find the DC name itself */
                request->cmd = WINBINDD_INIT_CONNECTION;
                fstrcpy(request->domain_name, domain->name);
-               request->data.init_conn.is_primary = domain->internal ? False : True;
+               request->data.init_conn.is_primary = domain->primary ? true : false;
                fstrcpy(request->data.init_conn.dcname, "");
                async_request(mem_ctx, &domain->child, request, response,
                              init_child_recv, state);
@@ -584,7 +637,7 @@ enum winbindd_result init_child_connection(struct winbindd_domain *domain,
        return WINBINDD_PENDING;
 }
 
-static void init_child_getdc_recv(void *private_data, BOOL success)
+static void init_child_getdc_recv(void *private_data, bool success)
 {
        struct init_child_state *state =
                talloc_get_type_abort(private_data, struct init_child_state);
@@ -606,7 +659,7 @@ static void init_child_getdc_recv(void *private_data, BOOL success)
                      init_child_recv, state);
 }
 
-static void init_child_recv(void *private_data, BOOL success)
+static void init_child_recv(void *private_data, bool success)
 {
        struct init_child_state *state =
                talloc_get_type_abort(private_data, struct init_child_state);
@@ -666,8 +719,7 @@ enum winbindd_result winbindd_dual_init_connection(struct winbindd_domain *domai
 
        fstrcpy(state->response.data.domain_info.name, domain->name);
        fstrcpy(state->response.data.domain_info.alt_name, domain->alt_name);
-       fstrcpy(state->response.data.domain_info.sid,
-               sid_string_static(&domain->sid));
+       sid_to_fstring(state->response.data.domain_info.sid, &domain->sid);
        
        state->response.data.domain_info.native_mode
                = domain->native_mode;
@@ -680,7 +732,7 @@ enum winbindd_result winbindd_dual_init_connection(struct winbindd_domain *domai
 }
 
 /* Look up global info for the winbind daemon */
-BOOL init_domain_list(void)
+bool init_domain_list(void)
 {
        struct winbindd_domain *domain;
        int role = lp_server_role();
@@ -688,6 +740,27 @@ BOOL init_domain_list(void)
        /* Free existing list */
        free_domain_list();
 
+       /* BUILTIN domain */
+
+       domain = add_trusted_domain("BUILTIN", NULL, &builtin_passdb_methods,
+                                   &global_sid_Builtin);
+       if (domain) {
+               setup_domain_child(domain,
+                                  &domain->child);
+       }
+
+       /* Local SAM */
+
+       domain = add_trusted_domain(get_global_sam_name(), NULL,
+                                   &sam_passdb_methods, get_global_sam_sid());
+       if (domain) {
+               if ( role != ROLE_DOMAIN_MEMBER ) {
+                       domain->primary = True;
+               }
+               setup_domain_child(domain,
+                                  &domain->child);
+       }
+
        /* Add ourselves as the first entry. */
 
        if ( role == ROLE_DOMAIN_MEMBER ) {
@@ -702,8 +775,9 @@ BOOL init_domain_list(void)
                                             &cache_methods, &our_sid);
                if (domain) {
                        domain->primary = True;
-                       setup_domain_child(domain, &domain->child, NULL);
-               
+                       setup_domain_child(domain,
+                                          &domain->child);
+
                        /* Even in the parent winbindd we'll need to
                           talk to the DC, so try and see if we can
                           contact it. Theoretically this isn't neccessary
@@ -714,25 +788,6 @@ BOOL init_domain_list(void)
                }
        }
 
-       /* Local SAM */
-
-       domain = add_trusted_domain(get_global_sam_name(), NULL,
-                                   &passdb_methods, get_global_sam_sid());
-       if (domain) {
-               if ( role != ROLE_DOMAIN_MEMBER ) {
-                       domain->primary = True;
-               }
-               setup_domain_child(domain, &domain->child, NULL);
-       }
-
-       /* BUILTIN domain */
-
-       domain = add_trusted_domain("BUILTIN", NULL, &passdb_methods,
-                                   &global_sid_Builtin);
-       if (domain) {
-               setup_domain_child(domain, &domain->child, NULL);
-       }
-
        return True;
 }
 
@@ -762,12 +817,13 @@ void check_domain_trusted( const char *name, const DOM_SID *user_sid )
           forest trust */
 
        domain->active_directory = True;
-       domain->domain_flags = DS_DOMAIN_DIRECT_OUTBOUND;
-       domain->domain_type  = DS_DOMAIN_TRUST_TYPE_UPLEVEL;
+       domain->domain_flags = NETR_TRUST_FLAG_OUTBOUND;
+       domain->domain_type  = NETR_TRUST_TYPE_UPLEVEL;
        domain->internal = False;
        domain->online = True;  
 
-       setup_domain_child(domain, &domain->child, NULL);
+       setup_domain_child(domain,
+                          &domain->child);
 
        wcache_tdc_add_domain( domain );
 
@@ -916,8 +972,7 @@ struct winbindd_domain *find_lookup_domain_from_sid(const DOM_SID *sid)
         * one to contact the external DC's. On member servers the internal
         * domains are different: These are part of the local SAM. */
 
-       DEBUG(10, ("find_lookup_domain_from_sid(%s)\n",
-                  sid_string_static(sid)));
+       DEBUG(10, ("find_lookup_domain_from_sid(%s)\n", sid_string_dbg(sid)));
 
        if (IS_DC || is_internal_domain(sid) || is_in_internal_domain(sid)) {
                DEBUG(10, ("calling find_domain_from_sid\n"));
@@ -950,7 +1005,7 @@ struct winbindd_domain *find_lookup_domain_from_name(const char *domain_name)
 
 /* Lookup a sid in a domain from a name */
 
-BOOL winbindd_lookup_sid_by_name(TALLOC_CTX *mem_ctx,
+bool winbindd_lookup_sid_by_name(TALLOC_CTX *mem_ctx,
                                 enum winbindd_cmd orig_cmd,
                                 struct winbindd_domain *domain, 
                                 const char *domain_name,
@@ -982,7 +1037,7 @@ BOOL winbindd_lookup_sid_by_name(TALLOC_CTX *mem_ctx,
  * @retval True if the name exists, in which case @p name and @p type
  * are set, otherwise False.
  **/
-BOOL winbindd_lookup_name_by_sid(TALLOC_CTX *mem_ctx,
+bool winbindd_lookup_name_by_sid(TALLOC_CTX *mem_ctx,
                                 struct winbindd_domain *domain,
                                 DOM_SID *sid,
                                 char **dom_name,
@@ -1020,13 +1075,12 @@ void free_getent_state(struct getent_state *state)
        temp = state;
 
        while(temp != NULL) {
-               struct getent_state *next;
+               struct getent_state *next = temp->next;
 
                /* Free sam entries then list entry */
 
                SAFE_FREE(state->sam_entries);
                DLIST_REMOVE(state, state);
-               next = temp->next;
 
                SAFE_FREE(temp);
                temp = next;
@@ -1035,7 +1089,7 @@ void free_getent_state(struct getent_state *state)
 
 /* Is this a domain which we may assume no DOMAIN\ prefix? */
 
-static BOOL assume_domain(const char *domain)
+static bool assume_domain(const char *domain)
 {
        /* never assume the domain on a standalone server */
 
@@ -1063,7 +1117,7 @@ static BOOL assume_domain(const char *domain)
 
 /* Parse a string of the form DOMAIN\user into a domain and a user */
 
-BOOL parse_domain_user(const char *domuser, fstring domain, fstring user)
+bool parse_domain_user(const char *domuser, fstring domain, fstring user)
 {
        char *p = strchr(domuser,*lp_winbind_separator());
 
@@ -1088,7 +1142,7 @@ BOOL parse_domain_user(const char *domuser, fstring domain, fstring user)
        return True;
 }
 
-BOOL parse_domain_user_talloc(TALLOC_CTX *mem_ctx, const char *domuser,
+bool parse_domain_user_talloc(TALLOC_CTX *mem_ctx, const char *domuser,
                              char **domain, char **user)
 {
        fstring fstr_domain, fstr_user;
@@ -1100,6 +1154,31 @@ BOOL parse_domain_user_talloc(TALLOC_CTX *mem_ctx, const char *domuser,
        return ((*domain != NULL) && (*user != NULL));
 }
 
+/* add a domain user name to a buffer */
+void parse_add_domuser(void *buf, char *domuser, int *len)
+{
+       fstring domain;
+       char *p, *user;
+
+       user = domuser;
+       p = strchr(domuser, *lp_winbind_separator());
+
+       if (p) {
+
+               fstrcpy(domain, domuser);
+               domain[PTR_DIFF(p, domuser)] = 0;
+               p++;
+
+               if (assume_domain(domain)) {
+
+                       user = p;
+                       *len -= (PTR_DIFF(p, domuser));
+               }
+       }
+
+       safe_strcpy((char *)buf, user, *len);
+}
+
 /* Ensure an incoming username from NSS is fully qualified. Replace the
    incoming fstring with DOMAIN <separator> user. Returns the same
    values as parse_domain_user() but also replaces the incoming username.
@@ -1109,7 +1188,7 @@ BOOL parse_domain_user_talloc(TALLOC_CTX *mem_ctx, const char *domuser,
    really should be changed to use this instead of doing things
    by hand. JRA. */
 
-BOOL canonicalize_username(fstring username_inout, fstring domain, fstring user)
+bool canonicalize_username(fstring username_inout, fstring domain, fstring user)
 {
        if (!parse_domain_user(username_inout, domain, user)) {
                return False;
@@ -1134,7 +1213,7 @@ BOOL canonicalize_username(fstring username_inout, fstring domain, fstring user)
 
     We always canonicalize as UPPERCASE DOMAIN, lowercase username.
 */
-void fill_domain_username(fstring name, const char *domain, const char *user, BOOL can_assume)
+void fill_domain_username(fstring name, const char *domain, const char *user, bool can_assume)
 {
        fstring tmp_user;
 
@@ -1150,6 +1229,33 @@ void fill_domain_username(fstring name, const char *domain, const char *user, BO
        }
 }
 
+/**
+ * talloc version of fill_domain_username()
+ * return NULL on talloc failure.
+ */
+char *fill_domain_username_talloc(TALLOC_CTX *mem_ctx,
+                                 const char *domain,
+                                 const char *user,
+                                 bool can_assume)
+{
+       char *tmp_user, *name;
+
+       tmp_user = talloc_strdup(mem_ctx, user);
+       strlower_m(tmp_user);
+
+       if (can_assume && assume_domain(domain)) {
+               name = tmp_user;
+       } else {
+               name = talloc_asprintf(mem_ctx, "%s%c%s",
+                                      domain,
+                                      *lp_winbind_separator(),
+                                      tmp_user);
+               TALLOC_FREE(tmp_user);
+       }
+
+       return name;
+}
+
 /*
  * Winbindd socket accessor functions
  */
@@ -1164,6 +1270,53 @@ char *get_winbind_priv_pipe_dir(void)
        return lock_path(WINBINDD_PRIV_SOCKET_SUBDIR);
 }
 
+/* Open the winbindd socket */
+
+static int _winbindd_socket = -1;
+static int _winbindd_priv_socket = -1;
+
+int open_winbindd_socket(void)
+{
+       if (_winbindd_socket == -1) {
+               _winbindd_socket = create_pipe_sock(
+                       get_winbind_pipe_dir(), WINBINDD_SOCKET_NAME, 0755);
+               DEBUG(10, ("open_winbindd_socket: opened socket fd %d\n",
+                          _winbindd_socket));
+       }
+
+       return _winbindd_socket;
+}
+
+int open_winbindd_priv_socket(void)
+{
+       if (_winbindd_priv_socket == -1) {
+               _winbindd_priv_socket = create_pipe_sock(
+                       get_winbind_priv_pipe_dir(), WINBINDD_SOCKET_NAME, 0750);
+               DEBUG(10, ("open_winbindd_priv_socket: opened socket fd %d\n",
+                          _winbindd_priv_socket));
+       }
+
+       return _winbindd_priv_socket;
+}
+
+/* Close the winbindd socket */
+
+void close_winbindd_socket(void)
+{
+       if (_winbindd_socket != -1) {
+               DEBUG(10, ("close_winbindd_socket: closing socket fd %d\n",
+                          _winbindd_socket));
+               close(_winbindd_socket);
+               _winbindd_socket = -1;
+       }
+       if (_winbindd_priv_socket != -1) {
+               DEBUG(10, ("close_winbindd_socket: closing socket fd %d\n",
+                          _winbindd_priv_socket));
+               close(_winbindd_priv_socket);
+               _winbindd_priv_socket = -1;
+       }
+}
+
 /*
  * Client list accessor functions
  */
@@ -1223,16 +1376,13 @@ NTSTATUS lookup_usergroups_cached(struct winbindd_domain *domain,
                                  const DOM_SID *user_sid,
                                  uint32 *p_num_groups, DOM_SID **user_sids)
 {
-       NET_USER_INFO_3 *info3 = NULL;
+       struct netr_SamInfo3 *info3 = NULL;
        NTSTATUS status = NT_STATUS_NO_MEMORY;
-       int i;
        size_t num_groups = 0;
-       DOM_SID group_sid, primary_group;
-       
+
        DEBUG(3,(": lookup_usergroups_cached\n"));
-       
+
        *user_sids = NULL;
-       num_groups = 0;
        *p_num_groups = 0;
 
        info3 = netsamlogon_cache_get(mem_ctx, user_sid);
@@ -1241,46 +1391,22 @@ NTSTATUS lookup_usergroups_cached(struct winbindd_domain *domain,
                return NT_STATUS_OBJECT_NAME_NOT_FOUND;
        }
 
-       if (info3->num_groups == 0) {
+       if (info3->base.groups.count == 0) {
                TALLOC_FREE(info3);
                return NT_STATUS_UNSUCCESSFUL;
        }
-       
-       /* always add the primary group to the sid array */
-       sid_compose(&primary_group, &info3->dom_sid.sid, info3->user_rid);
-       
-       if (!add_sid_to_array(mem_ctx, &primary_group, user_sids, &num_groups)) {
-               TALLOC_FREE(info3);
-               return NT_STATUS_NO_MEMORY;
-       }
 
-       for (i=0; i<info3->num_groups; i++) {
-               sid_copy(&group_sid, &info3->dom_sid.sid);
-               sid_append_rid(&group_sid, info3->gids[i].g_rid);
+       /* Skip Domain local groups outside our domain.
+          We'll get these from the getsidaliases() RPC call. */
+       status = sid_array_from_info3(mem_ctx, info3,
+                                     user_sids,
+                                     &num_groups,
+                                     false, true);
 
-               if (!add_sid_to_array(mem_ctx, &group_sid, user_sids,
-                                &num_groups)) {
-                       TALLOC_FREE(info3);
-                       return NT_STATUS_NO_MEMORY;
-               }
-       }
-
-       /* Add any Universal groups in the other_sids list */
-
-       for (i=0; i<info3->num_other_sids; i++) {
-               /* Skip Domain local groups outside our domain.
-                  We'll get these from the getsidaliases() RPC call. */
-               if (info3->other_sids_attrib[i] & SE_GROUP_RESOURCE)
-                       continue;
-
-               if (!add_sid_to_array(mem_ctx, &info3->other_sids[i].sid,
-                                     user_sids, &num_groups))
-               {
-                       TALLOC_FREE(info3);
-                       return NT_STATUS_NO_MEMORY;                     
-               }
+       if (!NT_STATUS_IS_OK(status)) {
+               TALLOC_FREE(info3);
+               return status;
        }
-       
 
        TALLOC_FREE(info3);
        *p_num_groups = num_groups;
@@ -1295,70 +1421,168 @@ NTSTATUS lookup_usergroups_cached(struct winbindd_domain *domain,
  We use this to remove spaces from user and group names
 ********************************************************************/
 
-void ws_name_replace( char *name, char replace )
+NTSTATUS normalize_name_map(TALLOC_CTX *mem_ctx,
+                            struct winbindd_domain *domain,
+                            char *name,
+                            char **normalized)
 {
-       char replace_char[2] = { 0x0, 0x0 };
-    
-       if ( !lp_winbind_normalize_names() || (replace == '\0') ) 
-               return;
+       NTSTATUS nt_status;
+
+       if (!name || !normalized) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
 
-       replace_char[0] = replace;      
-       all_string_sub( name, " ", replace_char, 0 );
+       if (!lp_winbind_normalize_names()) {
+               return NT_STATUS_PROCEDURE_NOT_FOUND;
+       }
 
-       return; 
+       /* Alias support and whitespace replacement are mutually
+          exclusive */
+
+       nt_status = resolve_username_to_alias(mem_ctx, domain,
+                                             name, normalized );
+       if (NT_STATUS_IS_OK(nt_status)) {
+               /* special return code to let the caller know we
+                  mapped to an alias */
+               return NT_STATUS_FILE_RENAMED;
+       }
+
+       /* check for an unreachable domain */
+
+       if (NT_STATUS_EQUAL(nt_status, NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND)) {
+               DEBUG(5,("normalize_name_map: Setting domain %s offline\n",
+                        domain->name));
+               set_domain_offline(domain);
+               return nt_status;
+       }
+
+       /* deal with whitespace */
+
+       *normalized = talloc_strdup(mem_ctx, name);
+       if (!(*normalized)) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       all_string_sub( *normalized, " ", "_", 0 );
+
+       return NT_STATUS_OK;
 }
 
 /*********************************************************************
- We use this to do the inverse of ws_name_replace()
+ We use this to do the inverse of normalize_name_map()
 ********************************************************************/
 
-void ws_name_return( char *name, char replace )
+NTSTATUS normalize_name_unmap(TALLOC_CTX *mem_ctx,
+                             char *name,
+                             char **normalized)
 {
-       char replace_char[2] = { 0x0, 0x0 };
-    
-       if ( !lp_winbind_normalize_names() || (replace == '\0') ) 
-               return;
+       NTSTATUS nt_status;
+       struct winbindd_domain *domain = find_our_domain();
+
+       if (!name || !normalized) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
        
-       replace_char[0] = replace;      
-       all_string_sub( name, replace_char, " ", 0 );
+       if (!lp_winbind_normalize_names()) {
+               return NT_STATUS_PROCEDURE_NOT_FOUND;
+       }
 
-       return; 
+       /* Alias support and whitespace replacement are mutally
+          exclusive */
+
+       /* When mapping from an alias to a username, we don't know the
+          domain.  But we only need a domain structure to cache
+          a successful lookup , so just our own domain structure for
+          the seqnum. */
+
+       nt_status = resolve_alias_to_username(mem_ctx, domain,
+                                             name, normalized);
+       if (NT_STATUS_IS_OK(nt_status)) {
+               /* Special return code to let the caller know we mapped
+                  from an alias */
+               return NT_STATUS_FILE_RENAMED;
+       }
+
+       /* check for an unreachable domain */
+
+       if (NT_STATUS_EQUAL(nt_status, NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND)) {
+               DEBUG(5,("normalize_name_unmap: Setting domain %s offline\n",
+                        domain->name));
+               set_domain_offline(domain);
+               return nt_status;
+       }
+
+       /* deal with whitespace */
+
+       *normalized = talloc_strdup(mem_ctx, name);
+       if (!(*normalized)) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       all_string_sub(*normalized, "_", " ", 0);
+
+       return NT_STATUS_OK;
 }
 
 /*********************************************************************
  ********************************************************************/
 
-BOOL winbindd_can_contact_domain( struct winbindd_domain *domain )
+bool winbindd_can_contact_domain(struct winbindd_domain *domain)
 {
+       struct winbindd_tdc_domain *tdc = NULL;
+       TALLOC_CTX *frame = talloc_stackframe();
+       bool ret = false;
+
        /* We can contact the domain if it is our primary domain */
 
-       if ( domain->primary )
-               return True;
+       if (domain->primary) {
+               return true;
+       }
 
-       /* Can always contact a domain that is in out forest */
+       /* Trust the TDC cache and not the winbindd_domain flags */
 
-       if ( domain->domain_flags & DS_DOMAIN_IN_FOREST )
-               return True;    
+       if ((tdc = wcache_tdc_fetch_domain(frame, domain->name)) == NULL) {
+               DEBUG(10,("winbindd_can_contact_domain: %s not found in cache\n",
+                         domain->name));
+               return false;
+       }
 
-       /* We cannot contact the domain if it is running AD and
-          we have no inbound trust */
+       /* Can always contact a domain that is in out forest */
 
-       if ( domain->active_directory && 
-            ((domain->domain_flags&DS_DOMAIN_DIRECT_INBOUND) != DS_DOMAIN_DIRECT_INBOUND) ) 
-       {
-               return False;
+       if (tdc->trust_flags & NETR_TRUST_FLAG_IN_FOREST) {
+               ret = true;
+               goto done;
        }
        
+       /*
+        * On a _member_ server, we cannot contact the domain if it
+        * is running AD and we have no inbound trust.
+        */
+
+       if (!IS_DC && 
+            domain->active_directory &&
+           ((tdc->trust_flags & NETR_TRUST_FLAG_INBOUND) != NETR_TRUST_FLAG_INBOUND))
+       {
+               DEBUG(10, ("winbindd_can_contact_domain: %s is an AD domain "
+                          "and we have no inbound trust.\n", domain->name));
+               goto done;
+       }
+
        /* Assume everything else is ok (probably not true but what
           can you do?) */
+
+       ret = true;     
+
+done:  
+       talloc_destroy(frame);
        
-       return True;    
+       return ret;     
 }
 
 /*********************************************************************
  ********************************************************************/
 
-BOOL winbindd_internal_child(struct winbindd_child *child)
+bool winbindd_internal_child(struct winbindd_child *child)
 {
        if ((child == idmap_child()) || (child == locator_child())) {
                return True;
@@ -1375,6 +1599,7 @@ BOOL winbindd_internal_child(struct winbindd_child *child)
 static void winbindd_set_locator_kdc_env(const struct winbindd_domain *domain)
 {
        char *var = NULL;
+       char addr[INET6_ADDRSTRLEN];
        const char *kdc = NULL;
        int lvl = 11;
 
@@ -1388,8 +1613,9 @@ static void winbindd_set_locator_kdc_env(const struct winbindd_domain *domain)
                return;
        }
 
-       kdc = inet_ntoa(domain->dcaddr.sin_addr);
-       if (!kdc) {
+       print_sockaddr(addr, sizeof(addr), &domain->dcaddr);
+       kdc = addr;
+       if (!*kdc) {
                DEBUG(lvl,("winbindd_set_locator_kdc_env: %s no DC IP\n",
                        domain->alt_name));
                kdc = domain->dcname;
@@ -1401,8 +1627,8 @@ static void winbindd_set_locator_kdc_env(const struct winbindd_domain *domain)
                return;
        }
 
-       if (asprintf(&var, "%s_%s", WINBINDD_LOCATOR_KDC_ADDRESS,
-                    strupper_static(domain->alt_name)) == -1) {
+       if (asprintf_strupper_m(&var, "%s_%s", WINBINDD_LOCATOR_KDC_ADDRESS,
+                               domain->alt_name) == -1) {
                return;
        }
 
@@ -1438,8 +1664,8 @@ void winbindd_unset_locator_kdc_env(const struct winbindd_domain *domain)
                return;
        }
 
-       if (asprintf(&var, "%s_%s", WINBINDD_LOCATOR_KDC_ADDRESS,
-                    strupper_static(domain->alt_name)) == -1) {
+       if (asprintf_strupper_m(&var, "%s_%s", WINBINDD_LOCATOR_KDC_ADDRESS,
+                               domain->alt_name) == -1) {
                return;
        }
 
@@ -1459,3 +1685,15 @@ void winbindd_unset_locator_kdc_env(const struct winbindd_domain *domain)
 }
 
 #endif /* HAVE_KRB5_LOCATE_PLUGIN_H */
+
+void set_auth_errors(struct winbindd_response *resp, NTSTATUS result)
+{
+       resp->data.auth.nt_status = NT_STATUS_V(result);
+       fstrcpy(resp->data.auth.nt_status_string, nt_errstr(result));
+
+       /* we might have given a more useful error above */
+       if (*resp->data.auth.error_string == '\0')
+               fstrcpy(resp->data.auth.error_string,
+                       get_friendly_nt_error_msg(result));
+       resp->data.auth.pam_error = nt_status_to_pam(result);
+}