winbindd: don't leak state_path onto talloc tos
[bbaumbach/samba-autobuild/.git] / source3 / winbindd / winbindd.c
index 248f747ee49a66f2b2426393654f58e9fbf69635..4978c97aaa89b00314c3b72b56084c69c9231b3b 100644 (file)
@@ -1,4 +1,4 @@
-/* 
+/*
    Unix SMB/CIFS implementation.
 
    Winbind daemon for ntdom nss module
 #include "../librpc/gen_ndr/srv_lsa.h"
 #include "../librpc/gen_ndr/srv_samr.h"
 #include "secrets.h"
+#include "rpc_client/cli_netlogon.h"
 #include "idmap.h"
 #include "lib/addrchange.h"
 #include "serverid.h"
 #include "auth.h"
 #include "messages.h"
+#include "../lib/util/pidfile.h"
+#include "util_cluster.h"
+#include "source4/lib/messaging/irpc.h"
+#include "source4/lib/messaging/messaging.h"
+#include "lib/param/param.h"
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_WINBIND
@@ -48,14 +54,69 @@ static bool interactive = False;
 
 extern bool override_logfile;
 
+struct tevent_context *winbind_event_context(void)
+{
+       static struct tevent_context *ev = NULL;
+
+       if (ev != NULL) {
+               return ev;
+       }
+
+       /*
+        * Note we MUST use the NULL context here, not the autofree context,
+        * to avoid side effects in forked children exiting.
+        */
+       ev = samba_tevent_context_init(NULL);
+       if (ev == NULL) {
+               smb_panic("Could not init winbindd's messaging context.\n");
+       }
+       return ev;
+}
+
 struct messaging_context *winbind_messaging_context(void)
 {
-       struct messaging_context *msg_ctx = server_messaging_context();
-       if (likely(msg_ctx != NULL)) {
-               return msg_ctx;
+       static struct messaging_context *msg = NULL;
+
+       if (msg != NULL) {
+               return msg;
+       }
+
+       /*
+        * Note we MUST use the NULL context here, not the autofree context,
+        * to avoid side effects in forked children exiting.
+        */
+       msg = messaging_init(NULL, winbind_event_context());
+       if (msg == NULL) {
+               smb_panic("Could not init winbindd's messaging context.\n");
+       }
+       return msg;
+}
+
+struct imessaging_context *winbind_imessaging_context(void)
+{
+       static struct imessaging_context *msg = NULL;
+       struct loadparm_context *lp_ctx;
+
+       if (msg != NULL) {
+               return msg;
+       }
+
+       lp_ctx = loadparm_init_s3(NULL, loadparm_s3_helpers());
+       if (lp_ctx == NULL) {
+               smb_panic("Could not load smb.conf to init winbindd's imessaging context.\n");
+       }
+
+       /*
+        * Note we MUST use the NULL context here, not the autofree context,
+        * to avoid side effects in forked children exiting.
+        */
+       msg = imessaging_init(NULL, lp_ctx, procid_self(), winbind_event_context(), false);
+       talloc_unlink(NULL, lp_ctx);
+
+       if (msg == NULL) {
+               smb_panic("Could not init winbindd's messaging context.\n");
        }
-       smb_panic("Could not init winbindd's messaging context.\n");
-       return NULL;
+       return msg;
 }
 
 /* Reload configuration */
@@ -65,7 +126,7 @@ static bool reload_services_file(const char *lfile)
        bool ret;
 
        if (lp_loaded()) {
-               char *fname = lp_configfile();
+               char *fname = lp_next_configfile(talloc_tos());
 
                if (file_exist(fname) && !strcsequal(fname,get_dyn_CONFIGFILE())) {
                        set_dyn_CONFIGFILE(fname);
@@ -160,7 +221,7 @@ static void terminate(bool is_parent)
                char *path = NULL;
 
                if (asprintf(&path, "%s/%s",
-                       get_winbind_pipe_dir(), WINBINDD_SOCKET_NAME) > 0) {
+                       lp_winbindd_socket_directory(), WINBINDD_SOCKET_NAME) > 0) {
                        unlink(path);
                        SAFE_FREE(path);
                }
@@ -183,8 +244,10 @@ static void terminate(bool is_parent)
 #endif
 
        if (is_parent) {
-               serverid_deregister(procid_self());
-               pidfile_unlink();
+               struct messaging_context *msg = winbind_messaging_context();
+               struct server_id self = messaging_server_id(msg);
+               serverid_deregister(self);
+               pidfile_unlink(lp_pid_directory(), "winbindd");
        }
 
        exit(0);
@@ -215,7 +278,7 @@ static void winbindd_stdin_handler(struct tevent_context *ev,
        char c;
        if (read(0, &c, 1) != 1) {
                bool *is_parent = talloc_get_type_abort(private_data, bool);
-               
+
                /* we have reached EOF on stdin, which means the
                   parent has exited. Shutdown the server */
                DEBUG(0,("EOF on stdin (is_parent=%d)\n",
@@ -277,20 +340,33 @@ bool winbindd_setup_stdin_handler(bool parent, bool foreground)
        bool *is_parent;
 
        if (foreground) {
+               struct stat st;
+
                is_parent = talloc(winbind_event_context(), bool);
                if (!is_parent) {
                        return false;
                }
-               
+
                *is_parent = parent;
 
                /* if we are running in the foreground then look for
                   EOF on stdin, and exit if it happens. This allows
                   us to die if the parent process dies
+                  Only do this on a pipe or socket, no other device.
                */
-               tevent_add_fd(winbind_event_context(), is_parent, 0, TEVENT_FD_READ, winbindd_stdin_handler, is_parent);
+               if (fstat(0, &st) != 0) {
+                       return false;
+               }
+               if (S_ISFIFO(st.st_mode) || S_ISSOCK(st.st_mode)) {
+                       tevent_add_fd(winbind_event_context(),
+                                       is_parent,
+                                       0,
+                                       TEVENT_FD_READ,
+                                       winbindd_stdin_handler,
+                                       is_parent);
+               }
        }
-       
+
        return true;
 }
 
@@ -620,6 +696,7 @@ static void process_request(struct winbindd_cli_state *state)
 
        state->cmd_name = "unknown request";
        state->recv_fn = NULL;
+       state->last_access = time(NULL);
 
        /* Process command */
 
@@ -816,7 +893,7 @@ static void new_connection(int listen_sock, bool privileged)
 
        if (sock == -1) {
                if (errno != EINTR) {
-                       DEBUG(0, ("Faild to accept socket - %s\n",
+                       DEBUG(0, ("Failed to accept socket - %s\n",
                                  strerror(errno)));
                }
                return;
@@ -921,7 +998,8 @@ static void remove_client(struct winbindd_cli_state *state)
 /* Is a client idle? */
 
 static bool client_is_idle(struct winbindd_cli_state *state) {
-  return (state->response == NULL &&
+  return (state->request == NULL &&
+         state->response == NULL &&
          !state->pwent_state && !state->grent_state);
 }
 
@@ -953,6 +1031,41 @@ static bool remove_idle_client(void)
        return False;
 }
 
+/*
+ * Terminate all clients whose requests have taken longer than
+ * "winbind request timeout" seconds to process, or have been
+ * idle for more than "winbind request timeout" seconds.
+ */
+
+static void remove_timed_out_clients(void)
+{
+       struct winbindd_cli_state *state, *next = NULL;
+       time_t curr_time = time(NULL);
+       int timeout_val = lp_winbind_request_timeout();
+
+       for (state = winbindd_client_list(); state; state = next) {
+               time_t expiry_time;
+
+               next = state->next;
+               expiry_time = state->last_access + timeout_val;
+
+               if (curr_time > expiry_time) {
+                       if (client_is_idle(state)) {
+                               DEBUG(5,("Idle client timed out, "
+                                       "shutting down sock %d, pid %u\n",
+                                       state->sock,
+                                       (unsigned int)state->pid));
+                       } else {
+                               DEBUG(5,("Client request timed out, "
+                                       "shutting down sock %d, pid %u\n",
+                                       state->sock,
+                                       (unsigned int)state->pid));
+                       }
+                       remove_client(state);
+               }
+       }
+}
+
 struct winbindd_listen_state {
        bool privileged;
        int fd;
@@ -978,6 +1091,7 @@ static void winbindd_listen_fde_handler(struct tevent_context *ev,
                        break;
                }
        }
+       remove_timed_out_clients();
        new_connection(s->fd, s->privileged);
 }
 
@@ -985,11 +1099,6 @@ static void winbindd_listen_fde_handler(struct tevent_context *ev,
  * Winbindd socket accessor functions
  */
 
-const char *get_winbind_pipe_dir(void)
-{
-       return lp_parm_const_string(-1, "winbindd", "socket dir", get_dyn_WINBINDD_SOCKET_DIR());
-}
-
 char *get_winbind_priv_pipe_dir(void)
 {
        return state_path(WINBINDD_PRIV_SOCKET_SUBDIR);
@@ -1001,6 +1110,7 @@ static bool winbindd_setup_listeners(void)
        struct winbindd_listen_state *priv_state = NULL;
        struct tevent_fd *fde;
        int rc;
+       char *socket_path;
 
        pub_state = talloc(winbind_event_context(),
                           struct winbindd_listen_state);
@@ -1010,7 +1120,7 @@ static bool winbindd_setup_listeners(void)
 
        pub_state->privileged = false;
        pub_state->fd = create_pipe_sock(
-               get_winbind_pipe_dir(), WINBINDD_SOCKET_NAME, 0755);
+               lp_winbindd_socket_directory(), WINBINDD_SOCKET_NAME, 0755);
        if (pub_state->fd == -1) {
                goto failed;
        }
@@ -1034,9 +1144,15 @@ static bool winbindd_setup_listeners(void)
                goto failed;
        }
 
+       socket_path = get_winbind_priv_pipe_dir();
+       if (socket_path == NULL) {
+               goto failed;
+       }
+
        priv_state->privileged = true;
        priv_state->fd = create_pipe_sock(
-               get_winbind_priv_pipe_dir(), WINBINDD_SOCKET_NAME, 0750);
+               socket_path, WINBINDD_SOCKET_NAME, 0750);
+       TALLOC_FREE(socket_path);
        if (priv_state->fd == -1) {
                goto failed;
        }
@@ -1071,8 +1187,10 @@ bool winbindd_use_cache(void)
        return !opt_nocache;
 }
 
-void winbindd_register_handlers(bool foreground)
+static void winbindd_register_handlers(struct messaging_context *msg_ctx,
+                                      bool foreground)
 {
+       NTSTATUS status;
        /* Setup signal handlers */
 
        if (!winbindd_setup_sig_term_handler(true))
@@ -1098,7 +1216,7 @@ void winbindd_register_handlers(bool foreground)
 
        /* get broadcast messages */
 
-       if (!serverid_register(procid_self(),
+       if (!serverid_register(messaging_server_id(msg_ctx),
                               FLAG_MSG_GENERAL |
                               FLAG_MSG_WINBIND |
                               FLAG_MSG_DBWRAP)) {
@@ -1108,36 +1226,42 @@ void winbindd_register_handlers(bool foreground)
 
        /* React on 'smbcontrol winbindd reload-config' in the same way
           as to SIGHUP signal */
-       messaging_register(winbind_messaging_context(), NULL,
+       messaging_register(msg_ctx, NULL,
                           MSG_SMB_CONF_UPDATED, msg_reload_services);
-       messaging_register(winbind_messaging_context(), NULL,
+       messaging_register(msg_ctx, NULL,
                           MSG_SHUTDOWN, msg_shutdown);
 
        /* Handle online/offline messages. */
-       messaging_register(winbind_messaging_context(), NULL,
+       messaging_register(msg_ctx, NULL,
                           MSG_WINBIND_OFFLINE, winbind_msg_offline);
-       messaging_register(winbind_messaging_context(), NULL,
+       messaging_register(msg_ctx, NULL,
                           MSG_WINBIND_ONLINE, winbind_msg_online);
-       messaging_register(winbind_messaging_context(), NULL,
+       messaging_register(msg_ctx, NULL,
                           MSG_WINBIND_ONLINESTATUS, winbind_msg_onlinestatus);
 
+       /* Handle domain online/offline messages for domains */
+       messaging_register(winbind_messaging_context(), NULL,
+                          MSG_WINBIND_DOMAIN_OFFLINE, winbind_msg_domain_offline);
        messaging_register(winbind_messaging_context(), NULL,
+                          MSG_WINBIND_DOMAIN_ONLINE, winbind_msg_domain_online);
+
+       messaging_register(msg_ctx, NULL,
                           MSG_DUMP_EVENT_LIST, winbind_msg_dump_event_list);
 
-       messaging_register(winbind_messaging_context(), NULL,
+       messaging_register(msg_ctx, NULL,
                           MSG_WINBIND_VALIDATE_CACHE,
                           winbind_msg_validate_cache);
 
-       messaging_register(winbind_messaging_context(), NULL,
+       messaging_register(msg_ctx, NULL,
                           MSG_WINBIND_DUMP_DOMAIN_LIST,
                           winbind_msg_dump_domain_list);
 
-       messaging_register(winbind_messaging_context(), NULL,
+       messaging_register(msg_ctx, NULL,
                           MSG_WINBIND_IP_DROPPED,
                           winbind_msg_ip_dropped_parent);
 
        /* Register handler for MSG_DEBUG. */
-       messaging_register(winbind_messaging_context(), NULL,
+       messaging_register(msg_ctx, NULL,
                           MSG_DEBUG,
                           winbind_msg_debug);
 
@@ -1166,6 +1290,12 @@ void winbindd_register_handlers(bool foreground)
                }
        }
 
+       status = wb_irpc_register();
+
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0, ("Could not register IRPC handlers\n"));
+               exit(1);
+       }
 }
 
 struct winbindd_addrchanged_state {
@@ -1254,7 +1384,7 @@ static void winbindd_addr_changed(struct tevent_req *req)
 
 /* Main function */
 
-int main(int argc, char **argv, char **envp)
+int main(int argc, const char **argv)
 {
        static bool is_daemon = False;
        static bool Fork = True;
@@ -1281,6 +1411,7 @@ int main(int argc, char **argv, char **envp)
        int opt;
        TALLOC_CTX *frame;
        NTSTATUS status;
+       bool ok;
 
        /*
         * Do this before any other talloc operation
@@ -1288,6 +1419,12 @@ int main(int argc, char **argv, char **envp)
        talloc_enable_null_tracking();
        frame = talloc_stackframe();
 
+       /*
+        * We want total control over the permissions on created files,
+        * so set our umask to 0.
+        */
+       umask(0);
+
        setup_logging("winbindd", DEBUG_DEFAULT_STDOUT);
 
        /* glibc (?) likes to print "User defined signal 1" and exit if a
@@ -1297,7 +1434,7 @@ int main(int argc, char **argv, char **envp)
        CatchSignal(SIGUSR2, SIG_IGN);
 
        fault_setup();
-       dump_core_setup("winbindd", lp_logfile());
+       dump_core_setup("winbindd", lp_logfile(talloc_tos()));
 
        load_case_tables();
 
@@ -1317,7 +1454,7 @@ int main(int argc, char **argv, char **envp)
 
        /* Initialise samba/rpc client stuff */
 
-       pc = poptGetContext("winbindd", argc, (const char **)argv, long_options, 0);
+       pc = poptGetContext("winbindd", argc, argv, long_options, 0);
 
        while ((opt = poptGetNextOpt(pc)) != -1) {
                switch (opt) {
@@ -1350,6 +1487,14 @@ int main(int argc, char **argv, char **envp)
                }
        }
 
+       /* We call dump_core_setup one more time because the command line can
+        * set the log file or the log-basename and this will influence where
+        * cores are stored. Without this call get_dyn_LOGFILEBASE will be
+        * the default value derived from build's prefix. For EOM this value
+        * is often not related to the path where winbindd is actually run
+        * in production.
+        */
+       dump_core_setup("winbindd", lp_logfile(talloc_tos()));
        if (is_daemon && interactive) {
                d_fprintf(stderr,"\nERROR: "
                          "Option -i|--interactive is not allowed together with -D|--daemon\n\n");
@@ -1389,6 +1534,22 @@ int main(int argc, char **argv, char **envp)
                DEBUG(0, ("error opening config file '%s'\n", get_dyn_CONFIGFILE()));
                exit(1);
        }
+       /* After parsing the configuration file we setup the core path one more time
+        * as the log file might have been set in the configuration and cores's
+        * path is by default basename(lp_logfile()).
+        */
+       dump_core_setup("winbindd", lp_logfile(talloc_tos()));
+
+       if (lp_server_role() == ROLE_ACTIVE_DIRECTORY_DC
+           && !lp_parm_bool(-1, "server role check", "inhibit", false)) {
+               DEBUG(0, ("server role = 'active directory domain controller' not compatible with running the winbindd binary. \n"));
+               DEBUGADD(0, ("You should start 'samba' instead, and it will control starting the internal AD DC winbindd implementation, which is not the same as this one\n"));
+               exit(1);
+       }
+
+       if (!cluster_probe_ok()) {
+               exit(1);
+       }
 
        /* Initialise messaging system */
 
@@ -1401,12 +1562,18 @@ int main(int argc, char **argv, char **envp)
                exit(1);
        }
 
-       if (!directory_exist(lp_lockdir())) {
-               mkdir(lp_lockdir(), 0755);
+       ok = directory_create_or_exist(lp_lock_directory(), 0755);
+       if (!ok) {
+               DEBUG(0, ("Failed to create directory %s for lock files - %s\n",
+                         lp_lock_directory(), strerror(errno)));
+               exit(1);
        }
 
-       if (!directory_exist(lp_piddir())) {
-               mkdir(lp_piddir(), 0755);
+       ok = directory_create_or_exist(lp_pid_directory(), 0755);
+       if (!ok) {
+               DEBUG(0, ("Failed to create directory %s for pid files - %s\n",
+                         lp_pid_directory(), strerror(errno)));
+               exit(1);
        }
 
        /* Setup names. */
@@ -1422,6 +1589,13 @@ int main(int argc, char **argv, char **envp)
                return False;
        }
 
+       status = rpccli_pre_open_netlogon_creds();
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0, ("rpccli_pre_open_netlogon_creds() - %s\n",
+                         nt_errstr(status)));
+               exit(1);
+       }
+
        /* Unblock all signals we are interested in as they may have been
           blocked by the parent process. */
 
@@ -1436,7 +1610,7 @@ int main(int argc, char **argv, char **envp)
        if (!interactive)
                become_daemon(Fork, no_process_group, log_stdout);
 
-       pidfile_create("winbindd");
+       pidfile_create(lp_pid_directory(), "winbindd");
 
 #if HAVE_SETPGID
        /*
@@ -1458,8 +1632,7 @@ int main(int argc, char **argv, char **envp)
                                   winbind_event_context(),
                                   false);
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0,("reinit_after_fork() failed\n"));
-               exit(1);
+               exit_daemon("Winbindd reinit_after_fork() failed", map_errno_from_nt_status(status));
        }
 
        /*
@@ -1469,17 +1642,18 @@ int main(int argc, char **argv, char **envp)
         */
        status = init_before_fork();
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0, ("init_before_fork failed: %s\n", nt_errstr(status)));
-               exit(1);
+               exit_daemon(nt_errstr(status), map_errno_from_nt_status(status));
        }
 
-       winbindd_register_handlers(!Fork);
+       winbindd_register_handlers(winbind_messaging_context(), !Fork);
+
+       if (!messaging_parent_dgm_cleanup_init(winbind_messaging_context())) {
+               exit(1);
+       }
 
        status = init_system_session_info();
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(1, ("ERROR: failed to setup system user info: %s.\n",
-                         nt_errstr(status)));
-               exit(1);
+               exit_daemon("Winbindd failed to setup system user info", map_errno_from_nt_status(status));
        }
 
        rpc_lsarpc_init(NULL);
@@ -1491,11 +1665,17 @@ int main(int argc, char **argv, char **envp)
        /* setup listen sockets */
 
        if (!winbindd_setup_listeners()) {
-               DEBUG(0,("winbindd_setup_listeners() failed\n"));
-               exit(1);
+               exit_daemon("Winbindd failed to setup listeners", EPIPE);
        }
 
+       irpc_add_name(winbind_imessaging_context(), "winbind_server");
+
        TALLOC_FREE(frame);
+
+       if (!interactive) {
+               daemon_ready("winbindd");
+       }
+
        /* Loop waiting for requests */
        while (1) {
                frame = talloc_stackframe();