Doesn't re-prompt for password when it is specified on the cmdline
[ira/wip.git] / source3 / utils / smbpasswd.c
index 126291915127e1188144e68fffdcdaee3575be83..fac161775286a87a9a396d73534c41e9fcb93798 100644 (file)
@@ -19,7 +19,6 @@
 
 #include "includes.h"
 
-extern pstring global_myname;
 extern BOOL AllowDebugChange;
 
 /*
@@ -29,12 +28,33 @@ extern BOOL AllowDebugChange;
 extern char *optarg;
 extern int optind;
 
-/** forced running in root-mode **/
-static BOOL local_mode;
+/* forced running in root-mode */
+static BOOL got_pass = False, got_username = False;
+static BOOL stdin_passwd_get = False;
+static fstring user_name, user_password;
+static char *new_passwd = NULL;
+static const char *remote_machine = NULL;
 
-/**
- * Print command usage on stderr and die.
- **/
+static fstring ldap_secret;
+
+/*****************************************************************************
+ stubb functions
+****************************************************************************/
+
+void become_root( void )
+{
+        return;
+}
+
+void unbecome_root( void )
+{
+        return;
+}
+
+
+/*********************************************************
+ Print command usage on stderr and die.
+**********************************************************/
 static void usage(void)
 {
        printf("When run by root:\n");
@@ -43,24 +63,24 @@ static void usage(void)
        printf("    smbpasswd [options] [password]\n\n");
 
        printf("options:\n");
+       printf("  -L                   local mode (must be first option)\n");
+       printf("  -h                   print this usage message\n");
        printf("  -s                   use stdin for password prompt\n");
+       printf("  -c smb.conf file     Use the given path to the smb.conf file\n");
        printf("  -D LEVEL             debug level\n");
-       printf("  -U USER              remote username\n");
        printf("  -r MACHINE           remote machine\n");
+       printf("  -U USER              remote username\n");
 
        printf("extra options when run by root or in local mode:\n");
-       printf("  -L                   local mode (must be first option)\n");
-       printf("  -R ORDER             name resolve order\n");
        printf("  -a                   add user\n");
-       printf("  -x                   delete user\n");
        printf("  -d                   disable user\n");
        printf("  -e                   enable user\n");
-       printf("  -n                   set no password\n");
-       printf("  -m                   machine trust account\n");
        printf("  -i                   interdomain trust account\n");
-#ifdef WITH_LDAP_SAM
+       printf("  -m                   machine trust account\n");
+       printf("  -n                   set no password\n");
        printf("  -w                   ldap admin password\n");
-#endif
+       printf("  -x                   delete user\n");
+       printf("  -R ORDER             name resolve order\n");
 
        exit(1);
 }
@@ -70,29 +90,164 @@ static void set_line_buffering(FILE *f)
        setvbuf(f, NULL, _IOLBF, 0);
 }
 
+/*******************************************************************
+ Process command line options
+ ******************************************************************/
+static int process_options(int argc, char **argv, int local_flags)
+{
+       int ch;
+       pstring configfile;
+       pstrcpy(configfile, dyn_CONFIGFILE);
+
+       local_flags |= LOCAL_SET_PASSWORD;
+
+       ZERO_STRUCT(user_name);
+       ZERO_STRUCT(user_password);
+
+       user_name[0] = '\0';
+
+       while ((ch = getopt(argc, argv, "c:axdehminjr:sw:R:D:U:L")) != EOF) {
+               switch(ch) {
+               case 'L':
+                       local_flags |= LOCAL_AM_ROOT;
+                       break;
+               case 'c':
+                       pstrcpy(configfile,optarg);
+                       break;
+               case 'a':
+                       local_flags |= LOCAL_ADD_USER;
+                       break;
+               case 'x':
+                       local_flags |= LOCAL_DELETE_USER;
+                       local_flags &= ~LOCAL_SET_PASSWORD;
+                       break;
+               case 'd':
+                       local_flags |= LOCAL_DISABLE_USER;
+                       local_flags &= ~LOCAL_SET_PASSWORD;
+                       break;
+               case 'e':
+                       local_flags |= LOCAL_ENABLE_USER;
+                       local_flags &= ~LOCAL_SET_PASSWORD;
+                       break;
+               case 'm':
+                       local_flags |= LOCAL_TRUST_ACCOUNT;
+                       break;
+               case 'i':
+                       local_flags |= LOCAL_INTERDOM_ACCOUNT;
+                       break;
+               case 'j':
+                       d_printf("See 'net join' for this functionality\n");
+                       exit(1);
+                       break;
+               case 'n':
+                       local_flags |= LOCAL_SET_NO_PASSWORD;
+                       local_flags &= ~LOCAL_SET_PASSWORD;
+                       new_passwd = smb_xstrdup("NO PASSWORD");
+                       break;
+               case 'r':
+                       remote_machine = optarg;
+                       break;
+               case 's':
+                       set_line_buffering(stdin);
+                       set_line_buffering(stdout);
+                       set_line_buffering(stderr);
+                       stdin_passwd_get = True;
+                       break;
+               case 'w':
+                       local_flags |= LOCAL_SET_LDAP_ADMIN_PW;
+                       fstrcpy(ldap_secret, optarg);
+                       break;
+               case 'R':
+                       lp_set_name_resolve_order(optarg);
+                       break;
+               case 'D':
+                       DEBUGLEVEL = atoi(optarg);
+                       break;
+               case 'U': {
+                       char *lp;
+
+                       got_username = True;
+                       fstrcpy(user_name, optarg);
+
+                       if ((lp = strchr(user_name, '%'))) {
+                               *lp = 0;
+                               fstrcpy(user_password, lp + 1);
+                               got_pass = True;
+                               memset(strchr_m(optarg, '%') + 1, 'X',
+                                      strlen(user_password));
+                       }
+
+                       break;
+               }
+               case 'h':
+               default:
+                       usage();
+               }
+       }
+       
+       argc -= optind;
+       argv += optind;
+
+       switch(argc) {
+       case 0:
+               if (!got_username)
+                       fstrcpy(user_name, "");
+               break;
+       case 1:
+               if (!(local_flags & LOCAL_AM_ROOT)) {
+                       new_passwd = argv[0];
+               } else {
+                       if (got_username) {
+                               usage();
+                       } else {
+                               fstrcpy(user_name, argv[0]);
+                       }
+               }
+               break;
+       case 2:
+               if (!(local_flags & LOCAL_AM_ROOT) || got_username || got_pass) {
+                       usage();
+               }
+
+               fstrcpy(user_name, argv[0]);
+               new_passwd = smb_xstrdup(argv[1]);
+               break;
+       default:
+               usage();
+       }
+
+       if (!lp_load(configfile,True,False,False)) {
+               fprintf(stderr, "Can't load %s - run testparm to debug it\n", 
+                       dyn_CONFIGFILE);
+               exit(1);
+       }
+
+       return local_flags;
+}
+
 /*************************************************************
  Utility function to prompt for passwords from stdin. Each
  password entered must end with a newline.
 *************************************************************/
 static char *stdin_new_passwd(void)
 {
-       static fstring new_passwd;
+       static fstring new_pw;
        size_t len;
 
-       ZERO_ARRAY(new_passwd);
+       ZERO_ARRAY(new_pw);
 
        /*
         * if no error is reported from fgets() and string at least contains
         * the newline that ends the password, then replace the newline with
         * a null terminator.
         */
-       if ( fgets(new_passwd, sizeof(new_passwd), stdin) != NULL) {
-               if ((len = strlen(new_passwd)) > 0) {
-                       if(new_passwd[len-1] == '\n')
-                               new_passwd[len - 1] = 0; 
+       if ( fgets(new_pw, sizeof(new_pw), stdin) != NULL) {
+               if ((len = strlen(new_pw)) > 0) {
+                       if(new_pw[len-1] == '\n')
+                               new_pw[len - 1] = 0; 
                }
        }
-       return(new_passwd);
+       return(new_pw);
 }
 
 
@@ -101,7 +256,7 @@ static char *stdin_new_passwd(void)
  Used if the '-s' option is set to silently get passwords
  to enable scripting.
 *************************************************************/
-static char *get_pass( char *prompt, BOOL stdin_get)
+static char *get_pass( const char *prompt, BOOL stdin_get)
 {
        char *p;
        if (stdin_get) {
@@ -118,20 +273,20 @@ static char *get_pass( char *prompt, BOOL stdin_get)
 static char *prompt_for_new_password(BOOL stdin_get)
 {
        char *p;
-       fstring new_passwd;
+       fstring new_pw;
 
-       ZERO_ARRAY(new_passwd);
+       ZERO_ARRAY(new_pw);
  
        p = get_pass("New SMB password:", stdin_get);
 
-       fstrcpy(new_passwd, p);
+       fstrcpy(new_pw, p);
        SAFE_FREE(p);
 
        p = get_pass("Retype new SMB password:", stdin_get);
 
-       if (strcmp(p, new_passwd)) {
+       if (strcmp(p, new_pw)) {
                fprintf(stderr, "Mismatch - password unchanged.\n");
-               ZERO_ARRAY(new_passwd);
+               ZERO_ARRAY(new_pw);
                SAFE_FREE(p);
                return NULL;
        }
@@ -144,27 +299,27 @@ static char *prompt_for_new_password(BOOL stdin_get)
  Change a password either locally or remotely.
 *************************************************************/
 
-static BOOL password_change(const char *remote_machine, char *user_name, 
-                           char *old_passwd, char *new_passwd, int local_flags)
+static BOOL password_change(const char *remote_mach, char *username, 
+                           char *old_passwd, char *new_pw, int local_flags)
 {
        BOOL ret;
        pstring err_str;
        pstring msg_str;
 
-       if (remote_machine != NULL) {
+       if (remote_mach != NULL) {
                if (local_flags & (LOCAL_ADD_USER|LOCAL_DELETE_USER|LOCAL_DISABLE_USER|LOCAL_ENABLE_USER|
                                                        LOCAL_TRUST_ACCOUNT|LOCAL_SET_NO_PASSWORD)) {
                        /* these things can't be done remotely yet */
                        return False;
                }
-               ret = remote_password_change(remote_machine, user_name, 
-                                            old_passwd, new_passwd, err_str, sizeof(err_str));
+               ret = remote_password_change(remote_mach, username, 
+                                            old_passwd, new_pw, err_str, sizeof(err_str));
                if(*err_str)
                        fprintf(stderr, err_str);
                return ret;
        }
        
-       ret = local_password_change(user_name, local_flags, new_passwd
+       ret = local_password_change(username, local_flags, new_pw
                                     err_str, sizeof(err_str), msg_str, sizeof(msg_str));
 
        if(*msg_str)
@@ -175,7 +330,6 @@ static BOOL password_change(const char *remote_machine, char *user_name,
        return ret;
 }
 
-#ifdef WITH_LDAP_SAM
 /*******************************************************************
  Store the LDAP admin password in secrets.tdb
  ******************************************************************/
@@ -189,112 +343,18 @@ static BOOL store_ldap_admin_pw (char* pw)
        
        return secrets_store_ldap_pw(lp_ldap_admin_dn(), pw);
 }
-#endif
+
 
 /*************************************************************
  Handle password changing for root.
 *************************************************************/
 
-static int process_root(int argc, char *argv[])
+static int process_root(int local_flags)
 {
        struct passwd  *pwd;
-       int result = 0, ch;
-       BOOL got_pass = False, got_username = False;
-       int local_flags = LOCAL_SET_PASSWORD;
-       BOOL stdin_passwd_get = False;
-       fstring user_name, user_password;
-       char *new_passwd = NULL;
+       int result = 0;
        char *old_passwd = NULL;
-       char *remote_machine = NULL;
-#ifdef WITH_LDAP_SAM
-       fstring ldap_secret;
-#endif
-
-       ZERO_STRUCT(user_name);
-       ZERO_STRUCT(user_password);
-
-       user_name[0] = '\0';
 
-       while ((ch = getopt(argc, argv, "axdehmnijr:sw:R:D:U:L")) != EOF) {
-               switch(ch) {
-               case 'L':
-                       local_mode = True;
-                       break;
-               case 'a':
-                       local_flags |= LOCAL_ADD_USER;
-                       break;
-               case 'x':
-                       local_flags |= LOCAL_DELETE_USER;
-                       local_flags &= ~LOCAL_SET_PASSWORD;
-                       break;
-               case 'd':
-                       local_flags |= LOCAL_DISABLE_USER;
-                       local_flags &= ~LOCAL_SET_PASSWORD;
-                       break;
-               case 'e':
-                       local_flags |= LOCAL_ENABLE_USER;
-                       local_flags &= ~LOCAL_SET_PASSWORD;
-                       break;
-               case 'm':
-                       local_flags |= LOCAL_TRUST_ACCOUNT;
-                       break;
-               case 'i':
-                       local_flags |= LOCAL_INTERDOM_ACCOUNT;
-                       break;
-               case 'j':
-                       d_printf("See 'net rpc join' for this functionality\n");
-                       exit(1);
-                       break;
-               case 'r':
-                       remote_machine = optarg;
-                       break;
-               case 's':
-                       set_line_buffering(stdin);
-                       set_line_buffering(stdout);
-                       set_line_buffering(stderr);
-                       stdin_passwd_get = True;
-                       break;
-               case 'w':
-#ifdef WITH_LDAP_SAM
-                       local_flags |= LOCAL_SET_LDAP_ADMIN_PW;
-                       fstrcpy(ldap_secret, optarg);
-                       break;
-#else
-                       printf("-w not available unless configured --with-ldap\n");
-                       goto done;
-#endif                 
-               case 'R':
-                       lp_set_name_resolve_order(optarg);
-                       break;
-               case 'D':
-                       DEBUGLEVEL = atoi(optarg);
-                       break;
-               case 'U': {
-                       char *lp;
-
-                       got_username = True;
-                       fstrcpy(user_name, optarg);
-
-                       if ((lp = strchr_m(user_name, '%'))) {
-                               *lp = 0;
-                               fstrcpy(user_password, lp + 1);
-                               got_pass = True;
-                               memset(strchr_m(optarg, '%') + 1, 'X',
-                                      strlen(user_password));
-                       }
-
-                       break;
-               }
-               case 'h':
-               default:
-                       usage();
-               }
-       }
-       
-       argc -= optind;
-       argv += optind;
-
-#ifdef WITH_LDAP_SAM
        if (local_flags & LOCAL_SET_LDAP_ADMIN_PW)
        {
                printf("Setting stored password for \"%s\" in secrets.tdb\n", 
@@ -303,7 +363,7 @@ static int process_root(int argc, char *argv[])
                        DEBUG(0,("ERROR: Failed to store the ldap admin password!\n"));
                goto done;
        }
-#endif
+
        /*
         * Ensure both add/delete user are not set
         * Ensure add/delete user and either remote machine or join domain are
@@ -321,32 +381,9 @@ static int process_root(int argc, char *argv[])
                load_interfaces();
        }
 
-       /*
-        * Deal with root - can add a user, but only locally.
-        */
-
-       switch(argc) {
-       case 0:
-               if (!got_username)
-                       fstrcpy(user_name, "");
-               break;
-       case 1:
-               if (got_username)
-                       usage();
-               fstrcpy(user_name, argv[0]);
-               break;
-       case 2:
-               if (got_username || got_pass)
-                       usage();
-               fstrcpy(user_name, argv[0]);
-               new_passwd = smb_xstrdup(argv[1]);
-               break;
-       default:
-               usage();
-       }
-
-       if (!user_name[0] && (pwd = sys_getpwuid(geteuid()))) {
+       if (!user_name[0] && (pwd = getpwuid_alloc(geteuid()))) {
                fstrcpy(user_name, pwd->pw_name);
+               passwd_free(&pwd);
        } 
 
        if (!user_name[0]) {
@@ -370,7 +407,7 @@ static int process_root(int argc, char *argv[])
                if (local_flags & LOCAL_ADD_USER) {
                        SAFE_FREE(new_passwd);
                        new_passwd = smb_xstrdup(user_name);
-                       strlower(new_passwd);
+                       strlower_m(new_passwd);
                }
 
                /*
@@ -383,7 +420,7 @@ static int process_root(int argc, char *argv[])
        } else if (local_flags & LOCAL_INTERDOM_ACCOUNT) {
                static fstring buf;
 
-               if (local_flags & LOCAL_ADD_USER) {
+               if (local_flags & LOCAL_ADD_USER & !new_passwd) {
                        /*
                         * Prompt for trusting domain's account password
                         */
@@ -393,9 +430,11 @@ static int process_root(int argc, char *argv[])
                                exit(1);
                        }
                }
+               
+               /* prepare uppercased and '$' terminated username */
                slprintf(buf, sizeof(buf) - 1, "%s$", user_name);
                fstrcpy(user_name, buf);
-
+               
        } else {
                
                if (remote_machine != NULL) {
@@ -426,7 +465,7 @@ static int process_root(int argc, char *argv[])
                        }
                }
                
-               if(local_flags & LOCAL_SET_PASSWORD) {
+               if(local_flags & LOCAL_SET_PASSWORD & !new_passwd) {
                        new_passwd = prompt_for_new_password(stdin_passwd_get);
                        
                        if(!new_passwd) {
@@ -442,7 +481,9 @@ static int process_root(int argc, char *argv[])
                goto done;
        } 
 
-       if(!(local_flags & (LOCAL_ADD_USER|LOCAL_DISABLE_USER|LOCAL_ENABLE_USER|LOCAL_DELETE_USER|LOCAL_SET_NO_PASSWORD|LOCAL_SET_PASSWORD))) {
+       if(remote_machine) {
+               printf("Password changed for user %s on %s.\n", user_name, remote_machine );
+       } else if(!(local_flags & (LOCAL_ADD_USER|LOCAL_DISABLE_USER|LOCAL_ENABLE_USER|LOCAL_DELETE_USER|LOCAL_SET_NO_PASSWORD|LOCAL_SET_PASSWORD))) {
                SAM_ACCOUNT *sampass = NULL;
                BOOL ret;
                
@@ -464,56 +505,27 @@ static int process_root(int argc, char *argv[])
 }
 
 
-/**
-   handle password changing for non-root
-**/
-static int process_nonroot(int argc, char *argv[])
+/*************************************************************
+ Handle password changing for non-root.
+*************************************************************/
+
+static int process_nonroot(int local_flags)
 {
        struct passwd  *pwd = NULL;
-       int result = 0, ch;
-       BOOL stdin_passwd_get = False;
-       char *old_passwd = NULL;
-       char *remote_machine = NULL;
-       char *user_name = NULL;
-       char *new_passwd = NULL;
-
-       while ((ch = getopt(argc, argv, "hD:r:sU:")) != EOF) {
-               switch(ch) {
-               case 'D':
-                       DEBUGLEVEL = atoi(optarg);
-                       break;
-               case 'r':
-                       remote_machine = optarg;
-                       break;
-               case 's':
-                       set_line_buffering(stdin);
-                       set_line_buffering(stdout);
-                       set_line_buffering(stderr);
-                       stdin_passwd_get = True;
-                       break;
-               case 'U':
-                       user_name = optarg;
-                       break;
-               default:
-                       usage();
-               }
-       }
-       
-       argc -= optind;
-       argv += optind;
+       int result = 0;
+       char *old_pw = NULL;
+       char *new_pw = NULL;
 
-       if(argc > 1) {
+       if (local_flags & ~(LOCAL_AM_ROOT | LOCAL_SET_PASSWORD)) {
+               /* Extra flags that we can't honor non-root */
                usage();
        }
-       
-       if (argc == 1) {
-               new_passwd = argv[0];
-       }
-       
-       if (!user_name) {
-               pwd = sys_getpwuid(getuid());
+
+       if (!user_name[0]) {
+               pwd = getpwuid_alloc(getuid());
                if (pwd) {
-                       user_name = smb_xstrdup(pwd->pw_name);
+                       fstrcpy(user_name,pwd->pw_name);
+                       passwd_free(&pwd);
                } else {
                        fprintf(stderr, "smbpasswd: you don't exist - go away\n");
                        exit(1);
@@ -533,19 +545,21 @@ static int process_nonroot(int argc, char *argv[])
        }
 
        if (remote_machine != NULL) {
-               old_passwd = get_pass("Old SMB password:",stdin_passwd_get);
+               old_pw = get_pass("Old SMB password:",stdin_passwd_get);
        }
        
        if (!new_passwd) {
-               new_passwd = prompt_for_new_password(stdin_passwd_get);
+               new_pw = prompt_for_new_password(stdin_passwd_get);
        }
+       else
+               new_pw = smb_xstrdup(new_passwd);
        
-       if (!new_passwd) {
+       if (!new_pw) {
                fprintf(stderr, "Unable to get new password.\n");
                exit(1);
        }
 
-       if (!password_change(remote_machine, user_name, old_passwd, new_passwd, 0)) {
+       if (!password_change(remote_machine, user_name, old_pw, new_pw, 0)) {
                fprintf(stderr,"Failed to change password for %s\n", user_name);
                result = 1;
                goto done;
@@ -554,8 +568,8 @@ static int process_nonroot(int argc, char *argv[])
        printf("Password changed for user %s\n", user_name);
 
  done:
-       SAFE_FREE(old_passwd);
-       SAFE_FREE(new_passwd);
+       SAFE_FREE(old_pw);
+       SAFE_FREE(new_pw);
 
        return result;
 }
@@ -567,32 +581,29 @@ static int process_nonroot(int argc, char *argv[])
 **********************************************************/
 int main(int argc, char **argv)
 {      
+       int local_flags = 0;
+       
        AllowDebugChange = False;
 
 #if defined(HAVE_SET_AUTH_PARAMETERS)
        set_auth_parameters(argc, argv);
 #endif /* HAVE_SET_AUTH_PARAMETERS */
 
-       setup_logging("smbpasswd", True);
-       
-       if (!lp_load(dyn_CONFIGFILE,True,False,False)) {
-               fprintf(stderr, "Can't load %s - run testparm to debug it\n", 
-                       dyn_CONFIGFILE);
-               exit(1);
+       if (getuid() == 0) {
+               local_flags = LOCAL_AM_ROOT;
        }
 
+       local_flags = process_options(argc, argv, local_flags);
+
+       setup_logging("smbpasswd", True);
+       
        /*
         * Set the machine NETBIOS name if not already
         * set from the config file. 
         */ 
     
-       if (!*global_myname) {   
-               char *p;
-               fstrcpy(global_myname, myhostname());
-               p = strchr_m(global_myname, '.' );
-               if (p) *p = 0;
-       }           
-       strupper(global_myname);
+       if (!init_names())
+               return 1;
 
        /* Check the effective uid - make sure we are not setuid */
        if (is_setuid_root()) {
@@ -600,17 +611,10 @@ int main(int argc, char **argv)
                exit(1);
        }
 
-       /* pre-check for local mode option as first option. We can't
-          do this via normal getopt as getopt can't be called
-          twice. */
-       if (argc > 1 && strcmp(argv[1], "-L") == 0) {
-               local_mode = True;
-       }
-
-       if (local_mode || getuid() == 0) {
+       if (local_flags & LOCAL_AM_ROOT) {
                secrets_init();
-               return process_root(argc, argv);
+               return process_root(local_flags);
        } 
 
-       return process_nonroot(argc, argv);
+       return process_nonroot(local_flags);
 }