Fix all warnings in source3 with gcc4.3.
[nivanova/samba-autobuild/.git] / source3 / utils / net_rpc_join.c
index de8661b0df18d300368cbc0531f6097a8a42db06..8070a6282b7ee7b39da4c42d0698c21c9c6f8c92 100644 (file)
@@ -1,22 +1,23 @@
-/* 
-   Samba Unix/Linux SMB client library 
-   Distributed SMB/CIFS Server Management Utility 
+/*
+   Samba Unix/Linux SMB client library
+   Distributed SMB/CIFS Server Management Utility
    Copyright (C) 2001 Andrew Bartlett (abartlet@samba.org)
    Copyright (C) Tim Potter     2001
+   Copyright (C) 2008 Guenther Deschner
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
-   
+
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
-   
+
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
 #include "includes.h"
 #include "utils/net.h"
 
  * @return A shell status integer (0 for success)
  *
  **/
-NTSTATUS net_rpc_join_ok(const char *domain, const char *server,
-                        struct sockaddr_storage *pss)
+NTSTATUS net_rpc_join_ok(struct net_context *c, const char *domain,
+                        const char *server, struct sockaddr_storage *pss)
 {
        enum security_types sec;
        unsigned int conn_flags = NET_FLAGS_PDC;
-       uint32 neg_flags = NETLOGON_NEG_SELECT_AUTH2_FLAGS|NETLOGON_NEG_SCHANNEL;
+       uint32_t neg_flags = NETLOGON_NEG_AUTH2_ADS_FLAGS;
        struct cli_state *cli = NULL;
        struct rpc_pipe_client *pipe_hnd = NULL;
        struct rpc_pipe_client *netlogon_pipe = NULL;
@@ -56,7 +57,7 @@ NTSTATUS net_rpc_join_ok(const char *domain, const char *server,
        if (sec == SEC_ADS) {
                /* Connect to IPC$ using machine account's credentials. We don't use anonymous
                   connection here, as it may be denied by server's local policy. */
-               net_use_machine_account();
+               net_use_machine_account(c);
 
        } else {
                /* some servers (e.g. WinNT) don't accept machine-authenticated
@@ -65,18 +66,20 @@ NTSTATUS net_rpc_join_ok(const char *domain, const char *server,
        }
 
        /* Connect to remote machine */
-       ntret = net_make_ipc_connection_ex(domain, server, pss, conn_flags, &cli);
+       ntret = net_make_ipc_connection_ex(c, domain, server, pss, conn_flags,
+                                          &cli);
        if (!NT_STATUS_IS_OK(ntret)) {
                return ntret;
        }
 
        /* Setup the creds as though we're going to do schannel... */
-        netlogon_pipe = get_schannel_session_key(cli, domain, &neg_flags, &ntret);
+       ntret = get_schannel_session_key(cli, domain, &neg_flags,
+                                        &netlogon_pipe);
 
        /* We return NT_STATUS_INVALID_NETWORK_RESPONSE if the server is refusing
           to negotiate schannel, but the creds were set up ok. That'll have to do. */
 
-        if (!netlogon_pipe) {
+        if (!NT_STATUS_IS_OK(ntret)) {
                if (NT_STATUS_EQUAL(ntret, NT_STATUS_INVALID_NETWORK_RESPONSE)) {
                        cli_shutdown(cli);
                        return NT_STATUS_OK;
@@ -96,11 +99,11 @@ NTSTATUS net_rpc_join_ok(const char *domain, const char *server,
                return ntret;
        }
 
-       pipe_hnd = cli_rpc_pipe_open_schannel_with_key(cli, PI_NETLOGON,
-                               PIPE_AUTH_LEVEL_PRIVACY,
-                               domain, netlogon_pipe->dc, &ntret);
+       ntret = cli_rpc_pipe_open_schannel_with_key(
+               cli, &ndr_table_netlogon.syntax_id, PIPE_AUTH_LEVEL_PRIVACY,
+               domain, netlogon_pipe->dc, &pipe_hnd);
 
-       if (!pipe_hnd) {
+       if (!NT_STATUS_IS_OK(ntret)) {
                DEBUG(0,("net_rpc_join_ok: failed to open schannel session "
                                "on netlogon pipe to server %s for domain %s. Error was %s\n",
                        cli->desthost, domain, nt_errstr(ntret) ));
@@ -124,7 +127,7 @@ NTSTATUS net_rpc_join_ok(const char *domain, const char *server,
  *
  **/
 
-int net_rpc_join_newstyle(int argc, const char **argv) 
+int net_rpc_join_newstyle(struct net_context *c, int argc, const char **argv)
 {
 
        /* libsmb variables */
@@ -132,7 +135,7 @@ int net_rpc_join_newstyle(int argc, const char **argv)
        struct cli_state *cli;
        TALLOC_CTX *mem_ctx;
         uint32 acb_info = ACB_WSTRUST;
-       uint32 neg_flags = NETLOGON_NEG_SELECT_AUTH2_FLAGS|(lp_client_schannel() ? NETLOGON_NEG_SCHANNEL : 0);
+       uint32_t neg_flags = NETLOGON_NEG_AUTH2_ADS_FLAGS;
        uint32 sec_channel_type;
        struct rpc_pipe_client *pipe_hnd = NULL;
 
@@ -145,22 +148,22 @@ int net_rpc_join_newstyle(int argc, const char **argv)
        /* Password stuff */
 
        char *clear_trust_password = NULL;
-       uchar pwbuf[516];
-       SAM_USERINFO_CTR ctr;
-       SAM_USER_INFO_24 p24;
-       SAM_USER_INFO_16 p16;
+       struct samr_CryptPassword crypt_pwd;
        uchar md4_trust_password[16];
+       union samr_UserInfo set_info;
 
        /* Misc */
 
        NTSTATUS result;
        int retval = 1;
        const char *domain = NULL;
-       uint32 num_rids, *name_types, *user_rids;
-       uint32 flags = 0x3e8;
        char *acct_name;
-       const char *const_acct_name;
+       struct lsa_String lsa_acct_name;
        uint32 acct_flags=0;
+       uint32_t access_granted = 0;
+       union lsa_PolicyInformation *info = NULL;
+       struct samr_Ids user_rids;
+       struct samr_Ids name_types;
 
        /* check what type of join */
        if (argc >= 0) {
@@ -185,7 +188,7 @@ int net_rpc_join_newstyle(int argc, const char **argv)
 
        /* Make authenticated connection to remote machine */
 
-       result = net_make_ipc_connection(NET_FLAGS_PDC, &cli);
+       result = net_make_ipc_connection(c, NET_FLAGS_PDC, &cli);
        if (!NT_STATUS_IS_OK(result)) {
                return 1;
        }
@@ -197,25 +200,31 @@ int net_rpc_join_newstyle(int argc, const char **argv)
 
        /* Fetch domain sid */
 
-       pipe_hnd = cli_rpc_pipe_open_noauth(cli, PI_LSARPC, &result);
-       if (!pipe_hnd) {
+       result = cli_rpc_pipe_open_noauth(cli, &ndr_table_lsarpc.syntax_id,
+                                         &pipe_hnd);
+       if (!NT_STATUS_IS_OK(result)) {
                DEBUG(0, ("Error connecting to LSA pipe. Error was %s\n",
                        nt_errstr(result) ));
                goto done;
        }
 
 
-       CHECK_RPC_ERR(rpccli_lsa_open_policy(pipe_hnd, mem_ctx, True,
+       CHECK_RPC_ERR(rpccli_lsa_open_policy(pipe_hnd, mem_ctx, true,
                                          SEC_RIGHTS_MAXIMUM_ALLOWED,
                                          &lsa_pol),
                      "error opening lsa policy handle");
 
-       CHECK_RPC_ERR(rpccli_lsa_query_info_policy(pipe_hnd, mem_ctx, &lsa_pol,
-                                               5, &domain, &domain_sid),
+       CHECK_RPC_ERR(rpccli_lsa_QueryInfoPolicy(pipe_hnd, mem_ctx,
+                                                &lsa_pol,
+                                                LSA_POLICY_INFO_ACCOUNT_DOMAIN,
+                                                &info),
                      "error querying info policy");
 
+       domain = info->account_domain.name.string;
+       domain_sid = info->account_domain.sid;
+
        rpccli_lsa_Close(pipe_hnd, mem_ctx, &lsa_pol);
-       cli_rpc_pipe_close(pipe_hnd); /* Done with this pipe */
+       TALLOC_FREE(pipe_hnd); /* Done with this pipe */
 
        /* Bail out if domain didn't get set. */
        if (!domain) {
@@ -224,22 +233,26 @@ int net_rpc_join_newstyle(int argc, const char **argv)
        }
 
        /* Create domain user */
-       pipe_hnd = cli_rpc_pipe_open_noauth(cli, PI_SAMR, &result);
-       if (!pipe_hnd) {
+       result = cli_rpc_pipe_open_noauth(cli, &ndr_table_samr.syntax_id,
+                                         &pipe_hnd);
+       if (!NT_STATUS_IS_OK(result)) {
                DEBUG(0, ("Error connecting to SAM pipe. Error was %s\n",
                        nt_errstr(result) ));
                goto done;
        }
 
-       CHECK_RPC_ERR(rpccli_samr_connect(pipe_hnd, mem_ctx, 
-                                      SEC_RIGHTS_MAXIMUM_ALLOWED,
-                                      &sam_pol),
+       CHECK_RPC_ERR(rpccli_samr_Connect2(pipe_hnd, mem_ctx,
+                                          pipe_hnd->desthost,
+                                          SEC_RIGHTS_MAXIMUM_ALLOWED,
+                                          &sam_pol),
                      "could not connect to SAM database");
 
-       
-       CHECK_RPC_ERR(rpccli_samr_open_domain(pipe_hnd, mem_ctx, &sam_pol,
-                                          SEC_RIGHTS_MAXIMUM_ALLOWED,
-                                          domain_sid, &domain_pol),
+
+       CHECK_RPC_ERR(rpccli_samr_OpenDomain(pipe_hnd, mem_ctx,
+                                            &sam_pol,
+                                            SEC_RIGHTS_MAXIMUM_ALLOWED,
+                                            domain_sid,
+                                            &domain_pol),
                      "could not open domain");
 
        /* Create domain user */
@@ -248,7 +261,8 @@ int net_rpc_join_newstyle(int argc, const char **argv)
                goto done;
        }
        strlower_m(acct_name);
-       const_acct_name = acct_name;
+
+       init_lsa_String(&lsa_acct_name, acct_name);
 
        acct_flags = SEC_GENERIC_READ | SEC_GENERIC_WRITE | SEC_GENERIC_EXECUTE |
                     SEC_STD_WRITE_DAC | SEC_STD_DELETE |
@@ -258,10 +272,14 @@ int net_rpc_join_newstyle(int argc, const char **argv)
 
        DEBUG(10, ("Creating account with flags: %d\n",acct_flags));
 
-       result = rpccli_samr_create_dom_user(pipe_hnd, mem_ctx, &domain_pol,
-                                         acct_name, acb_info,
-                                         acct_flags, &user_pol, 
-                                         &user_rid);
+       result = rpccli_samr_CreateUser2(pipe_hnd, mem_ctx,
+                                        &domain_pol,
+                                        &lsa_acct_name,
+                                        acb_info,
+                                        acct_flags,
+                                        &user_pol,
+                                        &access_granted,
+                                        &user_rid);
 
        if (!NT_STATUS_IS_OK(result) && 
            !NT_STATUS_EQUAL(result, NT_STATUS_USER_EXISTS)) {
@@ -283,53 +301,51 @@ int net_rpc_join_newstyle(int argc, const char **argv)
                rpccli_samr_Close(pipe_hnd, mem_ctx, &user_pol);
        }
 
-       CHECK_RPC_ERR_DEBUG(rpccli_samr_lookup_names(pipe_hnd, mem_ctx,
-                                                 &domain_pol, flags,
-                                                 1, &const_acct_name, 
-                                                 &num_rids,
-                                                 &user_rids, &name_types),
+       CHECK_RPC_ERR_DEBUG(rpccli_samr_LookupNames(pipe_hnd, mem_ctx,
+                                                   &domain_pol,
+                                                   1,
+                                                   &lsa_acct_name,
+                                                   &user_rids,
+                                                   &name_types),
                            ("error looking up rid for user %s: %s\n",
                             acct_name, nt_errstr(result)));
 
-       if (name_types[0] != SID_NAME_USER) {
-               DEBUG(0, ("%s is not a user account (type=%d)\n", acct_name, name_types[0]));
+       if (name_types.ids[0] != SID_NAME_USER) {
+               DEBUG(0, ("%s is not a user account (type=%d)\n", acct_name, name_types.ids[0]));
                goto done;
        }
 
-       user_rid = user_rids[0];
-               
+       user_rid = user_rids.ids[0];
+
        /* Open handle on user */
 
        CHECK_RPC_ERR_DEBUG(
-               rpccli_samr_open_user(pipe_hnd, mem_ctx, &domain_pol,
-                                  SEC_RIGHTS_MAXIMUM_ALLOWED,
-                                  user_rid, &user_pol),
+               rpccli_samr_OpenUser(pipe_hnd, mem_ctx,
+                                    &domain_pol,
+                                    SEC_RIGHTS_MAXIMUM_ALLOWED,
+                                    user_rid,
+                                    &user_pol),
                ("could not re-open existing user %s: %s\n",
                 acct_name, nt_errstr(result)));
        
        /* Create a random machine account password */
 
-       { 
-               char *str;
-               str = generate_random_str(DEFAULT_TRUST_ACCOUNT_PASSWORD_LENGTH);
-               clear_trust_password = SMB_STRDUP(str);
-               E_md4hash(clear_trust_password, md4_trust_password);
-       }
-
-       encode_pw_buffer(pwbuf, clear_trust_password, STR_UNICODE);
+       clear_trust_password = generate_random_str(talloc_tos(), DEFAULT_TRUST_ACCOUNT_PASSWORD_LENGTH);
+       E_md4hash(clear_trust_password, md4_trust_password);
 
        /* Set password on machine account */
 
-       ZERO_STRUCT(ctr);
-       ZERO_STRUCT(p24);
+       init_samr_CryptPassword(clear_trust_password,
+                               &cli->user_session_key,
+                               &crypt_pwd);
 
-       init_sam_user_info24(&p24, (char *)pwbuf,24);
+       init_samr_user_info24(&set_info.info24, &crypt_pwd,
+                             PASS_DONT_CHANGE_AT_NEXT_LOGON);
 
-       ctr.switch_value = 24;
-       ctr.info.id24 = &p24;
-
-       CHECK_RPC_ERR(rpccli_samr_set_userinfo(pipe_hnd, mem_ctx, &user_pol, 24, 
-                                           &cli->user_session_key, &ctr),
+       CHECK_RPC_ERR(rpccli_samr_SetUserInfo2(pipe_hnd, mem_ctx,
+                                              &user_pol,
+                                              24,
+                                              &set_info),
                      "error setting trust account password");
 
        /* Why do we have to try to (re-)set the ACB to be the same as what
@@ -341,25 +357,24 @@ int net_rpc_join_newstyle(int argc, const char **argv)
           seems to cope with either value so don't bomb out if the set
           userinfo2 level 0x10 fails.  -tpot */
 
-       ZERO_STRUCT(ctr);
-       ctr.switch_value = 16;
-       ctr.info.id16 = &p16;
-
-       init_sam_user_info16(&p16, acb_info);
+       set_info.info16.acct_flags = acb_info;
 
        /* Ignoring the return value is necessary for joining a domain
           as a normal user with "Add workstation to domain" privilege. */
 
-       result = rpccli_samr_set_userinfo2(pipe_hnd, mem_ctx, &user_pol, 16, 
-                                       &cli->user_session_key, &ctr);
+       result = rpccli_samr_SetUserInfo(pipe_hnd, mem_ctx,
+                                        &user_pol,
+                                        16,
+                                        &set_info);
 
        rpccli_samr_Close(pipe_hnd, mem_ctx, &user_pol);
-       cli_rpc_pipe_close(pipe_hnd); /* Done with this pipe */
+       TALLOC_FREE(pipe_hnd); /* Done with this pipe */
 
        /* Now check the whole process from top-to-bottom */
 
-       pipe_hnd = cli_rpc_pipe_open_noauth(cli, PI_NETLOGON, &result);
-       if (!pipe_hnd) {
+       result = cli_rpc_pipe_open_noauth(cli, &ndr_table_netlogon.syntax_id,
+                                         &pipe_hnd);
+       if (!NT_STATUS_IS_OK(result)) {
                DEBUG(0,("Error connecting to NETLOGON pipe. Error was %s\n",
                        nt_errstr(result) ));
                goto done;
@@ -394,13 +409,12 @@ int net_rpc_join_newstyle(int argc, const char **argv)
           do the same again (setup creds) in net_rpc_join_ok(). JRA. */
 
        if (lp_client_schannel() && (neg_flags & NETLOGON_NEG_SCHANNEL)) {
-               struct rpc_pipe_client *netlogon_schannel_pipe = 
-                                               cli_rpc_pipe_open_schannel_with_key(cli,
-                                                       PI_NETLOGON,
-                                                       PIPE_AUTH_LEVEL_PRIVACY,
-                                                       domain,
-                                                       pipe_hnd->dc,
-                                                       &result);
+               struct rpc_pipe_client *netlogon_schannel_pipe;
+
+               result = cli_rpc_pipe_open_schannel_with_key(
+                       cli, &ndr_table_netlogon.syntax_id,
+                       PIPE_AUTH_LEVEL_PRIVACY, domain, pipe_hnd->dc,
+                       &netlogon_schannel_pipe);
 
                if (!NT_STATUS_IS_OK(result)) {
                        DEBUG(0, ("Error in domain join verification (schannel setup failed): %s\n\n",
@@ -415,10 +429,10 @@ int net_rpc_join_newstyle(int argc, const char **argv)
 
                        goto done;
                }
-               cli_rpc_pipe_close(netlogon_schannel_pipe);
+               TALLOC_FREE(netlogon_schannel_pipe);
        }
 
-       cli_rpc_pipe_close(pipe_hnd);
+       TALLOC_FREE(pipe_hnd);
 
        /* Now store the secret in the secrets database */
 
@@ -434,7 +448,7 @@ int net_rpc_join_newstyle(int argc, const char **argv)
        }
 
        /* double-check, connection from scratch */
-       result = net_rpc_join_ok(domain, cli->desthost, &cli->dest_ss);
+       result = net_rpc_join_ok(c, domain, cli->desthost, &cli->dest_ss);
        retval = NT_STATUS_IS_OK(result) ? 0 : -1;
 
 done:
@@ -448,10 +462,10 @@ done:
                        printf("Joined domain %s.\n",domain);
                }
        }
-       
+
        cli_shutdown(cli);
 
-       SAFE_FREE(clear_trust_password);
+       TALLOC_FREE(clear_trust_password);
 
        return retval;
 }
@@ -462,16 +476,23 @@ done:
  * @return A shell status integer (0 for success)
  *
  **/
-int net_rpc_testjoin(int argc, const char **argv) 
+int net_rpc_testjoin(struct net_context *c, int argc, const char **argv)
 {
-       char *domain = smb_xstrdup(opt_target_workgroup);
+       char *domain = smb_xstrdup(c->opt_target_workgroup);
        NTSTATUS nt_status;
 
+       if (c->display_usage) {
+               d_printf("Usage\n"
+                        "net rpc testjoin\n"
+                        "    Test if a join is OK\n");
+               return 0;
+       }
+
        /* Display success or failure */
-       nt_status = net_rpc_join_ok(domain, NULL, NULL);
+       nt_status = net_rpc_join_ok(c, domain, NULL, NULL);
        if (!NT_STATUS_IS_OK(nt_status)) {
                fprintf(stderr,"Join to domain '%s' is not valid: %s\n",
-                       nt_errstr(nt_status), domain);
+                       domain, nt_errstr(nt_status));
                free(domain);
                return -1;
        }