I should have done this years ago...
[ira/wip.git] / source3 / utils / net_rpc.c
index 9b3248cf63346d88e70768003818f713f42a7183..eef3adbcb81b35a8582ba5e9f8c43f3212042611 100644 (file)
@@ -21,8 +21,6 @@
 #include "includes.h"
 #include "../utils/net.h"
 
-extern pstring global_myname;
-
 /**
  * @file net_rpc.c
  *
@@ -50,33 +48,20 @@ typedef NTSTATUS (*rpc_command_fn)(const DOM_SID *, struct cli_state *, TALLOC_C
  * @return The Domain SID of the remote machine.
  **/
 
-static DOM_SID *net_get_remote_domain_sid(struct cli_state *cli)
+static DOM_SID *net_get_remote_domain_sid(struct cli_state *cli, TALLOC_CTX *mem_ctx)
 {
        DOM_SID *domain_sid;
        POLICY_HND pol;
        NTSTATUS result = NT_STATUS_OK;
        uint32 info_class = 5;
-       fstring domain_name;
-       TALLOC_CTX *mem_ctx;
+        char *domain_name;
        
-       if (!(domain_sid = malloc(sizeof(DOM_SID)))){
-               DEBUG(0,("net_get_remote_domain_sid: malloc returned NULL!\n"));
-               goto error;
-       }
-           
-       if (!(mem_ctx=talloc_init()))
-       {
-               DEBUG(0,("net_get_remote_domain_sid: talloc_init returned NULL!\n"));
-               goto error;
-       }
-
-
-       if (!cli_nt_session_open (cli, PIPE_LSARPC)) {
+       if (!cli_nt_session_open (cli, PI_LSARPC)) {
                fprintf(stderr, "could not initialise lsa pipe\n");
                goto error;
        }
        
-       result = cli_lsa_open_policy(cli, mem_ctx, True, 
+       result = cli_lsa_open_policy(cli, mem_ctx, False, 
                                     SEC_RIGHTS_MAXIMUM_ALLOWED,
                                     &pol);
        if (!NT_STATUS_IS_OK(result)) {
@@ -84,25 +69,22 @@ static DOM_SID *net_get_remote_domain_sid(struct cli_state *cli)
        }
 
        result = cli_lsa_query_info_policy(cli, mem_ctx, &pol, info_class, 
-                                          domain_name, domain_sid);
+                                          &domain_name, &domain_sid);
        if (!NT_STATUS_IS_OK(result)) {
-               goto error;
+ error:
+               fprintf(stderr, "could not obtain sid for domain %s\n", cli->domain);
+
+               if (!NT_STATUS_IS_OK(result)) {
+                       fprintf(stderr, "error: %s\n", nt_errstr(result));
+               }
+
+               exit(1);
        }
 
        cli_lsa_close(cli, mem_ctx, &pol);
        cli_nt_session_close(cli);
-       talloc_destroy(mem_ctx);
 
        return domain_sid;
-
- error:
-       fprintf(stderr, "could not obtain sid for domain %s\n", cli->domain);
-
-       if (!NT_STATUS_IS_OK(result)) {
-               fprintf(stderr, "error: %s\n", nt_errstr(result));
-       }
-
-       exit(1);
 }
 
 /**
@@ -117,7 +99,7 @@ static DOM_SID *net_get_remote_domain_sid(struct cli_state *cli)
  * @return A shell status integer (0 for success)
  */
 
-static int run_rpc_command(struct cli_state *cli_arg, const char *pipe_name, int conn_flags,
+static int run_rpc_command(struct cli_state *cli_arg, const int pipe_idx, int conn_flags,
                            rpc_command_fn fn,
                            int argc, const char **argv) 
 {
@@ -136,18 +118,18 @@ static int run_rpc_command(struct cli_state *cli_arg, const char *pipe_name, int
                return -1;
        }
 
-       domain_sid = net_get_remote_domain_sid(cli);
-
        /* Create mem_ctx */
        
-       if (!(mem_ctx = talloc_init())) {
+       if (!(mem_ctx = talloc_init("run_rpc_command"))) {
                DEBUG(0, ("talloc_init() failed\n"));
                cli_shutdown(cli);
                return -1;
        }
        
-       if (!cli_nt_session_open(cli, pipe_name)) {
-               DEBUG(0, ("Could not initialise %s pipe\n", pipe_name));
+       domain_sid = net_get_remote_domain_sid(cli, mem_ctx);
+
+       if (!cli_nt_session_open(cli, pipe_idx)) {
+               DEBUG(0, ("Could not initialise pipe\n"));
        }
        
        nt_status = fn(domain_sid, cli, mem_ctx, argc, argv);
@@ -178,7 +160,7 @@ static int run_rpc_command(struct cli_state *cli_arg, const char *pipe_name, int
 /** 
  * Force a change of the trust acccount password.
  *
- * All paramaters are provided by the run_rpc_command funcion, except for
+ * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passes through. 
  *
  * @param domain_sid The domain sid aquired from the remote server
@@ -207,9 +189,9 @@ static NTSTATUS rpc_changetrustpw_internals(const DOM_SID *domain_sid, struct cl
  * @return A shell status integer (0 for success)
  **/
 
-static int rpc_changetrustpw(int argc, const char **argv) 
+int net_rpc_changetrustpw(int argc, const char **argv) 
 {
-       return run_rpc_command(NULL, PIPE_NETLOGON, NET_FLAGS_ANONYMOUS | NET_FLAGS_PDC, rpc_changetrustpw_internals,
+       return run_rpc_command(NULL, PI_NETLOGON, NET_FLAGS_ANONYMOUS | NET_FLAGS_PDC, rpc_changetrustpw_internals,
                               argc, argv);
 }
 
@@ -222,9 +204,9 @@ static int rpc_changetrustpw(int argc, const char **argv)
  *
  * This uses 'machinename' as the inital password, and changes it. 
  *
- * The password should be created with 'server manager' or eqiv first.
+ * The password should be created with 'server manager' or equiv first.
  *
- * All paramaters are provided by the run_rpc_command funcion, except for
+ * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passes through. 
  *
  * @param domain_sid The domain sid aquired from the remote server
@@ -237,15 +219,27 @@ static int rpc_changetrustpw(int argc, const char **argv)
  * @return Normal NTSTATUS return.
  **/
 
-static NTSTATUS rpc_join_oldstyle_internals(const DOM_SID *domain_sid, struct cli_state *cli, TALLOC_CTX *mem_ctx, 
-                                      int argc, const char **argv) {
+static NTSTATUS rpc_oldjoin_internals(const DOM_SID *domain_sid, struct cli_state *cli, 
+                                           TALLOC_CTX *mem_ctx, 
+                                           int argc, const char **argv) {
        
-       extern pstring global_myname;
        fstring trust_passwd;
        unsigned char orig_trust_passwd_hash[16];
+       NTSTATUS result;
+       uint32 sec_channel_type;
 
-       fstrcpy(trust_passwd, global_myname);
-       strlower(trust_passwd);
+       /* 
+          check what type of join - if the user want's to join as
+          a BDC, the server must agree that we are a BDC.
+       */
+       if (argc >= 0) {
+               sec_channel_type = get_sec_channel_type(argv[0]);
+       } else {
+               sec_channel_type = get_sec_channel_type(NULL);
+       }
+       
+       fstrcpy(trust_passwd, global_myname());
+       strlower_m(trust_passwd);
 
        /*
         * Machine names can be 15 characters, but the max length on
@@ -256,7 +250,20 @@ static NTSTATUS rpc_join_oldstyle_internals(const DOM_SID *domain_sid, struct cl
 
        E_md4hash(trust_passwd, orig_trust_passwd_hash);
 
-       return trust_pw_change_and_store_it(cli, mem_ctx, orig_trust_passwd_hash);
+       result = trust_pw_change_and_store_it(cli, mem_ctx, opt_target_workgroup,
+                                             orig_trust_passwd_hash,
+                                             sec_channel_type);
+
+       if (NT_STATUS_IS_OK(result))
+               printf("Joined domain %s.\n",opt_target_workgroup);
+
+
+       if (!secrets_store_domain_sid(opt_target_workgroup, domain_sid)) {
+               DEBUG(0, ("error storing domain sid for %s\n", opt_target_workgroup));
+               result = NT_STATUS_UNSUCCESSFUL;
+       }
+
+       return result;
 }
 
 /** 
@@ -269,12 +276,37 @@ static NTSTATUS rpc_join_oldstyle_internals(const DOM_SID *domain_sid, struct cl
  * @return A shell status integer (0 for success)
  **/
 
-static int net_rpc_join_oldstyle(int argc, const char **argv) 
+static int net_rpc_perform_oldjoin(int argc, const char **argv)
 {
-       return run_rpc_command(NULL, PIPE_NETLOGON, NET_FLAGS_ANONYMOUS | NET_FLAGS_PDC, rpc_join_oldstyle_internals,
+       return run_rpc_command(NULL, PI_NETLOGON, 
+                              NET_FLAGS_ANONYMOUS | NET_FLAGS_PDC, 
+                              rpc_oldjoin_internals,
                               argc, argv);
 }
 
+/** 
+ * Join a domain, the old way.  This function exists to allow
+ * the message to be displayed when oldjoin was explicitly 
+ * requested, but not when it was implied by "net rpc join"
+ *
+ * @param argc  Standard main() style argc
+ * @param argc  Standard main() style argv.  Initial components are already
+ *              stripped
+ *
+ * @return A shell status integer (0 for success)
+ **/
+
+static int net_rpc_oldjoin(int argc, const char **argv) 
+{
+       int rc = net_rpc_perform_oldjoin(argc, argv);
+
+       if (rc) {
+               d_printf("Failed to join domain\n");
+       }
+
+       return rc;
+}
+
 /** 
  * Basic usage function for 'net rpc join'
  * @param argc  Standard main() style argc
@@ -284,11 +316,13 @@ static int net_rpc_join_oldstyle(int argc, const char **argv)
 
 static int rpc_join_usage(int argc, const char **argv) 
 {      
-       d_printf("net rpc join -U <username>[%%password] [options]\n"\
+       d_printf("net rpc join -U <username>[%%password] <type>[options]\n"\
                 "\t to join a domain with admin username & password\n"\
-                "\t\t password will be prompted if none is specified\n");
-       d_printf("net rpc join [options except -U]\n"\
-                "\t to join a domain created in server manager\n\n\n");
+                "\t\t password will be prompted if needed and none is specified\n"\
+                "\t <type> can be (default MEMBER)\n"\
+                "\t\t BDC - Join as a BDC\n"\
+                "\t\t PDC - Join as a PDC\n"\
+                "\t\t MEMBER - Join as a MEMBER server\n");
 
        net_common_flags_usage(argc, argv);
        return -1;
@@ -302,13 +336,13 @@ static int rpc_join_usage(int argc, const char **argv)
  *
  * Main 'net_rpc_join()' (where the admain username/password is used) is 
  * in net_rpc_join.c
- * Assume if a -U is specified, it's the new style, otherwise it's the
- * old style
+ * Try to just change the password, but if that doesn't work, use/prompt
+ * for a username/password.
  **/
 
 int net_rpc_join(int argc, const char **argv) 
 {
-       if ((net_rpc_join_oldstyle(argc, argv) == 0))
+       if ((net_rpc_perform_oldjoin(argc, argv) == 0))
                return 0;
        
        return net_rpc_join_newstyle(argc, argv);
@@ -319,8 +353,8 @@ int net_rpc_join(int argc, const char **argv)
 /** 
  * display info about a rpc domain
  *
- * All paramaters are provided by the run_rpc_command function, except for
- * argc, argv which are passes through. 
+ * All parameters are provided by the run_rpc_command function, except for
+ * argc, argv which are passed through. 
  *
  * @param domain_sid The domain sid acquired from the remote server
  * @param cli A cli_state connected to the server.
@@ -339,6 +373,9 @@ rpc_info_internals(const DOM_SID *domain_sid, struct cli_state *cli,
        POLICY_HND connect_pol, domain_pol;
        NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
        SAM_UNK_CTR ctr;
+       fstring sid_str;
+
+       sid_to_string(sid_str, domain_sid);
 
        /* Get sam policy handle */     
        result = cli_samr_connect(cli, mem_ctx, MAXIMUM_ALLOWED_ACCESS, 
@@ -359,8 +396,9 @@ rpc_info_internals(const DOM_SID *domain_sid, struct cli_state *cli,
        result = cli_samr_query_dom_info(cli, mem_ctx, &domain_pol,
                                         2, &ctr);
        if (NT_STATUS_IS_OK(result)) {
-               TALLOC_CTX *ctx = talloc_init();
+               TALLOC_CTX *ctx = talloc_init("rpc_info_internals");
                d_printf("Domain Name: %s\n", unistr2_tdup(ctx, &ctr.info.inf2.uni_domain));
+               d_printf("Domain SID: %s\n", sid_str);
                d_printf("Sequence number: %u\n", ctr.info.inf2.seq_num);
                d_printf("Num users: %u\n", ctr.info.inf2.num_domain_usrs);
                d_printf("Num domain groups: %u\n", ctr.info.inf2.num_domain_grps);
@@ -381,12 +419,59 @@ rpc_info_internals(const DOM_SID *domain_sid, struct cli_state *cli,
  **/
 int net_rpc_info(int argc, const char **argv) 
 {
-       return run_rpc_command(NULL, PIPE_SAMR, NET_FLAGS_ANONYMOUS | NET_FLAGS_PDC, 
+       return run_rpc_command(NULL, PI_SAMR, NET_FLAGS_ANONYMOUS | NET_FLAGS_PDC, 
                               rpc_info_internals,
                               argc, argv);
 }
 
 
+/** 
+ * Fetch domain SID into the local secrets.tdb
+ *
+ * All parameters are provided by the run_rpc_command function, except for
+ * argc, argv which are passes through. 
+ *
+ * @param domain_sid The domain sid acquired from the remote server
+ * @param cli A cli_state connected to the server.
+ * @param mem_ctx Talloc context, destoyed on completion of the function.
+ * @param argc  Standard main() style argc
+ * @param argv  Standard main() style argv.  Initial components are already
+ *              stripped
+ *
+ * @return Normal NTSTATUS return.
+ **/
+
+static NTSTATUS 
+rpc_getsid_internals(const DOM_SID *domain_sid, struct cli_state *cli,
+                  TALLOC_CTX *mem_ctx, int argc, const char **argv)
+{
+       fstring sid_str;
+
+       sid_to_string(sid_str, domain_sid);
+       d_printf("Storing SID %s for Domain %s in secrets.tdb\n",
+                sid_str, lp_workgroup());
+
+       if (!secrets_store_domain_sid(global_myname(), domain_sid)) {
+               DEBUG(0,("Can't store domain SID\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       return NT_STATUS_OK;
+}
+
+
+/** 
+ * 'net rpc getsid' entrypoint.
+ * @param argc  Standard main() style argc
+ * @param argc  Standard main() style argv.  Initial components are already
+ *              stripped
+ **/
+int net_rpc_getsid(int argc, const char **argv) 
+{
+       return run_rpc_command(NULL, PI_SAMR, NET_FLAGS_ANONYMOUS | NET_FLAGS_PDC, 
+                              rpc_getsid_internals,
+                              argc, argv);
+}
 
 
 /****************************************************************************/
@@ -406,7 +491,7 @@ static int rpc_user_usage(int argc, const char **argv)
 /** 
  * Add a new user to a remote RPC server
  *
- * All paramaters are provided by the run_rpc_command funcion, except for
+ * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passes through. 
  *
  * @param domain_sid The domain sid acquired from the remote server
@@ -487,14 +572,14 @@ static NTSTATUS rpc_user_add_internals(const DOM_SID *domain_sid, struct cli_sta
 
 static int rpc_user_add(int argc, const char **argv) 
 {
-       return run_rpc_command(NULL, PIPE_SAMR, 0, rpc_user_add_internals,
+       return run_rpc_command(NULL, PI_SAMR, 0, rpc_user_add_internals,
                               argc, argv);
 }
 
 /** 
  * Delete a user from a remote RPC server
  *
- * All paramaters are provided by the run_rpc_command funcion, except for
+ * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passes through. 
  *
  * @param domain_sid The domain sid acquired from the remote server
@@ -588,14 +673,143 @@ static NTSTATUS rpc_user_del_internals(const DOM_SID *domain_sid,
 
 static int rpc_user_delete(int argc, const char **argv) 
 {
-       return run_rpc_command(NULL, PIPE_SAMR, 0, rpc_user_del_internals,
+       return run_rpc_command(NULL, PI_SAMR, 0, rpc_user_del_internals,
+                              argc, argv);
+}
+
+/** 
+ * Set a password for a user on a remote RPC server
+ *
+ * All parameters are provided by the run_rpc_command function, except for
+ * argc, argv which are passes through. 
+ *
+ * @param domain_sid The domain sid acquired from the remote server
+ * @param cli A cli_state connected to the server.
+ * @param mem_ctx Talloc context, destoyed on completion of the function.
+ * @param argc  Standard main() style argc
+ * @param argv  Standard main() style argv.  Initial components are already
+ *              stripped
+ *
+ * @return Normal NTSTATUS return.
+ **/
+
+static NTSTATUS rpc_user_password_internals(const DOM_SID *domain_sid, 
+                                           struct cli_state *cli, 
+                                           TALLOC_CTX *mem_ctx, 
+                                           int argc, const char **argv)
+{
+       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
+       POLICY_HND connect_pol, domain_pol, user_pol;
+       SAM_USERINFO_CTR ctr;
+       SAM_USER_INFO_24 p24;
+       uchar pwbuf[516];
+       const char *user;
+       const char *new_password;
+       char *prompt = NULL;
+
+       if (argc < 1) {
+               d_printf("User must be specified\n");
+               rpc_user_usage(argc, argv);
+               return NT_STATUS_OK;
+       }
+       
+       user = argv[0];
+
+       if (argv[1]) {
+               new_password = argv[1];
+       } else {
+               asprintf(&prompt, "Enter new password for %s:", user);
+               new_password = getpass(prompt);
+               SAFE_FREE(prompt);
+       }
+
+       /* Get sam policy and domain handles */
+
+       result = cli_samr_connect(cli, mem_ctx, MAXIMUM_ALLOWED_ACCESS, 
+                                 &connect_pol);
+
+       if (!NT_STATUS_IS_OK(result)) {
+               goto done;
+       }
+
+       result = cli_samr_open_domain(cli, mem_ctx, &connect_pol,
+                                     MAXIMUM_ALLOWED_ACCESS,
+                                     domain_sid, &domain_pol);
+
+       if (!NT_STATUS_IS_OK(result)) {
+               goto done;
+       }
+
+       /* Get handle on user */
+
+       {
+               uint32 *user_rids, num_rids, *name_types;
+               uint32 flags = 0x000003e8; /* Unknown */
+
+               result = cli_samr_lookup_names(cli, mem_ctx, &domain_pol,
+                                              flags, 1, &user,
+                                              &num_rids, &user_rids,
+                                              &name_types);
+
+               if (!NT_STATUS_IS_OK(result)) {
+                       goto done;
+               }
+
+               result = cli_samr_open_user(cli, mem_ctx, &domain_pol,
+                                           MAXIMUM_ALLOWED_ACCESS,
+                                           user_rids[0], &user_pol);
+
+               if (!NT_STATUS_IS_OK(result)) {
+                       goto done;
+               }
+       }
+
+       /* Set password on account */
+
+       ZERO_STRUCT(ctr);
+       ZERO_STRUCT(p24);
+
+       encode_pw_buffer(pwbuf, new_password, STR_UNICODE);
+
+       init_sam_user_info24(&p24, (char *)pwbuf,24);
+
+       ctr.switch_value = 24;
+       ctr.info.id24 = &p24;
+
+       result = cli_samr_set_userinfo(cli, mem_ctx, &user_pol, 24, 
+                                      &cli->user_session_key, &ctr);
+
+       if (!NT_STATUS_IS_OK(result)) {
+               goto done;
+       }
+
+       /* Display results */
+
+ done:
+       return result;
+
+}      
+
+/** 
+ * Set a user's password on a remote RPC server
+ *
+ * @param argc  Standard main() style argc
+ * @param argv  Standard main() style argv.  Initial components are already
+ *              stripped
+ *
+ * @return A shell status integer (0 for success)
+ **/
+
+static int rpc_user_password(int argc, const char **argv) 
+{
+       return run_rpc_command(NULL, PI_SAMR, 0, rpc_user_password_internals,
                               argc, argv);
 }
 
 /** 
  * List user's groups on a remote RPC server
  *
- * All paramaters are provided by the run_rpc_command funcion, except for
+ * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passes through. 
  *
  * @param domain_sid The domain sid acquired from the remote server
@@ -690,14 +904,14 @@ rpc_user_info_internals(const DOM_SID *domain_sid, struct cli_state *cli,
 
 static int rpc_user_info(int argc, const char **argv) 
 {
-       return run_rpc_command(NULL, PIPE_SAMR, 0, rpc_user_info_internals,
+       return run_rpc_command(NULL, PI_SAMR, 0, rpc_user_info_internals,
                               argc, argv);
 }
 
 /** 
  * List users on a remote RPC server
  *
- * All paramaters are provided by the run_rpc_command function, except for
+ * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passes through. 
  *
  * @param domain_sid The domain sid acquired from the remote server
@@ -716,7 +930,7 @@ rpc_user_list_internals(const DOM_SID *domain_sid, struct cli_state *cli,
 {
        POLICY_HND connect_pol, domain_pol;
        NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
-       uint32 start_idx=0, max_entries=250, num_entries, i;
+       uint32 start_idx=0, num_entries, i, loop_count = 0;
        SAM_DISPINFO_CTR ctr;
        SAM_DISPINFO_1 info1;
 
@@ -746,20 +960,27 @@ rpc_user_list_internals(const DOM_SID *domain_sid, struct cli_state *cli,
                         "\n-----------------------------\n");
        do {
                fstring user, desc;
+               uint32 max_entries, max_size;
+
+               get_query_dispinfo_params(
+                       loop_count, &max_entries, &max_size);
+
                result = cli_samr_query_dispinfo(cli, mem_ctx, &domain_pol,
                                                 &start_idx, 1, &num_entries,
-                                                max_entries, &ctr);
+                                                max_entries, max_size, &ctr);
+               loop_count++;
+
                for (i = 0; i < num_entries; i++) {
                        unistr2_to_ascii(user, &(&ctr.sam.info1->str[i])->uni_acct_name, sizeof(user)-1);
                        if (opt_long_list_entries) 
                                unistr2_to_ascii(desc, &(&ctr.sam.info1->str[i])->uni_acct_desc, sizeof(desc)-1);
                        
                        if (opt_long_list_entries)
-                               printf("%-21.21s %-50.50s\n", user, desc);
+                               printf("%-21.21s %s\n", user, desc);
                        else
                                printf("%s\n", user);
                }
-       } while (!NT_STATUS_IS_OK(result));
+       } while (NT_STATUS_EQUAL(result, STATUS_MORE_ENTRIES));
 
  done:
        return result;
@@ -778,6 +999,7 @@ int net_rpc_user(int argc, const char **argv)
                {"add", rpc_user_add},
                {"info", rpc_user_info},
                {"delete", rpc_user_delete},
+               {"password", rpc_user_password},
                {NULL, NULL}
        };
        
@@ -785,7 +1007,7 @@ int net_rpc_user(int argc, const char **argv)
                if (opt_long_list_entries) {
                } else {
                }
-                       return run_rpc_command(NULL,PIPE_SAMR, 0, 
+                       return run_rpc_command(NULL,PI_SAMR, 0, 
                                               rpc_user_list_internals,
                                               argc, argv);
        }
@@ -811,7 +1033,7 @@ static int rpc_group_usage(int argc, const char **argv)
 /** 
  * List groups on a remote RPC server
  *
- * All paramaters are provided by the run_rpc_command funcion, except for
+ * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passes through. 
  *
  * @param domain_sid The domain sid acquired from the remote server
@@ -830,9 +1052,29 @@ rpc_group_list_internals(const DOM_SID *domain_sid, struct cli_state *cli,
 {
        POLICY_HND connect_pol, domain_pol;
        NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
-       uint32 start_idx=0, max_entries=250, num_entries, i;
+       uint32 start_idx=0, max_entries=250, num_entries, i, loop_count = 0;
        struct acct_info *groups;
        DOM_SID global_sid_Builtin;
+       BOOL global = False;
+       BOOL local = False;
+       BOOL builtin = False;
+
+       if (argc == 0) {
+               global = True;
+               local = True;
+               builtin = True;
+       }
+
+       for (i=0; i<argc; i++) {
+               if (strequal(argv[i], "global"))
+                       global = True;
+
+               if (strequal(argv[i], "local"))
+                       local = True;
+
+               if (strequal(argv[i], "builtin"))
+                       builtin = True;
+       }
 
        string_to_sid(&global_sid_Builtin, "S-1-5-32");
 
@@ -858,34 +1100,79 @@ rpc_group_list_internals(const DOM_SID *domain_sid, struct cli_state *cli,
                d_printf("\nGroup name            Comment"\
                         "\n-----------------------------\n");
        do {
-               result = cli_samr_enum_dom_groups(cli, mem_ctx, &domain_pol,
-                                                 &start_idx, max_entries,
-                                                 &groups, &num_entries);
+               SAM_DISPINFO_CTR ctr;
+               SAM_DISPINFO_3 info3;
+               uint32 max_size;
+
+               ZERO_STRUCT(ctr);
+               ZERO_STRUCT(info3);
+               ctr.sam.info3 = &info3;
+
+               if (!global) break;
+
+               get_query_dispinfo_params(
+                       loop_count, &max_entries, &max_size);
+
+               result = cli_samr_query_dispinfo(cli, mem_ctx, &domain_pol,
+                                                &start_idx, 3, &num_entries,
+                                                max_entries, max_size, &ctr);
                                                 
                for (i = 0; i < num_entries; i++) {
+
+                       fstring group, desc;
+
+                       unistr2_to_ascii(group, &(&ctr.sam.info3->str[i])->uni_grp_name, sizeof(group)-1);
+                       unistr2_to_ascii(desc, &(&ctr.sam.info3->str[i])->uni_grp_desc, sizeof(desc)-1);
+                       
                        if (opt_long_list_entries)
-                               printf("%-21.21s %-50.50s\n", 
-                                      groups[i].acct_name,
-                                      groups[i].acct_desc);
+                               printf("%-21.21s %-50.50s\n",
+                                      group, desc);
                        else
-                               printf("%-21.21s\n", groups[i].acct_name);
+                               printf("%s\n", group);
                }
-       } while (!NT_STATUS_IS_OK(result));
+       } while (NT_STATUS_EQUAL(result, STATUS_MORE_ENTRIES));
        /* query domain aliases */
+       start_idx = 0;
        do {
+               if (!local) break;
+
                result = cli_samr_enum_als_groups(cli, mem_ctx, &domain_pol,
                                                  &start_idx, max_entries,
                                                  &groups, &num_entries);
-                                                
+
                for (i = 0; i < num_entries; i++) {
-                       if (opt_long_list_entries)
+
+                       char *description = NULL;
+
+                       if (opt_long_list_entries) {
+
+                               POLICY_HND alias_pol;
+                               ALIAS_INFO_CTR ctr;
+
+                               if ((NT_STATUS_IS_OK(cli_samr_open_alias(cli, mem_ctx,
+                                                                        &domain_pol,
+                                                                        0x8,
+                                                                        groups[i].rid,
+                                                                        &alias_pol))) &&
+                                   (NT_STATUS_IS_OK(cli_samr_query_alias_info(cli, mem_ctx,
+                                                                              &alias_pol, 3,
+                                                                              &ctr))) &&
+                                   (NT_STATUS_IS_OK(cli_samr_close(cli, mem_ctx,
+                                                                   &alias_pol)))) {
+                                       description = unistr2_tdup(mem_ctx,
+                                                                  &ctr.alias.info3.uni_acct_desc);
+                               }
+                       }
+                       
+                       if (description != NULL) {
                                printf("%-21.21s %-50.50s\n", 
                                       groups[i].acct_name,
-                                      groups[i].acct_desc);
-                       else
-                               printf("%-21.21s\n", groups[i].acct_name);
+                                      description);
+                       } else {
+                               printf("%s\n", groups[i].acct_name);
+                       }
                }
-       } while (!NT_STATUS_IS_OK(result));
+       } while (NT_STATUS_EQUAL(result, STATUS_MORE_ENTRIES));
        cli_samr_close(cli, mem_ctx, &domain_pol);
        /* Get builtin policy handle */
        
@@ -896,25 +1183,156 @@ rpc_group_list_internals(const DOM_SID *domain_sid, struct cli_state *cli,
                goto done;
        }
        /* query builtin aliases */
+       start_idx = 0;
        do {
+               if (!builtin) break;
+
                result = cli_samr_enum_als_groups(cli, mem_ctx, &domain_pol,
                                                  &start_idx, max_entries,
                                                  &groups, &num_entries);
                                                 
                for (i = 0; i < num_entries; i++) {
-                       if (opt_long_list_entries)
+
+                       char *description = NULL;
+
+                       if (opt_long_list_entries) {
+
+                               POLICY_HND alias_pol;
+                               ALIAS_INFO_CTR ctr;
+
+                               if ((NT_STATUS_IS_OK(cli_samr_open_alias(cli, mem_ctx,
+                                                                        &domain_pol,
+                                                                        0x8,
+                                                                        groups[i].rid,
+                                                                        &alias_pol))) &&
+                                   (NT_STATUS_IS_OK(cli_samr_query_alias_info(cli, mem_ctx,
+                                                                              &alias_pol, 3,
+                                                                              &ctr))) &&
+                                   (NT_STATUS_IS_OK(cli_samr_close(cli, mem_ctx,
+                                                                   &alias_pol)))) {
+                                       description = unistr2_tdup(mem_ctx,
+                                                                  &ctr.alias.info3.uni_acct_desc);
+                               }
+                       }
+                       
+                       if (description != NULL) {
                                printf("%-21.21s %-50.50s\n", 
                                       groups[i].acct_name,
-                                      groups[i].acct_desc);
-                       else
+                                      description);
+                       } else {
                                printf("%s\n", groups[i].acct_name);
+                       }
+               }
+       } while (NT_STATUS_EQUAL(result, STATUS_MORE_ENTRIES));
+
+ done:
+       return result;
+}
+
+static int rpc_group_list(int argc, const char **argv)
+{
+       return run_rpc_command(NULL, PI_SAMR, 0,
+                              rpc_group_list_internals,
+                              argc, argv);
+}
+static NTSTATUS 
+rpc_group_members_internals(const DOM_SID *domain_sid, struct cli_state *cli,
+                           TALLOC_CTX *mem_ctx, int argc, const char **argv)
+{
+       NTSTATUS result;
+       POLICY_HND connect_pol, domain_pol, group_pol;
+       uint32 num_rids, *rids, *rid_types;
+       uint32 num_members, *group_rids, *group_attrs;
+       uint32 num_names;
+       char **names;
+       uint32 *name_types;
+       int i;
+
+       /* Get sam policy handle */
+       
+       result = cli_samr_connect(cli, mem_ctx, MAXIMUM_ALLOWED_ACCESS, 
+                                 &connect_pol);
+       if (!NT_STATUS_IS_OK(result)) {
+               goto done;
+       }
+       
+       /* Get domain policy handle */
+       
+       result = cli_samr_open_domain(cli, mem_ctx, &connect_pol,
+                                     MAXIMUM_ALLOWED_ACCESS,
+                                     domain_sid, &domain_pol);
+       if (!NT_STATUS_IS_OK(result)) {
+               goto done;
+       }
+
+       result = cli_samr_lookup_names(cli, mem_ctx, &domain_pol, 1000,
+                                      1, argv, &num_rids, &rids, &rid_types);
+
+       if (!NT_STATUS_IS_OK(result)) {
+               goto done;
+       }
+
+       if (num_rids != 1) {
+               d_printf("Could not find group %s\n", argv[0]);
+               goto done;
+       }
+
+       if (rid_types[0] != SID_NAME_DOM_GRP) {
+               d_printf("%s is not a domain group\n", argv[0]);
+               goto done;
+       }
+
+       result = cli_samr_open_group(cli, mem_ctx, &domain_pol,
+                                    MAXIMUM_ALLOWED_ACCESS,
+                                    rids[0], &group_pol);
+
+       if (!NT_STATUS_IS_OK(result))
+               goto done;
+
+       result = cli_samr_query_groupmem(cli, mem_ctx, &group_pol,
+                                        &num_members, &group_rids,
+                                        &group_attrs);
+
+       if (!NT_STATUS_IS_OK(result))
+               goto done;
+
+       while (num_members > 0) {
+               int this_time = 512;
+
+               if (num_members < this_time)
+                       this_time = num_members;
+
+               result = cli_samr_lookup_rids(cli, mem_ctx, &domain_pol, 1000,
+                                             this_time, group_rids,
+                                             &num_names, &names, &name_types);
+
+               if (!NT_STATUS_IS_OK(result))
+                       goto done;
+
+               for (i = 0; i < this_time; i++) {
+                       printf("%s\n", names[i]);
                }
-       } while (!NT_STATUS_IS_OK(result));
+
+               num_members -= this_time;
+               group_rids += 512;
+       }
 
  done:
        return result;
 }
 
+static int rpc_group_members(int argc, const char **argv)
+{
+       if (argc != 1) {
+               return rpc_group_usage(argc, argv);
+       }
+
+       return run_rpc_command(NULL, PI_SAMR, 0,
+                              rpc_group_members_internals,
+                              argc, argv);
+}
+
 /** 
  * 'net rpc group' entrypoint.
  * @param argc  Standard main() style argc
@@ -929,6 +1347,8 @@ int net_rpc_group(int argc, const char **argv)
                {"add", rpc_group_add},
                {"delete", rpc_group_delete},
 #endif
+               {"list", rpc_group_list},
+               {"members", rpc_group_members},
                {NULL, NULL}
        };
        
@@ -936,7 +1356,7 @@ int net_rpc_group(int argc, const char **argv)
                if (opt_long_list_entries) {
                } else {
                }
-               return run_rpc_command(NULL, PIPE_SAMR, 0, 
+               return run_rpc_command(NULL, PI_SAMR, 0, 
                                       rpc_group_list_internals,
                                       argc, argv);
        }
@@ -954,7 +1374,7 @@ static int rpc_share_usage(int argc, const char **argv)
 /** 
  * Add a share on a remote RPC server
  *
- * All paramaters are provided by the run_rpc_command function, except for
+ * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passes through. 
  *
  * @param domain_sid The domain sid acquired from the remote server
@@ -994,7 +1414,7 @@ static int rpc_share_add(int argc, const char **argv)
                DEBUG(1,("Sharename or path not specified on add\n"));
                return rpc_share_usage(argc, argv);
        }
-       return run_rpc_command(NULL, PIPE_SRVSVC, 0, 
+       return run_rpc_command(NULL, PI_SRVSVC, 0, 
                               rpc_share_add_internals,
                               argc, argv);
 }
@@ -1002,7 +1422,7 @@ static int rpc_share_add(int argc, const char **argv)
 /** 
  * Delete a share on a remote RPC server
  *
- * All paramaters are provided by the run_rpc_command function, except for
+ * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passes through. 
  *
  * @param domain_sid The domain sid acquired from the remote server
@@ -1040,7 +1460,7 @@ static int rpc_share_delete(int argc, const char **argv)
                DEBUG(1,("Sharename not specified on delete\n"));
                return rpc_share_usage(argc, argv);
        }
-       return run_rpc_command(NULL, PIPE_SRVSVC, 0, 
+       return run_rpc_command(NULL, PI_SRVSVC, 0, 
                               rpc_share_del_internals,
                               argc, argv);
 }
@@ -1070,7 +1490,7 @@ static void display_share_info_1(SRV_SHARE_INFO_1 *info1)
 /** 
  * List shares on a remote RPC server
  *
- * All paramaters are provided by the run_rpc_command function, except for
+ * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passes through. 
  *
  * @param domain_sid The domain sid acquired from the remote server
@@ -1130,7 +1550,7 @@ int net_rpc_share(int argc, const char **argv)
        };
 
        if (argc == 0)
-               return run_rpc_command(NULL, PIPE_SRVSVC, 0, 
+               return run_rpc_command(NULL, PI_SRVSVC, 0, 
                                       rpc_share_list_internals,
                                       argc, argv);
 
@@ -1147,7 +1567,7 @@ static int rpc_file_usage(int argc, const char **argv)
 /** 
  * Close a file on a remote RPC server
  *
- * All paramaters are provided by the run_rpc_command function, except for
+ * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passes through. 
  *
  * @param domain_sid The domain sid acquired from the remote server
@@ -1184,7 +1604,7 @@ static int rpc_file_close(int argc, const char **argv)
                return(rpc_file_usage(argc, argv));
        }
 
-       return run_rpc_command(NULL, PIPE_SRVSVC, 0, 
+       return run_rpc_command(NULL, PI_SRVSVC, 0, 
                               rpc_file_close_internals,
                               argc, argv);
 }
@@ -1210,7 +1630,7 @@ static void display_file_info_3(FILE_INFO_3 *info3, FILE_INFO_3_STR *str3)
 /** 
  * List open files on a remote RPC server
  *
- * All paramaters are provided by the run_rpc_command funcion, except for
+ * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passes through. 
  *
  * @param domain_sid The domain sid acquired from the remote server
@@ -1275,7 +1695,7 @@ static int rpc_file_user(int argc, const char **argv)
                return(rpc_file_usage(argc, argv));
        }
 
-       return run_rpc_command(NULL, PIPE_SRVSVC, 0, 
+       return run_rpc_command(NULL, PI_SRVSVC, 0, 
                               rpc_file_list_internals,
                               argc, argv);
 }
@@ -1300,7 +1720,7 @@ int net_rpc_file(int argc, const char **argv)
        };
 
        if (argc == 0)
-               return run_rpc_command(NULL, PIPE_SRVSVC, 0, 
+               return run_rpc_command(NULL, PI_SRVSVC, 0, 
                                       rpc_file_list_internals,
                                       argc, argv);
 
@@ -1312,9 +1732,9 @@ int net_rpc_file(int argc, const char **argv)
 
 
 /** 
- * ABORT the shutdown of a remote RPC Server
+ * ABORT the shutdown of a remote RPC Server over, initshutdown pipe
  *
- * All paramaters are provided by the run_rpc_command function, except for
+ * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passed through. 
  *
  * @param domain_sid The domain sid aquired from the remote server
@@ -1327,11 +1747,47 @@ int net_rpc_file(int argc, const char **argv)
  * @return Normal NTSTATUS return.
  **/
 
-static NTSTATUS rpc_shutdown_abort_internals(const DOM_SID *domain_sid, struct cli_state *cli, TALLOC_CTX *mem_ctx, 
+static NTSTATUS rpc_shutdown_abort_internals(const DOM_SID *domain_sid, 
+                                            struct cli_state *cli, 
+                                            TALLOC_CTX *mem_ctx, 
                                             int argc, const char **argv) 
 {
        NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
        
+       result = cli_shutdown_abort(cli, mem_ctx);
+       
+       if (NT_STATUS_IS_OK(result))
+               DEBUG(5,("cmd_shutdown_abort: query succeeded\n"));
+       else
+               DEBUG(5,("cmd_shutdown_abort: query failed\n"));
+       
+       return result;
+}
+
+
+/** 
+ * ABORT the shutdown of a remote RPC Server,  over winreg pipe
+ *
+ * All parameters are provided by the run_rpc_command function, except for
+ * argc, argv which are passed through. 
+ *
+ * @param domain_sid The domain sid aquired from the remote server
+ * @param cli A cli_state connected to the server.
+ * @param mem_ctx Talloc context, destoyed on compleation of the function.
+ * @param argc  Standard main() style argc
+ * @param argv  Standard main() style argv.  Initial components are already
+ *              stripped
+ *
+ * @return Normal NTSTATUS return.
+ **/
+
+static NTSTATUS rpc_reg_shutdown_abort_internals(const DOM_SID *domain_sid, 
+                                                struct cli_state *cli, 
+                                                TALLOC_CTX *mem_ctx, 
+                                                int argc, const char **argv) 
+{
+       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
+       
        result = cli_reg_abort_shutdown(cli, mem_ctx);
        
        if (NT_STATUS_IS_OK(result))
@@ -1342,7 +1798,6 @@ static NTSTATUS rpc_shutdown_abort_internals(const DOM_SID *domain_sid, struct c
        return result;
 }
 
-
 /** 
  * ABORT the Shut down of a remote RPC server
  *
@@ -1355,14 +1810,24 @@ static NTSTATUS rpc_shutdown_abort_internals(const DOM_SID *domain_sid, struct c
 
 static int rpc_shutdown_abort(int argc, const char **argv) 
 {
-       return run_rpc_command(NULL, PIPE_WINREG, 0, rpc_shutdown_abort_internals,
+       int rc = run_rpc_command(NULL, PI_SHUTDOWN, 0, 
+                                rpc_shutdown_abort_internals,
+                                argc, argv);
+
+       if (rc == 0)
+               return rc;
+
+       DEBUG(1, ("initshutdown pipe didn't work, trying winreg pipe\n"));
+
+       return run_rpc_command(NULL, PI_WINREG, 0, 
+                              rpc_reg_shutdown_abort_internals,
                               argc, argv);
 }
 
 /** 
  * Shut down a remote RPC Server
  *
- * All paramaters are provided by the run_rpc_command funcion, except for
+ * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passes through. 
  *
  * @param domain_sid The domain sid aquired from the remote server
@@ -1379,11 +1844,8 @@ static NTSTATUS rpc_shutdown_internals(const DOM_SID *domain_sid, struct cli_sta
                                       int argc, const char **argv) 
 {
        NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
-        char *msg = "This machine will be shutdown shortly";
+        const char *msg = "This machine will be shutdown shortly";
        uint32 timeout = 20;
-       uint16 flgs = 0;
-       BOOL reboot = opt_reboot;
-       BOOL force = opt_force;
 #if 0
        poptContext pc;
        int rc;
@@ -1409,12 +1871,6 @@ static NTSTATUS rpc_shutdown_internals(const DOM_SID *domain_sid, struct cli_sta
                return NT_STATUS_INVALID_PARAMETER;
        }
 #endif
-       if (reboot) {
-               flgs |= REG_REBOOT_ON_SHUTDOWN;
-       }
-       if (force) {
-               flgs |= REG_FORCE_SHUTDOWN;
-       }
        if (opt_comment) {
                msg = opt_comment;
        }
@@ -1423,7 +1879,7 @@ static NTSTATUS rpc_shutdown_internals(const DOM_SID *domain_sid, struct cli_sta
        }
 
        /* create an entry */
-       result = cli_reg_shutdown(cli, mem_ctx, msg, timeout, flgs);
+       result = cli_reg_shutdown(cli, mem_ctx, msg, timeout, opt_reboot, opt_force);
 
        if (NT_STATUS_IS_OK(result))
                DEBUG(5,("Shutdown of remote machine succeeded\n"));
@@ -1445,7 +1901,7 @@ static NTSTATUS rpc_shutdown_internals(const DOM_SID *domain_sid, struct cli_sta
 
 static int rpc_shutdown(int argc, const char **argv) 
 {
-       return run_rpc_command(NULL, PIPE_WINREG, 0, rpc_shutdown_internals,
+       return run_rpc_command(NULL, PI_WINREG, 0, rpc_shutdown_internals,
                                       argc, argv);
 }
 
@@ -1478,8 +1934,8 @@ static NTSTATUS rpc_trustdom_add_internals(const DOM_SID *domain_sid, struct cli
        uint16 acb_info;
        uint32 unknown, user_rid;
 
-       if (argc != 1) {
-               d_printf("Usage: net rpc trustdom add <domain_name>\n");
+       if (argc != 2) {
+               d_printf("Usage: net rpc trustdom add <domain_name> <pw>\n");
                return NT_STATUS_INVALID_PARAMETER;
        }
 
@@ -1491,7 +1947,7 @@ static NTSTATUS rpc_trustdom_add_internals(const DOM_SID *domain_sid, struct cli
                return NT_STATUS_NO_MEMORY;
        }
 
-       strupper(acct_name);
+       strupper_m(acct_name);
 
        /* Get samr policy handle */
        result = cli_samr_connect(cli, mem_ctx, MAXIMUM_ALLOWED_ACCESS,
@@ -1510,7 +1966,7 @@ static NTSTATUS rpc_trustdom_add_internals(const DOM_SID *domain_sid, struct cli
 
        /* Create trusting domain's account */
        acb_info = ACB_DOMTRUST;
-       unknown = 0xe005000b; /* No idea what this is - a permission mask?
+       unknown = 0xe00500b0; /* No idea what this is - a permission mask?
                                 mimir: yes, most probably it is */
 
        result = cli_samr_create_dom_user(cli, mem_ctx, &domain_pol,
@@ -1520,6 +1976,31 @@ static NTSTATUS rpc_trustdom_add_internals(const DOM_SID *domain_sid, struct cli
                goto done;
        }
 
+       {
+               SAM_USERINFO_CTR ctr;
+               SAM_USER_INFO_24 p24;
+               uchar pwbuf[516];
+
+               encode_pw_buffer((char *)pwbuf, argv[1], STR_UNICODE);
+
+               ZERO_STRUCT(ctr);
+               ZERO_STRUCT(p24);
+
+               init_sam_user_info24(&p24, (char *)pwbuf, 24);
+
+               ctr.switch_value = 24;
+               ctr.info.id24 = &p24;
+
+               result = cli_samr_set_userinfo(cli, mem_ctx, &user_pol, 24,
+                                              &cli->user_session_key, &ctr);
+
+               if (!NT_STATUS_IS_OK(result)) {
+                       DEBUG(0,("Could not set trust account password: %s\n",
+                                nt_errstr(result)));
+                       goto done;
+               }
+       }
+
  done:
        SAFE_FREE(acct_name);
        return result;
@@ -1536,8 +2017,13 @@ static NTSTATUS rpc_trustdom_add_internals(const DOM_SID *domain_sid, struct cli
 
 static int rpc_trustdom_add(int argc, const char **argv)
 {
-       return run_rpc_command(NULL, PIPE_SAMR, 0, rpc_trustdom_add_internals,
-                              argc, argv);
+       if (argc > 0) {
+               return run_rpc_command(NULL, PI_SAMR, 0, rpc_trustdom_add_internals,
+                                      argc, argv);
+       } else {
+               d_printf("Usage: net rpc trustdom add <domain>\n");
+               return -1;
+       }
 }
 
 
@@ -1553,6 +2039,7 @@ static int rpc_trustdom_add(int argc, const char **argv)
 static int rpc_trustdom_del(int argc, const char **argv)
 {
        d_printf("Sorry, not yet implemented.\n");
+       d_printf("Use 'smbpasswd -x -i' instead.\n");
        return -1;
 }
 
@@ -1567,10 +2054,6 @@ static int rpc_trustdom_del(int argc, const char **argv)
  * @return Integer status (0 means success)
  **/
 
-extern char *opt_user_name;
-extern char *opt_password;
-extern char *opt_workgroup;
-
 static int rpc_trustdom_establish(int argc, const char **argv)
 {
        struct cli_state *cli;
@@ -1578,10 +2061,11 @@ static int rpc_trustdom_establish(int argc, const char **argv)
        POLICY_HND connect_hnd;
        TALLOC_CTX *mem_ctx;
        NTSTATUS nt_status;
-       DOM_SID domain_sid;
+       DOM_SID *domain_sid;
        WKS_INFO_100 wks_info;
        
        char* domain_name;
+       char* domain_name_pol;
        char* acct_name;
        fstring pdc_name;
 
@@ -1595,25 +2079,25 @@ static int rpc_trustdom_establish(int argc, const char **argv)
        }
 
        domain_name = smb_xstrdup(argv[0]);
-       strupper(domain_name);
+       strupper_m(domain_name);
+
+       /* account name used at first is our domain's name with '$' */
+       asprintf(&acct_name, "%s$", lp_workgroup());
+       strupper_m(acct_name);
        
        /*
         * opt_workgroup will be used by connection functions further,
         * hence it should be set to remote domain name instead of ours
         */
        if (opt_workgroup) {
-               SAFE_FREE(opt_workgroup);
                opt_workgroup = smb_xstrdup(domain_name);
        };
        
-       asprintf(&acct_name, "%s$", lp_workgroup());
-       strupper(acct_name);
-       
        opt_user_name = acct_name;
 
        /* find the domain controller */
-       if (!net_find_dc(&server_ip, pdc_name, domain_name)) {
-               DEBUG(0, ("Coulnd find domain controller for domain %s\n", domain_name));
+       if (!net_find_pdc(&server_ip, pdc_name, domain_name)) {
+               DEBUG(0, ("Couldn't find domain controller for domain %s\n", domain_name));
                return -1;
        }
 
@@ -1652,12 +2136,12 @@ static int rpc_trustdom_establish(int argc, const char **argv)
         * note: It is now used only to get unicode domain name
         */
        
-       if (!cli_nt_session_open(cli, PIPE_WKSSVC)) {
+       if (!cli_nt_session_open(cli, PI_WKSSVC)) {
                DEBUG(0, ("Couldn't not initialise wkssvc pipe\n"));
                return -1;
        }
 
-       if (!(mem_ctx = talloc_init_named("establishing trust relationship to domain %s",
+       if (!(mem_ctx = talloc_init("establishing trust relationship to domain %s",
                        domain_name))) {
                DEBUG(0, ("talloc_init() failed\n"));
                cli_shutdown(cli);
@@ -1679,13 +2163,13 @@ static int rpc_trustdom_establish(int argc, const char **argv)
         * Call LsaOpenPolicy and LsaQueryInfo
         */
         
-       if (!(mem_ctx = talloc_init())) {
+       if (!(mem_ctx = talloc_init("rpc_trustdom_establish"))) {
                DEBUG(0, ("talloc_init() failed\n"));
                cli_shutdown(cli);
                return -1;
        }
 
-       if (!cli_nt_session_open(cli, PIPE_LSARPC)) {
+       if (!cli_nt_session_open(cli, PI_LSARPC)) {
                DEBUG(0, ("Could not initialise lsa pipe\n"));
                cli_shutdown(cli);
                return -1;
@@ -1702,7 +2186,7 @@ static int rpc_trustdom_establish(int argc, const char **argv)
        /* Querying info level 5 */
        
        nt_status = cli_lsa_query_info_policy(cli, mem_ctx, &connect_hnd,
-                                             5 /* info level */, domain_name,
+                                             5 /* info level */, &domain_name_pol,
                                              &domain_sid);
        if (NT_STATUS_IS_ERR(nt_status)) {
                DEBUG(0, ("LSA Query Info failed. Returned error was %s\n",
@@ -1722,7 +2206,7 @@ static int rpc_trustdom_establish(int argc, const char **argv)
 
        if (!secrets_store_trusted_domain_password(domain_name, wks_info.uni_lan_grp.buffer,
                                                   wks_info.uni_lan_grp.uni_str_len, opt_password,
-                                                  domain_sid)) {
+                                                  *domain_sid)) {
                DEBUG(0, ("Storing password for trusted domain failed.\n"));
                return -1;
        }
@@ -1764,7 +2248,7 @@ static int rpc_trustdom_revoke(int argc, const char **argv)
        
        /* generate upper cased domain name */
        domain_name = smb_xstrdup(argv[0]);
-       strupper(domain_name);
+       strupper_m(domain_name);
 
        /* delete password of the trust */
        if (!trusted_domain_password_delete(domain_name)) {
@@ -1803,13 +2287,8 @@ static NTSTATUS rpc_query_domain_sid(const DOM_SID *domain_sid, struct cli_state
        sid_to_string(str_sid, domain_sid);
        d_printf("%s\n", str_sid);
        return NT_STATUS_OK;
-};
-
+}
 
-extern char* opt_workgroup;
-extern char* opt_target_worgroup;
-extern char* opt_host;
-extern char* opt_password;
 
 static int rpc_trustdom_list(int argc, const char **argv)
 {
@@ -1817,18 +2296,19 @@ static int rpc_trustdom_list(int argc, const char **argv)
        TALLOC_CTX* mem_ctx;
        struct cli_state *cli, *remote_cli;
        NTSTATUS nt_status;
-       char *domain_name = NULL;
-       DOM_SID queried_dom_sid;
+       const char *domain_name = NULL;
+       DOM_SID *queried_dom_sid;
        fstring ascii_sid, padding;
        int ascii_dom_name_len;
        POLICY_HND connect_hnd;
        
        /* trusted domains listing variables */
-       int enum_ctx = 0, pref_num_domains = 5;
-       int num_domains, i, pad_len, col_len = 20;
+       unsigned int num_domains, enum_ctx = 0;
+       int i, pad_len, col_len = 20;
        DOM_SID *domain_sids;
        char **trusted_dom_names;
        fstring pdc_name;
+       char *dummy;
        
        /* trusting domains listing variables */
        POLICY_HND domain_hnd;
@@ -1839,21 +2319,19 @@ static int rpc_trustdom_list(int argc, const char **argv)
         * Listing trusted domains (stored in secrets.tdb, if local)
         */
 
-       mem_ctx = talloc_init_named("trust relationships listing");
+       mem_ctx = talloc_init("trust relationships listing");
 
        /*
         * set domain and pdc name to local samba server (default)
         * or to remote one given in command line
         */
-       strupper(opt_workgroup);
-       if (strcmp(opt_workgroup, lp_workgroup())) {
+       
+       if (StrCaseCmp(opt_workgroup, lp_workgroup())) {
                domain_name = opt_workgroup;
-               if (opt_target_workgroup) SAFE_FREE(opt_target_workgroup);
                opt_target_workgroup = opt_workgroup;
        } else {
-               safe_strcpy(pdc_name, global_myname, FSTRING_LEN);
+               fstrcpy(pdc_name, global_myname());
                domain_name = talloc_strdup(mem_ctx, lp_workgroup());
-               if (opt_target_workgroup) SAFE_FREE(opt_target_workgroup);
                opt_target_workgroup = domain_name;
        };
 
@@ -1863,12 +2341,12 @@ static int rpc_trustdom_list(int argc, const char **argv)
                return -1;
        };
 
-       if (!cli_nt_session_open(cli, PIPE_LSARPC)) {
+       if (!cli_nt_session_open(cli, PI_LSARPC)) {
                DEBUG(0, ("Could not initialise lsa pipe\n"));
                return -1;
        };
 
-       nt_status = cli_lsa_open_policy2(cli, mem_ctx, True, SEC_RIGHTS_QUERY_VALUE,
+       nt_status = cli_lsa_open_policy2(cli, mem_ctx, False, SEC_RIGHTS_QUERY_VALUE,
                                        &connect_hnd);
        if (NT_STATUS_IS_ERR(nt_status)) {
                DEBUG(0, ("Couldn't open policy handle. Error was %s\n",
@@ -1877,8 +2355,10 @@ static int rpc_trustdom_list(int argc, const char **argv)
        };
        
        /* query info level 5 to obtain sid of a domain being queried */
-       nt_status = cli_lsa_query_info_policy(cli, mem_ctx, &connect_hnd,
-                                       5 /* info level */, domain_name, &queried_dom_sid);
+       nt_status = cli_lsa_query_info_policy(
+               cli, mem_ctx, &connect_hnd, 5 /* info level */, 
+               &dummy, &queried_dom_sid);
+
        if (NT_STATUS_IS_ERR(nt_status)) {
                DEBUG(0, ("LSA Query Info failed. Returned error was %s\n",
                        nt_errstr(nt_status)));
@@ -1894,7 +2374,7 @@ static int rpc_trustdom_list(int argc, const char **argv)
 
        do {
                nt_status = cli_lsa_enum_trust_dom(cli, mem_ctx, &connect_hnd, &enum_ctx,
-                                                  &pref_num_domains, &num_domains,
+                                                  &num_domains,
                                                   &trusted_dom_names, &domain_sids);
                
                if (NT_STATUS_IS_ERR(nt_status)) {
@@ -1914,6 +2394,12 @@ static int rpc_trustdom_list(int argc, const char **argv)
                        
                        d_printf("%s%s%s\n", trusted_dom_names[i], padding, ascii_sid);
                };
+               
+               /*
+                * in case of no trusted domains say something rather
+                * than just display blank line
+                */
+               if (!num_domains) d_printf("none\n");
 
        } while (NT_STATUS_EQUAL(nt_status, STATUS_MORE_ENTRIES));
 
@@ -1936,13 +2422,13 @@ static int rpc_trustdom_list(int argc, const char **argv)
        /*
         * Open \PIPE\samr and get needed policy handles
         */
-       if (!cli_nt_session_open(cli, PIPE_SAMR)) {
+       if (!cli_nt_session_open(cli, PI_SAMR)) {
                DEBUG(0, ("Could not initialise samr pipe\n"));
                return -1;
        };
        
        /* SamrConnect */
-       nt_status = cli_samr_connect(cli, mem_ctx, SAMR_ACCESS_OPEN_DOMAIN,
+       nt_status = cli_samr_connect(cli, mem_ctx, SA_RIGHT_SAM_OPEN_DOMAIN,
                                                                 &connect_hnd);
        if (!NT_STATUS_IS_OK(nt_status)) {
                DEBUG(0, ("Couldn't open SAMR policy handle. Error was %s\n",
@@ -1953,8 +2439,8 @@ static int rpc_trustdom_list(int argc, const char **argv)
        /* SamrOpenDomain - we have to open domain policy handle in order to be
           able to enumerate accounts*/
        nt_status = cli_samr_open_domain(cli, mem_ctx, &connect_hnd,
-                                                                        DOMAIN_ACCESS_ENUM_ACCOUNTS,
-                                                                        &queried_dom_sid, &domain_hnd);                                                                         
+                                        SA_RIGHT_DOMAIN_ENUM_ACCOUNTS,
+                                        queried_dom_sid, &domain_hnd);                                                                  
        if (!NT_STATUS_IS_OK(nt_status)) {
                DEBUG(0, ("Couldn't open domain object. Error was %s\n",
                        nt_errstr(nt_status)));
@@ -1997,9 +2483,8 @@ static int rpc_trustdom_list(int argc, const char **argv)
                        do padding[--pad_len] = ' '; while (pad_len);
 
                        /* set opt_* variables to remote domain */
-                       strupper(trusting_dom_names[i]);
+                       strupper_m(trusting_dom_names[i]);
                        opt_workgroup = talloc_strdup(mem_ctx, trusting_dom_names[i]);
-                       if (opt_target_workgroup) SAFE_FREE(opt_target_workgroup);
                        opt_target_workgroup = opt_workgroup;
                        
                        d_printf("%s%s", trusting_dom_names[i], padding);
@@ -2008,7 +2493,7 @@ static int rpc_trustdom_list(int argc, const char **argv)
                        remote_cli = net_make_ipc_connection(NET_FLAGS_PDC | NET_FLAGS_ANONYMOUS);
                        if (remote_cli) {                       
                                /* query for domain's sid */
-                               if (run_rpc_command(remote_cli, PIPE_LSARPC, 0, rpc_query_domain_sid, argc, argv))
+                               if (run_rpc_command(remote_cli, PI_LSARPC, 0, rpc_query_domain_sid, argc, argv))
                                        d_printf("couldn't get domain's sid\n");
 
                                cli_shutdown(remote_cli);
@@ -2018,6 +2503,8 @@ static int rpc_trustdom_list(int argc, const char **argv)
                        };
                };
                
+               if (!num_domains) d_printf("none\n");
+               
        } while (NT_STATUS_EQUAL(nt_status, STATUS_MORE_ENTRIES));
 
        /* close opened samr and domain policy handles */
@@ -2083,7 +2570,7 @@ BOOL net_rpc_check(unsigned flags)
 
        /* flags (i.e. server type) may depend on command */
        if (!net_find_server(flags, &server_ip, &server_name))
-               goto done;
+               return False;
 
        ZERO_STRUCT(cli);
        if (cli_initialise(&cli) == False)
@@ -2091,7 +2578,7 @@ BOOL net_rpc_check(unsigned flags)
 
        if (!cli_connect(&cli, server_name, &server_ip))
                goto done;
-       if (!attempt_netbios_session_request(&cli, global_myname, 
+       if (!attempt_netbios_session_request(&cli, global_myname()
                                             server_name, &server_ip))
                goto done;
        if (!cli_negprot(&cli))
@@ -2120,11 +2607,16 @@ int net_rpc_usage(int argc, const char **argv)
 {
        d_printf("  net rpc info \t\t\tshow basic info about a domain \n");
        d_printf("  net rpc join \t\t\tto join a domain \n");
+       d_printf("  net rpc oldjoin \t\t\tto join a domain created in server manager\n\n\n");
+       d_printf("  net rpc testjoin \t\ttests that a join is valid\n");
        d_printf("  net rpc user \t\t\tto add, delete and list users\n");
        d_printf("  net rpc group \t\tto list groups\n");
        d_printf("  net rpc share \t\tto add, delete, and list shares\n");
        d_printf("  net rpc file \t\t\tto list open files\n");
        d_printf("  net rpc changetrustpw \tto change the trust account password\n");
+       d_printf("  net rpc getsid \t\tfetch the domain sid into the local secrets.tdb\n");
+       d_printf("  net rpc vampire \t\tsyncronise an NT PDC's users and groups into the local passdb\n");
+       d_printf("  net rpc samdump \t\tdiplay an NT PDC's users, groups and other data\n");
        d_printf("  net rpc trustdom \t\tto create trusting domain's account\n"
                 "\t\t\t\t\tor establish trust\n");
        d_printf("  net rpc abortshutdown \tto abort the shutdown of a remote server\n");
@@ -2182,14 +2674,20 @@ int net_rpc(int argc, const char **argv)
        struct functable func[] = {
                {"info", net_rpc_info},
                {"join", net_rpc_join},
+               {"oldjoin", net_rpc_oldjoin},
+               {"testjoin", net_rpc_testjoin},
                {"user", net_rpc_user},
+               {"password", rpc_user_password},
                {"group", net_rpc_group},
                {"share", net_rpc_share},
                {"file", net_rpc_file},
-               {"changetrustpw", rpc_changetrustpw},
+               {"changetrustpw", net_rpc_changetrustpw},
                {"trustdom", rpc_trustdom},
                {"abortshutdown", rpc_shutdown_abort},
                {"shutdown", rpc_shutdown},
+               {"samdump", rpc_samdump},
+               {"vampire", rpc_vampire},
+               {"getsid", net_rpc_getsid},
                {"help", net_rpc_help},
                {NULL, NULL}
        };