s3:net: make use of cli_rpc_pipe_open_with_creds() by using net_context_creds()
[vlendec/samba-autobuild/.git] / source3 / utils / net_rpc.c
index 51517e6f185f7eaea76f8120b0a60cb25e24a1a5..d59522e29caf808d71f68299ea8e8cdbd3ab8dc4 100644 (file)
@@ -22,6 +22,7 @@
 
 #include "includes.h"
 #include "utils/net.h"
+#include "libsmb/namequery.h"
 #include "rpc_client/cli_pipe.h"
 #include "../libcli/auth/libcli_auth.h"
 #include "../librpc/gen_ndr/ndr_samr_c.h"
 #include "rpc_client/init_lsa.h"
 #include "../libcli/security/security.h"
 #include "libsmb/libsmb.h"
-#include "libsmb/clirap.h"
+#include "clirap2.h"
 #include "nsswitch/libwbclient/wbclient.h"
 #include "passdb.h"
 #include "../libcli/smb/smbXcli_base.h"
+#include "libsmb/dsgetdcname.h"
 
 static int net_mode_share;
 static NTSTATUS sync_files(struct copy_clistate *cp_clistate, const char *mask);
@@ -56,8 +58,8 @@ static NTSTATUS sync_files(struct copy_clistate *cp_clistate, const char *mask);
  * @brief RPC based subcommands for the 'net' utility.
  *
  * This file should contain much of the functionality that used to
- * be found in rpcclient, execpt that the commands should change
- * less often, and the fucntionality should be sane (the user is not
+ * be found in rpcclient, except that the commands should change
+ * less often, and the functionality should be sane (the user is not
  * expected to know a rid/sid before they conduct an operation etc.)
  *
  * @todo Perhaps eventually these should be split out into a number
@@ -204,16 +206,23 @@ int run_rpc_command(struct net_context *c,
                        }
                } else {
                        if (conn_flags & NET_FLAGS_SEAL) {
-                               nt_status = cli_rpc_pipe_open_generic_auth(
+                               struct cli_credentials *creds = NULL;
+
+                               creds = net_context_creds(c, mem_ctx);
+                               if (creds == NULL) {
+                                       DBG_ERR("net_rpc_ntlm_creds() failed\n");
+                                       nt_status = NT_STATUS_INTERNAL_ERROR;
+                                       goto fail;
+                               }
+
+                               nt_status = cli_rpc_pipe_open_with_creds(
                                        cli, table,
                                        (conn_flags & NET_FLAGS_TCP) ?
                                        NCACN_IP_TCP : NCACN_NP,
-                                       CRED_DONT_USE_KERBEROS,
                                        DCERPC_AUTH_TYPE_NTLMSSP,
                                        DCERPC_AUTH_LEVEL_PRIVACY,
                                        smbXcli_conn_remote_name(cli->conn),
-                                       lp_workgroup(), c->opt_user_name,
-                                       c->opt_password, &pipe_hnd);
+                                       creds, &pipe_hnd);
                        } else {
                                nt_status = cli_rpc_pipe_open_noauth(
                                        cli, table,
@@ -234,7 +243,7 @@ int run_rpc_command(struct net_context *c,
                DEBUG(1, ("rpc command function failed! (%s)\n", nt_errstr(nt_status)));
        } else {
                ret = 0;
-               DEBUG(5, ("rpc command function succedded\n"));
+               DEBUG(5, ("rpc command function succeeded\n"));
        }
 
        if (!(conn_flags & NET_FLAGS_NO_PIPE)) {
@@ -254,7 +263,7 @@ fail:
 }
 
 /**
- * Force a change of the trust acccount password.
+ * Force a change of the trust account password.
  *
  * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passed through.
@@ -303,7 +312,7 @@ static NTSTATUS rpc_changetrustpw_internals(struct net_context *c,
 }
 
 /**
- * Force a change of the trust acccount password.
+ * Force a change of the trust account password.
  *
  * @param argc  Standard main() style argc.
  * @param argv  Standard main() style argv. Initial components are already
@@ -314,6 +323,12 @@ static NTSTATUS rpc_changetrustpw_internals(struct net_context *c,
 
 int net_rpc_changetrustpw(struct net_context *c, int argc, const char **argv)
 {
+       int conn_flags = NET_FLAGS_PDC;
+
+       if (!c->opt_user_specified && !c->opt_kerberos) {
+               conn_flags |= NET_FLAGS_ANONYMOUS;
+       }
+
        if (c->display_usage) {
                d_printf(  "%s\n"
                           "net rpc changetrustpw\n"
@@ -324,7 +339,7 @@ int net_rpc_changetrustpw(struct net_context *c, int argc, const char **argv)
        }
 
        return run_rpc_command(c, NULL, &ndr_table_netlogon,
-                              NET_FLAGS_ANONYMOUS | NET_FLAGS_PDC,
+                              conn_flags,
                               rpc_changetrustpw_internals,
                               argc, argv);
 }
@@ -334,7 +349,7 @@ int net_rpc_changetrustpw(struct net_context *c, int argc, const char **argv)
  * the message to be displayed when oldjoin was explicitly
  * requested, but not when it was implied by "net rpc join".
  *
- * This uses 'machinename' as the inital password, and changes it.
+ * This uses 'machinename' as the initial password, and changes it.
  *
  * The password should be created with 'server manager' or equiv first.
  *
@@ -373,7 +388,7 @@ static int net_rpc_oldjoin(struct net_context *c, int argc, const char **argv)
        }
 
        /*
-          check what type of join - if the user want's to join as
+          check what type of join - if the user wants to join as
           a BDC, the server must agree that we are a BDC.
        */
        if (argc >= 0) {
@@ -566,7 +581,7 @@ static int net_rpc_join_newstyle(struct net_context *c, int argc, const char **a
        }
 
        /*
-          check what type of join - if the user want's to join as
+          check what type of join - if the user wants to join as
           a BDC, the server must agree that we are a BDC.
        */
        if (argc >= 0) {
@@ -721,11 +736,8 @@ NTSTATUS rpc_info_internals(struct net_context *c,
        struct policy_handle connect_pol, domain_pol;
        NTSTATUS status, result;
        union samr_DomainInfo *info = NULL;
-       fstring sid_str;
        struct dcerpc_binding_handle *b = pipe_hnd->binding_handle;
 
-       sid_to_fstring(sid_str, domain_sid);
-
        /* Get sam policy handle */
        status = dcerpc_samr_Connect2(b, mem_ctx,
                                      pipe_hnd->desthost,
@@ -774,9 +786,12 @@ NTSTATUS rpc_info_internals(struct net_context *c,
        }
        status = result;
        if (NT_STATUS_IS_OK(result)) {
+               struct dom_sid_buf sid_str;
+
                d_printf(_("Domain Name: %s\n"),
                         info->general.domain_name.string);
-               d_printf(_("Domain SID: %s\n"), sid_str);
+               d_printf(_("Domain SID: %s\n"),
+                        dom_sid_str_buf(domain_sid, &sid_str));
                d_printf(_("Sequence number: %llu\n"),
                        (unsigned long long)info->general.sequence_num);
                d_printf(_("Num users: %u\n"), info->general.num_users);
@@ -836,11 +851,11 @@ static NTSTATUS rpc_getsid_internals(struct net_context *c,
                        int argc,
                        const char **argv)
 {
-       fstring sid_str;
+       struct dom_sid_buf sid_str;
 
-       sid_to_fstring(sid_str, domain_sid);
        d_printf(_("Storing SID %s for Domain %s in secrets.tdb\n"),
-                sid_str, domain_name);
+                dom_sid_str_buf(domain_sid, &sid_str),
+                domain_name);
 
        if (!secrets_store_domain_sid(domain_name, domain_sid)) {
                DEBUG(0,("Can't store domain SID\n"));
@@ -861,7 +876,7 @@ int net_rpc_getsid(struct net_context *c, int argc, const char **argv)
 {
        int conn_flags = NET_FLAGS_PDC;
 
-       if (!c->opt_user_specified) {
+       if (!c->opt_user_specified && !c->opt_kerberos) {
                conn_flags |= NET_FLAGS_ANONYMOUS;
        }
 
@@ -3048,9 +3063,6 @@ static NTSTATUS rpc_list_group_members(struct net_context *c,
        struct samr_Ids types;
        struct dcerpc_binding_handle *b = pipe_hnd->binding_handle;
 
-       fstring sid_str;
-       sid_to_fstring(sid_str, domain_sid);
-
        status = dcerpc_samr_OpenGroup(b, mem_ctx,
                                       domain_pol,
                                       MAXIMUM_ALLOWED_ACCESS,
@@ -3109,8 +3121,14 @@ static NTSTATUS rpc_list_group_members(struct net_context *c,
                for (i = 0; i < this_time; i++) {
 
                        if (c->opt_long_list_entries) {
-                               printf("%s-%d %s\\%s %d\n", sid_str,
-                                      group_rids[i], domain_name,
+                               struct dom_sid sid;
+                               struct dom_sid_buf sid_str;
+
+                               sid_compose(&sid, domain_sid, group_rids[i]);
+
+                               printf("%s %s\\%s %d\n",
+                                      dom_sid_str_buf(&sid, &sid_str),
+                                      domain_name,
                                       names.names[i].string,
                                       SID_NAME_USER);
                        } else {
@@ -3218,18 +3236,18 @@ static NTSTATUS rpc_list_alias_members(struct net_context *c,
        }
 
        for (i = 0; i < num_members; i++) {
-               fstring sid_str;
-               sid_to_fstring(sid_str, &alias_sids[i]);
+               struct dom_sid_buf sid_str;
+               dom_sid_str_buf(&alias_sids[i], &sid_str);
 
                if (c->opt_long_list_entries) {
-                       printf("%s %s\\%s %d\n", sid_str,
+                       printf("%s %s\\%s %d\n", sid_str.buf,
                               domains[i] ? domains[i] : _("*unknown*"),
                               names[i] ? names[i] : _("*unknown*"), types[i]);
                } else {
                        if (domains[i])
                                printf("%s\\%s\n", domains[i], names[i]);
                        else
-                               printf("%s\n", sid_str);
+                               printf("%s\n", sid_str.buf);
                }
        }
 
@@ -4059,7 +4077,7 @@ static NTSTATUS copy_fn(const char *mnt, struct file_info *f,
 }
 
 /**
- * sync files, can be called recursivly to list files
+ * sync files, can be called recursively to list files
  * and then call copy_fn for each file
  *
  * @param cp_clistate  pointer to the copy_clistate we work with
@@ -4658,6 +4676,10 @@ static NTSTATUS rpc_fetch_domain_aliases(struct rpc_pipe_client *pipe_hnd,
 
                        if (alias.num_members > 0) {
                                alias.members = SMB_MALLOC_ARRAY(struct dom_sid, alias.num_members);
+                               if (alias.members == NULL) {
+                                       status = NT_STATUS_NO_MEMORY;
+                                       goto done;
+                               }
 
                                for (j = 0; j < alias.num_members; j++)
                                        sid_copy(&alias.members[j],
@@ -4838,7 +4860,9 @@ static void dump_user_token(struct user_token *token)
        d_printf("%s\n", token->name);
 
        for (i=0; i<token->token.num_sids; i++) {
-               d_printf(" %s\n", sid_string_tos(&token->token.sids[i]));
+               struct dom_sid_buf buf;
+               d_printf(" %s\n",
+                        dom_sid_str_buf(&token->token.sids[i], &buf));
        }
 }
 
@@ -4847,8 +4871,9 @@ static bool is_alias_member(struct dom_sid *sid, struct full_alias *alias)
        int i;
 
        for (i=0; i<alias->num_members; i++) {
-               if (dom_sid_compare(sid, &alias->members[i]) == 0)
+               if (dom_sid_equal(sid, &alias->members[i])) {
                        return true;
+               }
        }
 
        return false;
@@ -5230,7 +5255,13 @@ static NTSTATUS rpc_share_allowedusers_internals(struct net_context *c,
        if (argc == 0) {
                f = stdin;
        } else {
-               f = fopen(argv[0], "r");
+               if (strequal(argv[0], "-")) {
+                       f = stdin;
+               } else {
+                       f = fopen(argv[0], "r");
+               }
+               argv++;
+               argc--;
        }
 
        if (f == NULL) {
@@ -5259,6 +5290,17 @@ static NTSTATUS rpc_share_allowedusers_internals(struct net_context *c,
 
        b = pipe_hnd->binding_handle;
 
+       if (argc != 0) {
+               /* Show results only for shares listed on the command line. */
+               while (*argv) {
+                       const char *netname = *argv++;
+                       d_printf("%s\n", netname);
+                       show_userlist(pipe_hnd, cli, mem_ctx, netname,
+                                     num_tokens, tokens);
+               }
+               goto done;
+       }
+
        /* Issue the NetShareEnum RPC call and retrieve the response */
        nt_status = dcerpc_srvsvc_NetShareEnumAll(b,
                                        talloc_tos(),
@@ -5407,9 +5449,9 @@ int net_rpc_share(struct net_context *c, int argc, const char **argv)
                        "allowedusers",
                        rpc_share_allowedusers,
                        NET_TRANSPORT_RPC,
-                       N_("Modify allowed users"),
+                       N_("List allowed users"),
                        N_("net rpc share allowedusers\n"
-                          "    Modify allowed users")
+                          "    List allowed users")
                },
                {
                        "migrate",
@@ -6060,6 +6102,7 @@ static NTSTATUS rpc_trustdom_add_internals(struct net_context *c,
        unsigned int orig_timeout;
        struct dcerpc_binding_handle *b = pipe_hnd->binding_handle;
        DATA_BLOB session_key = data_blob_null;
+       TALLOC_CTX *frame = NULL;
 
        if (argc != 2) {
                d_printf("%s\n%s",
@@ -6069,22 +6112,24 @@ static NTSTATUS rpc_trustdom_add_internals(struct net_context *c,
                return NT_STATUS_INVALID_PARAMETER;
        }
 
+       frame = talloc_stackframe();
+
        /*
         * Make valid trusting domain account (ie. uppercased and with '$' appended)
         */
 
        if (asprintf(&acct_name, "%s$", argv[0]) < 0) {
-               return NT_STATUS_NO_MEMORY;
+               status = NT_STATUS_NO_MEMORY;
        }
 
        if (!strupper_m(acct_name)) {
-               SAFE_FREE(acct_name);
-               return NT_STATUS_INVALID_PARAMETER;
+               status = NT_STATUS_INVALID_PARAMETER;
+               goto done;
        }
 
        init_lsa_String(&lsa_acct_name, acct_name);
 
-       status = cli_get_session_key(mem_ctx, pipe_hnd, &session_key);
+       status = cli_get_session_key(frame, pipe_hnd, &session_key);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0,("Error getting session_key of SAM pipe. Error was %s\n",
                        nt_errstr(status)));
@@ -6092,7 +6137,7 @@ static NTSTATUS rpc_trustdom_add_internals(struct net_context *c,
        }
 
        /* Get samr policy handle */
-       status = dcerpc_samr_Connect2(b, mem_ctx,
+       status = dcerpc_samr_Connect2(b, frame,
                                      pipe_hnd->desthost,
                                      MAXIMUM_ALLOWED_ACCESS,
                                      &connect_pol,
@@ -6106,7 +6151,7 @@ static NTSTATUS rpc_trustdom_add_internals(struct net_context *c,
        }
 
        /* Get domain policy handle */
-       status = dcerpc_samr_OpenDomain(b, mem_ctx,
+       status = dcerpc_samr_OpenDomain(b, frame,
                                        &connect_pol,
                                        MAXIMUM_ALLOWED_ACCESS,
                                        discard_const_p(struct dom_sid2, domain_sid),
@@ -6133,7 +6178,7 @@ static NTSTATUS rpc_trustdom_add_internals(struct net_context *c,
                     SAMR_USER_ACCESS_GET_ATTRIBUTES |
                     SAMR_USER_ACCESS_SET_ATTRIBUTES;
 
-       status = dcerpc_samr_CreateUser2(b, mem_ctx,
+       status = dcerpc_samr_CreateUser2(b, frame,
                                         &domain_pol,
                                         &lsa_acct_name,
                                         acb_info,
@@ -6160,16 +6205,19 @@ static NTSTATUS rpc_trustdom_add_internals(struct net_context *c,
 
                ZERO_STRUCT(info.info23);
 
-               init_samr_CryptPassword(argv[1],
-                                       &session_key,
-                                       &crypt_pwd);
+               status = init_samr_CryptPassword(argv[1],
+                                                &session_key,
+                                                &crypt_pwd);
+               if (!NT_STATUS_IS_OK(status)) {
+                       goto done;
+               }
 
                info.info23.info.fields_present = SAMR_FIELD_ACCT_FLAGS |
                                                  SAMR_FIELD_NT_PASSWORD_PRESENT;
                info.info23.info.acct_flags = ACB_DOMTRUST;
                info.info23.password = crypt_pwd;
 
-               status = dcerpc_samr_SetUserInfo2(b, mem_ctx,
+               status = dcerpc_samr_SetUserInfo2(b, frame,
                                                  &user_pol,
                                                  23,
                                                  &info,
@@ -6186,9 +6234,11 @@ static NTSTATUS rpc_trustdom_add_internals(struct net_context *c,
                }
        }
 
+       status = NT_STATUS_OK;
  done:
        SAFE_FREE(acct_name);
        data_blob_clear_free(&session_key);
+       TALLOC_FREE(frame);
        return status;
 }
 
@@ -6545,6 +6595,7 @@ static int rpc_trustdom_establish(struct net_context *c, int argc,
        };
 
        c->opt_user_name = acct_name;
+       c->opt_user_specified = true;
 
        /* find the domain controller */
        if (!net_find_pdc(&server_ss, pdc_name, domain_name)) {
@@ -6733,22 +6784,18 @@ static NTSTATUS rpc_query_domain_sid(struct net_context *c,
                                        int argc,
                                        const char **argv)
 {
-       fstring str_sid;
-       if (!sid_to_fstring(str_sid, domain_sid)) {
-               return NT_STATUS_UNSUCCESSFUL;
-       }
-       d_printf("%s\n", str_sid);
+       struct dom_sid_buf sid_str;
+       d_printf("%s\n", dom_sid_str_buf(domain_sid, &sid_str));
        return NT_STATUS_OK;
 }
 
 static void print_trusted_domain(struct dom_sid *dom_sid, const char *trusted_dom_name)
 {
-       fstring ascii_sid;
-
-       /* convert sid into ascii string */
-       sid_to_fstring(ascii_sid, dom_sid);
+       struct dom_sid_buf sid_str;
 
-       d_printf("%-20s%s\n", trusted_dom_name, ascii_sid);
+       d_printf("%-20s%s\n",
+                trusted_dom_name,
+                dom_sid_str_buf(dom_sid, &sid_str));
 }
 
 static NTSTATUS vampire_trusted_domain(struct rpc_pipe_client *pipe_hnd,
@@ -6807,9 +6854,14 @@ static NTSTATUS vampire_trusted_domain(struct rpc_pipe_client *pipe_hnd,
        }
 
 #ifdef DEBUG_PASSWORD
-       DEBUG(100,("successfully vampired trusted domain [%s], sid: [%s], "
-                  "password: [%s]\n", trusted_dom_name,
-                  sid_string_dbg(&dom_sid), cleartextpwd));
+       {
+               struct dom_sid_buf buf;
+               DEBUG(100,("successfully vampired trusted domain [%s], "
+                          "sid: [%s], password: [%s]\n",
+                          trusted_dom_name,
+                          dom_sid_str_buf(&dom_sid, &buf),
+                          cleartextpwd));
+       }
 #endif
 
 done:
@@ -7423,10 +7475,14 @@ bool net_rpc_check(struct net_context *c, unsigned flags)
                                lp_netbios_name(), SMB_SIGNING_IPC_DEFAULT,
                                0, &cli);
        if (!NT_STATUS_IS_OK(status)) {
+               if (NT_STATUS_EQUAL(status, NT_STATUS_NOT_SUPPORTED)) {
+                       DBG_ERR("NetBIOS support disabled, unable to connect\n");
+               }
                return false;
        }
-       status = smbXcli_negprot(cli->conn, cli->timeout, PROTOCOL_CORE,
-                                PROTOCOL_NT1);
+       status = smbXcli_negprot(cli->conn, cli->timeout,
+                                lp_client_min_protocol(),
+                                lp_client_max_protocol());
        if (!NT_STATUS_IS_OK(status))
                goto done;
        if (smbXcli_conn_protocol(cli->conn) < PROTOCOL_NT1)
@@ -7442,15 +7498,6 @@ bool net_rpc_check(struct net_context *c, unsigned flags)
 static int rpc_vampire(struct net_context *c, int argc, const char **argv)
 {
        struct functable func[] = {
-               {
-                       "ldif",
-                       rpc_vampire_ldif,
-                       NET_TRANSPORT_RPC,
-                       N_("Dump remote SAM database to ldif"),
-                       N_("net rpc vampire ldif\n"
-                          "    Dump remote SAM database to LDIF file or "
-                          "stdout")
-               },
                {
                        "keytab",
                        rpc_vampire_keytab,
@@ -7765,9 +7812,9 @@ int rpc_printer_migrate(struct net_context *c, int argc, const char **argv)
                        "security",
                        rpc_printer_migrate_security,
                        NET_TRANSPORT_RPC,
-                       N_("Mirgate printer ACLs to local server"),
+                       N_("Migrate printer ACLs to local server"),
                        N_("net rpc printer migrate security\n"
-                          "    Mirgate printer ACLs to local server")
+                          "    Migrate printer ACLs to local server")
                },
                {
                        "settings",