notifyd: Use messaging_register for MSG_SMB_NOTIFY_GET_DB
[vlendec/samba-autobuild/.git] / source3 / smbd / service.c
index 13241687078ac3887df935cf9ab0850abeafe6aa..75a47dee0caae891a5364ee00a858400250ad17c 100644 (file)
 #include "auth.h"
 #include "lib/param/loadparm.h"
 #include "messages.h"
+#include "lib/afs/afs_funcs.h"
+#include "lib/util_path.h"
 
 static bool canonicalize_connect_path(connection_struct *conn)
 {
        bool ret;
-       char *resolved_name = SMB_VFS_REALPATH(conn,conn->connectpath);
-       if (!resolved_name) {
+       struct smb_filename con_fname = { .base_name = conn->connectpath };
+       struct smb_filename *resolved_fname = SMB_VFS_REALPATH(conn, talloc_tos(),
+                                               &con_fname);
+       if (resolved_fname == NULL) {
                return false;
        }
-       ret = set_conn_connectpath(conn,resolved_name);
-       SAFE_FREE(resolved_name);
+       ret = set_conn_connectpath(conn,resolved_fname->base_name);
+       TALLOC_FREE(resolved_fname);
        return ret;
 }
 
 /****************************************************************************
  Ensure when setting connectpath it is a canonicalized (no ./ // or ../)
  absolute path stating in / and not ending in /.
- Observent people will notice a similarity between this and check_path_syntax :-).
 ****************************************************************************/
 
 bool set_conn_connectpath(connection_struct *conn, const char *connectpath)
 {
        char *destname;
-       char *d;
-       const char *s = connectpath;
-        bool start_of_name_component = true;
 
        if (connectpath == NULL || connectpath[0] == '\0') {
                return false;
        }
 
-       /* Allocate for strlen + '\0' + possible leading '/' */
-       destname = (char *)talloc_size(conn, strlen(connectpath) + 2);
-       if (!destname) {
+       destname = canonicalize_absolute_path(conn, connectpath);
+       if (destname == NULL) {
                return false;
        }
-       d = destname;
-
-       *d++ = '/'; /* Always start with root. */
-
-       while (*s) {
-               if (*s == '/') {
-                       /* Eat multiple '/' */
-                       while (*s == '/') {
-                                s++;
-                        }
-                       if ((d > destname + 1) && (*s != '\0')) {
-                               *d++ = '/';
-                       }
-                       start_of_name_component = True;
-                       continue;
-               }
-
-               if (start_of_name_component) {
-                       if ((s[0] == '.') && (s[1] == '.') && (s[2] == '/' || s[2] == '\0')) {
-                               /* Uh oh - "/../" or "/..\0" ! */
-
-                               /* Go past the ../ or .. */
-                               if (s[2] == '/') {
-                                       s += 3;
-                               } else {
-                                       s += 2; /* Go past the .. */
-                               }
-
-                               /* If  we just added a '/' - delete it */
-                               if ((d > destname) && (*(d-1) == '/')) {
-                                       *(d-1) = '\0';
-                                       d--;
-                               }
-
-                               /* Are we at the start ? Can't go back further if so. */
-                               if (d <= destname) {
-                                       *d++ = '/'; /* Can't delete root */
-                                       continue;
-                               }
-                               /* Go back one level... */
-                               /* Decrement d first as d points to the *next* char to write into. */
-                               for (d--; d > destname; d--) {
-                                       if (*d == '/') {
-                                               break;
-                                       }
-                               }
-                               /* We're still at the start of a name component, just the previous one. */
-                               continue;
-                       } else if ((s[0] == '.') && ((s[1] == '\0') || s[1] == '/')) {
-                               /* Component of pathname can't be "." only - skip the '.' . */
-                               if (s[1] == '/') {
-                                       s += 2;
-                               } else {
-                                       s++;
-                               }
-                               continue;
-                       }
-               }
-
-               if (!(*s & 0x80)) {
-                       *d++ = *s++;
-               } else {
-                       size_t siz;
-                       /* Get the size of the next MB character. */
-                       next_codepoint(s,&siz);
-                       switch(siz) {
-                               case 5:
-                                       *d++ = *s++;
-                                       /*fall through*/
-                               case 4:
-                                       *d++ = *s++;
-                                       /*fall through*/
-                               case 3:
-                                       *d++ = *s++;
-                                       /*fall through*/
-                               case 2:
-                                       *d++ = *s++;
-                                       /*fall through*/
-                               case 1:
-                                       *d++ = *s++;
-                                       break;
-                               default:
-                                       break;
-                       }
-               }
-               start_of_name_component = false;
-       }
-       *d = '\0';
-
-       /* And must not end in '/' */
-       if (d > destname + 1 && (*(d-1) == '/')) {
-               *(d-1) = '\0';
-       }
 
        DEBUG(10,("set_conn_connectpath: service %s, connectpath = %s\n",
                lp_servicename(talloc_tos(), SNUM(conn)), destname ));
 
        talloc_free(conn->connectpath);
        conn->connectpath = destname;
-       /* Ensure conn->cwd is initialized - start as conn->connectpath. */
-       TALLOC_FREE(conn->cwd);
-       conn->cwd = talloc_strdup(conn, conn->connectpath);
-       if (!conn->cwd) {
+       /*
+        * Ensure conn->cwd_fname is initialized.
+        * start as conn->connectpath.
+        */
+       TALLOC_FREE(conn->cwd_fname);
+       conn->cwd_fname = synthetic_smb_fname(conn,
+                               conn->connectpath,
+                               NULL,
+                               NULL,
+                               0);
+       if (conn->cwd_fname == NULL) {
                return false;
        }
        return true;
@@ -177,9 +90,10 @@ bool set_conn_connectpath(connection_struct *conn, const char *connectpath)
  Load parameters specific to a connection/service.
 ****************************************************************************/
 
-bool set_current_service(connection_struct *conn, uint16 flags, bool do_chdir)
+bool set_current_service(connection_struct *conn, uint16_t flags, bool do_chdir)
 {
        int snum;
+       enum remote_arch_types ra_type;
 
        if (!conn)  {
                last_conn = NULL;
@@ -190,12 +104,22 @@ bool set_current_service(connection_struct *conn, uint16 flags, bool do_chdir)
 
        snum = SNUM(conn);
 
-       if (do_chdir &&
-           vfs_ChDir(conn,conn->connectpath) != 0 &&
-           vfs_ChDir(conn,conn->origpath) != 0) {
-                DEBUG(((errno!=EACCES)?0:3),("chdir (%s) failed, reason: %s\n",
-                         conn->connectpath, strerror(errno)));
-               return(False);
+       {
+               struct smb_filename connectpath_fname = {
+                       .base_name = conn->connectpath
+               };
+               struct smb_filename origpath_fname = {
+                       .base_name = conn->origpath
+               };
+
+               if (do_chdir &&
+                   vfs_ChDir(conn, &connectpath_fname) != 0 &&
+                   vfs_ChDir(conn, &origpath_fname) != 0) {
+                       DEBUG(((errno!=EACCES)?0:3),
+                               ("chdir (%s) failed, reason: %s\n",
+                               conn->connectpath, strerror(errno)));
+                       return(False);
+               }
        }
 
        if ((conn == last_conn) && (last_flags == flags)) {
@@ -205,28 +129,35 @@ bool set_current_service(connection_struct *conn, uint16 flags, bool do_chdir)
        last_conn = conn;
        last_flags = flags;
 
-       /* Obey the client case sensitivity requests - only for clients that support it. */
+       /*
+        * Obey the client case sensitivity requests - only for clients that
+        * support it. */
        switch (lp_case_sensitive(snum)) {
-               case Auto:
-                       {
-                               /* We need this uglyness due to DOS/Win9x clients that lie about case insensitivity. */
-                               enum remote_arch_types ra_type = get_remote_arch();
-                               if ((ra_type != RA_SAMBA) && (ra_type != RA_CIFSFS)) {
-                                       /* Client can't support per-packet case sensitive pathnames. */
-                                       conn->case_sensitive = False;
-                               } else {
-                                       conn->case_sensitive = !(flags & FLAG_CASELESS_PATHNAMES);
-                               }
-                       }
-                       break;
-               case True:
-                       conn->case_sensitive = True;
-                       break;
-               default:
-                       conn->case_sensitive = False;
-                       break;
-       }
-       return(True);
+       case Auto:
+               /*
+                * We need this uglyness due to DOS/Win9x clients that lie
+                * about case insensitivity. */
+               ra_type = get_remote_arch();
+               if (conn->sconn->using_smb2) {
+                       conn->case_sensitive = false;
+               } else if ((ra_type != RA_SAMBA) && (ra_type != RA_CIFSFS)) {
+                       /*
+                        * Client can't support per-packet case sensitive
+                        * pathnames. */
+                       conn->case_sensitive = false;
+               } else {
+                       conn->case_sensitive =
+                                       !(flags & FLAG_CASELESS_PATHNAMES);
+               }
+       break;
+       case True:
+               conn->case_sensitive = true;
+               break;
+       default:
+               conn->case_sensitive = false;
+               break;
+       }
+       return true;
 }
 
 /****************************************************************************
@@ -256,7 +187,7 @@ static NTSTATUS share_sanity_checks(const struct tsocket_address *remote_address
        if (dev[0] == '?' || !dev[0]) {
                if (lp_printable(snum)) {
                        fstrcpy(dev,"LPT1:");
-               } else if (strequal(lp_fstype(talloc_tos(), snum), "IPC")) {
+               } else if (strequal(lp_fstype(snum), "IPC")) {
                        fstrcpy(dev, "IPC");
                } else {
                        fstrcpy(dev,"A:");
@@ -272,7 +203,7 @@ static NTSTATUS share_sanity_checks(const struct tsocket_address *remote_address
                if (!strequal(dev, "LPT1:")) {
                        return NT_STATUS_BAD_DEVICE_TYPE;
                }
-       } else if (strequal(lp_fstype(talloc_tos(), snum), "IPC")) {
+       } else if (strequal(lp_fstype(snum), "IPC")) {
                if (!strequal(dev, "IPC")) {
                        return NT_STATUS_BAD_DEVICE_TYPE;
                }
@@ -430,7 +361,7 @@ static NTSTATUS create_connection_session_info(struct smbd_server_connection *sc
 }
 
 /****************************************************************************
-  set relavent user and group settings corresponding to force user/group
+  Set relevant user and group settings corresponding to force user/group
   configuration for the given snum.
 ****************************************************************************/
 
@@ -511,16 +442,56 @@ NTSTATUS set_conn_force_user_group(connection_struct *conn, int snum)
        return NT_STATUS_OK;
 }
 
+static NTSTATUS notify_init_sconn(struct smbd_server_connection *sconn)
+{
+       NTSTATUS status;
+
+       if (sconn->notify_ctx != NULL) {
+               return NT_STATUS_OK;
+       }
+
+       sconn->notify_ctx = notify_init(sconn, sconn->msg_ctx, sconn->ev_ctx,
+                                       sconn, notify_callback);
+       if (sconn->notify_ctx == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       status = messaging_register(sconn->msg_ctx, sconn,
+                                   MSG_SMB_NOTIFY_CANCEL_DELETED,
+                                   smbd_notify_cancel_deleted);
+       if (!NT_STATUS_IS_OK(status)) {
+               DBG_DEBUG("messaging_register failed: %s\n",
+                         nt_errstr(status));
+               TALLOC_FREE(sconn->notify_ctx);
+               return status;
+       }
+
+       status = messaging_register(sconn->msg_ctx, sconn,
+                                   MSG_SMB_NOTIFY_STARTED,
+                                   smbd_notifyd_restarted);
+       if (!NT_STATUS_IS_OK(status)) {
+               DBG_DEBUG("messaging_register failed: %s\n",
+                         nt_errstr(status));
+               messaging_deregister(sconn->msg_ctx,
+                                    MSG_SMB_NOTIFY_CANCEL_DELETED, sconn);
+               TALLOC_FREE(sconn->notify_ctx);
+               return status;
+       }
+
+       return NT_STATUS_OK;
+}
+
 /****************************************************************************
   Make a connection, given the snum to connect to, and the vuser of the
   connecting user if appropriate.
 ****************************************************************************/
 
-static NTSTATUS make_connection_snum(struct smbd_server_connection *sconn,
+static NTSTATUS make_connection_snum(struct smbXsrv_connection *xconn,
                                        connection_struct *conn,
                                        int snum, struct user_struct *vuser,
                                        const char *pdev)
 {
+       struct smbd_server_connection *sconn = xconn->client->sconn;
        struct smb_filename *smb_fname_cpath = NULL;
        fstring dev;
        int ret;
@@ -574,6 +545,18 @@ static NTSTATUS make_connection_snum(struct smbd_server_connection *sconn,
        conn->short_case_preserve = lp_short_preserve_case(snum);
 
        conn->encrypt_level = lp_smb_encrypt(snum);
+       if (conn->encrypt_level > SMB_SIGNING_OFF) {
+               if (lp_smb_encrypt(-1) == SMB_SIGNING_OFF) {
+                       if (conn->encrypt_level == SMB_SIGNING_REQUIRED) {
+                               DBG_ERR("Service [%s] requires encryption, but "
+                                       "it is disabled globally!\n",
+                                       lp_servicename(talloc_tos(), snum));
+                               status = NT_STATUS_ACCESS_DENIED;
+                               goto err_root_exit;
+                       }
+                       conn->encrypt_level = SMB_SIGNING_OFF;
+               }
+       }
 
        conn->veto_list = NULL;
        conn->hide_list = NULL;
@@ -614,11 +597,19 @@ static NTSTATUS make_connection_snum(struct smbd_server_connection *sconn,
        }
 
        /*
-        * Set up the share security descriptor
+        * Set up the share security descriptor.
+        * NOTE - we use the *INCOMING USER* session_info
+        * here, as does (indirectly) change_to_user(),
+        * which can be called on any incoming packet.
+        * This way we set up the share access based
+        * on the authenticated user, not the forced
+        * user. See bug:
+        *
+        * https://bugzilla.samba.org/show_bug.cgi?id=9878
         */
 
        status = check_user_share_access(conn,
-                                       conn->session_info,
+                                       vuser->session_info,
                                        &conn->share_access,
                                        &conn->read_only);
        if (!NT_STATUS_IS_OK(status)) {
@@ -659,7 +650,9 @@ static NTSTATUS make_connection_snum(struct smbd_server_connection *sconn,
 
        if (SMB_VFS_CONNECT(conn, lp_servicename(talloc_tos(), snum),
                            conn->session_info->unix_info->unix_name) < 0) {
-               DEBUG(0,("make_connection: VFS make connection failed!\n"));
+               DBG_WARNING("SMB_VFS_CONNECT for service '%s' at '%s' failed: %s\n",
+                           lp_servicename(talloc_tos(), snum), conn->connectpath,
+                           strerror(errno));
                status = NT_STATUS_UNSUCCESSFUL;
                goto err_root_exit;
        }
@@ -668,14 +661,11 @@ static NTSTATUS make_connection_snum(struct smbd_server_connection *sconn,
        on_err_call_dis_hook = true;
 
        if ((!conn->printer) && (!conn->ipc) &&
-           lp_change_notify(conn->params)) {
-               if (sconn->notify_ctx == NULL) {
-                       sconn->notify_ctx = notify_init(
-                               sconn, sconn->msg_ctx, sconn->ev_ctx);
-               }
-               if (sconn->sys_notify_ctx == NULL) {
-                       sconn->sys_notify_ctx = sys_notify_context_create(
-                               sconn, sconn->ev_ctx);
+           lp_change_notify()) {
+
+               status = notify_init_sconn(sconn);
+               if (!NT_STATUS_IS_OK(status)) {
+                       goto err_root_exit;
                }
        }
 
@@ -698,7 +688,7 @@ static NTSTATUS make_connection_snum(struct smbd_server_connection *sconn,
        /* Preexecs are done here as they might make the dir we are to ChDir
         * to below */
        /* execute any "root preexec = " line */
-       if (*lp_rootpreexec(talloc_tos(), snum)) {
+       if (*lp_root_preexec(talloc_tos(), snum)) {
                char *cmd = talloc_sub_advanced(talloc_tos(),
                                        lp_servicename(talloc_tos(), SNUM(conn)),
                                        conn->session_info->unix_info->unix_name,
@@ -706,11 +696,11 @@ static NTSTATUS make_connection_snum(struct smbd_server_connection *sconn,
                                        conn->session_info->unix_token->gid,
                                        conn->session_info->unix_info->sanitized_username,
                                        conn->session_info->info->domain_name,
-                                       lp_rootpreexec(talloc_tos(), snum));
+                                       lp_root_preexec(talloc_tos(), snum));
                DEBUG(5,("cmd=%s\n",cmd));
-               ret = smbrun(cmd,NULL);
+               ret = smbrun(cmd, NULL, NULL);
                TALLOC_FREE(cmd);
-               if (ret != 0 && lp_rootpreexec_close(snum)) {
+               if (ret != 0 && lp_root_preexec_close(snum)) {
                        DEBUG(1,("root preexec gave %d - failing "
                                 "connection\n", ret));
                        status = NT_STATUS_ACCESS_DENIED;
@@ -745,7 +735,7 @@ static NTSTATUS make_connection_snum(struct smbd_server_connection *sconn,
                                        conn->session_info->unix_info->sanitized_username,
                                        conn->session_info->info->domain_name,
                                        lp_preexec(talloc_tos(), snum));
-               ret = smbrun(cmd,NULL);
+               ret = smbrun(cmd, NULL, NULL);
                TALLOC_FREE(cmd);
                if (ret != 0 && lp_preexec_close(snum)) {
                        DEBUG(1,("preexec gave %d - failing connection\n",
@@ -798,8 +788,11 @@ static NTSTATUS make_connection_snum(struct smbd_server_connection *sconn,
                set_namearray( &conn->aio_write_behind_list,
                                lp_aio_write_behind(talloc_tos(), snum));
        }
-       smb_fname_cpath = synthetic_smb_fname(talloc_tos(), conn->connectpath,
-                                             NULL, NULL);
+       smb_fname_cpath = synthetic_smb_fname(talloc_tos(),
+                                       conn->connectpath,
+                                       NULL,
+                                       NULL,
+                                       0);
        if (smb_fname_cpath == NULL) {
                status = NT_STATUS_NO_MEMORY;
                goto err_root_exit;
@@ -849,7 +842,7 @@ static NTSTATUS make_connection_snum(struct smbd_server_connection *sconn,
                dbgtext( "%s (%s) ", get_remote_machine_name(),
                         tsocket_address_string(conn->sconn->remote_address,
                                                talloc_tos()) );
-               dbgtext( "%s", srv_is_signing_active(sconn) ? "signed " : "");
+               dbgtext( "%s", srv_is_signing_active(xconn) ? "signed " : "");
                dbgtext( "connect to service %s ",
                         lp_servicename(talloc_tos(), snum) );
                dbgtext( "initially as user %s ",
@@ -878,7 +871,7 @@ static NTSTATUS make_connection_snum(struct smbd_server_connection *sconn,
  Make a connection to a service from SMB1. Internal interface.
 ****************************************************************************/
 
-static connection_struct *make_connection_smb1(struct smbd_server_connection *sconn,
+static connection_struct *make_connection_smb1(struct smb_request *req,
                                        NTTIME now,
                                        int snum, struct user_struct *vuser,
                                        const char *pdev,
@@ -888,7 +881,7 @@ static connection_struct *make_connection_smb1(struct smbd_server_connection *sc
        NTSTATUS status;
        struct connection_struct *conn;
 
-       status = smb1srv_tcon_create(sconn->conn, now, &tcon);
+       status = smb1srv_tcon_create(req->xconn, now, &tcon);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0,("make_connection_smb1: Couldn't find free tcon %s.\n",
                         nt_errstr(status)));
@@ -896,7 +889,7 @@ static connection_struct *make_connection_smb1(struct smbd_server_connection *sc
                return NULL;
        }
 
-       conn = conn_new(sconn);
+       conn = conn_new(req->sconn);
        if (!conn) {
                TALLOC_FREE(tcon);
 
@@ -908,7 +901,7 @@ static connection_struct *make_connection_smb1(struct smbd_server_connection *sc
        conn->cnum = tcon->global->tcon_wire_id;
        conn->tcon = tcon;
 
-       *pstatus = make_connection_snum(sconn,
+       *pstatus = make_connection_snum(req->xconn,
                                        conn,
                                        snum,
                                        vuser,
@@ -946,13 +939,14 @@ static connection_struct *make_connection_smb1(struct smbd_server_connection *sc
  We must set cnum before claiming connection.
 ****************************************************************************/
 
-connection_struct *make_connection_smb2(struct smbd_server_connection *sconn,
+connection_struct *make_connection_smb2(struct smbd_smb2_request *req,
                                        struct smbXsrv_tcon *tcon,
                                        int snum,
                                        struct user_struct *vuser,
                                        const char *pdev,
                                        NTSTATUS *pstatus)
 {
+       struct smbd_server_connection *sconn = req->sconn;
        connection_struct *conn = conn_new(sconn);
        if (!conn) {
                DEBUG(0,("make_connection_smb2: Couldn't find free connection.\n"));
@@ -963,7 +957,7 @@ connection_struct *make_connection_smb2(struct smbd_server_connection *sconn,
        conn->cnum = tcon->global->tcon_wire_id;
        conn->tcon = tcon;
 
-       *pstatus = make_connection_snum(sconn,
+       *pstatus = make_connection_snum(req->xconn,
                                        conn,
                                        snum,
                                        vuser,
@@ -981,12 +975,13 @@ connection_struct *make_connection_smb2(struct smbd_server_connection *sconn,
  * @param service 
 ****************************************************************************/
 
-connection_struct *make_connection(struct smbd_server_connection *sconn,
+connection_struct *make_connection(struct smb_request *req,
                                   NTTIME now,
                                   const char *service_in,
                                   const char *pdev, uint64_t vuid,
                                   NTSTATUS *status)
 {
+       struct smbd_server_connection *sconn = req->sconn;
        uid_t euid;
        struct user_struct *vuser = NULL;
        char *service = NULL;
@@ -1036,7 +1031,7 @@ connection_struct *make_connection(struct smbd_server_connection *sconn,
                }
                DEBUG(5, ("making a connection to [homes] service "
                          "created at session setup time\n"));
-               return make_connection_smb1(sconn, now,
+               return make_connection_smb1(req, now,
                                            vuser->homes_snum,
                                            vuser,
                                            dev, status);
@@ -1045,7 +1040,7 @@ connection_struct *make_connection(struct smbd_server_connection *sconn,
                               lp_servicename(talloc_tos(), vuser->homes_snum))) {
                DEBUG(5, ("making a connection to 'homes' service [%s] "
                          "created at session setup time\n", service_in));
-               return make_connection_smb1(sconn, now,
+               return make_connection_smb1(req, now,
                                            vuser->homes_snum,
                                            vuser,
                                            dev, status);
@@ -1097,7 +1092,7 @@ connection_struct *make_connection(struct smbd_server_connection *sconn,
 
        DEBUG(5, ("making a connection to 'normal' service %s\n", service));
 
-       return make_connection_smb1(sconn, now, snum, vuser,
+       return make_connection_smb1(req, now, snum, vuser,
                                    dev, status);
 }
 
@@ -1107,6 +1102,9 @@ connection_struct *make_connection(struct smbd_server_connection *sconn,
 
 void close_cnum(connection_struct *conn, uint64_t vuid)
 {
+       char rootpath[2] = { '/', '\0'};
+       struct smb_filename root_fname = { .base_name = rootpath };
+
        file_close_conn(conn);
 
        if (!IS_IPC(conn)) {
@@ -1115,17 +1113,17 @@ void close_cnum(connection_struct *conn, uint64_t vuid)
 
        change_to_root_user();
 
-       DEBUG(IS_IPC(conn)?3:1, ("%s (%s) closed connection to service %s\n",
+       DEBUG(IS_IPC(conn)?3:2, ("%s (%s) closed connection to service %s\n",
                                 get_remote_machine_name(),
                                 tsocket_address_string(conn->sconn->remote_address,
                                                        talloc_tos()),
                                 lp_servicename(talloc_tos(), SNUM(conn))));
 
-       /* Call VFS disconnect hook */    
-       SMB_VFS_DISCONNECT(conn);
-
        /* make sure we leave the directory available for unmount */
-       vfs_ChDir(conn, "/");
+       vfs_ChDir(conn, &root_fname);
+
+       /* Call VFS disconnect hook */
+       SMB_VFS_DISCONNECT(conn);
 
        /* execute any "postexec = " line */
        if (*lp_postexec(talloc_tos(), SNUM(conn)) &&
@@ -1138,7 +1136,7 @@ void close_cnum(connection_struct *conn, uint64_t vuid)
                                        conn->session_info->unix_info->sanitized_username,
                                        conn->session_info->info->domain_name,
                                        lp_postexec(talloc_tos(), SNUM(conn)));
-               smbrun(cmd,NULL);
+               smbrun(cmd, NULL, NULL);
                TALLOC_FREE(cmd);
                change_to_root_user();
        }
@@ -1154,7 +1152,7 @@ void close_cnum(connection_struct *conn, uint64_t vuid)
                                        conn->session_info->unix_info->sanitized_username,
                                        conn->session_info->info->domain_name,
                                        lp_root_postexec(talloc_tos(), SNUM(conn)));
-               smbrun(cmd,NULL);
+               smbrun(cmd, NULL, NULL);
                TALLOC_FREE(cmd);
        }