rpc: Always supply both the remote and local address to the auth subsystem
[amitay/samba.git] / source3 / smbd / lanman.c
index 13297c0222187c02b9353cf6708663bc449c075a..c3e540ff8106994aa0f6bfa23d732ecb61670723 100644 (file)
 #include "rpc_client/cli_spoolss.h"
 #include "rpc_client/init_spoolss.h"
 #include "../librpc/gen_ndr/ndr_srvsvc_c.h"
-#include "../librpc/gen_ndr/srv_samr.h"
-#include "../librpc/gen_ndr/srv_srvsvc.h"
 #include "../librpc/gen_ndr/rap.h"
 #include "../lib/util/binsearch.h"
 #include "../libcli/auth/libcli_auth.h"
 #include "rpc_client/init_lsa.h"
-#include "rpc_server/rpc_ncacn_np.h"
 #include "../libcli/security/security.h"
 #include "printing.h"
 #include "passdb/machine_sid.h"
 #include "auth.h"
+#include "rpc_server/rpc_ncacn_np.h"
 
 #ifdef CHECK_TYPES
 #undef CHECK_TYPES
@@ -81,7 +79,7 @@ static char *smb_realloc_limit(void *ptr, size_t size)
 }
 
 static bool api_Unsupported(struct smbd_server_connection *sconn,
-                           connection_struct *conn, uint16 vuid,
+                           connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt, int mprcnt,
@@ -89,7 +87,7 @@ static bool api_Unsupported(struct smbd_server_connection *sconn,
                                int *rdata_len, int *rparam_len);
 
 static bool api_TooSmall(struct smbd_server_connection *sconn,
-                        connection_struct *conn, uint16 vuid, char *param, char *data,
+                        connection_struct *conn, uint64_t vuid, char *param, char *data,
                         int mdrcnt, int mprcnt,
                         char **rdata, char **rparam,
                         int *rdata_len, int *rparam_len);
@@ -112,25 +110,25 @@ static int CopyExpanded(connection_struct *conn,
                *p_space_remaining = 0;
                return 0;
        }
-       buf = talloc_string_sub(ctx, buf,"%S",lp_servicename(snum));
+       buf = talloc_string_sub(ctx, buf,"%S", lp_servicename(ctx, snum));
        if (!buf) {
                *p_space_remaining = 0;
                return 0;
        }
        buf = talloc_sub_advanced(ctx,
-                               lp_servicename(SNUM(conn)),
-                               conn->session_info->unix_name,
+                                 lp_servicename(ctx, SNUM(conn)),
+                               conn->session_info->unix_info->unix_name,
                                conn->connectpath,
-                               conn->session_info->utok.gid,
-                               conn->session_info->sanitized_username,
-                               conn->session_info->info3->base.domain.string,
+                               conn->session_info->unix_token->gid,
+                               conn->session_info->unix_info->sanitized_username,
+                               conn->session_info->info->domain_name,
                                buf);
        if (!buf) {
                *p_space_remaining = 0;
                return 0;
        }
        l = push_ascii(*dst,buf,*p_space_remaining, STR_TERMINATE);
-       if (l == -1) {
+       if (l == 0) {
                return 0;
        }
        (*dst) += l;
@@ -145,7 +143,7 @@ static int CopyAndAdvance(char **dst, char *src, int *n)
                return 0;
        }
        l = push_ascii(*dst,src,*n, STR_TERMINATE);
-       if (l == -1) {
+       if (l == 0) {
                return 0;
        }
        (*dst) += l;
@@ -164,17 +162,17 @@ static int StrlenExpanded(connection_struct *conn, int snum, char *s)
        if (!buf) {
                return 0;
        }
-       buf = talloc_string_sub(ctx,buf,"%S",lp_servicename(snum));
+       buf = talloc_string_sub(ctx,buf,"%S",lp_servicename(ctx, snum));
        if (!buf) {
                return 0;
        }
        buf = talloc_sub_advanced(ctx,
-                               lp_servicename(SNUM(conn)),
-                               conn->session_info->unix_name,
+                                 lp_servicename(ctx, SNUM(conn)),
+                               conn->session_info->unix_info->unix_name,
                                conn->connectpath,
-                               conn->session_info->utok.gid,
-                               conn->session_info->sanitized_username,
-                               conn->session_info->info3->base.domain.string,
+                               conn->session_info->unix_token->gid,
+                               conn->session_info->unix_info->sanitized_username,
+                               conn->session_info->info->domain_name,
                                buf);
        if (!buf) {
                return 0;
@@ -309,7 +307,7 @@ static int package(struct pack_desc *p, ...)
        int needed=0, stringneeded;
        const char *str=NULL;
        int is_string=0, stringused;
-       int32 temp;
+       int32_t temp;
 
        va_start(args,p);
 
@@ -614,9 +612,9 @@ static void fill_printq_info_52(struct spoolss_DriverInfo3 *driver,
 {
        int                             i;
        fstring                         location;
-       trim_string((char *)driver->driver_path, "\\print$\\WIN40\\0\\", 0);
-       trim_string((char *)driver->data_file, "\\print$\\WIN40\\0\\", 0);
-       trim_string((char *)driver->help_file, "\\print$\\WIN40\\0\\", 0);
+       trim_string(discard_const_p(char, driver->driver_path), "\\print$\\WIN40\\0\\", 0);
+       trim_string(discard_const_p(char, driver->data_file), "\\print$\\WIN40\\0\\", 0);
+       trim_string(discard_const_p(char, driver->help_file), "\\print$\\WIN40\\0\\", 0);
 
        PACKI(desc, "W", 0x0400);                     /* don't know */
        PACKS(desc, "z", driver->driver_name);        /* long printer name */
@@ -643,7 +641,7 @@ static void fill_printq_info_52(struct spoolss_DriverInfo3 *driver,
 
        for ( i=0; i<count && driver->dependent_files && *driver->dependent_files[i]; i++)
        {
-               trim_string((char *)driver->dependent_files[i], "\\print$\\WIN40\\0\\", 0);
+               trim_string(discard_const_p(char, driver->dependent_files[i]), "\\print$\\WIN40\\0\\", 0);
                PACKS(desc,"z",driver->dependent_files[i]);         /* driver files to copy */
                DEBUG(3,("Dependent File: %s:\n", driver->dependent_files[i]));
        }
@@ -758,7 +756,7 @@ static int get_printerdrivernumber(const struct spoolss_DriverInfo3 *driver)
 }
 
 static bool api_DosPrintQGetInfo(struct smbd_server_connection *sconn,
-                                connection_struct *conn, uint16 vuid,
+                                connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -829,14 +827,15 @@ static bool api_DosPrintQGetInfo(struct smbd_server_connection *sconn,
        ZERO_STRUCT(handle);
 
        if (QueueName == NULL || (strlen(QueueName) < 1)) {
-               desc.errcode = W_ERROR_V(WERR_INVALID_PARAM);
+               desc.errcode = W_ERROR_V(WERR_INVALID_PARAMETER);
                goto out;
        }
 
        status = rpc_pipe_open_interface(conn,
-                                        &ndr_table_spoolss.syntax_id,
+                                        &ndr_table_spoolss,
                                         conn->session_info,
-                                        &conn->sconn->client_id,
+                                        conn->sconn->remote_address,
+                                        conn->sconn->local_address,
                                         conn->sconn->msg_ctx,
                                         &cli);
        if (!NT_STATUS_IS_OK(status)) {
@@ -973,7 +972,7 @@ static bool api_DosPrintQGetInfo(struct smbd_server_connection *sconn,
 ****************************************************************************/
 
 static bool api_DosPrintQEnum(struct smbd_server_connection *sconn,
-                             connection_struct *conn, uint16 vuid,
+                             connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt, int mprcnt,
@@ -1031,9 +1030,10 @@ static bool api_DosPrintQEnum(struct smbd_server_connection *sconn,
        }
 
        status = rpc_pipe_open_interface(conn,
-                                        &ndr_table_spoolss.syntax_id,
+                                        &ndr_table_spoolss,
                                         conn->session_info,
-                                        &conn->sconn->client_id,
+                                        conn->sconn->remote_address,
+                                        conn->sconn->local_address,
                                         conn->sconn->msg_ctx,
                                         &cli);
        if (!NT_STATUS_IS_OK(status)) {
@@ -1161,8 +1161,8 @@ static bool api_DosPrintQEnum(struct smbd_server_connection *sconn,
                }
        }
 
-       SAFE_FREE(subcntarr);
  out:
+       SAFE_FREE(subcntarr);
        *rdata_len = desc.usedlen;
        *rparam_len = 8;
        *rparam = smb_realloc_limit(*rparam,*rparam_len);
@@ -1208,7 +1208,7 @@ static bool check_session_info(int uLevel, char* id)
 
 struct srv_info_struct {
        fstring name;
-       uint32 type;
+       uint32_t type;
        fstring comment;
        fstring domain;
        bool server_added;
@@ -1219,7 +1219,7 @@ struct srv_info_struct {
  number of entries.
 ******************************************************************/
 
-static int get_session_info(uint32 servertype,
+static int get_session_info(uint32_t servertype,
                           struct srv_info_struct **servers,
                           const char *domain)
 {
@@ -1228,12 +1228,19 @@ static int get_session_info(uint32 servertype,
        char **lines;
        bool local_list_only;
        int i;
+       char *slist_cache_path = cache_path(SERVER_LIST);
+       if (slist_cache_path == NULL) {
+               return 0;
+       }
 
-       lines = file_lines_load(cache_path(SERVER_LIST), NULL, 0, NULL);
+       lines = file_lines_load(slist_cache_path, NULL, 0, NULL);
        if (!lines) {
-               DEBUG(4,("Can't open %s - %s\n",cache_path(SERVER_LIST),strerror(errno)));
+               DEBUG(4, ("Can't open %s - %s\n",
+                         slist_cache_path, strerror(errno)));
+               TALLOC_FREE(slist_cache_path);
                return 0;
        }
+       TALLOC_FREE(slist_cache_path);
 
        /* request for everything is code for request all servers */
        if (servertype == SV_TYPE_ALL) {
@@ -1429,7 +1436,7 @@ static int fill_srv_info(struct srv_info_struct *service,
 
 static int srv_comp(struct srv_info_struct *s1,struct srv_info_struct *s2)
 {
-       return StrCaseCmp(s1->name,s2->name);
+       return strcasecmp_m(s1->name,s2->name);
 }
 
 /****************************************************************************
@@ -1438,7 +1445,7 @@ static int srv_comp(struct srv_info_struct *s1,struct srv_info_struct *s2)
 ****************************************************************************/
 
 static bool api_RNetServerEnum2(struct smbd_server_connection *sconn,
-                               connection_struct *conn, uint16 vuid,
+                               connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt, int mprcnt, char **rdata,
@@ -1449,7 +1456,7 @@ static bool api_RNetServerEnum2(struct smbd_server_connection *sconn,
        char *p = skip_string(param,tpscnt,str2);
        int uLevel = get_safe_SVAL(param, tpscnt, p, 0, -1);
        int buf_len = get_safe_SVAL(param,tpscnt, p, 2, 0);
-       uint32 servertype = get_safe_IVAL(param,tpscnt,p,4, 0);
+       uint32_t servertype = get_safe_IVAL(param,tpscnt,p,4, 0);
        char *p2;
        int data_len, fixed_len, string_len;
        int f_len = 0, s_len = 0;
@@ -1598,7 +1605,7 @@ static int srv_name_match(const char *n1, const char *n2)
         *  the server will return a list of servers that exist on
         *  the network greater than or equal to the FirstNameToReturn.
         */
-       int ret = StrCaseCmp(n1, n2);
+       int ret = strcasecmp_m(n1, n2);
 
        if (ret <= 0) {
                return 0;
@@ -1608,7 +1615,7 @@ static int srv_name_match(const char *n1, const char *n2)
 }
 
 static bool api_RNetServerEnum3(struct smbd_server_connection *sconn,
-                               connection_struct *conn, uint16 vuid,
+                               connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt, int mprcnt, char **rdata,
@@ -1619,7 +1626,7 @@ static bool api_RNetServerEnum3(struct smbd_server_connection *sconn,
        char *p = skip_string(param,tpscnt,str2);
        int uLevel = get_safe_SVAL(param, tpscnt, p, 0, -1);
        int buf_len = get_safe_SVAL(param,tpscnt, p, 2, 0);
-       uint32 servertype = get_safe_IVAL(param,tpscnt,p,4, 0);
+       uint32_t servertype = get_safe_IVAL(param,tpscnt,p,4, 0);
        char *p2;
        int data_len, fixed_len, string_len;
        int f_len = 0, s_len = 0;
@@ -1710,7 +1717,7 @@ static bool api_RNetServerEnum3(struct smbd_server_connection *sconn,
                         */
                        for (;first > 0;) {
                                int ret;
-                               ret = StrCaseCmp(first_name,
+                               ret = strcasecmp_m(first_name,
                                                 servers[first-1].name);
                                if (ret > 0) {
                                        break;
@@ -1801,7 +1808,7 @@ static bool api_RNetServerEnum3(struct smbd_server_connection *sconn,
   ****************************************************************************/
 
 static bool api_RNetGroupGetUsers(struct smbd_server_connection *sconn,
-                                 connection_struct *conn, uint16 vuid,
+                                 connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt, int mprcnt, char **rdata,
@@ -1908,10 +1915,10 @@ static int fill_share_info(connection_struct *conn, int snum, int uLevel,
                len = 0;
 
                if (uLevel > 0) {
-                       len += StrlenExpanded(conn,snum,lp_comment(snum));
+                       len += StrlenExpanded(conn,snum,lp_comment(talloc_tos(), snum));
                }
                if (uLevel > 1) {
-                       len += strlen(lp_pathname(snum)) + 1;
+                       len += strlen(lp_path(talloc_tos(), snum)) + 1;
                }
                if (buflen) {
                        *buflen = struct_len;
@@ -1940,14 +1947,14 @@ static int fill_share_info(connection_struct *conn, int snum, int uLevel,
                baseaddr = p;
        }
 
-       push_ascii(p,lp_servicename(snum),13, STR_TERMINATE);
+       push_ascii(p,lp_servicename(talloc_tos(), snum),13, STR_TERMINATE);
 
        if (uLevel > 0) {
                int type;
 
                SCVAL(p,13,0);
                type = STYPE_DISKTREE;
-               if (lp_print_ok(snum)) {
+               if (lp_printable(snum)) {
                        type = STYPE_PRINTQ;
                }
                if (strequal("IPC",lp_fstype(snum))) {
@@ -1955,7 +1962,7 @@ static int fill_share_info(connection_struct *conn, int snum, int uLevel,
                }
                SSVAL(p,14,type);               /* device type */
                SIVAL(p,16,PTR_DIFF(p2,baseaddr));
-               len += CopyExpanded(conn,snum,&p2,lp_comment(snum),&l2);
+               len += CopyExpanded(conn,snum,&p2,lp_comment(talloc_tos(),snum),&l2);
        }
 
        if (uLevel > 1) {
@@ -1963,7 +1970,7 @@ static int fill_share_info(connection_struct *conn, int snum, int uLevel,
                SSVALS(p,22,-1);                /* max uses */
                SSVAL(p,24,1); /* current uses */
                SIVAL(p,26,PTR_DIFF(p2,baseaddr)); /* local pathname */
-               len += CopyAndAdvance(&p2,lp_pathname(snum),&l2);
+               len += CopyAndAdvance(&p2,lp_path(talloc_tos(),snum),&l2);
                memset(p+30,0,SHPWLEN+2); /* passwd (reserved), pad field */
        }
 
@@ -1992,7 +1999,7 @@ static int fill_share_info(connection_struct *conn, int snum, int uLevel,
 }
 
 static bool api_RNetShareGetInfo(struct smbd_server_connection *sconn,
-                                connection_struct *conn,uint16 vuid,
+                                connection_struct *conn,uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -2057,7 +2064,7 @@ static bool api_RNetShareGetInfo(struct smbd_server_connection *sconn,
  ****************************************************************************/
 
 static bool api_RNetShareEnum(struct smbd_server_connection *sconn,
-                             connection_struct *conn, uint16 vuid,
+                             connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int                mdrcnt,
@@ -2093,8 +2100,9 @@ static bool api_RNetShareEnum(struct smbd_server_connection *sconn,
 
        /* Ensure all the usershares are loaded. */
        become_root();
+       delete_and_reload_printers(sconn->ev_ctx, sconn->msg_ctx);
        load_registry_shares();
-       count = load_usershare_shares();
+       count = load_usershare_shares(NULL, connections_snum_used);
        unbecome_root();
 
        data_len = fixed_len = string_len = 0;
@@ -2103,7 +2111,7 @@ static bool api_RNetShareEnum(struct smbd_server_connection *sconn,
                if (!(lp_browseable(i) && lp_snum_ok(i))) {
                        continue;
                }
-               push_ascii_fstring(servicename_dos, lp_servicename(i));
+               push_ascii_fstring(servicename_dos, lp_servicename(talloc_tos(), i));
                /* Maximum name length = 13. */
                if( lp_browseable( i ) && lp_snum_ok( i ) && (strlen(servicename_dos) < 13)) {
                        total++;
@@ -2135,7 +2143,8 @@ static bool api_RNetShareEnum(struct smbd_server_connection *sconn,
                        continue;
                }
 
-               push_ascii_fstring(servicename_dos, lp_servicename(i));
+               push_ascii_fstring(servicename_dos,
+                                  lp_servicename(talloc_tos(), i));
                if (lp_browseable(i) && lp_snum_ok(i) && (strlen(servicename_dos) < 13)) {
                        if (fill_share_info( conn,i,uLevel,&p,&f_len,&p2,&s_len,*rdata ) < 0) {
                                break;
@@ -2165,7 +2174,7 @@ static bool api_RNetShareEnum(struct smbd_server_connection *sconn,
   ****************************************************************************/
 
 static bool api_RNetShareAdd(struct smbd_server_connection *sconn,
-                            connection_struct *conn,uint16 vuid,
+                            connection_struct *conn,uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -2256,9 +2265,10 @@ static bool api_RNetShareAdd(struct smbd_server_connection *sconn,
                return false;
        }
 
-       status = rpc_pipe_open_internal(mem_ctx, &ndr_table_srvsvc.syntax_id,
+       status = rpc_pipe_open_interface(mem_ctx, &ndr_table_srvsvc,
                                        conn->session_info,
-                                       &conn->sconn->client_id,
+                                       conn->sconn->remote_address,
+                                       conn->sconn->local_address,
                                        conn->sconn->msg_ctx,
                                        &cli);
        if (!NT_STATUS_IS_OK(status)) {
@@ -2326,7 +2336,7 @@ static bool api_RNetShareAdd(struct smbd_server_connection *sconn,
   ****************************************************************************/
 
 static bool api_RNetGroupEnum(struct smbd_server_connection *sconn,
-                             connection_struct *conn,uint16 vuid,
+                             connection_struct *conn,uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -2342,7 +2352,7 @@ static bool api_RNetGroupEnum(struct smbd_server_connection *sconn,
 
        uint32_t num_groups;
        uint32_t resume_handle;
-       struct rpc_pipe_client *samr_pipe;
+       struct rpc_pipe_client *samr_pipe = NULL;
        struct policy_handle samr_handle, domain_handle;
        NTSTATUS status, result;
        struct dcerpc_binding_handle *b;
@@ -2367,10 +2377,10 @@ static bool api_RNetGroupEnum(struct smbd_server_connection *sconn,
                return False;
        }
 
-       status = rpc_pipe_open_internal(
-               talloc_tos(), &ndr_table_samr.syntax_id,
-               conn->session_info, &conn->sconn->client_id,
-               conn->sconn->msg_ctx, &samr_pipe);
+       status = rpc_pipe_open_interface(
+               talloc_tos(), &ndr_table_samr,
+               conn->session_info, conn->sconn->remote_address,
+               conn->sconn->local_address, conn->sconn->msg_ctx, &samr_pipe);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0, ("api_RNetUserEnum: Could not connect to samr: %s\n",
                          nt_errstr(status)));
@@ -2379,7 +2389,7 @@ static bool api_RNetGroupEnum(struct smbd_server_connection *sconn,
 
        b = samr_pipe->binding_handle;
 
-       status = dcerpc_samr_Connect2(b, talloc_tos(), global_myname(),
+       status = dcerpc_samr_Connect2(b, talloc_tos(), lp_netbios_name(),
                                      SAMR_ACCESS_LOOKUP_DOMAIN, &samr_handle,
                                      &result);
        if (!NT_STATUS_IS_OK(status)) {
@@ -2508,7 +2518,7 @@ static bool api_RNetGroupEnum(struct smbd_server_connection *sconn,
 ******************************************************************/
 
 static bool api_NetUserGetGroups(struct smbd_server_connection *sconn,
-                                connection_struct *conn,uint16 vuid,
+                                connection_struct *conn,uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -2526,7 +2536,7 @@ static bool api_NetUserGetGroups(struct smbd_server_connection *sconn,
        uint32_t i;
        char *endp = NULL;
 
-       struct rpc_pipe_client *samr_pipe;
+       struct rpc_pipe_client *samr_pipe = NULL;
        struct policy_handle samr_handle, domain_handle, user_handle;
        struct lsa_String name;
        struct lsa_Strings names;
@@ -2573,10 +2583,10 @@ static bool api_NetUserGetGroups(struct smbd_server_connection *sconn,
        p = *rdata;
        endp = *rdata + *rdata_len;
 
-       status = rpc_pipe_open_internal(
-               talloc_tos(), &ndr_table_samr.syntax_id,
-               conn->session_info, &conn->sconn->client_id,
-               conn->sconn->msg_ctx, &samr_pipe);
+       status = rpc_pipe_open_interface(
+               talloc_tos(), &ndr_table_samr,
+               conn->session_info, conn->sconn->remote_address,
+               conn->sconn->local_address, conn->sconn->msg_ctx, &samr_pipe);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0, ("api_RNetUserEnum: Could not connect to samr: %s\n",
                          nt_errstr(status)));
@@ -2585,7 +2595,7 @@ static bool api_NetUserGetGroups(struct smbd_server_connection *sconn,
 
        b = samr_pipe->binding_handle;
 
-       status = dcerpc_samr_Connect2(b, talloc_tos(), global_myname(),
+       status = dcerpc_samr_Connect2(b, talloc_tos(), lp_netbios_name(),
                                      SAMR_ACCESS_LOOKUP_DOMAIN, &samr_handle,
                                      &result);
        if (!NT_STATUS_IS_OK(status)) {
@@ -2630,6 +2640,14 @@ static bool api_NetUserGetGroups(struct smbd_server_connection *sconn,
                          nt_errstr(result)));
                goto close_domain;
        }
+       if (rid.count != 1) {
+               status = NT_STATUS_INVALID_NETWORK_RESPONSE;
+               goto close_domain;
+       }
+       if (type.count != 1) {
+               status = NT_STATUS_INVALID_NETWORK_RESPONSE;
+               goto close_domain;
+       }
 
        if (type.ids[0] != SID_NAME_USER) {
                DEBUG(10, ("%s is a %s, not a user\n", UserName,
@@ -2703,7 +2721,7 @@ static bool api_NetUserGetGroups(struct smbd_server_connection *sconn,
 ******************************************************************/
 
 static bool api_RNetUserEnum(struct smbd_server_connection *sconn,
-                            connection_struct *conn, uint16 vuid,
+                            connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -2716,7 +2734,7 @@ static bool api_RNetUserEnum(struct smbd_server_connection *sconn,
        int i, resume_context, cli_buf_size;
        uint32_t resume_handle;
 
-       struct rpc_pipe_client *samr_pipe;
+       struct rpc_pipe_client *samr_pipe = NULL;
        struct policy_handle samr_handle, domain_handle;
        NTSTATUS status, result;
 
@@ -2765,10 +2783,10 @@ static bool api_RNetUserEnum(struct smbd_server_connection *sconn,
        p = *rdata;
        endp = *rdata + *rdata_len;
 
-       status = rpc_pipe_open_internal(
-               talloc_tos(), &ndr_table_samr.syntax_id,
-               conn->session_info, &conn->sconn->client_id,
-               conn->sconn->msg_ctx, &samr_pipe);
+       status = rpc_pipe_open_interface(
+               talloc_tos(), &ndr_table_samr,
+               conn->session_info, conn->sconn->remote_address,
+               conn->sconn->local_address, conn->sconn->msg_ctx, &samr_pipe);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0, ("api_RNetUserEnum: Could not connect to samr: %s\n",
                          nt_errstr(status)));
@@ -2777,7 +2795,7 @@ static bool api_RNetUserEnum(struct smbd_server_connection *sconn,
 
        b = samr_pipe->binding_handle;
 
-       status = dcerpc_samr_Connect2(b, talloc_tos(), global_myname(),
+       status = dcerpc_samr_Connect2(b, talloc_tos(), lp_netbios_name(),
                                      SAMR_ACCESS_LOOKUP_DOMAIN, &samr_handle,
                                      &result);
        if (!NT_STATUS_IS_OK(status)) {
@@ -2886,7 +2904,7 @@ static bool api_RNetUserEnum(struct smbd_server_connection *sconn,
 ****************************************************************************/
 
 static bool api_NetRemoteTOD(struct smbd_server_connection *sconn,
-                            connection_struct *conn,uint16 vuid,
+                            connection_struct *conn,uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -2940,265 +2958,12 @@ static bool api_NetRemoteTOD(struct smbd_server_connection *sconn,
        return True;
 }
 
-/****************************************************************************
- Set the user password.
-*****************************************************************************/
-
-static bool api_SetUserPassword(struct smbd_server_connection *sconn,
-                               connection_struct *conn,uint16 vuid,
-                               char *param, int tpscnt,
-                               char *data, int tdscnt,
-                               int mdrcnt,int mprcnt,
-                               char **rdata,char **rparam,
-                               int *rdata_len,int *rparam_len)
-{
-       char *np = get_safe_str_ptr(param,tpscnt,param,2);
-       char *p = NULL;
-       fstring user;
-       fstring pass1,pass2;
-       TALLOC_CTX *mem_ctx = talloc_tos();
-       NTSTATUS status, result;
-       struct rpc_pipe_client *cli = NULL;
-       struct policy_handle connect_handle, domain_handle, user_handle;
-       struct lsa_String domain_name;
-       struct dom_sid2 *domain_sid;
-       struct lsa_String names;
-       struct samr_Ids rids;
-       struct samr_Ids types;
-       struct samr_Password old_lm_hash;
-       struct samr_Password new_lm_hash;
-       int errcode = NERR_badpass;
-       uint32_t rid;
-       int encrypted;
-       int min_pwd_length;
-       struct dcerpc_binding_handle *b = NULL;
-
-       /* Skip 2 strings. */
-       p = skip_string(param,tpscnt,np);
-       p = skip_string(param,tpscnt,p);
-
-       if (!np || !p) {
-               return False;
-       }
-
-       /* Do we have a string ? */
-       if (skip_string(param,tpscnt,p) == NULL) {
-               return False;
-       }
-       pull_ascii_fstring(user,p);
-
-       p = skip_string(param,tpscnt,p);
-       if (!p) {
-               return False;
-       }
-
-       memset(pass1,'\0',sizeof(pass1));
-       memset(pass2,'\0',sizeof(pass2));
-       /*
-        * We use 31 here not 32 as we're checking
-        * the last byte we want to access is safe.
-        */
-       if (!is_offset_safe(param,tpscnt,p,31)) {
-               return False;
-       }
-       memcpy(pass1,p,16);
-       memcpy(pass2,p+16,16);
-
-       encrypted = get_safe_SVAL(param,tpscnt,p+32,0,-1);
-       if (encrypted == -1) {
-               errcode = W_ERROR_V(WERR_INVALID_PARAM);
-               goto out;
-       }
-
-       min_pwd_length = get_safe_SVAL(param,tpscnt,p+34,0,-1);
-       if (min_pwd_length == -1) {
-               errcode = W_ERROR_V(WERR_INVALID_PARAM);
-               goto out;
-       }
-
-       *rparam_len = 4;
-       *rparam = smb_realloc_limit(*rparam,*rparam_len);
-       if (!*rparam) {
-               return False;
-       }
-
-       *rdata_len = 0;
-
-       DEBUG(3,("Set password for <%s> (encrypted: %d, min_pwd_length: %d)\n",
-               user, encrypted, min_pwd_length));
-
-       ZERO_STRUCT(connect_handle);
-       ZERO_STRUCT(domain_handle);
-       ZERO_STRUCT(user_handle);
-
-       status = rpc_pipe_open_internal(mem_ctx, &ndr_table_samr.syntax_id,
-                                       conn->session_info,
-                                       &conn->sconn->client_id,
-                                       conn->sconn->msg_ctx,
-                                       &cli);
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0,("api_SetUserPassword: could not connect to samr: %s\n",
-                         nt_errstr(status)));
-               errcode = W_ERROR_V(ntstatus_to_werror(status));
-               goto out;
-       }
-
-       b = cli->binding_handle;
-
-       status = dcerpc_samr_Connect2(b, mem_ctx,
-                                     global_myname(),
-                                     SAMR_ACCESS_CONNECT_TO_SERVER |
-                                     SAMR_ACCESS_ENUM_DOMAINS |
-                                     SAMR_ACCESS_LOOKUP_DOMAIN,
-                                     &connect_handle,
-                                     &result);
-       if (!NT_STATUS_IS_OK(status)) {
-               errcode = W_ERROR_V(ntstatus_to_werror(status));
-               goto out;
-       }
-       if (!NT_STATUS_IS_OK(result)) {
-               errcode = W_ERROR_V(ntstatus_to_werror(result));
-               goto out;
-       }
-
-       init_lsa_String(&domain_name, get_global_sam_name());
-
-       status = dcerpc_samr_LookupDomain(b, mem_ctx,
-                                         &connect_handle,
-                                         &domain_name,
-                                         &domain_sid,
-                                         &result);
-       if (!NT_STATUS_IS_OK(status)) {
-               errcode = W_ERROR_V(ntstatus_to_werror(status));
-               goto out;
-       }
-       if (!NT_STATUS_IS_OK(result)) {
-               errcode = W_ERROR_V(ntstatus_to_werror(result));
-               goto out;
-       }
-
-       status = dcerpc_samr_OpenDomain(b, mem_ctx,
-                                       &connect_handle,
-                                       SAMR_DOMAIN_ACCESS_OPEN_ACCOUNT,
-                                       domain_sid,
-                                       &domain_handle,
-                                       &result);
-       if (!NT_STATUS_IS_OK(status)) {
-               errcode = W_ERROR_V(ntstatus_to_werror(status));
-               goto out;
-       }
-       if (!NT_STATUS_IS_OK(result)) {
-               errcode = W_ERROR_V(ntstatus_to_werror(result));
-               goto out;
-       }
-
-       init_lsa_String(&names, user);
-
-       status = dcerpc_samr_LookupNames(b, mem_ctx,
-                                        &domain_handle,
-                                        1,
-                                        &names,
-                                        &rids,
-                                        &types,
-                                        &result);
-       if (!NT_STATUS_IS_OK(status)) {
-               errcode = W_ERROR_V(ntstatus_to_werror(status));
-               goto out;
-       }
-       if (!NT_STATUS_IS_OK(result)) {
-               errcode = W_ERROR_V(ntstatus_to_werror(result));
-               goto out;
-       }
-
-       if (rids.count != 1) {
-               errcode = W_ERROR_V(WERR_NO_SUCH_USER);
-               goto out;
-       }
-       if (rids.count != types.count) {
-               errcode = W_ERROR_V(WERR_INVALID_PARAM);
-               goto out;
-       }
-       if (types.ids[0] != SID_NAME_USER) {
-               errcode = W_ERROR_V(WERR_INVALID_PARAM);
-               goto out;
-       }
-
-       rid = rids.ids[0];
-
-       status = dcerpc_samr_OpenUser(b, mem_ctx,
-                                     &domain_handle,
-                                     SAMR_USER_ACCESS_CHANGE_PASSWORD,
-                                     rid,
-                                     &user_handle,
-                                     &result);
-       if (!NT_STATUS_IS_OK(status)) {
-               errcode = W_ERROR_V(ntstatus_to_werror(status));
-               goto out;
-       }
-       if (!NT_STATUS_IS_OK(result)) {
-               errcode = W_ERROR_V(ntstatus_to_werror(result));
-               goto out;
-       }
-
-       if (encrypted == 0) {
-               E_deshash(pass1, old_lm_hash.hash);
-               E_deshash(pass2, new_lm_hash.hash);
-       } else {
-               ZERO_STRUCT(old_lm_hash);
-               ZERO_STRUCT(new_lm_hash);
-               memcpy(old_lm_hash.hash, pass1, MIN(strlen(pass1), 16));
-               memcpy(new_lm_hash.hash, pass1, MIN(strlen(pass2), 16));
-       }
-
-       status = dcerpc_samr_ChangePasswordUser(b, mem_ctx,
-                                               &user_handle,
-                                               true, /* lm_present */
-                                               &old_lm_hash,
-                                               &new_lm_hash,
-                                               false, /* nt_present */
-                                               NULL, /* old_nt_crypted */
-                                               NULL, /* new_nt_crypted */
-                                               false, /* cross1_present */
-                                               NULL, /* nt_cross */
-                                               false, /* cross2_present */
-                                               NULL, /* lm_cross */
-                                               &result);
-       if (!NT_STATUS_IS_OK(status)) {
-               errcode = W_ERROR_V(ntstatus_to_werror(status));
-               goto out;
-       }
-       if (!NT_STATUS_IS_OK(result)) {
-               errcode = W_ERROR_V(ntstatus_to_werror(result));
-               goto out;
-       }
-
-       errcode = NERR_Success;
- out:
-
-       if (b && is_valid_policy_hnd(&user_handle)) {
-               dcerpc_samr_Close(b, mem_ctx, &user_handle, &result);
-       }
-       if (b && is_valid_policy_hnd(&domain_handle)) {
-               dcerpc_samr_Close(b, mem_ctx, &domain_handle, &result);
-       }
-       if (b && is_valid_policy_hnd(&connect_handle)) {
-               dcerpc_samr_Close(b, mem_ctx, &connect_handle, &result);
-       }
-
-       memset((char *)pass1,'\0',sizeof(fstring));
-       memset((char *)pass2,'\0',sizeof(fstring));
-
-       SSVAL(*rparam,0,errcode);
-       SSVAL(*rparam,2,0);             /* converter word */
-       return(True);
-}
-
 /****************************************************************************
   Set the user password (SamOEM version - gets plaintext).
 ****************************************************************************/
 
 static bool api_SamOEMChangePassword(struct smbd_server_connection *sconn,
-                                    connection_struct *conn,uint16 vuid,
+                                    connection_struct *conn,uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -3269,22 +3034,23 @@ static bool api_SamOEMChangePassword(struct smbd_server_connection *sconn,
        DEBUG(3,("api_SamOEMChangePassword: Change password for <%s>\n",user));
 
        if (tdscnt != 532) {
-               errcode = W_ERROR_V(WERR_INVALID_PARAM);
+               errcode = W_ERROR_V(WERR_INVALID_PARAMETER);
                goto out;
        }
 
        bufsize = get_safe_SVAL(param,tpscnt,p,0,-1);
        if (bufsize != 532) {
-               errcode = W_ERROR_V(WERR_INVALID_PARAM);
+               errcode = W_ERROR_V(WERR_INVALID_PARAMETER);
                goto out;
        }
 
        memcpy(password.data, data, 516);
        memcpy(hash.hash, data+516, 16);
 
-       status = rpc_pipe_open_internal(mem_ctx, &ndr_table_samr.syntax_id,
+       status = rpc_pipe_open_interface(mem_ctx, &ndr_table_samr,
                                        conn->session_info,
-                                       &conn->sconn->client_id,
+                                       conn->sconn->remote_address,
+                                       conn->sconn->local_address,
                                        conn->sconn->msg_ctx,
                                        &cli);
        if (!NT_STATUS_IS_OK(status)) {
@@ -3296,7 +3062,7 @@ static bool api_SamOEMChangePassword(struct smbd_server_connection *sconn,
 
        b = cli->binding_handle;
 
-       init_lsa_AsciiString(&server, global_myname());
+       init_lsa_AsciiString(&server, lp_netbios_name());
        init_lsa_AsciiString(&account, user);
 
        status = dcerpc_samr_OemChangePasswordUser2(b, mem_ctx,
@@ -3328,7 +3094,7 @@ static bool api_SamOEMChangePassword(struct smbd_server_connection *sconn,
   ****************************************************************************/
 
 static bool api_RDosPrintJobDel(struct smbd_server_connection *sconn,
-                               connection_struct *conn,uint16 vuid,
+                               connection_struct *conn,uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -3339,7 +3105,7 @@ static bool api_RDosPrintJobDel(struct smbd_server_connection *sconn,
        char *str1 = get_safe_str_ptr(param,tpscnt,param,2);
        char *str2 = skip_string(param,tpscnt,str1);
        char *p = skip_string(param,tpscnt,str2);
-       uint32 jobid;
+       uint32_t jobid;
        fstring sharename;
        int errcode;
        WERROR werr = WERR_OK;
@@ -3379,9 +3145,10 @@ static bool api_RDosPrintJobDel(struct smbd_server_connection *sconn,
        ZERO_STRUCT(handle);
 
        status = rpc_pipe_open_interface(conn,
-                                        &ndr_table_spoolss.syntax_id,
+                                        &ndr_table_spoolss,
                                         conn->session_info,
-                                        &conn->sconn->client_id,
+                                        conn->sconn->remote_address,
+                                        conn->sconn->local_address,
                                         conn->sconn->msg_ctx,
                                         &cli);
        if (!NT_STATUS_IS_OK(status)) {
@@ -3461,7 +3228,7 @@ static bool api_RDosPrintJobDel(struct smbd_server_connection *sconn,
   ****************************************************************************/
 
 static bool api_WPrintQueueCtrl(struct smbd_server_connection *sconn,
-                               connection_struct *conn,uint16 vuid,
+                               connection_struct *conn,uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -3507,9 +3274,10 @@ static bool api_WPrintQueueCtrl(struct smbd_server_connection *sconn,
        ZERO_STRUCT(handle);
 
        status = rpc_pipe_open_interface(conn,
-                                        &ndr_table_spoolss.syntax_id,
+                                        &ndr_table_spoolss,
                                         conn->session_info,
-                                        &conn->sconn->client_id,
+                                        conn->sconn->remote_address,
+                                        conn->sconn->local_address,
                                         conn->sconn->msg_ctx,
                                         &cli);
        if (!NT_STATUS_IS_OK(status)) {
@@ -3526,7 +3294,7 @@ static bool api_WPrintQueueCtrl(struct smbd_server_connection *sconn,
                                            QueueName,
                                            NULL,
                                            devmode_ctr,
-                                           SEC_FLAG_MAXIMUM_ALLOWED,
+                                           PRINTER_ACCESS_ADMINISTER,
                                            &handle,
                                            &werr);
        if (!NT_STATUS_IS_OK(status)) {
@@ -3623,7 +3391,7 @@ static int check_printjob_info(struct pack_desc* desc,
 }
 
 static bool api_PrintJobInfo(struct smbd_server_connection *sconn,
-                            connection_struct *conn, uint16 vuid,
+                            connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -3634,7 +3402,7 @@ static bool api_PrintJobInfo(struct smbd_server_connection *sconn,
        char *str1 = get_safe_str_ptr(param,tpscnt,param,2);
        char *str2 = skip_string(param,tpscnt,str1);
        char *p = skip_string(param,tpscnt,str2);
-       uint32 jobid;
+       uint32_t jobid;
        fstring sharename;
        int uLevel = get_safe_SVAL(param,tpscnt,p,2,-1);
        int function = get_safe_SVAL(param,tpscnt,p,4,-1);
@@ -3689,9 +3457,10 @@ static bool api_PrintJobInfo(struct smbd_server_connection *sconn,
        ZERO_STRUCT(handle);
 
        status = rpc_pipe_open_interface(conn,
-                                        &ndr_table_spoolss.syntax_id,
+                                        &ndr_table_spoolss,
                                         conn->session_info,
-                                        &conn->sconn->client_id,
+                                        conn->sconn->remote_address,
+                                        conn->sconn->local_address,
                                         conn->sconn->msg_ctx,
                                         &cli);
        if (!NT_STATUS_IS_OK(status)) {
@@ -3783,7 +3552,7 @@ static bool api_PrintJobInfo(struct smbd_server_connection *sconn,
 ****************************************************************************/
 
 static bool api_RNetServerGetInfo(struct smbd_server_connection *sconn,
-                                 connection_struct *conn,uint16 vuid,
+                                 connection_struct *conn,uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -3866,9 +3635,10 @@ static bool api_RNetServerGetInfo(struct smbd_server_connection *sconn,
        p = *rdata;
        p2 = p + struct_len;
 
-       status = rpc_pipe_open_internal(mem_ctx, &ndr_table_srvsvc.syntax_id,
+       status = rpc_pipe_open_interface(mem_ctx, &ndr_table_srvsvc,
                                        conn->session_info,
-                                       &conn->sconn->client_id,
+                                       conn->sconn->remote_address,
+                                       conn->sconn->local_address,
                                        conn->sconn->msg_ctx,
                                        &cli);
        if (!NT_STATUS_IS_OK(status)) {
@@ -3895,13 +3665,18 @@ static bool api_RNetServerGetInfo(struct smbd_server_connection *sconn,
        }
 
        if (info.info101 == NULL) {
-               errcode = W_ERROR_V(WERR_INVALID_PARAM);
+               errcode = W_ERROR_V(WERR_INVALID_PARAMETER);
                goto out;
        }
 
        if (uLevel != 20) {
-               srvstr_push(NULL, 0, p, info.info101->server_name, 16,
-                       STR_ASCII|STR_UPPER|STR_TERMINATE);
+               size_t len = 0;
+               status = srvstr_push(NULL, 0, p, info.info101->server_name, 16,
+                       STR_ASCII|STR_UPPER|STR_TERMINATE, &len);
+               if (!NT_STATUS_IS_OK(status)) {
+                       errcode = W_ERROR_V(ntstatus_to_werror(status));
+                       goto out;
+               }
        }
        p += 16;
        if (uLevel > 0) {
@@ -3955,7 +3730,7 @@ static bool api_RNetServerGetInfo(struct smbd_server_connection *sconn,
 ****************************************************************************/
 
 static bool api_NetWkstaGetInfo(struct smbd_server_connection *sconn,
-                               connection_struct *conn,uint16 vuid,
+                               connection_struct *conn,uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -4005,7 +3780,9 @@ static bool api_NetWkstaGetInfo(struct smbd_server_connection *sconn,
 
        SIVAL(p,0,PTR_DIFF(p2,*rdata)); /* host name */
        strlcpy(p2,get_local_machine_name(),PTR_DIFF(endp,p2));
-       strupper_m(p2);
+       if (!strupper_m(p2)) {
+               return false;
+       }
        p2 = skip_string(*rdata,*rdata_len,p2);
        if (!p2) {
                return False;
@@ -4013,7 +3790,7 @@ static bool api_NetWkstaGetInfo(struct smbd_server_connection *sconn,
        p += 4;
 
        SIVAL(p,0,PTR_DIFF(p2,*rdata));
-       strlcpy(p2,conn->session_info->sanitized_username,PTR_DIFF(endp,p2));
+       strlcpy(p2,conn->session_info->unix_info->sanitized_username,PTR_DIFF(endp,p2));
        p2 = skip_string(*rdata,*rdata_len,p2);
        if (!p2) {
                return False;
@@ -4022,15 +3799,17 @@ static bool api_NetWkstaGetInfo(struct smbd_server_connection *sconn,
 
        SIVAL(p,0,PTR_DIFF(p2,*rdata)); /* login domain */
        strlcpy(p2,lp_workgroup(),PTR_DIFF(endp,p2));
-       strupper_m(p2);
+       if (!strupper_m(p2)) {
+               return false;
+       }
        p2 = skip_string(*rdata,*rdata_len,p2);
        if (!p2) {
                return False;
        }
        p += 4;
 
-       SCVAL(p,0,lp_major_announce_version()); /* system version - e.g 4 in 4.1 */
-       SCVAL(p,1,lp_minor_announce_version()); /* system version - e.g .1 in 4.1 */
+       SCVAL(p,0,SAMBA_MAJOR_NBT_ANNOUNCE_VERSION); /* system version - e.g 4 in 4.1 */
+       SCVAL(p,1,SAMBA_MINOR_NBT_ANNOUNCE_VERSION); /* system version - e.g .1 in 4.1 */
        p += 2;
 
        SIVAL(p,0,PTR_DIFF(p2,*rdata));
@@ -4217,7 +3996,7 @@ There is no auxiliary data in the response.
 #define usri11_end            86
 
 static bool api_RNetUserGetInfo(struct smbd_server_connection *sconn,
-                               connection_struct *conn, uint16 vuid,
+                               connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -4242,7 +4021,7 @@ static bool api_RNetUserGetInfo(struct smbd_server_connection *sconn,
        struct lsa_String names;
        struct samr_Ids rids;
        struct samr_Ids types;
-       int errcode = W_ERROR_V(WERR_USER_NOT_FOUND);
+       int errcode = W_ERROR_V(WERR_NERR_USERNOTFOUND);
        uint32_t rid;
        union samr_UserInfo *info;
        struct dcerpc_binding_handle *b = NULL;
@@ -4293,9 +4072,10 @@ static bool api_RNetUserGetInfo(struct smbd_server_connection *sconn,
        ZERO_STRUCT(domain_handle);
        ZERO_STRUCT(user_handle);
 
-       status = rpc_pipe_open_internal(mem_ctx, &ndr_table_samr.syntax_id,
+       status = rpc_pipe_open_interface(mem_ctx, &ndr_table_samr,
                                        conn->session_info,
-                                       &conn->sconn->client_id,
+                                       conn->sconn->remote_address,
+                                       conn->sconn->local_address,
                                        conn->sconn->msg_ctx,
                                        &cli);
        if (!NT_STATUS_IS_OK(status)) {
@@ -4308,7 +4088,7 @@ static bool api_RNetUserGetInfo(struct smbd_server_connection *sconn,
        b = cli->binding_handle;
 
        status = dcerpc_samr_Connect2(b, mem_ctx,
-                                     global_myname(),
+                                     lp_netbios_name(),
                                      SAMR_ACCESS_CONNECT_TO_SERVER |
                                      SAMR_ACCESS_ENUM_DOMAINS |
                                      SAMR_ACCESS_LOOKUP_DOMAIN,
@@ -4377,11 +4157,11 @@ static bool api_RNetUserGetInfo(struct smbd_server_connection *sconn,
                goto out;
        }
        if (rids.count != types.count) {
-               errcode = W_ERROR_V(WERR_INVALID_PARAM);
+               errcode = W_ERROR_V(WERR_INVALID_PARAMETER);
                goto out;
        }
        if (types.ids[0] != SID_NAME_USER) {
-               errcode = W_ERROR_V(WERR_INVALID_PARAM);
+               errcode = W_ERROR_V(WERR_INVALID_PARAMETER);
                goto out;
        }
 
@@ -4614,7 +4394,7 @@ static bool api_RNetUserGetInfo(struct smbd_server_connection *sconn,
 }
 
 static bool api_WWkstaUserLogon(struct smbd_server_connection *sconn,
-                               connection_struct *conn,uint16 vuid,
+                               connection_struct *conn,uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -4629,7 +4409,7 @@ static bool api_WWkstaUserLogon(struct smbd_server_connection *sconn,
        char* name;
                /* With share level security vuid will always be zero.
                   Don't depend on vuser being non-null !!. JRA */
-       user_struct *vuser = get_valid_user_struct(sconn, vuid);
+       struct user_struct *vuser = get_valid_user_struct(sconn, vuid);
 
        if (!str1 || !str2 || !p) {
                return False;
@@ -4637,8 +4417,8 @@ static bool api_WWkstaUserLogon(struct smbd_server_connection *sconn,
 
        if(vuser != NULL) {
                DEBUG(3,("  Username of UID %d is %s\n",
-                        (int)vuser->session_info->utok.uid,
-                        vuser->session_info->unix_name));
+                        (int)vuser->session_info->unix_token->uid,
+                        vuser->session_info->unix_info->unix_name));
        }
 
        uLevel = get_safe_SVAL(param,tpscnt,p,0,-1);
@@ -4692,13 +4472,15 @@ static bool api_WWkstaUserLogon(struct smbd_server_connection *sconn,
                        fstring mypath;
                        fstrcpy(mypath,"\\\\");
                        fstrcat(mypath,get_local_machine_name());
-                       strupper_m(mypath);
+                       if (!strupper_m(mypath)) {
+                               return false;
+                       }
                        PACKS(&desc,"z",mypath); /* computer */
                }
 
                PACKS(&desc,"z",lp_workgroup());/* domain */
                PACKS(&desc,"z", vuser ?
-                       vuser->session_info->info3->base.logon_script.string
+                     vuser->session_info->info->logon_script
                        : ""); /* script path */
                PACKI(&desc,"D",0x00000000);            /* reserved */
        }
@@ -4723,7 +4505,7 @@ static bool api_WWkstaUserLogon(struct smbd_server_connection *sconn,
 ****************************************************************************/
 
 static bool api_WAccessGetUserPerms(struct smbd_server_connection *sconn,
-                                   connection_struct *conn,uint16 vuid,
+                                   connection_struct *conn,uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -4769,7 +4551,7 @@ static bool api_WAccessGetUserPerms(struct smbd_server_connection *sconn,
   ****************************************************************************/
 
 static bool api_WPrintJobGetInfo(struct smbd_server_connection *sconn,
-                                connection_struct *conn, uint16 vuid,
+                                connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -4781,7 +4563,7 @@ static bool api_WPrintJobGetInfo(struct smbd_server_connection *sconn,
        char *p = skip_string(param,tpscnt,str2);
        int uLevel;
        fstring sharename;
-       uint32 jobid;
+       uint32_t jobid;
        struct pack_desc desc;
        char *tmpdata=NULL;
 
@@ -4820,9 +4602,10 @@ static bool api_WPrintJobGetInfo(struct smbd_server_connection *sconn,
        ZERO_STRUCT(handle);
 
        status = rpc_pipe_open_interface(conn,
-                                        &ndr_table_spoolss.syntax_id,
+                                        &ndr_table_spoolss,
                                         conn->session_info,
-                                        &conn->sconn->client_id,
+                                        conn->sconn->remote_address,
+                                        conn->sconn->local_address,
                                         conn->sconn->msg_ctx,
                                         &cli);
        if (!NT_STATUS_IS_OK(status)) {
@@ -4907,7 +4690,7 @@ static bool api_WPrintJobGetInfo(struct smbd_server_connection *sconn,
 }
 
 static bool api_WPrintJobEnumerate(struct smbd_server_connection *sconn,
-                                  connection_struct *conn, uint16 vuid,
+                                  connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -4962,9 +4745,10 @@ static bool api_WPrintJobEnumerate(struct smbd_server_connection *sconn,
        ZERO_STRUCT(handle);
 
        status = rpc_pipe_open_interface(conn,
-                                        &ndr_table_spoolss.syntax_id,
+                                        &ndr_table_spoolss,
                                         conn->session_info,
-                                        &conn->sconn->client_id,
+                                        conn->sconn->remote_address,
+                                        conn->sconn->local_address,
                                         conn->sconn->msg_ctx,
                                         &cli);
        if (!NT_STATUS_IS_OK(status)) {
@@ -4981,7 +4765,7 @@ static bool api_WPrintJobEnumerate(struct smbd_server_connection *sconn,
                                            name,
                                            NULL,
                                            devmode_ctr,
-                                           SEC_FLAG_MAXIMUM_ALLOWED,
+                                           PRINTER_ACCESS_USE,
                                            &handle,
                                            &werr);
        if (!NT_STATUS_IS_OK(status)) {
@@ -5083,7 +4867,7 @@ static void fill_printdest_info(struct spoolss_PrinterInfo2 *info2, int uLevel,
 
        strncpy(buf, info2->printername, sizeof(buf)-1);
        buf[sizeof(buf)-1] = 0;
-       strupper_m(buf);
+       (void)strupper_m(buf);
 
        if (uLevel <= 1) {
                PACKS(desc,"B9",buf);   /* szName */
@@ -5113,7 +4897,7 @@ static void fill_printdest_info(struct spoolss_PrinterInfo2 *info2, int uLevel,
 }
 
 static bool api_WPrintDestGetInfo(struct smbd_server_connection *sconn,
-                                 connection_struct *conn, uint16 vuid,
+                                 connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -5162,9 +4946,10 @@ static bool api_WPrintDestGetInfo(struct smbd_server_connection *sconn,
        ZERO_STRUCT(handle);
 
        status = rpc_pipe_open_interface(conn,
-                                        &ndr_table_spoolss.syntax_id,
+                                        &ndr_table_spoolss,
                                         conn->session_info,
-                                        &conn->sconn->client_id,
+                                        conn->sconn->remote_address,
+                                        conn->sconn->local_address,
                                         conn->sconn->msg_ctx,
                                         &cli);
        if (!NT_STATUS_IS_OK(status)) {
@@ -5181,7 +4966,7 @@ static bool api_WPrintDestGetInfo(struct smbd_server_connection *sconn,
                                            PrinterName,
                                            NULL,
                                            devmode_ctr,
-                                           SEC_FLAG_MAXIMUM_ALLOWED,
+                                           PRINTER_ACCESS_USE,
                                            &handle,
                                            &werr);
        if (!NT_STATUS_IS_OK(status)) {
@@ -5251,7 +5036,7 @@ static bool api_WPrintDestGetInfo(struct smbd_server_connection *sconn,
 }
 
 static bool api_WPrintDestEnum(struct smbd_server_connection *sconn,
-                              connection_struct *conn, uint16 vuid,
+                              connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -5294,9 +5079,10 @@ static bool api_WPrintDestEnum(struct smbd_server_connection *sconn,
        queuecnt = 0;
 
        status = rpc_pipe_open_interface(conn,
-                                        &ndr_table_spoolss.syntax_id,
+                                        &ndr_table_spoolss,
                                         conn->session_info,
-                                        &conn->sconn->client_id,
+                                        conn->sconn->remote_address,
+                                        conn->sconn->local_address,
                                         conn->sconn->msg_ctx,
                                         &cli);
        if (!NT_STATUS_IS_OK(status)) {
@@ -5362,7 +5148,7 @@ static bool api_WPrintDestEnum(struct smbd_server_connection *sconn,
 }
 
 static bool api_WPrintDriverEnum(struct smbd_server_connection *sconn,
-                                connection_struct *conn, uint16 vuid,
+                                connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -5426,7 +5212,7 @@ static bool api_WPrintDriverEnum(struct smbd_server_connection *sconn,
 }
 
 static bool api_WPrintQProcEnum(struct smbd_server_connection *sconn,
-                               connection_struct *conn, uint16 vuid,
+                               connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -5490,7 +5276,7 @@ static bool api_WPrintQProcEnum(struct smbd_server_connection *sconn,
 }
 
 static bool api_WPrintPortEnum(struct smbd_server_connection *sconn,
-                              connection_struct *conn, uint16 vuid,
+                              connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -5560,7 +5346,7 @@ static bool api_WPrintPortEnum(struct smbd_server_connection *sconn,
  ****************************************************************************/
 
 static bool api_RNetSessionEnum(struct smbd_server_connection *sconn,
-                               connection_struct *conn, uint16 vuid,
+                               connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt,int mprcnt,
@@ -5605,9 +5391,10 @@ static bool api_RNetSessionEnum(struct smbd_server_connection *sconn,
        }
 
        status = rpc_pipe_open_interface(conn,
-                                        &ndr_table_srvsvc.syntax_id,
+                                        &ndr_table_srvsvc,
                                         conn->session_info,
-                                        &conn->sconn->client_id,
+                                        conn->sconn->remote_address,
+                                        conn->sconn->local_address,
                                         conn->sconn->msg_ctx,
                                         &cli);
        if (!NT_STATUS_IS_OK(status)) {
@@ -5621,7 +5408,7 @@ static bool api_RNetSessionEnum(struct smbd_server_connection *sconn,
        info_ctr.level = 1;
        info_ctr.ctr.ctr1 = talloc_zero(talloc_tos(), struct srvsvc_NetSessCtr1);
        if (info_ctr.ctr.ctr1 == NULL) {
-               desc.errcode = W_ERROR_V(WERR_NOMEM);
+               desc.errcode = W_ERROR_V(WERR_NOT_ENOUGH_MEMORY);
                goto out;
        }
 
@@ -5699,7 +5486,7 @@ static bool api_RNetSessionEnum(struct smbd_server_connection *sconn,
  ****************************************************************************/
 
 static bool api_TooSmall(struct smbd_server_connection *sconn,
-                        connection_struct *conn,uint16 vuid, char *param, char *data,
+                        connection_struct *conn,uint64_t vuid, char *param, char *data,
                         int mdrcnt, int mprcnt,
                         char **rdata, char **rparam,
                         int *rdata_len, int *rparam_len)
@@ -5724,7 +5511,7 @@ static bool api_TooSmall(struct smbd_server_connection *sconn,
  ****************************************************************************/
 
 static bool api_Unsupported(struct smbd_server_connection *sconn,
-                           connection_struct *conn, uint16 vuid,
+                           connection_struct *conn, uint64_t vuid,
                                char *param, int tpscnt,
                                char *data, int tdscnt,
                                int mdrcnt, int mprcnt,
@@ -5751,7 +5538,7 @@ static const struct {
        const char *name;
        int id;
        bool (*fn)(struct smbd_server_connection *sconn,
-                  connection_struct *, uint16,
+                  connection_struct *, uint64_t,
                        char *, int,
                        char *, int,
                        int,int,char **,char **,int *,int *);
@@ -5784,7 +5571,6 @@ static const struct {
        {"NetServerEnum2",      RAP_NetServerEnum2,     api_RNetServerEnum2}, /* anon OK */
        {"NetServerEnum3",      RAP_NetServerEnum3,     api_RNetServerEnum3}, /* anon OK */
        {"WAccessGetUserPerms",RAP_WAccessGetUserPerms,api_WAccessGetUserPerms},
-       {"SetUserPassword",     RAP_WUserPasswordSet2,  api_SetUserPassword},
        {"WWkstaUserLogon",     RAP_WWkstaUserLogon,    api_WWkstaUserLogon},
        {"PrintJobInfo",        RAP_WPrintJobSetInfo,   api_PrintJobInfo},
        {"WPrintDriverEnum",    RAP_WPrintDriverEnum,   api_WPrintDriverEnum},
@@ -5803,7 +5589,7 @@ static const struct {
  Handle remote api calls.
 ****************************************************************************/
 
-void api_reply(connection_struct *conn, uint16 vuid,
+void api_reply(connection_struct *conn, uint64_t vuid,
               struct smb_request *req,
               char *data, char *params,
               int tdscnt, int tpscnt,
@@ -5857,9 +5643,9 @@ void api_reply(connection_struct *conn, uint16 vuid,
        /* Check whether this api call can be done anonymously */
 
        if (api_commands[i].auth_user && lp_restrict_anonymous()) {
-               user_struct *user = get_valid_user_struct(req->sconn, vuid);
+               struct user_struct *user = get_valid_user_struct(req->sconn, vuid);
 
-               if (!user || user->session_info->guest) {
+               if (!user || security_session_user_level(user->session_info, NULL) < SECURITY_USER) {
                        reply_nterror(req, NT_STATUS_ACCESS_DENIED);
                        return;
                }