Use pidl for _samr_ChangePasswordUser2().
[ira/wip.git] / source3 / rpc_server / srv_samr_nt.c
index b3be0cccc1565fbcc4c4fbadab1c3f7361bb45bb..2ccb202aed5a8e01c483b4db22d554d2e8ee8164 100644 (file)
@@ -14,7 +14,7 @@
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
- *  the Free Software Foundation; either version 2 of the License, or
+ *  the Free Software Foundation; either version 3 of the License, or
  *  (at your option) any later version.
  *
  *  This program is distributed in the hope that it will be useful,
@@ -23,8 +23,7 @@
  *  GNU General Public License for more details.
  *
  *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ *  along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
 /*
                ( READ_CONTROL_ACCESS           | \
                  SA_RIGHT_USER_CHANGE_PASSWORD | \
                  SA_RIGHT_USER_SET_LOC_COM )
+#define SAMR_USR_RIGHTS_CANT_WRITE_PW \
+               ( READ_CONTROL_ACCESS | SA_RIGHT_USER_SET_LOC_COM )
 
 #define DISP_INFO_CACHE_TIMEOUT 10
 
 typedef struct disp_info {
-       struct disp_info *next, *prev;
-       TALLOC_CTX *mem_ctx;
        DOM_SID sid; /* identify which domain this is. */
-       BOOL builtin_domain; /* Quick flag to check if this is the builtin domain. */
+       bool builtin_domain; /* Quick flag to check if this is the builtin domain. */
        struct pdb_search *users; /* querydispinfo 1 and 4 */
        struct pdb_search *machines; /* querydispinfo 2 */
        struct pdb_search *groups; /* querydispinfo 3 and 5, enumgroups */
@@ -56,46 +55,49 @@ typedef struct disp_info {
        uint16 enum_acb_mask;
        struct pdb_search *enum_users; /* enumusers with a mask */
 
-
-       smb_event_id_t di_cache_timeout_event; /* cache idle timeout handler. */
+       struct timed_event *cache_timeout_event; /* cache idle timeout
+                                                 * handler. */
 } DISP_INFO;
 
 /* We keep a static list of these by SID as modern clients close down
    all resources between each request in a complete enumeration. */
 
-static DISP_INFO *disp_info_list;
-
 struct samr_info {
        /* for use by the \PIPE\samr policy */
        DOM_SID sid;
-       BOOL builtin_domain; /* Quick flag to check if this is the builtin domain. */
+       bool builtin_domain; /* Quick flag to check if this is the builtin domain. */
        uint32 status; /* some sort of flag.  best to record it.  comes from opnum 0x39 */
        uint32 acc_granted;
        DISP_INFO *disp_info;
        TALLOC_CTX *mem_ctx;
 };
 
-static struct generic_mapping sam_generic_mapping = {
+static const struct generic_mapping sam_generic_mapping = {
        GENERIC_RIGHTS_SAM_READ,
        GENERIC_RIGHTS_SAM_WRITE,
        GENERIC_RIGHTS_SAM_EXECUTE,
        GENERIC_RIGHTS_SAM_ALL_ACCESS};
-static struct generic_mapping dom_generic_mapping = {
+static const struct generic_mapping dom_generic_mapping = {
        GENERIC_RIGHTS_DOMAIN_READ,
        GENERIC_RIGHTS_DOMAIN_WRITE,
        GENERIC_RIGHTS_DOMAIN_EXECUTE,
        GENERIC_RIGHTS_DOMAIN_ALL_ACCESS};
-static struct generic_mapping usr_generic_mapping = {
+static const struct generic_mapping usr_generic_mapping = {
        GENERIC_RIGHTS_USER_READ,
        GENERIC_RIGHTS_USER_WRITE,
        GENERIC_RIGHTS_USER_EXECUTE,
        GENERIC_RIGHTS_USER_ALL_ACCESS};
-static struct generic_mapping grp_generic_mapping = {
+static const struct generic_mapping usr_nopwchange_generic_mapping = {
+       GENERIC_RIGHTS_USER_READ,
+       GENERIC_RIGHTS_USER_WRITE,
+       GENERIC_RIGHTS_USER_EXECUTE & ~SA_RIGHT_USER_CHANGE_PASSWORD,
+       GENERIC_RIGHTS_USER_ALL_ACCESS};
+static const struct generic_mapping grp_generic_mapping = {
        GENERIC_RIGHTS_GROUP_READ,
        GENERIC_RIGHTS_GROUP_WRITE,
        GENERIC_RIGHTS_GROUP_EXECUTE,
        GENERIC_RIGHTS_GROUP_ALL_ACCESS};
-static struct generic_mapping ali_generic_mapping = {
+static const struct generic_mapping ali_generic_mapping = {
        GENERIC_RIGHTS_ALIAS_READ,
        GENERIC_RIGHTS_ALIAS_WRITE,
        GENERIC_RIGHTS_ALIAS_EXECUTE,
@@ -105,7 +107,7 @@ static struct generic_mapping ali_generic_mapping = {
 *******************************************************************/
 
 static NTSTATUS make_samr_object_sd( TALLOC_CTX *ctx, SEC_DESC **psd, size_t *sd_size,
-                                     struct generic_mapping *map,
+                                     const struct generic_mapping *map,
                                     DOM_SID *sid, uint32 sid_access )
 {
        DOM_SID domadmin_sid;
@@ -147,7 +149,9 @@ static NTSTATUS make_samr_object_sd( TALLOC_CTX *ctx, SEC_DESC **psd, size_t *sd
        if ((psa = make_sec_acl(ctx, NT4_ACL_REVISION, i, ace)) == NULL)
                return NT_STATUS_NO_MEMORY;
 
-       if ((*psd = make_sec_desc(ctx, SEC_DESC_REVISION, SEC_DESC_SELF_RELATIVE, NULL, NULL, NULL, psa, sd_size)) == NULL)
+       if ((*psd = make_sec_desc(ctx, SECURITY_DESCRIPTOR_REVISION_1,
+                                 SEC_DESC_SELF_RELATIVE, NULL, NULL, NULL,
+                                 psa, sd_size)) == NULL)
                return NT_STATUS_NO_MEMORY;
 
        return NT_STATUS_OK;
@@ -247,38 +251,59 @@ static NTSTATUS access_check_samr_function(uint32 acc_granted, uint32 acc_requir
  Fetch or create a dispinfo struct.
 ********************************************************************/
 
-static DISP_INFO *get_samr_dispinfo_by_sid(DOM_SID *psid, const char *sid_str)
+static DISP_INFO *get_samr_dispinfo_by_sid(DOM_SID *psid)
 {
-       TALLOC_CTX *mem_ctx;
-       DISP_INFO *dpi;
-
-       for (dpi = disp_info_list; dpi; dpi = dpi->next) {
-               if (sid_equal(psid, &dpi->sid)) {
-                       return dpi;
-               }
-       }
+       /*
+        * We do a static cache for DISP_INFO's here. Explanation can be found
+        * in Jeremy's checkin message to r11793:
+        *
+        * Fix the SAMR cache so it works across completely insane
+        * client behaviour (ie.:
+        * open pipe/open SAMR handle/enumerate 0 - 1024
+        * close SAMR handle, close pipe.
+        * open pipe/open SAMR handle/enumerate 1024 - 2048...
+        * close SAMR handle, close pipe.
+        * And on ad-nausium. Amazing.... probably object-oriented
+        * client side programming in action yet again.
+        * This change should *massively* improve performance when
+        * enumerating users from an LDAP database.
+        * Jeremy.
+        *
+        * "Our" and the builtin domain are the only ones where we ever
+        * enumerate stuff, so just cache 2 entries.
+        */
 
-       /* This struct is never free'd - I'm using talloc so we
-          can get a list out of smbd using smbcontrol. There will
-          be one of these per SID we're authorative for. JRA. */
+       static struct disp_info builtin_dispinfo;
+       static struct disp_info domain_dispinfo;
 
-       mem_ctx = talloc_init("DISP_INFO for domain sid %s", sid_str);
+       /* There are two cases to consider here:
+          1) The SID is a domain SID and we look for an equality match, or
+          2) This is an account SID and so we return the DISP_INFO* for our 
+             domain */
 
-       if ((dpi = TALLOC_ZERO_P(mem_ctx, DISP_INFO)) == NULL)
+       if (psid == NULL) {
                return NULL;
+       }
 
-       dpi->mem_ctx = mem_ctx;
+       if (sid_check_is_builtin(psid) || sid_check_is_in_builtin(psid)) {
+               /*
+                * Necessary only once, but it does not really hurt.
+                */
+               sid_copy(&builtin_dispinfo.sid, &global_sid_Builtin);
 
-       if (psid) {
-               sid_copy( &dpi->sid, psid);
-               dpi->builtin_domain = sid_check_is_builtin(psid);
-       } else {
-               dpi->builtin_domain = False;
+               return &builtin_dispinfo;
        }
+               
+       if (sid_check_is_domain(psid) || sid_check_is_in_our_domain(psid)) {
+               /*
+                * Necessary only once, but it does not really hurt.
+                */
+               sid_copy(&domain_dispinfo.sid, get_global_sam_sid());
 
-       DLIST_ADD(disp_info_list, dpi);
+               return &domain_dispinfo;
+       }
 
-       return dpi;
+       return NULL;
 }
 
 /*******************************************************************
@@ -292,7 +317,7 @@ static struct samr_info *get_samr_info_by_sid(DOM_SID *psid)
        TALLOC_CTX *mem_ctx;
        
        if (psid) {
-               sid_to_string(sid_str, psid);
+               sid_to_fstring(sid_str, psid);
        } else {
                fstrcpy(sid_str,"(NULL)");
        }
@@ -312,12 +337,7 @@ static struct samr_info *get_samr_info_by_sid(DOM_SID *psid)
        }
        info->mem_ctx = mem_ctx;
 
-       info->disp_info = get_samr_dispinfo_by_sid(psid, sid_str);
-
-       if (!info->disp_info) {
-               talloc_destroy(mem_ctx);
-               return NULL;
-       }
+       info->disp_info = get_samr_dispinfo_by_sid(psid);
 
        return info;
 }
@@ -326,9 +346,10 @@ static struct samr_info *get_samr_info_by_sid(DOM_SID *psid)
  Function to free the per SID data.
  ********************************************************************/
 
-static void free_samr_cache(DISP_INFO *disp_info, const char *sid_str)
+static void free_samr_cache(DISP_INFO *disp_info)
 {
-       DEBUG(10,("free_samr_cache: deleting cache for SID %s\n", sid_str));
+       DEBUG(10, ("free_samr_cache: deleting cache for SID %s\n",
+                  sid_string_dbg(&disp_info->sid)));
 
        /* We need to become root here because the paged search might have to
         * tell the LDAP server we're not interested in the rest anymore. */
@@ -376,10 +397,8 @@ static void free_samr_info(void *ptr)
        /* Only free the dispinfo cache if no one bothered to set up
           a timeout. */
 
-       if (info->disp_info && info->disp_info->di_cache_timeout_event == (smb_event_id_t)0) {
-               fstring sid_str;
-               sid_to_string(sid_str, &info->disp_info->sid);
-               free_samr_cache(info->disp_info, sid_str);
+       if (info->disp_info && info->disp_info->cache_timeout_event == NULL) {
+               free_samr_cache(info->disp_info);
        }
 
        talloc_destroy(info->mem_ctx);
@@ -389,23 +408,18 @@ static void free_samr_info(void *ptr)
  Idle event handler. Throw away the disp info cache.
  ********************************************************************/
 
-static void disp_info_cache_idle_timeout_handler(void **private_data,
-                                       time_t *ev_interval,
-                                       time_t ev_now)
+static void disp_info_cache_idle_timeout_handler(struct event_context *ev_ctx,
+                                                struct timed_event *te,
+                                                const struct timeval *now,
+                                                void *private_data)
 {
-       fstring sid_str;
-       DISP_INFO *disp_info = (DISP_INFO *)(*private_data);
-
-       sid_to_string(sid_str, &disp_info->sid);
+       DISP_INFO *disp_info = (DISP_INFO *)private_data;
 
-       free_samr_cache(disp_info, sid_str);
+       TALLOC_FREE(disp_info->cache_timeout_event);
 
-       /* Remove the event. */
-       smb_unregister_idle_event(disp_info->di_cache_timeout_event);
-       disp_info->di_cache_timeout_event = (smb_event_id_t)0;
-
-       DEBUG(10,("disp_info_cache_idle_timeout_handler: caching timed out for SID %s at %u\n",
-               sid_str, (unsigned int)ev_now));
+       DEBUG(10, ("disp_info_cache_idle_timeout_handler: caching timed "
+                  "out\n"));
+       free_samr_cache(disp_info);
 }
 
 /*******************************************************************
@@ -414,24 +428,19 @@ static void disp_info_cache_idle_timeout_handler(void **private_data,
 
 static void set_disp_info_cache_timeout(DISP_INFO *disp_info, time_t secs_fromnow)
 {
-       fstring sid_str;
-
-       sid_to_string(sid_str, &disp_info->sid);
-
        /* Remove any pending timeout and update. */
 
-       if (disp_info->di_cache_timeout_event) {
-               smb_unregister_idle_event(disp_info->di_cache_timeout_event);
-               disp_info->di_cache_timeout_event = (smb_event_id_t)0;
-       }
+       TALLOC_FREE(disp_info->cache_timeout_event);
 
-       DEBUG(10,("set_disp_info_cache_timeout: caching enumeration for SID %s for %u seconds\n",
-               sid_str, (unsigned int)secs_fromnow ));
+       DEBUG(10,("set_disp_info_cache_timeout: caching enumeration for "
+                 "SID %s for %u seconds\n", sid_string_dbg(&disp_info->sid),
+                 (unsigned int)secs_fromnow ));
 
-       disp_info->di_cache_timeout_event =
-               smb_register_idle_event(disp_info_cache_idle_timeout_handler,
-                                       disp_info,
-                                       secs_fromnow);
+       disp_info->cache_timeout_event = event_add_timed(
+               smbd_event_context(), NULL,
+               timeval_current_ofs(secs_fromnow, 0),
+               "disp_info_cache_idle_timeout_handler",
+               disp_info_cache_idle_timeout_handler, (void *)disp_info);
 }
 
 /*******************************************************************
@@ -441,25 +450,20 @@ static void set_disp_info_cache_timeout(DISP_INFO *disp_info, time_t secs_fromno
 
 static void force_flush_samr_cache(DISP_INFO *disp_info)
 {
-       if (disp_info) {
-               fstring sid_str;
-
-               sid_to_string(sid_str, &disp_info->sid);
-               if (disp_info->di_cache_timeout_event) {
-                       smb_unregister_idle_event(disp_info->di_cache_timeout_event);
-                       disp_info->di_cache_timeout_event = (smb_event_id_t)0;
-                       DEBUG(10,("force_flush_samr_cache: clearing idle event for SID %s\n",
-                               sid_str));
-               }
-               free_samr_cache(disp_info, sid_str);
+       if ((disp_info == NULL) || (disp_info->cache_timeout_event == NULL)) {
+               return;
        }
+
+       DEBUG(10,("force_flush_samr_cache: clearing idle event\n"));
+       TALLOC_FREE(disp_info->cache_timeout_event);
+       free_samr_cache(disp_info);
 }
 
 /*******************************************************************
  Ensure password info is never given out. Paranioa... JRA.
  ********************************************************************/
 
-static void samr_clear_sam_passwd(SAM_ACCOUNT *sam_pass)
+static void samr_clear_sam_passwd(struct samu *sam_pass)
 {
        
        if (!sam_pass)
@@ -471,7 +475,7 @@ static void samr_clear_sam_passwd(SAM_ACCOUNT *sam_pass)
        pdb_set_nt_passwd(sam_pass, NULL, PDB_DEFAULT);
 }
 
-static uint32 count_sam_users(struct disp_info *info, uint16 acct_flags)
+static uint32 count_sam_users(struct disp_info *info, uint32 acct_flags)
 {
        struct samr_displayentry *entry;
 
@@ -539,45 +543,42 @@ static uint32 count_sam_aliases(struct disp_info *info)
 }
 
 /*******************************************************************
- _samr_close_hnd
+ _samr_Close
  ********************************************************************/
 
-NTSTATUS _samr_close_hnd(pipes_struct *p, SAMR_Q_CLOSE_HND *q_u, SAMR_R_CLOSE_HND *r_u)
+NTSTATUS _samr_Close(pipes_struct *p, struct samr_Close *r)
 {
-       r_u->status = NT_STATUS_OK;
-
-       /* close the policy handle */
-       if (!close_policy_hnd(p, &q_u->pol))
-               return NT_STATUS_OBJECT_NAME_INVALID;
+       if (!close_policy_hnd(p, r->in.handle)) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
 
-       DEBUG(5,("samr_reply_close_hnd: %d\n", __LINE__));
+       ZERO_STRUCTP(r->out.handle);
 
-       return r_u->status;
+       return NT_STATUS_OK;
 }
 
 /*******************************************************************
samr_reply_open_domain
_samr_OpenDomain
  ********************************************************************/
 
-NTSTATUS _samr_open_domain(pipes_struct *p, SAMR_Q_OPEN_DOMAIN *q_u, SAMR_R_OPEN_DOMAIN *r_u)
+NTSTATUS _samr_OpenDomain(pipes_struct *p,
+                         struct samr_OpenDomain *r)
 {
        struct    samr_info *info;
        SEC_DESC *psd = NULL;
        uint32    acc_granted;
-       uint32    des_access = q_u->flags;
+       uint32    des_access = r->in.access_mask;
        NTSTATUS  status;
        size_t    sd_size;
        SE_PRIV se_rights;
 
-       r_u->status = NT_STATUS_OK;
-
        /* find the connection policy handle. */
        
-       if ( !find_policy_by_hnd(p, &q_u->pol, (void**)(void *)&info) )
+       if ( !find_policy_by_hnd(p, r->in.connect_handle, (void**)(void *)&info) )
                return NT_STATUS_INVALID_HANDLE;
 
        status = access_check_samr_function( info->acc_granted, 
-               SA_RIGHT_SAM_OPEN_DOMAIN, "_samr_open_domain" );
+               SA_RIGHT_SAM_OPEN_DOMAIN, "_samr_OpenDomain" );
                
        if ( !NT_STATUS_IS_OK(status) )
                return status;
@@ -592,28 +593,28 @@ NTSTATUS _samr_open_domain(pipes_struct *p, SAMR_Q_OPEN_DOMAIN *q_u, SAMR_R_OPEN
 
        status = access_check_samr_object( psd, p->pipe_user.nt_user_token, 
                &se_rights, GENERIC_RIGHTS_DOMAIN_WRITE, des_access, 
-               &acc_granted, "_samr_open_domain" );
+               &acc_granted, "_samr_OpenDomain" );
                
        if ( !NT_STATUS_IS_OK(status) )
                return status;
 
-       if (!sid_check_is_domain(&q_u->dom_sid.sid) &&
-           !sid_check_is_builtin(&q_u->dom_sid.sid)) {
+       if (!sid_check_is_domain(r->in.sid) &&
+           !sid_check_is_builtin(r->in.sid)) {
                return NT_STATUS_NO_SUCH_DOMAIN;
        }
 
        /* associate the domain SID with the (unique) handle. */
-       if ((info = get_samr_info_by_sid(&q_u->dom_sid.sid))==NULL)
+       if ((info = get_samr_info_by_sid(r->in.sid))==NULL)
                return NT_STATUS_NO_MEMORY;
        info->acc_granted = acc_granted;
 
        /* get a (unique) handle.  open a policy on it. */
-       if (!create_policy_hnd(p, &r_u->domain_pol, free_samr_info, (void *)info))
+       if (!create_policy_hnd(p, r->out.domain_handle, free_samr_info, (void *)info))
                return NT_STATUS_OBJECT_NAME_NOT_FOUND;
 
-       DEBUG(5,("samr_open_domain: %d\n", __LINE__));
+       DEBUG(5,("_samr_OpenDomain: %d\n", __LINE__));
 
-       return r_u->status;
+       return NT_STATUS_OK;
 }
 
 /*******************************************************************
@@ -645,20 +646,10 @@ NTSTATUS _samr_get_usrdom_pwinfo(pipes_struct *p, SAMR_Q_GET_USRDOM_PWINFO *q_u,
        return r_u->status;
 }
 
-/*******************************************************************
- _samr_set_sec_obj
- ********************************************************************/
-
-NTSTATUS _samr_set_sec_obj(pipes_struct *p, SAMR_Q_SET_SEC_OBJ *q_u, SAMR_R_SET_SEC_OBJ *r_u)
-{
-       DEBUG(0,("_samr_set_sec_obj: Not yet implemented!\n"));
-       return NT_STATUS_NOT_IMPLEMENTED;
-}
-
 /*******************************************************************
 ********************************************************************/
 
-static BOOL get_lsa_policy_samr_sid( pipes_struct *p, POLICY_HND *pol, 
+static bool get_lsa_policy_samr_sid( pipes_struct *p, POLICY_HND *pol, 
                                        DOM_SID *sid, uint32 *acc_granted,
                                        DISP_INFO **ppdisp_info)
 {
@@ -680,6 +671,102 @@ static BOOL get_lsa_policy_samr_sid( pipes_struct *p, POLICY_HND *pol,
        return True;
 }
 
+/*******************************************************************
+ _samr_set_sec_obj
+ ********************************************************************/
+
+NTSTATUS _samr_set_sec_obj(pipes_struct *p, SAMR_Q_SET_SEC_OBJ *q_u, SAMR_R_SET_SEC_OBJ *r_u)
+{
+       DOM_SID pol_sid;
+       uint32 acc_granted, i;
+       SEC_ACL *dacl;
+       bool ret;
+       struct samu *sampass=NULL;
+       NTSTATUS status;
+
+       r_u->status = NT_STATUS_OK;
+
+       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &pol_sid, &acc_granted, NULL))
+               return NT_STATUS_INVALID_HANDLE;
+
+       if (!(sampass = samu_new( p->mem_ctx))) {
+               DEBUG(0,("No memory!\n"));
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       /* get the user record */
+       become_root();
+       ret = pdb_getsampwsid(sampass, &pol_sid);
+       unbecome_root();
+
+       if (!ret) {
+               DEBUG(4, ("User %s not found\n", sid_string_dbg(&pol_sid)));
+               TALLOC_FREE(sampass);
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       dacl = q_u->buf->sd->dacl;
+       for (i=0; i < dacl->num_aces; i++) {
+               if (sid_equal(&pol_sid, &dacl->aces[i].trustee)) {
+                       ret = pdb_set_pass_can_change(sampass, 
+                               (dacl->aces[i].access_mask & 
+                                SA_RIGHT_USER_CHANGE_PASSWORD) ? 
+                                                     True: False);
+                       break;
+               }
+       }
+
+       if (!ret) {
+               TALLOC_FREE(sampass);
+               return NT_STATUS_ACCESS_DENIED;
+       }
+
+       status = access_check_samr_function(acc_granted, SA_RIGHT_USER_SET_ATTRIBUTES, "_samr_set_sec_obj");
+       if (NT_STATUS_IS_OK(status)) {
+               become_root();
+               status = pdb_update_sam_account(sampass);
+               unbecome_root();
+       }
+
+       TALLOC_FREE(sampass);
+
+       return status;
+}
+
+/*******************************************************************
+  build correct perms based on policies and password times for _samr_query_sec_obj
+*******************************************************************/
+static bool check_change_pw_access(TALLOC_CTX *mem_ctx, DOM_SID *user_sid)
+{
+       struct samu *sampass=NULL;
+       bool ret;
+
+       if ( !(sampass = samu_new( mem_ctx )) ) {
+               DEBUG(0,("No memory!\n"));
+               return False;
+       }
+
+       become_root();
+       ret = pdb_getsampwsid(sampass, user_sid);
+       unbecome_root();
+
+       if (ret == False) {
+               DEBUG(4,("User %s not found\n", sid_string_dbg(user_sid)));
+               TALLOC_FREE(sampass);
+               return False;
+       }
+
+       DEBUG(3,("User:[%s]\n",  pdb_get_username(sampass) ));
+
+       if (pdb_get_pass_can_change(sampass)) {
+               TALLOC_FREE(sampass);
+               return True;
+       }
+       TALLOC_FREE(sampass);
+       return False;
+}
+
+
 /*******************************************************************
  _samr_query_sec_obj
  ********************************************************************/
@@ -687,7 +774,6 @@ static BOOL get_lsa_policy_samr_sid( pipes_struct *p, POLICY_HND *pol,
 NTSTATUS _samr_query_sec_obj(pipes_struct *p, SAMR_Q_QUERY_SEC_OBJ *q_u, SAMR_R_QUERY_SEC_OBJ *r_u)
 {
        DOM_SID pol_sid;
-       fstring str_sid;
        SEC_DESC * psd = NULL;
        uint32 acc_granted;
        size_t sd_size;
@@ -698,7 +784,8 @@ NTSTATUS _samr_query_sec_obj(pipes_struct *p, SAMR_Q_QUERY_SEC_OBJ *q_u, SAMR_R_
        if (!get_lsa_policy_samr_sid(p, &q_u->user_pol, &pol_sid, &acc_granted, NULL))
                return NT_STATUS_INVALID_HANDLE;
 
-       DEBUG(10,("_samr_query_sec_obj: querying security on SID: %s\n", sid_to_string(str_sid, &pol_sid)));
+       DEBUG(10,("_samr_query_sec_obj: querying security on SID: %s\n",
+                 sid_string_dbg(&pol_sid)));
 
        /* Check what typ of SID is beeing queried (e.g Domain SID, User SID, Group SID) */
 
@@ -708,19 +795,28 @@ NTSTATUS _samr_query_sec_obj(pipes_struct *p, SAMR_Q_QUERY_SEC_OBJ *q_u, SAMR_R_
                r_u->status = make_samr_object_sd(p->mem_ctx, &psd, &sd_size, &sam_generic_mapping, NULL, 0);
        } else if (sid_equal(&pol_sid,get_global_sam_sid())) { 
                /* check if it is our domain SID */
-               DEBUG(5,("_samr_query_sec_obj: querying security on Domain with SID: %s\n", sid_to_string(str_sid, &pol_sid)));
+               DEBUG(5,("_samr_query_sec_obj: querying security on Domain "
+                        "with SID: %s\n", sid_string_dbg(&pol_sid)));
                r_u->status = make_samr_object_sd(p->mem_ctx, &psd, &sd_size, &dom_generic_mapping, NULL, 0);
        } else if (sid_equal(&pol_sid,&global_sid_Builtin)) {
                /* check if it is the Builtin  Domain */
                /* TODO: Builtin probably needs a different SD with restricted write access*/
-               DEBUG(5,("_samr_query_sec_obj: querying security on Builtin Domain with SID: %s\n", sid_to_string(str_sid, &pol_sid)));
+               DEBUG(5,("_samr_query_sec_obj: querying security on Builtin "
+                        "Domain with SID: %s\n", sid_string_dbg(&pol_sid)));
                r_u->status = make_samr_object_sd(p->mem_ctx, &psd, &sd_size, &dom_generic_mapping, NULL, 0);
        } else if (sid_check_is_in_our_domain(&pol_sid) ||
                 sid_check_is_in_builtin(&pol_sid)) {
                /* TODO: different SDs have to be generated for aliases groups and users.
                         Currently all three get a default user SD  */
-               DEBUG(10,("_samr_query_sec_obj: querying security on Object with SID: %s\n", sid_to_string(str_sid, &pol_sid)));
-               r_u->status = make_samr_object_sd(p->mem_ctx, &psd, &sd_size, &usr_generic_mapping, &pol_sid, SAMR_USR_RIGHTS_WRITE_PW);
+               DEBUG(10,("_samr_query_sec_obj: querying security on Object "
+                         "with SID: %s\n", sid_string_dbg(&pol_sid)));
+               if (check_change_pw_access(p->mem_ctx, &pol_sid)) {
+                       r_u->status = make_samr_object_sd(p->mem_ctx, &psd, &sd_size, &usr_generic_mapping, 
+                                                         &pol_sid, SAMR_USR_RIGHTS_WRITE_PW);
+               } else {
+                       r_u->status = make_samr_object_sd(p->mem_ctx, &psd, &sd_size, &usr_nopwchange_generic_mapping, 
+                                                         &pol_sid, SAMR_USR_RIGHTS_CANT_WRITE_PW);
+               }
        } else {
                return NT_STATUS_OBJECT_TYPE_MISMATCH;
        }
@@ -758,7 +854,7 @@ static NTSTATUS make_user_sam_entry_list(TALLOC_CTX *ctx, SAM_ENTRY **sam_pp,
        uni_name = TALLOC_ZERO_ARRAY(ctx, UNISTR2, num_entries);
 
        if (sam == NULL || uni_name == NULL) {
-               DEBUG(0, ("make_user_sam_entry_list: talloc_zero failed!\n"));
+               DEBUG(0, ("make_user_sam_entry_list: TALLOC_ZERO failed!\n"));
                return NT_STATUS_NO_MEMORY;
        }
 
@@ -853,6 +949,7 @@ NTSTATUS _samr_enum_dom_users(pipes_struct *p, SAMR_Q_ENUM_DOM_USERS *q_u,
        if (num_account == 0) {
                DEBUG(5, ("_samr_enum_dom_users: enumeration handle over "
                          "total entries\n"));
+               init_samr_r_enum_dom_users(r_u, q_u->start_idx, 0);
                return NT_STATUS_OK;
        }
 
@@ -1005,7 +1102,7 @@ NTSTATUS _samr_enum_dom_aliases(pipes_struct *p, SAMR_Q_ENUM_DOM_ALIASES *q_u, S
                return r_u->status;
 
        DEBUG(5,("samr_reply_enum_dom_aliases: sid %s\n",
-                sid_string_static(&info->sid)));
+                sid_string_dbg(&info->sid)));
 
        become_root();
 
@@ -1257,7 +1354,7 @@ NTSTATUS _samr_query_aliasinfo(pipes_struct *p, SAMR_Q_QUERY_ALIASINFO *q_u, SAM
        DOM_SID   sid;
        struct acct_info info;
        uint32    acc_granted;
-       BOOL ret;
+       NTSTATUS status;
 
        r_u->status = NT_STATUS_OK;
 
@@ -1271,11 +1368,11 @@ NTSTATUS _samr_query_aliasinfo(pipes_struct *p, SAMR_Q_QUERY_ALIASINFO *q_u, SAM
        }
 
        become_root();
-       ret = pdb_get_aliasinfo(&sid, &info);
+       status = pdb_get_aliasinfo(&sid, &info);
        unbecome_root();
        
-       if ( !ret )
-               return NT_STATUS_NO_SUCH_ALIAS;
+       if ( !NT_STATUS_IS_OK(status))
+               return status;
 
        if ( !(r_u->ctr = TALLOC_ZERO_P( p->mem_ctx, ALIAS_INFO_CTR )) ) 
                return NT_STATUS_NO_MEMORY;
@@ -1366,11 +1463,10 @@ NTSTATUS _samr_query_aliasinfo(pipes_struct *p, SAMR_Q_QUERY_ALIASINFO *q_u, SAM
 NTSTATUS _samr_lookup_names(pipes_struct *p, SAMR_Q_LOOKUP_NAMES *q_u, SAMR_R_LOOKUP_NAMES *r_u)
 {
        uint32 rid[MAX_SAM_ENTRIES];
-       enum SID_NAME_USE type[MAX_SAM_ENTRIES];
+       enum lsa_SidType type[MAX_SAM_ENTRIES];
        int i;
        int num_rids = q_u->num_names2;
        DOM_SID pol_sid;
-       fstring sid_str;
        uint32  acc_granted;
 
        r_u->status = NT_STATUS_OK;
@@ -1394,7 +1490,8 @@ NTSTATUS _samr_lookup_names(pipes_struct *p, SAMR_Q_LOOKUP_NAMES *q_u, SAMR_R_LO
                DEBUG(5,("_samr_lookup_names: truncating entries to %d\n", num_rids));
        }
 
-       DEBUG(5,("_samr_lookup_names: looking name on SID %s\n", sid_to_string(sid_str, &pol_sid)));
+       DEBUG(5,("_samr_lookup_names: looking name on SID %s\n",
+                sid_string_dbg(&pol_sid)));
        
        for (i = 0; i < num_rids; i++) {
                fstring name;
@@ -1424,7 +1521,7 @@ NTSTATUS _samr_lookup_names(pipes_struct *p, SAMR_Q_LOOKUP_NAMES *q_u, SAMR_R_LO
                }
        }
 
-       init_samr_r_lookup_names(p->mem_ctx, r_u, num_rids, rid, (uint32 *)type, r_u->status);
+       init_samr_r_lookup_names(p->mem_ctx, r_u, num_rids, rid, type, r_u->status);
 
        DEBUG(5,("_samr_lookup_names: %d\n", __LINE__));
 
@@ -1432,22 +1529,22 @@ NTSTATUS _samr_lookup_names(pipes_struct *p, SAMR_Q_LOOKUP_NAMES *q_u, SAMR_R_LO
 }
 
 /*******************************************************************
- _samr_chgpasswd_user
+ _samr_ChangePasswordUser2
  ********************************************************************/
+NTSTATUS _samr_ChangePasswordUser2(pipes_struct *p,
+                                  struct samr_ChangePasswordUser2 *r)
 
-NTSTATUS _samr_chgpasswd_user(pipes_struct *p, SAMR_Q_CHGPASSWD_USER *q_u, SAMR_R_CHGPASSWD_USER *r_u)
 {
+       NTSTATUS status;
        fstring user_name;
        fstring wks;
 
-       DEBUG(5,("_samr_chgpasswd_user: %d\n", __LINE__));
-
-       r_u->status = NT_STATUS_OK;
+       DEBUG(5,("_samr_ChangePasswordUser2: %d\n", __LINE__));
 
-       rpcstr_pull(user_name, q_u->uni_user_name.buffer, sizeof(user_name), q_u->uni_user_name.uni_str_len*2, 0);
-       rpcstr_pull(wks, q_u->uni_dest_host.buffer, sizeof(wks), q_u->uni_dest_host.uni_str_len*2,0);
+       fstrcpy(user_name, r->in.account->string);
+       fstrcpy(wks, r->in.server->string);
 
-       DEBUG(5,("samr_chgpasswd_user: user: %s wks: %s\n", user_name, wks));
+       DEBUG(5,("_samr_ChangePasswordUser2: user: %s wks: %s\n", user_name, wks));
 
        /*
         * Pass the user through the NT -> unix user mapping
@@ -1461,14 +1558,12 @@ NTSTATUS _samr_chgpasswd_user(pipes_struct *p, SAMR_Q_CHGPASSWD_USER *q_u, SAMR_
         * is case insensitive.
         */
 
-       r_u->status = pass_oem_change(user_name, q_u->lm_newpass.pass, q_u->lm_oldhash.hash,
-                               q_u->nt_newpass.pass, q_u->nt_oldhash.hash, NULL);
-
-       init_samr_r_chgpasswd_user(r_u, r_u->status);
+       status = pass_oem_change(user_name, r->in.lm_password->data, r->in.lm_verifier->hash,
+                               r->in.nt_password->data, r->in.nt_verifier->hash, NULL);
 
-       DEBUG(5,("_samr_chgpasswd_user: %d\n", __LINE__));
+       DEBUG(5,("_samr_ChangePasswordUser2: %d\n", __LINE__));
 
-       return r_u->status;
+       return status;
 }
 
 /*******************************************************************
@@ -1567,7 +1662,7 @@ NTSTATUS _samr_chgpasswd_user3(pipes_struct *p, SAMR_Q_CHGPASSWD_USER3 *q_u, SAM
 makes a SAMR_R_LOOKUP_RIDS structure.
 ********************************************************************/
 
-static BOOL make_samr_lookup_rids(TALLOC_CTX *ctx, uint32 num_names,
+static bool make_samr_lookup_rids(TALLOC_CTX *ctx, uint32 num_names,
                                  const char **names, UNIHDR **pp_hdr_name,
                                  UNISTR2 **pp_uni_name)
 {
@@ -1607,13 +1702,15 @@ static BOOL make_samr_lookup_rids(TALLOC_CTX *ctx, uint32 num_names,
 NTSTATUS _samr_lookup_rids(pipes_struct *p, SAMR_Q_LOOKUP_RIDS *q_u, SAMR_R_LOOKUP_RIDS *r_u)
 {
        const char **names;
-       uint32 *attrs = NULL;
+       enum lsa_SidType *attrs = NULL;
+       uint32 *wire_attrs = NULL;
        UNIHDR *hdr_name = NULL;
        UNISTR2 *uni_name = NULL;
        DOM_SID pol_sid;
-       int num_rids = q_u->num_rids1;
+       int num_rids = (int)q_u->num_rids1;
        uint32 acc_granted;
-       
+       int i;
+
        r_u->status = NT_STATUS_OK;
 
        DEBUG(5,("_samr_lookup_rids: %d\n", __LINE__));
@@ -1628,22 +1725,38 @@ NTSTATUS _samr_lookup_rids(pipes_struct *p, SAMR_Q_LOOKUP_RIDS *q_u, SAMR_R_LOOK
                return NT_STATUS_UNSUCCESSFUL;
        }
 
-       names = TALLOC_ZERO_ARRAY(p->mem_ctx, const char *, num_rids);
-       attrs = TALLOC_ZERO_ARRAY(p->mem_ctx, uint32, num_rids);
+       if (num_rids) {
+               names = TALLOC_ZERO_ARRAY(p->mem_ctx, const char *, num_rids);
+               attrs = TALLOC_ZERO_ARRAY(p->mem_ctx, enum lsa_SidType, num_rids);
+               wire_attrs = TALLOC_ZERO_ARRAY(p->mem_ctx, uint32, num_rids);
 
-       if ((num_rids != 0) && ((names == NULL) || (attrs == NULL)))
-               return NT_STATUS_NO_MEMORY;
+               if ((names == NULL) || (attrs == NULL) || (wire_attrs==NULL))
+                       return NT_STATUS_NO_MEMORY;
+       } else {
+               names = NULL;
+               attrs = NULL;
+               wire_attrs = NULL;
+       }
 
        become_root();  /* lookup_sid can require root privs */
        r_u->status = pdb_lookup_rids(&pol_sid, num_rids, q_u->rid,
                                      names, attrs);
        unbecome_root();
 
+       if ( NT_STATUS_EQUAL(r_u->status, NT_STATUS_NONE_MAPPED) && (num_rids == 0) ) {
+               r_u->status = NT_STATUS_OK;
+       }
+
        if(!make_samr_lookup_rids(p->mem_ctx, num_rids, names,
                                  &hdr_name, &uni_name))
                return NT_STATUS_NO_MEMORY;
 
-       init_samr_r_lookup_rids(r_u, num_rids, hdr_name, uni_name, attrs);
+       /* Convert from enum lsa_SidType to uint32 for wire format. */
+       for (i = 0; i < num_rids; i++) {
+               wire_attrs[i] = (uint32)attrs[i];
+       }
+
+       init_samr_r_lookup_rids(r_u, num_rids, hdr_name, uni_name, wire_attrs);
 
        DEBUG(5,("_samr_lookup_rids: %d\n", __LINE__));
 
@@ -1651,45 +1764,43 @@ NTSTATUS _samr_lookup_rids(pipes_struct *p, SAMR_Q_LOOKUP_RIDS *q_u, SAMR_R_LOOK
 }
 
 /*******************************************************************
- _samr_open_user. Safe - gives out no passwd info.
- ********************************************************************/
+ _samr_OpenUser
+********************************************************************/
 
-NTSTATUS _samr_open_user(pipes_struct *p, SAMR_Q_OPEN_USER *q_u, SAMR_R_OPEN_USER *r_u)
+NTSTATUS _samr_OpenUser(pipes_struct *p,
+                       struct samr_OpenUser *r)
 {
-       SAM_ACCOUNT *sampass=NULL;
+       struct samu *sampass=NULL;
        DOM_SID sid;
-       POLICY_HND domain_pol = q_u->domain_pol;
-       POLICY_HND *user_pol = &r_u->user_pol;
+       POLICY_HND domain_pol = *r->in.domain_handle;
+       POLICY_HND *user_pol = r->out.user_handle;
        struct samr_info *info = NULL;
        SEC_DESC *psd = NULL;
        uint32    acc_granted;
-       uint32    des_access = q_u->access_mask;
+       uint32    des_access = r->in.access_mask;
        size_t    sd_size;
-       BOOL ret;
+       bool ret;
        NTSTATUS nt_status;
        SE_PRIV se_rights;
 
-       r_u->status = NT_STATUS_OK;
-
        /* find the domain policy handle and get domain SID / access bits in the domain policy. */
        
        if ( !get_lsa_policy_samr_sid(p, &domain_pol, &sid, &acc_granted, NULL) )
                return NT_STATUS_INVALID_HANDLE;
        
        nt_status = access_check_samr_function( acc_granted, 
-               SA_RIGHT_DOMAIN_OPEN_ACCOUNT, "_samr_open_user" );
+               SA_RIGHT_DOMAIN_OPEN_ACCOUNT, "_samr_OpenUser" );
                
        if ( !NT_STATUS_IS_OK(nt_status) )
                return nt_status;
 
-       nt_status = pdb_init_sam_talloc(p->mem_ctx, &sampass);
-       
-       if (!NT_STATUS_IS_OK(nt_status))
-               return nt_status;
+       if ( !(sampass = samu_new( p->mem_ctx )) ) {
+               return NT_STATUS_NO_MEMORY;
+       }
 
        /* append the user's RID to it */
        
-       if (!sid_append_rid(&sid, q_u->user_rid))
+       if (!sid_append_rid(&sid, r->in.rid))
                return NT_STATUS_NO_SUCH_USER;
        
        /* check if access can be granted as requested by client. */
@@ -1702,7 +1813,7 @@ NTSTATUS _samr_open_user(pipes_struct *p, SAMR_Q_OPEN_USER *q_u, SAMR_R_OPEN_USE
        
        nt_status = access_check_samr_object(psd, p->pipe_user.nt_user_token, 
                &se_rights, GENERIC_RIGHTS_USER_WRITE, des_access, 
-               &acc_granted, "_samr_open_user");
+               &acc_granted, "_samr_OpenUser");
                
        if ( !NT_STATUS_IS_OK(nt_status) )
                return nt_status;
@@ -1716,7 +1827,7 @@ NTSTATUS _samr_open_user(pipes_struct *p, SAMR_Q_OPEN_USER *q_u, SAMR_R_OPEN_USE
                return NT_STATUS_NO_SUCH_USER;
        }
 
-       pdb_free_sam(&sampass);
+       TALLOC_FREE(sampass);
 
        /* associate the user's SID and access bits with the new handle. */
        if ((info = get_samr_info_by_sid(&sid)) == NULL)
@@ -1727,7 +1838,7 @@ NTSTATUS _samr_open_user(pipes_struct *p, SAMR_Q_OPEN_USER *q_u, SAMR_R_OPEN_USE
        if (!create_policy_hnd(p, user_pol, free_samr_info, (void *)info))
                return NT_STATUS_OBJECT_NAME_NOT_FOUND;
 
-       return r_u->status;
+       return NT_STATUS_OK;
 }
 
 /*************************************************************************
@@ -1736,22 +1847,19 @@ NTSTATUS _samr_open_user(pipes_struct *p, SAMR_Q_OPEN_USER *q_u, SAMR_R_OPEN_USE
 
 static NTSTATUS get_user_info_7(TALLOC_CTX *mem_ctx, SAM_USER_INFO_7 *id7, DOM_SID *user_sid)
 {
-       SAM_ACCOUNT *smbpass=NULL;
-       BOOL ret;
-       NTSTATUS nt_status;
+       struct samu *smbpass=NULL;
+       bool ret;
 
-       nt_status = pdb_init_sam_talloc(mem_ctx, &smbpass);
-       
-       if (!NT_STATUS_IS_OK(nt_status)) {
-               return nt_status;
+       if ( !(smbpass = samu_new( mem_ctx )) ) {
+               return NT_STATUS_NO_MEMORY;
        }
-
+       
        become_root();
        ret = pdb_getsampwsid(smbpass, user_sid);
        unbecome_root();
 
-       if (ret==False) {
-               DEBUG(4,("User %s not found\n", sid_string_static(user_sid)));
+       if ( !ret ) {
+               DEBUG(4,("User %s not found\n", sid_string_dbg(user_sid)));
                return NT_STATUS_NO_SUCH_USER;
        }
 
@@ -1760,7 +1868,7 @@ static NTSTATUS get_user_info_7(TALLOC_CTX *mem_ctx, SAM_USER_INFO_7 *id7, DOM_S
        ZERO_STRUCTP(id7);
        init_sam_user_info7(id7, pdb_get_username(smbpass) );
 
-       pdb_free_sam(&smbpass);
+       TALLOC_FREE(smbpass);
 
        return NT_STATUS_OK;
 }
@@ -1770,14 +1878,11 @@ static NTSTATUS get_user_info_7(TALLOC_CTX *mem_ctx, SAM_USER_INFO_7 *id7, DOM_S
  *************************************************************************/
 static NTSTATUS get_user_info_9(TALLOC_CTX *mem_ctx, SAM_USER_INFO_9 * id9, DOM_SID *user_sid)
 {
-       SAM_ACCOUNT *smbpass=NULL;
-       BOOL ret;
-       NTSTATUS nt_status;
-
-       nt_status = pdb_init_sam_talloc(mem_ctx, &smbpass);
+       struct samu *smbpass=NULL;
+       bool ret;
 
-       if (!NT_STATUS_IS_OK(nt_status)) {
-               return nt_status;
+       if ( !(smbpass = samu_new( mem_ctx )) ) {
+               return NT_STATUS_NO_MEMORY;
        }
 
        become_root();
@@ -1785,7 +1890,7 @@ static NTSTATUS get_user_info_9(TALLOC_CTX *mem_ctx, SAM_USER_INFO_9 * id9, DOM_
        unbecome_root();
 
        if (ret==False) {
-               DEBUG(4,("User %s not found\n", sid_string_static(user_sid)));
+               DEBUG(4,("User %s not found\n", sid_string_dbg(user_sid)));
                return NT_STATUS_NO_SUCH_USER;
        }
 
@@ -1794,7 +1899,7 @@ static NTSTATUS get_user_info_9(TALLOC_CTX *mem_ctx, SAM_USER_INFO_9 * id9, DOM_
        ZERO_STRUCTP(id9);
        init_sam_user_info9(id9, pdb_get_group_rid(smbpass) );
 
-       pdb_free_sam(&smbpass);
+       TALLOC_FREE(smbpass);
 
        return NT_STATUS_OK;
 }
@@ -1805,14 +1910,11 @@ static NTSTATUS get_user_info_9(TALLOC_CTX *mem_ctx, SAM_USER_INFO_9 * id9, DOM_
 
 static NTSTATUS get_user_info_16(TALLOC_CTX *mem_ctx, SAM_USER_INFO_16 *id16, DOM_SID *user_sid)
 {
-       SAM_ACCOUNT *smbpass=NULL;
-       BOOL ret;
-       NTSTATUS nt_status;
+       struct samu *smbpass=NULL;
+       bool ret;
 
-       nt_status = pdb_init_sam_talloc(mem_ctx, &smbpass);
-       
-       if (!NT_STATUS_IS_OK(nt_status)) {
-               return nt_status;
+       if ( !(smbpass = samu_new( mem_ctx )) ) {
+               return NT_STATUS_NO_MEMORY;
        }
 
        become_root();
@@ -1820,7 +1922,7 @@ static NTSTATUS get_user_info_16(TALLOC_CTX *mem_ctx, SAM_USER_INFO_16 *id16, DO
        unbecome_root();
 
        if (ret==False) {
-               DEBUG(4,("User %s not found\n", sid_string_static(user_sid)));
+               DEBUG(4,("User %s not found\n", sid_string_dbg(user_sid)));
                return NT_STATUS_NO_SUCH_USER;
        }
 
@@ -1829,7 +1931,7 @@ static NTSTATUS get_user_info_16(TALLOC_CTX *mem_ctx, SAM_USER_INFO_16 *id16, DO
        ZERO_STRUCTP(id16);
        init_sam_user_info16(id16, pdb_get_acct_ctrl(smbpass) );
 
-       pdb_free_sam(&smbpass);
+       TALLOC_FREE(smbpass);
 
        return NT_STATUS_OK;
 }
@@ -1842,9 +1944,8 @@ static NTSTATUS get_user_info_16(TALLOC_CTX *mem_ctx, SAM_USER_INFO_16 *id16, DO
 
 static NTSTATUS get_user_info_18(pipes_struct *p, TALLOC_CTX *mem_ctx, SAM_USER_INFO_18 * id18, DOM_SID *user_sid)
 {
-       SAM_ACCOUNT *smbpass=NULL;
-       BOOL ret;
-       NTSTATUS nt_status;
+       struct samu *smbpass=NULL;
+       bool ret;
 
        if (p->auth.auth_type != PIPE_AUTH_TYPE_NTLMSSP || p->auth.auth_type != PIPE_AUTH_TYPE_SPNEGO_NTLMSSP) {
                return NT_STATUS_ACCESS_DENIED;
@@ -1858,31 +1959,29 @@ static NTSTATUS get_user_info_18(pipes_struct *p, TALLOC_CTX *mem_ctx, SAM_USER_
         * Do *NOT* do become_root()/unbecome_root() here ! JRA.
         */
 
-       nt_status = pdb_init_sam_talloc(mem_ctx, &smbpass);
-       
-       if (!NT_STATUS_IS_OK(nt_status)) {
-               return nt_status;
+       if ( !(smbpass = samu_new( mem_ctx )) ) {
+               return NT_STATUS_NO_MEMORY;
        }
 
        ret = pdb_getsampwsid(smbpass, user_sid);
 
        if (ret == False) {
-               DEBUG(4, ("User %s not found\n", sid_string_static(user_sid)));
-               pdb_free_sam(&smbpass);
+               DEBUG(4, ("User %s not found\n", sid_string_dbg(user_sid)));
+               TALLOC_FREE(smbpass);
                return (geteuid() == (uid_t)0) ? NT_STATUS_NO_SUCH_USER : NT_STATUS_ACCESS_DENIED;
        }
 
        DEBUG(3,("User:[%s] 0x%x\n", pdb_get_username(smbpass), pdb_get_acct_ctrl(smbpass) ));
 
        if ( pdb_get_acct_ctrl(smbpass) & ACB_DISABLED) {
-               pdb_free_sam(&smbpass);
+               TALLOC_FREE(smbpass);
                return NT_STATUS_ACCOUNT_DISABLED;
        }
 
        ZERO_STRUCTP(id18);
        init_sam_user_info18(id18, pdb_get_lanman_passwd(smbpass), pdb_get_nt_passwd(smbpass));
        
-       pdb_free_sam(&smbpass);
+       TALLOC_FREE(smbpass);
 
        return NT_STATUS_OK;
 }
@@ -1893,17 +1992,19 @@ static NTSTATUS get_user_info_18(pipes_struct *p, TALLOC_CTX *mem_ctx, SAM_USER_
 
 static NTSTATUS get_user_info_20(TALLOC_CTX *mem_ctx, SAM_USER_INFO_20 *id20, DOM_SID *user_sid)
 {
-       SAM_ACCOUNT *sampass=NULL;
-       BOOL ret;
+       struct samu *sampass=NULL;
+       bool ret;
 
-       pdb_init_sam_talloc(mem_ctx, &sampass);
+       if ( !(sampass = samu_new( mem_ctx )) ) {
+               return NT_STATUS_NO_MEMORY;
+       }
 
        become_root();
        ret = pdb_getsampwsid(sampass, user_sid);
        unbecome_root();
 
        if (ret == False) {
-               DEBUG(4,("User %s not found\n", sid_string_static(user_sid)));
+               DEBUG(4,("User %s not found\n", sid_string_dbg(user_sid)));
                return NT_STATUS_NO_SUCH_USER;
        }
 
@@ -1914,7 +2015,7 @@ static NTSTATUS get_user_info_20(TALLOC_CTX *mem_ctx, SAM_USER_INFO_20 *id20, DO
        ZERO_STRUCTP(id20);
        init_sam_user_info20A(id20, sampass);
        
-       pdb_free_sam(&sampass);
+       TALLOC_FREE(sampass);
 
        return NT_STATUS_OK;
 }
@@ -1926,13 +2027,12 @@ static NTSTATUS get_user_info_20(TALLOC_CTX *mem_ctx, SAM_USER_INFO_20 *id20, DO
 static NTSTATUS get_user_info_21(TALLOC_CTX *mem_ctx, SAM_USER_INFO_21 *id21, 
                                 DOM_SID *user_sid, DOM_SID *domain_sid)
 {
-       SAM_ACCOUNT *sampass=NULL;
-       BOOL ret;
+       struct samu *sampass=NULL;
+       bool ret;
        NTSTATUS nt_status;
 
-       nt_status = pdb_init_sam_talloc(mem_ctx, &sampass);
-       if (!NT_STATUS_IS_OK(nt_status)) {
-               return nt_status;
+       if ( !(sampass = samu_new( mem_ctx )) ) {
+               return NT_STATUS_NO_MEMORY;
        }
 
        become_root();
@@ -1940,7 +2040,7 @@ static NTSTATUS get_user_info_21(TALLOC_CTX *mem_ctx, SAM_USER_INFO_21 *id21,
        unbecome_root();
 
        if (ret == False) {
-               DEBUG(4,("User %s not found\n", sid_string_static(user_sid)));
+               DEBUG(4,("User %s not found\n", sid_string_dbg(user_sid)));
                return NT_STATUS_NO_SUCH_USER;
        }
 
@@ -1951,9 +2051,9 @@ static NTSTATUS get_user_info_21(TALLOC_CTX *mem_ctx, SAM_USER_INFO_21 *id21,
        ZERO_STRUCTP(id21);
        nt_status = init_sam_user_info21A(id21, sampass, domain_sid);
        
-       pdb_free_sam(&sampass);
+       TALLOC_FREE(sampass);
 
-       return NT_STATUS_OK;
+       return nt_status;
 }
 
 /*******************************************************************
@@ -1980,7 +2080,8 @@ NTSTATUS _samr_query_userinfo(pipes_struct *p, SAMR_Q_QUERY_USERINFO *q_u, SAMR_
        if (!sid_check_is_in_our_domain(&info->sid))
                return NT_STATUS_OBJECT_TYPE_MISMATCH;
 
-       DEBUG(5,("_samr_query_userinfo: sid:%s\n", sid_string_static(&info->sid)));
+       DEBUG(5,("_samr_query_userinfo: sid:%s\n",
+                sid_string_dbg(&info->sid)));
 
        ctr = TALLOC_ZERO_P(p->mem_ctx, SAM_USERINFO_CTR);
        if (!ctr)
@@ -2062,7 +2163,7 @@ NTSTATUS _samr_query_userinfo(pipes_struct *p, SAMR_Q_QUERY_USERINFO *q_u, SAMR_
 
 NTSTATUS _samr_query_usergroups(pipes_struct *p, SAMR_Q_QUERY_USERGROUPS *q_u, SAMR_R_QUERY_USERGROUPS *r_u)
 {
-       SAM_ACCOUNT *sam_pass=NULL;
+       struct samu *sam_pass=NULL;
        DOM_SID  sid;
        DOM_SID *sids;
        DOM_GID dom_gid;
@@ -2072,8 +2173,9 @@ NTSTATUS _samr_query_usergroups(pipes_struct *p, SAMR_Q_QUERY_USERGROUPS *q_u, S
        gid_t *unix_gids;
        size_t i, num_gids;
        uint32 acc_granted;
-       BOOL ret;
+       bool ret;
        NTSTATUS result;
+       bool success = False;
 
        /*
         * from the SID in the request:
@@ -2102,49 +2204,53 @@ NTSTATUS _samr_query_usergroups(pipes_struct *p, SAMR_Q_QUERY_USERGROUPS *q_u, S
        if (!sid_check_is_in_our_domain(&sid))
                return NT_STATUS_OBJECT_TYPE_MISMATCH;
 
-       pdb_init_sam_talloc(p->mem_ctx, &sam_pass);
-       
+        if ( !(sam_pass = samu_new( p->mem_ctx )) ) {
+                return NT_STATUS_NO_MEMORY;
+        }
+
        become_root();
        ret = pdb_getsampwsid(sam_pass, &sid);
        unbecome_root();
 
        if (!ret) {
                DEBUG(10, ("pdb_getsampwsid failed for %s\n",
-                          sid_string_static(&sid)));
+                          sid_string_dbg(&sid)));
                return NT_STATUS_NO_SUCH_USER;
        }
 
        sids = NULL;
 
+       /* make both calls inside the root block */
        become_root();
        result = pdb_enum_group_memberships(p->mem_ctx, sam_pass,
                                            &sids, &unix_gids, &num_groups);
+       if ( NT_STATUS_IS_OK(result) ) {
+               success = sid_peek_check_rid(get_global_sam_sid(), 
+                                            pdb_get_group_sid(sam_pass),
+                                            &primary_group_rid);
+       }
        unbecome_root();
 
        if (!NT_STATUS_IS_OK(result)) {
                DEBUG(10, ("pdb_enum_group_memberships failed for %s\n",
-                          sid_string_static(&sid)));
+                          sid_string_dbg(&sid)));
                return result;
        }
 
-       gids = NULL;
-       num_gids = 0;
-
-       dom_gid.attr = (SE_GROUP_MANDATORY|SE_GROUP_ENABLED_BY_DEFAULT|
-                       SE_GROUP_ENABLED);
-
-       if (!sid_peek_check_rid(get_global_sam_sid(),
-                               pdb_get_group_sid(sam_pass),
-                               &primary_group_rid)) {
+       if ( !success ) {
                DEBUG(5, ("Group sid %s for user %s not in our domain\n",
-                         sid_string_static(pdb_get_group_sid(sam_pass)),
+                         sid_string_dbg(pdb_get_group_sid(sam_pass)),
                          pdb_get_username(sam_pass)));
-               pdb_free_sam(&sam_pass);
+               TALLOC_FREE(sam_pass);
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       dom_gid.g_rid = primary_group_rid;
+       gids = NULL;
+       num_gids = 0;
 
+       dom_gid.attr = (SE_GROUP_MANDATORY|SE_GROUP_ENABLED_BY_DEFAULT|
+                       SE_GROUP_ENABLED);
+       dom_gid.g_rid = primary_group_rid;
        ADD_TO_ARRAY(p->mem_ctx, DOM_GID, dom_gid, &gids, &num_gids);
 
        for (i=0; i<num_groups; i++) {
@@ -2152,7 +2258,7 @@ NTSTATUS _samr_query_usergroups(pipes_struct *p, SAMR_Q_QUERY_USERGROUPS *q_u, S
                if (!sid_peek_check_rid(get_global_sam_sid(),
                                        &(sids[i]), &dom_gid.g_rid)) {
                        DEBUG(10, ("Found sid %s not in our domain\n",
-                                  sid_string_static(&sids[i])));
+                                  sid_string_dbg(&sids[i])));
                        continue;
                }
 
@@ -2175,10 +2281,12 @@ NTSTATUS _samr_query_usergroups(pipes_struct *p, SAMR_Q_QUERY_USERGROUPS *q_u, S
 }
 
 /*******************************************************************
- _samr_query_dom_info
+ _samr_query_domain_info
  ********************************************************************/
 
-NTSTATUS _samr_query_dom_info(pipes_struct *p, SAMR_Q_QUERY_DOMAIN_INFO *q_u, SAMR_R_QUERY_DOMAIN_INFO *r_u)
+NTSTATUS _samr_query_domain_info(pipes_struct *p, 
+                                SAMR_Q_QUERY_DOMAIN_INFO *q_u, 
+                                SAMR_R_QUERY_DOMAIN_INFO *r_u)
 {
        struct samr_info *info = NULL;
        SAM_UNK_CTR *ctr;
@@ -2207,7 +2315,7 @@ NTSTATUS _samr_query_dom_info(pipes_struct *p, SAMR_Q_QUERY_DOMAIN_INFO *q_u, SA
 
        r_u->status = NT_STATUS_OK;
        
-       DEBUG(5,("_samr_query_dom_info: %d\n", __LINE__));
+       DEBUG(5,("_samr_query_domain_info: %d\n", __LINE__));
        
        /* find the policy handle.  open a policy on it. */
        if (!find_policy_by_hnd(p, &q_u->domain_pol, (void **)(void *)&info)) {
@@ -2295,11 +2403,17 @@ NTSTATUS _samr_query_dom_info(pipes_struct *p, SAMR_Q_QUERY_DOMAIN_INFO *q_u, SA
                        
                        init_unk_info3(&ctr->info.inf3, nt_logout);
                        break;
+               case 0x04:
+                       init_unk_info4(&ctr->info.inf4, lp_serverstring());
+                       break;
                case 0x05:
-                       init_unk_info5(&ctr->info.inf5, global_myname());
+                       init_unk_info5(&ctr->info.inf5, get_global_sam_name());
                        break;
                case 0x06:
-                       init_unk_info6(&ctr->info.inf6);
+                       /* NT returns its own name when a PDC. win2k and later
+                        * only the name of the PDC if itself is a BDC (samba4
+                        * idl) */
+                       init_unk_info6(&ctr->info.inf6, global_myname());
                        break;
                case 0x07:
                        server_role = ROLE_DOMAIN_PDC;
@@ -2356,9 +2470,9 @@ NTSTATUS _samr_query_dom_info(pipes_struct *p, SAMR_Q_QUERY_DOMAIN_INFO *q_u, SA
                }
        
 
-       init_samr_r_query_dom_info(r_u, q_u->switch_value, ctr, NT_STATUS_OK);
+       init_samr_r_query_domain_info(r_u, q_u->switch_value, ctr, NT_STATUS_OK);
        
-       DEBUG(5,("_samr_query_dom_info: %d\n", __LINE__));
+       DEBUG(5,("_samr_query_domain_info: %d\n", __LINE__));
        
        return r_u->status;
 }
@@ -2370,15 +2484,15 @@ NTSTATUS _samr_query_dom_info(pipes_struct *p, SAMR_Q_QUERY_DOMAIN_INFO *q_u, SA
 
 static NTSTATUS can_create(TALLOC_CTX *mem_ctx, const char *new_name)
 {
-       enum SID_NAME_USE type;
-       BOOL result;
+       enum lsa_SidType type;
+       bool result;
 
        DEBUG(10, ("Checking whether [%s] can be created\n", new_name));
 
        become_root();
-       /* Lookup in our local databases (only LOOKUP_NAME_ISOLATED set)
+       /* Lookup in our local databases (LOOKUP_NAME_REMOTE not set)
         * whether the name already exists */
-       result = lookup_name(mem_ctx, new_name, LOOKUP_NAME_ISOLATED,
+       result = lookup_name(mem_ctx, new_name, LOOKUP_NAME_LOCAL,
                             NULL, NULL, NULL, &type);
        unbecome_root();
 
@@ -2402,32 +2516,25 @@ static NTSTATUS can_create(TALLOC_CTX *mem_ctx, const char *new_name)
 }
 
 /*******************************************************************
- _samr_create_user
- Create an account, can be either a normal user or a machine.
- This funcion will need to be updated for bdc/domain trusts.
+ _samr_CreateUser2
  ********************************************************************/
 
-NTSTATUS _samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u,
-                          SAMR_R_CREATE_USER *r_u)
+NTSTATUS _samr_CreateUser2(pipes_struct *p,
+                          struct samr_CreateUser2 *r)
 {
-       SAM_ACCOUNT *sam_pass=NULL;
-       fstring account;
+       const char *account = NULL;
        DOM_SID sid;
-       pstring add_script;
-       POLICY_HND dom_pol = q_u->domain_pol;
-       UNISTR2 user_account = q_u->uni_name;
-       uint16 acb_info = q_u->acb_info;
-       POLICY_HND *user_pol = &r_u->user_pol;
+       POLICY_HND dom_pol = *r->in.domain_handle;
+       uint32_t acb_info = r->in.acct_flags;
+       POLICY_HND *user_pol = r->out.user_handle;
        struct samr_info *info = NULL;
-       BOOL ret;
        NTSTATUS nt_status;
-       struct passwd *pw;
        uint32 acc_granted;
        SEC_DESC *psd;
        size_t    sd_size;
        /* check this, when giving away 'add computer to domain' privs */
        uint32    des_access = GENERIC_RIGHTS_USER_ALL_ACCESS;
-       BOOL can_add_account = False;
+       bool can_add_account = False;
        SE_PRIV se_rights;
        DISP_INFO *disp_info = NULL;
 
@@ -2438,7 +2545,7 @@ NTSTATUS _samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u,
 
        nt_status = access_check_samr_function(acc_granted,
                                               SA_RIGHT_DOMAIN_CREATE_USER,
-                                              "_samr_create_user");
+                                              "_samr_CreateUser2");
        if (!NT_STATUS_IS_OK(nt_status)) {
                return nt_status;
        }
@@ -2450,33 +2557,20 @@ NTSTATUS _samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u,
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       rpcstr_pull(account, user_account.buffer, sizeof(account),
-                   user_account.uni_str_len*2, 0);
-       strlower_m(account);
+       account = r->in.account_name->string;
+       if (account == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
 
        nt_status = can_create(p->mem_ctx, account);
        if (!NT_STATUS_IS_OK(nt_status)) {
                return nt_status;
        }
 
-       /*********************************************************************
-        * HEADS UP!  If we have to create a new user account, we have to get
-        * a new RID from somewhere.  This used to be done by the passdb
-        * backend. It has been moved into idmap now.  Since idmap is now
-        * wrapped up behind winbind, this means you have to run winbindd if
-        * you want new accounts to get a new RID when "enable rid algorithm =
-        * no".  Tough.  We now have a uniform way of allocating RIDs
-        * regardless of what ever passdb backend people may use.  --jerry
-        * (2003-07-10)
-        *********************************************************************/
-
-       pw = Get_Pwnam(account);
-
        /* determine which user right we need to check based on the acb_info */
        
        if ( acb_info & ACB_WSTRUST )
        {
-               pstrcpy(add_script, lp_addmachine_script());
                se_priv_copy( &se_rights, &se_machine_account );
                can_add_account = user_has_privileges(
                        p->pipe_user.nt_user_token, &se_rights );
@@ -2486,7 +2580,6 @@ NTSTATUS _samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u,
        else if ( acb_info & ACB_NORMAL &&
                  (account[strlen(account)-1] != '$') )
        {
-               pstrcpy(add_script, lp_adduser_script());
                se_priv_copy( &se_rights, &se_add_users );
                can_add_account = user_has_privileges(
                        p->pipe_user.nt_user_token, &se_rights );
@@ -2494,7 +2587,6 @@ NTSTATUS _samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u,
        else    /* implicit assumption of a BDC or domain trust account here
                 * (we already check the flags earlier) */
        {
-               pstrcpy(add_script, lp_addmachine_script());
                if ( lp_enable_privileges() ) {
                        /* only Domain Admins can add a BDC or domain trust */
                        se_priv_copy( &se_rights, &se_priv_none );
@@ -2504,48 +2596,18 @@ NTSTATUS _samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u,
                }
        }
                
-       DEBUG(5, ("_samr_create_user: %s can add this account : %s\n",
-               p->pipe_user_name, can_add_account ? "True":"False" ));
+       DEBUG(5, ("_samr_CreateUser2: %s can add this account : %s\n",
+                 uidtoname(p->pipe_user.ut.uid),
+                 can_add_account ? "True":"False" ));
                
        /********** BEGIN Admin BLOCK **********/
 
        if ( can_add_account )
                become_root();
 
-       if ( !pw ) {
-               if (*add_script) {
-                       int add_ret;
-
-                       all_string_sub(add_script, "%u", account,
-                                      sizeof(add_script));
-                       add_ret = smbrun(add_script,NULL);
-                       DEBUG(add_ret ? 0 : 3,("_samr_create_user: Running "
-                                              "the command `%s' gave %d\n",
-                                              add_script, add_ret));
-               }
-       }
-
-       /* implicit call to getpwnam() next.  we have a valid SID coming out
-        * of this call */
+       nt_status = pdb_create_user(p->mem_ctx, account, acb_info,
+                                   r->out.rid);
 
-       flush_pwnam_cache();
-       nt_status = pdb_init_sam_new(&sam_pass, account);
-
-       /* this code is order such that we have no unnecessary retuns 
-          out of the admin block of code */    
-          
-       if ( NT_STATUS_IS_OK(nt_status) ) {
-               pdb_set_acct_ctrl(sam_pass, acb_info, PDB_CHANGED);
-       
-               if ( !(ret = pdb_add_sam_account(sam_pass)) ) {
-                       pdb_free_sam(&sam_pass);
-                       DEBUG(0, ("could not add user/computer %s to passdb. "
-                                 "Check permissions?\n", 
-                               account));
-                       nt_status = NT_STATUS_ACCESS_DENIED;
-               }
-       }
-               
        if ( can_add_account )
                unbecome_root();
 
@@ -2557,8 +2619,8 @@ NTSTATUS _samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u,
                return nt_status;
                        
        /* Get the user's SID */
-       
-       sid_copy(&sid, pdb_get_user_sid(sam_pass));
+
+       sid_compose(&sid, get_global_sam_sid(), *r->out.rid);
        
        make_samr_object_sd(p->mem_ctx, &psd, &sd_size, &usr_generic_mapping,
                            &sid, SAMR_USR_RIGHTS_WRITE_PW);
@@ -2566,7 +2628,7 @@ NTSTATUS _samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u,
        
        nt_status = access_check_samr_object(psd, p->pipe_user.nt_user_token, 
                &se_rights, GENERIC_RIGHTS_USER_WRITE, des_access, 
-               &acc_granted, "_samr_create_user");
+               &acc_granted, "_samr_CreateUser2");
                
        if ( !NT_STATUS_IS_OK(nt_status) ) {
                return nt_status;
@@ -2574,7 +2636,6 @@ NTSTATUS _samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u,
 
        /* associate the user's SID with the new handle. */
        if ((info = get_samr_info_by_sid(&sid)) == NULL) {
-               pdb_free_sam(&sam_pass);
                return NT_STATUS_NO_MEMORY;
        }
 
@@ -2584,18 +2645,13 @@ NTSTATUS _samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u,
 
        /* get a (unique) handle.  open a policy on it. */
        if (!create_policy_hnd(p, user_pol, free_samr_info, (void *)info)) {
-               pdb_free_sam(&sam_pass);
                return NT_STATUS_OBJECT_NAME_NOT_FOUND;
        }
 
        /* After a "set" ensure we have no cached display info. */
        force_flush_samr_cache(info->disp_info);
 
-       r_u->user_rid=pdb_get_user_rid(sam_pass);
-
-       r_u->access_granted = acc_granted;
-
-       pdb_free_sam(&sam_pass);
+       *r->out.access_granted = acc_granted;
 
        return NT_STATUS_OK;
 }
@@ -2838,7 +2894,8 @@ NTSTATUS _samr_lookup_domain(pipes_struct *p, SAMR_Q_LOOKUP_DOMAIN *q_u, SAMR_R_
                }
        }
 
-       DEBUG(2,("Returning domain sid for domain %s -> %s\n", domain_name, sid_string_static(&sid)));
+       DEBUG(2,("Returning domain sid for domain %s -> %s\n", domain_name,
+                sid_string_dbg(&sid)));
 
        init_samr_r_lookup_domain(r_u, &sid, r_u->status);
 
@@ -2849,7 +2906,7 @@ NTSTATUS _samr_lookup_domain(pipes_struct *p, SAMR_Q_LOOKUP_DOMAIN *q_u, SAMR_R_
 makes a SAMR_R_ENUM_DOMAINS structure.
 ********************************************************************/
 
-static BOOL make_enum_domains(TALLOC_CTX *ctx, SAM_ENTRY **pp_sam,
+static bool make_enum_domains(TALLOC_CTX *ctx, SAM_ENTRY **pp_sam,
                        UNISTR2 **pp_uni_name, uint32 num_sam_entries, fstring doms[])
 {
        uint32 i;
@@ -2916,32 +2973,31 @@ NTSTATUS _samr_enum_domains(pipes_struct *p, SAMR_Q_ENUM_DOMAINS *q_u, SAMR_R_EN
 }
 
 /*******************************************************************
api_samr_open_alias
_samr_OpenAlias
  ********************************************************************/
 
-NTSTATUS _samr_open_alias(pipes_struct *p, SAMR_Q_OPEN_ALIAS *q_u, SAMR_R_OPEN_ALIAS *r_u)
+NTSTATUS _samr_OpenAlias(pipes_struct *p,
+                        struct samr_OpenAlias *r)
 {
        DOM_SID sid;
-       POLICY_HND domain_pol = q_u->dom_pol;
-       uint32 alias_rid = q_u->rid_alias;
-       POLICY_HND *alias_pol = &r_u->pol;
+       POLICY_HND domain_pol = *r->in.domain_handle;
+       uint32 alias_rid = r->in.rid;
+       POLICY_HND *alias_pol = r->out.alias_handle;
        struct    samr_info *info = NULL;
        SEC_DESC *psd = NULL;
        uint32    acc_granted;
-       uint32    des_access = q_u->access_mask;
+       uint32    des_access = r->in.access_mask;
        size_t    sd_size;
        NTSTATUS  status;
        SE_PRIV se_rights;
 
-       r_u->status = NT_STATUS_OK;
-
        /* find the domain policy and get the SID / access bits stored in the domain policy */
        
        if ( !get_lsa_policy_samr_sid(p, &domain_pol, &sid, &acc_granted, NULL) )
                return NT_STATUS_INVALID_HANDLE;
        
        status = access_check_samr_function(acc_granted, 
-               SA_RIGHT_DOMAIN_OPEN_ACCOUNT, "_samr_open_alias");
+               SA_RIGHT_DOMAIN_OPEN_ACCOUNT, "_samr_OpenAlias");
                
        if ( !NT_STATUS_IS_OK(status) ) 
                return status;
@@ -2961,15 +3017,16 @@ NTSTATUS _samr_open_alias(pipes_struct *p, SAMR_Q_OPEN_ALIAS *q_u, SAMR_R_OPEN_A
        
        status = access_check_samr_object(psd, p->pipe_user.nt_user_token, 
                &se_rights, GENERIC_RIGHTS_ALIAS_WRITE, des_access, 
-               &acc_granted, "_samr_open_alias");
+               &acc_granted, "_samr_OpenAlias");
                
        if ( !NT_STATUS_IS_OK(status) )
                return status;
 
        {
                /* Check we actually have the requested alias */
-               enum SID_NAME_USE type;
-               BOOL result;
+               enum lsa_SidType type;
+               bool result;
+               gid_t gid;
 
                become_root();
                result = lookup_sid(NULL, &sid, NULL, NULL, &type);
@@ -2978,6 +3035,13 @@ NTSTATUS _samr_open_alias(pipes_struct *p, SAMR_Q_OPEN_ALIAS *q_u, SAMR_R_OPEN_A
                if (!result || (type != SID_NAME_ALIAS)) {
                        return NT_STATUS_NO_SUCH_ALIAS;
                }
+
+               /* make sure there is a mapping */
+               
+               if ( !sid_to_gid( &sid, &gid ) ) {
+                       return NT_STATUS_NO_SUCH_ALIAS;
+               }
+
        }
 
        /* associate the alias SID with the new handle. */
@@ -2990,27 +3054,27 @@ NTSTATUS _samr_open_alias(pipes_struct *p, SAMR_Q_OPEN_ALIAS *q_u, SAMR_R_OPEN_A
        if (!create_policy_hnd(p, alias_pol, free_samr_info, (void *)info))
                return NT_STATUS_OBJECT_NAME_NOT_FOUND;
 
-       return r_u->status;
+       return NT_STATUS_OK;
 }
 
 /*******************************************************************
  set_user_info_7
  ********************************************************************/
 static NTSTATUS set_user_info_7(TALLOC_CTX *mem_ctx,
-                               const SAM_USER_INFO_7 *id7, SAM_ACCOUNT *pwd)
+                               const SAM_USER_INFO_7 *id7, struct samu *pwd)
 {
        fstring new_name;
        NTSTATUS rc;
 
        if (id7 == NULL) {
                DEBUG(5, ("set_user_info_7: NULL id7\n"));
-               pdb_free_sam(&pwd);
+               TALLOC_FREE(pwd);
                return NT_STATUS_ACCESS_DENIED;
        }
 
        if(!rpcstr_pull(new_name, id7->uni_name.buffer, sizeof(new_name), id7->uni_name.uni_str_len*2, 0)) {
                DEBUG(5, ("set_user_info_7: failed to get new username\n"));
-               pdb_free_sam(&pwd);
+               TALLOC_FREE(pwd);
                return NT_STATUS_ACCESS_DENIED;
        }
 
@@ -3030,7 +3094,7 @@ static NTSTATUS set_user_info_7(TALLOC_CTX *mem_ctx,
 
        rc = pdb_rename_sam_account(pwd, new_name);
 
-       pdb_free_sam(&pwd);
+       TALLOC_FREE(pwd);
        return rc;
 }
 
@@ -3038,26 +3102,26 @@ static NTSTATUS set_user_info_7(TALLOC_CTX *mem_ctx,
  set_user_info_16
  ********************************************************************/
 
-static BOOL set_user_info_16(const SAM_USER_INFO_16 *id16, SAM_ACCOUNT *pwd)
+static bool set_user_info_16(const SAM_USER_INFO_16 *id16, struct samu *pwd)
 {
        if (id16 == NULL) {
                DEBUG(5, ("set_user_info_16: NULL id16\n"));
-               pdb_free_sam(&pwd);
+               TALLOC_FREE(pwd);
                return False;
        }
        
        /* FIX ME: check if the value is really changed --metze */
        if (!pdb_set_acct_ctrl(pwd, id16->acb_info, PDB_CHANGED)) {
-               pdb_free_sam(&pwd);
+               TALLOC_FREE(pwd);
                return False;
        }
 
        if(!NT_STATUS_IS_OK(pdb_update_sam_account(pwd))) {
-               pdb_free_sam(&pwd);
+               TALLOC_FREE(pwd);
                return False;
        }
 
-       pdb_free_sam(&pwd);
+       TALLOC_FREE(pwd);
 
        return True;
 }
@@ -3066,77 +3130,42 @@ static BOOL set_user_info_16(const SAM_USER_INFO_16 *id16, SAM_ACCOUNT *pwd)
  set_user_info_18
  ********************************************************************/
 
-static BOOL set_user_info_18(SAM_USER_INFO_18 *id18, SAM_ACCOUNT *pwd)
+static bool set_user_info_18(SAM_USER_INFO_18 *id18, struct samu *pwd)
 {
 
        if (id18 == NULL) {
                DEBUG(2, ("set_user_info_18: id18 is NULL\n"));
-               pdb_free_sam(&pwd);
+               TALLOC_FREE(pwd);
                return False;
        }
  
        if (!pdb_set_lanman_passwd (pwd, id18->lm_pwd, PDB_CHANGED)) {
-               pdb_free_sam(&pwd);
+               TALLOC_FREE(pwd);
                return False;
        }
        if (!pdb_set_nt_passwd     (pwd, id18->nt_pwd, PDB_CHANGED)) {
-               pdb_free_sam(&pwd);
+               TALLOC_FREE(pwd);
                return False;
        }
-       if (!pdb_set_pass_changed_now (pwd)) {
-               pdb_free_sam(&pwd);
+       if (!pdb_set_pass_last_set_time (pwd, time(NULL), PDB_CHANGED)) {
+               TALLOC_FREE(pwd);
                return False; 
        }
  
        if(!NT_STATUS_IS_OK(pdb_update_sam_account(pwd))) {
-               pdb_free_sam(&pwd);
+               TALLOC_FREE(pwd);
                return False;
        }
 
-       pdb_free_sam(&pwd);
-       return True;
-}
-
-/*******************************************************************
- The GROUPSID field in the SAM_ACCOUNT changed. Try to tell unix.
- ********************************************************************/
-static BOOL set_unix_primary_group(SAM_ACCOUNT *sampass)
-{
-       struct group *grp;
-       gid_t gid;
-
-       if (!sid_to_gid(pdb_get_group_sid(sampass), &gid)) {
-               DEBUG(2,("Could not get gid for primary group of "
-                        "user %s\n", pdb_get_username(sampass)));
-               return False;
-       }
-
-       grp = getgrgid(gid);
-
-       if (grp == NULL) {
-               DEBUG(2,("Could not find primary group %lu for "
-                        "user %s\n", (unsigned long)gid, 
-                        pdb_get_username(sampass)));
-               return False;
-       }
-
-       if (smb_set_primary_group(grp->gr_name,
-                                 pdb_get_username(sampass)) != 0) {
-               DEBUG(2,("Could not set primary group for user %s to "
-                        "%s\n",
-                        pdb_get_username(sampass), grp->gr_name));
-               return False;
-       }
-
+       TALLOC_FREE(pwd);
        return True;
 }
-       
 
 /*******************************************************************
  set_user_info_20
  ********************************************************************/
 
-static BOOL set_user_info_20(SAM_USER_INFO_20 *id20, SAM_ACCOUNT *pwd)
+static bool set_user_info_20(SAM_USER_INFO_20 *id20, struct samu *pwd)
 {
        if (id20 == NULL) {
                DEBUG(5, ("set_user_info_20: NULL id20\n"));
@@ -3147,11 +3176,11 @@ static BOOL set_user_info_20(SAM_USER_INFO_20 *id20, SAM_ACCOUNT *pwd)
 
        /* write the change out */
        if(!NT_STATUS_IS_OK(pdb_update_sam_account(pwd))) {
-               pdb_free_sam(&pwd);
+               TALLOC_FREE(pwd);
                return False;
        }
 
-       pdb_free_sam(&pwd);
+       TALLOC_FREE(pwd);
 
        return True;
 }
@@ -3159,14 +3188,52 @@ static BOOL set_user_info_20(SAM_USER_INFO_20 *id20, SAM_ACCOUNT *pwd)
  set_user_info_21
  ********************************************************************/
 
-static BOOL set_user_info_21(SAM_USER_INFO_21 *id21, SAM_ACCOUNT *pwd)
+static NTSTATUS set_user_info_21(TALLOC_CTX *mem_ctx, SAM_USER_INFO_21 *id21,
+                                struct samu *pwd)
 {
+       fstring new_name;
+       NTSTATUS status;
+       
        if (id21 == NULL) {
                DEBUG(5, ("set_user_info_21: NULL id21\n"));
-               return False;
+               return NT_STATUS_INVALID_PARAMETER;
        }
+
+       /* we need to separately check for an account rename first */
+       
+       if (rpcstr_pull(new_name, id21->uni_user_name.buffer, 
+               sizeof(new_name), id21->uni_user_name.uni_str_len*2, 0) 
+               && (!strequal(new_name, pdb_get_username(pwd)))) 
+       {
+
+               /* check to see if the new username already exists.  Note: we can't
+                  reliably lock all backends, so there is potentially the 
+                  possibility that a user can be created in between this check and
+                  the rename.  The rename should fail, but may not get the
+                  exact same failure status code.  I think this is small enough
+                  of a window for this type of operation and the results are
+                  simply that the rename fails with a slightly different status
+                  code (like UNSUCCESSFUL instead of ALREADY_EXISTS). */
+
+               status = can_create(mem_ctx, new_name);
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
+               }
+
+               status = pdb_rename_sam_account(pwd, new_name);
+
+               if (!NT_STATUS_IS_OK(status)) {
+                       DEBUG(0,("set_user_info_21: failed to rename account: %s\n", 
+                               nt_errstr(status)));
+                       TALLOC_FREE(pwd);
+                       return status;
+               }
+
+               /* set the new username so that later 
+                  functions can work on the new account */
+               pdb_set_username(pwd, new_name, PDB_SET);
+       }
+
        copy_id21_to_sam_passwd(pwd, id21);
  
        /*
@@ -3176,114 +3243,148 @@ static BOOL set_user_info_21(SAM_USER_INFO_21 *id21, SAM_ACCOUNT *pwd)
         * id21.  I don't know if they need to be set.    --jerry
         */
  
-       if (IS_SAM_CHANGED(pwd, PDB_GROUPSID))
-               set_unix_primary_group(pwd);
+       if ( IS_SAM_CHANGED(pwd, PDB_GROUPSID) ) {
+               status = pdb_set_unix_primary_group(mem_ctx, pwd);
+               if ( !NT_STATUS_IS_OK(status) ) {
+                       return status;
+               }
+       }
+       
+       /* Don't worry about writing out the user account since the
+          primary group SID is generated solely from the user's Unix 
+          primary group. */
 
        /* write the change out */
-       if(!NT_STATUS_IS_OK(pdb_update_sam_account(pwd))) {
-               pdb_free_sam(&pwd);
-               return False;
+       if(!NT_STATUS_IS_OK(status = pdb_update_sam_account(pwd))) {
+               TALLOC_FREE(pwd);
+               return status;
        }
 
-       pdb_free_sam(&pwd);
+       TALLOC_FREE(pwd);
 
-       return True;
+       return NT_STATUS_OK;
 }
 
 /*******************************************************************
  set_user_info_23
  ********************************************************************/
 
-static BOOL set_user_info_23(SAM_USER_INFO_23 *id23, SAM_ACCOUNT *pwd)
+static NTSTATUS set_user_info_23(TALLOC_CTX *mem_ctx, SAM_USER_INFO_23 *id23,
+                                struct samu *pwd)
 {
-       pstring plaintext_buf;
-       uint32 len;
+       char *plaintext_buf = NULL;
+       uint32 len = 0;
        uint16 acct_ctrl;
+       NTSTATUS status;
+
        if (id23 == NULL) {
                DEBUG(5, ("set_user_info_23: NULL id23\n"));
-               return False;
+               return NT_STATUS_INVALID_PARAMETER;
        }
+
        DEBUG(5, ("Attempting administrator password change (level 23) for user %s\n",
                  pdb_get_username(pwd)));
 
        acct_ctrl = pdb_get_acct_ctrl(pwd);
 
-       if (!decode_pw_buffer(id23->pass, plaintext_buf, 256, &len, STR_UNICODE)) {
-               pdb_free_sam(&pwd);
-               return False;
+       if (!decode_pw_buffer(mem_ctx,
+                               id23->pass,
+                               &plaintext_buf,
+                               &len,
+                               STR_UNICODE)) {
+               TALLOC_FREE(pwd);
+               return NT_STATUS_INVALID_PARAMETER;
        }
-  
+
        if (!pdb_set_plaintext_passwd (pwd, plaintext_buf)) {
-               pdb_free_sam(&pwd);
-               return False;
+               TALLOC_FREE(pwd);
+               return NT_STATUS_ACCESS_DENIED;
        }
+
        copy_id23_to_sam_passwd(pwd, id23);
+
        /* if it's a trust account, don't update /etc/passwd */
        if (    ( (acct_ctrl &  ACB_DOMTRUST) == ACB_DOMTRUST ) ||
                ( (acct_ctrl &  ACB_WSTRUST) ==  ACB_WSTRUST) ||
                ( (acct_ctrl &  ACB_SVRTRUST) ==  ACB_SVRTRUST) ) {
-               DEBUG(5, ("Changing trust account or non-unix-user password, not updating /etc/passwd\n"));
+               DEBUG(5, ("Changing trust account.  Not updating /etc/passwd\n"));
        } else  {
                /* update the UNIX password */
                if (lp_unix_password_sync() ) {
-                       struct passwd *passwd = Get_Pwnam(pdb_get_username(pwd));
-                       if (!passwd) {
+                       struct passwd *passwd;
+                       if (pdb_get_username(pwd) == NULL) {
+                               DEBUG(1, ("chgpasswd: User without name???\n"));
+                               TALLOC_FREE(pwd);
+                               return NT_STATUS_ACCESS_DENIED;
+                       }
+
+                       passwd = Get_Pwnam_alloc(pwd, pdb_get_username(pwd));
+                       if (passwd == NULL) {
                                DEBUG(1, ("chgpasswd: Username does not exist in system !?!\n"));
                        }
-                       
+
                        if(!chgpasswd(pdb_get_username(pwd), passwd, "", plaintext_buf, True)) {
-                               pdb_free_sam(&pwd);
-                               return False;
+                               TALLOC_FREE(pwd);
+                               return NT_STATUS_ACCESS_DENIED;
                        }
+                       TALLOC_FREE(passwd);
                }
        }
-       ZERO_STRUCT(plaintext_buf);
-       if (IS_SAM_CHANGED(pwd, PDB_GROUPSID))
-               set_unix_primary_group(pwd);
 
-       if(!NT_STATUS_IS_OK(pdb_update_sam_account(pwd))) {
-               pdb_free_sam(&pwd);
-               return False;
+       memset(plaintext_buf, '\0', strlen(plaintext_buf));
+
+       if (IS_SAM_CHANGED(pwd, PDB_GROUPSID) &&
+           (!NT_STATUS_IS_OK(status =  pdb_set_unix_primary_group(mem_ctx,
+                                                                  pwd)))) {
+               TALLOC_FREE(pwd);
+               return status;
        }
-       pdb_free_sam(&pwd);
 
-       return True;
+       if(!NT_STATUS_IS_OK(status = pdb_update_sam_account(pwd))) {
+               TALLOC_FREE(pwd);
+               return status;
+       }
+
+       TALLOC_FREE(pwd);
+
+       return NT_STATUS_OK;
 }
 
 /*******************************************************************
  set_user_info_pw
  ********************************************************************/
 
-static BOOL set_user_info_pw(uint8 *pass, SAM_ACCOUNT *pwd)
+static bool set_user_info_pw(uint8 *pass, struct samu *pwd)
 {
-       uint32 len;
-       pstring plaintext_buf;
-       uint16 acct_ctrl;
+       uint32 len = 0;
+       char *plaintext_buf = NULL;
+       uint32 acct_ctrl;
+       time_t last_set_time;
+       enum pdb_value_state last_set_state;
+
        DEBUG(5, ("Attempting administrator password change for user %s\n",
                  pdb_get_username(pwd)));
 
        acct_ctrl = pdb_get_acct_ctrl(pwd);
-
-       ZERO_STRUCT(plaintext_buf);
-       if (!decode_pw_buffer(pass, plaintext_buf, 256, &len, STR_UNICODE)) {
-               pdb_free_sam(&pwd);
+       /* we need to know if it's expired, because this is an admin change, not a
+          user change, so it's still expired when we're done */
+       last_set_state = pdb_get_init_flags(pwd, PDB_PASSLASTSET);
+       last_set_time = pdb_get_pass_last_set_time(pwd);
+
+       if (!decode_pw_buffer(talloc_tos(),
+                               pass,
+                               &plaintext_buf,
+                               &len,
+                               STR_UNICODE)) {
+               TALLOC_FREE(pwd);
                return False;
        }
 
        if (!pdb_set_plaintext_passwd (pwd, plaintext_buf)) {
-               pdb_free_sam(&pwd);
+               TALLOC_FREE(pwd);
                return False;
        }
+
        /* if it's a trust account, don't update /etc/passwd */
        if ( ( (acct_ctrl &  ACB_DOMTRUST) == ACB_DOMTRUST ) ||
                ( (acct_ctrl &  ACB_WSTRUST) ==  ACB_WSTRUST) ||
@@ -3292,48 +3393,103 @@ static BOOL set_user_info_pw(uint8 *pass, SAM_ACCOUNT *pwd)
        } else {
                /* update the UNIX password */
                if (lp_unix_password_sync()) {
-                       struct passwd *passwd = Get_Pwnam(pdb_get_username(pwd));
-                       if (!passwd) {
+                       struct passwd *passwd;
+
+                       if (pdb_get_username(pwd) == NULL) {
+                               DEBUG(1, ("chgpasswd: User without name???\n"));
+                               TALLOC_FREE(pwd);
+                               return False;
+                       }
+
+                       passwd = Get_Pwnam_alloc(pwd, pdb_get_username(pwd));
+                       if (passwd == NULL) {
                                DEBUG(1, ("chgpasswd: Username does not exist in system !?!\n"));
                        }
-                       
+
                        if(!chgpasswd(pdb_get_username(pwd), passwd, "", plaintext_buf, True)) {
-                               pdb_free_sam(&pwd);
+                               TALLOC_FREE(pwd);
                                return False;
                        }
+                       TALLOC_FREE(passwd);
                }
        }
-       ZERO_STRUCT(plaintext_buf);
+
+       memset(plaintext_buf, '\0', strlen(plaintext_buf));
+
+       /* restore last set time as this is an admin change, not a user pw change */
+       pdb_set_pass_last_set_time (pwd, last_set_time, last_set_state);
+
        DEBUG(5,("set_user_info_pw: pdb_update_pwd()\n"));
+
        /* update the SAMBA password */
        if(!NT_STATUS_IS_OK(pdb_update_sam_account(pwd))) {
-               pdb_free_sam(&pwd);
+               TALLOC_FREE(pwd);
                return False;
        }
 
-       pdb_free_sam(&pwd);
+       TALLOC_FREE(pwd);
 
        return True;
 }
 
+/*******************************************************************
+ set_user_info_25
+ ********************************************************************/
+
+static NTSTATUS set_user_info_25(TALLOC_CTX *mem_ctx, SAM_USER_INFO_25 *id25,
+                                struct samu *pwd)
+{
+       NTSTATUS status;
+       
+       if (id25 == NULL) {
+               DEBUG(5, ("set_user_info_25: NULL id25\n"));
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+
+       copy_id25_to_sam_passwd(pwd, id25);
+       /* write the change out */
+       if(!NT_STATUS_IS_OK(status = pdb_update_sam_account(pwd))) {
+               TALLOC_FREE(pwd);
+               return status;
+       }
+
+       /*
+        * We need to "pdb_update_sam_account" before the unix primary group
+        * is set, because the idealx scripts would also change the
+        * sambaPrimaryGroupSid using the ldap replace method. pdb_ldap uses
+        * the delete explicit / add explicit, which would then fail to find
+        * the previous primaryGroupSid value.
+        */
+
+       if ( IS_SAM_CHANGED(pwd, PDB_GROUPSID) ) {
+               status = pdb_set_unix_primary_group(mem_ctx, pwd);
+               if ( !NT_STATUS_IS_OK(status) ) {
+                       return status;
+               }
+       }
+       
+       /* WARNING: No TALLOC_FREE(pwd), we are about to set the password
+        * hereafter! */
+
+       return NT_STATUS_OK;
+}
+
 /*******************************************************************
  samr_reply_set_userinfo
  ********************************************************************/
 
 NTSTATUS _samr_set_userinfo(pipes_struct *p, SAMR_Q_SET_USERINFO *q_u, SAMR_R_SET_USERINFO *r_u)
 {
-       SAM_ACCOUNT *pwd = NULL;
+       struct samu *pwd = NULL;
        DOM_SID sid;
        POLICY_HND *pol = &q_u->pol;
        uint16 switch_value = q_u->switch_value;
        SAM_USERINFO_CTR *ctr = q_u->ctr;
        uint32 acc_granted;
        uint32 acc_required;
-       BOOL ret;
-       BOOL has_enough_rights = False;
+       bool ret;
+       bool has_enough_rights = False;
        uint32 acb_info;
        DISP_INFO *disp_info = NULL;
 
@@ -3345,29 +3501,47 @@ NTSTATUS _samr_set_userinfo(pipes_struct *p, SAMR_Q_SET_USERINFO *q_u, SAMR_R_SE
        if (!get_lsa_policy_samr_sid(p, pol, &sid, &acc_granted, &disp_info))
                return NT_STATUS_INVALID_HANDLE;
 
-       /* observed when joining an XP client to a Samba domain */
+       /* This is tricky.  A WinXP domain join sets 
+         (SA_RIGHT_USER_SET_PASSWORD|SA_RIGHT_USER_SET_ATTRIBUTES|SA_RIGHT_USER_ACCT_FLAGS_EXPIRY)
+         The MMC lusrmgr plugin includes these perms and more in the SamrOpenUser().  But the 
+         standard Win32 API calls just ask for SA_RIGHT_USER_SET_PASSWORD in the SamrOpenUser().  
+         This should be enough for levels 18, 24, 25,& 26.  Info level 23 can set more so 
+         we'll use the set from the WinXP join as the basis. */
+       
+       switch (switch_value) {
+       case 18:
+       case 24:
+       case 25:
+       case 26:
+               acc_required = SA_RIGHT_USER_SET_PASSWORD;
+               break;
+       default:
+               acc_required = SA_RIGHT_USER_SET_PASSWORD | SA_RIGHT_USER_SET_ATTRIBUTES | SA_RIGHT_USER_ACCT_FLAGS_EXPIRY;
+               break;
+       }
        
-       acc_required = SA_RIGHT_USER_SET_PASSWORD | SA_RIGHT_USER_SET_ATTRIBUTES | SA_RIGHT_USER_ACCT_FLAGS_EXPIRY;     
-
        if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, acc_required, "_samr_set_userinfo"))) {
                return r_u->status;
        }
 
-       DEBUG(5, ("_samr_set_userinfo: sid:%s, level:%d\n", sid_string_static(&sid), switch_value));
+       DEBUG(5, ("_samr_set_userinfo: sid:%s, level:%d\n",
+                 sid_string_dbg(&sid), switch_value));
 
        if (ctr == NULL) {
                DEBUG(5, ("_samr_set_userinfo: NULL info level\n"));
                return NT_STATUS_INVALID_INFO_CLASS;
        }
        
-       pdb_init_sam(&pwd);     
+       if ( !(pwd = samu_new( NULL )) ) {
+               return NT_STATUS_NO_MEMORY;
+       }
        
        become_root();
        ret = pdb_getsampwsid(pwd, &sid);
        unbecome_root();
        
        if ( !ret ) {
-               pdb_free_sam(&pwd);
+               TALLOC_FREE(pwd);
                return NT_STATUS_NO_SUCH_USER;
        }
        
@@ -3385,7 +3559,8 @@ NTSTATUS _samr_set_userinfo(pipes_struct *p, SAMR_Q_SET_USERINFO *q_u, SAMR_R_SE
        }
        
        DEBUG(5, ("_samr_set_userinfo: %s does%s possess sufficient rights\n",
-               p->pipe_user_name, has_enough_rights ? "" : " not"));
+                 uidtoname(p->pipe_user.ut.uid),
+                 has_enough_rights ? "" : " not"));
 
        /* ================ BEGIN SeMachineAccountPrivilege BLOCK ================ */
        
@@ -3406,7 +3581,7 @@ NTSTATUS _samr_set_userinfo(pipes_struct *p, SAMR_Q_SET_USERINFO *q_u, SAMR_R_SE
                        }
                        SamOEMhashBlob(ctr->info.id24->pass, 516, &p->session_key);
 
-                       dump_data(100, (char *)ctr->info.id24->pass, 516);
+                       dump_data(100, ctr->info.id24->pass, 516);
 
                        if (!set_user_info_pw(ctr->info.id24->pass, pwd))
                                r_u->status = NT_STATUS_ACCESS_DENIED;
@@ -3418,8 +3593,13 @@ NTSTATUS _samr_set_userinfo(pipes_struct *p, SAMR_Q_SET_USERINFO *q_u, SAMR_R_SE
                        }
                        encode_or_decode_arc4_passwd_buffer(ctr->info.id25->pass, &p->session_key);
 
-                       dump_data(100, (char *)ctr->info.id25->pass, 532);
+                       dump_data(100, ctr->info.id25->pass, 532);
 
+                       r_u->status = set_user_info_25(p->mem_ctx,
+                                                      ctr->info.id25, pwd);
+                       if (!NT_STATUS_IS_OK(r_u->status)) {
+                               goto done;
+                       }
                        if (!set_user_info_pw(ctr->info.id25->pass, pwd))
                                r_u->status = NT_STATUS_ACCESS_DENIED;
                        break;
@@ -3430,7 +3610,7 @@ NTSTATUS _samr_set_userinfo(pipes_struct *p, SAMR_Q_SET_USERINFO *q_u, SAMR_R_SE
                        }
                        encode_or_decode_arc4_passwd_buffer(ctr->info.id26->pass, &p->session_key);
 
-                       dump_data(100, (char *)ctr->info.id26->pass, 516);
+                       dump_data(100, ctr->info.id26->pass, 516);
 
                        if (!set_user_info_pw(ctr->info.id26->pass, pwd))
                                r_u->status = NT_STATUS_ACCESS_DENIED;
@@ -3442,16 +3622,17 @@ NTSTATUS _samr_set_userinfo(pipes_struct *p, SAMR_Q_SET_USERINFO *q_u, SAMR_R_SE
                        }
                        SamOEMhashBlob(ctr->info.id23->pass, 516, &p->session_key);
 
-                       dump_data(100, (char *)ctr->info.id23->pass, 516);
+                       dump_data(100, ctr->info.id23->pass, 516);
 
-                       if (!set_user_info_23(ctr->info.id23, pwd))
-                               r_u->status = NT_STATUS_ACCESS_DENIED;
+                       r_u->status = set_user_info_23(p->mem_ctx,
+                                                      ctr->info.id23, pwd);
                        break;
 
                default:
                        r_u->status = NT_STATUS_INVALID_INFO_CLASS;
        }
 
+ done:
        
        if ( has_enough_rights )                                
                unbecome_root();
@@ -3471,15 +3652,15 @@ NTSTATUS _samr_set_userinfo(pipes_struct *p, SAMR_Q_SET_USERINFO *q_u, SAMR_R_SE
 
 NTSTATUS _samr_set_userinfo2(pipes_struct *p, SAMR_Q_SET_USERINFO2 *q_u, SAMR_R_SET_USERINFO2 *r_u)
 {
-       SAM_ACCOUNT *pwd = NULL;
+       struct samu *pwd = NULL;
        DOM_SID sid;
        SAM_USERINFO_CTR *ctr = q_u->ctr;
        POLICY_HND *pol = &q_u->pol;
        uint16 switch_value = q_u->switch_value;
        uint32 acc_granted;
        uint32 acc_required;
-       BOOL ret;
-       BOOL has_enough_rights = False;
+       bool ret;
+       bool has_enough_rights = False;
        uint32 acb_info;
        DISP_INFO *disp_info = NULL;
 
@@ -3491,15 +3672,21 @@ NTSTATUS _samr_set_userinfo2(pipes_struct *p, SAMR_Q_SET_USERINFO2 *q_u, SAMR_R_
        if (!get_lsa_policy_samr_sid(p, pol, &sid, &acc_granted, &disp_info))
                return NT_STATUS_INVALID_HANDLE;
 
-       /* observed when joining XP client to Samba domain */
                
+#if 0  /* this really should be applied on a per info level basis   --jerry */
+
+       /* observed when joining XP client to Samba domain */
        acc_required = SA_RIGHT_USER_SET_PASSWORD | SA_RIGHT_USER_SET_ATTRIBUTES | SA_RIGHT_USER_ACCT_FLAGS_EXPIRY;
+#else
+       acc_required = SA_RIGHT_USER_SET_ATTRIBUTES;
+#endif
        
        if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, acc_required, "_samr_set_userinfo2"))) {
                return r_u->status;
        }
 
-       DEBUG(5, ("samr_reply_set_userinfo2: sid:%s\n", sid_string_static(&sid)));
+       DEBUG(5, ("samr_reply_set_userinfo2: sid:%s\n",
+                 sid_string_dbg(&sid)));
 
        if (ctr == NULL) {
                DEBUG(5, ("samr_reply_set_userinfo2: NULL info level\n"));
@@ -3508,14 +3695,16 @@ NTSTATUS _samr_set_userinfo2(pipes_struct *p, SAMR_Q_SET_USERINFO2 *q_u, SAMR_R_
 
        switch_value=ctr->switch_value;
 
-       pdb_init_sam(&pwd);     
-       
+       if ( !(pwd = samu_new( NULL )) ) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
        become_root();
        ret = pdb_getsampwsid(pwd, &sid);
        unbecome_root();
        
        if ( !ret ) {
-               pdb_free_sam(&pwd);
+               TALLOC_FREE(pwd);
                return NT_STATUS_NO_SUCH_USER;
        }
        
@@ -3530,7 +3719,8 @@ NTSTATUS _samr_set_userinfo2(pipes_struct *p, SAMR_Q_SET_USERINFO2 *q_u, SAMR_R_
        }
        
        DEBUG(5, ("_samr_set_userinfo2: %s does%s possess sufficient rights\n",
-               p->pipe_user_name, has_enough_rights ? "" : " not"));
+                 uidtoname(p->pipe_user.ut.uid),
+                 has_enough_rights ? "" : " not"));
 
        /* ================ BEGIN SeMachineAccountPrivilege BLOCK ================ */
        
@@ -3558,8 +3748,8 @@ NTSTATUS _samr_set_userinfo2(pipes_struct *p, SAMR_Q_SET_USERINFO2 *q_u, SAMR_R_
                                r_u->status = NT_STATUS_ACCESS_DENIED;
                        break;
                case 21:
-                       if (!set_user_info_21(ctr->info.id21, pwd))
-                               return NT_STATUS_ACCESS_DENIED;
+                       r_u->status = set_user_info_21(p->mem_ctx,
+                                                      ctr->info.id21, pwd);
                        break;
                case 23:
                        if (!p->session_key.length) {
@@ -3567,10 +3757,10 @@ NTSTATUS _samr_set_userinfo2(pipes_struct *p, SAMR_Q_SET_USERINFO2 *q_u, SAMR_R_
                        }
                        SamOEMhashBlob(ctr->info.id23->pass, 516, &p->session_key);
 
-                       dump_data(100, (char *)ctr->info.id23->pass, 516);
+                       dump_data(100, ctr->info.id23->pass, 516);
 
-                       if (!set_user_info_23(ctr->info.id23, pwd))
-                               r_u->status = NT_STATUS_ACCESS_DENIED;
+                       r_u->status = set_user_info_23(p->mem_ctx,
+                                                      ctr->info.id23, pwd);
                        break;
                case 26:
                        if (!p->session_key.length) {
@@ -3578,7 +3768,7 @@ NTSTATUS _samr_set_userinfo2(pipes_struct *p, SAMR_Q_SET_USERINFO2 *q_u, SAMR_R_
                        }
                        encode_or_decode_arc4_passwd_buffer(ctr->info.id26->pass, &p->session_key);
 
-                       dump_data(100, (char *)ctr->info.id26->pass, 516);
+                       dump_data(100, ctr->info.id26->pass, 516);
 
                        if (!set_user_info_pw(ctr->info.id26->pass, pwd))
                                r_u->status = NT_STATUS_ACCESS_DENIED;
@@ -3637,10 +3827,14 @@ NTSTATUS _samr_query_useraliases(pipes_struct *p, SAMR_Q_QUERY_USERALIASES *q_u,
            !sid_check_is_builtin(&info->sid))
                return NT_STATUS_OBJECT_TYPE_MISMATCH;
 
-       members = TALLOC_ARRAY(p->mem_ctx, DOM_SID, q_u->num_sids1);
+       if (q_u->num_sids1) {
+               members = TALLOC_ARRAY(p->mem_ctx, DOM_SID, q_u->num_sids1);
 
-       if (members == NULL)
-               return NT_STATUS_NO_MEMORY;
+               if (members == NULL)
+                       return NT_STATUS_NO_MEMORY;
+       } else {
+               members = NULL;
+       }
 
        for (i=0; i<q_u->num_sids1; i++)
                sid_copy(&members[i], &q_u->sid[i].sid);
@@ -3688,18 +3882,24 @@ NTSTATUS _samr_query_aliasmem(pipes_struct *p, SAMR_Q_QUERY_ALIASMEM *q_u, SAMR_
                return r_u->status;
        }
 
-       DEBUG(10, ("sid is %s\n", sid_string_static(&alias_sid)));
+       DEBUG(10, ("sid is %s\n", sid_string_dbg(&alias_sid)));
 
+       become_root();
        status = pdb_enum_aliasmem(&alias_sid, &sids, &num_sids);
+       unbecome_root();
 
        if (!NT_STATUS_IS_OK(status)) {
                return status;
        }
 
-       sid = TALLOC_ZERO_ARRAY(p->mem_ctx, DOM_SID2, num_sids);        
-       if (num_sids!=0 && sid == NULL) {
-               SAFE_FREE(sids);
-               return NT_STATUS_NO_MEMORY;
+       if (num_sids) {
+               sid = TALLOC_ZERO_ARRAY(p->mem_ctx, DOM_SID2, num_sids);        
+               if (sid == NULL) {
+                       SAFE_FREE(sids);
+                       return NT_STATUS_NO_MEMORY;
+               }
+       } else {
+               sid = NULL;
        }
 
        for (i = 0; i < num_sids; i++) {
@@ -3708,75 +3908,11 @@ NTSTATUS _samr_query_aliasmem(pipes_struct *p, SAMR_Q_QUERY_ALIASMEM *q_u, SAMR_
 
        init_samr_r_query_aliasmem(r_u, num_sids, sid, NT_STATUS_OK);
 
-       SAFE_FREE(sids);
+       TALLOC_FREE(sids);
 
        return NT_STATUS_OK;
 }
 
-static void add_uid_to_array_unique(uid_t uid, uid_t **uids, int *num)
-{
-       int i;
-
-       for (i=0; i<*num; i++) {
-               if ((*uids)[i] == uid)
-                       return;
-       }
-       
-       *uids = SMB_REALLOC_ARRAY(*uids, uid_t, *num+1);
-
-       if (*uids == NULL)
-               return;
-
-       (*uids)[*num] = uid;
-       *num += 1;
-}
-
-
-static BOOL get_memberuids(gid_t gid, uid_t **uids, int *num)
-{
-       struct group *grp;
-       char **gr;
-       struct sys_pwent *userlist, *user;
-       *uids = NULL;
-       *num = 0;
-
-       /* We only look at our own sam, so don't care about imported stuff */
-
-       winbind_off();
-
-       if ((grp = getgrgid(gid)) == NULL) {
-               winbind_on();
-               return False;
-       }
-
-       /* Primary group members */
-
-       userlist = getpwent_list();
-
-       for (user = userlist; user != NULL; user = user->next) {
-               if (user->pw_gid != gid)
-                       continue;
-               add_uid_to_array_unique(user->pw_uid, uids, num);
-       }
-
-       pwent_free(userlist);
-
-       /* Secondary group members */
-
-       for (gr = grp->gr_mem; (*gr != NULL) && ((*gr)[0] != '\0'); gr += 1) {
-               struct passwd *pw = getpwnam(*gr);
-
-               if (pw == NULL)
-                       continue;
-               add_uid_to_array_unique(pw->pw_uid, uids, num);
-       }
-
-       winbind_on();
-
-       return True;
-}      
-
 /*********************************************************************
  _samr_query_groupmem
 *********************************************************************/
@@ -3784,7 +3920,6 @@ static BOOL get_memberuids(gid_t gid, uid_t **uids, int *num)
 NTSTATUS _samr_query_groupmem(pipes_struct *p, SAMR_Q_QUERY_GROUPMEM *q_u, SAMR_R_QUERY_GROUPMEM *r_u)
 {
        DOM_SID group_sid;
-       fstring group_sid_str;
        size_t i, num_members;
 
        uint32 *rid=NULL;
@@ -3802,11 +3937,11 @@ NTSTATUS _samr_query_groupmem(pipes_struct *p, SAMR_Q_QUERY_GROUPMEM *q_u, SAMR_
                return r_u->status;
        }
                
-       sid_to_string(group_sid_str, &group_sid);
-       DEBUG(10, ("sid is %s\n", group_sid_str));
+       DEBUG(10, ("sid is %s\n", sid_string_dbg(&group_sid)));
 
        if (!sid_check_is_in_our_domain(&group_sid)) {
-               DEBUG(3, ("sid %s is not in our domain\n", group_sid_str));
+               DEBUG(3, ("sid %s is not in our domain\n",
+                         sid_string_dbg(&group_sid)));
                return NT_STATUS_NO_SUCH_GROUP;
        }
 
@@ -3820,10 +3955,14 @@ NTSTATUS _samr_query_groupmem(pipes_struct *p, SAMR_Q_QUERY_GROUPMEM *q_u, SAMR_
        if (!NT_STATUS_IS_OK(result))
                return result;
 
-       attr=TALLOC_ZERO_ARRAY(p->mem_ctx, uint32, num_members);
-       
-       if ((num_members!=0) && (rid==NULL))
-               return NT_STATUS_NO_MEMORY;
+       if (num_members) {
+               attr=TALLOC_ZERO_ARRAY(p->mem_ctx, uint32, num_members);
+               if (attr == NULL) {
+                       return NT_STATUS_NO_MEMORY;
+               }
+       } else {
+               attr = NULL;
+       }
        
        for (i=0; i<num_members; i++)
                attr[i] = SID_NAME_USER;
@@ -3842,7 +3981,7 @@ NTSTATUS _samr_add_aliasmem(pipes_struct *p, SAMR_Q_ADD_ALIASMEM *q_u, SAMR_R_AD
        DOM_SID alias_sid;
        uint32 acc_granted;
        SE_PRIV se_rights;
-       BOOL can_add_accounts;
+       bool can_add_accounts;
        NTSTATUS ret;
        DISP_INFO *disp_info = NULL;
 
@@ -3854,7 +3993,7 @@ NTSTATUS _samr_add_aliasmem(pipes_struct *p, SAMR_Q_ADD_ALIASMEM *q_u, SAMR_R_AD
                return r_u->status;
        }
                
-       DEBUG(10, ("sid is %s\n", sid_string_static(&alias_sid)));
+       DEBUG(10, ("sid is %s\n", sid_string_dbg(&alias_sid)));
        
        se_priv_copy( &se_rights, &se_add_users );
        can_add_accounts = user_has_privileges( p->pipe_user.nt_user_token, &se_rights );
@@ -3887,7 +4026,7 @@ NTSTATUS _samr_del_aliasmem(pipes_struct *p, SAMR_Q_DEL_ALIASMEM *q_u, SAMR_R_DE
        DOM_SID alias_sid;
        uint32 acc_granted;
        SE_PRIV se_rights;
-       BOOL can_add_accounts;
+       bool can_add_accounts;
        NTSTATUS ret;
        DISP_INFO *disp_info = NULL;
 
@@ -3900,7 +4039,7 @@ NTSTATUS _samr_del_aliasmem(pipes_struct *p, SAMR_Q_DEL_ALIASMEM *q_u, SAMR_R_DE
        }
        
        DEBUG(10, ("_samr_del_aliasmem:sid is %s\n",
-                  sid_string_static(&alias_sid)));
+                  sid_string_dbg(&alias_sid)));
 
        se_priv_copy( &se_rights, &se_add_users );
        can_add_accounts = user_has_privileges( p->pipe_user.nt_user_token, &se_rights );
@@ -3931,19 +4070,10 @@ NTSTATUS _samr_del_aliasmem(pipes_struct *p, SAMR_Q_DEL_ALIASMEM *q_u, SAMR_R_DE
 NTSTATUS _samr_add_groupmem(pipes_struct *p, SAMR_Q_ADD_GROUPMEM *q_u, SAMR_R_ADD_GROUPMEM *r_u)
 {
        DOM_SID group_sid;
-       DOM_SID user_sid;
-       fstring group_sid_str;
-       uid_t uid;
-       struct passwd *pwd;
-       struct group *grp;
-       fstring grp_name;
-       GROUP_MAP map;
-       NTSTATUS ret;
-       SAM_ACCOUNT *sam_user=NULL;
-       BOOL check;
+       uint32 group_rid;
        uint32 acc_granted;
        SE_PRIV se_rights;
-       BOOL can_add_accounts;
+       bool can_add_accounts;
        DISP_INFO *disp_info = NULL;
 
        /* Find the policy handle. Open a policy on it. */
@@ -3954,53 +4084,11 @@ NTSTATUS _samr_add_groupmem(pipes_struct *p, SAMR_Q_ADD_GROUPMEM *q_u, SAMR_R_AD
                return r_u->status;
        }
 
-       sid_to_string(group_sid_str, &group_sid);
-       DEBUG(10, ("sid is %s\n", group_sid_str));
-
-       if (sid_compare(&group_sid, get_global_sam_sid())<=0)
-               return NT_STATUS_NO_SUCH_GROUP;
-
-       DEBUG(10, ("lookup on Domain SID\n"));
-
-       if(!get_domain_group_from_sid(group_sid, &map))
-               return NT_STATUS_NO_SUCH_GROUP;
-
-       sid_copy(&user_sid, get_global_sam_sid());
-       sid_append_rid(&user_sid, q_u->rid);
-
-       ret = pdb_init_sam(&sam_user);
-       if (!NT_STATUS_IS_OK(ret))
-               return ret;
-       
-       check = pdb_getsampwsid(sam_user, &user_sid);
-       
-       if (check != True) {
-               pdb_free_sam(&sam_user);
-               return NT_STATUS_NO_SUCH_USER;
-       }
-
-       /* check a real user exist before we run the script to add a user to a group */
-       if (!sid_to_uid(pdb_get_user_sid(sam_user), &uid)) {
-               pdb_free_sam(&sam_user);
-               return NT_STATUS_NO_SUCH_USER;
-       }
-
-       pdb_free_sam(&sam_user);
-
-       if ((pwd=getpwuid_alloc(p->mem_ctx, uid)) == NULL) {
-               return NT_STATUS_NO_SUCH_USER;
-       }
-
-       if ((grp=getgrgid(map.gid)) == NULL) {
-               return NT_STATUS_NO_SUCH_GROUP;
-       }
-
-       /* we need to copy the name otherwise it's overloaded in user_in_unix_group_list */
-       fstrcpy(grp_name, grp->gr_name);
+       DEBUG(10, ("sid is %s\n", sid_string_dbg(&group_sid)));
 
-       /* if the user is already in the group */
-       if(user_in_unix_group(pwd->pw_name, grp_name)) {
-               return NT_STATUS_MEMBER_IN_GROUP;
+       if (!sid_peek_check_rid(get_global_sam_sid(), &group_sid,
+                               &group_rid)) {
+               return NT_STATUS_INVALID_HANDLE;
        }
 
        se_priv_copy( &se_rights, &se_add_users );
@@ -4010,28 +4098,17 @@ NTSTATUS _samr_add_groupmem(pipes_struct *p, SAMR_Q_ADD_GROUPMEM *q_u, SAMR_R_AD
        
        if ( can_add_accounts )
                become_root();
-               
-       /* 
-        * ok, the group exist, the user exist, the user is not in the group,
-        *
-        * we can (finally) add it to the group !
-        */
-
-       smb_add_user_group(grp_name, pwd->pw_name);
 
+       r_u->status = pdb_add_groupmem(p->mem_ctx, group_rid, q_u->rid);
+               
        if ( can_add_accounts )
                unbecome_root();
                
        /******** END SeAddUsers BLOCK *********/
        
-       /* check if the user has been added then ... */
-       if(!user_in_unix_group(pwd->pw_name, grp_name)) {
-               return NT_STATUS_MEMBER_NOT_IN_GROUP;           /* don't know what to reply else */
-       }
-
        force_flush_samr_cache(disp_info);
 
-       return NT_STATUS_OK;
+       return r_u->status;
 }
 
 /*********************************************************************
@@ -4041,14 +4118,10 @@ NTSTATUS _samr_add_groupmem(pipes_struct *p, SAMR_Q_ADD_GROUPMEM *q_u, SAMR_R_AD
 NTSTATUS _samr_del_groupmem(pipes_struct *p, SAMR_Q_DEL_GROUPMEM *q_u, SAMR_R_DEL_GROUPMEM *r_u)
 {
        DOM_SID group_sid;
-       DOM_SID user_sid;
-       SAM_ACCOUNT *sam_pass=NULL;
-       GROUP_MAP map;
-       fstring grp_name;
-       struct group *grp;
+       uint32 group_rid;
        uint32 acc_granted;
        SE_PRIV se_rights;
-       BOOL can_add_accounts;
+       bool can_add_accounts;
        DISP_INFO *disp_info = NULL;
 
        /*
@@ -4064,36 +4137,11 @@ NTSTATUS _samr_del_groupmem(pipes_struct *p, SAMR_Q_DEL_GROUPMEM *q_u, SAMR_R_DE
        if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_GROUP_REMOVE_MEMBER, "_samr_del_groupmem"))) {
                return r_u->status;
        }
-               
-       if (!sid_check_is_in_our_domain(&group_sid))
-               return NT_STATUS_NO_SUCH_GROUP;
-
-       sid_copy(&user_sid, get_global_sam_sid());
-       sid_append_rid(&user_sid, q_u->rid);
-
-       if (!get_domain_group_from_sid(group_sid, &map))
-               return NT_STATUS_NO_SUCH_GROUP;
-
-       if ((grp=getgrgid(map.gid)) == NULL)
-               return NT_STATUS_NO_SUCH_GROUP;
-
-       /* we need to copy the name otherwise it's overloaded in user_in_group_list */
-       fstrcpy(grp_name, grp->gr_name);
-
-       /* check if the user exists before trying to remove it from the group */
-       pdb_init_sam(&sam_pass);
-       if (!pdb_getsampwsid(sam_pass, &user_sid)) {
-               DEBUG(5,("User %s doesn't exist.\n", pdb_get_username(sam_pass)));
-               pdb_free_sam(&sam_pass);
-               return NT_STATUS_NO_SUCH_USER;
-       }
 
-       /* if the user is not in the group */
-       if (!user_in_unix_group(pdb_get_username(sam_pass), grp_name)) {
-               pdb_free_sam(&sam_pass);
-               return NT_STATUS_MEMBER_NOT_IN_GROUP;
+       if (!sid_peek_check_rid(get_global_sam_sid(), &group_sid,
+                               &group_rid)) {
+               return NT_STATUS_INVALID_HANDLE;
        }
-       
 
        se_priv_copy( &se_rights, &se_add_users );
        can_add_accounts = user_has_privileges( p->pipe_user.nt_user_token, &se_rights );
@@ -4103,118 +4151,97 @@ NTSTATUS _samr_del_groupmem(pipes_struct *p, SAMR_Q_DEL_GROUPMEM *q_u, SAMR_R_DE
        if ( can_add_accounts )
                become_root();
                
-       smb_delete_user_group(grp_name, pdb_get_username(sam_pass));
+       r_u->status = pdb_del_groupmem(p->mem_ctx, group_rid, q_u->rid);
 
        if ( can_add_accounts )
                unbecome_root();
                
        /******** END SeAddUsers BLOCK *********/
        
-       /* check if the user has been removed then ... */
-       if (user_in_unix_group(pdb_get_username(sam_pass), grp_name)) {
-               pdb_free_sam(&sam_pass);
-               return NT_STATUS_ACCESS_DENIED;         /* don't know what to reply else */
-       }
-       
-       pdb_free_sam(&sam_pass);
-
        force_flush_samr_cache(disp_info);
 
-       return NT_STATUS_OK;
-
-}
-
-/****************************************************************************
- Delete a UNIX user on demand.
-****************************************************************************/
-
-static int smb_delete_user(const char *unix_user)
-{
-       pstring del_script;
-       int ret;
-
-       pstrcpy(del_script, lp_deluser_script());
-       if (! *del_script)
-               return -1;
-       all_string_sub(del_script, "%u", unix_user, sizeof(del_script));
-       ret = smbrun(del_script,NULL);
-       flush_pwnam_cache();
-       DEBUG(ret ? 0 : 3,("smb_delete_user: Running the command `%s' gave %d\n",del_script,ret));
-
-       return ret;
+       return r_u->status;
 }
 
 /*********************************************************************
- _samr_delete_dom_user
+ _samr_DeleteUser
 *********************************************************************/
 
-NTSTATUS _samr_delete_dom_user(pipes_struct *p, SAMR_Q_DELETE_DOM_USER *q_u, SAMR_R_DELETE_DOM_USER *r_u )
+NTSTATUS _samr_DeleteUser(pipes_struct *p,
+                         struct samr_DeleteUser *r)
 {
+       NTSTATUS status;
        DOM_SID user_sid;
-       SAM_ACCOUNT *sam_pass=NULL;
+       struct samu *sam_pass=NULL;
        uint32 acc_granted;
-       BOOL can_add_accounts;
-       BOOL ret;
+       bool can_add_accounts;
+       uint32 acb_info;
        DISP_INFO *disp_info = NULL;
+       bool ret;
 
-       DEBUG(5, ("_samr_delete_dom_user: %d\n", __LINE__));
+       DEBUG(5, ("_samr_DeleteUser: %d\n", __LINE__));
 
        /* Find the policy handle. Open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->user_pol, &user_sid, &acc_granted, &disp_info)) 
+       if (!get_lsa_policy_samr_sid(p, r->in.user_handle, &user_sid, &acc_granted, &disp_info)) 
                return NT_STATUS_INVALID_HANDLE;
                
-       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, STD_RIGHT_DELETE_ACCESS, "_samr_delete_dom_user"))) {
-               return r_u->status;
+       status = access_check_samr_function(acc_granted, STD_RIGHT_DELETE_ACCESS, "_samr_DeleteUser");
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
                
        if (!sid_check_is_in_our_domain(&user_sid))
                return NT_STATUS_CANNOT_DELETE;
 
        /* check if the user exists before trying to delete */
-       pdb_init_sam(&sam_pass);
-       if(!pdb_getsampwsid(sam_pass, &user_sid)) {
-               DEBUG(5,("_samr_delete_dom_user:User %s doesn't exist.\n", 
-                       sid_string_static(&user_sid)));
-               pdb_free_sam(&sam_pass);
+       if ( !(sam_pass = samu_new( NULL )) ) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       become_root();
+       ret = pdb_getsampwsid(sam_pass, &user_sid);
+       unbecome_root();
+
+       if( !ret ) {
+               DEBUG(5,("_samr_DeleteUser: User %s doesn't exist.\n", 
+                       sid_string_dbg(&user_sid)));
+               TALLOC_FREE(sam_pass);
                return NT_STATUS_NO_SUCH_USER;
        }
        
-       can_add_accounts = user_has_privileges( p->pipe_user.nt_user_token, &se_add_users );
+       acb_info = pdb_get_acct_ctrl(sam_pass);
+
+       /* For machine accounts it's the SeMachineAccountPrivilege that counts. */
+       if ( acb_info & ACB_WSTRUST ) {
+               can_add_accounts = user_has_privileges( p->pipe_user.nt_user_token, &se_machine_account );
+       } else {
+               can_add_accounts = user_has_privileges( p->pipe_user.nt_user_token, &se_add_users );
+       } 
 
        /******** BEGIN SeAddUsers BLOCK *********/
        
        if ( can_add_accounts )
                become_root();
 
-       /* First delete the samba side....
-          code is order to prevent unnecessary returns out of the admin 
-          block of code */
-          
-       if ( (ret = pdb_delete_sam_account(sam_pass)) == True ) {
-               /*
-                * Now delete the unix side ....
-                * note: we don't check if the delete really happened
-                * as the script is not necessary present
-                * and maybe the sysadmin doesn't want to delete the unix side
-                */
-               smb_delete_user( pdb_get_username(sam_pass) );
-       }
-       
+       status = pdb_delete_user(p->mem_ctx, sam_pass);
+
        if ( can_add_accounts )
                unbecome_root();
                
        /******** END SeAddUsers BLOCK *********/
                
-       if ( !ret ) {
-               DEBUG(5,("_samr_delete_dom_user:Failed to delete entry for user %s.\n", pdb_get_username(sam_pass)));
-               pdb_free_sam(&sam_pass);
-               return NT_STATUS_CANNOT_DELETE;
+       if ( !NT_STATUS_IS_OK(status) ) {
+               DEBUG(5,("_samr_DeleteUser: Failed to delete entry for "
+                        "user %s: %s.\n", pdb_get_username(sam_pass),
+                        nt_errstr(status)));
+               TALLOC_FREE(sam_pass);
+               return status;
        }
 
 
-       pdb_free_sam(&sam_pass);
+       TALLOC_FREE(sam_pass);
 
-       if (!close_policy_hnd(p, &q_u->user_pol))
+       if (!close_policy_hnd(p, r->in.user_handle))
                return NT_STATUS_OBJECT_NAME_INVALID;
 
        force_flush_samr_cache(disp_info);
@@ -4223,54 +4250,37 @@ NTSTATUS _samr_delete_dom_user(pipes_struct *p, SAMR_Q_DELETE_DOM_USER *q_u, SAM
 }
 
 /*********************************************************************
- _samr_delete_dom_group
+ _samr_DeleteDomainGroup
 *********************************************************************/
 
-NTSTATUS _samr_delete_dom_group(pipes_struct *p, SAMR_Q_DELETE_DOM_GROUP *q_u, SAMR_R_DELETE_DOM_GROUP *r_u)
+NTSTATUS _samr_DeleteDomainGroup(pipes_struct *p,
+                                struct samr_DeleteDomainGroup *r)
 {
+       NTSTATUS status;
        DOM_SID group_sid;
-       DOM_SID dom_sid;
        uint32 group_rid;
-       fstring group_sid_str;
-       gid_t gid;
-       struct group *grp;
-       GROUP_MAP map;
        uint32 acc_granted;
        SE_PRIV se_rights;
-       BOOL can_add_accounts;
-       BOOL ret;
+       bool can_add_accounts;
        DISP_INFO *disp_info = NULL;
 
-       DEBUG(5, ("samr_delete_dom_group: %d\n", __LINE__));
+       DEBUG(5, ("samr_DeleteDomainGroup: %d\n", __LINE__));
 
        /* Find the policy handle. Open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->group_pol, &group_sid, &acc_granted, &disp_info)) 
+       if (!get_lsa_policy_samr_sid(p, r->in.group_handle, &group_sid, &acc_granted, &disp_info)) 
                return NT_STATUS_INVALID_HANDLE;
-               
-       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, STD_RIGHT_DELETE_ACCESS, "_samr_delete_dom_group"))) {
-               return r_u->status;
-       }
-               
-       sid_copy(&dom_sid, &group_sid);
-       sid_to_string(group_sid_str, &dom_sid);
-       sid_split_rid(&dom_sid, &group_rid);
-
-       DEBUG(10, ("sid is %s\n", group_sid_str));
-
-       /* we check if it's our SID before deleting */
-       if (!sid_equal(&dom_sid, get_global_sam_sid()))
-               return NT_STATUS_NO_SUCH_GROUP;
-
-       DEBUG(10, ("lookup on Domain SID\n"));
 
-       if(!get_domain_group_from_sid(group_sid, &map))
-               return NT_STATUS_NO_SUCH_GROUP;
+       status = access_check_samr_function(acc_granted, STD_RIGHT_DELETE_ACCESS, "_samr_DeleteDomainGroup");
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
 
-       gid=map.gid;
+       DEBUG(10, ("sid is %s\n", sid_string_dbg(&group_sid)));
 
-       /* check if group really exists */
-       if ( (grp=getgrgid(gid)) == NULL) 
+       if (!sid_peek_check_rid(get_global_sam_sid(), &group_sid,
+                               &group_rid)) {
                return NT_STATUS_NO_SUCH_GROUP;
+       }
 
        se_priv_copy( &se_rights, &se_add_users );
        can_add_accounts = user_has_privileges( p->pipe_user.nt_user_token, &se_rights );
@@ -4280,27 +4290,22 @@ NTSTATUS _samr_delete_dom_group(pipes_struct *p, SAMR_Q_DELETE_DOM_GROUP *q_u, S
        if ( can_add_accounts )
                become_root();
 
-       /* delete mapping first */
-       
-       if ( (ret = pdb_delete_group_mapping_entry(group_sid)) == True ) {
-               smb_delete_group( grp->gr_name );
-       }
+       status = pdb_delete_dom_group(p->mem_ctx, group_rid);
 
        if ( can_add_accounts )
                unbecome_root();
                
        /******** END SeAddUsers BLOCK *********/
        
-       if ( !ret ) {
-               DEBUG(5,("_samr_delete_dom_group: Failed to delete mapping entry for group %s.\n", 
-                       group_sid_str));
-               return NT_STATUS_ACCESS_DENIED;
+       if ( !NT_STATUS_IS_OK(status) ) {
+               DEBUG(5,("_samr_DeleteDomainGroup: Failed to delete mapping "
+                        "entry for group %s: %s\n",
+                        sid_string_dbg(&group_sid),
+                        nt_errstr(status)));
+               return status;
        }
        
-       /* don't check that the unix group has been deleted.  Work like 
-          _samr_delet_dom_user() */
-
-       if (!close_policy_hnd(p, &q_u->group_pol))
+       if (!close_policy_hnd(p, r->in.group_handle))
                return NT_STATUS_OBJECT_NAME_INVALID;
 
        force_flush_samr_cache(disp_info);
@@ -4309,29 +4314,41 @@ NTSTATUS _samr_delete_dom_group(pipes_struct *p, SAMR_Q_DELETE_DOM_GROUP *q_u, S
 }
 
 /*********************************************************************
- _samr_delete_dom_alias
+ _samr_DeleteDomAlias
 *********************************************************************/
 
-NTSTATUS _samr_delete_dom_alias(pipes_struct *p, SAMR_Q_DELETE_DOM_ALIAS *q_u, SAMR_R_DELETE_DOM_ALIAS *r_u)
+NTSTATUS _samr_DeleteDomAlias(pipes_struct *p,
+                             struct samr_DeleteDomAlias *r)
 {
        DOM_SID alias_sid;
        uint32 acc_granted;
        SE_PRIV se_rights;
-       BOOL can_add_accounts;
-       BOOL ret;
+       bool can_add_accounts;
+       NTSTATUS status;
        DISP_INFO *disp_info = NULL;
 
-       DEBUG(5, ("_samr_delete_dom_alias: %d\n", __LINE__));
+       DEBUG(5, ("_samr_DeleteDomAlias: %d\n", __LINE__));
 
        /* Find the policy handle. Open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->alias_pol, &alias_sid, &acc_granted, &disp_info)) 
+       if (!get_lsa_policy_samr_sid(p, r->in.alias_handle, &alias_sid, &acc_granted, &disp_info)) 
                return NT_STATUS_INVALID_HANDLE;
        
-       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, STD_RIGHT_DELETE_ACCESS, "_samr_delete_dom_alias"))) {
-               return r_u->status;
+       /* copy the handle to the outgoing reply */
+
+       memcpy(r->out.alias_handle, r->in.alias_handle, sizeof(r->out.alias_handle));
+
+       status = access_check_samr_function(acc_granted, STD_RIGHT_DELETE_ACCESS, "_samr_DeleteDomAlias");
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
 
-       DEBUG(10, ("sid is %s\n", sid_string_static(&alias_sid)));
+       DEBUG(10, ("sid is %s\n", sid_string_dbg(&alias_sid)));
+
+       /* Don't let Windows delete builtin groups */
+
+       if ( sid_check_is_in_builtin( &alias_sid ) ) {
+               return NT_STATUS_SPECIAL_ACCOUNT;
+       }
 
        if (!sid_check_is_in_our_domain(&alias_sid))
                return NT_STATUS_NO_SUCH_ALIAS;
@@ -4347,17 +4364,17 @@ NTSTATUS _samr_delete_dom_alias(pipes_struct *p, SAMR_Q_DELETE_DOM_ALIAS *q_u, S
                become_root();
 
        /* Have passdb delete the alias */
-       ret = pdb_delete_alias(&alias_sid);
+       status = pdb_delete_alias(&alias_sid);
        
        if ( can_add_accounts )
                unbecome_root();
                
        /******** END SeAddUsers BLOCK *********/
 
-       if ( !ret )
-               return NT_STATUS_ACCESS_DENIED;
+       if ( !NT_STATUS_IS_OK(status))
+               return status;
 
-       if (!close_policy_hnd(p, &q_u->alias_pol))
+       if (!close_policy_hnd(p, r->in.alias_handle))
                return NT_STATUS_OBJECT_NAME_INVALID;
 
        force_flush_samr_cache(disp_info);
@@ -4366,40 +4383,43 @@ NTSTATUS _samr_delete_dom_alias(pipes_struct *p, SAMR_Q_DELETE_DOM_ALIAS *q_u, S
 }
 
 /*********************************************************************
- _samr_create_dom_group
+ _samr_CreateDomainGroup
 *********************************************************************/
 
-NTSTATUS _samr_create_dom_group(pipes_struct *p, SAMR_Q_CREATE_DOM_GROUP *q_u, SAMR_R_CREATE_DOM_GROUP *r_u)
+NTSTATUS _samr_CreateDomainGroup(pipes_struct *p,
+                                struct samr_CreateDomainGroup *r)
+
 {
+       NTSTATUS status;
        DOM_SID dom_sid;
        DOM_SID info_sid;
-       fstring name;
-       fstring sid_string;
-       struct group *grp;
+       const char *name;
        struct samr_info *info;
        uint32 acc_granted;
-       gid_t gid;
        SE_PRIV se_rights;
-       BOOL can_add_accounts;
-       NTSTATUS result;
+       bool can_add_accounts;
        DISP_INFO *disp_info = NULL;
 
        /* Find the policy handle. Open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &dom_sid, &acc_granted, &disp_info)) 
+       if (!get_lsa_policy_samr_sid(p, r->in.domain_handle, &dom_sid, &acc_granted, &disp_info)) 
                return NT_STATUS_INVALID_HANDLE;
        
-       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_DOMAIN_CREATE_GROUP, "_samr_create_dom_group"))) {
-               return r_u->status;
+       status = access_check_samr_function(acc_granted, SA_RIGHT_DOMAIN_CREATE_GROUP, "_samr_CreateDomainGroup");
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
                
        if (!sid_equal(&dom_sid, get_global_sam_sid()))
                return NT_STATUS_ACCESS_DENIED;
 
-       unistr2_to_ascii(name, &q_u->uni_acct_desc, sizeof(name)-1);
+       name = r->in.name->string;
+       if (name == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
 
-       r_u->status = can_create(p->mem_ctx, name);
-       if (!NT_STATUS_IS_OK(r_u->status)) {
-               return r_u->status;
+       status = can_create(p->mem_ctx, name);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
 
        se_priv_copy( &se_rights, &se_add_users );
@@ -4412,35 +4432,7 @@ NTSTATUS _samr_create_dom_group(pipes_struct *p, SAMR_Q_CREATE_DOM_GROUP *q_u, S
        
        /* check that we successfully create the UNIX group */
        
-       result = NT_STATUS_ACCESS_DENIED;
-       if ( (smb_create_group(name, &gid) == 0) && ((grp=getgrgid(gid)) != NULL) ) {
-       
-               /* so far, so good */
-               
-               result = NT_STATUS_OK;
-
-               if (pdb_rid_algorithm()) {
-                       r_u->rid = pdb_gid_to_group_rid( grp->gr_gid );
-               } else {
-                       if (!pdb_new_rid(&r_u->rid)) {
-                               result = NT_STATUS_ACCESS_DENIED;
-                       }
-               }
-
-               if (NT_STATUS_IS_OK(result)) {
-
-                       /* add the group to the mapping table */
-               
-                       sid_copy( &info_sid, get_global_sam_sid() );
-                       sid_append_rid( &info_sid, r_u->rid );
-                       sid_to_string( sid_string, &info_sid );
-               
-                       /* reset the error code if we fail to add the mapping entry */
-               
-                       if ( !add_initial_entry(grp->gr_gid, sid_string, SID_NAME_DOM_GRP, name, NULL) )
-                               result = NT_STATUS_ACCESS_DENIED;
-               }
-       }
+       status = pdb_create_dom_group(p->mem_ctx, name, r->out.rid);
 
        if ( can_add_accounts )
                unbecome_root();
@@ -4449,19 +4441,20 @@ NTSTATUS _samr_create_dom_group(pipes_struct *p, SAMR_Q_CREATE_DOM_GROUP *q_u, S
        
        /* check if we should bail out here */
        
-       if ( !NT_STATUS_IS_OK(result) )
-               return result;
+       if ( !NT_STATUS_IS_OK(status) )
+               return status;
+
+       sid_compose(&info_sid, get_global_sam_sid(), *r->out.rid);
        
        if ((info = get_samr_info_by_sid(&info_sid)) == NULL)
                return NT_STATUS_NO_MEMORY;
 
-
        /* they created it; let the user do what he wants with it */
 
        info->acc_granted = GENERIC_RIGHTS_GROUP_ALL_ACCESS;
 
        /* get a (unique) handle.  open a policy on it. */
-       if (!create_policy_hnd(p, &r_u->pol, free_samr_info, (void *)info))
+       if (!create_policy_hnd(p, r->out.group_handle, free_samr_info, (void *)info))
                return NT_STATUS_OBJECT_NAME_NOT_FOUND;
 
        force_flush_samr_cache(disp_info);
@@ -4470,34 +4463,36 @@ NTSTATUS _samr_create_dom_group(pipes_struct *p, SAMR_Q_CREATE_DOM_GROUP *q_u, S
 }
 
 /*********************************************************************
- _samr_create_dom_alias
+ _samr_CreateDomAlias
 *********************************************************************/
 
-NTSTATUS _samr_create_dom_alias(pipes_struct *p, SAMR_Q_CREATE_DOM_ALIAS *q_u, SAMR_R_CREATE_DOM_ALIAS *r_u)
+NTSTATUS _samr_CreateDomAlias(pipes_struct *p,
+                             struct samr_CreateDomAlias *r)
 {
        DOM_SID dom_sid;
        DOM_SID info_sid;
-       fstring name;
+       const char *name = NULL;
        struct samr_info *info;
        uint32 acc_granted;
        gid_t gid;
        NTSTATUS result;
        SE_PRIV se_rights;
-       BOOL can_add_accounts;
+       bool can_add_accounts;
        DISP_INFO *disp_info = NULL;
 
        /* Find the policy handle. Open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->dom_pol, &dom_sid, &acc_granted, &disp_info)) 
+       if (!get_lsa_policy_samr_sid(p, r->in.domain_handle, &dom_sid, &acc_granted, &disp_info)) 
                return NT_STATUS_INVALID_HANDLE;
                
-       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_DOMAIN_CREATE_ALIAS, "_samr_create_alias"))) {
-               return r_u->status;
+       result = access_check_samr_function(acc_granted, SA_RIGHT_DOMAIN_CREATE_ALIAS, "_samr_CreateDomAlias");
+       if (!NT_STATUS_IS_OK(result)) {
+               return result;
        }
                
        if (!sid_equal(&dom_sid, get_global_sam_sid()))
                return NT_STATUS_ACCESS_DENIED;
 
-       unistr2_to_ascii(name, &q_u->uni_acct_desc, sizeof(name)-1);
+       name = r->in.alias_name->string;
 
        se_priv_copy( &se_rights, &se_add_users );
        can_add_accounts = user_has_privileges( p->pipe_user.nt_user_token, &se_rights );
@@ -4513,7 +4508,7 @@ NTSTATUS _samr_create_dom_alias(pipes_struct *p, SAMR_Q_CREATE_DOM_ALIAS *q_u, S
                become_root();
 
        /* Have passdb create the alias */
-       result = pdb_create_alias(name, &r_u->rid);
+       result = pdb_create_alias(name, r->out.rid);
 
        if ( can_add_accounts )
                unbecome_root();
@@ -4527,7 +4522,7 @@ NTSTATUS _samr_create_dom_alias(pipes_struct *p, SAMR_Q_CREATE_DOM_ALIAS *q_u, S
        }
 
        sid_copy(&info_sid, get_global_sam_sid());
-       sid_append_rid(&info_sid, r_u->rid);
+       sid_append_rid(&info_sid, *r->out.rid);
 
        if (!sid_to_gid(&info_sid, &gid)) {
                DEBUG(10, ("Could not find alias just created\n"));
@@ -4549,7 +4544,7 @@ NTSTATUS _samr_create_dom_alias(pipes_struct *p, SAMR_Q_CREATE_DOM_ALIAS *q_u, S
        info->acc_granted = GENERIC_RIGHTS_ALIAS_ALL_ACCESS;
 
        /* get a (unique) handle.  open a policy on it. */
-       if (!create_policy_hnd(p, &r_u->alias_pol, free_samr_info, (void *)info))
+       if (!create_policy_hnd(p, r->out.alias_handle, free_samr_info, (void *)info))
                return NT_STATUS_OBJECT_NAME_NOT_FOUND;
 
        force_flush_samr_cache(disp_info);
@@ -4568,12 +4563,9 @@ NTSTATUS _samr_query_groupinfo(pipes_struct *p, SAMR_Q_QUERY_GROUPINFO *q_u, SAM
 {
        DOM_SID group_sid;
        GROUP_MAP map;
-       DOM_SID *sids=NULL;
-       uid_t *uids;
-       int num=0;
        GROUP_INFO_CTR *ctr;
        uint32 acc_granted;
-       BOOL ret;
+       bool ret;
 
        if (!get_lsa_policy_samr_sid(p, &q_u->pol, &group_sid, &acc_granted, NULL)) 
                return NT_STATUS_INVALID_HANDLE;
@@ -4593,13 +4585,28 @@ NTSTATUS _samr_query_groupinfo(pipes_struct *p, SAMR_Q_QUERY_GROUPINFO *q_u, SAM
                return NT_STATUS_NO_MEMORY;
 
        switch (q_u->switch_level) {
-               case 1:
+               case 1: {
+                       uint32 *members;
+                       size_t num_members;
+
                        ctr->switch_value1 = 1;
-                       if(!get_memberuids(map.gid, &uids, &num))
-                               return NT_STATUS_NO_SUCH_GROUP;
-                       SAFE_FREE(uids);
-                       init_samr_group_info1(&ctr->group.info1, map.nt_name, map.comment, num);
-                       SAFE_FREE(sids);
+
+                       become_root();
+                       r_u->status = pdb_enum_group_members(
+                               p->mem_ctx, &group_sid, &members, &num_members);
+                       unbecome_root();
+       
+                       if (!NT_STATUS_IS_OK(r_u->status)) {
+                               return r_u->status;
+                       }
+
+                       init_samr_group_info1(&ctr->group.info1, map.nt_name,
+                                     map.comment, num_members);
+                       break;
+               }
+               case 2:
+                       ctr->switch_value1 = 2;
+                       init_samr_group_info2(&ctr->group.info2, map.nt_name);
                        break;
                case 3:
                        ctr->switch_value1 = 3;
@@ -4609,6 +4616,28 @@ NTSTATUS _samr_query_groupinfo(pipes_struct *p, SAMR_Q_QUERY_GROUPINFO *q_u, SAM
                        ctr->switch_value1 = 4;
                        init_samr_group_info4(&ctr->group.info4, map.comment);
                        break;
+               case 5: {
+                       /*
+                       uint32 *members;
+                       size_t num_members;
+                       */
+
+                       ctr->switch_value1 = 5;
+
+                       /*
+                       become_root();
+                       r_u->status = pdb_enum_group_members(
+                               p->mem_ctx, &group_sid, &members, &num_members);
+                       unbecome_root();
+       
+                       if (!NT_STATUS_IS_OK(r_u->status)) {
+                               return r_u->status;
+                       }
+                       */
+                       init_samr_group_info5(&ctr->group.info5, map.nt_name,
+                                     map.comment, 0 /* num_members */); /* in w2k3 this is always 0 */
+                       break;
+               }
                default:
                        return NT_STATUS_INVALID_INFO_CLASS;
        }
@@ -4631,8 +4660,8 @@ NTSTATUS _samr_set_groupinfo(pipes_struct *p, SAMR_Q_SET_GROUPINFO *q_u, SAMR_R_
        GROUP_INFO_CTR *ctr;
        uint32 acc_granted;
        NTSTATUS ret;
-       BOOL result;
-       BOOL can_mod_accounts;
+       bool result;
+       bool can_mod_accounts;
        DISP_INFO *disp_info = NULL;
 
        if (!get_lsa_policy_samr_sid(p, &q_u->pol, &group_sid, &acc_granted, &disp_info))
@@ -4652,10 +4681,10 @@ NTSTATUS _samr_set_groupinfo(pipes_struct *p, SAMR_Q_SET_GROUPINFO *q_u, SAMR_R_
 
        switch (ctr->switch_value1) {
                case 1:
-                       unistr2_to_ascii(map.comment, &(ctr->group.info1.uni_acct_desc), sizeof(map.comment)-1);
+                       unistr2_to_ascii(map.comment, &(ctr->group.info1.uni_acct_desc), sizeof(map.comment));
                        break;
                case 4:
-                       unistr2_to_ascii(map.comment, &(ctr->group.info4.uni_acct_desc), sizeof(map.comment)-1);
+                       unistr2_to_ascii(map.comment, &(ctr->group.info4.uni_acct_desc), sizeof(map.comment));
                        break;
                default:
                        return NT_STATUS_INVALID_INFO_CLASS;
@@ -4694,8 +4723,8 @@ NTSTATUS _samr_set_aliasinfo(pipes_struct *p, SAMR_Q_SET_ALIASINFO *q_u, SAMR_R_
        struct acct_info info;
        ALIAS_INFO_CTR *ctr;
        uint32 acc_granted;
-       BOOL ret;
-       BOOL can_mod_accounts;
+       bool can_mod_accounts;
+       NTSTATUS status;
        DISP_INFO *disp_info = NULL;
 
        if (!get_lsa_policy_samr_sid(p, &q_u->alias_pol, &group_sid, &acc_granted, &disp_info))
@@ -4707,12 +4736,59 @@ NTSTATUS _samr_set_aliasinfo(pipes_struct *p, SAMR_Q_SET_ALIASINFO *q_u, SAMR_R_
                
        ctr=&q_u->ctr;
 
+       /* get the current group information */
+
+       become_root();
+       status = pdb_get_aliasinfo( &group_sid, &info );
+       unbecome_root();
+
+       if ( !NT_STATUS_IS_OK(status))
+               return status;
+
        switch (ctr->level) {
+               case 2:
+               {
+                       fstring group_name, acct_name;
+
+                       /* We currently do not support renaming groups in the
+                          the BUILTIN domain.  Refer to util_builtin.c to understand 
+                          why.  The eventually needs to be fixed to be like Windows
+                          where you can rename builtin groups, just not delete them */
+
+                       if ( sid_check_is_in_builtin( &group_sid ) ) {
+                               return NT_STATUS_SPECIAL_ACCOUNT;
+                       }
+
+                       /* There has to be a valid name (and it has to be different) */
+
+                       if ( !ctr->alias.info2.name.string ) 
+                               return NT_STATUS_INVALID_PARAMETER;
+
+                       unistr2_to_ascii( acct_name, ctr->alias.info2.name.string, 
+                               sizeof(acct_name));
+
+                       /* If the name is the same just reply "ok".  Yes this
+                          doesn't allow you to change the case of a group name. */
+
+                       if ( strequal( acct_name, info.acct_name ) )
+                               return NT_STATUS_OK;
+
+                       fstrcpy( info.acct_name, acct_name );
+
+                       /* make sure the name doesn't already exist as a user 
+                          or local group */
+
+                       fstr_sprintf( group_name, "%s\\%s", global_myname(), info.acct_name );
+                       status = can_create( p->mem_ctx, group_name );
+                       if ( !NT_STATUS_IS_OK( status ) ) 
+                               return status;
+                       break;
+               }
                case 3:
                        if ( ctr->alias.info3.description.string ) {
                                unistr2_to_ascii( info.acct_desc, 
                                        ctr->alias.info3.description.string, 
-                                       sizeof(info.acct_desc)-1 );
+                                       sizeof(info.acct_desc));
                        }
                        else
                                fstrcpy( info.acct_desc, "" );
@@ -4728,46 +4804,48 @@ NTSTATUS _samr_set_aliasinfo(pipes_struct *p, SAMR_Q_SET_ALIASINFO *q_u, SAMR_R_
         if ( can_mod_accounts )
                 become_root();
 
-        ret = pdb_set_aliasinfo( &group_sid, &info );
+        status = pdb_set_aliasinfo( &group_sid, &info );
 
         if ( can_mod_accounts )
                 unbecome_root();
 
         /******** End SeAddUsers BLOCK *********/
 
-       if (ret) {
+       if (NT_STATUS_IS_OK(status))
                force_flush_samr_cache(disp_info);
-       }
 
-       return ret ? NT_STATUS_OK : NT_STATUS_ACCESS_DENIED;
+       return status;
 }
 
-/*********************************************************************
- _samr_get_dom_pwinfo
-*********************************************************************/
+/****************************************************************
+ _samr_GetDomPwInfo
+****************************************************************/
 
-NTSTATUS _samr_get_dom_pwinfo(pipes_struct *p, SAMR_Q_GET_DOM_PWINFO *q_u, SAMR_R_GET_DOM_PWINFO *r_u)
+NTSTATUS _samr_GetDomPwInfo(pipes_struct *p,
+                           struct samr_GetDomPwInfo *r)
 {
        /* Perform access check.  Since this rpc does not require a
           policy handle it will not be caught by the access checks on
           SAMR_CONNECT or SAMR_CONNECT_ANON. */
 
        if (!pipe_access_check(p)) {
-               DEBUG(3, ("access denied to samr_get_dom_pwinfo\n"));
-               r_u->status = NT_STATUS_ACCESS_DENIED;
-               return r_u->status;
+               DEBUG(3, ("access denied to _samr_GetDomPwInfo\n"));
+               return NT_STATUS_ACCESS_DENIED;
        }
 
        /* Actually, returning zeros here works quite well :-). */
+       ZERO_STRUCTP(r->out.info);
 
        return NT_STATUS_OK;
 }
 
 /*********************************************************************
- _samr_open_group
+ _samr_OpenGroup
 *********************************************************************/
 
-NTSTATUS _samr_open_group(pipes_struct *p, SAMR_Q_OPEN_GROUP *q_u, SAMR_R_OPEN_GROUP *r_u)
+NTSTATUS _samr_OpenGroup(pipes_struct *p,
+                        struct samr_OpenGroup *r)
+
 {
        DOM_SID sid;
        DOM_SID info_sid;
@@ -4775,18 +4853,18 @@ NTSTATUS _samr_open_group(pipes_struct *p, SAMR_Q_OPEN_GROUP *q_u, SAMR_R_OPEN_G
        struct samr_info *info;
        SEC_DESC         *psd = NULL;
        uint32            acc_granted;
-       uint32            des_access = q_u->access_mask;
+       uint32            des_access = r->in.access_mask;
        size_t            sd_size;
        NTSTATUS          status;
        fstring sid_string;
-       BOOL ret;
+       bool ret;
        SE_PRIV se_rights;
 
-       if (!get_lsa_policy_samr_sid(p, &q_u->domain_pol, &sid, &acc_granted, NULL)) 
+       if (!get_lsa_policy_samr_sid(p, r->in.domain_handle, &sid, &acc_granted, NULL)) 
                return NT_STATUS_INVALID_HANDLE;
        
        status = access_check_samr_function(acc_granted, 
-               SA_RIGHT_DOMAIN_OPEN_ACCOUNT, "_samr_open_group");
+               SA_RIGHT_DOMAIN_OPEN_ACCOUNT, "_samr_OpenGroup");
                
        if ( !NT_STATUS_IS_OK(status) )
                return status;
@@ -4799,7 +4877,7 @@ NTSTATUS _samr_open_group(pipes_struct *p, SAMR_Q_OPEN_GROUP *q_u, SAMR_R_OPEN_G
 
        status = access_check_samr_object(psd, p->pipe_user.nt_user_token, 
                &se_rights, GENERIC_RIGHTS_GROUP_WRITE, des_access, 
-               &acc_granted, "_samr_open_group");
+               &acc_granted, "_samr_OpenGroup");
                
        if ( !NT_STATUS_IS_OK(status) ) 
                return status;
@@ -4810,15 +4888,15 @@ NTSTATUS _samr_open_group(pipes_struct *p, SAMR_Q_OPEN_GROUP *q_u, SAMR_R_OPEN_G
                return NT_STATUS_ACCESS_DENIED;
 
        sid_copy(&info_sid, get_global_sam_sid());
-       sid_append_rid(&info_sid, q_u->rid_group);
-       sid_to_string(sid_string, &info_sid);
+       sid_append_rid(&info_sid, r->in.rid);
+       sid_to_fstring(sid_string, &info_sid);
 
        if ((info = get_samr_info_by_sid(&info_sid)) == NULL)
                return NT_STATUS_NO_MEMORY;
                
        info->acc_granted = acc_granted;
 
-       DEBUG(10, ("_samr_open_group:Opening SID: %s\n", sid_string));
+       DEBUG(10, ("_samr_OpenGroup:Opening SID: %s\n", sid_string));
 
        /* check if that group really exists */
        become_root();
@@ -4828,7 +4906,7 @@ NTSTATUS _samr_open_group(pipes_struct *p, SAMR_Q_OPEN_GROUP *q_u, SAMR_R_OPEN_G
                return NT_STATUS_NO_SUCH_GROUP;
 
        /* get a (unique) handle.  open a policy on it. */
-       if (!create_policy_hnd(p, &r_u->pol, free_samr_info, (void *)info))
+       if (!create_policy_hnd(p, r->out.group_handle, free_samr_info, (void *)info))
                return NT_STATUS_OBJECT_NAME_NOT_FOUND;
 
        return NT_STATUS_OK;
@@ -4848,12 +4926,12 @@ NTSTATUS _samr_remove_sid_foreign_domain(pipes_struct *p,
        DISP_INFO *disp_info = NULL;
 
        sid_copy( &delete_sid, &q_u->sid.sid );
-       
+
        DEBUG(5,("_samr_remove_sid_foreign_domain: removing SID [%s]\n",
-               sid_string_static(&delete_sid)));
-               
+               sid_string_dbg(&delete_sid)));
+
        /* Find the policy handle. Open a policy on it. */
-       
+
        if (!get_lsa_policy_samr_sid(p, &q_u->dom_pol, &domain_sid,
                                     &acc_granted, &disp_info)) 
                return NT_STATUS_INVALID_HANDLE;
@@ -4864,8 +4942,8 @@ NTSTATUS _samr_remove_sid_foreign_domain(pipes_struct *p,
        if (!NT_STATUS_IS_OK(result)) 
                return result;
                        
-       DEBUG(8, ("_samr_remove_sid_foreign_domain:sid is %s\n", 
-               sid_string_static(&domain_sid)));
+       DEBUG(8, ("_samr_remove_sid_foreign_domain:sid is %s\n",
+                 sid_string_dbg(&domain_sid)));
 
        /* we can only delete a user from a group since we don't have 
           nested groups anyways.  So in the latter case, just say OK */
@@ -4884,8 +4962,8 @@ NTSTATUS _samr_remove_sid_foreign_domain(pipes_struct *p,
        if (!sid_check_is_builtin(&domain_sid)) {
                DEBUG(1,("_samr_remove_sid_foreign_domain: domain_sid = %s, "
                         "global_sam_sid() = %s\n",
-                        sid_string_static(&domain_sid),
-                        sid_string_static(get_global_sam_sid())));
+                        sid_string_dbg(&domain_sid),
+                        sid_string_dbg(get_global_sam_sid())));
                DEBUGADD(1,("please report to samba-technical@samba.org!\n"));
                return NT_STATUS_OK;
        }
@@ -4902,144 +4980,31 @@ NTSTATUS _samr_remove_sid_foreign_domain(pipes_struct *p,
  ********************************************************************/
 
 NTSTATUS _samr_query_domain_info2(pipes_struct *p,
-               SAMR_Q_QUERY_DOMAIN_INFO2 *q_u,
-               SAMR_R_QUERY_DOMAIN_INFO2 *r_u)
+                                 SAMR_Q_QUERY_DOMAIN_INFO2 *q_u,
+                                 SAMR_R_QUERY_DOMAIN_INFO2 *r_u)
 {
-       struct samr_info *info = NULL;
-       SAM_UNK_CTR *ctr;
-       uint32 min_pass_len,pass_hist,password_properties;
-       time_t u_expire, u_min_age;
-       NTTIME nt_expire, nt_min_age;
-
-       time_t u_lock_duration, u_reset_time;
-       NTTIME nt_lock_duration, nt_reset_time;
-       uint32 lockout;
-       
-       time_t u_logout;
-       NTTIME nt_logout;
-
-       uint32 num_users=0, num_groups=0, num_aliases=0;
-
-       uint32 account_policy_temp;
-
-       time_t seq_num;
-       uint32 server_role;
-
-       if ((ctr = TALLOC_ZERO_P(p->mem_ctx, SAM_UNK_CTR)) == NULL)
-               return NT_STATUS_NO_MEMORY;
+       SAMR_Q_QUERY_DOMAIN_INFO q;
+       SAMR_R_QUERY_DOMAIN_INFO r;
 
-       ZERO_STRUCTP(ctr);
-
-       r_u->status = NT_STATUS_OK;
+       ZERO_STRUCT(q);
+       ZERO_STRUCT(r);
 
        DEBUG(5,("_samr_query_domain_info2: %d\n", __LINE__));
 
-       /* find the policy handle.  open a policy on it. */
-       if (!find_policy_by_hnd(p, &q_u->domain_pol, (void **)(void *)&info))
-               return NT_STATUS_INVALID_HANDLE;
-
-       switch (q_u->switch_value) {
-               case 0x01:
-                       pdb_get_account_policy(AP_MIN_PASSWORD_LEN, &account_policy_temp);
-                       min_pass_len = account_policy_temp;
-
-                       pdb_get_account_policy(AP_PASSWORD_HISTORY, &account_policy_temp);
-                       pass_hist = account_policy_temp;
-
-                       pdb_get_account_policy(AP_USER_MUST_LOGON_TO_CHG_PASS, &account_policy_temp);
-                       password_properties = account_policy_temp;
-
-                       pdb_get_account_policy(AP_MAX_PASSWORD_AGE, &account_policy_temp);
-                       u_expire = account_policy_temp;
-
-                       pdb_get_account_policy(AP_MIN_PASSWORD_AGE, &account_policy_temp);
-                       u_min_age = account_policy_temp;
-
-                       unix_to_nt_time_abs(&nt_expire, u_expire);
-                       unix_to_nt_time_abs(&nt_min_age, u_min_age);
-
-                       init_unk_info1(&ctr->info.inf1, (uint16)min_pass_len, (uint16)pass_hist, 
-                                      password_properties, nt_expire, nt_min_age);
-                       break;
-               case 0x02:
-                       become_root();          
-                       num_users = count_sam_users(info->disp_info, ACB_NORMAL);
-                       num_groups = count_sam_groups(info->disp_info);
-                       num_aliases = count_sam_aliases(info->disp_info);
-                       unbecome_root();
-
-                       pdb_get_account_policy(AP_TIME_TO_LOGOUT, &account_policy_temp);
-                       u_logout = account_policy_temp;
-
-                       unix_to_nt_time_abs(&nt_logout, u_logout);
-
-                       if (!pdb_get_seq_num(&seq_num))
-                               seq_num = time(NULL);
-
-                       server_role = ROLE_DOMAIN_PDC;
-                       if (lp_server_role() == ROLE_DOMAIN_BDC)
-                               server_role = ROLE_DOMAIN_BDC;
-
-                       init_unk_info2(&ctr->info.inf2, lp_serverstring(), lp_workgroup(), global_myname(), seq_num, 
-                                      num_users, num_groups, num_aliases, nt_logout, server_role);
-                       break;
-               case 0x03:
-                       pdb_get_account_policy(AP_TIME_TO_LOGOUT, &account_policy_temp);
-                       u_logout = account_policy_temp;
-
-                       unix_to_nt_time_abs(&nt_logout, u_logout);
-                       
-                       init_unk_info3(&ctr->info.inf3, nt_logout);
-                       break;
-               case 0x05:
-                       init_unk_info5(&ctr->info.inf5, global_myname());
-                       break;
-               case 0x06:
-                       init_unk_info6(&ctr->info.inf6);
-                       break;
-               case 0x07:
-                       server_role = ROLE_DOMAIN_PDC;
-                       if (lp_server_role() == ROLE_DOMAIN_BDC)
-                               server_role = ROLE_DOMAIN_BDC;
-
-                       init_unk_info7(&ctr->info.inf7, server_role);
-                       break;
-               case 0x08:
-                       if (!pdb_get_seq_num(&seq_num))
-                               seq_num = time(NULL);
-
-                       init_unk_info8(&ctr->info.inf8, (uint32) seq_num);
-                       break;
-               case 0x0c:
-                       pdb_get_account_policy(AP_LOCK_ACCOUNT_DURATION, &account_policy_temp);
-                       u_lock_duration = account_policy_temp;
-                       if (u_lock_duration != -1)
-                               u_lock_duration *= 60;
-
-                       pdb_get_account_policy(AP_RESET_COUNT_TIME, &account_policy_temp);
-                       u_reset_time = account_policy_temp * 60;
+       q.domain_pol = q_u->domain_pol;
+       q.switch_value = q_u->switch_value;
 
-                       pdb_get_account_policy(AP_BAD_ATTEMPT_LOCKOUT, &account_policy_temp);
-                       lockout = account_policy_temp;
-       
-                       unix_to_nt_time_abs(&nt_lock_duration, u_lock_duration);
-                       unix_to_nt_time_abs(&nt_reset_time, u_reset_time);
-       
-                       init_unk_info12(&ctr->info.inf12, nt_lock_duration, nt_reset_time, (uint16)lockout);
-                       break;
-               default:
-                       return NT_STATUS_INVALID_INFO_CLASS;
-       }
-
-       init_samr_r_samr_query_domain_info2(r_u, q_u->switch_value, ctr, NT_STATUS_OK);
+       r_u->status = _samr_query_domain_info(p, &q, &r);
 
-       DEBUG(5,("_samr_query_domain_info2: %d\n", __LINE__));
+       r_u->ptr_0              = r.ptr_0;
+       r_u->switch_value       = r.switch_value;
+       r_u->ctr                = r.ctr;
 
        return r_u->status;
 }
 
 /*******************************************************************
- _samr_
+ _samr_set_dom_info
  ********************************************************************/
 
 NTSTATUS _samr_set_dom_info(pipes_struct *p, SAMR_Q_SET_DOMAIN_INFO *q_u, SAMR_R_SET_DOMAIN_INFO *r_u)
@@ -5102,3 +5067,553 @@ NTSTATUS _samr_set_dom_info(pipes_struct *p, SAMR_Q_SET_DOMAIN_INFO *q_u, SAMR_R
 
        return r_u->status;
 }
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_Connect(pipes_struct *p,
+                      struct samr_Connect *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_SetSecurity(pipes_struct *p,
+                          struct samr_SetSecurity *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_QuerySecurity(pipes_struct *p,
+                            struct samr_QuerySecurity *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_Shutdown(pipes_struct *p,
+                       struct samr_Shutdown *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_LookupDomain(pipes_struct *p,
+                           struct samr_LookupDomain *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_EnumDomains(pipes_struct *p,
+                          struct samr_EnumDomains *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_QueryDomainInfo(pipes_struct *p,
+                              struct samr_QueryDomainInfo *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_SetDomainInfo(pipes_struct *p,
+                            struct samr_SetDomainInfo *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_EnumDomainGroups(pipes_struct *p,
+                               struct samr_EnumDomainGroups *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_CreateUser(pipes_struct *p,
+                         struct samr_CreateUser *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_EnumDomainUsers(pipes_struct *p,
+                              struct samr_EnumDomainUsers *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_EnumDomainAliases(pipes_struct *p,
+                                struct samr_EnumDomainAliases *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_GetAliasMembership(pipes_struct *p,
+                                 struct samr_GetAliasMembership *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_LookupNames(pipes_struct *p,
+                          struct samr_LookupNames *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_LookupRids(pipes_struct *p,
+                         struct samr_LookupRids *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_QueryGroupInfo(pipes_struct *p,
+                             struct samr_QueryGroupInfo *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_SetGroupInfo(pipes_struct *p,
+                           struct samr_SetGroupInfo *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_AddGroupMember(pipes_struct *p,
+                             struct samr_AddGroupMember *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_DeleteGroupMember(pipes_struct *p,
+                                struct samr_DeleteGroupMember *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_QueryGroupMember(pipes_struct *p,
+                               struct samr_QueryGroupMember *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_SetMemberAttributesOfGroup(pipes_struct *p,
+                                         struct samr_SetMemberAttributesOfGroup *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_QueryAliasInfo(pipes_struct *p,
+                             struct samr_QueryAliasInfo *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_SetAliasInfo(pipes_struct *p,
+                           struct samr_SetAliasInfo *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_AddAliasMember(pipes_struct *p,
+                             struct samr_AddAliasMember *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_DeleteAliasMember(pipes_struct *p,
+                                struct samr_DeleteAliasMember *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_GetMembersInAlias(pipes_struct *p,
+                                struct samr_GetMembersInAlias *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_QueryUserInfo(pipes_struct *p,
+                            struct samr_QueryUserInfo *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_SetUserInfo(pipes_struct *p,
+                          struct samr_SetUserInfo *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_ChangePasswordUser(pipes_struct *p,
+                                 struct samr_ChangePasswordUser *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_GetGroupsForUser(pipes_struct *p,
+                               struct samr_GetGroupsForUser *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_QueryDisplayInfo(pipes_struct *p,
+                               struct samr_QueryDisplayInfo *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_GetDisplayEnumerationIndex(pipes_struct *p,
+                                         struct samr_GetDisplayEnumerationIndex *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_TestPrivateFunctionsDomain(pipes_struct *p,
+                                         struct samr_TestPrivateFunctionsDomain *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_TestPrivateFunctionsUser(pipes_struct *p,
+                                       struct samr_TestPrivateFunctionsUser *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_GetUserPwInfo(pipes_struct *p,
+                            struct samr_GetUserPwInfo *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_RemoveMemberFromForeignDomain(pipes_struct *p,
+                                            struct samr_RemoveMemberFromForeignDomain *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_QueryDomainInfo2(pipes_struct *p,
+                               struct samr_QueryDomainInfo2 *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_QueryUserInfo2(pipes_struct *p,
+                             struct samr_QueryUserInfo2 *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_QueryDisplayInfo2(pipes_struct *p,
+                                struct samr_QueryDisplayInfo2 *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_GetDisplayEnumerationIndex2(pipes_struct *p,
+                                          struct samr_GetDisplayEnumerationIndex2 *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_QueryDisplayInfo3(pipes_struct *p,
+                                struct samr_QueryDisplayInfo3 *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_AddMultipleMembersToAlias(pipes_struct *p,
+                                        struct samr_AddMultipleMembersToAlias *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_RemoveMultipleMembersFromAlias(pipes_struct *p,
+                                             struct samr_RemoveMultipleMembersFromAlias *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_OemChangePasswordUser2(pipes_struct *p,
+                                     struct samr_OemChangePasswordUser2 *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_Connect2(pipes_struct *p,
+                       struct samr_Connect2 *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_SetUserInfo2(pipes_struct *p,
+                           struct samr_SetUserInfo2 *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_SetBootKeyInformation(pipes_struct *p,
+                                    struct samr_SetBootKeyInformation *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_GetBootKeyInformation(pipes_struct *p,
+                                    struct samr_GetBootKeyInformation *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_Connect3(pipes_struct *p,
+                       struct samr_Connect3 *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_Connect4(pipes_struct *p,
+                       struct samr_Connect4 *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_ChangePasswordUser3(pipes_struct *p,
+                                  struct samr_ChangePasswordUser3 *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_Connect5(pipes_struct *p,
+                       struct samr_Connect5 *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_RidToSid(pipes_struct *p,
+                       struct samr_RidToSid *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_SetDsrmPassword(pipes_struct *p,
+                              struct samr_SetDsrmPassword *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+/****************************************************************
+****************************************************************/
+
+NTSTATUS _samr_ValidatePassword(pipes_struct *p,
+                               struct samr_ValidatePassword *r)
+{
+       p->rng_fault_state = true;
+       return NT_STATUS_NOT_IMPLEMENTED;
+}