s3: Remove use of iconv_convenience.
[samba.git] / source3 / rpc_server / srv_pipe_hnd.c
index fb7aca5c0fa2febbf9f3578d72962ce41f2dd3d3..847953d1862528914d9a1bb0ba7b02a36642aaae 100644 (file)
@@ -96,7 +96,7 @@ static struct pipes_struct *make_internal_rpc_pipe_p(TALLOC_CTX *mem_ctx,
        pipes_struct *p;
 
        DEBUG(4,("Create pipe requested %s\n",
-                get_pipe_name_from_iface(syntax)));
+                get_pipe_name_from_syntax(talloc_tos(), syntax)));
 
        p = TALLOC_ZERO_P(mem_ctx, struct pipes_struct);
 
@@ -105,9 +105,10 @@ static struct pipes_struct *make_internal_rpc_pipe_p(TALLOC_CTX *mem_ctx,
                return NULL;
        }
 
-       if ((p->mem_ctx = talloc_init("pipe %s %p",
-                                     get_pipe_name_from_iface(syntax),
-                                     p)) == NULL) {
+       p->mem_ctx = talloc_named(p, 0, "pipe %s %p",
+                                get_pipe_name_from_syntax(talloc_tos(),
+                                                          syntax), p);
+       if (p->mem_ctx == NULL) {
                DEBUG(0,("open_rpc_pipe_p: talloc_init failed.\n"));
                TALLOC_FREE(p);
                return NULL;
@@ -115,7 +116,6 @@ static struct pipes_struct *make_internal_rpc_pipe_p(TALLOC_CTX *mem_ctx,
 
        if (!init_pipe_handle_list(p, syntax)) {
                DEBUG(0,("open_rpc_pipe_p: init_pipe_handles failed.\n"));
-               talloc_destroy(p->mem_ctx);
                TALLOC_FREE(p);
                return NULL;
        }
@@ -129,7 +129,6 @@ static struct pipes_struct *make_internal_rpc_pipe_p(TALLOC_CTX *mem_ctx,
 
        if(!prs_init(&p->in_data.data, 128, p->mem_ctx, MARSHALL)) {
                DEBUG(0,("open_rpc_pipe_p: malloc fail for in_data struct.\n"));
-               talloc_destroy(p->mem_ctx);
                close_policy_by_pipe(p);
                TALLOC_FREE(p);
                return NULL;
@@ -138,7 +137,6 @@ static struct pipes_struct *make_internal_rpc_pipe_p(TALLOC_CTX *mem_ctx,
        p->server_info = copy_serverinfo(p, server_info);
        if (p->server_info == NULL) {
                DEBUG(0, ("open_rpc_pipe_p: copy_serverinfo failed\n"));
-               talloc_destroy(p->mem_ctx);
                close_policy_by_pipe(p);
                TALLOC_FREE(p);
                return NULL;
@@ -158,7 +156,7 @@ static struct pipes_struct *make_internal_rpc_pipe_p(TALLOC_CTX *mem_ctx,
        p->syntax = *syntax;
 
        DEBUG(4,("Created internal pipe %s (pipes_open=%d)\n",
-                get_pipe_name_from_iface(syntax), pipes_open));
+                get_pipe_name_from_syntax(talloc_tos(), syntax), pipes_open));
 
        talloc_set_destructor(p, close_internal_rpc_pipe_hnd);
 
@@ -176,7 +174,7 @@ static void set_incoming_fault(pipes_struct *p)
        p->in_data.pdu_received_len = 0;
        p->fault_state = True;
        DEBUG(10, ("set_incoming_fault: Setting fault state on pipe %s\n",
-                  get_pipe_name_from_iface(&p->syntax)));
+                  get_pipe_name_from_syntax(talloc_tos(), &p->syntax)));
 }
 
 /****************************************************************************
@@ -264,7 +262,7 @@ static ssize_t unmarshall_rpc_header(pipes_struct *p)
                 * AS/U doesn't set FIRST flag in a BIND packet it seems.
                 */
 
-               if ((p->hdr.pkt_type == RPC_REQUEST) && !(p->hdr.flags & RPC_FLG_FIRST)) {
+               if ((p->hdr.pkt_type == DCERPC_PKT_REQUEST) && !(p->hdr.flags & DCERPC_PFC_FLAG_FIRST)) {
                        /*
                         * Ensure that the FIRST flag is set. If not then we have
                         * a stream missmatch.
@@ -343,8 +341,9 @@ static void free_pipe_context(pipes_struct *p)
                         "%lu\n", (unsigned long)talloc_total_size(p->mem_ctx) ));
                talloc_free_children(p->mem_ctx);
        } else {
-               p->mem_ctx = talloc_init(
-                       "pipe %s %p", get_pipe_name_from_iface(&p->syntax), p);
+               p->mem_ctx = talloc_named(p, 0, "pipe %s %p",
+                                   get_pipe_name_from_syntax(talloc_tos(),
+                                                             &p->syntax), p);
                if (p->mem_ctx == NULL) {
                        p->fault_state = True;
                }
@@ -444,7 +443,7 @@ static bool process_request_pdu(pipes_struct *p, prs_struct *rpc_in_p)
                return False;
        }
 
-       if(p->hdr.flags & RPC_FLG_LAST) {
+       if(p->hdr.flags & DCERPC_PFC_FLAG_LAST) {
                bool ret = False;
                /*
                 * Ok - we finally have a complete RPC stream.
@@ -512,7 +511,7 @@ static void process_complete_pdu(pipes_struct *p)
 
        if(p->fault_state) {
                DEBUG(10,("process_complete_pdu: pipe %s in fault state.\n",
-                        get_pipe_name_from_iface(&p->syntax)));
+                         get_pipe_name_from_syntax(talloc_tos(), &p->syntax)));
                set_incoming_fault(p);
                setup_fault_pdu(p, NT_STATUS(DCERPC_FAULT_OP_RNG_ERROR));
                return;
@@ -534,35 +533,38 @@ static void process_complete_pdu(pipes_struct *p)
                        (unsigned int)p->hdr.pkt_type ));
 
        switch (p->hdr.pkt_type) {
-               case RPC_REQUEST:
+               case DCERPC_PKT_REQUEST:
                        reply = process_request_pdu(p, &rpc_in);
                        break;
 
-               case RPC_PING: /* CL request - ignore... */
+               case DCERPC_PKT_PING: /* CL request - ignore... */
                        DEBUG(0,("process_complete_pdu: Error. Connectionless packet type %u received on pipe %s.\n",
                                (unsigned int)p->hdr.pkt_type,
-                               get_pipe_name_from_iface(&p->syntax)));
+                                get_pipe_name_from_syntax(talloc_tos(),
+                                                          &p->syntax)));
                        break;
 
-               case RPC_RESPONSE: /* No responses here. */
-                       DEBUG(0,("process_complete_pdu: Error. RPC_RESPONSE received from client on pipe %s.\n",
-                               get_pipe_name_from_iface(&p->syntax)));
+               case DCERPC_PKT_RESPONSE: /* No responses here. */
+                       DEBUG(0,("process_complete_pdu: Error. DCERPC_PKT_RESPONSE received from client on pipe %s.\n",
+                                get_pipe_name_from_syntax(talloc_tos(),
+                                                          &p->syntax)));
                        break;
 
-               case RPC_FAULT:
-               case RPC_WORKING: /* CL request - reply to a ping when a call in process. */
-               case RPC_NOCALL: /* CL - server reply to a ping call. */
-               case RPC_REJECT:
-               case RPC_ACK:
-               case RPC_CL_CANCEL:
-               case RPC_FACK:
-               case RPC_CANCEL_ACK:
+               case DCERPC_PKT_FAULT:
+               case DCERPC_PKT_WORKING: /* CL request - reply to a ping when a call in process. */
+               case DCERPC_PKT_NOCALL: /* CL - server reply to a ping call. */
+               case DCERPC_PKT_REJECT:
+               case DCERPC_PKT_ACK:
+               case DCERPC_PKT_CL_CANCEL:
+               case DCERPC_PKT_FACK:
+               case DCERPC_PKT_CANCEL_ACK:
                        DEBUG(0,("process_complete_pdu: Error. Connectionless packet type %u received on pipe %s.\n",
                                (unsigned int)p->hdr.pkt_type,
-                               get_pipe_name_from_iface(&p->syntax)));
+                                get_pipe_name_from_syntax(talloc_tos(),
+                                                          &p->syntax)));
                        break;
 
-               case RPC_BIND:
+               case DCERPC_PKT_BIND:
                        /*
                         * We assume that a pipe bind is only in one pdu.
                         */
@@ -571,15 +573,16 @@ static void process_complete_pdu(pipes_struct *p)
                        }
                        break;
 
-               case RPC_BINDACK:
-               case RPC_BINDNACK:
-                       DEBUG(0,("process_complete_pdu: Error. RPC_BINDACK/RPC_BINDNACK packet type %u received on pipe %s.\n",
+               case DCERPC_PKT_BIND_ACK:
+               case DCERPC_PKT_BIND_NAK:
+                       DEBUG(0,("process_complete_pdu: Error. DCERPC_PKT_BINDACK/DCERPC_PKT_BINDNACK packet type %u received on pipe %s.\n",
                                (unsigned int)p->hdr.pkt_type,
-                               get_pipe_name_from_iface(&p->syntax)));
+                                get_pipe_name_from_syntax(talloc_tos(),
+                                                          &p->syntax)));
                        break;
 
 
-               case RPC_ALTCONT:
+               case DCERPC_PKT_ALTER:
                        /*
                         * We assume that a pipe bind is only in one pdu.
                         */
@@ -588,12 +591,13 @@ static void process_complete_pdu(pipes_struct *p)
                        }
                        break;
 
-               case RPC_ALTCONTRESP:
-                       DEBUG(0,("process_complete_pdu: Error. RPC_ALTCONTRESP on pipe %s: Should only be server -> client.\n",
-                               get_pipe_name_from_iface(&p->syntax)));
+               case DCERPC_PKT_ALTER_RESP:
+                       DEBUG(0,("process_complete_pdu: Error. DCERPC_PKT_ALTER_RESP on pipe %s: Should only be server -> client.\n",
+                                get_pipe_name_from_syntax(talloc_tos(),
+                                                          &p->syntax)));
                        break;
 
-               case RPC_AUTH3:
+               case DCERPC_PKT_AUTH3:
                        /*
                         * The third packet in an NTLMSSP auth exchange.
                         */
@@ -602,14 +606,15 @@ static void process_complete_pdu(pipes_struct *p)
                        }
                        break;
 
-               case RPC_SHUTDOWN:
-                       DEBUG(0,("process_complete_pdu: Error. RPC_SHUTDOWN on pipe %s: Should only be server -> client.\n",
-                               get_pipe_name_from_iface(&p->syntax)));
+               case DCERPC_PKT_SHUTDOWN:
+                       DEBUG(0,("process_complete_pdu: Error. DCERPC_PKT_SHUTDOWN on pipe %s: Should only be server -> client.\n",
+                                get_pipe_name_from_syntax(talloc_tos(),
+                                                          &p->syntax)));
                        break;
 
-               case RPC_CO_CANCEL:
+               case DCERPC_PKT_CO_CANCEL:
                        /* For now just free all client data and continue processing. */
-                       DEBUG(3,("process_complete_pdu: RPC_ORPHANED. Abandoning rpc call.\n"));
+                       DEBUG(3,("process_complete_pdu: DCERPC_PKT_CO_CANCEL. Abandoning rpc call.\n"));
                        /* As we never do asynchronous RPC serving, we can never cancel a
                           call (as far as I know). If we ever did we'd have to send a cancel_ack
                           reply. For now, just free all client data and continue processing. */
@@ -626,10 +631,10 @@ static void process_complete_pdu(pipes_struct *p)
                        break;
 #endif
 
-               case RPC_ORPHANED:
+               case DCERPC_PKT_ORPHANED:
                        /* We should probably check the auth-verifier here.
                           For now just free all client data and continue processing. */
-                       DEBUG(3,("process_complete_pdu: RPC_ORPHANED. Abandoning rpc call.\n"));
+                       DEBUG(3,("process_complete_pdu: DCERPC_PKT_ORPHANED. Abandoning rpc call.\n"));
                        reply = True;
                        break;
 
@@ -643,7 +648,8 @@ static void process_complete_pdu(pipes_struct *p)
 
        if (!reply) {
                DEBUG(3,("process_complete_pdu: DCE/RPC fault sent on "
-                        "pipe %s\n", get_pipe_name_from_iface(&p->syntax)));
+                        "pipe %s\n", get_pipe_name_from_syntax(talloc_tos(),
+                                                               &p->syntax)));
                set_incoming_fault(p);
                setup_fault_pdu(p, NT_STATUS(DCERPC_FAULT_OP_RNG_ERROR));
                prs_mem_free(&rpc_in);
@@ -712,7 +718,7 @@ incoming data size = %u\n", (unsigned int)p->in_data.pdu_received_len, (unsigned
                        return rret;
                }
                /* If rret == 0 and pdu_needed_len == 0 here we have a PDU that consists
-                  of an RPC_HEADER only. This is a RPC_SHUTDOWN, RPC_CO_CANCEL or RPC_ORPHANED
+                  of an RPC_HEADER only. This is a DCERPC_PKT_SHUTDOWN, DCERPC_PKT_CO_CANCEL or DCERPC_PKT_ORPHANED
                   pdu type. Deal with this in process_complete_pdu(). */
        }
 
@@ -798,7 +804,8 @@ static ssize_t read_from_internal_pipe(struct pipes_struct *p, char *data, size_
                return -1;              
        }
 
-       DEBUG(6,(" name: %s len: %u\n", get_pipe_name_from_iface(&p->syntax),
+       DEBUG(6,(" name: %s len: %u\n",
+                get_pipe_name_from_syntax(talloc_tos(), &p->syntax),
                 (unsigned int)n));
 
        /*
@@ -815,7 +822,8 @@ static ssize_t read_from_internal_pipe(struct pipes_struct *p, char *data, size_
        if(n > RPC_MAX_PDU_FRAG_LEN) {
                 DEBUG(5,("read_from_pipe: too large read (%u) requested on "
                         "pipe %s. We can only service %d sized reads.\n",
-                        (unsigned int)n, get_pipe_name_from_iface(&p->syntax),
+                        (unsigned int)n,
+                        get_pipe_name_from_syntax(talloc_tos(), &p->syntax),
                         RPC_MAX_PDU_FRAG_LEN ));
                n = RPC_MAX_PDU_FRAG_LEN;
        }
@@ -836,7 +844,7 @@ static ssize_t read_from_internal_pipe(struct pipes_struct *p, char *data, size_
 
                DEBUG(10,("read_from_pipe: %s: current_pdu_len = %u, "
                          "current_pdu_sent = %u returning %d bytes.\n",
-                         get_pipe_name_from_iface(&p->syntax),
+                         get_pipe_name_from_syntax(talloc_tos(), &p->syntax),
                          (unsigned int)prs_offset(&p->out_data.frag),
                          (unsigned int)p->out_data.current_pdu_sent,
                          (int)data_returned));
@@ -857,7 +865,8 @@ static ssize_t read_from_internal_pipe(struct pipes_struct *p, char *data, size_
 
        DEBUG(10,("read_from_pipe: %s: fault_state = %d : data_sent_length "
                  "= %u, prs_offset(&p->out_data.rdata) = %u.\n",
-                 get_pipe_name_from_iface(&p->syntax), (int)p->fault_state,
+                 get_pipe_name_from_syntax(talloc_tos(), &p->syntax),
+                 (int)p->fault_state,
                  (unsigned int)p->out_data.data_sent_length,
                  (unsigned int)prs_offset(&p->out_data.rdata) ));
 
@@ -878,7 +887,7 @@ static ssize_t read_from_internal_pipe(struct pipes_struct *p, char *data, size_
 
        if(!create_next_pdu(p)) {
                DEBUG(0,("read_from_pipe: %s: create_next_pdu failed.\n",
-                        get_pipe_name_from_iface(&p->syntax)));
+                        get_pipe_name_from_syntax(talloc_tos(), &p->syntax)));
                return -1;
        }
 
@@ -890,6 +899,13 @@ static ssize_t read_from_internal_pipe(struct pipes_struct *p, char *data, size_
   out:
        (*is_data_outstanding) = prs_offset(&p->out_data.frag) > n;
 
+       if (p->out_data.current_pdu_sent == prs_offset(&p->out_data.frag)) {
+               /* We've returned everything in the out_data.frag
+                * so we're done with this pdu. Free it and reset
+                * current_pdu_sent. */
+               p->out_data.current_pdu_sent = 0;
+               prs_mem_free(&p->out_data.frag);
+       }
        return data_returned;
 }
 
@@ -912,8 +928,6 @@ static int close_internal_rpc_pipe_hnd(struct pipes_struct *p)
                (*p->auth.auth_data_free_func)(&p->auth);
        }
 
-       TALLOC_FREE(p->mem_ctx);
-
        free_pipe_rpc_context( p->contexts );
 
        /* Free the handles database. */
@@ -923,9 +937,7 @@ static int close_internal_rpc_pipe_hnd(struct pipes_struct *p)
 
        ZERO_STRUCTP(p);
 
-       TALLOC_FREE(p);
-       
-       return True;
+       return 0;
 }
 
 bool fsp_is_np(struct files_struct *fsp)
@@ -943,8 +955,8 @@ bool fsp_is_np(struct files_struct *fsp)
 }
 
 struct np_proxy_state {
-       struct async_req_queue *read_queue;
-       struct async_req_queue *write_queue;
+       struct tevent_queue *read_queue;
+       struct tevent_queue *write_queue;
        int fd;
 
        uint8_t *msg;
@@ -1037,8 +1049,7 @@ static struct np_proxy_state *make_external_rpc_pipe_p(TALLOC_CTX *mem_ctx,
        req.level = 1;
        req.info.info1 = *info3;
 
-       ndr_err = ndr_push_struct_blob(
-               &req_blob, talloc_tos(), NULL, &req,
+       ndr_err = ndr_push_struct_blob(&req_blob, talloc_tos(), &req,
                (ndr_push_flags_fn_t)ndr_push_named_pipe_auth_req);
 
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
@@ -1068,8 +1079,7 @@ static struct np_proxy_state *make_external_rpc_pipe_p(TALLOC_CTX *mem_ctx,
        DEBUG(10,("name_pipe_auth_rep(client)[%u]\n", (uint32_t)rep_blob.length));
        dump_data(10, rep_blob.data, rep_blob.length);
 
-       ndr_err = ndr_pull_struct_blob(
-               &rep_blob, talloc_tos(), NULL, &rep,
+       ndr_err = ndr_pull_struct_blob(&rep_blob, talloc_tos(), &rep,
                (ndr_pull_flags_fn_t)ndr_pull_named_pipe_auth_rep);
 
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
@@ -1104,11 +1114,11 @@ static struct np_proxy_state *make_external_rpc_pipe_p(TALLOC_CTX *mem_ctx,
 
        result->msg = NULL;
 
-       result->read_queue = async_req_queue_init(result);
+       result->read_queue = tevent_queue_create(result, "np_read");
        if (result->read_queue == NULL) {
                goto fail;
        }
-       result->write_queue = async_req_queue_init(result);
+       result->write_queue = tevent_queue_create(result, "np_write");
        if (result->write_queue == NULL) {
                goto fail;
        }
@@ -1175,22 +1185,21 @@ struct np_write_state {
        ssize_t nwritten;
 };
 
-static void np_write_trigger(struct async_req *req);
 static void np_write_done(struct tevent_req *subreq);
 
-struct async_req *np_write_send(TALLOC_CTX *mem_ctx, struct event_context *ev,
-                               struct fake_file_handle *handle,
-                               const uint8_t *data, size_t len)
+struct tevent_req *np_write_send(TALLOC_CTX *mem_ctx, struct event_context *ev,
+                                struct fake_file_handle *handle,
+                                const uint8_t *data, size_t len)
 {
-       struct async_req *result;
+       struct tevent_req *req;
        struct np_write_state *state;
        NTSTATUS status;
 
        DEBUG(6, ("np_write_send: len: %d\n", (int)len));
        dump_data(50, data, len);
 
-       if (!async_req_setup(mem_ctx, &result, &state,
-                            struct np_write_state)) {
+       req = tevent_req_create(mem_ctx, &state, struct np_write_state);
+       if (req == NULL) {
                return NULL;
        }
 
@@ -1214,68 +1223,60 @@ struct async_req *np_write_send(TALLOC_CTX *mem_ctx, struct event_context *ev,
        if (handle->type == FAKE_FILE_TYPE_NAMED_PIPE_PROXY) {
                struct np_proxy_state *p = talloc_get_type_abort(
                        handle->private_data, struct np_proxy_state);
+               struct tevent_req *subreq;
 
                state->ev = ev;
                state->p = p;
                state->iov.iov_base = CONST_DISCARD(void *, data);
                state->iov.iov_len = len;
 
-               if (!async_req_enqueue(p->write_queue, ev, result,
-                                      np_write_trigger)) {
+               subreq = writev_send(state, ev, p->write_queue, p->fd,
+                                    false, &state->iov, 1);
+               if (subreq == NULL) {
                        goto fail;
                }
-               return result;
+               tevent_req_set_callback(subreq, np_write_done, req);
+               return req;
        }
 
        status = NT_STATUS_INVALID_HANDLE;
  post_status:
-       if (async_post_ntstatus(result, ev, status)) {
-               return result;
+       if (NT_STATUS_IS_OK(status)) {
+               tevent_req_done(req);
+       } else {
+               tevent_req_nterror(req, status);
        }
+       return tevent_req_post(req, ev);
  fail:
-       TALLOC_FREE(result);
+       TALLOC_FREE(req);
        return NULL;
 }
 
-static void np_write_trigger(struct async_req *req)
-{
-       struct np_write_state *state = talloc_get_type_abort(
-               req->private_data, struct np_write_state);
-       struct tevent_req *subreq;
-
-       subreq = writev_send(state, state->ev, NULL, state->p->fd,
-                            &state->iov, 1);
-       if (async_req_nomem(subreq, req)) {
-               return;
-       }
-       tevent_req_set_callback(subreq, np_write_done, req);
-}
-
 static void np_write_done(struct tevent_req *subreq)
 {
-       struct async_req *req =
-               tevent_req_callback_data(subreq, struct async_req);
-       struct np_write_state *state = talloc_get_type_abort(
-               req->private_data, struct np_write_state);
+       struct tevent_req *req = tevent_req_callback_data(
+               subreq, struct tevent_req);
+       struct np_write_state *state = tevent_req_data(
+               req, struct np_write_state);
        ssize_t received;
        int err;
 
        received = writev_recv(subreq, &err);
        if (received < 0) {
-               async_req_nterror(req, map_nt_error_from_unix(err));
+               tevent_req_nterror(req, map_nt_error_from_unix(err));
                return;
        }
        state->nwritten = received;
-       async_req_done(req);
+       tevent_req_done(req);
 }
 
-NTSTATUS np_write_recv(struct async_req *req, ssize_t *pnwritten)
+NTSTATUS np_write_recv(struct tevent_req *req, ssize_t *pnwritten)
 {
-       struct np_write_state *state = talloc_get_type_abort(
-               req->private_data, struct np_write_state);
+       struct np_write_state *state = tevent_req_data(
+               req, struct np_write_state);
        NTSTATUS status;
 
-       if (async_req_is_nterror(req, &status)) {
+       if (tevent_req_is_nterror(req, &status)) {
                return status;
        }
        *pnwritten = state->nwritten;
@@ -1313,19 +1314,19 @@ struct np_read_state {
        bool is_data_outstanding;
 };
 
-static void np_read_trigger(struct async_req *req);
+static void np_read_trigger(struct tevent_req *req, void *private_data);
 static void np_read_done(struct tevent_req *subreq);
 
-struct async_req *np_read_send(TALLOC_CTX *mem_ctx, struct event_context *ev,
-                              struct fake_file_handle *handle,
-                              uint8_t *data, size_t len)
+struct tevent_req *np_read_send(TALLOC_CTX *mem_ctx, struct event_context *ev,
+                               struct fake_file_handle *handle,
+                               uint8_t *data, size_t len)
 {
-       struct async_req *result;
+       struct tevent_req *req;
        struct np_read_state *state;
        NTSTATUS status;
 
-       if (!async_req_setup(mem_ctx, &result, &state,
-                            struct np_read_state)) {
+       req = tevent_req_create(mem_ctx, &state, struct np_read_state);
+       if (req == NULL) {
                return NULL;
        }
 
@@ -1370,32 +1371,35 @@ struct async_req *np_read_send(TALLOC_CTX *mem_ctx, struct event_context *ev,
                state->data = data;
                state->len = len;
 
-               if (!async_req_enqueue(p->read_queue, ev, result,
-                                      np_read_trigger)) {
+               if (!tevent_queue_add(p->read_queue, ev, req, np_read_trigger,
+                                     NULL)) {
                        goto fail;
                }
-               return result;
+               return req;
        }
 
        status = NT_STATUS_INVALID_HANDLE;
  post_status:
-       if (async_post_ntstatus(result, ev, status)) {
-               return result;
+       if (NT_STATUS_IS_OK(status)) {
+               tevent_req_done(req);
+       } else {
+               tevent_req_nterror(req, status);
        }
+       return tevent_req_post(req, ev);
  fail:
-       TALLOC_FREE(result);
+       TALLOC_FREE(req);
        return NULL;
 }
 
-static void np_read_trigger(struct async_req *req)
+static void np_read_trigger(struct tevent_req *req, void *private_data)
 {
-       struct np_read_state *state = talloc_get_type_abort(
-               req->private_data, struct np_read_state);
+       struct np_read_state *state = tevent_req_data(
+               req, struct np_read_state);
        struct tevent_req *subreq;
 
        subreq = read_packet_send(state, state->ev, state->p->fd,
                                  RPC_HEADER_LEN, rpc_frag_more_fn, NULL);
-       if (async_req_nomem(subreq, req)) {
+       if (tevent_req_nomem(subreq, req)) {
                return;
        }
        tevent_req_set_callback(subreq, np_read_done, req);
@@ -1403,10 +1407,10 @@ static void np_read_trigger(struct async_req *req)
 
 static void np_read_done(struct tevent_req *subreq)
 {
-       struct async_req *req =
-               tevent_req_callback_data(subreq, struct async_req);
-       struct np_read_state *state = talloc_get_type_abort(
-               req->private_data, struct np_read_state);
+       struct tevent_req *req = tevent_req_callback_data(
+               subreq, struct tevent_req);
+       struct np_read_state *state = tevent_req_data(
+               req, struct np_read_state);
        ssize_t received;
        size_t thistime;
        int err;
@@ -1414,7 +1418,7 @@ static void np_read_done(struct tevent_req *subreq)
        received = read_packet_recv(subreq, state->p, &state->p->msg, &err);
        TALLOC_FREE(subreq);
        if (received == -1) {
-               async_req_nterror(req, map_nt_error_from_unix(err));
+               tevent_req_nterror(req, map_nt_error_from_unix(err));
                return;
        }
 
@@ -1431,18 +1435,18 @@ static void np_read_done(struct tevent_req *subreq)
                state->is_data_outstanding = false;
        }
 
-       async_req_done(req);
+       tevent_req_done(req);
        return;
 }
 
-NTSTATUS np_read_recv(struct async_req *req, ssize_t *nread,
+NTSTATUS np_read_recv(struct tevent_req *req, ssize_t *nread,
                      bool *is_data_outstanding)
 {
-       struct np_read_state *state = talloc_get_type_abort(
-               req->private_data, struct np_read_state);
+       struct np_read_state *state = tevent_req_data(
+               req, struct np_read_state);
        NTSTATUS status;
 
-       if (async_req_is_nterror(req, &status)) {
+       if (tevent_req_is_nterror(req, &status)) {
                return status;
        }
        *nread = state->nread;
@@ -1451,7 +1455,33 @@ NTSTATUS np_read_recv(struct async_req *req, ssize_t *nread,
 }
 
 /**
- * Create a new RPC client context which uses a local dispatch function.
+ * @brief Create a new RPC client context which uses a local dispatch function.
+ *
+ * @param[in]  mem_ctx  The memory context to use.
+ *
+ * @param[in]  abstract_syntax Normally the syntax_id of the autogenerated
+ *                             ndr_table_<name>.
+ *
+ * @param[in]  dispatch The corresponding autogenerated dispatch function
+ *                      rpc_<name>_dispatch.
+ *
+ * @param[in]  serversupplied_info The server supplied authentication function.
+ *
+ * @param[out] presult  A pointer to store the connected rpc client pipe.
+ *
+ * @return              NT_STATUS_OK on success, a corresponding NT status if an
+ *                      error occured.
+ *
+ * @code
+ *   struct rpc_pipe_client *winreg_pipe;
+ *   NTSTATUS status;
+ *
+ *   status = rpc_pipe_open_internal(tmp_ctx,
+ *                                   &ndr_table_winreg.syntax_id,
+ *                                   rpc_winreg_dispatch,
+ *                                   p->server_info,
+ *                                   &winreg_pipe);
+ * @endcode
  */
 NTSTATUS rpc_pipe_open_internal(TALLOC_CTX *mem_ctx,
                                const struct ndr_syntax_id *abstract_syntax,