r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text
[bbaumbach/samba-autobuild/.git] / source3 / nsswitch / winbindd_user.c
index 6c544d7cf252648c4e9bf4f7923eac333078a757..198c54c039dbe3a105579df6b1c38f4eb8739ef8 100644 (file)
@@ -5,10 +5,11 @@
 
    Copyright (C) Tim Potter 2000
    Copyright (C) Jeremy Allison 2001.
+   Copyright (C) Gerald (Jerry) Carter 2003.
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
    GNU General Public License for more details.
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
+#include "includes.h"
 #include "winbindd.h"
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_WINBIND
 
+static BOOL fillup_pw_field(const char *lp_template, 
+                           const char *username, 
+                           const char *domname,
+                           uid_t uid,
+                           gid_t gid,
+                           const char *in, 
+                           fstring out)
+{
+       char *templ;
+
+       if (out == NULL)
+               return False;
+
+       /* The substitution of %U and %D in the 'template 
+          homedir' is done by talloc_sub_specified() below.
+          If we have an in string (which means the value has already
+          been set in the nss_info backend), then use that.
+          Otherwise use the template value passed in. */
+
+       if ( in && !strequal(in,"") && lp_security() == SEC_ADS ) {
+               templ = talloc_sub_specified(NULL, in, 
+                                            username, domname,
+                                    uid, gid);
+       } else {
+               templ = talloc_sub_specified(NULL, lp_template, 
+                                            username, domname,
+                                            uid, gid);         
+       }
+               
+       if (!templ)
+               return False;
+
+       safe_strcpy(out, templ, sizeof(fstring) - 1);
+       TALLOC_FREE(templ);
+               
+       return True;
+       
+}
 /* Fill a pwent structure with information we have obtained */
 
 static BOOL winbindd_fill_pwent(char *dom_name, char *user_name, 
-                               uint32 user_rid, uint32 group_rid, 
-                               char *full_name, struct winbindd_pw *pw)
+                               DOM_SID *user_sid, DOM_SID *group_sid,
+                               char *full_name, char *homedir, char *shell,
+                               struct winbindd_pw *pw)
 {
-       extern userdom_struct current_user_info;
        fstring output_username;
-       pstring homedir;
+       fstring sid_string;
        
        if (!pw || !dom_name || !user_name)
                return False;
        
        /* Resolve the uid number */
-       
-       if (!winbindd_idmap_get_uid_from_rid(dom_name, user_rid, 
-                                            &pw->pw_uid)) {
-               DEBUG(1, ("error getting user id for rid %d\n", user_rid));
+
+       if (!NT_STATUS_IS_OK(idmap_sid_to_uid(user_sid, &pw->pw_uid))) {
+               DEBUG(1, ("error getting user id for sid %s\n", sid_to_string(sid_string, user_sid)));
                return False;
        }
        
        /* Resolve the gid number */   
-       
-       if (!winbindd_idmap_get_gid_from_rid(dom_name, group_rid, 
-                                            &pw->pw_gid)) {
-               DEBUG(1, ("error getting group id for rid %d\n", group_rid));
+
+       if (!NT_STATUS_IS_OK(idmap_sid_to_gid(group_sid, &pw->pw_gid))) {
+               DEBUG(1, ("error getting group id for sid %s\n", sid_to_string(sid_string, group_sid)));
                return False;
        }
 
+       strlower_m(user_name);
+
        /* Username */
 
-       fill_domain_username(output_username, dom_name, user_name); 
+       fill_domain_username(output_username, dom_name, user_name, True); 
 
        safe_strcpy(pw->pw_name, output_username, sizeof(pw->pw_name) - 1);
        
@@ -65,195 +104,363 @@ static BOOL winbindd_fill_pwent(char *dom_name, char *user_name,
        
        safe_strcpy(pw->pw_gecos, full_name, sizeof(pw->pw_gecos) - 1);
 
-       /* Home directory and shell - use template config parameters.  The
-          defaults are /tmp for the home directory and /bin/false for
-          shell. */
+       /* Home directory and shell */
        
-       /* The substitution of %U and %D in the 'template homedir' is done
-          by lp_string() calling standard_sub_basic(). */
+       if (!fillup_pw_field(lp_template_homedir(), user_name, dom_name, 
+                            pw->pw_uid, pw->pw_gid, homedir, pw->pw_dir))
+               return False;
 
-       fstrcpy(current_user_info.smb_name, user_name);
-       sub_set_smb_name(user_name);
-       fstrcpy(current_user_info.domain, dom_name);
+       if (!fillup_pw_field(lp_template_shell(), user_name, dom_name, 
+                            pw->pw_uid, pw->pw_gid, shell, pw->pw_shell))
+               return False;
 
-       pstrcpy(homedir, lp_template_homedir());
-       
-       safe_strcpy(pw->pw_dir, homedir, sizeof(pw->pw_dir) - 1);
-       
-       safe_strcpy(pw->pw_shell, lp_template_shell(), 
-                   sizeof(pw->pw_shell) - 1);
-       
-       /* Password - set to "x" as we can't generate anything useful here.
+       /* Password - set to "*" as we can't generate anything useful here.
           Authentication can be done using the pam_winbind module. */
 
-       safe_strcpy(pw->pw_passwd, "x", sizeof(pw->pw_passwd) - 1);
-       
+       safe_strcpy(pw->pw_passwd, "*", sizeof(pw->pw_passwd) - 1);
+
        return True;
 }
 
-/* Return a password structure from a username.  */
+/* Wrapper for domain->methods->query_user, only on the parent->child pipe */
 
-enum winbindd_result winbindd_getpwnam(struct winbindd_cli_state *state) 
+enum winbindd_result winbindd_dual_userinfo(struct winbindd_domain *domain,
+                                           struct winbindd_cli_state *state)
 {
-       uint32 user_rid;
+       DOM_SID sid;
        WINBIND_USERINFO user_info;
-       DOM_SID user_sid;
        NTSTATUS status;
-       fstring name_domain, name_user;
-       enum SID_NAME_USE name_type;
-       struct winbindd_domain *domain;
-       TALLOC_CTX *mem_ctx;
-       
+
        /* Ensure null termination */
-       state->request.data.username[sizeof(state->request.data.username)-1]='\0';
+       state->request.data.sid[sizeof(state->request.data.sid)-1]='\0';
 
-       DEBUG(3, ("[%5d]: getpwnam %s\n", state->pid,
-                 state->request.data.username));
-       
-       /* Parse domain and username */
+       DEBUG(3, ("[%5lu]: lookupsid %s\n", (unsigned long)state->pid, 
+                 state->request.data.sid));
 
-       if (!parse_domain_user(state->request.data.username, name_domain, 
-                              name_user))
-               return WINBINDD_ERROR;
-       
-       if ((domain = find_domain_from_name(name_domain)) == NULL) {
-               DEBUG(5, ("no such domain: %s\n", name_domain));
+       if (!string_to_sid(&sid, state->request.data.sid)) {
+               DEBUG(5, ("%s not a SID\n", state->request.data.sid));
                return WINBINDD_ERROR;
        }
-       
-       /* Get rid and name type from name */
 
-       if (!winbindd_lookup_sid_by_name(domain, name_user, &user_sid, &name_type)) {
-               DEBUG(1, ("user '%s' does not exist\n", name_user));
+       status = domain->methods->query_user(domain, state->mem_ctx,
+                                            &sid, &user_info);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(1, ("error getting user info for sid %s\n",
+                         sid_string_static(&sid)));
                return WINBINDD_ERROR;
        }
 
-       if (name_type != SID_NAME_USER) {
-               DEBUG(1, ("name '%s' is not a user name: %d\n", name_user, 
-                         name_type));
+       fstrcpy(state->response.data.user_info.acct_name, user_info.acct_name);
+       fstrcpy(state->response.data.user_info.full_name, user_info.full_name);
+       fstrcpy(state->response.data.user_info.homedir, user_info.homedir);
+       fstrcpy(state->response.data.user_info.shell, user_info.shell);
+       state->response.data.user_info.primary_gid = user_info.primary_gid;     
+       if (!sid_peek_check_rid(&domain->sid, &user_info.group_sid,
+                               &state->response.data.user_info.group_rid)) {
+               DEBUG(1, ("Could not extract group rid out of %s\n",
+                         sid_string_static(&sid)));
                return WINBINDD_ERROR;
        }
+
+       return WINBINDD_OK;
+}
+
+struct getpwsid_state {
+       struct winbindd_cli_state *state;
+       struct winbindd_domain *domain;
+       char *username;
+       char *fullname;
+       char *homedir;
+       char *shell;
+       DOM_SID user_sid;
+       uid_t uid;
+       DOM_SID group_sid;
+       gid_t gid;
+};
+
+static void getpwsid_queryuser_recv(void *private_data, BOOL success,
+                                   const char *acct_name,
+                                   const char *full_name, 
+                                   const char *homedir,
+                                   const char *shell,
+                                   uint32 gid,
+                                   uint32 group_rid);
+static void getpwsid_sid2uid_recv(void *private_data, BOOL success, uid_t uid);
+static void getpwsid_sid2gid_recv(void *private_data, BOOL success, gid_t gid);
+
+static void winbindd_getpwsid(struct winbindd_cli_state *state,
+                             const DOM_SID *sid)
+{
+       struct getpwsid_state *s;
+
+       s = TALLOC_ZERO_P(state->mem_ctx, struct getpwsid_state);
+       if (s == NULL) {
+               DEBUG(0, ("talloc failed\n"));
+               goto error;
+       }
+
+       s->state = state;
+       s->domain = find_domain_from_sid_noinit(sid);
+       if (s->domain == NULL) {
+               DEBUG(3, ("Could not find domain for sid %s\n",
+                         sid_string_static(sid)));
+               goto error;
+       }
+
+       sid_copy(&s->user_sid, sid);
+
+       query_user_async(s->state->mem_ctx, s->domain, sid,
+                        getpwsid_queryuser_recv, s);
+       return;
+
+ error:
+       request_error(state);
+}
        
-       /* Get some user info.  Split the user rid from the sid obtained
-          from the winbind_lookup_by_name() call and use it in a
-          winbind_lookup_userinfo() */
-    
-       if (!(mem_ctx = talloc_init("winbindd_getpwnam([%s]\\[%s])", 
-                                         name_domain, name_user))) {
-               DEBUG(1, ("out of memory\n"));
-               return WINBINDD_ERROR;
+static void getpwsid_queryuser_recv(void *private_data, BOOL success,
+                                   const char *acct_name,
+                                   const char *full_name, 
+                                   const char *homedir,
+                                   const char *shell,
+                                   uint32 gid,
+                                   uint32 group_rid)
+{
+       fstring username;
+       struct getpwsid_state *s =
+               talloc_get_type_abort(private_data, struct getpwsid_state);
+
+       if (!success) {
+               DEBUG(5, ("Could not query domain %s SID %s\n", s->domain->name,
+                         sid_string_static(&s->user_sid)));
+               request_error(s->state);
+               return;
        }
 
-       sid_split_rid(&user_sid, &user_rid);
+       if ( acct_name && *acct_name ) {
+       fstrcpy( username, acct_name );
+       } else {                
+               char *domain_name = NULL;
+               enum lsa_SidType type;
+               char *user_name = NULL;
+               struct winbindd_domain *domain = NULL;
+               
+               domain = find_lookup_domain_from_sid(&s->user_sid);
+               winbindd_lookup_name_by_sid(s->state->mem_ctx, domain,
+                                           &s->user_sid, &domain_name,
+                                           &user_name, &type );                
+
+               /* If this still fails we ar4e done.  Just error out */
+               if ( !user_name ) {
+                       DEBUG(5,("Could not obtain a name for SID %s\n",
+                                sid_string_static(&s->user_sid)));                     
+                       request_error(s->state);
+                       return;                 
+               }
 
-       status = domain->methods->query_user(domain, mem_ctx, user_rid, 
-                                            &user_info);
+               fstrcpy( username, user_name );         
+       }
 
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(1, ("error getting user info for user '[%s]\\[%s]'\n", 
-                         name_domain, name_user));
-               talloc_destroy(mem_ctx);
-               return WINBINDD_ERROR;
+       strlower_m( username );
+       s->username = talloc_strdup(s->state->mem_ctx, username);
+
+       ws_name_replace( s->username, WB_REPLACE_CHAR );
+        
+       s->fullname = talloc_strdup(s->state->mem_ctx, full_name);
+       s->homedir = talloc_strdup(s->state->mem_ctx, homedir);
+       s->shell = talloc_strdup(s->state->mem_ctx, shell);
+       s->gid = gid;   
+       sid_copy(&s->group_sid, &s->domain->sid);
+       sid_append_rid(&s->group_sid, group_rid);
+
+       winbindd_sid2uid_async(s->state->mem_ctx, &s->user_sid,
+                              getpwsid_sid2uid_recv, s);
+}
+
+static void getpwsid_sid2uid_recv(void *private_data, BOOL success, uid_t uid)
+{
+       struct getpwsid_state *s =
+               talloc_get_type_abort(private_data, struct getpwsid_state);
+
+       if (!success) {
+               DEBUG(5, ("Could not query uid for user %s\\%s\n",
+                         s->domain->name, s->username));
+               request_error(s->state);
+               return;
        }
-    
-       /* Now take all this information and fill in a passwd structure */      
-       if (!winbindd_fill_pwent(name_domain, name_user, 
-                                user_rid, user_info.group_rid, 
-                                user_info.full_name,
-                                &state->response.data.pw)) {
-               talloc_destroy(mem_ctx);
-               return WINBINDD_ERROR;
+
+       s->uid = uid;
+       winbindd_sid2gid_async(s->state->mem_ctx, &s->group_sid,
+                              getpwsid_sid2gid_recv, s);
+}
+
+static void getpwsid_sid2gid_recv(void *private_data, BOOL success, gid_t gid)
+{
+       struct getpwsid_state *s =
+               talloc_get_type_abort(private_data, struct getpwsid_state);
+       struct winbindd_pw *pw;
+       fstring output_username;
+
+       /* allow the nss backend to override the primary group ID.
+          If the gid has already been set, then keep it.
+          This makes me feel dirty.  If the nss backend already
+          gave us a gid, we don't really care whether the sid2gid()
+          call worked or not.   --jerry  */
+
+       if ( s->gid == (gid_t)-1 ) {
+
+               if (!success) {
+                       DEBUG(5, ("Could not query gid for user %s\\%s\n",
+                                 s->domain->name, s->username));
+                       goto failed;
+               }
+
+               /* take what the sid2gid() call gave us */
+               s->gid = gid;
        }
 
-       talloc_destroy(mem_ctx);
-       
-       return WINBINDD_OK;
-}       
+       pw = &s->state->response.data.pw;
+       pw->pw_uid = s->uid;
+       pw->pw_gid = s->gid;
+       fill_domain_username(output_username, s->domain->name, s->username, True); 
+       safe_strcpy(pw->pw_name, output_username, sizeof(pw->pw_name) - 1);
+       safe_strcpy(pw->pw_gecos, s->fullname, sizeof(pw->pw_gecos) - 1);
 
-/* Return a password structure given a uid number */
+       if (!fillup_pw_field(lp_template_homedir(), s->username, s->domain->name, 
+                            pw->pw_uid, pw->pw_gid, s->homedir, pw->pw_dir)) {
+               DEBUG(5, ("Could not compose homedir\n"));
+               goto failed;
+       }
+
+       if (!fillup_pw_field(lp_template_shell(), s->username, s->domain->name, 
+                            pw->pw_uid, pw->pw_gid, s->shell, pw->pw_shell)) {
+               DEBUG(5, ("Could not compose shell\n"));
+               goto failed;
+       }
+
+       /* Password - set to "*" as we can't generate anything useful here.
+          Authentication can be done using the pam_winbind module. */
+
+       safe_strcpy(pw->pw_passwd, "*", sizeof(pw->pw_passwd) - 1);
+
+       request_ok(s->state);
+       return;
 
-enum winbindd_result winbindd_getpwuid(struct winbindd_cli_state *state)
+ failed:
+       request_error(s->state);
+}
+
+/* Return a password structure from a username.  */
+
+static void getpwnam_name2sid_recv(void *private_data, BOOL success,
+                                  const DOM_SID *sid, enum lsa_SidType type);
+
+void winbindd_getpwnam(struct winbindd_cli_state *state)
 {
-       DOM_SID user_sid;
        struct winbindd_domain *domain;
-       uint32 user_rid;
-       fstring dom_name;
-       fstring user_name;
-       enum SID_NAME_USE name_type;
-       WINBIND_USERINFO user_info;
-       gid_t gid;
-       TALLOC_CTX *mem_ctx;
-       NTSTATUS status;
-       
-       /* Bug out if the uid isn't in the winbind range */
+       fstring domname, username;
 
-       if ((state->request.data.uid < server_state.uid_low ) ||
-           (state->request.data.uid > server_state.uid_high))
-               return WINBINDD_ERROR;
+       /* Ensure null termination */
+       state->request.data.username[sizeof(state->request.data.username)-1]='\0';
 
-       DEBUG(3, ("[%5d]: getpwuid %d\n", state->pid, 
-                 state->request.data.uid));
-       
-       /* Get rid from uid */
+       DEBUG(3, ("[%5lu]: getpwnam %s\n", (unsigned long)state->pid,
+                 state->request.data.username));
 
-       if (!winbindd_idmap_get_rid_from_uid(state->request.data.uid, 
-                                            &user_rid, &domain)) {
-               DEBUG(1, ("could not convert uid %d to rid\n", 
-                         state->request.data.uid));
-               return WINBINDD_ERROR;
-       }
-       
-       /* Get name and name type from rid */
+       ws_name_return( state->request.data.username, WB_REPLACE_CHAR );
 
-       sid_copy(&user_sid, &domain->sid);
-       sid_append_rid(&user_sid, user_rid);
-       
-       if (!winbindd_lookup_name_by_sid(&user_sid, dom_name, user_name, &name_type)) {
-               fstring temp;
-               
-               sid_to_string(temp, &user_sid);
-               DEBUG(1, ("could not lookup sid %s\n", temp));
-               return WINBINDD_ERROR;
+       if (!parse_domain_user(state->request.data.username, domname,
+                              username)) {
+               DEBUG(5, ("Could not parse domain user: %s\n",
+                         state->request.data.username));
+               request_error(state);
+               return;
        }
        
-       /* Get some user info */
-       
-       if (!(mem_ctx = talloc_init("winbind_getpwuid(%d)",
-                                         state->request.data.uid))) {
+       /* Get info for the domain */
 
-               DEBUG(1, ("out of memory\n"));
-               return WINBINDD_ERROR;
+       domain = find_domain_from_name(domname);
+
+       if (domain == NULL) {
+               DEBUG(7, ("could not find domain entry for domain %s.  "
+                         "Using primary domain\n", domname));
+               if ( (domain = find_our_domain()) == NULL ) {
+                       DEBUG(0,("Cannot find my primary domain structure!\n"));
+               request_error(state);
+               return;
+       }
        }
 
-       status = domain->methods->query_user(domain, mem_ctx, user_rid, 
-                                            &user_info);
+       if ( strequal(domname, lp_workgroup()) && lp_winbind_trusted_domains_only() ) {
+               DEBUG(7,("winbindd_getpwnam: My domain -- rejecting getpwnam() for %s\\%s.\n", 
+                       domname, username));
+               request_error(state);
+               return;
+       }       
 
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(1, ("error getting user info for user '%s'\n", 
-                         user_name));
-               talloc_destroy(mem_ctx);
-               return WINBINDD_ERROR;
+       /* Get rid and name type from name.  The following costs 1 packet */
+
+       winbindd_lookupname_async(state->mem_ctx, domname, username,
+                                 getpwnam_name2sid_recv, WINBINDD_GETPWNAM, 
+                                 state);
+}
+
+static void getpwnam_name2sid_recv(void *private_data, BOOL success,
+                                  const DOM_SID *sid, enum lsa_SidType type)
+{
+       struct winbindd_cli_state *state =
+               (struct winbindd_cli_state *)private_data;
+       fstring domname, username;      
+
+       if (!success) {
+               DEBUG(5, ("Could not lookup name for user %s\n",
+                         state->request.data.username));
+               request_error(state);
+               return;
        }
-       
-       /* Resolve gid number */
 
-       if (!winbindd_idmap_get_gid_from_rid(domain->name, user_info.group_rid, &gid)) {
-               DEBUG(1, ("error getting group id for user %s\n", user_name));
-               talloc_destroy(mem_ctx);
-               return WINBINDD_ERROR;
+       if ((type != SID_NAME_USER) && (type != SID_NAME_COMPUTER)) {
+               DEBUG(5, ("%s is not a user\n", state->request.data.username));
+               request_error(state);
+               return;
        }
 
-       /* Fill in password structure */
+       if ( parse_domain_user(state->request.data.username, domname, username) ) {
+               check_domain_trusted( domname, sid );   
+       }
 
-       if (!winbindd_fill_pwent(domain->name, user_name, user_rid, user_info.group_rid,
-                                user_info.full_name, &state->response.data.pw)) {
-               talloc_destroy(mem_ctx);
-               return WINBINDD_ERROR;
+
+
+       winbindd_getpwsid(state, sid);
+}
+
+static void getpwuid_recv(void *private_data, BOOL success, const char *sid)
+{
+       struct winbindd_cli_state *state =
+               (struct winbindd_cli_state *)private_data;
+       DOM_SID user_sid;
+
+       if (!success) {
+               DEBUG(10,("uid2sid_recv: uid [%lu] to sid mapping failed\n.",
+                         (unsigned long)(state->request.data.uid)));
+               request_error(state);
+               return;
        }
        
-       talloc_destroy(mem_ctx);
+       DEBUG(10,("uid2sid_recv: uid %lu has sid %s\n",
+                 (unsigned long)(state->request.data.uid), sid));
 
-       return WINBINDD_OK;
+       string_to_sid(&user_sid, sid);
+       winbindd_getpwsid(state, &user_sid);
+}
+
+/* Return a password structure given a uid number */
+void winbindd_getpwuid(struct winbindd_cli_state *state)
+{
+       DEBUG(3, ("[%5lu]: getpwuid %lu\n", (unsigned long)state->pid, 
+                 (unsigned long)state->request.data.uid));
+
+       /* always query idmap via the async interface */
+       /* if this turns to be too slow we will add here a direct query to the cache */
+       winbindd_uid2sid_async(state->mem_ctx, state->request.data.uid, getpwuid_recv, state);
 }
 
 /*
@@ -262,16 +469,17 @@ enum winbindd_result winbindd_getpwuid(struct winbindd_cli_state *state)
 
 /* Rewind file pointer for ntdom passwd database */
 
-enum winbindd_result winbindd_setpwent(struct winbindd_cli_state *state)
+static BOOL winbindd_setpwent_internal(struct winbindd_cli_state *state)
 {
        struct winbindd_domain *domain;
         
-       DEBUG(3, ("[%5d]: setpwent\n", state->pid));
+       DEBUG(3, ("[%5lu]: setpwent\n", (unsigned long)state->pid));
         
        /* Check user has enabled this */
         
-       if (!lp_winbind_enum_users())
-               return WINBINDD_ERROR;
+       if (!lp_winbind_enum_users()) {
+               return False;
+       }
 
        /* Free old static data if it exists */
         
@@ -279,17 +487,41 @@ enum winbindd_result winbindd_setpwent(struct winbindd_cli_state *state)
                free_getent_state(state->getpwent_state);
                state->getpwent_state = NULL;
        }
+
+#if 0  /* JERRY */
+       /* add any local users we have */
+               
+       if ( (domain_state = (struct getent_state *)malloc(sizeof(struct getent_state))) == NULL )
+               return False;
+                
+       ZERO_STRUCTP(domain_state);
+
+       /* Add to list of open domains */
+                
+       DLIST_ADD(state->getpwent_state, domain_state);
+#endif
         
        /* Create sam pipes for each domain we know about */
         
        for(domain = domain_list(); domain != NULL; domain = domain->next) {
                struct getent_state *domain_state;
                 
+               
+               /* don't add our domaina if we are a PDC or if we 
+                  are a member of a Samba domain */
+               
+               if ( (IS_DC || lp_winbind_trusted_domains_only())
+                       && strequal(domain->name, lp_workgroup()) )
+               {
+                       continue;
+               }
+                                               
                /* Create a state record for this domain */
                 
-               if ((domain_state = (struct getent_state *)
-                    malloc(sizeof(struct getent_state))) == NULL)
-                       return WINBINDD_ERROR;
+               if ((domain_state = SMB_MALLOC_P(struct getent_state)) == NULL) {
+                       DEBUG(0, ("malloc failed\n"));
+                       return False;
+               }
                 
                ZERO_STRUCTP(domain_state);
 
@@ -300,19 +532,29 @@ enum winbindd_result winbindd_setpwent(struct winbindd_cli_state *state)
                DLIST_ADD(state->getpwent_state, domain_state);
        }
         
-       return WINBINDD_OK;
+       state->getpwent_initialized = True;
+       return True;
+}
+
+void winbindd_setpwent(struct winbindd_cli_state *state)
+{
+       if (winbindd_setpwent_internal(state)) {
+               request_ok(state);
+       } else {
+               request_error(state);
+       }
 }
 
 /* Close file pointer to ntdom passwd database */
 
-enum winbindd_result winbindd_endpwent(struct winbindd_cli_state *state)
+void winbindd_endpwent(struct winbindd_cli_state *state)
 {
-       DEBUG(3, ("[%5d]: endpwent\n", state->pid));
+       DEBUG(3, ("[%5lu]: endpwent\n", (unsigned long)state->pid));
 
        free_getent_state(state->getpwent_state);    
+       state->getpwent_initialized = False;
        state->getpwent_state = NULL;
-        
-       return WINBINDD_OK;
+       request_ok(state);
 }
 
 /* Get partial list of domain users for a domain.  We fill in the sam_entries,
@@ -320,27 +562,19 @@ enum winbindd_result winbindd_endpwent(struct winbindd_cli_state *state)
    field is incremented to the index of the next user to fetch.  Return True if
    some users were returned, False otherwise. */
 
-#define MAX_FETCH_SAM_ENTRIES 100
-
-static BOOL get_sam_user_entries(struct getent_state *ent)
+static BOOL get_sam_user_entries(struct getent_state *ent, TALLOC_CTX *mem_ctx)
 {
        NTSTATUS status;
        uint32 num_entries;
        WINBIND_USERINFO *info;
        struct getpwent_user *name_list = NULL;
-       BOOL result = False;
-       TALLOC_CTX *mem_ctx;
        struct winbindd_domain *domain;
        struct winbindd_methods *methods;
-       int i;
+       unsigned int i;
 
        if (ent->num_sam_entries)
                return False;
 
-       if (!(mem_ctx = talloc_init("get_sam_user_entries(%s)",
-                                         ent->domain_name)))
-               return False;
-
        if (!(domain = find_domain_from_name(ent->domain_name))) {
                DEBUG(3, ("no such domain %s in get_sam_user_entries\n",
                          ent->domain_name));
@@ -361,20 +595,19 @@ static BOOL get_sam_user_entries(struct getent_state *ent)
        status = methods->query_user_list(domain, mem_ctx, &num_entries, 
                                          &info);
                
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(10,("get_sam_user_entries: query_user_list failed with %s\n",
+                       nt_errstr(status) ));
+               return False;
+       }
+
        if (num_entries) {
-               struct getpwent_user *tnl;
+               name_list = SMB_REALLOC_ARRAY(name_list, struct getpwent_user, ent->num_sam_entries + num_entries);
                
-               tnl = (struct getpwent_user *)Realloc(name_list, 
-                                                     sizeof(struct getpwent_user) *
-                                                     (ent->num_sam_entries + 
-                                                      num_entries));
-               
-               if (!tnl) {
+               if (!name_list) {
                        DEBUG(0,("get_sam_user_entries realloc failed.\n"));
-                       SAFE_FREE(name_list);
-                       goto done;
-               } else
-                       name_list = tnl;
+                       return False;
+               }
        }
 
        for (i = 0; i < num_entries; i++) {
@@ -391,10 +624,25 @@ static BOOL get_sam_user_entries(struct getent_state *ent)
                        fstrcpy(name_list[ent->num_sam_entries + i].gecos, 
                                info[i].full_name); 
                }
-               
+               if (!info[i].homedir) {
+                       fstrcpy(name_list[ent->num_sam_entries + i].homedir, "");
+               } else {
+                       fstrcpy(name_list[ent->num_sam_entries + i].homedir, 
+                               info[i].homedir); 
+               }
+               if (!info[i].shell) {
+                       fstrcpy(name_list[ent->num_sam_entries + i].shell, "");
+               } else {
+                       fstrcpy(name_list[ent->num_sam_entries + i].shell, 
+                               info[i].shell); 
+               }
+       
+       
                /* User and group ids */
-               name_list[ent->num_sam_entries+i].user_rid = info[i].user_rid;
-               name_list[ent->num_sam_entries+i].group_rid = info[i].group_rid;
+               sid_copy(&name_list[ent->num_sam_entries+i].user_sid,
+                        &info[i].user_sid);
+               sid_copy(&name_list[ent->num_sam_entries+i].group_sid,
+                        &info[i].group_sid);
        }
                
        ent->num_sam_entries += num_entries;
@@ -403,51 +651,58 @@ static BOOL get_sam_user_entries(struct getent_state *ent)
        
        ent->sam_entries = name_list;
        ent->sam_entry_index = 0;
-       result = ent->num_sam_entries > 0;
-
- done:
-
-       talloc_destroy(mem_ctx);
-
-       return result;
+       return ent->num_sam_entries > 0;
 }
 
 /* Fetch next passwd entry from ntdom database */
 
 #define MAX_GETPWENT_USERS 500
 
-enum winbindd_result winbindd_getpwent(struct winbindd_cli_state *state)
+void winbindd_getpwent(struct winbindd_cli_state *state)
 {
        struct getent_state *ent;
        struct winbindd_pw *user_list;
-       int num_users, user_list_ndx = 0, i;
+       int num_users, user_list_ndx;
 
-       DEBUG(3, ("[%5d]: getpwent\n", state->pid));
+       DEBUG(3, ("[%5lu]: getpwent\n", (unsigned long)state->pid));
 
        /* Check user has enabled this */
 
-       if (!lp_winbind_enum_users())
-               return WINBINDD_ERROR;
+       if (!lp_winbind_enum_users()) {
+               request_error(state);
+               return;
+       }
 
        /* Allocate space for returning a chunk of users */
 
        num_users = MIN(MAX_GETPWENT_USERS, state->request.data.num_entries);
+
+       if (num_users == 0) {
+               request_error(state);
+               return;
+       }
        
-       if ((state->response.extra_data = 
-            malloc(num_users * sizeof(struct winbindd_pw))) == NULL)
-               return WINBINDD_ERROR;
+       if ((state->response.extra_data.data = SMB_MALLOC_ARRAY(struct winbindd_pw, num_users)) == NULL) {
+               request_error(state);
+               return;
+       }
 
-       memset(state->response.extra_data, 0, num_users * 
+       memset(state->response.extra_data.data, 0, num_users * 
               sizeof(struct winbindd_pw));
 
-       user_list = (struct winbindd_pw *)state->response.extra_data;
+       user_list = (struct winbindd_pw *)state->response.extra_data.data;
+
+       if (!state->getpwent_initialized)
+               winbindd_setpwent_internal(state);
        
-       if (!(ent = state->getpwent_state))
-               return WINBINDD_ERROR;
+       if (!(ent = state->getpwent_state)) {
+               request_error(state);
+               return;
+       }
 
        /* Start sending back users */
 
-       for (i = 0; i < num_users; i++) {
+       for (user_list_ndx = 0; user_list_ndx < num_users; ) {
                struct getpwent_user *name_list = NULL;
                uint32 result;
 
@@ -455,7 +710,8 @@ enum winbindd_result winbindd_getpwent(struct winbindd_cli_state *state)
 
                if (ent->num_sam_entries == ent->sam_entry_index) {
 
-                       while(ent && !get_sam_user_entries(ent)) {
+                       while(ent &&
+                             !get_sam_user_entries(ent, state->mem_ctx)) {
                                struct getent_state *next_ent;
 
                                /* Free state information for this domain */
@@ -475,29 +731,20 @@ enum winbindd_result winbindd_getpwent(struct winbindd_cli_state *state)
                                break;
                }
 
-               name_list = ent->sam_entries;
-
-               /* Skip machine accounts */
-
-               if (name_list[ent->sam_entry_index].
-                   name[strlen(name_list[ent->sam_entry_index].name) - 1] 
-                   == '$') {
-                       ent->sam_entry_index++;
-                       continue;
-               }
+               name_list = (struct getpwent_user *)ent->sam_entries;
 
                /* Lookup user info */
                
                result = winbindd_fill_pwent(
                        ent->domain_name, 
                        name_list[ent->sam_entry_index].name,
-                       name_list[ent->sam_entry_index].user_rid,
-                       name_list[ent->sam_entry_index].group_rid,
+                       &name_list[ent->sam_entry_index].user_sid,
+                       &name_list[ent->sam_entry_index].group_sid,
                        name_list[ent->sam_entry_index].gecos,
+                       name_list[ent->sam_entry_index].homedir,
+                       name_list[ent->sam_entry_index].shell,
                        &user_list[user_list_ndx]);
                
-               ent->sam_entry_index++;
-               
                /* Add user to return list */
                
                if (result) {
@@ -510,58 +757,75 @@ enum winbindd_result winbindd_getpwent(struct winbindd_cli_state *state)
                } else
                        DEBUG(1, ("could not lookup domain user %s\n",
                                  name_list[ent->sam_entry_index].name));
+
+               ent->sam_entry_index++;
+               
        }
 
        /* Out of domains */
 
-       return (user_list_ndx > 0) ? WINBINDD_OK : WINBINDD_ERROR;
+       if (user_list_ndx > 0)
+               request_ok(state);
+       else
+               request_error(state);
 }
 
 /* List domain users without mapping to unix ids */
 
-enum winbindd_result winbindd_list_users(struct winbindd_cli_state *state)
+void winbindd_list_users(struct winbindd_cli_state *state)
 {
        struct winbindd_domain *domain;
        WINBIND_USERINFO *info;
+       const char *which_domain;
        uint32 num_entries = 0, total_entries = 0;
-       char *ted, *extra_data = NULL;
+       char *extra_data = NULL;
        int extra_data_len = 0;
-       TALLOC_CTX *mem_ctx;
        enum winbindd_result rv = WINBINDD_ERROR;
 
-       DEBUG(3, ("[%5d]: list users\n", state->pid));
-
-       if (!(mem_ctx = talloc_init("winbindd_list_users")))
-               return WINBINDD_ERROR;
+       DEBUG(3, ("[%5lu]: list users\n", (unsigned long)state->pid));
 
+       /* Ensure null termination */
+       state->request.domain_name[sizeof(state->request.domain_name)-1]='\0';  
+       which_domain = state->request.domain_name;
+       
        /* Enumerate over trusted domains */
 
        for (domain = domain_list(); domain; domain = domain->next) {
                NTSTATUS status;
                struct winbindd_methods *methods;
-               int i;
-
+               unsigned int i;
+               
+               /* if we have a domain name restricting the request and this
+                  one in the list doesn't match, then just bypass the remainder
+                  of the loop */
+                  
+               if ( *which_domain && !strequal(which_domain, domain->name) )
+                       continue;
+                       
                methods = domain->methods;
 
                /* Query display info */
-               status = methods->query_user_list(domain, mem_ctx, 
+               status = methods->query_user_list(domain, state->mem_ctx, 
                                                  &num_entries, &info);
 
+               if (!NT_STATUS_IS_OK(status)) {
+                       continue;
+               }
+
                if (num_entries == 0)
                        continue;
 
                /* Allocate some memory for extra data */
                total_entries += num_entries;
                        
-               ted = Realloc(extra_data, sizeof(fstring) * total_entries);
+               extra_data = (char *)SMB_REALLOC(
+                       extra_data, sizeof(fstring) * total_entries);
                        
-               if (!ted) {
+               if (!extra_data) {
                        DEBUG(0,("failed to enlarge buffer!\n"));
-                       SAFE_FREE(extra_data);
                        goto done;
-               } else 
-                       extra_data = ted;
-                       
+               }
+
                /* Pack user list into extra data fields */
                        
                for (i = 0; i < num_entries; i++) {
@@ -573,7 +837,7 @@ enum winbindd_result winbindd_list_users(struct winbindd_cli_state *state)
                                fstrcpy(acct_name, info[i].acct_name);
                        }
                        
-                       fill_domain_username(name, domain->name, acct_name);
+                       fill_domain_username(name, domain->name, acct_name, True);
                        
                                /* Append to extra data */
                        memcpy(&extra_data[extra_data_len], name, 
@@ -587,7 +851,7 @@ enum winbindd_result winbindd_list_users(struct winbindd_cli_state *state)
 
        if (extra_data) {
                extra_data[extra_data_len - 1] = '\0';
-               state->response.extra_data = extra_data;
+               state->response.extra_data.data = extra_data;
                state->response.length += extra_data_len;
        }
 
@@ -598,7 +862,8 @@ enum winbindd_result winbindd_list_users(struct winbindd_cli_state *state)
 
  done:
 
-       talloc_destroy(mem_ctx);
-
-       return rv;
+       if (rv == WINBINDD_OK)
+               request_ok(state);
+       else
+               request_error(state);
 }