Merge branch 'work/v3-2-test' into v3-2-test
[ira/wip.git] / source3 / nmbd / nmbd_synclists.c
index 28ad92ed108022ac277e51cd7d7c175c349f868b..147df68a69d9787ebf039ed68ed80c5d4278c546 100644 (file)
@@ -7,7 +7,7 @@
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
@@ -16,8 +16,7 @@
    GNU General Public License for more details.
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
    
 */
 
 
 #include "includes.h"
 
-extern fstring local_machine;
-
 struct sync_record {
        struct sync_record *next, *prev;
        unstring workgroup;
        unstring server;
-       pstring fname;
+       char *fname;
        struct in_addr ip;
        pid_t pid;
 };
@@ -64,62 +61,76 @@ static void callback(const char *sname, uint32 stype,
 
 static void sync_child(char *name, int nm_type, 
                       char *workgroup,
-                      struct in_addr ip, BOOL local, BOOL servers,
+                      struct in_addr ip, bool local, bool servers,
                       char *fname)
 {
        fstring unix_workgroup;
-       static struct cli_state cli;
+       struct cli_state *cli;
        uint32 local_type = local ? SV_TYPE_LOCAL_LIST_ONLY : 0;
        struct nmb_name called, calling;
+       struct sockaddr_storage ss;
+       NTSTATUS status;
 
        /* W2K DMB's return empty browse lists on port 445. Use 139.
         * Patch from Andy Levine andyl@epicrealm.com.
         */
 
-       if (!cli_initialise(&cli) || !cli_set_port(&cli, 139) || !cli_connect(&cli, name, &ip)) {
+       cli = cli_initialise();
+       if (!cli) {
                return;
        }
 
-       make_nmb_name(&calling, local_machine, 0x0);
+       if (!cli_set_port(cli, 139)) {
+               return;
+       }
+
+       in_addr_to_sockaddr_storage(&ss, ip);
+       status = cli_connect(cli, name, &ss);
+       if (!NT_STATUS_IS_OK(status)) {
+               return;
+       }
+
+       make_nmb_name(&calling, get_local_machine_name(), 0x0);
        make_nmb_name(&called , name, nm_type);
 
-       if (!cli_session_request(&cli, &calling, &called)) {
-               cli_shutdown(&cli);
+       if (!cli_session_request(cli, &calling, &called)) {
+               cli_shutdown(cli);
                return;
        }
 
-       if (!cli_negprot(&cli)) {
-               cli_shutdown(&cli);
+       if (!cli_negprot(cli)) {
+               cli_shutdown(cli);
                return;
        }
 
-       if (!cli_session_setup(&cli, "", "", 1, "", 0, workgroup)) {
-               cli_shutdown(&cli);
+       if (!NT_STATUS_IS_OK(cli_session_setup(cli, "", "", 1, "", 0,
+                                              workgroup))) {
+               cli_shutdown(cli);
                return;
        }
 
-       if (!cli_send_tconX(&cli, "IPC$", "IPC", "", 1)) {
-               cli_shutdown(&cli);
+       if (!cli_send_tconX(cli, "IPC$", "IPC", "", 1)) {
+               cli_shutdown(cli);
                return;
        }
 
        /* All the cli_XX functions take UNIX character set. */
-       fstrcpy(unix_workgroup, cli.server_domain?cli.server_domain:workgroup);
+       fstrcpy(unix_workgroup, cli->server_domain ? cli->server_domain : workgroup);
 
        /* Fetch a workgroup list. */
-       cli_NetServerEnum(&cli, unix_workgroup,
+       cli_NetServerEnum(cli, unix_workgroup,
                          local_type|SV_TYPE_DOMAIN_ENUM, 
                          callback, NULL);
        
        /* Now fetch a server list. */
        if (servers) {
                fstrcpy(unix_workgroup, workgroup);
-               cli_NetServerEnum(&cli, unix_workgroup, 
+               cli_NetServerEnum(cli, unix_workgroup, 
                                  local?SV_TYPE_LOCAL_LIST_ONLY:SV_TYPE_ALL,
                                  callback, NULL);
        }
        
-       cli_shutdown(&cli);
+       cli_shutdown(cli);
 }
 
 /*******************************************************************
@@ -130,7 +141,7 @@ static void sync_child(char *name, int nm_type,
 
 void sync_browse_lists(struct work_record *work,
                       char *name, int nm_type, 
-                      struct in_addr ip, BOOL local, BOOL servers)
+                      struct in_addr ip, bool local, bool servers)
 {
        struct sync_record *s;
        static int counter;
@@ -138,7 +149,7 @@ void sync_browse_lists(struct work_record *work,
        START_PROFILE(sync_browse_lists);
        /* Check we're not trying to sync with ourselves. This can
           happen if we are a domain *and* a local master browser. */
-       if (ismyip(ip)) {
+       if (ismyip_v4(ip)) {
 done:
                END_PROFILE(sync_browse_lists);
                return;
@@ -148,15 +159,18 @@ done:
        if (!s) goto done;
 
        ZERO_STRUCTP(s);
-       
+
        unstrcpy(s->workgroup, work->work_group);
        unstrcpy(s->server, name);
        s->ip = ip;
 
-       slprintf(s->fname, sizeof(pstring)-1,
-                "%s/sync.%d", lp_lockdir(), counter++);
+       if (asprintf(&s->fname, "%s/sync.%d", lp_lockdir(), counter++) < 0) {
+               SAFE_FREE(s);
+               goto done;
+       }
+       /* Safe to use as 0 means no size change. */
        all_string_sub(s->fname,"//", "/", 0);
-       
+
        DLIST_ADD(syncs, s);
 
        /* the parent forks and returns, leaving the child to do the
@@ -172,7 +186,7 @@ done:
        fp = x_fopen(s->fname,O_WRONLY|O_CREAT|O_TRUNC, 0644);
        if (!fp) {
                END_PROFILE(sync_browse_lists);
-               _exit(1);       
+               _exit(1);
        }
 
        sync_child(name, nm_type, work->work_group, ip, local, servers,
@@ -187,7 +201,7 @@ done:
  Handle one line from a completed sync file.
  **********************************************************************/
 
-static void complete_one(struct sync_record *s, 
+static void complete_one(struct sync_record *s,
                         char *sname, uint32 stype, char *comment)
 {
        struct work_record *work;
@@ -236,7 +250,7 @@ static void complete_one(struct sync_record *s,
        /* Create the server in the workgroup. */ 
        create_server_on_workgroup(work, sname,stype, lp_max_ttl(), comment);
 }
-               
+
 /**********************************************************************
  Read the completed sync info.
 **********************************************************************/
@@ -244,10 +258,11 @@ static void complete_one(struct sync_record *s,
 static void complete_sync(struct sync_record *s)
 {
        XFILE *f;
-       unstring server, type_str;
+       char *server;
+       char *type_str;
        unsigned type;
-       pstring comment;
-       pstring line;
+       char *comment;
+       char line[1024];
        const char *ptr;
        int count=0;
 
@@ -255,17 +270,20 @@ static void complete_sync(struct sync_record *s)
 
        if (!f)
                return;
-       
+
        while (!x_feof(f)) {
-               
-               if (!fgets_slash(line,sizeof(pstring),f))
+               TALLOC_CTX *frame = NULL;
+
+               if (!fgets_slash(line,sizeof(line),f))
                        continue;
-               
+
                ptr = line;
 
-               if (!next_token(&ptr,server,NULL,sizeof(server)) ||
-                   !next_token(&ptr,type_str,NULL, sizeof(type_str)) ||
-                   !next_token(&ptr,comment,NULL, sizeof(comment))) {
+               frame = talloc_stackframe();
+               if (!next_token_talloc(frame,&ptr,&server,NULL) ||
+                   !next_token_talloc(frame,&ptr,&type_str,NULL) ||
+                   !next_token_talloc(frame,&ptr,&comment,NULL)) {
+                       TALLOC_FREE(frame);
                        continue;
                }
 
@@ -274,8 +292,8 @@ static void complete_sync(struct sync_record *s)
                complete_one(s, server, type, comment);
 
                count++;
+               TALLOC_FREE(frame);
        }
-
        x_fclose(f);
 
        unlink(s->fname);
@@ -298,7 +316,7 @@ void sync_check_completion(void)
                        /* it has completed - grab the info */
                        complete_sync(s);
                        DLIST_REMOVE(syncs, s);
-                       ZERO_STRUCTP(s);
+                       SAFE_FREE(s->fname);
                        SAFE_FREE(s);
                }
        }