s3:libsmb only log a dead connection if it was not closed
[samba.git] / source3 / libsmb / clientgen.c
index 8a5aedfde5697d0907d931c15e10cc3e2595e626..e26c1718d80e1a749e2e7c0cc0ee3a65426d5d2c 100644 (file)
@@ -19,6 +19,8 @@
 */
 
 #include "includes.h"
+#include "smb_signing.h"
+#include "async_smb.h"
 
 /*******************************************************************
  Setup the word count and byte count for a client smb message.
@@ -50,12 +52,21 @@ unsigned int cli_set_timeout(struct cli_state *cli, unsigned int timeout)
  Change the port number used to call on.
 ****************************************************************************/
 
-int cli_set_port(struct cli_state *cli, int port)
+void cli_set_port(struct cli_state *cli, int port)
 {
        cli->port = port;
-       return port;
 }
 
+/****************************************************************************
+ convenience routine to find if we negotiated ucs2
+****************************************************************************/
+
+bool cli_ucs2(struct cli_state *cli)
+{
+       return ((cli->capabilities & CAP_UNICODE) != 0);
+}
+
+
 /****************************************************************************
  Read an smb from a fd ignoring all keepalive packets.
  The timeout is in milliseconds
@@ -126,6 +137,79 @@ static ssize_t client_receive_smb(struct cli_state *cli, size_t maxlen)
        return len;
 }
 
+static bool cli_state_set_seqnum(struct cli_state *cli, uint16_t mid, uint32_t seqnum)
+{
+       struct cli_state_seqnum *c;
+
+       for (c = cli->seqnum; c; c = c->next) {
+               if (c->mid == mid) {
+                       c->seqnum = seqnum;
+                       return true;
+               }
+       }
+
+       c = talloc_zero(cli, struct cli_state_seqnum);
+       if (!c) {
+               return false;
+       }
+
+       c->mid = mid;
+       c->seqnum = seqnum;
+       c->persistent = false;
+       DLIST_ADD_END(cli->seqnum, c, struct cli_state_seqnum *);
+
+       return true;
+}
+
+bool cli_state_seqnum_persistent(struct cli_state *cli,
+                                uint16_t mid)
+{
+       struct cli_state_seqnum *c;
+
+       for (c = cli->seqnum; c; c = c->next) {
+               if (c->mid == mid) {
+                       c->persistent = true;
+                       return true;
+               }
+       }
+
+       return false;
+}
+
+bool cli_state_seqnum_remove(struct cli_state *cli,
+                            uint16_t mid)
+{
+       struct cli_state_seqnum *c;
+
+       for (c = cli->seqnum; c; c = c->next) {
+               if (c->mid == mid) {
+                       DLIST_REMOVE(cli->seqnum, c);
+                       TALLOC_FREE(c);
+                       return true;
+               }
+       }
+
+       return false;
+}
+
+static uint32_t cli_state_get_seqnum(struct cli_state *cli, uint16_t mid)
+{
+       struct cli_state_seqnum *c;
+
+       for (c = cli->seqnum; c; c = c->next) {
+               if (c->mid == mid) {
+                       uint32_t seqnum = c->seqnum;
+                       if (!c->persistent) {
+                               DLIST_REMOVE(cli->seqnum, c);
+                               TALLOC_FREE(c);
+                       }
+                       return seqnum;
+               }
+       }
+
+       return 0;
+}
+
 /****************************************************************************
  Recv an smb.
 ****************************************************************************/
@@ -133,6 +217,8 @@ static ssize_t client_receive_smb(struct cli_state *cli, size_t maxlen)
 bool cli_receive_smb(struct cli_state *cli)
 {
        ssize_t len;
+       uint16_t mid;
+       uint32_t seqnum;
 
        /* fd == -1 causes segfaults -- Tom (tom@ninja.nl) */
        if (cli->fd == -1)
@@ -150,7 +236,7 @@ bool cli_receive_smb(struct cli_state *cli)
                        if (cli->oplock_handler) {
                                int fnum = SVAL(cli->inbuf,smb_vwv2);
                                unsigned char level = CVAL(cli->inbuf,smb_vwv3+1);
-                               if (!cli->oplock_handler(cli, fnum, level)) {
+                               if (!NT_STATUS_IS_OK(cli->oplock_handler(cli, fnum, level))) {
                                        return false;
                                }
                        }
@@ -162,13 +248,25 @@ bool cli_receive_smb(struct cli_state *cli)
 
        /* If the server is not responding, note that now */
        if (len < 0) {
-                DEBUG(0, ("Receiving SMB: Server stopped responding\n"));
-               close(cli->fd);
-               cli->fd = -1;
+               /*
+                * only log if the connection should still be open and not when
+                * the connection was closed due to a dropped ip message
+                */
+               if (cli->fd != -1) {
+                       char addr[INET6_ADDRSTRLEN];
+                       print_sockaddr(addr, sizeof(addr), &cli->dest_ss);
+                       DEBUG(0, ("Receiving SMB: Server %s stopped responding\n",
+                               addr));
+                       close(cli->fd);
+                       cli->fd = -1;
+               }
                return false;
        }
 
-       if (!cli_check_sign_mac(cli, cli->inbuf)) {
+       mid = SVAL(cli->inbuf,smb_mid);
+       seqnum = cli_state_get_seqnum(cli, mid);
+
+       if (!cli_check_sign_mac(cli, cli->inbuf, seqnum+1)) {
                /*
                 * If we get a signature failure in sessionsetup, then
                 * the server sometimes just reflects the sent signature
@@ -198,37 +296,6 @@ bool cli_receive_smb(struct cli_state *cli)
        return true;
 }
 
-/****************************************************************************
- Read the data portion of a readX smb.
- The timeout is in milliseconds
-****************************************************************************/
-
-ssize_t cli_receive_smb_data(struct cli_state *cli, char *buffer, size_t len)
-{
-       NTSTATUS status;
-
-       set_smb_read_error(&cli->smb_rw_error, SMB_READ_OK);
-
-       status = read_socket_with_timeout(
-               cli->fd, buffer, len, len, cli->timeout, NULL);
-       if (NT_STATUS_IS_OK(status)) {
-               return len;
-       }
-
-       if (NT_STATUS_EQUAL(status, NT_STATUS_END_OF_FILE)) {
-               set_smb_read_error(&cli->smb_rw_error, SMB_READ_EOF);
-               return -1;
-       }
-
-       if (NT_STATUS_EQUAL(status, NT_STATUS_IO_TIMEOUT)) {
-               set_smb_read_error(&cli->smb_rw_error, SMB_READ_TIMEOUT);
-               return -1;
-       }
-
-       set_smb_read_error(&cli->smb_rw_error, SMB_READ_ERROR);
-       return -1;
-}
-
 static ssize_t write_socket(int fd, const char *buf, size_t len)
 {
         ssize_t ret=0;
@@ -255,12 +322,20 @@ bool cli_send_smb(struct cli_state *cli)
        ssize_t ret;
        char *buf_out = cli->outbuf;
        bool enc_on = cli_encryption_on(cli);
+       uint32_t seqnum;
 
        /* fd == -1 causes segfaults -- Tom (tom@ninja.nl) */
        if (cli->fd == -1)
                return false;
 
-       cli_calculate_sign_mac(cli, cli->outbuf);
+       cli_calculate_sign_mac(cli, cli->outbuf, &seqnum);
+
+       if (!cli_state_set_seqnum(cli, cli->mid, seqnum)) {
+               DEBUG(0,("Failed to store mid[%u]/seqnum[%u]\n",
+                       (unsigned int)cli->mid,
+                       (unsigned int)seqnum));
+               return false;
+       }
 
        if (enc_on) {
                NTSTATUS status = cli_encrypt_message(cli, cli->outbuf,
@@ -315,7 +390,7 @@ bool cli_send_smb_direct_writeX(struct cli_state *cli,
        /* First length to send is the offset to the data. */
        size_t len = SVAL(cli->outbuf,smb_vwv11) + 4;
        size_t nwritten=0;
-       ssize_t ret;
+       struct iovec iov[2];
 
        /* fd == -1 causes segfaults -- Tom (tom@ninja.nl) */
        if (cli->fd == -1) {
@@ -327,33 +402,19 @@ bool cli_send_smb_direct_writeX(struct cli_state *cli,
                return false;
        }
 
-       while (nwritten < len) {
-               ret = write_socket(cli->fd,cli->outbuf+nwritten,len - nwritten);
-               if (ret <= 0) {
-                       close(cli->fd);
-                       cli->fd = -1;
-                       cli->smb_rw_error = SMB_WRITE_ERROR;
-                       DEBUG(0,("Error writing %d bytes to client. %d (%s)\n",
-                               (int)len,(int)ret, strerror(errno) ));
-                       return false;
-               }
-               nwritten += ret;
-       }
+       iov[0].iov_base = (void *)cli->outbuf;
+       iov[0].iov_len = len;
+       iov[1].iov_base = CONST_DISCARD(void *, p);
+       iov[1].iov_len = extradata;
 
-       /* Now write the extra data. */
-       nwritten=0;
-       while (nwritten < extradata) {
-               ret = write_socket(cli->fd,p+nwritten,extradata - nwritten);
-               if (ret <= 0) {
-                       close(cli->fd);
-                       cli->fd = -1;
-                       cli->smb_rw_error = SMB_WRITE_ERROR;
-                       DEBUG(0,("Error writing %d extradata "
-                               "bytes to client. %d (%s)\n",
-                               (int)extradata,(int)ret, strerror(errno) ));
-                       return false;
-               }
-               nwritten += ret;
+       nwritten = write_data_iov(cli->fd, iov, 2);
+       if (nwritten < (len + extradata)) {
+               close(cli->fd);
+               cli->fd = -1;
+               cli->smb_rw_error = SMB_WRITE_ERROR;
+               DEBUG(0,("Error writing %d bytes to client. (%s)\n",
+                        (int)(len+extradata), strerror(errno)));
+               return false;
        }
 
        /* Increment the mid so we can tell between responses. */
@@ -414,49 +475,76 @@ void cli_setup_bcc(struct cli_state *cli, void *p)
 }
 
 /****************************************************************************
- Initialise credentials of a client structure.
+ Initialize Domain, user or password.
 ****************************************************************************/
 
-void cli_init_creds(struct cli_state *cli, const char *username, const char *domain, const char *password)
+NTSTATUS cli_set_domain(struct cli_state *cli, const char *domain)
 {
-       fstrcpy(cli->domain, domain);
-       fstrcpy(cli->user_name, username);
-       pwd_set_cleartext(&cli->pwd, password);
-       if (!*username) {
-               cli->pwd.null_pwd = true;
+       TALLOC_FREE(cli->domain);
+       cli->domain = talloc_strdup(cli, domain ? domain : "");
+       if (cli->domain == NULL) {
+               return NT_STATUS_NO_MEMORY;
        }
+       return NT_STATUS_OK;
+}
 
-        DEBUG(10,("cli_init_creds: user %s domain %s\n", cli->user_name, cli->domain));
+NTSTATUS cli_set_username(struct cli_state *cli, const char *username)
+{
+       TALLOC_FREE(cli->user_name);
+       cli->user_name = talloc_strdup(cli, username ? username : "");
+       if (cli->user_name == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+       return NT_STATUS_OK;
+}
+
+NTSTATUS cli_set_password(struct cli_state *cli, const char *password)
+{
+       TALLOC_FREE(cli->password);
+
+       /* Password can be NULL. */
+       if (password) {
+               cli->password = talloc_strdup(cli, password);
+               if (cli->password == NULL) {
+                       return NT_STATUS_NO_MEMORY;
+               }
+       } else {
+               /* Use zero NTLMSSP hashes and session key. */
+               cli->password = NULL;
+       }
+
+       return NT_STATUS_OK;
 }
 
 /****************************************************************************
Set the signing state (used from the command line).
Initialise credentials of a client structure.
 ****************************************************************************/
 
-void cli_setup_signing_state(struct cli_state *cli, int signing_state)
+NTSTATUS cli_init_creds(struct cli_state *cli, const char *username, const char *domain, const char *password)
 {
-       if (signing_state == Undefined)
-               return;
-
-       if (signing_state == false) {
-               cli->sign_info.allow_smb_signing = false;
-               cli->sign_info.mandatory_signing = false;
-               return;
+       NTSTATUS status = cli_set_username(cli, username);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
+       status = cli_set_domain(cli, domain);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+       DEBUG(10,("cli_init_creds: user %s domain %s\n", cli->user_name, cli->domain));
 
-       cli->sign_info.allow_smb_signing = true;
-
-       if (signing_state == Required) 
-               cli->sign_info.mandatory_signing = true;
+       return cli_set_password(cli, password);
 }
 
 /****************************************************************************
- Initialise a client structure. Always returns a malloc'ed struct.
+ Initialise a client structure. Always returns a talloc'ed struct.
+ Set the signing state (used from the command line).
 ****************************************************************************/
 
-struct cli_state *cli_initialise(void)
+struct cli_state *cli_initialise_ex(int signing_state)
 {
        struct cli_state *cli = NULL;
+       bool allow_smb_signing = false;
+       bool mandatory_signing = false;
 
        /* Check the effective uid - make sure we are not setuid */
        if (is_setuid_root()) {
@@ -469,6 +557,10 @@ struct cli_state *cli_initialise(void)
                return NULL;
        }
 
+       cli->dfs_mountpoint = talloc_strdup(cli, "");
+       if (!cli->dfs_mountpoint) {
+               goto error;
+       }
        cli->port = 0;
        cli->fd = -1;
        cli->cnum = -1;
@@ -480,6 +572,7 @@ struct cli_state *cli_initialise(void)
        cli->bufsize = CLI_BUFFER_SIZE+4;
        cli->max_xmit = cli->bufsize;
        cli->outbuf = (char *)SMB_MALLOC(cli->bufsize+SAFETY_MARGIN);
+       cli->seqnum = 0;
        cli->inbuf = (char *)SMB_MALLOC(cli->bufsize+SAFETY_MARGIN);
        cli->oplock_handler = cli_oplock_ack;
        cli->case_sensitive = false;
@@ -495,12 +588,27 @@ struct cli_state *cli_initialise(void)
        if (getenv("CLI_FORCE_DOSERR"))
                cli->force_dos_errors = true;
 
-       if (lp_client_signing()) 
-               cli->sign_info.allow_smb_signing = true;
+       if (lp_client_signing()) {
+               allow_smb_signing = true;
+       }
+
+       if (lp_client_signing() == Required) {
+               mandatory_signing = true;
+       }
+
+       if (signing_state != Undefined) {
+               allow_smb_signing = true;
+       }
+
+       if (signing_state == false) {
+               allow_smb_signing = false;
+               mandatory_signing = false;
+       }
+
+       if (signing_state == Required) {
+               mandatory_signing = true;
+       }
 
-       if (lp_client_signing() == Required) 
-               cli->sign_info.mandatory_signing = true;
-                                   
        if (!cli->outbuf || !cli->inbuf)
                 goto error;
 
@@ -515,7 +623,18 @@ struct cli_state *cli_initialise(void)
 #endif
 
        /* initialise signing */
-       cli_null_set_signing(cli);
+       cli->signing_state = smb_signing_init(cli,
+                                             allow_smb_signing,
+                                             mandatory_signing);
+       if (!cli->signing_state) {
+               goto error;
+       }
+
+       cli->outgoing = tevent_queue_create(cli, "cli_outgoing");
+       if (cli->outgoing == NULL) {
+               goto error;
+       }
+       cli->pending = NULL;
 
        cli->initialised = 1;
 
@@ -527,10 +646,15 @@ struct cli_state *cli_initialise(void)
 
         SAFE_FREE(cli->inbuf);
         SAFE_FREE(cli->outbuf);
-       SAFE_FREE(cli);
+       TALLOC_FREE(cli);
         return NULL;
 }
 
+struct cli_state *cli_initialise(void)
+{
+       return cli_initialise_ex(Undefined);
+}
+
 /****************************************************************************
  Close all pipes open on this session.
 ****************************************************************************/
@@ -549,7 +673,7 @@ void cli_nt_pipes_close(struct cli_state *cli)
  Shutdown a client structure.
 ****************************************************************************/
 
-void cli_shutdown(struct cli_state *cli)
+static void _cli_shutdown(struct cli_state *cli)
 {
        cli_nt_pipes_close(cli);
 
@@ -572,7 +696,6 @@ void cli_shutdown(struct cli_state *cli)
        SAFE_FREE(cli->outbuf);
        SAFE_FREE(cli->inbuf);
 
-       cli_free_signing_context(cli);
        data_blob_free(&cli->secblob);
        data_blob_free(&cli->user_session_key);
 
@@ -582,9 +705,41 @@ void cli_shutdown(struct cli_state *cli)
        cli->fd = -1;
        cli->smb_rw_error = SMB_READ_OK;
 
+       /*
+        * Need to free pending first, they remove themselves
+        */
+       while (cli->pending) {
+               talloc_free(cli->pending[0]);
+       }
        TALLOC_FREE(cli);
 }
 
+void cli_shutdown(struct cli_state *cli)
+{
+       struct cli_state *cli_head;
+       if (cli == NULL) {
+               return;
+       }
+       DLIST_HEAD(cli, cli_head);
+       if (cli_head == cli) {
+               /*
+                * head of a DFS list, shutdown all subsidiary DFS
+                * connections.
+                */
+               struct cli_state *p, *next;
+
+               for (p = cli_head->next; p; p = next) {
+                       next = p->next;
+                       DLIST_REMOVE(cli_head, p);
+                       _cli_shutdown(p);
+               }
+       } else {
+               DLIST_REMOVE(cli_head, cli);
+       }
+
+       _cli_shutdown(cli);
+}
+
 /****************************************************************************
  Set socket options on a open connection.
 ****************************************************************************/
@@ -616,112 +771,74 @@ bool cli_set_case_sensitive(struct cli_state *cli, bool case_sensitive)
        return ret;
 }
 
-/****************************************************************************
-Send a keepalive packet to the server
-****************************************************************************/
+struct cli_echo_state {
+       uint16_t vwv[1];
+       DATA_BLOB data;
+       int num_echos;
+};
+
+static void cli_echo_done(struct tevent_req *subreq);
 
-bool cli_send_keepalive(struct cli_state *cli)
+struct tevent_req *cli_echo_send(TALLOC_CTX *mem_ctx, struct event_context *ev,
+                                struct cli_state *cli, uint16_t num_echos,
+                                DATA_BLOB data)
 {
-        if (cli->fd == -1) {
-                DEBUG(3, ("cli_send_keepalive: fd == -1\n"));
-                return false;
-        }
-        if (!send_keepalive(cli->fd)) {
-                close(cli->fd);
-                cli->fd = -1;
-                DEBUG(0,("Error sending keepalive packet to client.\n"));
-                return false;
-        }
-        return true;
-}
+       struct tevent_req *req, *subreq;
+       struct cli_echo_state *state;
 
-/**
- * @brief: Collect a echo reply
- * @param[in] req      The corresponding async request
- *
- * There might be more than one echo reply. This helper pulls the reply out of
- * the data stream. If all expected replies have arrived, declare the
- * async_req done.
- */
+       req = tevent_req_create(mem_ctx, &state, struct cli_echo_state);
+       if (req == NULL) {
+               return NULL;
+       }
+       SSVAL(state->vwv, 0, num_echos);
+       state->data = data;
+       state->num_echos = num_echos;
+
+       subreq = cli_smb_send(state, ev, cli, SMBecho, 0, 1, state->vwv,
+                             data.length, data.data);
+       if (subreq == NULL) {
+               goto fail;
+       }
+       tevent_req_set_callback(subreq, cli_echo_done, req);
+       return req;
+ fail:
+       TALLOC_FREE(req);
+       return NULL;
+}
 
-static void cli_echo_recv_helper(struct async_req *req)
+static void cli_echo_done(struct tevent_req *subreq)
 {
-       struct cli_request *cli_req;
-       uint8_t wct;
-       uint16_t *vwv;
-       uint16_t num_bytes;
-       uint8_t *bytes;
+       struct tevent_req *req = tevent_req_callback_data(
+               subreq, struct tevent_req);
+       struct cli_echo_state *state = tevent_req_data(
+               req, struct cli_echo_state);
        NTSTATUS status;
+       uint32_t num_bytes;
+       uint8_t *bytes;
+       uint8_t *inbuf;
 
-       status = cli_pull_reply(req, &wct, &vwv, &num_bytes, &bytes);
+       status = cli_smb_recv(subreq, state, &inbuf, 0, NULL, NULL,
+                             &num_bytes, &bytes);
        if (!NT_STATUS_IS_OK(status)) {
-               async_req_error(req, status);
+               tevent_req_nterror(req, status);
                return;
        }
-
-       cli_req = talloc_get_type_abort(req->private_data, struct cli_request);
-
-       if ((num_bytes != cli_req->data.echo.data.length)
-           || (memcmp(cli_req->data.echo.data.data, bytes,
-                      num_bytes) != 0)) {
-               async_req_error(req, NT_STATUS_INVALID_NETWORK_RESPONSE);
+       if ((num_bytes != state->data.length)
+           || (memcmp(bytes, state->data.data, num_bytes) != 0)) {
+               tevent_req_nterror(req, NT_STATUS_INVALID_NETWORK_RESPONSE);
                return;
        }
 
-       cli_req->data.echo.num_echos -= 1;
-
-       if (cli_req->data.echo.num_echos == 0) {
-               client_set_trans_sign_state_off(cli_req->cli, cli_req->mid);
-               async_req_done(req);
+       state->num_echos -=1;
+       if (state->num_echos == 0) {
+               tevent_req_done(req);
                return;
        }
 
-       return;
-}
-
-/**
- * @brief Send SMBEcho requests
- * @param[in] mem_ctx  The memory context to put the async_req on
- * @param[in] ev       The event context that will call us back
- * @param[in] cli      The connection to send the echo to
- * @param[in] num_echos        How many times do we want to get the reply?
- * @param[in] data     The data we want to get back
- * @retval The async request
- */
-
-struct async_req *cli_echo_send(TALLOC_CTX *mem_ctx, struct event_context *ev,
-                               struct cli_state *cli, uint16_t num_echos,
-                               DATA_BLOB data)
-{
-       uint16_t vwv[1];
-       uint8_t *data_copy;
-       struct async_req *result;
-       struct cli_request *req;
-
-       SSVAL(vwv, 0, num_echos);
-
-       data_copy = (uint8_t *)talloc_memdup(mem_ctx, data.data, data.length);
-       if (data_copy == NULL) {
-               return NULL;
-       }
-
-       result = cli_request_send(mem_ctx, ev, cli, SMBecho, 0, 1, vwv,
-                                 data.length, data.data);
-       if (result == NULL) {
-               TALLOC_FREE(data_copy);
-               return NULL;
+       if (!cli_smb_req_set_pending(subreq)) {
+               tevent_req_nterror(req, NT_STATUS_NO_MEMORY);
+               return;
        }
-       req = talloc_get_type_abort(result->private_data, struct cli_request);
-
-       client_set_trans_sign_state_on(cli, req->mid);
-
-       req->data.echo.num_echos = num_echos;
-       req->data.echo.data.data = talloc_move(req, &data_copy);
-       req->data.echo.data.length = data.length;
-
-       req->recv_helper.fn = cli_echo_recv_helper;
-
-       return result;
 }
 
 /**
@@ -730,14 +847,9 @@ struct async_req *cli_echo_send(TALLOC_CTX *mem_ctx, struct event_context *ev,
  * @retval Did the server reply correctly?
  */
 
-NTSTATUS cli_echo_recv(struct async_req *req)
+NTSTATUS cli_echo_recv(struct tevent_req *req)
 {
-       SMB_ASSERT(req->state >= ASYNC_REQ_DONE);
-       if (req->state == ASYNC_REQ_ERROR) {
-               return req->status;
-       }
-
-       return NT_STATUS_OK;
+       return tevent_req_simple_recv_ntstatus(req);
 }
 
 /**
@@ -754,34 +866,101 @@ NTSTATUS cli_echo(struct cli_state *cli, uint16_t num_echos, DATA_BLOB data)
 {
        TALLOC_CTX *frame = talloc_stackframe();
        struct event_context *ev;
-       struct async_req *req;
-       NTSTATUS status = NT_STATUS_NO_MEMORY;
+       struct tevent_req *req;
+       NTSTATUS status = NT_STATUS_OK;
 
-       if (cli->fd_event != NULL) {
+       if (cli_has_async_calls(cli)) {
                /*
                 * Can't use sync call while an async call is in flight
                 */
-               cli_set_error(cli, NT_STATUS_INVALID_PARAMETER);
+               status = NT_STATUS_INVALID_PARAMETER;
                goto fail;
        }
 
        ev = event_context_init(frame);
        if (ev == NULL) {
+               status = NT_STATUS_NO_MEMORY;
                goto fail;
        }
 
        req = cli_echo_send(frame, ev, cli, num_echos, data);
        if (req == NULL) {
+               status = NT_STATUS_NO_MEMORY;
                goto fail;
        }
 
-       while (req->state < ASYNC_REQ_DONE) {
-               event_loop_once(ev);
+       if (!tevent_req_poll(req, ev)) {
+               status = map_nt_error_from_unix(errno);
+               goto fail;
        }
 
        status = cli_echo_recv(req);
-
  fail:
        TALLOC_FREE(frame);
+       if (!NT_STATUS_IS_OK(status)) {
+               cli_set_error(cli, status);
+       }
        return status;
 }
+
+/**
+ * Is the SMB command able to hold an AND_X successor
+ * @param[in] cmd      The SMB command in question
+ * @retval Can we add a chained request after "cmd"?
+ */
+bool is_andx_req(uint8_t cmd)
+{
+       switch (cmd) {
+       case SMBtconX:
+       case SMBlockingX:
+       case SMBopenX:
+       case SMBreadX:
+       case SMBwriteX:
+       case SMBsesssetupX:
+       case SMBulogoffX:
+       case SMBntcreateX:
+               return true;
+               break;
+       default:
+               break;
+       }
+
+       return false;
+}
+
+NTSTATUS cli_smb(TALLOC_CTX *mem_ctx, struct cli_state *cli,
+                uint8_t smb_command, uint8_t additional_flags,
+                uint8_t wct, uint16_t *vwv,
+                uint32_t num_bytes, const uint8_t *bytes,
+                struct tevent_req **result_parent,
+                uint8_t min_wct, uint8_t *pwct, uint16_t **pvwv,
+                uint32_t *pnum_bytes, uint8_t **pbytes)
+{
+        struct tevent_context *ev;
+        struct tevent_req *req = NULL;
+        NTSTATUS status = NT_STATUS_NO_MEMORY;
+
+        if (cli_has_async_calls(cli)) {
+                return NT_STATUS_INVALID_PARAMETER;
+        }
+        ev = tevent_context_init(mem_ctx);
+        if (ev == NULL) {
+                goto fail;
+        }
+        req = cli_smb_send(mem_ctx, ev, cli, smb_command, additional_flags,
+                          wct, vwv, num_bytes, bytes);
+        if (req == NULL) {
+                goto fail;
+        }
+        if (!tevent_req_poll_ntstatus(req, ev, &status)) {
+                goto fail;
+        }
+        status = cli_smb_recv(req, NULL, NULL, min_wct, pwct, pvwv,
+                             pnum_bytes, pbytes);
+fail:
+        TALLOC_FREE(ev);
+       if (NT_STATUS_IS_OK(status) && (result_parent != NULL)) {
+               *result_parent = req;
+       }
+        return status;
+}