Check error returns from strupper_m() (in all reasonable places).

[mat/samba.git] / source3 / lib / util_names.c

diff --git a/source3/lib/util_names.c b/source3/lib/util_names.c
index 0e128eab1cdc855f71816884f2d2faaf0ba3c82c..cf54a0eeceeb7412bde959f075e4b1056f3d97b1 100644 (file)
--- a/source3/lib/util_names.c
+++ b/source3/lib/util_names.c
@@ -63,8 +63,7 @@ static bool set_my_netbios_names(const char *name, int i)
        smb_my_netbios_names[i] = SMB_STRDUP(name);
        if (!smb_my_netbios_names[i])
                return False;
-       strupper_m(smb_my_netbios_names[i]);
-       return True;
+       return strupper_m(smb_my_netbios_names[i]);
 }
 
 /***********************************************************************