parse correctly getprinterdriver2
[sfrench/samba-autobuild/.git] / source / rpc_parse / parse_spoolss.c
index 796466337f8a4cdd6cacdca191597d6e100d54a2..85d295eb3f3b9841b1434a723bdbcac1eb0c2c55 100644 (file)
 #include "includes.h"
 #include "nterr.h"
 
+#ifdef TNG
+       #define prs_uint16 _prs_uint16
+       #define prs_uint32 _prs_uint32
+       #define prs_uint8s _prs_uint8s
+       #define prs_uint16s _prs_uint16s
+       #define prs_unistr _prs_unistr
+       #define init_unistr2 make_unistr2
+#endif
+
+
 extern int DEBUGLEVEL;
 /*******************************************************************
 return the length of a UNISTR string.
@@ -73,23 +83,6 @@ BOOL make_systemtime(SYSTEMTIME *systime, struct tm *unixtime)
        return True;
 }
 
-/*******************************************************************
-reads or writes an POLICY_HND structure.
-********************************************************************/  
-static BOOL smb_io_prt_hnd(char *desc, POLICY_HND *hnd, prs_struct *ps, int depth)
-{
-       if (hnd == NULL) return False;
-
-       prs_debug(ps, depth, desc, "smb_io_prt_hnd");
-       depth++;
-       prs_align(ps);
-        
-       prs_uint8s (False, "data", ps, depth, hnd->data, POLICY_HND_SIZE);
-
-       return True;
-}
-
 /*******************************************************************
 reads or writes an DOC_INFO structure.
 ********************************************************************/  
@@ -179,24 +172,26 @@ static BOOL smb_io_doc_info_container(char *desc, DOC_INFO_CONTAINER *cont, prs_
 /*******************************************************************
 reads or writes an NOTIFY OPTION TYPE structure.
 ********************************************************************/  
-static BOOL smb_io_notify_option_type(char *desc,
-                               SPOOL_NOTIFY_OPTION_TYPE *type,
-                               prs_struct *ps, int depth)
+static BOOL smb_io_notify_option_type(char *desc, SPOOL_NOTIFY_OPTION_TYPE *type, prs_struct *ps, int depth)
 {
-       uint32 useless_ptr;
-
        prs_debug(ps, depth, desc, "smb_io_notify_option_type");
        depth++;
  
-       prs_align(ps);
-
-       prs_uint16("type", ps, depth, &(type->type));
-       prs_uint16("reserved0", ps, depth, &(type->reserved0));
-       prs_uint32("reserved1", ps, depth, &(type->reserved1));
-       prs_uint32("reserved2", ps, depth, &(type->reserved2));
-       prs_uint32("count", ps, depth, &(type->count));
-       prs_uint32("useless ptr", ps, depth, &useless_ptr);
+       if (!prs_align(ps))
+               return False;
 
+       if(!prs_uint16("type", ps, depth, &type->type))
+               return False;
+       if(!prs_uint16("reserved0", ps, depth, &type->reserved0))
+               return False;
+       if(!prs_uint32("reserved1", ps, depth, &type->reserved1))
+               return False;
+       if(!prs_uint32("reserved2", ps, depth, &type->reserved2))
+               return False;
+       if(!prs_uint32("count", ps, depth, &type->count))
+               return False;
+       if(!prs_uint32("fields_ptr", ps, depth, &type->fields_ptr))
+               return False;
 
        return True;
 }
@@ -204,79 +199,97 @@ static BOOL smb_io_notify_option_type(char *desc,
 /*******************************************************************
 reads or writes an NOTIFY OPTION TYPE DATA.
 ********************************************************************/  
-static BOOL smb_io_notify_option_type_data(char *desc,
-                                    SPOOL_NOTIFY_OPTION_TYPE *type,
-                                    prs_struct *ps, int depth)
+static BOOL smb_io_notify_option_type_data(char *desc, SPOOL_NOTIFY_OPTION_TYPE *type, prs_struct *ps, int depth)
 {
-       uint32 count;
        int i;
 
        prs_debug(ps, depth, desc, "smb_io_notify_option_type_data");
        depth++;
  
-       prs_align(ps);
+       /* if there are no fields just return */
+       if (type->fields_ptr==0)
+               return True;
 
-       prs_uint32("count", ps, depth, &count);
+       if(!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("count2", ps, depth, &type->count2))
+               return False;
        
-       if (count != type->count)
-       {
-               DEBUG(4,("What a mess, count was %x now is %x !\n",type->count,count));
-               type->count=count;
-       }
-       for(i=0;i<count;i++)
-       {
-               /* read the option type struct */
-               prs_uint16("fields",ps,depth,&(type->fields[i]));
-       }
+       if (type->count2 != type->count)
+               DEBUG(4,("What a mess, count was %x now is %x !\n", type->count, type->count2));
 
+       /* parse the option type data */
+       for(i=0;i<type->count2;i++)
+               if(!prs_uint16("fields",ps,depth,&(type->fields[i])))
+                       return False;
        return True;
 }
 
 /*******************************************************************
 reads or writes an NOTIFY OPTION structure.
 ********************************************************************/  
-static BOOL smb_io_notify_option(char *desc, SPOOL_NOTIFY_OPTION *option,
-                          prs_struct *ps, int depth)
-{
-       uint32 useless_ptr;
+static BOOL smb_io_notify_option_type_ctr(char *desc, SPOOL_NOTIFY_OPTION_TYPE_CTR *ctr , prs_struct *ps, int depth)
+{              
        int i;
-
-       prs_debug(ps, depth, desc, "smb_io_notify_option");
+       
+       prs_debug(ps, depth, desc, "smb_io_notify_option_type_ctr");
        depth++;
  
-       prs_align(ps);
+       if(!prs_uint32("count", ps, depth, &ctr->count))
+               return False;
+
+       /* reading */
+       if (UNMARSHALLING(ps))
+               ctr->type=(SPOOL_NOTIFY_OPTION_TYPE *)malloc(ctr->count*sizeof(SPOOL_NOTIFY_OPTION_TYPE));
+               
+       /* the option type struct */
+       for(i=0;i<ctr->count;i++)
+               if(!smb_io_notify_option_type("", &(ctr->type[i]) , ps, depth))
+                       return False;
 
-       /* memory pointer to the struct */
-       prs_uint32("useless ptr", ps, depth, &useless_ptr);
+       /* the type associated with the option type struct */
+       for(i=0;i<ctr->count;i++)
+               if(!smb_io_notify_option_type_data("", &(ctr->type[i]) , ps, depth))
+                       return False;
        
-       prs_uint32("version",     ps, depth, &(option->version));
-       prs_uint32("reserved",    ps, depth, &(option->reserved));
-       prs_uint32("count",       ps, depth, &(option->count));
-       prs_uint32("useless ptr", ps, depth, &useless_ptr);
-       prs_uint32("count",       ps, depth, &(option->count));
-
-       /* read the option type struct */
-       for(i=0;i<option->count;i++)
-       {
-               smb_io_notify_option_type("",&(option->type[i]) ,ps, depth);
-       }
+       return True;
+}
 
-       /* now read the type associated with the option type struct */
-       for(i=0;i<option->count;i++)
-       {
-               smb_io_notify_option_type_data("",&(option->type[i]) ,ps, depth);
+/*******************************************************************
+reads or writes an NOTIFY OPTION structure.
+********************************************************************/  
+static BOOL smb_io_notify_option(char *desc, SPOOL_NOTIFY_OPTION *option, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "smb_io_notify_option");
+       depth++;
+       
+       if(!prs_uint32("version", ps, depth, &option->version))
+               return False;
+       if(!prs_uint32("flags", ps, depth, &option->flags))
+               return False;
+       if(!prs_uint32("count", ps, depth, &option->count))
+               return False;
+       if(!prs_uint32("option_type_ptr", ps, depth, &option->option_type_ptr))
+               return False;
+       
+       /* marshalling or unmarshalling, that would work */     
+       if (option->option_type_ptr!=0) {
+               if(!smb_io_notify_option_type_ctr("", &option->ctr ,ps, depth))
+                       return False;
+       }
+       else {
+               option->ctr.type=NULL;
+               option->ctr.count=0;
        }
        
-
        return True;
 }
 
-
 /*******************************************************************
 reads or writes an NOTIFY INFO DATA structure.
 ********************************************************************/  
-static BOOL smb_io_notify_info_data(char *desc,SPOOL_NOTIFY_INFO_DATA *data,
-                             prs_struct *ps, int depth)
+static BOOL smb_io_notify_info_data(char *desc,SPOOL_NOTIFY_INFO_DATA *data, prs_struct *ps, int depth)
 {
        uint32 useless_ptr=0xADDE0FF0;
 
@@ -354,19 +367,16 @@ BOOL smb_io_notify_info_data_strings(char *desc,SPOOL_NOTIFY_INFO_DATA *data,
 /*******************************************************************
 reads or writes an NOTIFY INFO structure.
 ********************************************************************/  
-static BOOL smb_io_notify_info(char *desc, SPOOL_NOTIFY_INFO *info,
-                        prs_struct *ps, int depth)
+static BOOL smb_io_notify_info(char *desc, SPOOL_NOTIFY_INFO *info, prs_struct *ps, int depth)
 {
-       uint32 useless_ptr=0x0001;
        int i;
 
-       info->version=0x02;
        prs_debug(ps, depth, desc, "smb_io_notify_info");
        depth++;
  
-       prs_align(ps);
+       if(!prs_align(ps))
+               return False;
 
-       prs_uint32("pointer", ps, depth, &useless_ptr);
        prs_uint32("count", ps, depth, &(info->count));
        prs_uint32("version", ps, depth, &(info->version));
        prs_uint32("flags", ps, depth, &(info->flags));
@@ -380,8 +390,7 @@ static BOOL smb_io_notify_info(char *desc, SPOOL_NOTIFY_INFO *info,
        /* now do the strings at the end of the stream */       
        for (i=0;i<info->count;i++)
        {
-               smb_io_notify_info_data_strings(desc, &(info->data[i]),
-                                               ps, depth);
+               smb_io_notify_info_data_strings(desc, &(info->data[i]), ps, depth);
        }
 
        return True;
@@ -559,6 +568,9 @@ static BOOL spoolss_io_devmode_cont(char *desc, DEVMODE_CTR *dm_c, prs_struct *p
        prs_debug(ps, depth, desc, "spoolss_io_devmode_cont");
        depth++;
 
+       if(!prs_align(ps))
+               return False;
+       
        if (!prs_uint32("size", ps, depth, &dm_c->size))
                return False;
 
@@ -618,45 +630,37 @@ static BOOL spoolss_io_printer_default(char *desc, PRINTER_DEFAULT *pd, prs_stru
 }
 
 /*******************************************************************
- * make a structure.
+ * init a structure.
  ********************************************************************/
-BOOL make_spoolss_q_open_printer_ex(SPOOL_Q_OPEN_PRINTER_EX *q_u, 
-               const char *printername,
-               uint32 cbbuf, uint32 devmod, uint32 des_access,
-               const char *station,
-               const char *username)
+BOOL make_spoolss_q_open_printer_ex(SPOOL_Q_OPEN_PRINTER_EX *q_u, fstring printername, fstring datatype, 
+                                       uint32 access_required, fstring clientname, fstring user_name)
 {
-       int len_name = printername != NULL ? strlen(printername) : 0;
-       int len_sta  = station     != NULL ? strlen(station    ) : 0;
-       int len_user = username    != NULL ? strlen(username   ) : 0;
-
-       if (q_u == NULL) return False;
-
-       DEBUG(5,("make_spoolss_io_q_open_printer_ex\n"));
-
-       q_u->printername_ptr = 1;
-       init_unistr2(&(q_u->printername), printername, len_name);
+       DEBUG(5,("make_spoolss_q_open_printer_ex\n"));
+       q_u->printername_ptr = (printername!=NULL)?1:0;
+       init_unistr2(&(q_u->printername), printername, strlen(printername));
 
+       q_u->printer_default.datatype_ptr = 0;
 /*
-       q_u->unknown0 = 0x0;
-       q_u->cbbuf = cbbuf;
-       q_u->devmod = devmod;
-       q_u->access_required = des_access;
-*/
-/*     q_u->unknown1 = 0x1;
-       q_u->unknown2 = 0x1;
-       q_u->unknown3 = 0x149f7d8;
-       q_u->unknown4 = 0x1c;
-       q_u->unknown5 = 0x00b94dd0;
-       q_u->unknown6 = 0x0149f5cc;
-       q_u->unknown7 = 0x00000565;
-       q_u->unknown8  = 0x2;
-       q_u->unknown9 = 0x0;
-       q_u->unknown10 = 0x0;
-
-       init_unistr2(&(q_u->station), station, len_sta);
-       init_unistr2(&(q_u->username), username, len_user);
+       q_u->printer_default.datatype_ptr = (datatype!=NULL)?1:0;
+       init_unistr2(&(q_u->printer_default.datatype), datatype, strlen(datatype));
 */
+       q_u->printer_default.devmode_cont.size=0;
+       q_u->printer_default.devmode_cont.devmode_ptr=0;
+       q_u->printer_default.devmode_cont.devmode=NULL;
+       q_u->printer_default.access_required=access_required;
+       q_u->user_switch=1;
+       q_u->user_ctr.level=1;
+       q_u->user_ctr.ptr=1;
+       q_u->user_ctr.user1.size=strlen(clientname)+strlen(user_name)+8;
+       q_u->user_ctr.user1.client_name_ptr = (clientname!=NULL)?1:0;
+       q_u->user_ctr.user1.user_name_ptr = (user_name!=NULL)?1:0;
+       q_u->user_ctr.user1.build=1381;
+       q_u->user_ctr.user1.major=2;
+       q_u->user_ctr.user1.minor=0;
+       q_u->user_ctr.user1.processor=0;
+       init_unistr2(&(q_u->user_ctr.user1.client_name), clientname, strlen(clientname));
+       init_unistr2(&(q_u->user_ctr.user1.user_name), user_name, strlen(user_name));
+       
        return True;
 }
 
@@ -709,7 +713,7 @@ BOOL spoolss_io_r_open_printer_ex(char *desc, SPOOL_R_OPEN_PRINTER_EX *r_u, prs_
        if (!prs_align(ps))
                return False;
 
-       if (!smb_io_prt_hnd("printer handle",&(r_u->handle),ps,depth))
+       if (!smb_io_pol_hnd("printer handle",&(r_u->handle),ps,depth))
                return False;
 
        if (!prs_uint32("status code", ps, depth, &(r_u->status)))
@@ -751,7 +755,7 @@ BOOL spoolss_io_q_getprinterdata(char *desc, SPOOL_Q_GETPRINTERDATA *q_u, prs_st
 
        if (!prs_align(ps))
                return False;
-       if (!smb_io_prt_hnd("printer handle",&(q_u->handle),ps,depth))
+       if (!smb_io_pol_hnd("printer handle",&(q_u->handle),ps,depth))
                return False;
        if (!prs_align(ps))
                return False;
@@ -827,7 +831,7 @@ BOOL spoolss_io_q_closeprinter(char *desc, SPOOL_Q_CLOSEPRINTER *q_u, prs_struct
        if (!prs_align(ps))
                return False;
 
-       if (!smb_io_prt_hnd("printer handle",&q_u->handle,ps,depth))
+       if (!smb_io_pol_hnd("printer handle",&q_u->handle,ps,depth))
                return False;
 
        return True;
@@ -846,7 +850,7 @@ BOOL spoolss_io_r_closeprinter(char *desc, SPOOL_R_CLOSEPRINTER *r_u, prs_struct
        if (!prs_align(ps))
                return False;
 
-       if (!smb_io_prt_hnd("printer handle",&r_u->handle,ps,depth))
+       if (!smb_io_pol_hnd("printer handle",&r_u->handle,ps,depth))
                return False;
        if (!prs_uint32("status", ps, depth, &r_u->status))
                return False;
@@ -867,7 +871,7 @@ BOOL spoolss_io_q_startdocprinter(char *desc, SPOOL_Q_STARTDOCPRINTER *q_u, prs_
 
        prs_align(ps);
 
-       smb_io_prt_hnd("printer handle",&(q_u->handle),ps,depth);
+       smb_io_pol_hnd("printer handle",&(q_u->handle),ps,depth);
        
        smb_io_doc_info_container("",&(q_u->doc_info_container), ps, depth);    
 
@@ -901,7 +905,7 @@ BOOL spoolss_io_q_enddocprinter(char *desc, SPOOL_Q_ENDDOCPRINTER *q_u, prs_stru
 
        prs_align(ps);
 
-       smb_io_prt_hnd("printer handle",&(q_u->handle),ps,depth);
+       smb_io_pol_hnd("printer handle",&(q_u->handle),ps,depth);
 
        return True;
 }
@@ -932,7 +936,7 @@ BOOL spoolss_io_q_startpageprinter(char *desc, SPOOL_Q_STARTPAGEPRINTER *q_u, pr
 
        prs_align(ps);
 
-       smb_io_prt_hnd("printer handle",&(q_u->handle),ps,depth);
+       smb_io_pol_hnd("printer handle",&(q_u->handle),ps,depth);
 
        return True;
 }
@@ -963,7 +967,7 @@ BOOL spoolss_io_q_endpageprinter(char *desc, SPOOL_Q_ENDPAGEPRINTER *q_u, prs_st
 
        prs_align(ps);
 
-       smb_io_prt_hnd("printer handle",&(q_u->handle),ps,depth);
+       smb_io_pol_hnd("printer handle",&(q_u->handle),ps,depth);
 
        return True;
 }
@@ -994,7 +998,7 @@ BOOL spoolss_io_q_writeprinter(char *desc, SPOOL_Q_WRITEPRINTER *q_u, prs_struct
 
        prs_align(ps);
 
-       smb_io_prt_hnd("printer handle",&(q_u->handle),ps,depth);
+       smb_io_pol_hnd("printer handle",&(q_u->handle),ps,depth);
        prs_uint32("buffer_size", ps, depth, &(q_u->buffer_size));
        
        if (q_u->buffer_size!=0)
@@ -1026,29 +1030,43 @@ BOOL spoolss_io_r_writeprinter(char *desc, SPOOL_R_WRITEPRINTER *r_u, prs_struct
  * read a structure.
  * called from spoolss_q_rffpcnex (srv_spoolss.c)
  ********************************************************************/
-BOOL spoolss_io_q_rffpcnex(char *desc, SPOOL_Q_RFFPCNEX *q_u,
-                           prs_struct *ps, int depth)
+BOOL spoolss_io_q_rffpcnex(char *desc, SPOOL_Q_RFFPCNEX *q_u, prs_struct *ps, int depth)
 {
-       uint32 useless_ptr;
-
        prs_debug(ps, depth, desc, "spoolss_io_q_rffpcnex");
        depth++;
-       prs_align(ps);
 
-       smb_io_prt_hnd("printer handle",&(q_u->handle),ps,depth);
-       prs_uint32("flags",       ps, depth, &(q_u->flags));
-       prs_uint32("options",     ps, depth, &(q_u->options));
-       prs_uint32("useless ptr", ps, depth, &useless_ptr);
-       /*prs_align(ps);*/
-
-       smb_io_unistr2("", &(q_u->localmachine), True, ps, depth);      
-
-       prs_align(ps);
-       prs_uint32("printerlocal", ps, depth, &(q_u->printerlocal));
+       if(!prs_align(ps))
+               return False;
 
-       smb_io_notify_option("notify option", &(q_u->option), ps, depth);
+       if(!smb_io_pol_hnd("printer handle", &q_u->handle, ps, depth))
+               return False;
+       if(!prs_uint32("flags", ps, depth, &q_u->flags))
+               return False;
+       if(!prs_uint32("options", ps, depth, &q_u->options))
+               return False;
+       if(!prs_uint32("localmachine_ptr", ps, depth, &q_u->localmachine_ptr))
+               return False;
+       if(!smb_io_unistr2("localmachine", &q_u->localmachine, q_u->localmachine_ptr, ps, depth))
+               return False;
 
+       if(!prs_align(ps))
+               return False;
+               
+       if(!prs_uint32("printerlocal", ps, depth, &q_u->printerlocal))
+               return False;
 
+       if(!prs_uint32("option_ptr", ps, depth, &q_u->option_ptr))
+               return False;
+       
+       if (q_u->option_ptr!=0) {
+       
+               if (UNMARSHALLING(ps))
+                       q_u->option=(SPOOL_NOTIFY_OPTION *)malloc(sizeof(SPOOL_NOTIFY_OPTION));
+       
+               if(!smb_io_notify_option("notify option", q_u->option, ps, depth))
+                       return False;
+       }
+       
        return True;
 }
 
@@ -1056,13 +1074,13 @@ BOOL spoolss_io_q_rffpcnex(char *desc, SPOOL_Q_RFFPCNEX *q_u,
  * write a structure.
  * called from spoolss_r_rffpcnex (srv_spoolss.c)
  ********************************************************************/
-BOOL spoolss_io_r_rffpcnex(char *desc, SPOOL_R_RFFPCNEX *r_u, 
-                           prs_struct *ps, int depth)
+BOOL spoolss_io_r_rffpcnex(char *desc, SPOOL_R_RFFPCNEX *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_rffpcnex");
        depth++;
 
-       prs_uint32("status", ps, depth, &(r_u->status));
+       if(!prs_uint32("status", ps, depth, &r_u->status))
+               return False;
 
        return True;
 }
@@ -1071,20 +1089,31 @@ BOOL spoolss_io_r_rffpcnex(char *desc, SPOOL_R_RFFPCNEX *r_u,
  * read a structure.
  * called from spoolss_q_rfnpcnex (srv_spoolss.c)
  ********************************************************************/
-BOOL spoolss_io_q_rfnpcnex(char *desc, SPOOL_Q_RFNPCNEX *q_u,
-                           prs_struct *ps, int depth)
+BOOL spoolss_io_q_rfnpcnex(char *desc, SPOOL_Q_RFNPCNEX *q_u, prs_struct *ps, int depth)
 {
-
        prs_debug(ps, depth, desc, "spoolss_io_q_rfnpcnex");
        depth++;
 
-       prs_align(ps);
+       if(!prs_align(ps))
+               return False;
 
-       smb_io_prt_hnd("printer handle",&(q_u->handle),ps,depth);
+       if(!smb_io_pol_hnd("printer handle",&q_u->handle,ps,depth))
+               return False;
 
-       prs_uint32("change", ps, depth, &(q_u->change));
+       if(!prs_uint32("change", ps, depth, &q_u->change))
+               return False;
+       
+       if(!prs_uint32("option_ptr", ps, depth, &q_u->option_ptr))
+               return False;
+       
+       if (q_u->option_ptr!=0) {
+       
+               if (UNMARSHALLING(ps))
+                       q_u->option=(SPOOL_NOTIFY_OPTION *)malloc(sizeof(SPOOL_NOTIFY_OPTION));
        
-       smb_io_notify_option("notify option",&(q_u->option),ps,depth);
+               if(!smb_io_notify_option("notify option", q_u->option, ps, depth))
+                       return False;
+       }
 
        return True;
 }
@@ -1093,22 +1122,36 @@ BOOL spoolss_io_q_rfnpcnex(char *desc, SPOOL_Q_RFNPCNEX *q_u,
  * write a structure.
  * called from spoolss_r_rfnpcnex (srv_spoolss.c)
  ********************************************************************/
-BOOL spoolss_io_r_rfnpcnex(char *desc, 
-                           SPOOL_R_RFNPCNEX *r_u, 
-                           prs_struct *ps, int depth)
+BOOL spoolss_io_r_rfnpcnex(char *desc, SPOOL_R_RFNPCNEX *r_u, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_rfnpcnex");
        depth++;
 
-       prs_align(ps);
+       if(!prs_align(ps))
+               return False;
+               
+       if (!prs_uint32("info_ptr", ps, depth, &r_u->info_ptr))
+               return False;
 
-       smb_io_notify_info("notify info",&(r_u->info),ps,depth);                
-       prs_align(ps);
-       prs_uint32("status", ps, depth, &r_u->status);
+       if(!smb_io_notify_info("notify info", &r_u->info ,ps,depth))
+               return False;
+       
+       if(!prs_align(ps))
+               return False;
+       if(!prs_uint32("status", ps, depth, &r_u->status))
+               return False;
 
        return True;
 }
 
+/*******************************************************************
+ * return the length of a uint16 (obvious, but the code is clean)
+ ********************************************************************/
+static uint32 size_of_uint16(uint16 *value)
+{
+       return (sizeof(*value));
+}
+
 /*******************************************************************
  * return the length of a uint32 (obvious, but the code is clean)
  ********************************************************************/
@@ -1116,7 +1159,6 @@ static uint32 size_of_uint32(uint32 *value)
 {
        return (sizeof(*value));
 }
-
 /*******************************************************************
  * return the length of a UNICODE string in number of char, includes:
  * - the leading zero
@@ -1160,7 +1202,7 @@ static uint32 size_of_systemtime(SYSTEMTIME *systime)
  * write a UNICODE string.
  * used by all the RPC structs passing a buffer
  ********************************************************************/
-static BOOL spoolss_smb_io_unistr(char *desc,  UNISTR *uni, prs_struct *ps, int depth)
+static BOOL spoolss_smb_io_unistr(char *desc, UNISTR *uni, prs_struct *ps, int depth)
 {
        if (uni == NULL)
                return False;
@@ -1169,49 +1211,11 @@ static BOOL spoolss_smb_io_unistr(char *desc,  UNISTR *uni, prs_struct *ps, int
        depth++;
        if (!prs_unistr("unistr", ps, depth, uni))
                return False;
-}
-
-
-/*******************************************************************
- * write a UNICODE string and its relative pointer.
- * used by all the RPC structs passing a buffer
- ********************************************************************/
-static BOOL smb_io_relstr(char *desc, prs_struct *ps, int depth, UNISTR *buffer,
-                   uint32 *start_offset, uint32 *end_offset)
-{
-       if (!ps->io)
-       {
-               uint32 struct_offset = prs_offset(ps);
-               uint32 relative_offset;
-               
-               /* writing */
-               *end_offset -= 2*(str_len_uni(buffer)+1);
-               prs_set_offset(ps, *end_offset);
-               spoolss_smb_io_unistr(desc, buffer, ps, depth);
-
-               prs_set_offset(ps,struct_offset);
-               relative_offset=*end_offset-*start_offset;
-
-               prs_uint32("offset", ps, depth, &(relative_offset));
-       }
-       else
-       {
-               uint32 old_offset;
-               uint32 relative_offset;
-
-               prs_uint32("offset", ps, depth, &(relative_offset));
-
-               old_offset = prs_offset(ps);
-               prs_set_offset(ps, (*start_offset) + relative_offset);
-
-               spoolss_smb_io_unistr(desc, buffer, ps, depth);
 
-               *end_offset = prs_offset(ps);
-               prs_set_offset(ps, old_offset);
-       }
        return True;
 }
 
+
 /*******************************************************************
  * write a UNICODE string and its relative pointer.
  * used by all the RPC structs passing a buffer
@@ -1261,7 +1265,7 @@ static BOOL new_smb_io_relstr(char *desc, NEW_BUFFER *buffer, int depth, UNISTR
                        return False;
 
                old_offset = prs_offset(ps);
-               prs_set_offset(ps, buffer->string_at_end);
+               prs_set_offset(ps, buffer->string_at_end+buffer->struct_start);
 
                /* read the string */
                if (!spoolss_smb_io_unistr(desc, string, ps, depth))
@@ -1338,46 +1342,11 @@ static BOOL new_smb_io_relarraystr(char *desc, NEW_BUFFER *buffer, int depth, UN
        return True;
 }
 
-static BOOL smb_io_relarraystr(char *desc, prs_struct *ps, int depth, UNISTR ***buffer,
-                   uint32 *start_offset, uint32 *end_offset)
-{
-       int i=0;
-       uint32 struct_offset;
-       uint32 relative_offset;
-       struct_offset=prs_offset(ps);
-       
-       while ( (*buffer)[i]!=0x0000 )
-       {
-               i++;
-       }
-       
-       i--;
-       
-       /* that's for the ending NULL */
-       *end_offset-=2;
-       
-       do
-       {
-               *end_offset-= 2*(str_len_uni((*buffer)[i])+1);  
-               prs_set_offset(ps, *end_offset);
-               spoolss_smb_io_unistr(desc, (*buffer)[i], ps, depth);
-               
-               i--;
-       }
-       while (i>=0);
-
-       prs_set_offset(ps, struct_offset);
-       relative_offset=*end_offset-*start_offset;
-
-       prs_uint32("offset", ps, depth, &(relative_offset));
-
-       return True;
-}
 
 /*******************************************************************
  Parse a DEVMODE structure and its relative pointer.
 ********************************************************************/
-static BOOL new_smb_io_reldevmode(char *desc, NEW_BUFFER *buffer, int depth, DEVICEMODE *devmode)
+static BOOL new_smb_io_reldevmode(char *desc, NEW_BUFFER *buffer, int depth, DEVICEMODE **devmode)
 {
        prs_struct *ps=&(buffer->prs);
 
@@ -1388,12 +1357,12 @@ static BOOL new_smb_io_reldevmode(char *desc, NEW_BUFFER *buffer, int depth, DEV
                uint32 struct_offset = prs_offset(ps);
                uint32 relative_offset;
                
-               buffer->string_at_end -= (devmode->size+devmode->driverextra);
+               buffer->string_at_end -= ((*devmode)->size + (*devmode)->driverextra);
                
                prs_set_offset(ps, buffer->string_at_end);
                
                /* write the DEVMODE */
-               if (!spoolss_io_devmode(desc, ps, depth, devmode))
+               if (!spoolss_io_devmode(desc, ps, depth, *devmode))
                        return False;
 
                prs_set_offset(ps, struct_offset);
@@ -1414,7 +1383,8 @@ static BOOL new_smb_io_reldevmode(char *desc, NEW_BUFFER *buffer, int depth, DEV
                prs_set_offset(ps, buffer->string_at_end + buffer->struct_start);
 
                /* read the string */
-               if (!spoolss_io_devmode(desc, ps, depth, devmode))
+               *devmode=(DEVICEMODE *)malloc(sizeof(DEVICEMODE));
+               if (!spoolss_io_devmode(desc, ps, depth, *devmode))
                        return False;
 
                prs_set_offset(ps, old_offset);
@@ -1423,29 +1393,6 @@ static BOOL new_smb_io_reldevmode(char *desc, NEW_BUFFER *buffer, int depth, DEV
 }
 
 
-static BOOL smb_io_reldevmode(char *desc, prs_struct *ps, int depth, DEVICEMODE *devmode,
-                   uint32 *start_offset, uint32 *end_offset)
-{
-       uint32 struct_offset;
-       uint32 relative_offset;
-       
-       prs_debug(ps, depth, desc, "smb_io_reldevmode");
-       depth++;
-               
-       struct_offset=prs_offset(ps);
-       *end_offset-= (devmode->size+devmode->driverextra);
-       prs_set_offset(ps, *end_offset);
-
-       spoolss_io_devmode(desc, ps, depth, devmode);
-
-       prs_set_offset(ps, struct_offset);
-       relative_offset=*end_offset-*start_offset;
-
-       prs_uint32("offset", ps, depth, &(relative_offset));
-
-       return True;
-}
-
 /*******************************************************************
  Parse a PRINTER_INFO_0 structure.
 ********************************************************************/  
@@ -1465,26 +1412,36 @@ BOOL new_smb_io_printer_info_0(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_0 *i
        
        if(!prs_uint32("cjobs", ps, depth, &info->cjobs))
                return False;
-       if(!prs_uint32("attributes", ps, depth, &info->attributes))
+       if(!prs_uint32("total_jobs", ps, depth, &info->total_jobs))
+               return False;
+       if(!prs_uint32("total_bytes", ps, depth, &info->total_bytes))
                return False;
 
-       if(!prs_uint32("unknown0", ps, depth, &info->unknown0))
+       if(!prs_uint16("year", ps, depth, &info->year))
                return False;
-       if(!prs_uint32("unknown1", ps, depth, &info->unknown1))
+       if(!prs_uint16("month", ps, depth, &info->month))
                return False;
-       if(!prs_uint32("unknown2", ps, depth, &info->unknown2))
+       if(!prs_uint16("dayofweek", ps, depth, &info->dayofweek))
                return False;
-       if(!prs_uint32("unknown3", ps, depth, &info->unknown3))
+       if(!prs_uint16("day", ps, depth, &info->day))
                return False;
-       if(!prs_uint32("unknown4", ps, depth, &info->unknown4))
+       if(!prs_uint16("hour", ps, depth, &info->hour))
                return False;
-       if(!prs_uint32("unknown5", ps, depth, &info->unknown5))
+       if(!prs_uint16("minute", ps, depth, &info->minute))
                return False;
-       if(!prs_uint32("unknown6", ps, depth, &info->unknown6))
+       if(!prs_uint16("second", ps, depth, &info->second))
                return False;
-       if(!prs_uint16("majorversion", ps, depth, &info->majorversion))
+       if(!prs_uint16("milliseconds", ps, depth, &info->milliseconds))
                return False;
-       if(!prs_uint16("buildversion", ps, depth, &info->buildversion))
+
+       if(!prs_uint32("global_counter", ps, depth, &info->global_counter))
+               return False;
+       if(!prs_uint32("total_pages", ps, depth, &info->total_pages))
+               return False;
+
+       if(!prs_uint16("major_version", ps, depth, &info->major_version))
+               return False;
+       if(!prs_uint16("build_version", ps, depth, &info->build_version))
                return False;
        if(!prs_uint32("unknown7", ps, depth, &info->unknown7))
                return False;
@@ -1492,11 +1449,11 @@ BOOL new_smb_io_printer_info_0(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_0 *i
                return False;
        if(!prs_uint32("unknown9", ps, depth, &info->unknown9))
                return False;
-       if(!prs_uint32("unknown10", ps, depth, &info->unknown10))
+       if(!prs_uint32("session_counter", ps, depth, &info->session_counter))
                return False;
        if(!prs_uint32("unknown11", ps, depth, &info->unknown11))
                return False;
-       if(!prs_uint32("unknown12", ps, depth, &info->unknown12))
+       if(!prs_uint32("printer_errors", ps, depth, &info->printer_errors))
                return False;
        if(!prs_uint32("unknown13", ps, depth, &info->unknown13))
                return False;
@@ -1506,7 +1463,7 @@ BOOL new_smb_io_printer_info_0(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_0 *i
                return False;
        if(!prs_uint32("unknown16", ps, depth, &info->unknown16))
                return False;
-       if(!prs_uint32("unknown17", ps, depth, &info->unknown17))
+       if(!prs_uint32("change_id", ps, depth, &info->change_id))
                return False;
        if(!prs_uint32("unknown18", ps, depth, &info->unknown18))
                return False;
@@ -1514,11 +1471,23 @@ BOOL new_smb_io_printer_info_0(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_0 *i
                return False;
        if(!prs_uint32("unknown20", ps, depth, &info->unknown20))
                return False;
-       if(!prs_uint32("unknown21", ps, depth, &info->unknown21))
+       if(!prs_uint32("c_setprinter", ps, depth, &info->c_setprinter))
                return False;
        if(!prs_uint16("unknown22", ps, depth, &info->unknown22))
                return False;
-       if(!prs_uint32("unknown23", ps, depth, &info->unknown23))
+       if(!prs_uint16("unknown23", ps, depth, &info->unknown23))
+               return False;
+       if(!prs_uint16("unknown24", ps, depth, &info->unknown24))
+               return False;
+       if(!prs_uint16("unknown25", ps, depth, &info->unknown25))
+               return False;
+       if(!prs_uint16("unknown26", ps, depth, &info->unknown26))
+               return False;
+       if(!prs_uint16("unknown27", ps, depth, &info->unknown27))
+               return False;
+       if(!prs_uint16("unknown28", ps, depth, &info->unknown28))
+               return False;
+       if(!prs_uint16("unknown29", ps, depth, &info->unknown29))
                return False;
 
        return True;
@@ -1579,7 +1548,7 @@ BOOL new_smb_io_printer_info_2(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_2 *i
                return False;
 
        /* NT parses the DEVMODE at the end of the struct */
-       if (!new_smb_io_reldevmode("devmode", buffer, depth, info->devmode))
+       if (!new_smb_io_reldevmode("devmode", buffer, depth, &info->devmode))
                return False;
        
        if (!new_smb_io_relstr("sepfile", buffer, depth, &info->sepfile))
@@ -1631,17 +1600,6 @@ BOOL new_smb_io_printer_driver_info_1(char *desc, NEW_BUFFER *buffer, DRIVER_INF
        return True;
 }
 
-static BOOL smb_io_printer_driver_info_1(char *desc, DRIVER_INFO_1 *info, prs_struct *ps, int depth, 
-                                         uint32 *start_offset, uint32 *end_offset)
-{
-       prs_debug(ps, depth, desc, "smb_io_printer_driver_info_1");
-       depth++;        
-       *start_offset=prs_offset(ps);
-
-       smb_io_relstr("name",          ps, depth, &(info->name), start_offset, end_offset);
-
-       return True;
-}
 
 /*******************************************************************
  Parse a DRIVER_INFO_2 structure.
@@ -1671,22 +1629,6 @@ BOOL new_smb_io_printer_driver_info_2(char *desc, NEW_BUFFER *buffer, DRIVER_INF
        return True;
 }
 
-static BOOL smb_io_printer_driver_info_2(char *desc, DRIVER_INFO_2 *info,prs_struct *ps, int depth, 
-                                         uint32 *start_offset, uint32 *end_offset)
-{
-       prs_debug(ps, depth, desc, "smb_io_printer_xxx");
-       depth++;        
-       *start_offset=prs_offset(ps);
-
-       prs_uint32("version",          ps, depth, &(info->version));
-       smb_io_relstr("name",          ps, depth, &(info->name), start_offset, end_offset);
-       smb_io_relstr("architecture",  ps, depth, &(info->architecture), start_offset, end_offset);
-       smb_io_relstr("driverpath",    ps, depth, &(info->driverpath), start_offset, end_offset);
-       smb_io_relstr("datafile",      ps, depth, &(info->datafile), start_offset, end_offset);
-       smb_io_relstr("configfile",    ps, depth, &(info->configfile), start_offset, end_offset);
-
-       return True;
-}
 
 /*******************************************************************
  Parse a DRIVER_INFO_3 structure.
@@ -1726,28 +1668,6 @@ BOOL new_smb_io_printer_driver_info_3(char *desc, NEW_BUFFER *buffer, DRIVER_INF
        return True;
 }
 
-static BOOL smb_io_printer_driver_info_3(char *desc, DRIVER_INFO_3 *info,prs_struct *ps, int depth, 
-                                         uint32 *start_offset, uint32 *end_offset)
-{
-       prs_debug(ps, depth, desc, "smb_io_printer_driver_info_3");
-       depth++;        
-       *start_offset=prs_offset(ps);
-
-       prs_uint32("version",            ps, depth, &(info->version));
-       smb_io_relstr("name",            ps, depth, &(info->name), start_offset, end_offset);
-       smb_io_relstr("architecture",    ps, depth, &(info->architecture), start_offset, end_offset);
-       smb_io_relstr("driverpath",      ps, depth, &(info->driverpath), start_offset, end_offset);
-       smb_io_relstr("datafile",        ps, depth, &(info->datafile), start_offset, end_offset);
-       smb_io_relstr("configfile",      ps, depth, &(info->configfile), start_offset, end_offset);
-       smb_io_relstr("helpfile",        ps, depth, &(info->helpfile), start_offset, end_offset);
-
-       smb_io_relarraystr("dependentfiles", ps, depth, &(info->dependentfiles), start_offset, end_offset);
-
-       smb_io_relstr("monitorname",     ps, depth, &(info->monitorname), start_offset, end_offset);
-       smb_io_relstr("defaultdatatype", ps, depth, &(info->defaultdatatype), start_offset, end_offset);
-
-       return True;
-}
 
 /*******************************************************************
  Parse a JOB_INFO_1 structure.
@@ -1825,7 +1745,7 @@ BOOL new_smb_io_job_info_2(char *desc, NEW_BUFFER *buffer, JOB_INFO_2 *info, int
                return False;
        if (!new_smb_io_relstr("drivername", buffer, depth, &info->drivername))
                return False;
-       if (!new_smb_io_reldevmode("devmode", buffer, depth, info->devmode))
+       if (!new_smb_io_reldevmode("devmode", buffer, depth, &info->devmode))
                return False;
        if (!new_smb_io_relstr("text_status", buffer, depth, &info->text_status))
                return False;
@@ -1944,7 +1864,9 @@ static BOOL new_spoolss_io_buffer(char *desc, prs_struct *ps, int depth, NEW_BUF
                        return False;
                if (!prs_append_some_prs_data(ps, &(buffer->prs), 0, buffer->size))
                        return False;
-       }               
+
+               return True;
+       }
 }
 
 /*******************************************************************
@@ -1998,26 +1920,6 @@ uint32 new_get_buffer_size(NEW_BUFFER *buffer)
        return (buffer->size);
 }
 
-/*******************************************************************
-********************************************************************/  
-static BOOL smb_io_form_1(char *desc, FORM_1 *info, prs_struct *ps, int depth, 
-                          uint32 *start_offset, uint32 *end_offset)
-{
-       prs_debug(ps, depth, desc, "smb_io_form_1");
-       depth++;        
-       *start_offset=prs_offset(ps);
-
-       prs_uint32("flag", ps, depth, &(info->flag));
-       smb_io_relstr("name",ps, depth, &(info->name), start_offset, end_offset);
-       prs_uint32("width", ps, depth, &(info->width));
-       prs_uint32("length", ps, depth, &(info->length));
-       prs_uint32("left", ps, depth, &(info->left));
-       prs_uint32("top", ps, depth, &(info->top));
-       prs_uint32("right", ps, depth, &(info->right));
-       prs_uint32("bottom", ps, depth, &(info->bottom));
-
-       return True;
-}
 
 /*******************************************************************
  Parse a DRIVER_DIRECTORY_1 structure.
@@ -2031,7 +1933,7 @@ BOOL new_smb_io_driverdir_1(char *desc, NEW_BUFFER *buffer, DRIVER_DIRECTORY_1 *
 
        buffer->struct_start=prs_offset(ps);
 
-       if(!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!spoolss_smb_io_unistr(desc, &info->name, ps, depth))
                return False;
 
        return True;
@@ -2081,29 +1983,31 @@ BOOL new_smb_io_port_2(char *desc, NEW_BUFFER *buffer, PORT_INFO_2 *info, int de
        return True;
 }
 
-static BOOL smb_io_port_2(char *desc, PORT_INFO_2 *info, prs_struct *ps, int depth, 
-                          uint32 *start_offset, uint32 *end_offset)
+
+/*******************************************************************
+********************************************************************/  
+BOOL smb_io_printprocessor_info_1(char *desc, NEW_BUFFER *buffer, PRINTPROCESSOR_1 *info, int depth)
 {
-       prs_debug(ps, depth, desc, "smb_io_port_2");
+       prs_struct *ps=&(buffer->prs);
+
+       prs_debug(ps, depth, desc, "smb_io_printprocessor_info_1");
        depth++;        
-       *start_offset=prs_offset(ps);
 
-       smb_io_relstr("port_name",ps, depth, &(info->port_name), start_offset, end_offset);
-       smb_io_relstr("monitor_name",ps, depth, &(info->monitor_name), start_offset, end_offset);
-       smb_io_relstr("description",ps, depth, &(info->description), start_offset, end_offset);
-       prs_uint32("port_type", ps, depth, &(info->port_type));
-       prs_uint32("reserved", ps, depth, &(info->reserved));
+       buffer->struct_start=prs_offset(ps);
+       
+       if (new_smb_io_relstr("name", buffer, depth, &info->name))
+               return False;
 
        return True;
 }
 
 /*******************************************************************
 ********************************************************************/  
-BOOL smb_io_printprocessor_info_1(char *desc, NEW_BUFFER *buffer, PRINTPROCESSOR_1 *info, int depth)
+BOOL smb_io_printprocdatatype_info_1(char *desc, NEW_BUFFER *buffer, PRINTPROCDATATYPE_1 *info, int depth)
 {
        prs_struct *ps=&(buffer->prs);
 
-       prs_debug(ps, depth, desc, "smb_io_printprocessor_info_1");
+       prs_debug(ps, depth, desc, "smb_io_printprocdatatype_info_1");
        depth++;        
 
        buffer->struct_start=prs_offset(ps);
@@ -2159,13 +2063,53 @@ uint32 spoolss_size_printer_info_0(PRINTER_INFO_0 *info)
 {
        int size=0;
        
-       size+=24*4;
-       size+=6;
+       size+=size_of_relative_string( &info->printername );
+       size+=size_of_relative_string( &info->servername );
+
+       size+=size_of_uint32( &info->cjobs);
+       size+=size_of_uint32( &info->total_jobs);
+       size+=size_of_uint32( &info->total_bytes);
+
+       size+=size_of_uint16( &info->year);
+       size+=size_of_uint16( &info->month);
+       size+=size_of_uint16( &info->dayofweek);
+       size+=size_of_uint16( &info->day);
+       size+=size_of_uint16( &info->hour);
+       size+=size_of_uint16( &info->minute);
+       size+=size_of_uint16( &info->second);
+       size+=size_of_uint16( &info->milliseconds);
+
+       size+=size_of_uint32( &info->global_counter);
+       size+=size_of_uint32( &info->total_pages);
+
+       size+=size_of_uint16( &info->major_version);
+       size+=size_of_uint16( &info->build_version);
+
+       size+=size_of_uint32( &info->unknown7);
+       size+=size_of_uint32( &info->unknown8);
+       size+=size_of_uint32( &info->unknown9);
+       size+=size_of_uint32( &info->session_counter);
+       size+=size_of_uint32( &info->unknown11);
+       size+=size_of_uint32( &info->printer_errors);
+       size+=size_of_uint32( &info->unknown13);
+       size+=size_of_uint32( &info->unknown14);
+       size+=size_of_uint32( &info->unknown15);
+       size+=size_of_uint32( &info->unknown16);
+       size+=size_of_uint32( &info->change_id);
+       size+=size_of_uint32( &info->unknown18);
+       size+=size_of_uint32( &info->status);
+       size+=size_of_uint32( &info->unknown20);
+       size+=size_of_uint32( &info->c_setprinter);
+       
+       size+=size_of_uint16( &info->unknown22);
+       size+=size_of_uint16( &info->unknown23);
+       size+=size_of_uint16( &info->unknown24);
+       size+=size_of_uint16( &info->unknown25);
+       size+=size_of_uint16( &info->unknown26);
+       size+=size_of_uint16( &info->unknown27);
+       size+=size_of_uint16( &info->unknown28);
+       size+=size_of_uint16( &info->unknown29);
        
-       size+=size_of_uint32( &(info->attributes) );    
-       size+=size_of_relative_string( &(info->printername) );
-       size+=size_of_relative_string( &(info->servername) );
-
        return size;
 }
 
@@ -2374,7 +2318,9 @@ uint32 spoolss_size_driverdir_info_1(DRIVER_DIRECTORY_1 *info)
 {
        int size=0;
 
-       size+=size_of_relative_string( &info->name );
+       size=str_len_uni(&info->name);  /* the string length       */
+       size=size+1;                    /* add the leading zero    */
+       size=size*2;                    /* convert in char         */
 
        return size;
 }
@@ -2407,6 +2353,17 @@ uint32 spoolss_size_printprocessor_info_1(PRINTPROCESSOR_1 *info)
        return size;
 }
 
+/*******************************************************************
+return the size required by a struct in the stream
+********************************************************************/  
+uint32 spoolss_size_printprocdatatype_info_1(PRINTPROCDATATYPE_1 *info)
+{
+       int size=0;
+       size+=size_of_relative_string( &info->name );
+
+       return size;
+}
+
 /*******************************************************************
 return the size required by a struct in the stream
 ********************************************************************/  
@@ -2443,7 +2400,7 @@ BOOL spoolss_io_q_getprinterdriver2(char *desc, SPOOL_Q_GETPRINTERDRIVER2 *q_u,
        if(!prs_align(ps))
                return False;
        
-       if(!smb_io_prt_hnd("printer handle", &q_u->handle, ps, depth))
+       if(!smb_io_pol_hnd("printer handle", &q_u->handle, ps, depth))
                return False;
        if(!prs_uint32("architecture_ptr", ps, depth, &q_u->architecture_ptr))
                return False;
@@ -2464,7 +2421,9 @@ BOOL spoolss_io_q_getprinterdriver2(char *desc, SPOOL_Q_GETPRINTERDRIVER2 *q_u,
        if(!prs_uint32("offered", ps, depth, &q_u->offered))
                return False;
                
-       if(!prs_uint32("unknown", ps, depth, &q_u->unknown))
+       if(!prs_uint32("clientmajorversion", ps, depth, &q_u->clientmajorversion))
+               return False;
+       if(!prs_uint32("clientminorversion", ps, depth, &q_u->clientminorversion))
                return False;
 
        return True;
@@ -2489,9 +2448,9 @@ BOOL spoolss_io_r_getprinterdriver2(char *desc, SPOOL_R_GETPRINTERDRIVER2 *r_u,
                return False;
        if (!prs_uint32("needed", ps, depth, &r_u->needed))
                return False;
-       if (!prs_uint32("unknown0", ps, depth, &r_u->unknown0))
+       if (!prs_uint32("servermajorversion", ps, depth, &r_u->servermajorversion))
                return False;
-       if (!prs_uint32("unknown1", ps, depth, &r_u->unknown1))
+       if (!prs_uint32("serverminorversion", ps, depth, &r_u->serverminorversion))
                return False;           
        if (!prs_uint32("status", ps, depth, &r_u->status))
                return False;
@@ -2499,40 +2458,21 @@ BOOL spoolss_io_r_getprinterdriver2(char *desc, SPOOL_R_GETPRINTERDRIVER2 *r_u,
        return True;            
 }
 
-/*
-       UNISTR **dependentfiles;
-       int j=0;
-       dependentfiles=info3->dependentfiles;
-       while ( dependentfiles[j] != NULL )
-       {
-               free(dependentfiles[j]);
-               j++;
-       }
-       free(dependentfiles);
-
-       free(info3);
-*/
-
 /*******************************************************************
- * make a structure.
+ * init a structure.
  ********************************************************************/
-BOOL make_spoolss_q_enumprinters(SPOOL_Q_ENUMPRINTERS *q_u,
-                               uint32 flags,
-                               const char* servername,
-                               uint32 level,
-                               uint32 size)
+BOOL make_spoolss_q_enumprinters(SPOOL_Q_ENUMPRINTERS *q_u, uint32 flags, 
+                               fstring servername, uint32 level, 
+                               NEW_BUFFER *buffer, uint32 offered)
 {
-       size_t len_name = servername != NULL ? strlen(servername) : 0;
-
-       DEBUG(5,("make_spoolss_q_enumprinters.  size: %d\n", size));
-
-       q_u->flags = flags;
-
-       init_unistr2(&q_u->servername, servername, len_name);
+       q_u->flags=flags;
+       
+       q_u->servername_ptr = (servername != NULL) ? 1 : 0;
+       init_unistr2(&(q_u->servername), servername, strlen(servername));
 
-       q_u->level = level;
-       /*make_spoolss_buffer(&q_u->buffer, size);*/
-/*     q_u->buf_size = size;*/
+       q_u->level=level;
+       q_u->buffer=buffer;
+       q_u->offered=offered;
 
        return True;
 }
@@ -2630,26 +2570,6 @@ BOOL spoolss_io_r_getprinter(char *desc, SPOOL_R_GETPRINTER *r_u, prs_struct *ps
        return True;            
 }
 
-/*******************************************************************
- * make a structure.
- * called from spoolss_getprinter (srv_spoolss.c)
- ********************************************************************/
-BOOL make_spoolss_q_getprinter(SPOOL_Q_GETPRINTER *q_u,
-                               POLICY_HND *hnd,
-                               uint32 level,
-                               uint32 buf_size)
-{
-       if (q_u == NULL) return False;
-
-       memcpy(&q_u->handle, hnd, sizeof(q_u->handle));
-       
-       q_u->level = level;
-       q_u->buffer = (uint8 *)Realloc(NULL, (buf_size) * sizeof(uint8) );
-       q_u->offered = buf_size;
-
-       return True;
-}
-
 /*******************************************************************
  * read a structure.
  * called from spoolss_getprinter (srv_spoolss.c)
@@ -2662,7 +2582,7 @@ BOOL spoolss_io_q_getprinter(char *desc, SPOOL_Q_GETPRINTER *q_u, prs_struct *ps
        if (!prs_align(ps))
                return False;
 
-       if(!smb_io_prt_hnd("printer handle", &q_u->handle, ps, depth))
+       if(!smb_io_pol_hnd("printer handle", &q_u->handle, ps, depth))
                return False;
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
@@ -2699,24 +2619,25 @@ BOOL spoolss_io_q_setprinter(char *desc, SPOOL_Q_SETPRINTER *q_u, prs_struct *ps
        prs_debug(ps, depth, desc, "spoolss_io_q_setprinter");
        depth++;
 
-       prs_align(ps);
-
-       smb_io_prt_hnd("printer handle", &(q_u->handle),ps,depth);
-       prs_uint32("level", ps, depth, &(q_u->level));
-
-       /* again a designed mess */
-       /* sometimes I'm wondering how all of this work ! */
+       if(!prs_align(ps))
+               return False;
 
-       /* To be correct it need to be split in 3 functions */
+       if(!smb_io_pol_hnd("printer handle", &q_u->handle ,ps, depth))
+               return False;
+       if(!prs_uint32("level", ps, depth, &q_u->level))
+               return False;
 
-       spool_io_printer_info_level("", &(q_u->info), ps, depth);
+       if(!spool_io_printer_info_level("", &q_u->info, ps, depth))
+               return False;
 
-       spoolss_io_devmode(desc, ps, depth, q_u->devmode);
+       if (!spoolss_io_devmode_cont(desc, &q_u->devmode_ctr, ps, depth))
+               return False;
        
-       prs_uint32("security.size_of_buffer", ps, depth, &(q_u->security.size_of_buffer));
-       prs_uint32("security.data",           ps, depth, &(q_u->security.data));
+       prs_uint32("security.size_of_buffer", ps, depth, &q_u->security.size_of_buffer);
+       prs_uint32("security.data", ps, depth, &q_u->security.data);
        
-       prs_uint32("command", ps, depth, &(q_u->command));
+       if(!prs_uint32("command", ps, depth, &q_u->command))
+               return False;
 
        return True;
 }
@@ -2745,7 +2666,7 @@ BOOL spoolss_io_q_fcpn(char *desc, SPOOL_Q_FCPN *q_u, prs_struct *ps, int depth)
 
        prs_align(ps);
 
-       smb_io_prt_hnd("printer handle",&(q_u->handle),ps,depth);
+       smb_io_pol_hnd("printer handle",&(q_u->handle),ps,depth);
 
        return True;
 }
@@ -2777,7 +2698,7 @@ BOOL spoolss_io_q_addjob(char *desc, SPOOL_Q_ADDJOB *q_u, prs_struct *ps, int de
        if(!prs_align(ps))
                return False;
 
-       if(!smb_io_prt_hnd("printer handle", &q_u->handle, ps, depth))
+       if(!smb_io_pol_hnd("printer handle", &q_u->handle, ps, depth))
                return False;
        if(!prs_uint32("level", ps, depth, &q_u->level))
                return False;
@@ -2829,7 +2750,8 @@ BOOL make_spoolss_q_enumjobs(SPOOL_Q_ENUMJOBS *q_u, const POLICY_HND *hnd,
                                uint32 firstjob,
                                uint32 numofjobs,
                                uint32 level,
-                               uint32 buf_size)
+                               NEW_BUFFER *buffer,
+                               uint32 offered)
 {
        if (q_u == NULL)
        {
@@ -2839,13 +2761,8 @@ BOOL make_spoolss_q_enumjobs(SPOOL_Q_ENUMJOBS *q_u, const POLICY_HND *hnd,
        q_u->firstjob = firstjob;
        q_u->numofjobs = numofjobs;
        q_u->level = level;
-/*     
-       if (!make_spoolss_buffer(&q_u->buffer, buf_size))
-       {
-               return False;
-       }
-       q_u->buf_size = buf_size;
-*/
+       q_u->buffer= buffer;
+       q_u->offered = offered;
        return True;
 }
 
@@ -2859,7 +2776,7 @@ BOOL spoolss_io_q_enumjobs(char *desc, SPOOL_Q_ENUMJOBS *q_u, prs_struct *ps, in
        if (!prs_align(ps))
                return False;
 
-       if (!smb_io_prt_hnd("printer handle",&q_u->handle, ps, depth))
+       if (!smb_io_pol_hnd("printer handle",&q_u->handle, ps, depth))
                return False;
                
        if (!prs_uint32("firstjob", ps, depth, &q_u->firstjob))
@@ -2901,7 +2818,7 @@ BOOL spoolss_io_q_schedulejob(char *desc, SPOOL_Q_SCHEDULEJOB *q_u, prs_struct *
 
        prs_align(ps);
 
-       smb_io_prt_hnd("printer handle",&(q_u->handle),ps,depth);
+       smb_io_pol_hnd("printer handle",&(q_u->handle),ps,depth);
        prs_uint32("jobid", ps, depth, &(q_u->jobid));
 
        return True;
@@ -2930,7 +2847,7 @@ BOOL spoolss_io_q_setjob(char *desc, SPOOL_Q_SETJOB *q_u, prs_struct *ps, int de
 
        prs_align(ps);
 
-       smb_io_prt_hnd("printer handle",&(q_u->handle),ps,depth);
+       smb_io_pol_hnd("printer handle",&(q_u->handle),ps,depth);
        prs_uint32("jobid", ps, depth, &(q_u->jobid));
        /* 
         * level is usually 0. If (level!=0) then I'm in trouble !
@@ -3023,7 +2940,7 @@ BOOL spoolss_io_q_enumforms(char *desc, SPOOL_Q_ENUMFORMS *q_u, prs_struct *ps,
 
        if (!prs_align(ps))
                return False;                   
-       if (!smb_io_prt_hnd("printer handle",&(q_u->handle),ps,depth))
+       if (!smb_io_pol_hnd("printer handle",&(q_u->handle),ps,depth))
                return False;           
        if (!prs_uint32("level", ps, depth, &(q_u->level)))
                return False;   
@@ -3128,77 +3045,83 @@ BOOL spoolss_io_q_enumports(char *desc, SPOOL_Q_ENUMPORTS *q_u, prs_struct *ps,
        return True;
 }
 
-
 /*******************************************************************
+ Parse a SPOOL_PRINTER_INFO_LEVEL_2 structure.
 ********************************************************************/  
-BOOL spool_io_printer_info_level_2(char *desc, SPOOL_PRINTER_INFO_LEVEL_2 **q_u, prs_struct *ps, int depth)
+BOOL spool_io_printer_info_level_2(char *desc, SPOOL_PRINTER_INFO_LEVEL_2 *il, prs_struct *ps, int depth)
 {      
-       SPOOL_PRINTER_INFO_LEVEL_2 *il;
-       
-       prs_debug(ps, depth, desc, "");
+       prs_debug(ps, depth, desc, "spool_io_printer_info_level_2");
        depth++;
-
-       /* reading */
-       if (ps->io)
-       {
-               il=(SPOOL_PRINTER_INFO_LEVEL_2 *)malloc(sizeof(SPOOL_PRINTER_INFO_LEVEL_2));
-               ZERO_STRUCTP(il);
-               *q_u=il;
-               DEBUG(7,("lecture: memoire ok\n"));
-       }
-       else
-       {
-               il=*q_u;
-       }
                
-       prs_align(ps);  
-
-       prs_uint32("servername_ptr",     ps, depth, &(il->servername_ptr));
-       prs_uint32("printername_ptr",    ps, depth, &(il->printername_ptr));
-       prs_uint32("sharename_ptr",      ps, depth, &(il->sharename_ptr));
-       prs_uint32("portname_ptr",       ps, depth, &(il->portname_ptr));
-       prs_uint32("drivername_ptr",     ps, depth, &(il->drivername_ptr));
-       prs_uint32("comment_ptr",        ps, depth, &(il->comment_ptr));
-       prs_uint32("location_ptr",       ps, depth, &(il->location_ptr));
-       prs_uint32("devmode_ptr",        ps, depth, &(il->devmode_ptr));
-       prs_uint32("sepfile_ptr",        ps, depth, &(il->sepfile_ptr));
-       prs_uint32("printprocessor_ptr", ps, depth, &(il->printprocessor_ptr));
-       prs_uint32("datatype_ptr",       ps, depth, &(il->datatype_ptr));
-       prs_uint32("parameters_ptr",     ps, depth, &(il->parameters_ptr));
-       prs_uint32("secdesc_ptr",        ps, depth, &(il->secdesc_ptr));
-
-       prs_uint32("attributes",         ps, depth, &(il->attributes));
-       prs_uint32("priority",           ps, depth, &(il->priority));
-       prs_uint32("default_priority",   ps, depth, &(il->default_priority));
-       prs_uint32("starttime",          ps, depth, &(il->starttime));
-       prs_uint32("untiltime",          ps, depth, &(il->untiltime));
-       prs_uint32("status",             ps, depth, &(il->status));
-       prs_uint32("cjobs",              ps, depth, &(il->cjobs));
-       prs_uint32("averageppm",         ps, depth, &(il->averageppm));
-
-       smb_io_unistr2("", &(il->servername),     il->servername_ptr,     ps, depth);   
-       smb_io_unistr2("", &(il->printername),    il->printername_ptr,    ps, depth);   
-       smb_io_unistr2("", &(il->sharename),      il->sharename_ptr,      ps, depth);   
-       smb_io_unistr2("", &(il->portname),       il->portname_ptr,       ps, depth);   
-       smb_io_unistr2("", &(il->drivername),     il->drivername_ptr,     ps, depth);   
-       smb_io_unistr2("", &(il->comment),        il->comment_ptr,        ps, depth);   
-       smb_io_unistr2("", &(il->location),       il->location_ptr,       ps, depth);   
-       smb_io_unistr2("", &(il->sepfile),        il->sepfile_ptr,        ps, depth);   
-       smb_io_unistr2("", &(il->printprocessor), il->printprocessor_ptr, ps, depth);   
-       smb_io_unistr2("", &(il->datatype),       il->datatype_ptr,       ps, depth);   
-       smb_io_unistr2("", &(il->parameters),     il->parameters_ptr,     ps, depth);   
+       if(!prs_align(ps))
+               return False;
 
-       prs_align(ps);
+       if(!prs_uint32("servername_ptr", ps, depth, &il->servername_ptr))
+               return False;
+       if(!prs_uint32("printername_ptr", ps, depth, &il->printername_ptr))
+               return False;
+       if(!prs_uint32("sharename_ptr", ps, depth, &il->sharename_ptr))
+               return False;
+       if(!prs_uint32("portname_ptr", ps, depth, &il->portname_ptr))
+               return False;
+       if(!prs_uint32("drivername_ptr", ps, depth, &il->drivername_ptr))
+               return False;
+       if(!prs_uint32("comment_ptr", ps, depth, &il->comment_ptr))
+               return False;
+       if(!prs_uint32("location_ptr", ps, depth, &il->location_ptr))
+               return False;
+       if(!prs_uint32("devmode_ptr", ps, depth, &il->devmode_ptr))
+               return False;
+       if(!prs_uint32("sepfile_ptr", ps, depth, &il->sepfile_ptr))
+               return False;
+       if(!prs_uint32("printprocessor_ptr", ps, depth, &il->printprocessor_ptr))
+               return False;
+       if(!prs_uint32("datatype_ptr", ps, depth, &il->datatype_ptr))
+               return False;
+       if(!prs_uint32("parameters_ptr", ps, depth, &il->parameters_ptr))
+               return False;
+       if(!prs_uint32("secdesc_ptr", ps, depth, &il->secdesc_ptr))
+               return False;
 
-       /* this code as nothing to do here !!!
-       
-       if (il->secdesc_ptr)
-       {
-               il->secdesc=NULL;
-               sec_io_desc_buf("", &(il->secdesc), ps, depth);
-       }
-       
-       */
+       if(!prs_uint32("attributes", ps, depth, &il->attributes))
+               return False;
+       if(!prs_uint32("priority", ps, depth, &il->priority))
+               return False;
+       if(!prs_uint32("default_priority", ps, depth, &il->default_priority))
+               return False;
+       if(!prs_uint32("starttime", ps, depth, &il->starttime))
+               return False;
+       if(!prs_uint32("untiltime", ps, depth, &il->untiltime))
+               return False;
+       if(!prs_uint32("status", ps, depth, &il->status))
+               return False;
+       if(!prs_uint32("cjobs", ps, depth, &il->cjobs))
+               return False;
+       if(!prs_uint32("averageppm", ps, depth, &il->averageppm))
+               return False;
+
+       if(!smb_io_unistr2("servername", &il->servername, il->servername_ptr, ps, depth))
+               return False;
+       if(!smb_io_unistr2("printername", &il->printername, il->printername_ptr, ps, depth))
+               return False;
+       if(!smb_io_unistr2("sharename", &il->sharename, il->sharename_ptr, ps, depth))
+               return False;
+       if(!smb_io_unistr2("portname", &il->portname, il->portname_ptr, ps, depth))
+               return False;
+       if(!smb_io_unistr2("drivername", &il->drivername, il->drivername_ptr, ps, depth))
+               return False;
+       if(!smb_io_unistr2("comment", &il->comment, il->comment_ptr, ps, depth))
+               return False;
+       if(!smb_io_unistr2("location", &il->location, il->location_ptr, ps, depth))
+               return False;
+       if(!smb_io_unistr2("sepfile", &il->sepfile, il->sepfile_ptr, ps, depth))
+               return False;
+       if(!smb_io_unistr2("printprocessor", &il->printprocessor, il->printprocessor_ptr, ps, depth))
+               return False;
+       if(!smb_io_unistr2("datatype", &il->datatype, il->datatype_ptr, ps, depth))
+               return False;
+       if(!smb_io_unistr2("parameters", &il->parameters, il->parameters_ptr, ps, depth))
+               return False;
 
        return True;
 }
@@ -3207,16 +3130,24 @@ BOOL spool_io_printer_info_level_2(char *desc, SPOOL_PRINTER_INFO_LEVEL_2 **q_u,
 ********************************************************************/  
 BOOL spool_io_printer_info_level(char *desc, SPOOL_PRINTER_INFO_LEVEL *il, prs_struct *ps, int depth)
 {
-       uint32 useless;
-       uint32 level;
-       prs_debug(ps, depth, desc, "");
+       prs_debug(ps, depth, desc, "spool_io_printer_info_level");
        depth++;
 
-       prs_align(ps);  
-       prs_uint32("info level", ps, depth, &level);
-       prs_uint32("useless", ps, depth, &useless);
-               
-       switch (level) {
+       if(!prs_align(ps))
+               return False;
+       if(!prs_uint32("level", ps, depth, &il->level))
+               return False;
+       if(!prs_uint32("info_ptr", ps, depth, &il->info_ptr))
+               return False;
+       
+       /* if no struct inside just return */
+       if (il->info_ptr==0) {
+               if (UNMARSHALLING(ps))
+                       il->info_2=NULL;
+               return True;
+       }
+                       
+       switch (il->level) {
                /*
                 * level 0 is used by setprinter when managing the queue
                 * (hold, stop, start a queue)
@@ -3228,11 +3159,13 @@ BOOL spool_io_printer_info_level(char *desc, SPOOL_PRINTER_INFO_LEVEL *il, prs_s
                 * and by setprinter when updating printer's info
                 */     
                case 2:
-                       spool_io_printer_info_level_2("", &(il->info_2), ps, depth);
+                       if (UNMARSHALLING(ps))
+                               il->info_2=(SPOOL_PRINTER_INFO_LEVEL_2 *)malloc(sizeof(SPOOL_PRINTER_INFO_LEVEL_2));
+                       if (!spool_io_printer_info_level_2("", il->info_2, ps, depth))
+                               return False;
                        break;          
        }
 
-
        return True;
 }
 
@@ -3299,7 +3232,7 @@ BOOL spoolss_io_r_addprinterex(char *desc, SPOOL_R_ADDPRINTEREX *r_u, prs_struct
        prs_debug(ps, depth, desc, "spoolss_io_r_addprinterex");
        depth++;
        
-       smb_io_prt_hnd("printer handle",&(r_u->handle),ps,depth);
+       smb_io_pol_hnd("printer handle",&(r_u->handle),ps,depth);
 
        prs_uint32("status", ps, depth, &(r_u->status));
 
@@ -3572,8 +3505,11 @@ BOOL uni_2_asc_printer_info_2(const SPOOL_PRINTER_INFO_LEVEL_2 *uni,
                               NT_PRINTER_INFO_LEVEL_2  **asc)
 {
        NT_PRINTER_INFO_LEVEL_2 *d;
+       NTTIME time_nt;
+       time_t time_unix;
        
        DEBUG(7,("Converting from UNICODE to ASCII\n"));
+       time_unix=time(NULL);
        
        if (*asc==NULL)
        {
@@ -3581,6 +3517,12 @@ BOOL uni_2_asc_printer_info_2(const SPOOL_PRINTER_INFO_LEVEL_2 *uni,
 
                *asc=(NT_PRINTER_INFO_LEVEL_2 *)malloc(sizeof(NT_PRINTER_INFO_LEVEL_2));
                ZERO_STRUCTP(*asc);
+               
+               /* we allocate memory iff called from 
+                * addprinter(ex) so we can do one time stuff here.
+                */
+               (*asc)->setuptime=time_unix;
+
        }       
        DEBUGADD(8,("start converting\n"));
 
@@ -3594,17 +3536,21 @@ BOOL uni_2_asc_printer_info_2(const SPOOL_PRINTER_INFO_LEVEL_2 *uni,
        d->status=uni->status;
        d->cjobs=uni->cjobs;
 
-       unistr2_to_ascii(d->servername,     &(uni->servername),     sizeof(d->servername)-1);
-       unistr2_to_ascii(d->printername,    &(uni->printername),    sizeof(d->printername)-1);
-       unistr2_to_ascii(d->sharename,      &(uni->sharename),      sizeof(d->sharename)-1);
-       unistr2_to_ascii(d->portname,       &(uni->portname),       sizeof(d->portname)-1);
-       unistr2_to_ascii(d->drivername,     &(uni->drivername),     sizeof(d->drivername)-1);
-       unistr2_to_ascii(d->comment,        &(uni->comment),        sizeof(d->comment)-1);
-       unistr2_to_ascii(d->location,       &(uni->location),       sizeof(d->location)-1);
-       unistr2_to_ascii(d->sepfile,        &(uni->sepfile),        sizeof(d->sepfile)-1);
-       unistr2_to_ascii(d->printprocessor, &(uni->printprocessor), sizeof(d->printprocessor)-1);
-       unistr2_to_ascii(d->datatype,       &(uni->datatype),       sizeof(d->datatype)-1);
-       unistr2_to_ascii(d->parameters,     &(uni->parameters),     sizeof(d->parameters)-1);
+       unix_to_nt_time(&time_nt, time_unix);
+       d->changeid=time_nt.low;
+       
+       d->c_setprinter++;
+
+       unistr2_to_ascii(d->servername, &uni->servername, sizeof(d->servername)-1);
+       unistr2_to_ascii(d->printername, &uni->printername, sizeof(d->printername)-1);
+       unistr2_to_ascii(d->sharename, &uni->sharename, sizeof(d->sharename)-1);
+       unistr2_to_ascii(d->portname, &uni->portname, sizeof(d->portname)-1);
+       unistr2_to_ascii(d->drivername, &uni->drivername, sizeof(d->drivername)-1);
+       unistr2_to_ascii(d->location, &uni->location, sizeof(d->location)-1);
+       unistr2_to_ascii(d->sepfile, &uni->sepfile, sizeof(d->sepfile)-1);
+       unistr2_to_ascii(d->printprocessor, &uni->printprocessor, sizeof(d->printprocessor)-1);
+       unistr2_to_ascii(d->datatype, &uni->datatype, sizeof(d->datatype)-1);
+       unistr2_to_ascii(d->parameters, &uni->parameters, sizeof(d->parameters)-1);
 
        return True;
 }
@@ -3708,7 +3654,6 @@ BOOL spoolss_io_r_enumprintprocessors(char *desc, SPOOL_R_ENUMPRINTPROCESSORS *r
 ********************************************************************/  
 BOOL spoolss_io_q_enumprintprocessors(char *desc, SPOOL_Q_ENUMPRINTPROCESSORS *q_u, prs_struct *ps, int depth)
 {
-       uint32 useless;
        prs_debug(ps, depth, desc, "spoolss_io_q_enumprintprocessors");
        depth++;
 
@@ -3746,6 +3691,75 @@ BOOL spoolss_io_q_enumprintprocessors(char *desc, SPOOL_Q_ENUMPRINTPROCESSORS *q
        return True;
 }
 
+/*******************************************************************
+********************************************************************/  
+BOOL spoolss_io_r_enumprintprocdatatypes(char *desc, SPOOL_R_ENUMPRINTPROCDATATYPES *r_u, prs_struct *ps, int depth)
+{              
+       prs_debug(ps, depth, desc, "spoolss_io_r_enumprintprocdatatypes");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+               
+       if (!new_spoolss_io_buffer("", ps, depth, r_u->buffer))
+               return False;
+
+       if (!prs_align(ps))
+               return False;
+               
+       if (!prs_uint32("needed", ps, depth, &r_u->needed))
+               return False;
+               
+       if (!prs_uint32("returned", ps, depth, &r_u->returned))
+               return False;
+               
+       if (!prs_uint32("status", ps, depth, &r_u->status))
+               return False;
+
+       return True;            
+}
+
+/*******************************************************************
+********************************************************************/  
+BOOL spoolss_io_q_enumprintprocdatatypes(char *desc, SPOOL_Q_ENUMPRINTPROCDATATYPES *q_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_q_enumprintprocdatatypes");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+               
+       if (!prs_uint32("name_ptr", ps, depth, &q_u->name_ptr))
+               return False;
+       if (!smb_io_unistr2("name", &q_u->name, True, ps, depth))
+               return False;
+               
+       if (!prs_align(ps))
+               return False;
+               
+       if (!prs_uint32("processor_ptr", ps, depth, &q_u->processor_ptr))
+               return False;
+       if (!smb_io_unistr2("processor", &q_u->processor, q_u->processor_ptr, ps, depth))
+               return False;
+       
+       if (!prs_align(ps))
+               return False;
+               
+       if (!prs_uint32("level", ps, depth, &q_u->level))
+               return False;
+               
+       if(!new_spoolss_io_buffer("buffer", ps, depth, q_u->buffer))
+               return False;
+
+       if (!prs_align(ps))
+               return False;
+
+       if (!prs_uint32("offered", ps, depth, &q_u->offered))
+               return False;
+
+       return True;
+}
+
 /*******************************************************************
  Parse a SPOOL_Q_ENUMPRINTMONITORS structure.
 ********************************************************************/  
@@ -3815,17 +3829,26 @@ BOOL spoolss_io_r_enumprinterdata(char *desc, SPOOL_R_ENUMPRINTERDATA *r_u, prs_
        prs_debug(ps, depth, desc, "spoolss_io_r_enumprinterdata");
        depth++;
 
-       prs_align(ps);  
-       prs_uint32("valuesize",     ps, depth, &(r_u->valuesize));
-       prs_unistr("value",         ps, depth, &(r_u->value));
-       prs_uint32("realvaluesize", ps, depth, &(r_u->realvaluesize));
+       if(!prs_align(ps))
+               return False;
+       if(!prs_uint32("valuesize", ps, depth, &r_u->valuesize))
+               return False;
+       if(!prs_uint16s(False, "value", ps, depth, r_u->value, r_u->valuesize))
+               return False;
+       if(!prs_uint32("realvaluesize", ps, depth, &r_u->realvaluesize))
+               return False;
 
-       prs_uint32("type",          ps, depth, &(r_u->type));
+       if(!prs_uint32("type", ps, depth, &r_u->type))
+               return False;
 
-       prs_uint32("datasize",      ps, depth, &(r_u->datasize));
-       prs_uint8s(False, "data",   ps, depth, r_u->data, r_u->datasize);
-       prs_uint32("realdatasize",  ps, depth, &(r_u->realdatasize));
-       prs_uint32("status",        ps, depth, &(r_u->status));
+       if(!prs_uint32("datasize", ps, depth, &r_u->datasize))
+               return False;
+       if(!prs_uint8s(False, "data", ps, depth, r_u->data, r_u->datasize))
+               return False;
+       if(!prs_uint32("realdatasize", ps, depth, &r_u->realdatasize))
+               return False;
+       if(!prs_uint32("status", ps, depth, &r_u->status))
+               return False;
 
        return True;
 }
@@ -3837,11 +3860,28 @@ BOOL spoolss_io_q_enumprinterdata(char *desc, SPOOL_Q_ENUMPRINTERDATA *q_u, prs_
        prs_debug(ps, depth, desc, "spoolss_io_q_enumprinterdata");
        depth++;
 
-       prs_align(ps);
-       smb_io_prt_hnd("printer handle",&(q_u->handle),ps,depth);
-       prs_uint32("index",     ps, depth, &(q_u->index));
-       prs_uint32("valuesize", ps, depth, &(q_u->valuesize));
-       prs_uint32("datasize",  ps, depth, &(q_u->datasize));
+       if(!prs_align(ps))
+               return False;
+       if(!smb_io_pol_hnd("printer handle",&q_u->handle,ps,depth))
+               return False;
+       if(!prs_uint32("index", ps, depth, &q_u->index))
+               return False;
+       if(!prs_uint32("valuesize", ps, depth, &q_u->valuesize))
+               return False;
+       if(!prs_uint32("datasize", ps, depth, &q_u->datasize))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+********************************************************************/  
+BOOL make_spoolss_q_enumprinterdata(SPOOL_Q_ENUMPRINTERDATA *q_u, POLICY_HND *hnd, uint32 idx, uint32 valuelen, uint32 datalen)
+{
+       memcpy(&(q_u->handle), hnd, sizeof(q_u->handle));
+       q_u->index=idx;
+       q_u->valuesize=valuelen;
+       q_u->datasize=datalen;
 
        return True;
 }
@@ -3854,7 +3894,7 @@ BOOL spoolss_io_q_setprinterdata(char *desc, SPOOL_Q_SETPRINTERDATA *q_u, prs_st
        depth++;
 
        prs_align(ps);
-       smb_io_prt_hnd("printer handle", &(q_u->handle), ps, depth);
+       smb_io_pol_hnd("printer handle", &(q_u->handle), ps, depth);
        smb_io_unistr2("", &(q_u->value), True, ps, depth);
 
        prs_align(ps);
@@ -3957,7 +3997,7 @@ BOOL spoolss_io_q_addform(char *desc, SPOOL_Q_ADDFORM *q_u, prs_struct *ps, int
        depth++;
 
        prs_align(ps);
-       smb_io_prt_hnd("printer handle", &(q_u->handle), ps, depth);
+       smb_io_pol_hnd("printer handle", &(q_u->handle), ps, depth);
        prs_uint32("level",  ps, depth, &(q_u->level));
        prs_uint32("level2", ps, depth, &(q_u->level2));
 
@@ -3992,7 +4032,7 @@ BOOL spoolss_io_q_setform(char *desc, SPOOL_Q_SETFORM *q_u, prs_struct *ps, int
        depth++;
 
        prs_align(ps);
-       smb_io_prt_hnd("printer handle", &(q_u->handle), ps, depth);
+       smb_io_pol_hnd("printer handle", &(q_u->handle), ps, depth);
        smb_io_unistr2("", &(q_u->name), True, ps, depth);
              
        prs_align(ps);
@@ -4059,7 +4099,7 @@ BOOL spoolss_io_q_getjob(char *desc, SPOOL_Q_GETJOB *q_u, prs_struct *ps, int de
        if(!prs_align(ps))
                return False;
 
-       if(!smb_io_prt_hnd("printer handle",&(q_u->handle),ps,depth))
+       if(!smb_io_pol_hnd("printer handle",&(q_u->handle),ps,depth))
                return False;
        if(!prs_uint32("jobid", ps, depth, &q_u->jobid))
                return False;