r18931: * Fix the IDL for QueryInfoKey. teh Classname in an
[tprouty/samba.git] / source / rpc_client / cli_reg.c
index 1bad3e16a466403bb0ceeb87e329b99cb00f076c..42f0606ca6f712abfe97f64104145728c29c4ca3 100644 (file)
-
 /* 
- *  Unix SMB/Netbios implementation.
- *  Version 1.9.
- *  RPC Pipe client / server routines
- *  Copyright (C) Andrew Tridgell              1992-1998,
- *  Copyright (C) Luke Kenneth Casson Leighton 1996-1998,
- *  Copyright (C) Paul Ashton                  1997-1998.
- *  
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License as published by
- *  the Free Software Foundation; either version 2 of the License, or
- *  (at your option) any later version.
- *  
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *  
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
- */
-
-
-#ifdef SYSLOG
-#undef SYSLOG
-#endif
+   Unix SMB/CIFS implementation.
+   RPC Pipe client
+   Copyright (C) Gerald (Jerry) Carter        2005-2006
+   
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2 of the License, or
+   (at your option) any later version.
+   
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+   
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, write to the Free Software
+   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+*/
 
 #include "includes.h"
+#include "rpc_client.h"
 
-extern int DEBUGLEVEL;
+/*******************************************************************
+ connect to a registry hive root (open a registry policy)
+*******************************************************************/
 
-/****************************************************************************
-do a REG Open Policy
-****************************************************************************/
-BOOL do_reg_connect(struct cli_state *cli, uint16 fnum,
-                               const char *full_keyname,
-                               char *key_name,
-                               POLICY_HND *reg_hnd)
+NTSTATUS rpccli_winreg_connect(struct rpc_pipe_client *cli, TALLOC_CTX *mem_ctx,
+                         uint32 reg_type, uint32 access_mask,
+                         POLICY_HND *reg_hnd)
 {
-       BOOL res = True;
-       uint32 reg_type = 0;
-
-       if (full_keyname == NULL)
-       {
-               return False;
-       }
-
        ZERO_STRUCTP(reg_hnd);
 
-       /*
-        * open registry receive a policy handle
-        */
-
-       if (!reg_split_key(full_keyname, &reg_type, key_name))
-       {
-               DEBUG(0,("do_reg_connect: unrecognised key name %s\n", full_keyname));  
-               return False;
-       }
-
        switch (reg_type)
        {
-               case HKEY_CLASSES_ROOT:
-               {
-                       res = res ? do_reg_open_hkcr(cli, fnum,
-                                       0x5428, 0x02000000,
-                                       reg_hnd) : False;
-                       break;
-               }
-       
-               case HKEY_LOCAL_MACHINE:
-               {
-                       res = res ? do_reg_open_hklm(cli, fnum,
-                                       0x84E0, 0x02000000,
-                                       reg_hnd) : False;
-                       break;
-               }
-       
-               case HKEY_USERS:
-               {
-                       res = res ? do_reg_open_hku(cli, fnum,
-                                       0x84E0, 0x02000000,
-                                       reg_hnd) : False;
-                       break;
-               }
-               default:
-               {
-                       DEBUG(0,("do_reg_connect: unrecognised hive key\n"));   
-                       return False;
-               }
-       }
-
-       return res;
-}
-
-/****************************************************************************
-do a REG Open Policy
-****************************************************************************/
-BOOL do_reg_open_hkcr(struct cli_state *cli, uint16 fnum, uint16 unknown_0, uint32 level,
-                               POLICY_HND *hnd)
-{
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_OPEN_HKCR q_o;
-       BOOL valid_pol = False;
-
-       if (hnd == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       /* create and send a MSRPC command with api REG_OPEN_HKCR */
-
-       DEBUG(4,("REG Open HKCR\n"));
-
-       make_reg_q_open_hkcr(&q_o, unknown_0, level);
-
-       /* turn parameters into data stream */
-       reg_io_q_open_hkcr("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_OPEN_HKCR, &buf, &rbuf))
-       {
-               REG_R_OPEN_HKCR r_o;
-               BOOL p;
-
-               ZERO_STRUCT(r_o);
-
-               reg_io_r_open_hkcr("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
-
-               if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_OPEN_HKCR: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
-
-               if (p)
-               {
-                       /* ok, at last: we're happy. return the policy handle */
-                       memcpy(hnd, r_o.pol.data, sizeof(hnd->data));
-                       valid_pol = True;
-               }
-       }
-
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
-
-       return valid_pol;
-}
-
-/****************************************************************************
-do a REG Open Policy
-****************************************************************************/
-BOOL do_reg_open_hklm(struct cli_state *cli, uint16 fnum, uint16 unknown_0, uint32 level,
-                               POLICY_HND *hnd)
-{
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_OPEN_HKLM q_o;
-       BOOL valid_pol = False;
-
-       if (hnd == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       /* create and send a MSRPC command with api REG_OPEN_HKLM */
-
-       DEBUG(4,("REG Open HKLM\n"));
-
-       make_reg_q_open_hklm(&q_o, unknown_0, level);
-
-       /* turn parameters into data stream */
-       reg_io_q_open_hklm("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_OPEN_HKLM, &buf, &rbuf))
-       {
-               REG_R_OPEN_HKLM r_o;
-               BOOL p;
-
-               ZERO_STRUCT(r_o);
-
-               reg_io_r_open_hklm("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
-
-               if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_OPEN_HKLM: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
-
-               if (p)
-               {
-                       /* ok, at last: we're happy. return the policy handle */
-                       memcpy(hnd, r_o.pol.data, sizeof(hnd->data));
-                       valid_pol = True;
-               }
-       }
-
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
-
-       return valid_pol;
-}
-
-/****************************************************************************
-do a REG Open HKU
-****************************************************************************/
-BOOL do_reg_open_hku(struct cli_state *cli, uint16 fnum, uint16 unknown_0, uint32 level,
-                               POLICY_HND *hnd)
-{
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_OPEN_HKU q_o;
-       BOOL valid_pol = False;
-
-       if (hnd == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       /* create and send a MSRPC command with api REG_OPEN_HKU */
-
-       DEBUG(4,("REG Open HKU\n"));
-
-       make_reg_q_open_hku(&q_o, unknown_0, level);
-
-       /* turn parameters into data stream */
-       reg_io_q_open_hku("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_OPEN_HKU, &buf, &rbuf))
-       {
-               REG_R_OPEN_HKU r_o;
-               BOOL p;
-
-               ZERO_STRUCT(r_o);
-
-               reg_io_r_open_hku("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
-
-               if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_OPEN_HKU: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
-
-               if (p)
-               {
-                       /* ok, at last: we're happy. return the policy handle */
-                       memcpy(hnd, r_o.pol.data, sizeof(hnd->data));
-                       valid_pol = True;
-               }
-       }
-
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
-
-       return valid_pol;
-}
-
-/****************************************************************************
-do a REG Unknown 0xB command.  sent after a create key or create value.
-this might be some sort of "sync" or "refresh" command, sent after
-modification of the registry...
-****************************************************************************/
-BOOL do_reg_flush_key(struct cli_state *cli, uint16 fnum, POLICY_HND *hnd)
-{
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_FLUSH_KEY q_o;
-       BOOL valid_query = False;
-
-       if (hnd == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       /* create and send a MSRPC command with api REG_FLUSH_KEY */
-
-       DEBUG(4,("REG Unknown 0xB\n"));
-
-       make_reg_q_flush_key(&q_o, hnd);
-
-       /* turn parameters into data stream */
-       reg_io_q_flush_key("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_FLUSH_KEY, &buf, &rbuf))
-       {
-               REG_R_FLUSH_KEY r_o;
-               BOOL p;
+       case HKEY_CLASSES_ROOT:
+               return rpccli_winreg_OpenHKCR( cli, mem_ctx, NULL, 
+                       access_mask, reg_hnd );
 
-               ZERO_STRUCT(r_o);
+       case HKEY_LOCAL_MACHINE:
+               return rpccli_winreg_OpenHKLM( cli, mem_ctx, NULL, 
+                       access_mask, reg_hnd );
 
-               reg_io_r_flush_key("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
+       case HKEY_USERS:
+               return rpccli_winreg_OpenHKU( cli, mem_ctx, NULL, 
+                       access_mask, reg_hnd );
 
-               if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_FLUSH_KEY: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
+       case HKEY_PERFORMANCE_DATA:
+               return rpccli_winreg_OpenHKPD( cli, mem_ctx, NULL, 
+                       access_mask, reg_hnd );
 
-               if (p)
-               {
-                       valid_query = True;
-               }
+       default:
+               /* fall through to end of function */
+               break;
        }
 
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
-
-       return valid_query;
+       return NT_STATUS_INVALID_PARAMETER;
 }
 
 /****************************************************************************
-do a REG Query Key
 ****************************************************************************/
-BOOL do_reg_query_key(struct cli_state *cli, uint16 fnum, POLICY_HND *hnd,
-                               char *key_class, uint32 *class_len,
-                               uint32 *num_subkeys, uint32 *max_subkeylen,
-                               uint32 *max_subkeysize, uint32 *num_values,
-                               uint32 *max_valnamelen, uint32 *max_valbufsize,
-                               uint32 *sec_desc, NTTIME *mod_time)
-{
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_QUERY_KEY q_o;
-       BOOL valid_query = False;
-
-       if (hnd == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       /* create and send a MSRPC command with api REG_QUERY_KEY */
-
-       DEBUG(4,("REG Query Key\n"));
-
-       make_reg_q_query_key(&q_o, hnd, *class_len);
-
-       /* turn parameters into data stream */
-       reg_io_q_query_key("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_QUERY_KEY, &buf, &rbuf))
-       {
-               REG_R_QUERY_KEY r_o;
-               BOOL p;
-
-               ZERO_STRUCT(r_o);
-
-               reg_io_r_query_key("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
-
-               if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_QUERY_KEY: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
-
-               if (p)
-               {
-                       valid_query = True;
-                       
-                       *class_len      = r_o.hdr_class.uni_max_len;
-                       unistr2_to_ascii(key_class, &r_o.uni_class, sizeof(fstring)-1);
-                       *num_subkeys    = r_o.num_subkeys   ;
-                       *max_subkeylen  = r_o.max_subkeylen ;
-                       *max_subkeysize = r_o.max_subkeysize;
-                       *num_values     = r_o.num_values    ;
-                       *max_valnamelen = r_o.max_valnamelen;
-                       *max_valbufsize = r_o.max_valbufsize;
-                       *sec_desc       = r_o.sec_desc      ;
-                       *mod_time       = r_o.mod_time      ;
-               }
-       }
-
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
 
-       return valid_query;
-}
-
-/****************************************************************************
-do a REG Unknown 1A
-****************************************************************************/
-BOOL do_reg_unknown_1a(struct cli_state *cli, uint16 fnum, POLICY_HND *hnd, uint32 *unk)
+NTSTATUS rpccli_winreg_query_key(struct rpc_pipe_client *cli, TALLOC_CTX *mem_ctx,
+                           POLICY_HND *hnd,
+                           char *key_class, uint32 *class_len,
+                           uint32 *num_subkeys, uint32 *max_subkeylen,
+                           uint32 *max_subkeysize, uint32 *num_values,
+                           uint32 *max_valnamelen, uint32 *max_valbufsize,
+                           uint32 *secdescsize, NTTIME *mod_time)
 {
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_UNK_1A q_o;
-       BOOL valid_query = False;
-
-       if (hnd == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       /* create and send a MSRPC command with api REG_UNKNOWN_1A */
-
-       DEBUG(4,("REG Unknown 1a\n"));
-
-       make_reg_q_unk_1a(&q_o, hnd);
-
-       /* turn parameters into data stream */
-       reg_io_q_unk_1a("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_UNK_1A, &buf, &rbuf))
-       {
-               REG_R_UNK_1A r_o;
-               BOOL p;
-
-               ZERO_STRUCT(r_o);
-
-               reg_io_r_unk_1a("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
+       NTSTATUS status;
+       struct winreg_String classname;
 
-               if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_UNK_1A: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
+       classname.name = key_class;
+       status = rpccli_winreg_QueryInfoKey( cli, mem_ctx, hnd, 
+                       &classname, num_subkeys,
+                       max_subkeylen, max_subkeysize, num_values,
+                       max_valnamelen, max_valbufsize, secdescsize,
+                       mod_time );
 
-               if (p)
-               {
-                       valid_query = True;
-                       (*unk) = r_o.unknown;
-               }
-       }
-
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
+       /* The old code would check for INSUFFICIENT_BUFFER.  
+          Will have to work this out. */
 
-       return valid_query;
+       return status;
 }
 
-/****************************************************************************
-do a REG Query Info
-****************************************************************************/
-BOOL do_reg_query_info(struct cli_state *cli, uint16 fnum, POLICY_HND *hnd,
-                               const char* val_name,
-                               uint32 *type, BUFFER2 *buffer)
-{
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_INFO q_o;
-       BOOL valid_query = False;
-
-       if (hnd == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       /* create and send a MSRPC command with api REG_INFO */
-
-       DEBUG(4,("REG Query Info\n"));
-
-       make_reg_q_info(&q_o, hnd, val_name, 4, 0);
-
-       /* turn parameters into data stream */
-       reg_io_q_info("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_INFO, &buf, &rbuf))
-       {
-               REG_R_INFO r_o;
-               BOOL p;
-
-               ZERO_STRUCT(r_o);
-
-               r_o.type = type;
-               r_o.uni_type = buffer;
-
-               reg_io_r_info("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
-
-               if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_INFO: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
-
-               if (p)
-               {
-                       valid_query = True;
-               }
-       }
-
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
-
-       return valid_query;
-}
 
 /****************************************************************************
-do a REG Set Key Security 
 ****************************************************************************/
-BOOL do_reg_set_key_sec(struct cli_state *cli, uint16 fnum, POLICY_HND *hnd,
-                               uint32 sec_info,
-                               uint32 sec_buf_size, SEC_DESC *sec_buf)
-{
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_SET_KEY_SEC q_o;
-       BOOL valid_query = False;
-
-       if (hnd == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
 
-       /* create and send a MSRPC command with api REG_SET_KEY_SEC */
-
-       DEBUG(4,("REG Set Key security.\n"));
-
-       make_reg_q_set_key_sec(&q_o, hnd, sec_info, sec_buf_size, sec_buf);
-
-       /* turn parameters into data stream */
-       reg_io_q_set_key_sec("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_SET_KEY_SEC, &buf, &rbuf))
-       {
-               REG_R_SET_KEY_SEC r_o;
-               BOOL p;
-
-               ZERO_STRUCT(r_o);
-
-               reg_io_r_set_key_sec("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
-
-               if (p && r_o.status != 0)
-               {
-                       valid_query = True;
-               }
-       }
-
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
-
-       return valid_query;
-}
-
-
-/****************************************************************************
-do a REG Query Key Security 
-****************************************************************************/
-BOOL do_reg_get_key_sec(struct cli_state *cli, uint16 fnum, POLICY_HND *hnd,
-                               uint32 sec_info,
-                               uint32 *sec_buf_size, SEC_DESC_BUF *sec_buf)
+NTSTATUS rpccli_winreg_enum_val(struct rpc_pipe_client *cli, TALLOC_CTX *mem_ctx,
+                          POLICY_HND *hnd, int idx,
+                          fstring val_name, uint32 *type, REGVAL_BUFFER *value)
 {
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_GET_KEY_SEC q_o;
-       BOOL valid_query = False;
-
-       if (hnd == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       /* create and send a MSRPC command with api REG_GET_KEY_SEC */
-
-       DEBUG(4,("REG query key security.  buf_size: %d\n", *sec_buf_size));
-
-       make_reg_q_get_key_sec(&q_o, hnd, sec_info, *sec_buf_size, sec_buf);
-
-       /* turn parameters into data stream */
-       reg_io_q_get_key_sec("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_GET_KEY_SEC, &buf, &rbuf))
-       {
-               REG_R_GET_KEY_SEC r_o;
-               BOOL p;
-
-               ZERO_STRUCT(r_o);
-
-               r_o.data = sec_buf;
-               if (*sec_buf_size != 0)
-               {
-                       sec_buf->sec = (SEC_DESC*)malloc(*sec_buf_size);
-               }
-               reg_io_r_get_key_sec("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
-
-               if (p && r_o.status == 0x0000007a)
-               {
-                       /*
-                        * get the maximum buffer size: it was too small
-                        */
-                       (*sec_buf_size) = r_o.hdr_sec.buf_max_len;
-                       DEBUG(5,("sec_buf_size too small.  use %d\n", *sec_buf_size));
-                       valid_query = True;
-               }
-               else if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_GET_KEY_SEC: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
-               else
-               {
-                       valid_query = True;
-                       (*sec_buf_size) = r_o.data->len;
-               }
-       }
-
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
-
-       return valid_query;
-}
-
-/****************************************************************************
-do a REG Delete Value
-****************************************************************************/
-BOOL do_reg_delete_val(struct cli_state *cli, uint16 fnum, POLICY_HND *hnd, char *val_name)
-{
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_DELETE_VALUE q_o;
-       BOOL valid_delete = False;
-
-       if (hnd == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       /* create and send a MSRPC command with api REG_DELETE_VALUE */
-
-       DEBUG(4,("REG Delete Value: %s\n", val_name));
-
-       make_reg_q_delete_val(&q_o, hnd, val_name);
-
-       /* turn parameters into data stream */
-       reg_io_q_delete_val("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_DELETE_VALUE, &buf, &rbuf))
-       {
-               REG_R_DELETE_VALUE r_o;
-               BOOL p;
-
-               ZERO_STRUCT(r_o);
-
-               reg_io_r_delete_val("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
-
-               if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_DELETE_VALUE: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
-
-               if (p)
-               {
-                       valid_delete = True;
-               }
-       }
-
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
-
-       return valid_delete;
-}
-
-/****************************************************************************
-do a REG Delete Key
-****************************************************************************/
-BOOL do_reg_delete_key(struct cli_state *cli, uint16 fnum, POLICY_HND *hnd, char *key_name)
-{
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_DELETE_KEY q_o;
-       BOOL valid_delete = False;
-
-       if (hnd == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       /* create and send a MSRPC command with api REG_DELETE_KEY */
-
-       DEBUG(4,("REG Delete Key: %s\n", key_name));
-
-       make_reg_q_delete_key(&q_o, hnd, key_name);
-
-       /* turn parameters into data stream */
-       reg_io_q_delete_key("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_DELETE_KEY, &buf, &rbuf))
-       {
-               REG_R_DELETE_KEY r_o;
-               BOOL p;
-
-               ZERO_STRUCT(r_o);
-
-               reg_io_r_delete_key("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
-
-               if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_DELETE_KEY: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
-
-               if (p)
-               {
-                       valid_delete = True;
-               }
-       }
-
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
-
-       return valid_delete;
+       NTSTATUS status = NT_STATUS_INVALID_PARAMETER;
+       
+       /* do rpc */
+       
+               
+       return status;
 }
 
 /****************************************************************************
-do a REG Create Key
 ****************************************************************************/
-BOOL do_reg_create_key(struct cli_state *cli, uint16 fnum, POLICY_HND *hnd,
-                               char *key_name, char *key_class,
-                               SEC_ACCESS *sam_access,
-                               POLICY_HND *key)
-{
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_CREATE_KEY q_o;
-       BOOL valid_create = False;
-       SEC_DESC sec;
-       SEC_DESC_BUF sec_buf;
-       int sec_len;
-
-       ZERO_STRUCT(sec);
-       ZERO_STRUCT(sec_buf);
-       ZERO_STRUCT(q_o);
-
-       if (hnd == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       /* create and send a MSRPC command with api REG_CREATE_KEY */
-
-       DEBUG(4,("REG Create Key: %s %s 0x%08x\n", key_name, key_class,
-               sam_access != NULL ? sam_access->mask : 0));
-
-       sec_len = make_sec_desc(&sec, 1, SEC_DESC_SELF_RELATIVE,
-                               NULL, NULL, NULL, NULL);
-
-       DEBUG(10,("make_sec_desc: len = %d\n", sec_len));
-
-       make_reg_q_create_key(&q_o, hnd, key_name, key_class, sam_access,
-                             &sec_buf, sec_len, &sec);
 
-       /* turn parameters into data stream */
-       reg_io_q_create_key("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_CREATE_KEY, &buf, &rbuf))
-       {
-               REG_R_CREATE_KEY r_o;
-               BOOL p;
-
-               ZERO_STRUCT(r_o);
-
-               reg_io_r_create_key("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
-
-               if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_CREATE_KEY: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
-
-               if (p)
-               {
-                       valid_create = True;
-                       memcpy(key, r_o.key_pol.data, sizeof(key->data));
-               }
-       }
-
-       free_sec_desc(&sec);
-
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
-
-       return valid_create;
-}
-
-/****************************************************************************
-do a REG Enum Key
-****************************************************************************/
-BOOL do_reg_enum_key(struct cli_state *cli, uint16 fnum, POLICY_HND *hnd,
-                               int key_index, char *key_name,
-                               uint32 *unk_1, uint32 *unk_2,
-                               time_t *mod_time)
+NTSTATUS rpccli_winreg_enum_key(struct rpc_pipe_client *cli, TALLOC_CTX *mem_ctx,
+                          POLICY_HND *hnd, int key_index, fstring key_name,
+                          fstring class_name, time_t *mod_time)
 {
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_ENUM_KEY q_o;
-       BOOL valid_query = False;
-
-       if (hnd == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       /* create and send a MSRPC command with api REG_ENUM_KEY */
-
-       DEBUG(4,("REG Enum Key\n"));
-
-       make_reg_q_enum_key(&q_o, hnd, key_index);
-
-       /* turn parameters into data stream */
-       reg_io_q_enum_key("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_ENUM_KEY, &buf, &rbuf))
-       {
-               REG_R_ENUM_KEY r_o;
-               BOOL p;
-
-               ZERO_STRUCT(r_o);
-
-               reg_io_r_enum_key("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
-
-               if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_ENUM_KEY: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
-
-               if (p)
-               {
-                       valid_query = True;
-                       (*unk_1) = r_o.unknown_1;
-                       (*unk_2) = r_o.unknown_2;
-                       unistr_to_ascii(key_name, r_o.key_name.str.buffer,
-                                       sizeof(fstring)-1);
-                       (*mod_time) = nt_time_to_unix(&r_o.time);
-               }
-       }
-
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
-
-       return valid_query;
+       NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
+       
+       return status;
 }
 
-/****************************************************************************
-do a REG Create Value
-****************************************************************************/
-BOOL do_reg_create_val(struct cli_state *cli, uint16 fnum, POLICY_HND *hnd,
-                               char *val_name, uint32 type, BUFFER3 *data)
-{
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_CREATE_VALUE q_o;
-       BOOL valid_create = False;
-
-       if (hnd == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       /* create and send a MSRPC command with api REG_CREATE_VALUE */
-
-       DEBUG(4,("REG Create Value: %s\n", val_name));
-
-       make_reg_q_create_val(&q_o, hnd, val_name, type, data);
-
-       /* turn parameters into data stream */
-       reg_io_q_create_val("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_CREATE_VALUE, &buf, &rbuf))
-       {
-               REG_R_CREATE_VALUE r_o;
-               BOOL p;
-
-               ZERO_STRUCT(r_o);
-
-               reg_io_r_create_val("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
-
-               if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_CREATE_VALUE: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
-
-               if (p)
-               {
-                       valid_create = True;
-               }
-       }
-
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
+/*
+ *
+ * Utility functions
+ * 
+ */
 
-       return valid_create;
-}
+/*****************************************************************
+ Splits out the start of the key (HKLM or HKU) and the rest of the key.
+*****************************************************************/  
 
-/****************************************************************************
-do a REG Enum Value
-****************************************************************************/
-BOOL do_reg_enum_val(struct cli_state *cli, uint16 fnum, POLICY_HND *hnd,
-                               int val_index, int max_valnamelen, int max_valbufsize,
-                               fstring val_name,
-                               uint32 *val_type, BUFFER2 *value)
+BOOL reg_split_hive(const char *full_keyname, uint32 *reg_type, pstring key_name)
 {
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_ENUM_VALUE q_o;
-       BOOL valid_query = False;
-
-       if (hnd == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       /* create and send a MSRPC command with api REG_ENUM_VALUE */
+       pstring tmp;
 
-       DEBUG(4,("REG Enum Value\n"));
-
-       make_reg_q_enum_val(&q_o, hnd, val_index, max_valnamelen, max_valbufsize);
-
-       /* turn parameters into data stream */
-       reg_io_q_enum_val("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_ENUM_VALUE, &buf, &rbuf))
-       {
-               REG_R_ENUM_VALUE r_o;
-               BOOL p;
-
-               ZERO_STRUCT(r_o);
-               r_o.buf_value = value;
+       if (!next_token(&full_keyname, tmp, "\\", sizeof(tmp)))
+               return False;
 
-               reg_io_r_enum_val("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
+       (*reg_type) = 0;
 
-               if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_ENUM_VALUE: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
+       DEBUG(10, ("reg_split_key: hive %s\n", tmp));
 
-               if (p)
-               {
-                       valid_query = True;
-                       (*val_type) = r_o.type;
-                       unistr2_to_ascii(val_name, &r_o.uni_name, sizeof(fstring)-1);
-               }
+       if (strequal(tmp, "HKLM") || strequal(tmp, "HKEY_LOCAL_MACHINE"))
+               (*reg_type) = HKEY_LOCAL_MACHINE;
+       else if (strequal(tmp, "HKCR") || strequal(tmp, "HKEY_CLASSES_ROOT"))
+               (*reg_type) = HKEY_CLASSES_ROOT;
+       else if (strequal(tmp, "HKU") || strequal(tmp, "HKEY_USERS"))
+               (*reg_type) = HKEY_USERS;
+       else if (strequal(tmp, "HKPD")||strequal(tmp, "HKEY_PERFORMANCE_DATA"))
+               (*reg_type) = HKEY_PERFORMANCE_DATA;
+       else {
+               DEBUG(10,("reg_split_key: unrecognised hive key %s\n", tmp));
+               return False;
        }
+       
+       if (next_token(&full_keyname, tmp, "\n\r", sizeof(tmp)))
+               pstrcpy(key_name, tmp);
+       else
+               key_name[0] = 0;
 
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
+       DEBUG(10, ("reg_split_key: name %s\n", key_name));
 
-       return valid_query;
+       return True;
 }
 
-/****************************************************************************
-do a REG Open Key
-****************************************************************************/
-BOOL do_reg_open_entry(struct cli_state *cli, uint16 fnum, POLICY_HND *hnd,
-                               char *key_name, uint32 unk_0,
-                               POLICY_HND *key_hnd)
-{
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_OPEN_ENTRY q_o;
-       BOOL valid_pol = False;
-
-       if (hnd == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       /* create and send a MSRPC command with api REG_OPEN_ENTRY */
-
-       DEBUG(4,("REG Open Entry\n"));
-
-       make_reg_q_open_entry(&q_o, hnd, key_name, unk_0);
-
-       /* turn parameters into data stream */
-       reg_io_q_open_entry("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_OPEN_ENTRY, &buf, &rbuf))
-       {
-               REG_R_OPEN_ENTRY r_o;
-               BOOL p;
-
-               ZERO_STRUCT(r_o);
-
-               reg_io_r_open_entry("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
+/*******************************************************************
+ Fill in a REGVAL_BUFFER for the data given a REGISTRY_VALUE
+ *******************************************************************/
 
-               if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_OPEN_ENTRY: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
-
-               if (p)
-               {
-                       valid_pol = True;
-                       memcpy(key_hnd, r_o.pol.data, sizeof(key_hnd->data));
-               }
-       }
-
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
-
-       return valid_pol;
-}
-
-/****************************************************************************
-do a REG Close
-****************************************************************************/
-BOOL do_reg_close(struct cli_state *cli, uint16 fnum, POLICY_HND *hnd)
+uint32 reg_init_regval_buffer( REGVAL_BUFFER *buf2, REGISTRY_VALUE *val )
 {
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_CLOSE q_c;
-       BOOL valid_close = False;
-
-       if (hnd == NULL) return False;
-
-       /* create and send a MSRPC command with api REG_CLOSE */
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       DEBUG(4,("REG Close\n"));
-
-       /* store the parameters */
-       make_reg_q_close(&q_c, hnd);
-
-       /* turn parameters into data stream */
-       reg_io_q_close("", &q_c, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_CLOSE, &buf, &rbuf))
-       {
-               REG_R_CLOSE r_c;
-               BOOL p;
-
-               ZERO_STRUCT(r_c);
-
-               reg_io_r_close("", &r_c, &rbuf, 0);
-               p = rbuf.offset != 0;
-
-               if (p && r_c.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_CLOSE: %s\n", get_nt_error_msg(r_c.status)));
-                       p = False;
-               }
-
-               if (p)
-               {
-                       /* check that the returned policy handle is all zeros */
-                       uint32 i;
-                       valid_close = True;
-
-                       for (i = 0; i < sizeof(r_c.pol.data); i++)
-                       {
-                               if (r_c.pol.data[i] != 0)
-                               {
-                                       valid_close = False;
-                                       break;
-                               }
-                       }       
-                       if (!valid_close)
-                       {
-                               DEBUG(0,("REG_CLOSE: non-zero handle returned\n"));
-                       }
-               }
-       }
-
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
+       uint32          real_size = 0;
+       
+       if ( !buf2 || !val )
+               return 0;
+               
+       real_size = regval_size(val);
+       init_regval_buffer( buf2, (unsigned char*)regval_data_p(val), real_size );
 
-       return valid_close;
+       return real_size;
 }
 
-/****************************************************************************
-do a REG Shutdown Server
-****************************************************************************/
-BOOL do_reg_shutdown(struct cli_state *cli, uint16 fnum, 
-                               char *msg, uint32 timeout, uint16 flags)
-{
-       prs_struct rbuf;
-       prs_struct buf; 
-       REG_Q_SHUTDOWN q_o;
-       BOOL valid_shutdown = False;
-
-       if (msg == NULL) return False;
-
-       prs_init(&buf , 1024, 4, SAFETY_MARGIN, False);
-       prs_init(&rbuf, 0   , 4, SAFETY_MARGIN, True );
-
-       /* create and send a MSRPC command with api REG_SHUTDOWN */
-
-       DEBUG(4,("REG Shutdown: (timeout: %d secs) %s\n", timeout, msg));
-
-       make_reg_q_shutdown(&q_o, msg, timeout, flags);
-
-       /* turn parameters into data stream */
-       reg_io_q_shutdown("", &q_o, &buf, 0);
-
-       /* send the data on \PIPE\ */
-       if (rpc_api_pipe_req(cli, fnum, REG_SHUTDOWN, &buf, &rbuf))
-       {
-               REG_R_SHUTDOWN r_o;
-               BOOL p;
-
-               ZERO_STRUCT(r_o);
-
-               reg_io_r_shutdown("", &r_o, &rbuf, 0);
-               p = rbuf.offset != 0;
-
-               if (p && r_o.status != 0)
-               {
-                       /* report error code */
-                       DEBUG(0,("REG_SHUTDOWN: %s\n", get_nt_error_msg(r_o.status)));
-                       p = False;
-               }
-
-               if (p)
-               {
-                       valid_shutdown = True;
-               }
-       }
-
-       prs_mem_free(&rbuf);
-       prs_mem_free(&buf );
-
-       return valid_shutdown;
-}