r2987: added support for signed 32 bit integers in pidl
[gd/samba-autobuild/.git] / source / librpc / ndr / ndr_basic.c
index 3bd75e7c0dd2eb38ff1a867dbf2833bf7b2e0107..61ad722cb15859b35e98b9475421b7643836afbf 100644 (file)
 
 #include "includes.h"
 
-#define NDR_PULL_NEED_BYTES(ndr, n) do { \
-       if ((n) > ndr->data_size || ndr->offset + (n) > ndr->data_size) { \
-               return NT_STATUS_BUFFER_TOO_SMALL; \
-       } \
-} while(0)
+#define NDR_BE(ndr) (((ndr)->flags & (LIBNDR_FLAG_BIGENDIAN|LIBNDR_FLAG_LITTLE_ENDIAN)) == LIBNDR_FLAG_BIGENDIAN)
+#define NDR_SVAL(ndr, ofs) (NDR_BE(ndr)?RSVAL(ndr->data,ofs):SVAL(ndr->data,ofs))
+#define NDR_IVAL(ndr, ofs) (NDR_BE(ndr)?RIVAL(ndr->data,ofs):IVAL(ndr->data,ofs))
+#define NDR_IVALS(ndr, ofs) (NDR_BE(ndr)?RIVALS(ndr->data,ofs):IVALS(ndr->data,ofs))
+#define NDR_SSVAL(ndr, ofs, v) do { if (NDR_BE(ndr))  { RSSVAL(ndr->data,ofs,v); } else SSVAL(ndr->data,ofs,v); } while (0)
+#define NDR_SIVAL(ndr, ofs, v) do { if (NDR_BE(ndr))  { RSIVAL(ndr->data,ofs,v); } else SIVAL(ndr->data,ofs,v); } while (0)
+#define NDR_SIVALS(ndr, ofs, v) do { if (NDR_BE(ndr))  { RSIVALS(ndr->data,ofs,v); } else SIVALS(ndr->data,ofs,v); } while (0)
 
-#define NDR_PULL_ALIGN(ndr, n) do { \
-       ndr->offset = (ndr->offset + (n-1)) & ~(n-1); \
-       if (ndr->offset >= ndr->data_size) { \
-               return NT_STATUS_BUFFER_TOO_SMALL; \
-       } \
-} while(0)
+
+/*
+  check for data leaks from the server by looking for non-zero pad bytes
+  these could also indicate that real structure elements have been
+  mistaken for padding in the IDL
+*/
+void ndr_check_padding(struct ndr_pull *ndr, size_t n)
+{
+       size_t ofs2 = (ndr->offset + (n-1)) & ~(n-1);
+       int i;
+       for (i=ndr->offset;i<ofs2;i++) {
+               if (ndr->data[i] != 0) {
+                       break;
+               }
+       }
+       if (i<ofs2) {
+               DEBUG(0,("WARNING: Non-zero padding to %d: ", n));
+               for (i=ndr->offset;i<ofs2;i++) {
+                       DEBUG(0,("%02x ", ndr->data[i]));
+               }
+               DEBUG(0,("\n"));
+       }
+
+}
 
 /*
   parse a uint8
 */
-NTSTATUS ndr_pull_uint8(struct ndr_pull *ndr, uint8 *v)
+NTSTATUS ndr_pull_uint8(struct ndr_pull *ndr, uint8_t *v)
 {
        NDR_PULL_NEED_BYTES(ndr, 1);
        *v = CVAL(ndr->data, ndr->offset);
@@ -50,51 +70,135 @@ NTSTATUS ndr_pull_uint8(struct ndr_pull *ndr, uint8 *v)
 /*
   parse a uint16
 */
-NTSTATUS ndr_pull_uint16(struct ndr_pull *ndr, uint16 *v)
+NTSTATUS ndr_pull_uint16(struct ndr_pull *ndr, uint16_t *v)
 {
        NDR_PULL_ALIGN(ndr, 2);
        NDR_PULL_NEED_BYTES(ndr, 2);
-       if (ndr->flags & LIBNDR_FLAG_BIGENDIAN) {
-               *v = RSVAL(ndr->data, ndr->offset);
-       } else {
-               *v = SVAL(ndr->data, ndr->offset);
-       }
+       *v = NDR_SVAL(ndr, ndr->offset);
        ndr->offset += 2;
        return NT_STATUS_OK;
 }
 
 
 /*
-  parse a uint32
+  parse a uint32_t
 */
-NTSTATUS ndr_pull_uint32(struct ndr_pull *ndr, uint32 *v)
+NTSTATUS ndr_pull_uint32(struct ndr_pull *ndr, uint32_t *v)
 {
        NDR_PULL_ALIGN(ndr, 4);
        NDR_PULL_NEED_BYTES(ndr, 4);
-       if (ndr->flags & LIBNDR_FLAG_BIGENDIAN) {
-               *v = RIVAL(ndr->data, ndr->offset);
-       } else {
-               *v = IVAL(ndr->data, ndr->offset);
-       }
+       *v = NDR_IVAL(ndr, ndr->offset);
        ndr->offset += 4;
        return NT_STATUS_OK;
 }
 
+/*
+  parse a int32_t
+*/
+NTSTATUS ndr_pull_int32(struct ndr_pull *ndr, int32_t *v)
+{
+       NDR_PULL_ALIGN(ndr, 4);
+       NDR_PULL_NEED_BYTES(ndr, 4);
+       *v = NDR_IVALS(ndr, ndr->offset);
+       ndr->offset += 4;
+       return NT_STATUS_OK;
+}
+
+/*
+  parse a pointer
+*/
+NTSTATUS ndr_pull_ptr(struct ndr_pull *ndr, uint32_t *v)
+{
+       NTSTATUS status;
+       status = ndr_pull_uint32(ndr, v);
+       if (*v != 0) {
+               ndr->ptr_count++;
+       }
+       return status;
+}
+
+/*
+  parse a uint64
+*/
+NTSTATUS ndr_pull_uint64(struct ndr_pull *ndr, uint64_t *v)
+{
+       NDR_PULL_ALIGN(ndr, 4);
+       NDR_PULL_NEED_BYTES(ndr, 8);
+       *v = NDR_IVAL(ndr, ndr->offset);
+       *v |= (uint64_t)(NDR_IVAL(ndr, ndr->offset+4)) << 32;
+       ndr->offset += 8;
+       return NT_STATUS_OK;
+}
+
+/*
+  parse a int64
+*/
+NTSTATUS ndr_pull_int64(struct ndr_pull *ndr, int64_t *v)
+{
+       return ndr_pull_uint64(ndr, (uint64_t *)v);
+}
+
+/*
+  parse a HYPER_T
+*/
+NTSTATUS ndr_pull_HYPER_T(struct ndr_pull *ndr, HYPER_T *v)
+{
+       NDR_PULL_ALIGN(ndr, 8);
+       return ndr_pull_uint64(ndr, v);
+}
+
 /*
   pull a NTSTATUS
 */
-NTSTATUS ndr_pull_status(struct ndr_pull *ndr, NTSTATUS *status)
+NTSTATUS ndr_pull_NTSTATUS(struct ndr_pull *ndr, NTSTATUS *status)
 {
-       uint32 v;
+       uint32_t v;
        NDR_CHECK(ndr_pull_uint32(ndr, &v));
        *status = NT_STATUS(v);
        return NT_STATUS_OK;
 }
 
+/*
+  push a NTSTATUS
+*/
+NTSTATUS ndr_push_NTSTATUS(struct ndr_push *ndr, NTSTATUS status)
+{
+       return ndr_push_uint32(ndr, NT_STATUS_V(status));
+}
+
+void ndr_print_NTSTATUS(struct ndr_print *ndr, const char *name, NTSTATUS *r)
+{
+       ndr->print(ndr, "%-25s: %s", name, nt_errstr(*r));
+}
+
+/*
+  pull a WERROR
+*/
+NTSTATUS ndr_pull_WERROR(struct ndr_pull *ndr, WERROR *status)
+{
+       uint32_t v;
+       NDR_CHECK(ndr_pull_uint32(ndr, &v));
+       *status = W_ERROR(v);
+       return NT_STATUS_OK;
+}
+
+/*
+  push a WERROR
+*/
+NTSTATUS ndr_push_WERROR(struct ndr_push *ndr, WERROR status)
+{
+       return ndr_push_uint32(ndr, W_ERROR_V(status));
+}
+
+void ndr_print_WERROR(struct ndr_print *ndr, const char *name, WERROR *r)
+{
+       ndr->print(ndr, "%-25s: %s", name, win_errstr(*r));
+}
+
 /*
   parse a set of bytes
 */
-NTSTATUS ndr_pull_bytes(struct ndr_pull *ndr, char *data, uint32 n)
+NTSTATUS ndr_pull_bytes(struct ndr_pull *ndr, char *data, uint32_t n)
 {
        NDR_PULL_NEED_BYTES(ndr, n);
        memcpy(data, ndr->data + ndr->offset, n);
@@ -103,31 +207,66 @@ NTSTATUS ndr_pull_bytes(struct ndr_pull *ndr, char *data, uint32 n)
 }
 
 /*
-  parse a GUID
+  pull an array of uint8
 */
-NTSTATUS ndr_pull_guid(struct ndr_pull *ndr, GUID *guid)
+NTSTATUS ndr_pull_array_uint8(struct ndr_pull *ndr, int ndr_flags, char *data, uint32_t n)
 {
-       int i;
-       NDR_PULL_NEED_BYTES(ndr, GUID_SIZE);
-       for (i=0;i<GUID_SIZE;i++) {
-               guid->info[i] = CVAL(ndr->data, ndr->offset + i);
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
        }
-       ndr->offset += i;
-       return NT_STATUS_OK;
+       return ndr_pull_bytes(ndr, data, n);
 }
 
 
-#define NDR_PUSH_NEED_BYTES(ndr, n) NDR_CHECK(ndr_push_expand(ndr, ndr->offset+(n)))
+/*
+  pull an array of uint16
+*/
+NTSTATUS ndr_pull_array_uint16(struct ndr_pull *ndr, int ndr_flags, uint16_t *data, uint32_t n)
+{
+       uint32_t i;
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+       for (i=0;i<n;i++) {
+               NDR_CHECK(ndr_pull_uint16(ndr, &data[i]));
+       }
+       return NT_STATUS_OK;
+}
 
-#define NDR_PUSH_ALIGN(ndr, n) do { \
-       uint32 _pad = (ndr->offset & (n-1)); \
-       while (_pad--) NDR_CHECK(ndr_push_uint8(ndr, 0)); \
-} while(0)
+/*
+  pull a const array of uint32_t
+*/
+NTSTATUS ndr_pull_array_uint32(struct ndr_pull *ndr, int ndr_flags, uint32_t *data, uint32_t n)
+{
+       uint32_t i;
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+       for (i=0;i<n;i++) {
+               NDR_CHECK(ndr_pull_uint32(ndr, &data[i]));
+       }
+       return NT_STATUS_OK;
+}
+
+/*
+  pull a const array of HYPER_T
+*/
+NTSTATUS ndr_pull_array_HYPER_T(struct ndr_pull *ndr, int ndr_flags, HYPER_T *data, uint32_t n)
+{
+       uint32_t i;
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+       for (i=0;i<n;i++) {
+               NDR_CHECK(ndr_pull_HYPER_T(ndr, &data[i]));
+       }
+       return NT_STATUS_OK;
+}
 
 /*
   push a uint8
 */
-NTSTATUS ndr_push_uint8(struct ndr_push *ndr, uint8 v)
+NTSTATUS ndr_push_uint8(struct ndr_push *ndr, uint8_t v)
 {
        NDR_PUSH_NEED_BYTES(ndr, 1);
        SCVAL(ndr->data, ndr->offset, v);
@@ -138,40 +277,85 @@ NTSTATUS ndr_push_uint8(struct ndr_push *ndr, uint8 v)
 /*
   push a uint16
 */
-NTSTATUS ndr_push_uint16(struct ndr_push *ndr, uint16 v)
+NTSTATUS ndr_push_uint16(struct ndr_push *ndr, uint16_t v)
 {
        NDR_PUSH_ALIGN(ndr, 2);
        NDR_PUSH_NEED_BYTES(ndr, 2);
-       SSVAL(ndr->data, ndr->offset, v);
+       NDR_SSVAL(ndr, ndr->offset, v);
        ndr->offset += 2;
        return NT_STATUS_OK;
 }
 
 /*
-  push a uint32
+  push a uint32_t
+*/
+NTSTATUS ndr_push_uint32(struct ndr_push *ndr, uint32_t v)
+{
+       NDR_PUSH_ALIGN(ndr, 4);
+       NDR_PUSH_NEED_BYTES(ndr, 4);
+       NDR_SIVAL(ndr, ndr->offset, v);
+       ndr->offset += 4;
+       return NT_STATUS_OK;
+}
+
+/*
+  push a int32_t
 */
-NTSTATUS ndr_push_uint32(struct ndr_push *ndr, uint32 v)
+NTSTATUS ndr_push_int32(struct ndr_push *ndr, int32_t v)
 {
        NDR_PUSH_ALIGN(ndr, 4);
        NDR_PUSH_NEED_BYTES(ndr, 4);
-       SIVAL(ndr->data, ndr->offset, v);
+       NDR_SIVALS(ndr, ndr->offset, v);
        ndr->offset += 4;
        return NT_STATUS_OK;
 }
 
 /*
-  align to a uint32
+  push a uint64
 */
-NTSTATUS ndr_push_align_uint32(struct ndr_push *ndr)
+NTSTATUS ndr_push_uint64(struct ndr_push *ndr, uint64_t v)
 {
        NDR_PUSH_ALIGN(ndr, 4);
+       NDR_PUSH_NEED_BYTES(ndr, 8);
+       NDR_SIVAL(ndr, ndr->offset, (v & 0xFFFFFFFF));
+       NDR_SIVAL(ndr, ndr->offset+4, (v>>32));
+       ndr->offset += 8;
+       return NT_STATUS_OK;
+}
+
+/*
+  push a int64
+*/
+NTSTATUS ndr_push_int64(struct ndr_push *ndr, int64_t v)
+{
+       return ndr_push_uint64(ndr, (uint64_t)v);
+}
+
+/*
+  push a HYPER_T
+*/
+NTSTATUS ndr_push_HYPER_T(struct ndr_push *ndr, HYPER_T v)
+{
+       NDR_PUSH_ALIGN(ndr, 8);
+       return ndr_push_uint64(ndr, v);
+}
+
+NTSTATUS ndr_push_align(struct ndr_push *ndr, size_t size)
+{
+       NDR_PUSH_ALIGN(ndr, size);
+       return NT_STATUS_OK;
+}
+
+NTSTATUS ndr_pull_align(struct ndr_pull *ndr, size_t size)
+{
+       NDR_PULL_ALIGN(ndr, size);
        return NT_STATUS_OK;
 }
 
 /*
   push some bytes
 */
-NTSTATUS ndr_push_bytes(struct ndr_push *ndr, const char *data, uint32 n)
+NTSTATUS ndr_push_bytes(struct ndr_push *ndr, const char *data, uint32_t n)
 {
        NDR_PUSH_NEED_BYTES(ndr, n);
        memcpy(ndr->data + ndr->offset, data, n);
@@ -179,6 +363,73 @@ NTSTATUS ndr_push_bytes(struct ndr_push *ndr, const char *data, uint32 n)
        return NT_STATUS_OK;
 }
 
+/*
+  push some zero bytes
+*/
+NTSTATUS ndr_push_zero(struct ndr_push *ndr, uint32_t n)
+{
+       NDR_PUSH_NEED_BYTES(ndr, n);
+       memset(ndr->data + ndr->offset, 0, n);
+       ndr->offset += n;
+       return NT_STATUS_OK;
+}
+
+/*
+  push an array of uint8
+*/
+NTSTATUS ndr_push_array_uint8(struct ndr_push *ndr, int ndr_flags, const char *data, uint32_t n)
+{
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+       return ndr_push_bytes(ndr, data, n);
+}
+
+/*
+  push an array of uint16
+*/
+NTSTATUS ndr_push_array_uint16(struct ndr_push *ndr, int ndr_flags, const uint16_t *data, uint32_t n)
+{
+       int i;
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+       for (i=0;i<n;i++) {
+               NDR_CHECK(ndr_push_uint16(ndr, data[i]));
+       }
+       return NT_STATUS_OK;
+}
+
+/*
+  push an array of uint32_t
+*/
+NTSTATUS ndr_push_array_uint32(struct ndr_push *ndr, int ndr_flags, const uint32_t *data, uint32_t n)
+{
+       int i;
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+       for (i=0;i<n;i++) {
+               NDR_CHECK(ndr_push_uint32(ndr, data[i]));
+       }
+       return NT_STATUS_OK;
+}
+
+/*
+  push an array of HYPER_T
+*/
+NTSTATUS ndr_push_array_HYPER_T(struct ndr_push *ndr, int ndr_flags, const HYPER_T *data, uint32_t n)
+{
+       int i;
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+       for (i=0;i<n;i++) {
+               NDR_CHECK(ndr_push_HYPER_T(ndr, data[i]));
+       }
+       return NT_STATUS_OK;
+}
+
 /*
   save the current position
  */
@@ -196,84 +447,686 @@ void ndr_push_restore(struct ndr_push *ndr, struct ndr_push_save *save)
 }
 
 /*
-  this is used when a packet has a 4 byte length field. We remember the start position
-  and come back to it later to fill in the size
+  push a 1 if a pointer is non-NULL, otherwise 0
+*/
+NTSTATUS ndr_push_ptr(struct ndr_push *ndr, const void *p)
+{
+       uint32_t ptr = 0;
+       if (p) {
+               /* we do this to ensure that we generate unique ref ids,
+                  which means we can handle the case where a MS programmer
+                  forgot to mark a pointer as unique */
+               ndr->ptr_count++;
+               ptr = ndr->ptr_count;
+       }
+       return ndr_push_uint32(ndr, ptr);
+}
+
+
+/*
+  pull a general string from the wire
 */
-NTSTATUS ndr_push_length4_start(struct ndr_push *ndr, struct ndr_push_save *save)
+NTSTATUS ndr_pull_string(struct ndr_pull *ndr, int ndr_flags, const char **s)
 {
-       NDR_PUSH_ALIGN(ndr, 4);
-       ndr_push_save(ndr, save);
-       return ndr_push_uint32(ndr, 0);
+       char *as=NULL;
+       uint32_t len1, ofs, len2;
+       uint16_t len3;
+       int ret;
+       int chset = CH_UTF16;
+       unsigned byte_mul = 2;
+       unsigned flags = ndr->flags;
+
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+
+       if (NDR_BE(ndr)) {
+               chset = CH_UTF16BE;
+       }
+
+       if (flags & LIBNDR_FLAG_STR_ASCII) {
+               chset = CH_DOS;
+               byte_mul = 1;
+               flags &= ~LIBNDR_FLAG_STR_ASCII;
+       }
+
+       switch (flags & LIBNDR_STRING_FLAGS) {
+       case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4:
+       case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4|LIBNDR_FLAG_STR_NOTERM:
+               NDR_CHECK(ndr_pull_uint32(ndr, &len1));
+               NDR_CHECK(ndr_pull_uint32(ndr, &ofs));
+               if (ofs != 0) {
+                       return ndr_pull_error(ndr, NDR_ERR_STRING, "non-zero array offset with string flags 0x%x\n",
+                                             ndr->flags & LIBNDR_STRING_FLAGS);
+               }
+               NDR_CHECK(ndr_pull_uint32(ndr, &len2));
+               if (len2 > len1) {
+                       return ndr_pull_error(ndr, NDR_ERR_STRING, 
+                                             "Bad string lengths len1=%u ofs=%u len2=%u\n", 
+                                             len1, ofs, len2);
+               }
+               if (len2 == 0) {
+                       *s = talloc_strdup(ndr, "");
+                       break;
+               }
+               NDR_PULL_NEED_BYTES(ndr, len2*byte_mul);
+               ret = convert_string_talloc(ndr, chset, CH_UNIX, 
+                                           ndr->data+ndr->offset, 
+                                           len2*byte_mul,
+                                           (void **)&as);
+               if (ret == -1) {
+                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               NDR_CHECK(ndr_pull_advance(ndr, len2*byte_mul));
+
+               /* this is a way of detecting if a string is sent with the wrong
+                  termination */
+               if (ndr->flags & LIBNDR_FLAG_STR_NOTERM) {
+                       if (strlen(as) < len2) {
+                               DEBUG(6,("short string '%s'\n", as));
+                       }
+               } else {
+                       if (strlen(as) == len2) {
+                               DEBUG(6,("long string '%s'\n", as));
+                       }
+               }
+               *s = as;
+               break;
+
+       case LIBNDR_FLAG_STR_SIZE4:
+       case LIBNDR_FLAG_STR_SIZE4|LIBNDR_FLAG_STR_NOTERM:
+               NDR_CHECK(ndr_pull_uint32(ndr, &len1));
+               NDR_PULL_NEED_BYTES(ndr, len1*byte_mul);
+               if (len1 == 0) {
+                       *s = talloc_strdup(ndr, "");
+                       break;
+               }
+               ret = convert_string_talloc(ndr, chset, CH_UNIX, 
+                                           ndr->data+ndr->offset, 
+                                           len1*byte_mul,
+                                           (void **)&as);
+               if (ret == -1) {
+                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               NDR_CHECK(ndr_pull_advance(ndr, len1*byte_mul));
+
+               /* this is a way of detecting if a string is sent with the wrong
+                  termination */
+               if (ndr->flags & LIBNDR_FLAG_STR_NOTERM) {
+                       if (strlen(as) < len1) {
+                               DEBUG(6,("short string '%s'\n", as));
+                       }
+               } else {
+                       if (strlen(as) == len1) {
+                               DEBUG(6,("long string '%s'\n", as));
+                       }
+               }
+               *s = as;
+               break;
+
+       case LIBNDR_FLAG_STR_LEN4:
+       case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_NOTERM:
+               NDR_CHECK(ndr_pull_uint32(ndr, &ofs));
+               if (ofs != 0) {
+                       return ndr_pull_error(ndr, NDR_ERR_STRING, "non-zero array offset with string flags 0x%x\n",
+                                             ndr->flags & LIBNDR_STRING_FLAGS);
+               }
+               NDR_CHECK(ndr_pull_uint32(ndr, &len1));
+               NDR_PULL_NEED_BYTES(ndr, len1*byte_mul);
+               if (len1 == 0) {
+                       *s = talloc_strdup(ndr, "");
+                       break;
+               }
+               ret = convert_string_talloc(ndr, chset, CH_UNIX, 
+                                           ndr->data+ndr->offset, 
+                                           len1*byte_mul,
+                                           (void **)&as);
+               if (ret == -1) {
+                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               NDR_CHECK(ndr_pull_advance(ndr, len1*byte_mul));
+
+               /* this is a way of detecting if a string is sent with the wrong
+                  termination */
+               if (ndr->flags & LIBNDR_FLAG_STR_NOTERM) {
+                       if (strlen(as) < len1) {
+                               DEBUG(6,("short string '%s'\n", as));
+                       }
+               } else {
+                       if (strlen(as) == len1) {
+                               DEBUG(6,("long string '%s'\n", as));
+                       }
+               }
+               *s = as;
+               break;
+
+
+       case LIBNDR_FLAG_STR_SIZE2:
+       case LIBNDR_FLAG_STR_SIZE2|LIBNDR_FLAG_STR_NOTERM:
+               NDR_CHECK(ndr_pull_uint16(ndr, &len3));
+               NDR_PULL_NEED_BYTES(ndr, len3*byte_mul);
+               if (len3 == 0) {
+                       *s = talloc_strdup(ndr, "");
+                       break;
+               }
+               ret = convert_string_talloc(ndr, chset, CH_UNIX, 
+                                           ndr->data+ndr->offset, 
+                                           len3*byte_mul,
+                                           (void **)&as);
+               if (ret == -1) {
+                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               NDR_CHECK(ndr_pull_advance(ndr, len3*byte_mul));
+
+               /* this is a way of detecting if a string is sent with the wrong
+                  termination */
+               if (ndr->flags & LIBNDR_FLAG_STR_NOTERM) {
+                       if (strlen(as) < len3) {
+                               DEBUG(6,("short string '%s'\n", as));
+                       }
+               } else {
+                       if (strlen(as) == len3) {
+                               DEBUG(6,("long string '%s'\n", as));
+                       }
+               }
+               *s = as;
+               break;
+
+       case LIBNDR_FLAG_STR_SIZE2|LIBNDR_FLAG_STR_NOTERM|LIBNDR_FLAG_STR_BYTESIZE:
+               NDR_CHECK(ndr_pull_uint16(ndr, &len3));
+               NDR_PULL_NEED_BYTES(ndr, len3);
+               if (len3 == 0) {
+                       *s = talloc_strdup(ndr, "");
+                       break;
+               }
+               ret = convert_string_talloc(ndr, chset, CH_UNIX, 
+                                           ndr->data+ndr->offset, 
+                                           len3,
+                                           (void **)&as);
+               if (ret == -1) {
+                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               NDR_CHECK(ndr_pull_advance(ndr, len3));
+               *s = as;
+               break;
+
+       case LIBNDR_FLAG_STR_NULLTERM:
+               if (byte_mul == 1) {
+                       len1 = strnlen(ndr->data+ndr->offset, ndr->data_size - ndr->offset);
+               } else {
+                       len1 = utf16_len_n(ndr->data+ndr->offset, ndr->data_size - ndr->offset);
+               }
+               ret = convert_string_talloc(ndr, chset, CH_UNIX, 
+                                           ndr->data+ndr->offset, 
+                                           len1,
+                                           (void **)&as);
+               if (ret == -1) {
+                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               NDR_CHECK(ndr_pull_advance(ndr, len1));
+               *s = as;
+               break;
+
+       default:
+               return ndr_pull_error(ndr, NDR_ERR_STRING, "Bad string flags 0x%x\n",
+                                     ndr->flags & LIBNDR_STRING_FLAGS);
+       }
+
+       return NT_STATUS_OK;
 }
 
-NTSTATUS ndr_push_length4_end(struct ndr_push *ndr, struct ndr_push_save *save)
+
+/*
+  push a general string onto the wire
+*/
+NTSTATUS ndr_push_string(struct ndr_push *ndr, int ndr_flags, const char *s)
 {
-       struct ndr_push_save save2;
-       ndr_push_save(ndr, &save2);
-       ndr_push_restore(ndr, save);
-       NDR_CHECK(ndr_push_uint32(ndr, save2.offset - ndr->offset));
-       ndr_push_restore(ndr, &save2);
+       ssize_t s_len, c_len;
+       int ret;
+       int chset = CH_UTF16;
+       unsigned flags = ndr->flags;
+       unsigned byte_mul = 2;
+
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+
+       if (NDR_BE(ndr)) {
+               chset = CH_UTF16BE;
+       }
+       
+       s_len = s?strlen(s):0;
+       c_len = s?strlen_m(s):0;
+
+       if (flags & LIBNDR_FLAG_STR_ASCII) {
+               chset = CH_DOS;
+               byte_mul = 1;
+               flags &= ~LIBNDR_FLAG_STR_ASCII;
+       }
+
+       switch (flags & LIBNDR_STRING_FLAGS) {
+       case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4:
+               NDR_CHECK(ndr_push_uint32(ndr, c_len+1));
+               NDR_CHECK(ndr_push_uint32(ndr, 0));
+               NDR_CHECK(ndr_push_uint32(ndr, c_len+1));
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*(c_len+1));
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len+1,
+                                    ndr->data+ndr->offset, 
+                                    byte_mul*(c_len+1));
+               if (ret == -1) {
+                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               ndr->offset += byte_mul*(c_len+1);
+               break;
+
+       case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4|LIBNDR_FLAG_STR_NOTERM:
+               NDR_CHECK(ndr_push_uint32(ndr, c_len));
+               NDR_CHECK(ndr_push_uint32(ndr, 0));
+               NDR_CHECK(ndr_push_uint32(ndr, c_len));
+               NDR_PUSH_NEED_BYTES(ndr, c_len*byte_mul);
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len,
+                                    ndr->data+ndr->offset, c_len*byte_mul);
+               if (ret == -1) {
+                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               ndr->offset += c_len*byte_mul;
+               break;
+
+       case LIBNDR_FLAG_STR_LEN4:
+               NDR_CHECK(ndr_push_uint32(ndr, 0));
+               NDR_CHECK(ndr_push_uint32(ndr, c_len + 1));
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*(c_len+1));
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len + 1,
+                                    ndr->data+ndr->offset, byte_mul*(c_len+1));
+               if (ret == -1) {
+                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               ndr->offset += byte_mul*(c_len+1);
+               break;
+
+       case LIBNDR_FLAG_STR_SIZE4:
+               NDR_CHECK(ndr_push_uint32(ndr, c_len + 1));
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*(c_len+1));
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len + 1,
+                                    ndr->data+ndr->offset, byte_mul*(c_len+1));
+               if (ret == -1) {
+                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               ndr->offset += byte_mul*(c_len+1);
+               break;
+
+       case LIBNDR_FLAG_STR_SIZE2:
+               NDR_CHECK(ndr_push_uint16(ndr, c_len + 1));
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*(c_len+1));
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len + 1,
+                                    ndr->data+ndr->offset, byte_mul*(c_len+1));
+               if (ret == -1) {
+                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               ndr->offset += byte_mul*(c_len+1);
+               break;
+
+       case LIBNDR_FLAG_STR_NULLTERM:
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*(c_len+1));
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len+1,
+                                    ndr->data+ndr->offset, byte_mul*(c_len+1));
+               if (ret == -1) {
+                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               ndr->offset += byte_mul*(c_len+1);
+               break;
+
+       case LIBNDR_FLAG_STR_SIZE2|LIBNDR_FLAG_STR_NOTERM|LIBNDR_FLAG_STR_BYTESIZE:
+               NDR_CHECK(ndr_push_uint16(ndr, c_len*byte_mul));
+               NDR_PUSH_NEED_BYTES(ndr, c_len*byte_mul);
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len,
+                                    ndr->data+ndr->offset, c_len*byte_mul);
+               if (ret == -1) {
+                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               ndr->offset += c_len*byte_mul;
+               break;
+
+       default:
+               return ndr_push_error(ndr, NDR_ERR_STRING, "Bad string flags 0x%x\n",
+                                     ndr->flags & LIBNDR_STRING_FLAGS);
+       }
+
        return NT_STATUS_OK;
 }
 
 /*
-  push a 1 if a pointer is non-NULL, otherwise 0
+  push a NTTIME
 */
-NTSTATUS ndr_push_ptr(struct ndr_push *ndr, const void *p)
+NTSTATUS ndr_push_NTTIME(struct ndr_push *ndr, NTTIME t)
 {
-       return ndr_push_uint32(ndr, p?1:0);
+       NDR_CHECK(ndr_push_uint64(ndr, t));
+       return NT_STATUS_OK;
 }
 
 /*
-  push a comformant, variable ucs2 string onto the wire from a C string
+  pull a NTTIME
 */
-NTSTATUS ndr_push_unistr(struct ndr_push *ndr, const char *s)
+NTSTATUS ndr_pull_NTTIME(struct ndr_pull *ndr, NTTIME *t)
 {
-       char *ws;
-       ssize_t len;
-       len = push_ucs2_talloc(ndr->mem_ctx, (smb_ucs2_t **)&ws, s);
-       if (len == -1) {
-               return NT_STATUS_INVALID_PARAMETER;
-       }
-       NDR_CHECK(ndr_push_uint32(ndr, len/2));
-       NDR_CHECK(ndr_push_uint32(ndr, 0));
-       NDR_CHECK(ndr_push_uint32(ndr, len/2));
-       NDR_CHECK(ndr_push_bytes(ndr, ws, len));
+       NDR_CHECK(ndr_pull_uint64(ndr, t));
        return NT_STATUS_OK;
 }
 
 /*
-  push a 4 byte offset pointer, remembering where we are so we can later fill
-  in the correct value
+  push a time_t
 */
-NTSTATUS ndr_push_offset(struct ndr_push *ndr, struct ndr_push_save *ofs)
+NTSTATUS ndr_push_time_t(struct ndr_push *ndr, time_t t)
 {
-       NDR_PUSH_ALIGN(ndr, 4);
-       ndr_push_save(ndr, ofs);
-       return ndr_push_uint32(ndr, 0);
+       return ndr_push_uint32(ndr, t);
 }
 
 /*
-  fill in the correct offset in a saved offset pointer
-  the offset is taken relative to 'save'
+  pull a time_t
 */
-NTSTATUS ndr_push_offset_ptr(struct ndr_push *ndr, 
-                            struct ndr_push_save *ofs, 
-                            struct ndr_push_save *save)
+NTSTATUS ndr_pull_time_t(struct ndr_pull *ndr, time_t *t)
 {
-       struct ndr_push_save save2;
-       ndr_push_save(ndr, &save2);
-       ndr_push_restore(ndr, ofs);
-       NDR_CHECK(ndr_push_uint32(ndr, save2.offset - save->offset));
-       ndr_push_restore(ndr, &save2);
+       uint32_t tt;
+       NDR_CHECK(ndr_pull_uint32(ndr, &tt));
+       *t = tt;
        return NT_STATUS_OK;
 }
 
 
+void ndr_print_struct(struct ndr_print *ndr, const char *name, const char *type)
+{
+       ndr->print(ndr, "%s: struct %s", name, type);
+}
+
+void ndr_print_uint8(struct ndr_print *ndr, const char *name, uint8_t v)
+{
+       ndr->print(ndr, "%-25s: 0x%02x (%u)", name, v, v);
+}
+
+void ndr_print_uint16(struct ndr_print *ndr, const char *name, uint16_t v)
+{
+       ndr->print(ndr, "%-25s: 0x%04x (%u)", name, v, v);
+}
+
+void ndr_print_uint32(struct ndr_print *ndr, const char *name, uint32_t v)
+{
+       ndr->print(ndr, "%-25s: 0x%08x (%u)", name, v, v);
+}
+
+void ndr_print_int32(struct ndr_print *ndr, const char *name, int32_t v)
+{
+       ndr->print(ndr, "%-25s: %d", name, v);
+}
+
+void ndr_print_uint64(struct ndr_print *ndr, const char *name, uint64_t v)
+{
+       ndr->print(ndr, "%-25s: 0x%08x%08x", name, (uint32_t)(v >> 32), (uint32_t)(v & 0xFFFFFFFF));
+}
+
+void ndr_print_int64(struct ndr_print *ndr, const char *name, int64_t v)
+{
+       ndr->print(ndr, "%-25s: 0x%08x%08x (%lld)", name, 
+                  (uint32_t)(v >> 32), 
+                  (uint32_t)(v & 0xFFFFFFFF),
+                  v);
+}
+
+void ndr_print_HYPER_T(struct ndr_print *ndr, const char *name, HYPER_T v)
+{
+       ndr->print(ndr, "%-25s: 0x%08x%08x", name, (uint32_t)(v >> 32), (uint32_t)(v & 0xFFFFFFFF));
+}
+
+void ndr_print_ptr(struct ndr_print *ndr, const char *name, const void *p)
+{
+       if (p) {
+               ndr->print(ndr, "%-25s: *", name);
+       } else {
+               ndr->print(ndr, "%-25s: NULL", name);
+       }
+}
+
+void ndr_print_string(struct ndr_print *ndr, const char *name, const char *s)
+{
+       if (s) {
+               ndr->print(ndr, "%-25s: '%s'", name, s);
+       } else {
+               ndr->print(ndr, "%-25s: NULL", name);
+       }
+}
+
+void ndr_print_NTTIME(struct ndr_print *ndr, const char *name, NTTIME t)
+{
+       ndr->print(ndr, "%-25s: %s", name, nt_time_string(ndr, t));
+}
+
+void ndr_print_time_t(struct ndr_print *ndr, const char *name, time_t t)
+{
+       if (t == (time_t)-1 || t == 0) {
+               ndr->print(ndr, "%-25s: (time_t)%d", name, (int)t);
+       } else {
+               ndr->print(ndr, "%-25s: %s", name, timestring(ndr, t));
+       }
+}
+
+void ndr_print_union(struct ndr_print *ndr, const char *name, uint16_t level, const char *type)
+{
+       ndr->print(ndr, "%-25s: union %s(case %u)", name, type, level);
+}
+
+void ndr_print_bad_level(struct ndr_print *ndr, const char *name, uint16_t level)
+{
+       ndr->print(ndr, "UNKNOWN LEVEL %u", level);
+}
+
+void ndr_print_array_HYPER_T(struct ndr_print *ndr, const char *name, 
+                           const HYPER_T *data, uint32_t count)
+{
+       int i;
+
+       ndr->print(ndr, "%s: ARRAY(%d)", name, count);
+       ndr->depth++;
+       for (i=0;i<count;i++) {
+               char *idx=NULL;
+               asprintf(&idx, "[%d]", i);
+               if (idx) {
+                       ndr_print_HYPER_T(ndr, idx, data[i]);
+                       free(idx);
+               }
+       }
+       ndr->depth--;   
+}
+
+void ndr_print_array_uint32(struct ndr_print *ndr, const char *name, 
+                           const uint32_t *data, uint32_t count)
+{
+       int i;
+
+       ndr->print(ndr, "%s: ARRAY(%d)", name, count);
+       ndr->depth++;
+       for (i=0;i<count;i++) {
+               char *idx=NULL;
+               asprintf(&idx, "[%d]", i);
+               if (idx) {
+                       ndr_print_uint32(ndr, idx, data[i]);
+                       free(idx);
+               }
+       }
+       ndr->depth--;   
+}
+
+void ndr_print_array_uint16(struct ndr_print *ndr, const char *name, 
+                           const uint16_t *data, uint32_t count)
+{
+       int i;
+
+       ndr->print(ndr, "%s: ARRAY(%d)", name, count);
+       ndr->depth++;
+       for (i=0;i<count;i++) {
+               char *idx=NULL;
+               asprintf(&idx, "[%d]", i);
+               if (idx) {
+                       ndr_print_uint16(ndr, idx, data[i]);
+                       free(idx);
+               }
+       }
+       ndr->depth--;   
+}
+
+void ndr_print_array_uint8(struct ndr_print *ndr, const char *name, 
+                          const uint8_t *data, uint32_t count)
+{
+       int i;
+
+       if (count <= 600 && (ndr->flags & LIBNDR_PRINT_ARRAY_HEX)) {
+               char s[1202];
+               for (i=0;i<count;i++) {
+                       snprintf(&s[i*2], 3, "%02x", data[i]);
+               }
+               s[i*2] = 0;
+               ndr->print(ndr, "%-25s: %s", name, s);
+               return;
+       }
+
+       ndr->print(ndr, "%s: ARRAY(%d)", name, count);
+       ndr->depth++;
+       for (i=0;i<count;i++) {
+               char *idx=NULL;
+               asprintf(&idx, "[%d]", i);
+               if (idx) {
+                       ndr_print_uint8(ndr, idx, data[i]);
+                       free(idx);
+               }
+       }
+       ndr->depth--;   
+}
+
+/*
+  build a GUID from a string
+*/
+NTSTATUS GUID_from_string(const char *s, struct GUID *guid)
+{
+        uint32_t time_low;
+        uint32_t time_mid, time_hi_and_version;
+        uint32_t clock_seq[2];
+        uint32_t node[6];
+        int i;
+
+        if (11 != sscanf(s, "%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x",
+                         &time_low, &time_mid, &time_hi_and_version, 
+                         &clock_seq[0], &clock_seq[1],
+                         &node[0], &node[1], &node[2], &node[3], &node[4], &node[5])) {
+                return NT_STATUS_INVALID_PARAMETER;
+        }
+
+       guid->time_low = time_low;
+       guid->time_mid = time_mid;
+       guid->time_hi_and_version = time_hi_and_version;
+       guid->clock_seq[0] = clock_seq[0];
+       guid->clock_seq[1] = clock_seq[1];
+        for (i=0;i<6;i++) {
+               guid->node[i] = node[i];
+       }
+
+        return NT_STATUS_OK;
+}
+
+/*
+  its useful to be able to display these in debugging messages
+*/
+const char *GUID_string(TALLOC_CTX *mem_ctx, const struct GUID *guid)
+{
+       return talloc_asprintf(mem_ctx, 
+                              "%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x",
+                              guid->time_low, guid->time_mid,
+                              guid->time_hi_and_version,
+                              guid->clock_seq[0],
+                              guid->clock_seq[1],
+                              guid->node[0], guid->node[1],
+                              guid->node[2], guid->node[3],
+                              guid->node[4], guid->node[5]);
+}
+
+void ndr_print_GUID(struct ndr_print *ndr, const char *name, const struct GUID *guid)
+{
+       ndr->print(ndr, "%-25s: %s", name, GUID_string(ndr, guid));
+}
+
+void ndr_print_DATA_BLOB(struct ndr_print *ndr, const char *name, DATA_BLOB r)
+{
+       ndr->print(ndr, "%-25s: DATA_BLOB length=%u", name, r.length);
+       if (r.length) {
+               dump_data(10, r.data, r.length);
+       }
+}
+
+
+/*
+  push a DATA_BLOB onto the wire. 
+*/
+NTSTATUS ndr_push_DATA_BLOB(struct ndr_push *ndr, DATA_BLOB blob)
+{
+       if (ndr->flags & LIBNDR_ALIGN_FLAGS) {
+               if (ndr->flags & LIBNDR_FLAG_ALIGN2) {
+                       blob.length = NDR_ALIGN(ndr, 2);
+               } else if (ndr->flags & LIBNDR_FLAG_ALIGN4) {
+                       blob.length = NDR_ALIGN(ndr, 4);
+               } else if (ndr->flags & LIBNDR_FLAG_ALIGN8) {
+                       blob.length = NDR_ALIGN(ndr, 8);
+               }
+               NDR_PUSH_ALLOC_SIZE(ndr, blob.data, blob.length);
+               data_blob_clear(&blob);
+       } else if (!(ndr->flags & LIBNDR_FLAG_REMAINING)) {
+               NDR_CHECK(ndr_push_uint32(ndr, blob.length));
+       }
+       NDR_CHECK(ndr_push_bytes(ndr, blob.data, blob.length));
+       return NT_STATUS_OK;
+}
+
 /*
-  push a GUID
+  pull a DATA_BLOB from the wire. 
 */
-NTSTATUS ndr_push_guid(struct ndr_push *ndr, GUID *guid)
+NTSTATUS ndr_pull_DATA_BLOB(struct ndr_pull *ndr, DATA_BLOB *blob)
 {
-       return ndr_push_bytes(ndr, guid->info, GUID_SIZE);
+       uint32_t length;
+
+       if (ndr->flags & LIBNDR_ALIGN_FLAGS) {
+               if (ndr->flags & LIBNDR_FLAG_ALIGN2) {
+                       length = NDR_ALIGN(ndr, 2);
+               } else if (ndr->flags & LIBNDR_FLAG_ALIGN4) {
+                       length = NDR_ALIGN(ndr, 4);
+               } else if (ndr->flags & LIBNDR_FLAG_ALIGN8) {
+                       length = NDR_ALIGN(ndr, 8);
+               }
+               if (ndr->data_size - ndr->offset < length) {
+                       length = ndr->data_size - ndr->offset;
+               }
+       } else if (ndr->flags & LIBNDR_FLAG_REMAINING) {
+               length = ndr->data_size - ndr->offset;
+       } else {
+               NDR_CHECK(ndr_pull_uint32(ndr, &length));
+       }
+       NDR_PULL_NEED_BYTES(ndr, length);
+       *blob = data_blob_talloc(ndr, ndr->data+ndr->offset, length);
+       ndr->offset += length;
+       return NT_STATUS_OK;
 }