bugfix to a bug reported by Ian Schorr:
[obnox/wireshark/wip.git] / packet-q931.c
index 96b230a1add925ec47f36c76ac07766ef6dec0af..3e09da7165ff0069ef76fc4c2ff5f935d5428ee2 100644 (file)
@@ -2,7 +2,7 @@
  * Routines for Q.931 frame disassembly
  * Guy Harris <guy@alum.mit.edu>
  *
- * $Id: packet-q931.c,v 1.47 2002/09/17 19:50:12 guy Exp $
+ * $Id: packet-q931.c,v 1.76 2004/04/17 04:43:58 guy Exp $
  *
  * Modified by Andreas Sikkema for possible use with H.323
  *
 #include <epan/strutil.h>
 #include "nlpid.h"
 #include "packet-q931.h"
+#include "packet-e164.h"
 #include "prefs.h"
+#include "reassemble.h"
 
+#include "lapd_sapi.h"
 #include "packet-tpkt.h"
 
 /* Q.931 references:
  * http://www.tulatelecom.ru/staff/german/DSSHelp/MessList/InfEl/InfElList.html
  */
 
-static int proto_q931 = -1;
-static int hf_q931_discriminator = -1;
-static int hf_q931_call_ref_len = -1;
-static int hf_q931_call_ref = -1;
-static int hf_q931_message_type = -1;
+static int proto_q931                                  = -1;
+static int hf_q931_discriminator                       = -1;
+static int hf_q931_coding_standard                     = -1;
+static int hf_q931_information_transfer_capability     = -1;
+static int hf_q931_transfer_mode                       = -1;
+static int hf_q931_information_transfer_rate           = -1;
+static int hf_q931_uil1                                        = -1;
+static int hf_q931_call_ref_len                        = -1;
+static int hf_q931_call_ref_flag                       = -1;
+static int hf_q931_call_ref                            = -1;
+static int hf_q931_message_type                        = -1;
+static int hf_q931_segment_type                        = -1;
+static int hf_q931_cause_location                      = -1;
+static int hf_q931_cause_value                                 = -1;
+static int hf_q931_number_type                         = -1;
+static int hf_q931_numbering_plan                      = -1;
+static int hf_q931_extension_ind                       = -1;
+static int hf_q931_calling_party_number                = -1;
+static int hf_q931_called_party_number                         = -1;
+static int hf_q931_connected_number                    = -1;
+static int hf_q931_redirecting_number                  = -1;
+static int hf_q931_screening_ind                               = -1;
+static int hf_q931_presentation_ind                            = -1;
+
+static int hf_q931_segments = -1;
+static int hf_q931_segment = -1;
+static int hf_q931_segment_overlap = -1;
+static int hf_q931_segment_overlap_conflict = -1;
+static int hf_q931_segment_multiple_tails = -1;
+static int hf_q931_segment_too_long_segment = -1;
+static int hf_q931_segment_error = -1;
+static int hf_q931_reassembled_in = -1; 
+
+static gint ett_q931                                   = -1;
+static gint ett_q931_ie                                = -1;
+
+static gint ett_q931_segments = -1;
+static gint ett_q931_segment = -1;
+
+static const fragment_items q931_frag_items = {
+       &ett_q931_segment,
+       &ett_q931_segments,
+
+       &hf_q931_segments,
+       &hf_q931_segment,
+       &hf_q931_segment_overlap,
+       &hf_q931_segment_overlap_conflict,
+       &hf_q931_segment_multiple_tails,
+       &hf_q931_segment_too_long_segment,
+       &hf_q931_segment_error,
+       &hf_q931_reassembled_in,
+       "segments"
+};
+
+/* Tables for reassembly of fragments. */
+static GHashTable *q931_fragment_table = NULL;
+static GHashTable *q931_reassembled_table = NULL;
+
+/* Preferences */
+static gboolean q931_reassembly = TRUE;
 
-static gint ett_q931 = -1;
-static gint ett_q931_ie = -1;
+static dissector_table_t codeset_dissector_table;
+static dissector_table_t ie_dissector_table;
 
 /* desegmentation of Q.931 over TPKT over TCP */
 static gboolean q931_desegment = TRUE;
@@ -67,6 +125,10 @@ static gboolean q931_desegment = TRUE;
 static dissector_handle_t h225_handle;
 static dissector_handle_t q931_tpkt_pdu_handle;
 
+static void
+dissect_q931_IEs(tvbuff_t *tvb, packet_info *pinfo, proto_tree *root_tree,
+    proto_tree *q931_tree, gboolean is_tpkt, int offset, int initial_codeset);
+
 /*
  * Q.931 message types.
  */
@@ -143,10 +205,26 @@ static const value_string q931_message_type_vals[] = {
        { 0,                            NULL }
 };
 
+static const true_false_string tfs_call_ref_flag = {
+       "Message sent to originating side",
+       "Message sent from originating side"
+};
+
 /*
  * Information elements.
  */
 
+/* Shifted codeset values */
+#define CS0 0x000
+#define CS1 0x100
+#define CS2 0x200
+#define CS3 0x300
+#define CS4 0x400
+#define CS5 0x500
+#define CS6 0x600
+#define CS7 0x700
+
+#define        Q931_IE_SO_MASK 0x80    /* single-octet/variable-length mask */
 /*
  * Single-octet IEs.
  */
@@ -155,8 +233,8 @@ static const value_string q931_message_type_vals[] = {
 #define        Q931_IE_SO_IE_MASK              0x0F    /* IE mask */
 
 #define        Q931_IE_SHIFT                   0x90
-#define        Q931_IE_SHIFT_LOCKING           0x08    /* locking shift */
-#define        Q931_IE_SHIFT_CODESET           0x0F    /* codeset */
+#define        Q931_IE_SHIFT_NON_LOCKING       0x08    /* non-locking shift */
+#define        Q931_IE_SHIFT_CODESET           0x07    /* codeset */
 
 #define        Q931_IE_MORE_DATA_OR_SEND_COMP  0xA0    /* More Data or Sending Complete */
 #define        Q931_IE_MORE_DATA               0xA0
@@ -169,6 +247,15 @@ static const value_string q931_message_type_vals[] = {
  * Variable-length IEs.
  */
 #define        Q931_IE_VL_EXTENSION            0x80    /* Extension flag */
+/*     extension bit. The bit value "0" indicates that the octet continues through the         */
+/*     next octet. The bit value "1" indicates that this octet is the last octet               */
+
+static const true_false_string q931_extension_ind_value = {
+  "last octet",
+  "information continues through the next octet",
+
+};
+
 
 /*
  * Codeset 0 (default).
@@ -249,7 +336,8 @@ static const value_string q931_message_type_vals[] = {
 /* 0x76 is Redirection Number, but that's also Codeset 0 */
 #define        Q931_IE_CALL_APPEARANCE         0x7B
 
-static const value_string q931_info_element_vals[] = {
+/* Codeset 0 */
+static const value_string q931_info_element_vals0[] = {
        { Q931_IE_SEGMENTED_MESSAGE,            "Segmented message" },
        { Q931_IE_BEARER_CAPABILITY,            "Bearer capability" },
        { Q931_IE_CAUSE,                        "Cause" },
@@ -293,13 +381,54 @@ static const value_string q931_info_element_vals[] = {
        { Q931_IE_ESCAPE,                       "Escape" },
        { Q931_IE_CONNECTED_NUMBER,             "Connected number" },
        { Q931_IE_CONNECTED_SUBADDR,            "Connected subaddress" },
+       { 0,                                    NULL }
+};
+/* Codeset 1 */
+static const value_string q931_info_element_vals1[] = {
+       { 0,                                    NULL }
+};
+/* Codeset 2 */
+static const value_string q931_info_element_vals2[] = {
+       { 0,                                    NULL }
+};
+/* Codeset 3 */
+static const value_string q931_info_element_vals3[] = {
+       { 0,                                    NULL }
+};
+/* Codeset 4 */
+static const value_string q931_info_element_vals4[] = {
+       { 0,                                    NULL }
+};
+/* Codeset 5 */
+static const value_string q931_info_element_vals5[] = {
        { Q931_IE_CHARGING_ADVICE,              "Charging advice" },
        { Q931_IE_OPERATOR_SYSTEM_ACCESS,       "Operator system access" },
+       { 0,                                    NULL }
+};
+/* Codeset 6 */
+static const value_string q931_info_element_vals6[] = {
        { Q931_IE_REDIRECTING_NUMBER,           "Redirecting number" },
        { Q931_IE_REDIRECTING_SUBADDR,          "Redirecting subaddress" },
        { Q931_IE_CALL_APPEARANCE,              "Call appearance" },
        { 0,                                    NULL }
 };
+/* Codeset 7 */
+static const value_string q931_info_element_vals7[] = {
+       { 0,                                    NULL }
+};
+
+/* Codeset array */
+#define NUM_INFO_ELEMENT_VALS  (Q931_IE_SHIFT_CODESET+1)
+static const value_string *q931_info_element_vals[NUM_INFO_ELEMENT_VALS] = {
+  q931_info_element_vals0,
+  q931_info_element_vals1,
+  q931_info_element_vals2,
+  q931_info_element_vals3,
+  q931_info_element_vals4,
+  q931_info_element_vals5,
+  q931_info_element_vals6,
+  q931_info_element_vals7,
+};
 
 static const value_string q931_congestion_level_vals[] = {
        { 0x0, "Receiver ready" },
@@ -326,7 +455,7 @@ dissect_q931_segmented_message_ie(tvbuff_t *tvb, int offset, int len,
 {
        if (len != 2) {
                proto_tree_add_text(tree, tvb, offset, len,
-                   "Segmented message: length is %d, should be 2\n", len);
+                   "Segmented message: length is %d, should be 2", len);
                return;
        }
        if (tvb_get_guint8(tvb, offset) & 0x80) {
@@ -338,18 +467,17 @@ dissect_q931_segmented_message_ie(tvbuff_t *tvb, int offset, int len,
                    "Not first segment: %u segments remaining",
                    tvb_get_guint8(tvb, offset) & 0x7F);
        }
-       proto_tree_add_text(tree, tvb, offset + 1, 1,
-           "Segmented message type: %u\n", tvb_get_guint8(tvb, offset + 1));
+       proto_tree_add_item(tree, hf_q931_segment_type, tvb, offset + 1, 1, FALSE);
 }
 
 /*
  * Dissect a Bearer capability or Low-layer compatibility information element.
  */
-static const value_string q931_bc_coding_standard_vals[] = {
-       { 0x00, "ITU-T standardized coding" },
-       { 0x20, "ISO/IEC standard" },
-       { 0x40, "National standard" },
-       { 0x60, "Standard defined for this particular network" },
+static const value_string q931_coding_standard_vals[] = {
+       { 0x0, "ITU-T standardized coding" },
+       { 0x1, "ISO/IEC standard" },
+       { 0x2, "National standard" },
+       { 0x3, "Standard defined for this particular network" },
        { 0,    NULL }
 };
 
@@ -365,7 +493,7 @@ static const value_string q931_information_transfer_capability_vals[] = {
 
 static const value_string q931_transfer_mode_vals[] = {
        { 0x00, "Circuit mode" },
-       { 0x40, "Packet mode" },
+       { 0x02, "Packet mode" },
        { 0,    NULL }
 };
 
@@ -565,9 +693,6 @@ dissect_q931_bearer_capability_ie(tvbuff_t *tvb, int offset, int len,
                return;
        octet = tvb_get_guint8(tvb, offset);
        coding_standard = octet & 0x60;
-       proto_tree_add_text(tree, tvb, offset, 1,
-           "Coding standard: %s",
-           val_to_str(coding_standard, q931_bc_coding_standard_vals, NULL));
        if (coding_standard != Q931_ITU_STANDARDIZED_CODING) {
                /*
                 * We don't know how the bearer capability is encoded,
@@ -576,12 +701,13 @@ dissect_q931_bearer_capability_ie(tvbuff_t *tvb, int offset, int len,
                proto_tree_add_text(tree, tvb, offset,
                    len, "Data: %s",
                    tvb_bytes_to_str(tvb, offset, len));
+               proto_tree_add_uint(tree, hf_q931_coding_standard, tvb, offset, 1, octet);
+               proto_tree_add_boolean(tree, hf_q931_extension_ind, tvb, offset, 1, octet);
                return;
        }
-       proto_tree_add_text(tree, tvb, offset, 1,
-           "Information transfer capability: %s",
-           val_to_str(octet & 0x1F, q931_information_transfer_capability_vals,
-             "Unknown (0x%02X)"));
+       proto_tree_add_uint(tree, hf_q931_information_transfer_capability, tvb, offset, 1, octet);
+       proto_tree_add_uint(tree, hf_q931_coding_standard, tvb, offset, 1, octet);
+       proto_tree_add_boolean(tree, hf_q931_extension_ind, tvb, offset, 1, octet);
        offset += 1;
        len -= 1;
 
@@ -602,15 +728,10 @@ dissect_q931_bearer_capability_ie(tvbuff_t *tvb, int offset, int len,
        if (len == 0)
                return;
        octet = tvb_get_guint8(tvb, offset);
-       proto_tree_add_text(tree, tvb, offset, 1,
-           "Transfer mode: %s",
-           val_to_str(octet & 0x60, q931_transfer_mode_vals,
-             "Unknown (0x%02X)"));
+       proto_tree_add_uint(tree, hf_q931_information_transfer_rate, tvb, offset, 1, octet);
+       proto_tree_add_uint(tree, hf_q931_transfer_mode, tvb, offset, 1, octet);
+       proto_tree_add_boolean(tree, hf_q931_extension_ind, tvb, offset, 1, octet);
        it_rate = octet & 0x1F;
-       proto_tree_add_text(tree, tvb, offset, 1,
-           "Information transfer rate: %s",
-           val_to_str(it_rate, q931_information_transfer_rate_vals,
-             "Unknown (0x%02X)"));
        offset += 1;
        len -= 1;
 
@@ -629,10 +750,8 @@ dissect_q931_bearer_capability_ie(tvbuff_t *tvb, int offset, int len,
                /*
                 * Layer 1 information.
                 */
-               proto_tree_add_text(tree, tvb, offset, 1,
-                   "User information layer 1 protocol: %s",
-                   val_to_str(octet & 0x1F, q931_uil1_vals,
-                     "Unknown (0x%02X)"));
+               proto_tree_add_uint(tree, hf_q931_uil1, tvb, offset, 1, octet);
+               proto_tree_add_boolean(tree, hf_q931_extension_ind, tvb, offset, 1, octet);
                offset += 1;
                len -= 1;
 
@@ -719,7 +838,7 @@ dissect_q931_bearer_capability_ie(tvbuff_t *tvb, int offset, int len,
                       "Unknown (0x%X)"));
                proto_tree_add_text(tree, tvb, offset, 1,
                    "Parity: %s",
-                     val_to_str(octet & 0x08, q931_l1_parity_vals,
+                     val_to_str(octet & 0x07, q931_l1_parity_vals,
                       "Unknown (0x%X)"));
 
                if (octet & Q931_IE_VL_EXTENSION)
@@ -888,13 +1007,7 @@ l3_done:
 /*
  * Dissect a Cause information element.
  */
-static const value_string q931_cause_coding_standard_vals[] = {
-       { 0x00, "ITU-T standardized coding" },
-       { 0x20, "ISO/IEC standard" },
-       { 0x40, "National standard" },
-       { 0x60, "Standard specific to identified location" },
-       { 0,    NULL }
-};
+
 
 const value_string q931_cause_location_vals[] = {
        { 0x00, "User (U)" },
@@ -919,124 +1032,165 @@ static const value_string q931_cause_recommendation_vals[] = {
 /*
  * Cause codes for Cause.
  */
+#define        Q931_CAUSE_UNALLOC_NUMBER       0x01
+#define        Q931_CAUSE_NO_ROUTE_TO_DEST     0x03
+#define        Q931_CAUSE_CALL_REJECTED        0x15
+#define        Q931_CAUSE_NUMBER_CHANGED       0x16
+#define        Q931_CAUSE_ACCESS_INFO_DISC     0x2B
+#define        Q931_CAUSE_QOS_UNAVAILABLE      0x31
+#define        Q931_CAUSE_CHAN_NONEXISTENT     0x52
+#define        Q931_CAUSE_INCOMPATIBLE_DEST    0x58
+#define        Q931_CAUSE_MAND_IE_MISSING      0x60
+#define        Q931_CAUSE_MT_NONEX_OR_UNIMPL   0x61
+#define        Q931_CAUSE_IE_NONEX_OR_UNIMPL   0x63
+#define        Q931_CAUSE_INVALID_IE_CONTENTS  0x64
+#define        Q931_CAUSE_MSG_INCOMPAT_W_CS    0x65
+#define        Q931_CAUSE_REC_TIMER_EXP        0x66
+
 const value_string q931_cause_code_vals[] = {
-       { 0x00, "Valid cause code not yet received" },
-       { 0x01, "Unallocated (unassigned) number" },
-       { 0x02, "No route to specified transit network" },
-       { 0x03, "No route to destination" },
-       { 0x04, "Send special information tone" },
-       { 0x05, "Misdialled trunk prefix" },
-       { 0x06, "Channel unacceptable" },
-       { 0x07, "Call awarded and being delivered in an established channel" },
-       { 0x08, "Prefix 0 dialed but not allowed" },
-       { 0x09, "Prefix 1 dialed but not allowed" },
-       { 0x0A, "Prefix 1 dialed but not required" },
-       { 0x0B, "More digits received than allowed, call is proceeding" },
-       { 0x10, "Normal call clearing" },
-       { 0x11, "User busy" },
-       { 0x12, "No user responding" },
-       { 0x13, "No answer from user (user alerted)" },
-       { 0x14, "Subscriber absent" },
-       { 0x15, "Call rejected" },
-       { 0x16, "Number changed" },
-       { 0x17, "Reverse charging rejected" },
-       { 0x18, "Call suspended" },
-       { 0x19, "Call resumed" },
-       { 0x1A, "Non-selected user clearing" },
-       { 0x1B, "Destination out of order" },
-       { 0x1C, "Invalid number format (incomplete number)" },
-       { 0x1D, "Facility rejected" },
-       { 0x1E, "Response to STATUS ENQUIRY" },
-       { 0x1F, "Normal unspecified" },
-       { 0x21, "Circuit out of order" },
-       { 0x22, "No circuit/channel available" },
-       { 0x23, "Destination unattainable" },
-       { 0x25, "Degraded service" },
-       { 0x26, "Network out of order" },
-       { 0x27, "Transit delay range cannot be achieved" },
-       { 0x28, "Throughput range cannot be achieved" },
-       { 0x29, "Temporary failure" },
-       { 0x2A, "Switching equipment congestion" },
-       { 0x2B, "Access information discarded" },
-       { 0x2C, "Requested circuit/channel not available" },
-       { 0x2D, "Pre-empted" },
-       { 0x2E, "Precedence call blocked" },
-       { 0x2F, "Resources unavailable, unspecified" },
-       { 0x31, "Quality of service unavailable" },
-       { 0x32, "Requested facility not subscribed" },
-       { 0x33, "Reverse charging not allowed" },
-       { 0x34, "Outgoing calls barred" },
-       { 0x35, "Outgoing calls barred within CUG" },
-       { 0x36, "Incoming calls barred" },
-       { 0x37, "Incoming calls barred within CUG" },
-       { 0x38, "Call waiting not subscribed" },
-       { 0x39, "Bearer capability not authorized" },
-       { 0x3A, "Bearer capability not presently available" },
-       { 0x3E, "Inconsistency in designated outgoing access information and subscriber class" },
-       { 0x3F, "Service or option not available, unspecified" },
-       { 0x41, "Bearer capability not implemented" },
-       { 0x42, "Channel type not implemented" },
-       { 0x43, "Transit network selection not implemented" },
-       { 0x44, "Message not implemented" },
-       { 0x45, "Requested facility not implemented" },
-       { 0x46, "Only restricted digital information bearer capability is available" },
-       { 0x4F, "Service or option not implemented, unspecified" },
-       { 0x51, "Invalid call reference value" },
-       { 0x52, "Identified channel does not exist" },
-       { 0x53, "Call identity does not exist for suspended call" },
-       { 0x54, "Call identity in use" },
-       { 0x55, "No call suspended" },
-       { 0x56, "Call having the requested call identity has been cleared" },
-       { 0x57, "Called user not member of CUG" },
-       { 0x58, "Incompatible destination" },
-       { 0x59, "Non-existent abbreviated address entry" },
-       { 0x5A, "Destination address missing, and direct call not subscribed" },
-       { 0x5B, "Invalid transit network selection (national use)" },
-       { 0x5C, "Invalid facility parameter" },
-       { 0x5D, "Mandatory information element is missing" },
-       { 0x5F, "Invalid message, unspecified" },
-       { 0x60, "Mandatory information element is missing" },
-       { 0x61, "Message type non-existent or not implemented" },
-       { 0x62, "Message not compatible with call state or message type non-existent or not implemented" },
-       { 0x63, "Information element nonexistant or not implemented" },
-       { 0x64, "Invalid information element contents" },
-       { 0x65, "Message not compatible with call state" },
-       { 0x66, "Recovery on timer expiry" },
-       { 0x67, "Parameter non-existent or not implemented - passed on" },
-       { 0x6E, "Message with unrecognized parameter discarded" },
-       { 0x6F, "Protocol error, unspecified" },
-       { 0x7F, "Internetworking, unspecified" },
-       { 0,    NULL }
+       { 0x00,                         "Valid cause code not yet received" },
+       { Q931_CAUSE_UNALLOC_NUMBER,    "Unallocated (unassigned) number" },
+       { 0x02,                         "No route to specified transit network" },
+       { Q931_CAUSE_NO_ROUTE_TO_DEST,  "No route to destination" },
+       { 0x04,                         "Send special information tone" },
+       { 0x05,                         "Misdialled trunk prefix" },
+       { 0x06,                         "Channel unacceptable" },
+       { 0x07,                         "Call awarded and being delivered in an established channel" },
+       { 0x08,                         "Prefix 0 dialed but not allowed" },
+                                       /* Q.850 - "Preemption" */
+       { 0x09,                         "Prefix 1 dialed but not allowed" },
+                                       /* Q.850 - "Preemption - circuit reserved for reuse" */
+       { 0x0A,                         "Prefix 1 dialed but not required" },
+       { 0x0B,                         "More digits received than allowed, call is proceeding" },
+       { 0x0E,                         "QoR: ported number" },
+       { 0x10,                         "Normal call clearing" },
+       { 0x11,                         "User busy" },
+       { 0x12,                         "No user responding" },
+       { 0x13,                         "No answer from user (user alerted)" },
+       { 0x14,                         "Subscriber absent" },
+       { Q931_CAUSE_CALL_REJECTED,     "Call rejected" },
+       { Q931_CAUSE_NUMBER_CHANGED,    "Number changed" },
+       { 0x17,                         "Reverse charging rejected" },
+                                       /* Q.850 - "Redirection to new destination" */
+       { 0x18,                         "Call suspended" },
+                                       /* Q.850 Amendment 1 - "Call rejected due to feature at the destination" */
+       { 0x19,                         "Call resumed" },
+                                       /* Q.850 - "Exchange routing error */
+       { 0x1A,                         "Non-selected user clearing" },
+       { 0x1B,                         "Destination out of order" },
+       { 0x1C,                         "Invalid number format (incomplete number)" },
+       { 0x1D,                         "Facility rejected" },
+       { 0x1E,                         "Response to STATUS ENQUIRY" },
+       { 0x1F,                         "Normal unspecified" },
+       { 0x21,                         "Circuit out of order" },
+       { 0x22,                         "No circuit/channel available" },
+       { 0x23,                         "Destination unattainable" },
+       { 0x25,                         "Degraded service" },
+       { 0x26,                         "Network out of order" },
+       { 0x27,                         "Transit delay range cannot be achieved" },
+                                       /* Q.850 - "Permanent frame mode connection out of service" */
+       { 0x28,                         "Throughput range cannot be achieved" },
+                                       /* Q.850 - "Permanent frame mode connection operational" */
+       { 0x29,                         "Temporary failure" },
+       { 0x2A,                         "Switching equipment congestion" },
+       { Q931_CAUSE_ACCESS_INFO_DISC,  "Access information discarded" },
+       { 0x2C,                         "Requested circuit/channel not available" },
+       { 0x2D,                         "Pre-empted" },
+       { 0x2E,                         "Precedence call blocked" },
+       { 0x2F,                         "Resources unavailable, unspecified" },
+       { Q931_CAUSE_QOS_UNAVAILABLE,   "Quality of service unavailable" },
+       { 0x32,                         "Requested facility not subscribed" },
+       { 0x33,                         "Reverse charging not allowed" },
+       { 0x34,                         "Outgoing calls barred" },
+       { 0x35,                         "Outgoing calls barred within CUG" },
+       { 0x36,                         "Incoming calls barred" },
+       { 0x37,                         "Incoming calls barred within CUG" },
+       { 0x38,                         "Call waiting not subscribed" },
+       { 0x39,                         "Bearer capability not authorized" },
+       { 0x3A,                         "Bearer capability not presently available" },
+       { 0x3E,                         "Inconsistency in designated outgoing access information and subscriber class" },
+       { 0x3F,                         "Service or option not available, unspecified" },
+       { 0x41,                         "Bearer capability not implemented" },
+       { 0x42,                         "Channel type not implemented" },
+       { 0x43,                         "Transit network selection not implemented" },
+       { 0x44,                         "Message not implemented" },
+       { 0x45,                         "Requested facility not implemented" },
+       { 0x46,                         "Only restricted digital information bearer capability is available" },
+       { 0x4F,                         "Service or option not implemented, unspecified" },
+       { 0x51,                         "Invalid call reference value" },
+       { Q931_CAUSE_CHAN_NONEXISTENT,  "Identified channel does not exist" },
+       { 0x53,                         "Call identity does not exist for suspended call" },
+       { 0x54,                         "Call identity in use" },
+       { 0x55,                         "No call suspended" },
+       { 0x56,                         "Call having the requested call identity has been cleared" },
+       { 0x57,                         "Called user not member of CUG" },
+       { Q931_CAUSE_INCOMPATIBLE_DEST, "Incompatible destination" },
+       { 0x59,                         "Non-existent abbreviated address entry" },
+       { 0x5A,                         "Destination address missing, and direct call not subscribed" },
+                                       /* Q.850 - "Non-existent CUG" */
+       { 0x5B,                         "Invalid transit network selection (national use)" },
+       { 0x5C,                         "Invalid facility parameter" },
+       { 0x5D,                         "Mandatory information element is missing" },
+       { 0x5F,                         "Invalid message, unspecified" },
+       { Q931_CAUSE_MAND_IE_MISSING,   "Mandatory information element is missing" },
+       { Q931_CAUSE_MT_NONEX_OR_UNIMPL,"Message type non-existent or not implemented" },
+       { 0x62,                         "Message not compatible with call state or message type non-existent or not implemented" },
+       { Q931_CAUSE_IE_NONEX_OR_UNIMPL,"Information element nonexistant or not implemented" },
+       { Q931_CAUSE_INVALID_IE_CONTENTS,"Invalid information element contents" },
+       { Q931_CAUSE_MSG_INCOMPAT_W_CS, "Message not compatible with call state" },
+       { Q931_CAUSE_REC_TIMER_EXP,     "Recovery on timer expiry" },
+       { 0x67,                         "Parameter non-existent or not implemented - passed on" },
+       { 0x6E,                         "Message with unrecognized parameter discarded" },
+       { 0x6F,                         "Protocol error, unspecified" },
+       { 0x7F,                         "Internetworking, unspecified" },
+       { 0,                            NULL }
 };
 
-static void
+static const value_string q931_cause_condition_vals[] = {
+       { 0x00, "Unknown" },
+       { 0x01, "Permanent" },
+       { 0x02, "Transient" },
+       { 0x00, NULL }
+};
+
+#define        Q931_REJ_USER_SPECIFIC          0x00
+#define        Q931_REJ_IE_MISSING             0x04
+#define        Q931_REJ_IE_INSUFFICIENT        0x08
+
+static const value_string q931_rejection_reason_vals[] = {
+       { 0x00, "User specific" },
+       { 0x04, "Information element missing" },
+       { 0x08, "Information element contents are not sufficient" },
+       { 0x00, NULL }
+};
+
+void
 dissect_q931_cause_ie(tvbuff_t *tvb, int offset, int len,
-    proto_tree *tree)
+    proto_tree *tree, int hf_cause_value)
 {
        guint8 octet;
+       guint8 cause_value;
        guint8 coding_standard;
+       guint8 rejection_reason;
 
        if (len == 0)
                return;
        octet = tvb_get_guint8(tvb, offset);
        coding_standard = octet & 0x60;
-       proto_tree_add_text(tree, tvb, offset, 1,
-           "Coding standard: %s",
-           val_to_str(coding_standard, q931_cause_coding_standard_vals, NULL));
        if (coding_standard != Q931_ITU_STANDARDIZED_CODING) {
                /*
                 * We don't know how the cause is encoded,
                 * so just dump it as data and be done with it.
                 */
+               proto_tree_add_uint(tree, hf_q931_coding_standard, tvb, offset, 1, octet);
                proto_tree_add_text(tree, tvb, offset,
                    len, "Data: %s",
                    tvb_bytes_to_str(tvb, offset, len));
                return;
        }
-       proto_tree_add_text(tree, tvb, offset, 1,
-           "Location: %s",
-           val_to_str(octet & 0x0F, q931_cause_location_vals,
-             "Unknown (0x%X)"));
+       proto_tree_add_uint(tree, hf_q931_cause_location, tvb, offset, 1, octet);
+       proto_tree_add_uint(tree, hf_q931_coding_standard, tvb, offset, 1, octet);
+       proto_tree_add_boolean(tree, hf_q931_extension_ind, tvb, offset, 1, octet);
        offset += 1;
        len -= 1;
 
@@ -1048,6 +1202,7 @@ dissect_q931_cause_ie(tvbuff_t *tvb, int offset, int len,
                    "Recommendation: %s",
                    val_to_str(octet & 0x7F, q931_cause_recommendation_vals,
                      "Unknown (0x%02X)"));
+               proto_tree_add_boolean(tree, hf_q931_extension_ind, tvb, offset, 1, octet);
                offset += 1;
                len -= 1;
        }
@@ -1055,31 +1210,117 @@ dissect_q931_cause_ie(tvbuff_t *tvb, int offset, int len,
        if (len == 0)
                return;
        octet = tvb_get_guint8(tvb, offset);
-       proto_tree_add_text(tree, tvb, offset, 1,
-           "Cause value: %s",
-           val_to_str(octet & 0x7F, q931_cause_code_vals,
-             "Unknown (0x%02X)"));
+       cause_value = octet & 0x7F;
+       proto_tree_add_uint(tree, hf_cause_value, tvb, offset, 1, cause_value);
+       proto_tree_add_boolean(tree, hf_q931_extension_ind, tvb, offset, 1, octet);
        offset += 1;
        len -= 1;
 
        if (len == 0)
                return;
-       proto_tree_add_text(tree, tvb, offset, len,
-           "Diagnostics: %s",
-           tvb_bytes_to_str(tvb, offset, len));
+       switch (cause_value) {
+
+       case Q931_CAUSE_UNALLOC_NUMBER:
+       case Q931_CAUSE_NO_ROUTE_TO_DEST:
+       case Q931_CAUSE_QOS_UNAVAILABLE:
+               octet = tvb_get_guint8(tvb, offset);
+               proto_tree_add_text(tree, tvb, offset, 1,
+                   "Network service: %s",
+                   (octet & 0x80) ? "User" : "Provider");
+               proto_tree_add_text(tree, tvb, offset, 1,
+                   "%s",
+                   (octet & 0x40) ? "Abnormal" : "Normal");
+               proto_tree_add_text(tree, tvb, offset, 1,
+                   "Condition: %s",
+                   val_to_str(octet & 0x03, q931_cause_condition_vals,
+                     "Unknown (0x%X)"));
+               break;
+
+       case Q931_CAUSE_CALL_REJECTED:
+               rejection_reason = octet & 0x7C;
+               proto_tree_add_text(tree, tvb, offset, 1,
+                   "Rejection reason: %s",
+                   val_to_str(octet & 0x7C, q931_rejection_reason_vals,
+                     "Unknown (0x%X)"));
+               proto_tree_add_text(tree, tvb, offset, 1,
+                   "Condition: %s",
+                   val_to_str(octet & 0x03, q931_cause_condition_vals,
+                     "Unknown (0x%X)"));
+               offset += 1;
+               len -= 1;
+
+               if (len == 0)
+                       return;
+               switch (rejection_reason) {
+
+               case Q931_REJ_USER_SPECIFIC:
+                       proto_tree_add_text(tree, tvb, offset, len,
+                           "User specific diagnostic: %s",
+                           tvb_bytes_to_str(tvb, offset, len));
+                       break;
+
+               case Q931_REJ_IE_MISSING:
+                       proto_tree_add_text(tree, tvb, offset, 1,
+                           "Missing information element: %s",
+                           val_to_str(tvb_get_guint8(tvb, offset), q931_info_element_vals0,
+                             "Unknown (0x%02X)"));
+                       break;
+
+               case Q931_REJ_IE_INSUFFICIENT:
+                       proto_tree_add_text(tree, tvb, offset, 1,
+                           "Insufficient information element: %s",
+                           val_to_str(tvb_get_guint8(tvb, offset), q931_info_element_vals0,
+                             "Unknown (0x%02X)"));
+                       break;
+
+               default:
+                       proto_tree_add_text(tree, tvb, offset, len,
+                           "Diagnostic: %s",
+                           tvb_bytes_to_str(tvb, offset, len));
+                       break;
+               }
+               break;
+
+       case Q931_CAUSE_ACCESS_INFO_DISC:
+       case Q931_CAUSE_INCOMPATIBLE_DEST:
+       case Q931_CAUSE_MAND_IE_MISSING:
+       case Q931_CAUSE_IE_NONEX_OR_UNIMPL:
+       case Q931_CAUSE_INVALID_IE_CONTENTS:
+               do {
+                       proto_tree_add_text(tree, tvb, offset, 1,
+                           "Information element: %s",
+                           val_to_str(tvb_get_guint8(tvb, offset), q931_info_element_vals0,
+                             "Unknown (0x%02X)"));
+                       offset += 1;
+                       len -= 1;
+               } while (len != 0);
+               break;
+
+       case Q931_CAUSE_MT_NONEX_OR_UNIMPL:
+       case Q931_CAUSE_MSG_INCOMPAT_W_CS:
+               proto_tree_add_text(tree, tvb, offset, 1,
+                   "Message type: %s",
+                   val_to_str(tvb_get_guint8(tvb, offset), q931_message_type_vals,
+                     "Unknown (0x%02X)"));
+               break;
+
+       case Q931_CAUSE_REC_TIMER_EXP:
+               if (len < 3)
+                       return;
+               proto_tree_add_text(tree, tvb, offset, 3,
+                   "Timer: %.3s", tvb_get_ptr(tvb, offset, 3));
+               break;
+
+       default:
+               proto_tree_add_text(tree, tvb, offset, len,
+                   "Diagnostics: %s",
+                   tvb_bytes_to_str(tvb, offset, len));
+       }
 }
 
 /*
  * Dissect a Call state information element.
  */
-static const value_string q931_coding_standard_vals[] = {
-       { 0x00, "ITU-T standardized coding" },
-       { 0x20, "ISO/IEC standard" },
-       { 0x40, "National standard" },
-       { 0x60, "Standard defined for the network" },
-       { 0,    NULL }
-};
-
 static const value_string q931_call_state_vals[] = {
        { 0x00, "Null" },
        { 0x01, "Call initiated" },
@@ -1114,9 +1355,7 @@ dissect_q931_call_state_ie(tvbuff_t *tvb, int offset, int len,
                return;
        octet = tvb_get_guint8(tvb, offset);
        coding_standard = octet & 0x60;
-       proto_tree_add_text(tree, tvb, offset, 1,
-           "Coding standard: %s",
-           val_to_str(coding_standard, q931_coding_standard_vals, NULL));
+       proto_tree_add_uint(tree, hf_q931_coding_standard, tvb, offset, 1, octet);
        if (coding_standard != Q931_ITU_STANDARDIZED_CODING) {
                /*
                 * We don't know how the call state is encoded,
@@ -1232,10 +1471,7 @@ dissect_q931_channel_identification_ie(tvbuff_t *tvb, int offset, int len,
                        return;
                octet = tvb_get_guint8(tvb, offset);
                coding_standard = octet & 0x60;
-               proto_tree_add_text(tree, tvb, offset, 1,
-                   "Coding standard: %s",
-                   val_to_str(coding_standard, q931_coding_standard_vals,
-                     NULL));
+               proto_tree_add_uint(tree, hf_q931_coding_standard, tvb, offset, 1, octet);
                if (coding_standard != Q931_ITU_STANDARDIZED_CODING) {
                        /*
                         * We don't know how the channel identifier is
@@ -1286,9 +1522,7 @@ dissect_q931_progress_indicator_ie(tvbuff_t *tvb, int offset, int len,
                return;
        octet = tvb_get_guint8(tvb, offset);
        coding_standard = octet & 0x60;
-       proto_tree_add_text(tree, tvb, offset, 1,
-           "Coding standard: %s",
-           val_to_str(coding_standard, q931_cause_coding_standard_vals, NULL));
+       proto_tree_add_uint(tree, hf_q931_coding_standard, tvb, offset, 1, octet);
        if (coding_standard != Q931_ITU_STANDARDIZED_CODING) {
                /*
                 * We don't know how the progress indicator is encoded,
@@ -1421,19 +1655,24 @@ static void
 dissect_q931_date_time_ie(tvbuff_t *tvb, int offset, int len,
     proto_tree *tree)
 {
-       if (len != 6) {
+       if (len == 6) {
+               /*
+                * XXX - what is "year" relative to?  Is "month" 0-origin or
+                * 1-origin?  Q.931 doesn't say....
+                */
+               proto_tree_add_text(tree, tvb, offset, 6,
+                   "Date/time: %02u-%02u-%02u %02u:%02u:%02u",
+                   tvb_get_guint8(tvb, offset + 0), tvb_get_guint8(tvb, offset + 1), tvb_get_guint8(tvb, offset + 2),
+                   tvb_get_guint8(tvb, offset + 3), tvb_get_guint8(tvb, offset + 4), tvb_get_guint8(tvb, offset + 5));
+       } else if (len == 5) {
+               proto_tree_add_text(tree, tvb, offset, 5,
+                   "Date/time: %02u-%02u-%02u %02u:%02u:00",
+                   tvb_get_guint8(tvb, offset + 0), tvb_get_guint8(tvb, offset + 1), tvb_get_guint8(tvb, offset + 2),
+                   tvb_get_guint8(tvb, offset + 3), tvb_get_guint8(tvb, offset + 4));
+       } else {
                proto_tree_add_text(tree, tvb, offset, len,
-                   "Date/time: length is %d, should be 6\n", len);
-               return;
+                   "Date/time: length is %d, should be 5 or 6", len);
        }
-       /*
-        * XXX - what is "year" relative to?  Is "month" 0-origin or
-        * 1-origin?  Q.931 doesn't say....
-        */
-       proto_tree_add_text(tree, tvb, offset, 6,
-           "Date/time: %02u-%02u-%02u %02u:%02u:%02u",
-           tvb_get_guint8(tvb, offset + 0), tvb_get_guint8(tvb, offset + 1), tvb_get_guint8(tvb, offset + 2),
-           tvb_get_guint8(tvb, offset + 3), tvb_get_guint8(tvb, offset + 4), tvb_get_guint8(tvb, offset + 5));
 }
 
 /*
@@ -1469,7 +1708,7 @@ dissect_q931_signal_ie(tvbuff_t *tvb, int offset, int len,
 {
        if (len != 1) {
                proto_tree_add_text(tree, tvb, offset, len,
-                   "Signal: length is %d, should be 1\n", len);
+                   "Signal: length is %d, should be 1", len);
                return;
        }
        proto_tree_add_text(tree, tvb, offset, 1,
@@ -1502,7 +1741,7 @@ dissect_q931_information_rate_ie(tvbuff_t *tvb, int offset, int len,
 {
        if (len != 4) {
                proto_tree_add_text(tree, tvb, offset, len,
-                   "Information rate: length is %d, should be 4\n", len);
+                   "Information rate: length is %d, should be 4", len);
                return;
        }
        proto_tree_add_text(tree, tvb, offset + 0, 1,
@@ -1768,12 +2007,12 @@ dissect_q931_reverse_charge_ind_ie(tvbuff_t *tvb, int offset, int len,
  * Dissect a (phone) number information element.
  */
 static const value_string q931_number_type_vals[] = {
-       { 0x00, "Unknown" },
-       { 0x10, "International number" },
-       { 0x20, "National number" },
-       { 0x30, "Network specific number" },
-       { 0x40, "Subscriber number" },
-       { 0x60, "Abbreviated number" },
+       { 0x0, "Unknown" },
+       { 0x1, "International number" },
+       { 0x2, "National number" },
+       { 0x3, "Network specific number" },
+       { 0x4, "Subscriber number" },
+       { 0x6, "Abbreviated number" },
        { 0,    NULL }
 };
 
@@ -1789,8 +2028,8 @@ static const value_string q931_numbering_plan_vals[] = {
 
 static const value_string q931_presentation_indicator_vals[] = {
        { 0x00, "Presentation allowed" },
-       { 0x20, "Presentation restricted" },
-       { 0x40, "Number not available due to interworking" },
+       { 0x01, "Presentation restricted" },
+       { 0x02, "Number not available due to interworking" },
        { 0,    NULL }
 };
 
@@ -1815,21 +2054,20 @@ static const value_string q931_redirection_reason_vals[] = {
 
 static void
 dissect_q931_number_ie(tvbuff_t *tvb, int offset, int len,
-    proto_tree *tree)
+    proto_tree *tree, int hfindex, e164_info_t e164_info)
 {
        guint8 octet;
+       gint number_plan;
 
        if (len == 0)
                return;
        octet = tvb_get_guint8(tvb, offset);
-       proto_tree_add_text(tree, tvb, offset, 1,
-           "Type of number: %s",
-           val_to_str(octet & 0x70, q931_number_type_vals,
-             "Unknown (0x%02X)"));
-       proto_tree_add_text(tree, tvb, offset, 1,
-           "Numbering plan: %s",
-           val_to_str(octet & 0x0F, q931_numbering_plan_vals,
-             "Unknown (0x%02X)"));
+       number_plan = octet & 0x0f;
+       e164_info.nature_of_address = ( octet & 0x70 ) >> 4;
+       proto_tree_add_uint(tree, hf_q931_numbering_plan, tvb, offset, 1, octet);
+       proto_tree_add_uint(tree, hf_q931_number_type, tvb, offset, 1, octet);
+       proto_tree_add_boolean(tree, hf_q931_extension_ind, tvb, offset, 1, octet);
+       
        offset += 1;
        len -= 1;
 
@@ -1837,14 +2075,9 @@ dissect_q931_number_ie(tvbuff_t *tvb, int offset, int len,
                if (len == 0)
                        return;
                octet = tvb_get_guint8(tvb, offset);
-               proto_tree_add_text(tree, tvb, offset, 1,
-                   "Presentation indicator: %s",
-                   val_to_str(octet & 0x60, q931_presentation_indicator_vals,
-                     "Unknown (0x%X)"));
-               proto_tree_add_text(tree, tvb, offset, 1,
-                   "Screening indicator: %s",
-                   val_to_str(octet & 0x03, q931_screening_indicator_vals,
-                     "Unknown (0x%X)"));
+               proto_tree_add_uint(tree, hf_q931_screening_ind, tvb, offset, 1, octet);
+               proto_tree_add_uint(tree, hf_q931_presentation_ind, tvb, offset, 1, octet);
+               proto_tree_add_boolean(tree, hf_q931_extension_ind, tvb, offset, 1, octet);
                offset += 1;
                len -= 1;
        }
@@ -1866,8 +2099,18 @@ dissect_q931_number_ie(tvbuff_t *tvb, int offset, int len,
 
        if (len == 0)
                return;
-       proto_tree_add_text(tree, tvb, offset, len, "Number: %s",
-           tvb_format_text(tvb, offset, len));
+       proto_tree_add_item(tree, hfindex, tvb, offset, len, FALSE);
+       proto_item_append_text(proto_tree_get_parent(tree), ": '%s'", tvb_format_text(tvb, offset, len));
+
+       if ( number_plan == 1 ) {
+               if ( e164_info.e164_number_type != NONE ){
+
+                       e164_info.E164_number_str = tvb_get_string(tvb, offset, len);
+                       e164_info.E164_number_length = len;
+                       dissect_e164_number(tvb, tree, offset, len, e164_info);
+               }
+       }
+
 }
 
 /*
@@ -1927,7 +2170,7 @@ dissect_q931_restart_indicator_ie(tvbuff_t *tvb, int offset, int len,
 {
        if (len != 1) {
                proto_tree_add_text(tree, tvb, offset, len,
-                   "Restart indicator: length is %d, should be 1\n", len);
+                   "Restart indicator: length is %d, should be 1", len);
                return;
        }
        proto_tree_add_text(tree, tvb, offset, 1,
@@ -1980,9 +2223,9 @@ dissect_q931_high_layer_compat_ie(tvbuff_t *tvb, int offset, int len,
                return;
        octet = tvb_get_guint8(tvb, offset);
        coding_standard = octet & 0x60;
-       proto_tree_add_text(tree, tvb, offset, 1,
-           "Coding standard: %s",
-           val_to_str(coding_standard, q931_coding_standard_vals, NULL));
+       proto_tree_add_uint(tree, hf_q931_coding_standard, tvb, offset, 1, octet);
+       offset += 1;
+       len -= 1;
        if (coding_standard != Q931_ITU_STANDARDIZED_CODING) {
                /*
                 * We don't know how the call state is encoded,
@@ -2043,7 +2286,7 @@ static const value_string q931_protocol_discriminator_vals[] = {
        { 0,                                    NULL }
 };
 
-static void
+void
 dissect_q931_user_user_ie(tvbuff_t *tvb, int offset, int len,
     proto_tree *tree)
 {
@@ -2085,34 +2328,28 @@ dissect_q931_ia5_ie(tvbuff_t *tvb, int offset, int len, proto_tree *tree,
        if (len != 0) {
                proto_tree_add_text(tree, tvb, offset, len, "%s: %s", label,
                    tvb_format_text(tvb, offset, len));
+               proto_item_append_text(proto_tree_get_parent(tree), "  '%s'", tvb_format_text(tvb, offset, len));
        }
 }
 
-static const value_string q931_codeset_vals[] = {
-       { 0x00, "Q.931 information elements" },
-       { 0x04, "Information elements for ISO/IEC use" },
-       { 0x05, "Information elements for national use" },
-       { 0x06, "Information elements specific to the local network" },
-       { 0x07, "User-specific information elements" },
-       { 0x00, NULL },
-};
-
 static void
 dissect_q931_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
     gboolean is_tpkt)
 {
        int             offset = 0;
        proto_tree      *q931_tree = NULL;
-       proto_item      *ti;
        proto_tree      *ie_tree = NULL;
+       proto_item      *ti, *ti_ie;
        guint8          call_ref_len;
        guint8          call_ref[15];
-       guint8          message_type;
+       guint32         call_ref_val;
+       guint8          message_type, segmented_message_type;
        guint8          info_element;
        guint16         info_element_len;
-       int             codeset;
-       gboolean        non_locking_shift;
-       tvbuff_t        *h225_tvb;
+       gboolean        more_frags; 
+       guint32         frag_len;
+       fragment_data *fd_head;
+       tvbuff_t *next_tvb = NULL;
 
        if (check_col(pinfo->cinfo, COL_PROTOCOL))
                col_set_str(pinfo->cinfo, COL_PROTOCOL, "Q.931");
@@ -2129,11 +2366,22 @@ dissect_q931_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
        if (q931_tree != NULL)
                proto_tree_add_uint(q931_tree, hf_q931_call_ref_len, tvb, offset, 1, call_ref_len);
        offset += 1;
+       switch (call_ref_len) {
+               case 0: call_ref_val = 0; break;
+               case 1: call_ref_val = tvb_get_guint8(tvb, offset);     break;
+               case 2: call_ref_val = tvb_get_ntohs(tvb, offset); break;
+               case 3: call_ref_val = tvb_get_ntoh24(tvb, offset); break;
+               default: call_ref_val = tvb_get_ntohl(tvb, offset);
+       } 
        if (call_ref_len != 0) {
-               /* XXX - split this into flag and value */
                tvb_memcpy(tvb, call_ref, offset, call_ref_len);
-               if (q931_tree != NULL)
-                       proto_tree_add_bytes(q931_tree, hf_q931_call_ref, tvb, offset, call_ref_len, call_ref);
+               if (q931_tree != NULL) {
+                       proto_tree_add_boolean(q931_tree, hf_q931_call_ref_flag,
+                           tvb, offset, 1, (call_ref[0] & 0x80) != 0);
+                       call_ref[0] &= 0x7F;
+                       proto_tree_add_bytes(q931_tree, hf_q931_call_ref,
+                           tvb, offset, call_ref_len, call_ref);
+               }
                offset += call_ref_len;
        }
        message_type = tvb_get_guint8(tvb, offset);
@@ -2149,20 +2397,96 @@ dissect_q931_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
        /*
         * And now for the information elements....
         */
-       codeset = 0;    /* start out in codeset 0 */
+       if ((message_type != Q931_SEGMENT) || !q931_reassembly || 
+                       (tvb_reported_length_remaining(tvb, offset) <= 4)) {
+               dissect_q931_IEs(tvb, pinfo, tree, q931_tree, is_tpkt, offset, 0);
+               return;
+       }
+       info_element = tvb_get_guint8(tvb, offset);
+       info_element_len = tvb_get_guint8(tvb, offset + 1);
+       if ((info_element != Q931_IE_SEGMENTED_MESSAGE) || (info_element_len < 2)) {
+               dissect_q931_IEs(tvb, pinfo, tree, q931_tree, is_tpkt, offset, 0);
+               return;
+       }
+       /* Segmented message IE */
+       ti_ie = proto_tree_add_text(q931_tree, tvb, offset, 1+1+info_element_len, "%s",
+                                   val_to_str(info_element, q931_info_element_vals[0], "Unknown information element (0x%02X)"));
+       ie_tree = proto_item_add_subtree(ti_ie, ett_q931_ie);
+       proto_tree_add_text(ie_tree, tvb, offset, 1, "Information element: %s",
+                                   val_to_str(info_element, q931_info_element_vals[0], "Unknown (0x%02X)"));
+       proto_tree_add_text(ie_tree, tvb, offset + 1, 1, "Length: %u", info_element_len);
+       dissect_q931_segmented_message_ie(tvb, offset + 2, info_element_len, ie_tree);
+       more_frags = (tvb_get_guint8(tvb, offset + 2) & 0x7F) != 0;
+       segmented_message_type = tvb_get_guint8(tvb, offset + 3);
+       if (check_col(pinfo->cinfo, COL_INFO)) {
+               col_append_fstr(pinfo->cinfo, COL_INFO, " of %s",
+                   val_to_str(segmented_message_type, q931_message_type_vals, "Unknown message type (0x%02X)"));
+       }
+       offset += 1 + 1 + info_element_len;
+       /* Reassembly */
+       frag_len = tvb_length_remaining(tvb, offset);
+       fd_head = fragment_add_seq_next(tvb, offset, pinfo, call_ref_val,
+                                                                       q931_fragment_table, q931_reassembled_table,
+                                                                       frag_len, more_frags);
+       if (fd_head) {
+               if (pinfo->fd->num == fd_head->reassembled_in) {  /* last fragment */
+                       if (fd_head->next != NULL) {  /* 2 or more segments */
+                               next_tvb = tvb_new_real_data(fd_head->data, fd_head->len, fd_head->len);
+                               tvb_set_child_real_data_tvbuff(tvb, next_tvb);
+                               add_new_data_source(pinfo, next_tvb, "Reassembled Q.931 IEs");
+                               /* Show all fragments. */
+                               if (tree) show_fragment_seq_tree(fd_head, &q931_frag_items, q931_tree, pinfo, next_tvb);
+                       } else {  /* only 1 segment */
+                               next_tvb = tvb_new_subset(tvb, offset, -1, -1);
+                       }
+                       if (check_col(pinfo->cinfo, COL_INFO)) {
+                               col_add_fstr(pinfo->cinfo, COL_INFO, "%s [reassembled]",
+                                   val_to_str(segmented_message_type, q931_message_type_vals, "Unknown message type (0x%02X)"));
+                       }
+               } else {
+                       if (tree) proto_tree_add_uint(q931_tree, hf_q931_reassembled_in, tvb, offset, frag_len, fd_head->reassembled_in);
+               }
+       }
+       if (next_tvb)
+               dissect_q931_IEs(next_tvb, pinfo, tree, q931_tree, is_tpkt, 0, 0);
+}
+
+static const value_string q931_codeset_vals[] = {
+       { 0x00, "Q.931 information elements" },
+       { 0x04, "Information elements for ISO/IEC use" },
+       { 0x05, "Information elements for national use" },
+       { 0x06, "Information elements specific to the local network" },
+       { 0x07, "User-specific information elements" },
+       { 0x00, NULL },
+};
+
+static void
+dissect_q931_IEs(tvbuff_t *tvb, packet_info *pinfo, proto_tree *root_tree,
+    proto_tree *q931_tree, gboolean is_tpkt, int offset, int initial_codeset)
+{
+       proto_item      *ti;
+       proto_tree      *ie_tree = NULL;
+       guint8          info_element;
+       guint16         info_element_len;
+       int             codeset, locked_codeset;
+       gboolean        non_locking_shift, first_segment;
+       tvbuff_t        *h225_tvb, *next_tvb;
+       e164_info_t e164_info;
+       e164_info.e164_number_type = NONE;
+
+       codeset = locked_codeset = initial_codeset;
        non_locking_shift = TRUE;
+       first_segment = FALSE;
        while (tvb_reported_length_remaining(tvb, offset) > 0) {
                info_element = tvb_get_guint8(tvb, offset);
 
-               /*
-                * Check for the single-octet IEs.
-                */
-               switch (info_element & Q931_IE_SO_IDENTIFIER_MASK) {
-
-               case Q931_IE_SHIFT:
-                       non_locking_shift =
-                           !(info_element & Q931_IE_SHIFT_LOCKING);
+               /* Check for the codeset shift */
+               if ((info_element & Q931_IE_SO_MASK) &&
+                   ((info_element & Q931_IE_SO_IDENTIFIER_MASK) == Q931_IE_SHIFT)) {
+                       non_locking_shift = info_element & Q931_IE_SHIFT_NON_LOCKING;
                        codeset = info_element & Q931_IE_SHIFT_CODESET;
+                       if (!non_locking_shift)
+                               locked_codeset = codeset;
                        if (q931_tree != NULL) {
                                proto_tree_add_text(q931_tree, tvb, offset, 1,
                                    "%s shift to codeset %u: %s",
@@ -2173,65 +2497,87 @@ dissect_q931_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
                        }
                        offset += 1;
                        continue;
+               }
 
-               case Q931_IE_MORE_DATA_OR_SEND_COMP:
-                       switch (info_element) {
+               /*
+                * Check for the single-octet IEs.
+                */
+               if (info_element & Q931_IE_SO_MASK) {
+                       /*
+                        * Check for subdissectors for this IE or
+                        * for all IEs in this codeset.
+                        */
+                       if (dissector_get_port_handle(codeset_dissector_table, codeset) ||
+                           dissector_get_port_handle(ie_dissector_table, (codeset << 8) | (info_element & Q931_IE_SO_IDENTIFIER_MASK))) {
+                               next_tvb = tvb_new_subset (tvb, offset, 1, 1);
+                               if (dissector_try_port(ie_dissector_table, (codeset << 8) | (info_element & Q931_IE_SO_IDENTIFIER_MASK), next_tvb, pinfo, q931_tree) ||
+                                   dissector_try_port(codeset_dissector_table, codeset, next_tvb, pinfo, q931_tree)) {
+                                       offset += 1;
+                                       codeset = locked_codeset;
+                                       continue;
+                               }
+                       }
+
+                       switch ((codeset << 8) | (info_element & Q931_IE_SO_IDENTIFIER_MASK)) {
+
+                       case CS0 | Q931_IE_MORE_DATA_OR_SEND_COMP:
+                               switch (info_element) { 
+
+                               case Q931_IE_MORE_DATA:
+                                       if (q931_tree != NULL) {
+                                               proto_tree_add_text(q931_tree, tvb, offset, 1,
+                                                   "More data");
+                                       }
+                                       break;
 
-                       case Q931_IE_MORE_DATA:
+                               case Q931_IE_SENDING_COMPLETE:
+                                       if (q931_tree != NULL) {
+                                               proto_tree_add_text(q931_tree, tvb, offset, 1,
+                                                   "Sending complete");
+                                       }
+                                       break;
+
+                               default:
+                                       if (q931_tree != NULL) {
+                                               proto_tree_add_text(q931_tree, tvb, offset, 1,
+                                                   "Unknown information element (0x%02X)",
+                                                   info_element);
+                                       }
+                                       break;
+                               }
+                               break;
+
+                       case CS0 | Q931_IE_CONGESTION_LEVEL:
                                if (q931_tree != NULL) {
                                        proto_tree_add_text(q931_tree, tvb, offset, 1,
-                                           "More data");
+                                           "Congestion level: %s",
+                                           val_to_str(info_element & Q931_IE_SO_IE_MASK,
+                                             q931_congestion_level_vals,
+                                             "Unknown (0x%X)"));
                                }
                                break;
 
-                       case Q931_IE_SENDING_COMPLETE:
+                       case CS0 | Q931_IE_REPEAT_INDICATOR:
                                if (q931_tree != NULL) {
                                        proto_tree_add_text(q931_tree, tvb, offset, 1,
-                                           "Sending complete");
+                                           "Repeat indicator: %s",
+                                           val_to_str(info_element & Q931_IE_SO_IE_MASK,
+                                         q931_repeat_indication_vals,
+                                             "Unknown (0x%X)"));
                                }
                                break;
 
                        default:
                                if (q931_tree != NULL) {
                                        proto_tree_add_text(q931_tree, tvb, offset, 1,
-                                           "Unknown information element (0x%02X",
+                                           "Unknown information element (0x%02X)",
                                            info_element);
                                }
                                break;
                        }
                        offset += 1;
-                       if (non_locking_shift)
-                               codeset = 0;
-                       continue;
-
-               case Q931_IE_CONGESTION_LEVEL:
-                       if (q931_tree != NULL) {
-                               proto_tree_add_text(q931_tree, tvb, offset, 1,
-                                   "Congestion level: %s",
-                                   val_to_str(info_element & Q931_IE_SO_IE_MASK,
-                                     q931_congestion_level_vals,
-                                     "Unknown (0x%X)"));
-                       }
-                       offset += 1;
-                       if (non_locking_shift)
-                               codeset = 0;
-                       continue;
-
-               case Q931_IE_REPEAT_INDICATOR:
-                       if (q931_tree != NULL) {
-                               proto_tree_add_text(q931_tree, tvb, offset, 1,
-                                   "Repeat indicator: %s",
-                                   val_to_str(info_element & Q931_IE_SO_IE_MASK,
-                                     q931_repeat_indication_vals,
-                                     "Unknown (0x%X)"));
-                       }
-                       offset += 1;
-                       if (non_locking_shift)
-                               codeset = 0;
+                       codeset = locked_codeset;
                        continue;
-
-               default:
-                       break;
                }
 
                /*
@@ -2246,21 +2592,21 @@ dissect_q931_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
                 * IE with ASN.1 encoding of the user information.
                 */
                if (is_tpkt && tvb_bytes_exist(tvb, offset, 4) &&
-                   tvb_get_guint8(tvb, offset) == Q931_IE_USER_USER &&
+                   codeset == 0 && tvb_get_guint8(tvb, offset) == Q931_IE_USER_USER &&
                    tvb_get_guint8(tvb, offset + 3) == Q931_PROTOCOL_DISCRIMINATOR_ASN1)  {
                        info_element_len = tvb_get_ntohs(tvb, offset + 1);
                        if (q931_tree != NULL) {
                                ti = proto_tree_add_text(q931_tree, tvb, offset,
                                    1+2+info_element_len, "%s",
                                    val_to_str(info_element,
-                                     q931_info_element_vals,
+                                     q931_info_element_vals[codeset],
                                      "Unknown information element (0x%02X)"));
                                ie_tree = proto_item_add_subtree(ti,
                                    ett_q931_ie);
                                proto_tree_add_text(ie_tree, tvb, offset, 1,
                                    "Information element: %s",
                                    val_to_str(info_element,
-                                     q931_info_element_vals, "Unknown (0x%02X)"));
+                                     q931_info_element_vals[codeset], "Unknown (0x%02X)"));
                                proto_tree_add_text(ie_tree, tvb, offset + 1,
                                    2, "Length: %u", info_element_len);
                                proto_tree_add_text(ie_tree, tvb, offset + 3,
@@ -2285,7 +2631,7 @@ dissect_q931_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
                                            offset + 4, info_element_len - 1,
                                            info_element_len - 1);
                                        call_dissector(h225_handle, h225_tvb,
-                                           pinfo, tree);
+                                           pinfo, root_tree);
                                } else {
                                        /*
                                         * No - just show it as "User
@@ -2302,172 +2648,216 @@ dissect_q931_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
                        offset += 1 + 2 + info_element_len;
                } else {
                        info_element_len = tvb_get_guint8(tvb, offset + 1);
-                       if (q931_tree != NULL) {
-                               ti = proto_tree_add_text(q931_tree, tvb, offset,
-                                   1+1+info_element_len, "%s",
-                                   val_to_str(info_element, q931_info_element_vals,
-                                     "Unknown information element (0x%02X)"));
-                                       ie_tree = proto_item_add_subtree(ti, ett_q931_ie);
-                               proto_tree_add_text(ie_tree, tvb, offset, 1,
-                                   "Information element: %s",
-                                   val_to_str(info_element, q931_info_element_vals,
-                                     "Unknown (0x%02X)"));
-                               proto_tree_add_text(ie_tree, tvb, offset + 1, 1,
-                                   "Length: %u", info_element_len);
 
-                               switch (info_element) {
+                       if (first_segment && (tvb_reported_length_remaining(tvb, offset + 2) < info_element_len)) {  /* incomplete IE at the end of the 1st segment */
+                               proto_tree_add_text(q931_tree, tvb, offset, tvb_reported_length_remaining(tvb, offset), "Incomplete IE in the 1st segment");
+                               break;
+                       }
 
-                               case Q931_IE_SEGMENTED_MESSAGE:
-                                       dissect_q931_segmented_message_ie(tvb,
-                                           offset + 2, info_element_len,
-                                           ie_tree);
-                                       break;
+                       /*
+                        * Check for subdissectors for this IE or
+                        * for all IEs in this codeset.
+                        */
+                       if (dissector_get_port_handle(codeset_dissector_table, codeset) ||
+                           dissector_get_port_handle(ie_dissector_table, (codeset << 8) | info_element)) {
+                               next_tvb = tvb_new_subset (tvb, offset, info_element_len + 2, info_element_len + 2);
+                               if (dissector_try_port(ie_dissector_table, (codeset << 8) | info_element, next_tvb, pinfo, q931_tree) ||
+                                   dissector_try_port(codeset_dissector_table, codeset, next_tvb, pinfo, q931_tree)) {
+                                       offset += 2 + info_element_len;
+                                       codeset = locked_codeset;
+                                       continue;
+                               }
+                       }
 
-                               case Q931_IE_BEARER_CAPABILITY:
-                               case Q931_IE_LOW_LAYER_COMPAT:
+                       ti = proto_tree_add_text(q931_tree, tvb, offset, 1+1+info_element_len, "%s",
+                                   val_to_str(info_element, q931_info_element_vals[codeset], "Unknown information element (0x%02X)"));
+                       ie_tree = proto_item_add_subtree(ti, ett_q931_ie);
+                       proto_tree_add_text(ie_tree, tvb, offset, 1, "Information element: %s",
+                                   val_to_str(info_element, q931_info_element_vals[codeset], "Unknown (0x%02X)"));
+                       proto_tree_add_text(ie_tree, tvb, offset + 1, 1, "Length: %u", info_element_len);
+
+                       if (((codeset << 8) | info_element) == (CS0 | Q931_IE_SEGMENTED_MESSAGE)) {
+                               dissect_q931_segmented_message_ie(tvb, offset + 2, info_element_len, ie_tree);
+                               if (check_col(pinfo->cinfo, COL_INFO)) {
+                                       col_append_fstr(pinfo->cinfo, COL_INFO, " of %s",
+                                           val_to_str(tvb_get_guint8(tvb, offset + 3), q931_message_type_vals, "Unknown message type (0x%02X)"));
+                               }
+                               if (tvb_get_guint8(tvb, offset + 2) & 0x80) {  /* the 1st segment */
+                                       first_segment = TRUE;
+                               } else {  /* not the 1st segment */
+                                       proto_tree_add_text(q931_tree, tvb, offset + 4, tvb_reported_length_remaining(tvb, offset + 4), "Message segment");
+                                       info_element_len += tvb_reported_length_remaining(tvb, offset + 4);
+                               }
+                       } else if (q931_tree != NULL) {
+                               switch ((codeset << 8) | info_element) {
+
+                               case CS0 | Q931_IE_BEARER_CAPABILITY:
+                               case CS0 | Q931_IE_LOW_LAYER_COMPAT:
                                        dissect_q931_bearer_capability_ie(tvb,
                                            offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_CAUSE:
+                               case CS0 | Q931_IE_CAUSE:
                                        dissect_q931_cause_ie(tvb,
                                            offset + 2, info_element_len,
-                                           ie_tree);
+                                           ie_tree,
+                                           hf_q931_cause_value);
                                        break;
 
-                               case Q931_IE_CALL_STATE:
+                               case CS0 | Q931_IE_CALL_STATE:
                                        dissect_q931_call_state_ie(tvb,
                                            offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_CHANNEL_IDENTIFICATION:
+                               case CS0 | Q931_IE_CHANNEL_IDENTIFICATION:
                                        dissect_q931_channel_identification_ie(
                                            tvb, offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_PROGRESS_INDICATOR:
+                               case CS0 | Q931_IE_PROGRESS_INDICATOR:
                                        dissect_q931_progress_indicator_ie(tvb,
                                            offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_NETWORK_SPECIFIC_FACIL:
-                               case Q931_IE_TRANSIT_NETWORK_SEL:
+                               case CS0 | Q931_IE_NETWORK_SPECIFIC_FACIL:
+                               case CS0 | Q931_IE_TRANSIT_NETWORK_SEL:
                                        dissect_q931_ns_facilities_ie(tvb,
                                            offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_NOTIFICATION_INDICATOR:
+                               case CS0 | Q931_IE_NOTIFICATION_INDICATOR:
                                        dissect_q931_notification_indicator_ie(
                                            tvb, offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_DISPLAY:
+                               case CS0 | Q931_IE_DISPLAY:
                                        dissect_q931_ia5_ie(tvb, offset + 2,
                                            info_element_len, ie_tree,
                                            "Display information");
                                        break;
 
-                               case Q931_IE_DATE_TIME:
+                               case CS0 | Q931_IE_DATE_TIME:
                                        dissect_q931_date_time_ie(tvb,
                                            offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_KEYPAD_FACILITY:
+                               case CS0 | Q931_IE_KEYPAD_FACILITY:
                                        dissect_q931_ia5_ie(tvb, offset + 2,
                                            info_element_len, ie_tree,
                                            "Keypad facility");
                                        break;
 
-                               case Q931_IE_SIGNAL:
+                               case CS0 | Q931_IE_SIGNAL:
                                        dissect_q931_signal_ie(tvb,
                                            offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_INFORMATION_RATE:
+                               case CS0 | Q931_IE_INFORMATION_RATE:
                                        dissect_q931_information_rate_ie(tvb,
                                            offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_E2E_TRANSIT_DELAY:
+                               case CS0 | Q931_IE_E2E_TRANSIT_DELAY:
                                        dissect_q931_e2e_transit_delay_ie(tvb,
                                            offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_TD_SELECTION_AND_INT:
+                               case CS0 | Q931_IE_TD_SELECTION_AND_INT:
                                        dissect_q931_td_selection_and_int_ie(
                                            tvb, offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_PL_BINARY_PARAMETERS:
+                               case CS0 | Q931_IE_PL_BINARY_PARAMETERS:
                                        dissect_q931_pl_binary_parameters_ie(
                                            tvb, offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_PL_WINDOW_SIZE:
+                               case CS0 | Q931_IE_PL_WINDOW_SIZE:
                                        dissect_q931_pl_window_size_ie(tvb,
                                            offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_PACKET_SIZE:
+                               case CS0 | Q931_IE_PACKET_SIZE:
                                        dissect_q931_packet_size_ie(tvb,
                                            offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_CUG:
+                               case CS0 | Q931_IE_CUG:
                                        dissect_q931_cug_ie(tvb,
                                            offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_REVERSE_CHARGE_IND:
+                               case CS0 | Q931_IE_REVERSE_CHARGE_IND:
                                        dissect_q931_reverse_charge_ind_ie(tvb,
                                            offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_CALLING_PARTY_NUMBER:
-                               case Q931_IE_CONNECTED_NUMBER_DEFAULT:
-                               case Q931_IE_CALLED_PARTY_NUMBER:
-                               case Q931_IE_REDIRECTING_NUMBER:
+                               case CS0 | Q931_IE_CALLING_PARTY_NUMBER:
+                                       e164_info.e164_number_type = CALLING_PARTY_NUMBER;
                                        dissect_q931_number_ie(tvb,
                                            offset + 2, info_element_len,
-                                           ie_tree);
+                                           ie_tree,
+                                           hf_q931_calling_party_number, e164_info);
+                                       break;
+
+                               case CS0 | Q931_IE_CONNECTED_NUMBER_DEFAULT:
+                                       dissect_q931_number_ie(tvb,
+                                           offset + 2, info_element_len,
+                                           ie_tree,
+                                           hf_q931_connected_number, e164_info);
+                                       break;
+
+                               case CS0 | Q931_IE_CALLED_PARTY_NUMBER:
+                                       e164_info.e164_number_type = CALLED_PARTY_NUMBER;
+                                       dissect_q931_number_ie(tvb,
+                                           offset + 2, info_element_len,
+                                           ie_tree,
+                                           hf_q931_called_party_number, e164_info);
+                                       break;
+
+                               case CS0 | Q931_IE_REDIRECTING_NUMBER:
+                                       dissect_q931_number_ie(tvb,
+                                           offset + 2, info_element_len,
+                                           ie_tree,
+                                           hf_q931_redirecting_number, e164_info);
                                        break;
 
-                               case Q931_IE_CALLING_PARTY_SUBADDR:
-                               case Q931_IE_CALLED_PARTY_SUBADDR:
+                               case CS0 | Q931_IE_CALLING_PARTY_SUBADDR:
+                               case CS0 | Q931_IE_CALLED_PARTY_SUBADDR:
                                        dissect_q931_party_subaddr_ie(tvb,
                                            offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_RESTART_INDICATOR:
+                               case CS0 | Q931_IE_RESTART_INDICATOR:
                                        dissect_q931_restart_indicator_ie(tvb,
                                            offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_HIGH_LAYER_COMPAT:
+                               case CS0 | Q931_IE_HIGH_LAYER_COMPAT:
                                        dissect_q931_high_layer_compat_ie(tvb,
                                            offset + 2, info_element_len,
                                            ie_tree);
                                        break;
 
-                               case Q931_IE_USER_USER:
+                               case CS0 | Q931_IE_USER_USER:
                                        dissect_q931_user_user_ie(tvb,
                                            offset + 2, info_element_len,
                                            ie_tree);
@@ -2486,8 +2876,7 @@ dissect_q931_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
                        }
                        offset += 1 + 1 + info_element_len;
                }
-               if (non_locking_shift)
-                       codeset = 0;
+               codeset = locked_codeset;
        }
 }
 
@@ -2576,50 +2965,192 @@ dissect_q931(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        dissect_q931_pdu(tvb, pinfo, tree, FALSE);
 }
 
+static void
+dissect_q931_ie_cs0(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
+{
+       dissect_q931_IEs(tvb, pinfo, NULL, tree, FALSE, 0, 0);
+}
+
+static void
+dissect_q931_ie_cs7(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
+{
+       dissect_q931_IEs(tvb, pinfo, NULL, tree, FALSE, 0, 7);
+}
+
+static void 
+q931_init(void) {
+       /* Initialize the fragment and reassembly tables */
+       fragment_table_init(&q931_fragment_table);
+       reassembled_table_init(&q931_reassembled_table);
+}
+
 void
 proto_register_q931(void)
 {
        static hf_register_info hf[] = {
                { &hf_q931_discriminator,
                  { "Protocol discriminator", "q931.disc", FT_UINT8, BASE_HEX, NULL, 0x0,
-                       "", HFILL }},
+                       "", HFILL }},
 
                { &hf_q931_call_ref_len,
                  { "Call reference value length", "q931.call_ref_len", FT_UINT8, BASE_DEC, NULL, 0x0,
-                       "", HFILL }},
+                       "", HFILL }},
+
+               { &hf_q931_call_ref_flag,
+                 { "Call reference flag", "q931.call_ref_flag", FT_BOOLEAN, BASE_NONE, TFS(&tfs_call_ref_flag), 0x0,
+                       "", HFILL }},
 
                { &hf_q931_call_ref,
                  { "Call reference value", "q931.call_ref", FT_BYTES, BASE_HEX, NULL, 0x0,
-                       "", HFILL }},
+                       "", HFILL }},
 
                { &hf_q931_message_type,
                  { "Message type", "q931.message_type", FT_UINT8, BASE_HEX, VALS(q931_message_type_vals), 0x0,
-                       "", HFILL }},
+                       "", HFILL }},
+
+               { &hf_q931_segment_type,
+                 { "Segmented message type", "q931.segment_type", FT_UINT8, BASE_HEX, VALS(q931_message_type_vals), 0x0,
+                       "", HFILL }},
+
+               { &hf_q931_coding_standard,
+                 { "Coding standard", "q931.coding_standard", FT_UINT8, BASE_HEX,
+                        VALS(q931_coding_standard_vals), 0x60,"", HFILL }},
+
+               { &hf_q931_information_transfer_capability,
+                 { "Information transfer capability", "q931.information_transfer_capability", FT_UINT8, BASE_HEX,
+                        VALS(q931_information_transfer_capability_vals), 0x1f,"", HFILL }},
+
+               { &hf_q931_transfer_mode,
+                 { "Transfer mode", "q931.transfer_mode", FT_UINT8, BASE_HEX,
+                        VALS(q931_transfer_mode_vals), 0x60,"", HFILL }},
+
+               { &hf_q931_information_transfer_rate,
+                 { "Information transfer rate", "q931.information_transfer_rate", FT_UINT8, BASE_HEX,
+                        VALS(q931_information_transfer_rate_vals), 0x1f,"", HFILL }},
+
+               { &hf_q931_uil1,
+                 { "User information layer 1 protocol", "q931.uil1", FT_UINT8, BASE_HEX,
+                        VALS(q931_uil1_vals), 0x1f,"", HFILL }},
+
+               { &hf_q931_cause_location,
+                 { "Cause location", "q931.cause_location", FT_UINT8, BASE_DEC, VALS(q931_cause_location_vals), 0x0f,
+                       "", HFILL }},
+
+               { &hf_q931_cause_value,
+                 { "Cause value", "q931.cause_value", FT_UINT8, BASE_DEC, VALS(q931_cause_code_vals), 0x7f,
+                       "", HFILL }},
+
+               { &hf_q931_number_type,
+                 { "Number type", "q931.number_type", FT_UINT8, BASE_HEX, VALS(q931_number_type_vals), 0x70,
+                       "", HFILL }},
+
+               { &hf_q931_numbering_plan,
+                 { "Numbering plan", "q931.numbering_plan", FT_UINT8, BASE_HEX, VALS(q931_numbering_plan_vals), 0x0f,
+                       "", HFILL }},
+
+               { &hf_q931_screening_ind,
+                 { "Screening indicator", "q931.screening_ind", FT_UINT8, BASE_HEX, VALS(q931_screening_indicator_vals), 0x03,
+                       "", HFILL }},
+
+               { &hf_q931_presentation_ind,
+                 { "Presentation indicator", "q931.presentation_ind", FT_UINT8, BASE_HEX, VALS(q931_presentation_indicator_vals), 0x60,
+                       "", HFILL }},
+
+               { &hf_q931_extension_ind,
+                 { "Extension indicator",  "q931.extension_ind",
+                       FT_BOOLEAN, 8, TFS(&q931_extension_ind_value), 0x80,
+                       "", HFILL }},
+
+               { &hf_q931_calling_party_number,
+                 { "Calling party number digits", "q931.calling_party_number.digits", FT_STRING, BASE_NONE, NULL, 0x0,
+                       "", HFILL }},
+
+               { &hf_q931_called_party_number,
+                 { "Called party number digits", "q931.called_party_number.digits", FT_STRING, BASE_NONE, NULL, 0x0,
+                       "", HFILL }},
+
+               { &hf_q931_connected_number,
+                 { "Connected party number digits", "q931.connected_number.digits", FT_STRING, BASE_NONE, NULL, 0x0,
+                       "", HFILL }},
+
+               { &hf_q931_redirecting_number,
+                 { "Redirecting party number digits", "q931.redirecting_number.digits", FT_STRING, BASE_NONE, NULL, 0x0,
+                       "", HFILL }},
+    /* desegmentation fields */
+               { &hf_q931_segment_overlap,
+                 { "Segment overlap", "q931.segment.overlap", FT_BOOLEAN, BASE_NONE, NULL, 0x0,
+                       "Fragment overlaps with other fragments", HFILL }},
+
+               { &hf_q931_segment_overlap_conflict,
+                 { "Conflicting data in fragment overlap", "q931.segment.overlap.conflict", FT_BOOLEAN, BASE_NONE, NULL, 0x0,
+                       "Overlapping fragments contained conflicting data", HFILL }},
+
+               { &hf_q931_segment_multiple_tails,
+                 { "Multiple tail fragments found", "q931.segment.multipletails", FT_BOOLEAN, BASE_NONE, NULL, 0x0,
+                       "Several tails were found when defragmenting the packet", HFILL }},
+
+               { &hf_q931_segment_too_long_segment,
+                 { "Segment too long", "q931.segment.toolongfragment", FT_BOOLEAN, BASE_NONE, NULL, 0x0,
+                       "Segment contained data past end of packet", HFILL }},
+
+               { &hf_q931_segment_error,
+                 { "Defragmentation error", "q931.segment.error", FT_FRAMENUM, BASE_NONE, NULL, 0x0,
+                       "Defragmentation error due to illegal fragments", HFILL }},
+
+               { &hf_q931_segment,
+                 { "Q.931 Segment", "q931.segment", FT_FRAMENUM, BASE_NONE, NULL, 0x0,
+                       "Q.931 Segment", HFILL }},
+
+               { &hf_q931_segments,
+                 { "Q.931 Segments", "q931.segments", FT_NONE, BASE_NONE, NULL, 0x0,
+                       "Q.931 Segments", HFILL }},
+
+               { &hf_q931_reassembled_in,
+                 { "Reassembled Q.931 in frame", "q931.reassembled_in", FT_FRAMENUM, BASE_NONE, NULL, 0x0,
+                       "This Q.931 message is reassembled in this frame", HFILL}}, 
        };
        static gint *ett[] = {
                &ett_q931,
                &ett_q931_ie,
+               &ett_q931_segments,
+               &ett_q931_segment,
        };
        module_t *q931_module;
 
        proto_q931 = proto_register_protocol("Q.931", "Q.931", "q931");
        proto_register_field_array (proto_q931, hf, array_length(hf));
        proto_register_subtree_array(ett, array_length(ett));
+       register_init_routine(q931_init);
 
        register_dissector("q931", dissect_q931, proto_q931);
        q931_tpkt_pdu_handle = create_dissector_handle(dissect_q931_tpkt_pdu,
            proto_q931);
+       register_dissector("q931.ie", dissect_q931_ie_cs0, proto_q931);
+       register_dissector("q931.ie.cs7", dissect_q931_ie_cs7, proto_q931);
+
+       /* subdissector code */ 
+       codeset_dissector_table = register_dissector_table("q931.codeset", "Q.931 Codeset", FT_UINT8, BASE_HEX);
+       ie_dissector_table = register_dissector_table("q931.ie", "Q.931 IE", FT_UINT16, BASE_HEX);
 
        q931_module = prefs_register_protocol(proto_q931, NULL);
        prefs_register_bool_preference(q931_module, "desegment_h323_messages",
            "Desegment all Q.931 messages spanning multiple TCP segments",
            "Whether the Q.931 dissector should desegment all messages spanning multiple TCP segments",
            &q931_desegment);
+       prefs_register_bool_preference(q931_module, "reassembly",
+           "Reassemble segmented Q.931 messages",
+           "Reassemble segmented Q.931 messages (Q.931 - Annex H)",
+           &q931_reassembly);
 }
 
 void
 proto_reg_handoff_q931(void)
 {
+       dissector_handle_t q931_handle;
+
+       q931_handle = find_dissector("q931");
+       dissector_add("lapd.sapi", LAPD_SAPI_Q931, q931_handle);
+
        /*
         * Attempt to get a handle for the H.225 dissector.
         * If we can't, the handle we get is null, and we'll just