Merge git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6

[sfrench/cifs-2.6.git] / net / xfrm / xfrm_input.c

diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c
index 8624cbdb2a1eea89627c3ee28e56b51c50cc87c8..62188c6a06ddc2d933f0ad88819f3d4f10479638 100644 (file)
--- a/net/xfrm/xfrm_input.c
+++ b/net/xfrm/xfrm_input.c
@@ -81,7 +81,6 @@ int xfrm_parse_spi(struct sk_buff *skb, u8 nexthdr, __be32 *spi, __be32 *seq)
        *seq = *(__be32*)(skb_transport_header(skb) + offset_seq);
        return 0;
 }
-EXPORT_SYMBOL(xfrm_parse_spi);
 
 int xfrm_prepare_input(struct xfrm_state *x, struct sk_buff *skb)
 {
@@ -110,7 +109,7 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type)
        if (encap_type < 0) {
                async = 1;
                x = xfrm_input_state(skb);
-               seq = XFRM_SKB_CB(skb)->seq;
+               seq = XFRM_SKB_CB(skb)->seq.input;
                goto resume;
        }
 
@@ -119,8 +118,10 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type)
                struct sec_path *sp;
 
                sp = secpath_dup(skb->sp);
-               if (!sp)
+               if (!sp) {
+                       XFRM_INC_STATS(LINUX_MIB_XFRMINERROR);
                        goto drop;
+               }
                if (skb->sp)
                        secpath_put(skb->sp);
                skb->sp = sp;
@@ -131,35 +132,50 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type)
        family = XFRM_SPI_SKB_CB(skb)->family;
 
        seq = 0;
-       if (!spi && (err = xfrm_parse_spi(skb, nexthdr, &spi, &seq)) != 0)
+       if (!spi && (err = xfrm_parse_spi(skb, nexthdr, &spi, &seq)) != 0) {
+               XFRM_INC_STATS(LINUX_MIB_XFRMINHDRERROR);
                goto drop;
+       }
 
        do {
-               if (skb->sp->len == XFRM_MAX_DEPTH)
+               if (skb->sp->len == XFRM_MAX_DEPTH) {
+                       XFRM_INC_STATS(LINUX_MIB_XFRMINBUFFERERROR);
                        goto drop;
+               }
 
                x = xfrm_state_lookup(daddr, spi, nexthdr, family);
-               if (x == NULL)
+               if (x == NULL) {
+                       XFRM_INC_STATS(LINUX_MIB_XFRMINNOSTATES);
+                       xfrm_audit_state_notfound(skb, family, spi, seq);
                        goto drop;
+               }
 
                skb->sp->xvec[skb->sp->len++] = x;
 
                spin_lock(&x->lock);
-               if (unlikely(x->km.state != XFRM_STATE_VALID))
+               if (unlikely(x->km.state != XFRM_STATE_VALID)) {
+                       XFRM_INC_STATS(LINUX_MIB_XFRMINSTATEINVALID);
                        goto drop_unlock;
+               }
 
-               if ((x->encap ? x->encap->encap_type : 0) != encap_type)
+               if ((x->encap ? x->encap->encap_type : 0) != encap_type) {
+                       XFRM_INC_STATS(LINUX_MIB_XFRMINSTATEMISMATCH);
                        goto drop_unlock;
+               }
 
-               if (x->props.replay_window && xfrm_replay_check(x, seq))
+               if (x->props.replay_window && xfrm_replay_check(x, skb, seq)) {
+                       XFRM_INC_STATS(LINUX_MIB_XFRMINSTATESEQERROR);
                        goto drop_unlock;
+               }
 
-               if (xfrm_state_check_expire(x))
+               if (xfrm_state_check_expire(x)) {
+                       XFRM_INC_STATS(LINUX_MIB_XFRMINSTATEEXPIRED);
                        goto drop_unlock;
+               }
 
                spin_unlock(&x->lock);
 
-               XFRM_SKB_CB(skb)->seq = seq;
+               XFRM_SKB_CB(skb)->seq.input = seq;
 
                nexthdr = x->type->input(x, skb);
 
@@ -169,8 +185,12 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type)
 resume:
                spin_lock(&x->lock);
                if (nexthdr <= 0) {
-                       if (nexthdr == -EBADMSG)
+                       if (nexthdr == -EBADMSG) {
+                               xfrm_audit_state_icvfail(x, skb,
+                                                        x->type->proto);
                                x->stats.integrity_failed++;
+                       }
+                       XFRM_INC_STATS(LINUX_MIB_XFRMINSTATEPROTOERROR);
                        goto drop_unlock;
                }
 
@@ -187,8 +207,10 @@ resume:
 
                XFRM_MODE_SKB_CB(skb)->protocol = nexthdr;
 
-               if (x->inner_mode->input(x, skb))
+               if (x->inner_mode->input(x, skb)) {
+                       XFRM_INC_STATS(LINUX_MIB_XFRMINSTATEMODEERROR);
                        goto drop;
+               }
 
                if (x->outer_mode->flags & XFRM_MODE_FLAG_TUNNEL) {
                        decaps = 1;
@@ -203,8 +225,10 @@ resume:
                family = x->outer_mode->afinfo->family;
 
                err = xfrm_parse_spi(skb, nexthdr, &spi, &seq);
-               if (err < 0)
+               if (err < 0) {
+                       XFRM_INC_STATS(LINUX_MIB_XFRMINHDRERROR);
                        goto drop;
+               }
        } while (!err);
 
        nf_reset(skb);