tipc: remove SS_CONNECTED sock state
[sfrench/cifs-2.6.git] / net / tipc / socket.c
index ce7d9be8833c583d0732e331621ba05677b8d51d..149396366e80402fbcfca436749a2489d3aae9a9 100644 (file)
 #define CONN_TIMEOUT_DEFAULT   8000    /* default connect timeout = 8s */
 #define CONN_PROBING_INTERVAL  msecs_to_jiffies(3600000)  /* [ms] => 1 h */
 #define TIPC_FWD_MSG           1
-#define TIPC_CONN_OK           0
-#define TIPC_CONN_PROBING      1
 #define TIPC_MAX_PORT          0xffffffff
 #define TIPC_MIN_PORT          1
 
 enum {
        TIPC_LISTEN = TCP_LISTEN,
+       TIPC_ESTABLISHED = TCP_ESTABLISHED,
+       TIPC_OPEN = TCP_CLOSE,
+       TIPC_DISCONNECTING = TCP_CLOSE_WAIT,
+       TIPC_CONNECTING = TCP_SYN_SENT,
 };
 
 /**
@@ -88,9 +90,9 @@ struct tipc_sock {
        struct list_head sock_list;
        struct list_head publications;
        u32 pub_count;
-       u32 probing_state;
        uint conn_timeout;
        atomic_t dupl_rcvcnt;
+       bool probe_unacked;
        bool link_cong;
        u16 snt_unacked;
        u16 snd_win;
@@ -292,7 +294,7 @@ static void tsk_rej_rx_queue(struct sock *sk)
 
 static bool tipc_sk_connected(struct sock *sk)
 {
-       return sk->sk_socket->state == SS_CONNECTED;
+       return sk->sk_state == TIPC_ESTABLISHED;
 }
 
 /* tipc_sk_type_connectionless - check if the socket is datagram socket
@@ -348,12 +350,26 @@ static bool tsk_peer_msg(struct tipc_sock *tsk, struct tipc_msg *msg)
  */
 static int tipc_set_sk_state(struct sock *sk, int state)
 {
-       int oldstate = sk->sk_socket->state;
+       int oldsk_state = sk->sk_state;
        int res = -EINVAL;
 
        switch (state) {
+       case TIPC_OPEN:
+               res = 0;
+               break;
        case TIPC_LISTEN:
-               if (oldstate == SS_UNCONNECTED)
+       case TIPC_CONNECTING:
+               if (oldsk_state == TIPC_OPEN)
+                       res = 0;
+               break;
+       case TIPC_ESTABLISHED:
+               if (oldsk_state == TIPC_CONNECTING ||
+                   oldsk_state == TIPC_OPEN)
+                       res = 0;
+               break;
+       case TIPC_DISCONNECTING:
+               if (oldsk_state == TIPC_CONNECTING ||
+                   oldsk_state == TIPC_ESTABLISHED)
                        res = 0;
                break;
        }
@@ -419,14 +435,15 @@ static int tipc_sk_create(struct net *net, struct socket *sock,
 
        /* Finish initializing socket data structures */
        sock->ops = ops;
-       sock->state = SS_UNCONNECTED;
        sock_init_data(sock, sk);
+       tipc_set_sk_state(sk, TIPC_OPEN);
        if (tipc_sk_insert(tsk)) {
                pr_warn("Socket create failed; port number exhausted\n");
                return -EINVAL;
        }
        msg_set_origport(msg, tsk->portid);
        setup_timer(&sk->sk_timer, tipc_sk_timeout, (unsigned long)tsk);
+       sk->sk_shutdown = 0;
        sk->sk_backlog_rcv = tipc_backlog_rcv;
        sk->sk_rcvbuf = sysctl_tipc_rmem[1];
        sk->sk_data_ready = tipc_data_ready;
@@ -444,6 +461,7 @@ static int tipc_sk_create(struct net *net, struct socket *sock,
                if (sock->type == SOCK_DGRAM)
                        tsk_set_unreliable(tsk, true);
        }
+
        return 0;
 }
 
@@ -454,6 +472,44 @@ static void tipc_sk_callback(struct rcu_head *head)
        sock_put(&tsk->sk);
 }
 
+/* Caller should hold socket lock for the socket. */
+static void __tipc_shutdown(struct socket *sock, int error)
+{
+       struct sock *sk = sock->sk;
+       struct tipc_sock *tsk = tipc_sk(sk);
+       struct net *net = sock_net(sk);
+       u32 dnode = tsk_peer_node(tsk);
+       struct sk_buff *skb;
+
+       /* Reject all unreceived messages, except on an active connection
+        * (which disconnects locally & sends a 'FIN+' to peer).
+        */
+       while ((skb = __skb_dequeue(&sk->sk_receive_queue)) != NULL) {
+               if (TIPC_SKB_CB(skb)->bytes_read) {
+                       kfree_skb(skb);
+               } else {
+                       if (!tipc_sk_type_connectionless(sk) &&
+                           sk->sk_state != TIPC_DISCONNECTING) {
+                               tipc_set_sk_state(sk, TIPC_DISCONNECTING);
+                               tipc_node_remove_conn(net, dnode, tsk->portid);
+                       }
+                       tipc_sk_respond(sk, skb, error);
+               }
+       }
+       if (sk->sk_state != TIPC_DISCONNECTING) {
+               skb = tipc_msg_create(TIPC_CRITICAL_IMPORTANCE,
+                                     TIPC_CONN_MSG, SHORT_H_SIZE, 0, dnode,
+                                     tsk_own_node(tsk), tsk_peer_port(tsk),
+                                     tsk->portid, error);
+               if (skb)
+                       tipc_node_xmit_skb(net, skb, dnode, tsk->portid);
+               if (!tipc_sk_type_connectionless(sk)) {
+                       tipc_node_remove_conn(net, dnode, tsk->portid);
+                       tipc_set_sk_state(sk, TIPC_DISCONNECTING);
+               }
+       }
+}
+
 /**
  * tipc_release - destroy a TIPC socket
  * @sock: socket to destroy
@@ -473,10 +529,7 @@ static void tipc_sk_callback(struct rcu_head *head)
 static int tipc_release(struct socket *sock)
 {
        struct sock *sk = sock->sk;
-       struct net *net;
        struct tipc_sock *tsk;
-       struct sk_buff *skb;
-       u32 dnode;
 
        /*
         * Exit if socket isn't fully initialized (occurs when a failed accept()
@@ -485,46 +538,16 @@ static int tipc_release(struct socket *sock)
        if (sk == NULL)
                return 0;
 
-       net = sock_net(sk);
        tsk = tipc_sk(sk);
        lock_sock(sk);
 
-       /*
-        * Reject all unreceived messages, except on an active connection
-        * (which disconnects locally & sends a 'FIN+' to peer)
-        */
-       dnode = tsk_peer_node(tsk);
-       while (sock->state != SS_DISCONNECTING) {
-               skb = __skb_dequeue(&sk->sk_receive_queue);
-               if (skb == NULL)
-                       break;
-               if (TIPC_SKB_CB(skb)->bytes_read)
-                       kfree_skb(skb);
-               else {
-                       if ((sock->state == SS_CONNECTING) ||
-                           (sock->state == SS_CONNECTED)) {
-                               sock->state = SS_DISCONNECTING;
-                               tipc_node_remove_conn(net, dnode, tsk->portid);
-                       }
-                       tipc_sk_respond(sk, skb, TIPC_ERR_NO_PORT);
-               }
-       }
-
+       __tipc_shutdown(sock, TIPC_ERR_NO_PORT);
+       sk->sk_shutdown = SHUTDOWN_MASK;
        tipc_sk_withdraw(tsk, 0, NULL);
        sk_stop_timer(sk, &sk->sk_timer);
        tipc_sk_remove(tsk);
-       if (tipc_sk_connected(sk)) {
-               skb = tipc_msg_create(TIPC_CRITICAL_IMPORTANCE,
-                                     TIPC_CONN_MSG, SHORT_H_SIZE, 0, dnode,
-                                     tsk_own_node(tsk), tsk_peer_port(tsk),
-                                     tsk->portid, TIPC_ERR_NO_PORT);
-               if (skb)
-                       tipc_node_xmit_skb(net, skb, dnode, tsk->portid);
-               tipc_node_remove_conn(net, dnode, tsk->portid);
-       }
 
        /* Reject any messages that accumulated in backlog queue */
-       sock->state = SS_DISCONNECTING;
        release_sock(sk);
 
        call_rcu(&tsk->rcu, tipc_sk_callback);
@@ -610,13 +633,14 @@ static int tipc_getname(struct socket *sock, struct sockaddr *uaddr,
                        int *uaddr_len, int peer)
 {
        struct sockaddr_tipc *addr = (struct sockaddr_tipc *)uaddr;
-       struct tipc_sock *tsk = tipc_sk(sock->sk);
+       struct sock *sk = sock->sk;
+       struct tipc_sock *tsk = tipc_sk(sk);
        struct tipc_net *tn = net_generic(sock_net(sock->sk), tipc_net_id);
 
        memset(addr, 0, sizeof(*addr));
        if (peer) {
-               if ((sock->state != SS_CONNECTED) &&
-                       ((peer != 2) || (sock->state != SS_DISCONNECTING)))
+               if ((!tipc_sk_connected(sk)) &&
+                   ((peer != 2) || (sk->sk_state != TIPC_DISCONNECTING)))
                        return -ENOTCONN;
                addr->addr.id.ref = tsk_peer_port(tsk);
                addr->addr.id.node = tsk_peer_node(tsk);
@@ -648,28 +672,6 @@ static int tipc_getname(struct socket *sock, struct sockaddr *uaddr,
  * exits.  TCP and other protocols seem to rely on higher level poll routines
  * to handle any preventable race conditions, so TIPC will do the same ...
  *
- * TIPC sets the returned events as follows:
- *
- * socket state                flags set
- * ------------                ---------
- * unconnected         no read flags
- *                     POLLOUT if port is not congested
- *
- * connecting          POLLIN/POLLRDNORM if ACK/NACK in rx queue
- *                     no write flags
- *
- * connected           POLLIN/POLLRDNORM if data in rx queue
- *                     POLLOUT if port is not congested
- *
- * disconnecting       POLLIN/POLLRDNORM/POLLHUP
- *                     no write flags
- *
- * listening           POLLIN if SYN in rx queue
- *                     no write flags
- *
- * ready               POLLIN/POLLRDNORM if data in rx queue
- * [connectionless]    POLLOUT (since port cannot be congested)
- *
  * IMPORTANT: The fact that a read or write operation is indicated does NOT
  * imply that the operation will succeed, merely that it should be performed
  * and will not block.
@@ -683,36 +685,29 @@ static unsigned int tipc_poll(struct file *file, struct socket *sock,
 
        sock_poll_wait(file, sk_sleep(sk), wait);
 
-       if (tipc_sk_type_connectionless(sk)) {
-               if (!tsk->link_cong)
-                       mask |= POLLOUT;
-               if (!skb_queue_empty(&sk->sk_receive_queue))
-                       mask |= (POLLIN | POLLRDNORM);
-               return mask;
-       }
+       if (sk->sk_shutdown & RCV_SHUTDOWN)
+               mask |= POLLRDHUP | POLLIN | POLLRDNORM;
+       if (sk->sk_shutdown == SHUTDOWN_MASK)
+               mask |= POLLHUP;
 
-       switch ((int)sock->state) {
-       case SS_UNCONNECTED:
-               switch (sk->sk_state) {
-               case TIPC_LISTEN:
-                       if (!skb_queue_empty(&sk->sk_receive_queue))
-                               mask |= (POLLIN | POLLRDNORM);
-                       break;
-               default:
-                       if (!tsk->link_cong)
-                               mask |= POLLOUT;
-                       break;
-               }
-               break;
-       case SS_CONNECTED:
+       switch (sk->sk_state) {
+       case TIPC_ESTABLISHED:
                if (!tsk->link_cong && !tsk_conn_cong(tsk))
                        mask |= POLLOUT;
                /* fall thru' */
-       case SS_CONNECTING:
+       case TIPC_LISTEN:
+       case TIPC_CONNECTING:
                if (!skb_queue_empty(&sk->sk_receive_queue))
                        mask |= (POLLIN | POLLRDNORM);
                break;
-       case SS_DISCONNECTING:
+       case TIPC_OPEN:
+               if (!tsk->link_cong)
+                       mask |= POLLOUT;
+               if (tipc_sk_type_connectionless(sk) &&
+                   (!skb_queue_empty(&sk->sk_receive_queue)))
+                       mask |= (POLLIN | POLLRDNORM);
+               break;
+       case TIPC_DISCONNECTING:
                mask = (POLLIN | POLLRDNORM | POLLHUP);
                break;
        }
@@ -858,7 +853,7 @@ static void tipc_sk_proto_rcv(struct tipc_sock *tsk, struct sk_buff *skb,
        if (!tsk_peer_msg(tsk, hdr))
                goto exit;
 
-       tsk->probing_state = TIPC_CONN_OK;
+       tsk->probe_unacked = false;
 
        if (mtyp == CONN_PROBE) {
                msg_set_type(hdr, CONN_PROBE_REPLY);
@@ -890,7 +885,7 @@ static int tipc_wait_for_sndmsg(struct socket *sock, long *timeo_p)
                int err = sock_error(sk);
                if (err)
                        return err;
-               if (sock->state == SS_DISCONNECTING)
+               if (sk->sk_shutdown & SEND_SHUTDOWN)
                        return -EPIPE;
                if (!*timeo_p)
                        return -EAGAIN;
@@ -961,7 +956,7 @@ static int __tipc_sendmsg(struct socket *sock, struct msghdr *m, size_t dsz)
        if (!is_connectionless) {
                if (sk->sk_state == TIPC_LISTEN)
                        return -EPIPE;
-               if (sock->state != SS_UNCONNECTED)
+               if (sk->sk_state != TIPC_OPEN)
                        return -EISCONN;
                if (tsk->published)
                        return -EOPNOTSUPP;
@@ -1014,7 +1009,7 @@ new_mtu:
                rc = tipc_node_xmit(net, &pktchain, dnode, tsk->portid);
                if (likely(!rc)) {
                        if (!is_connectionless)
-                               sock->state = SS_CONNECTING;
+                               tipc_set_sk_state(sk, TIPC_CONNECTING);
                        return dsz;
                }
                if (rc == -ELINKCONG) {
@@ -1045,9 +1040,9 @@ static int tipc_wait_for_sndpkt(struct socket *sock, long *timeo_p)
                int err = sock_error(sk);
                if (err)
                        return err;
-               if (sock->state == SS_DISCONNECTING)
+               if (sk->sk_state == TIPC_DISCONNECTING)
                        return -EPIPE;
-               else if (sock->state != SS_CONNECTED)
+               else if (!tipc_sk_connected(sk))
                        return -ENOTCONN;
                if (!*timeo_p)
                        return -EAGAIN;
@@ -1114,8 +1109,8 @@ static int __tipc_send_stream(struct socket *sock, struct msghdr *m, size_t dsz)
        if (dsz > (uint)INT_MAX)
                return -EMSGSIZE;
 
-       if (unlikely(sock->state != SS_CONNECTED)) {
-               if (sock->state == SS_DISCONNECTING)
+       if (unlikely(!tipc_sk_connected(sk))) {
+               if (sk->sk_state == TIPC_DISCONNECTING)
                        return -EPIPE;
                else
                        return -ENOTCONN;
@@ -1198,8 +1193,8 @@ static void tipc_sk_finish_conn(struct tipc_sock *tsk, u32 peer_port,
        msg_set_lookup_scope(msg, 0);
        msg_set_hdr_sz(msg, SHORT_H_SIZE);
 
-       tsk->probing_state = TIPC_CONN_OK;
        sk_reset_timer(sk, &sk->sk_timer, jiffies + CONN_PROBING_INTERVAL);
+       tipc_set_sk_state(sk, TIPC_ESTABLISHED);
        tipc_node_add_conn(net, peer_node, tsk->portid, peer_port);
        tsk->max_pkt = tipc_node_get_mtu(net, peer_node, tsk->portid);
        tsk->peer_caps = tipc_node_get_capabilities(net, peer_node);
@@ -1343,7 +1338,7 @@ static int tipc_wait_for_rcvmsg(struct socket *sock, long *timeop)
        for (;;) {
                prepare_to_wait(sk_sleep(sk), &wait, TASK_INTERRUPTIBLE);
                if (timeo && skb_queue_empty(&sk->sk_receive_queue)) {
-                       if (sock->state == SS_DISCONNECTING) {
+                       if (sk->sk_shutdown & RCV_SHUTDOWN) {
                                err = -ENOTCONN;
                                break;
                        }
@@ -1396,7 +1391,7 @@ static int tipc_recvmsg(struct socket *sock, struct msghdr *m, size_t buf_len,
 
        lock_sock(sk);
 
-       if (!is_connectionless && unlikely(sock->state == SS_UNCONNECTED)) {
+       if (!is_connectionless && unlikely(sk->sk_state == TIPC_OPEN)) {
                res = -ENOTCONN;
                goto exit;
        }
@@ -1493,7 +1488,7 @@ static int tipc_recv_stream(struct socket *sock, struct msghdr *m,
 
        lock_sock(sk);
 
-       if (unlikely(sock->state == SS_UNCONNECTED)) {
+       if (unlikely(sk->sk_state == TIPC_OPEN)) {
                res = -ENOTCONN;
                goto exit;
        }
@@ -1629,49 +1624,31 @@ static bool filter_connect(struct tipc_sock *tsk, struct sk_buff *skb)
 {
        struct sock *sk = &tsk->sk;
        struct net *net = sock_net(sk);
-       struct socket *sock = sk->sk_socket;
        struct tipc_msg *hdr = buf_msg(skb);
 
        if (unlikely(msg_mcast(hdr)))
                return false;
 
-       switch ((int)sock->state) {
-       case SS_CONNECTED:
-
-               /* Accept only connection-based messages sent by peer */
-               if (unlikely(!tsk_peer_msg(tsk, hdr)))
-                       return false;
-
-               if (unlikely(msg_errcode(hdr))) {
-                       sock->state = SS_DISCONNECTING;
-                       /* Let timer expire on it's own */
-                       tipc_node_remove_conn(net, tsk_peer_node(tsk),
-                                             tsk->portid);
-                       sk->sk_state_change(sk);
-               }
-               return true;
-
-       case SS_CONNECTING:
-
+       switch (sk->sk_state) {
+       case TIPC_CONNECTING:
                /* Accept only ACK or NACK message */
                if (unlikely(!msg_connected(hdr)))
                        return false;
 
                if (unlikely(msg_errcode(hdr))) {
-                       sock->state = SS_DISCONNECTING;
+                       tipc_set_sk_state(sk, TIPC_DISCONNECTING);
                        sk->sk_err = ECONNREFUSED;
                        return true;
                }
 
                if (unlikely(!msg_isdata(hdr))) {
-                       sock->state = SS_DISCONNECTING;
+                       tipc_set_sk_state(sk, TIPC_DISCONNECTING);
                        sk->sk_err = EINVAL;
                        return true;
                }
 
                tipc_sk_finish_conn(tsk, msg_origport(hdr), msg_orignode(hdr));
                msg_set_importance(&tsk->phdr, msg_importance(hdr));
-               sock->state = SS_CONNECTED;
 
                /* If 'ACK+' message, add to socket receive queue */
                if (msg_data_sz(hdr))
@@ -1685,17 +1662,31 @@ static bool filter_connect(struct tipc_sock *tsk, struct sk_buff *skb)
                msg_set_dest_droppable(hdr, 1);
                return false;
 
-       case SS_UNCONNECTED:
-
+       case TIPC_OPEN:
+       case TIPC_DISCONNECTING:
+               break;
+       case TIPC_LISTEN:
                /* Accept only SYN message */
                if (!msg_connected(hdr) && !(msg_errcode(hdr)))
                        return true;
                break;
-       case SS_DISCONNECTING:
-               break;
+       case TIPC_ESTABLISHED:
+               /* Accept only connection-based messages sent by peer */
+               if (unlikely(!tsk_peer_msg(tsk, hdr)))
+                       return false;
+
+               if (unlikely(msg_errcode(hdr))) {
+                       tipc_set_sk_state(sk, TIPC_DISCONNECTING);
+                       /* Let timer expire on it's own */
+                       tipc_node_remove_conn(net, tsk_peer_node(tsk),
+                                             tsk->portid);
+                       sk->sk_state_change(sk);
+               }
+               return true;
        default:
-               pr_err("Unknown socket state %u\n", sock->state);
+               pr_err("Unknown sk_state %u\n", sk->sk_state);
        }
+
        return false;
 }
 
@@ -1952,7 +1943,8 @@ static int tipc_wait_for_connect(struct socket *sock, long *timeo_p)
                        return sock_intr_errno(*timeo_p);
 
                prepare_to_wait(sk_sleep(sk), &wait, TASK_INTERRUPTIBLE);
-               done = sk_wait_event(sk, timeo_p, sock->state != SS_CONNECTING);
+               done = sk_wait_event(sk, timeo_p,
+                                    sk->sk_state != TIPC_CONNECTING);
                finish_wait(sk_sleep(sk), &wait);
        } while (!done);
        return 0;
@@ -1975,7 +1967,7 @@ static int tipc_connect(struct socket *sock, struct sockaddr *dest,
        struct sockaddr_tipc *dst = (struct sockaddr_tipc *)dest;
        struct msghdr m = {NULL,};
        long timeout = (flags & O_NONBLOCK) ? 0 : tsk->conn_timeout;
-       socket_state previous;
+       int previous;
        int res = 0;
 
        lock_sock(sk);
@@ -2003,9 +1995,10 @@ static int tipc_connect(struct socket *sock, struct sockaddr *dest,
                goto exit;
        }
 
-       previous = sock->state;
-       switch (sock->state) {
-       case SS_UNCONNECTED:
+       previous = sk->sk_state;
+
+       switch (sk->sk_state) {
+       case TIPC_OPEN:
                /* Send a 'SYN-' to destination */
                m.msg_name = dest;
                m.msg_namelen = destlen;
@@ -2020,27 +2013,29 @@ static int tipc_connect(struct socket *sock, struct sockaddr *dest,
                if ((res < 0) && (res != -EWOULDBLOCK))
                        goto exit;
 
-               /* Just entered SS_CONNECTING state; the only
+               /* Just entered TIPC_CONNECTING state; the only
                 * difference is that return value in non-blocking
                 * case is EINPROGRESS, rather than EALREADY.
                 */
                res = -EINPROGRESS;
-       case SS_CONNECTING:
-               if (previous == SS_CONNECTING)
-                       res = -EALREADY;
-               if (!timeout)
+               /* fall thru' */
+       case TIPC_CONNECTING:
+               if (!timeout) {
+                       if (previous == TIPC_CONNECTING)
+                               res = -EALREADY;
                        goto exit;
+               }
                timeout = msecs_to_jiffies(timeout);
                /* Wait until an 'ACK' or 'RST' arrives, or a timeout occurs */
                res = tipc_wait_for_connect(sock, &timeout);
                break;
-       case SS_CONNECTED:
+       case TIPC_ESTABLISHED:
                res = -EISCONN;
                break;
        default:
                res = -EINVAL;
-               break;
        }
+
 exit:
        release_sock(sk);
        return res;
@@ -2148,7 +2143,6 @@ static int tipc_accept(struct socket *sock, struct socket *new_sock, int flags)
 
        /* Connect new socket to it's peer */
        tipc_sk_finish_conn(new_tsock, msg_origport(msg), msg_orignode(msg));
-       new_sock->state = SS_CONNECTED;
 
        tsk_set_importance(new_tsock, msg_importance(msg));
        if (msg_named(msg)) {
@@ -2188,13 +2182,6 @@ exit:
 static int tipc_shutdown(struct socket *sock, int how)
 {
        struct sock *sk = sock->sk;
-       struct net *net = sock_net(sk);
-       struct tipc_sock *tsk = tipc_sk(sk);
-       struct sk_buff *skb;
-       u32 dnode = tsk_peer_node(tsk);
-       u32 dport = tsk_peer_port(tsk);
-       u32 onode = tipc_own_addr(net);
-       u32 oport = tsk->portid;
        int res;
 
        if (how != SHUT_RDWR)
@@ -2202,44 +2189,17 @@ static int tipc_shutdown(struct socket *sock, int how)
 
        lock_sock(sk);
 
-       switch (sock->state) {
-       case SS_CONNECTING:
-       case SS_CONNECTED:
-
-restart:
-               dnode = tsk_peer_node(tsk);
-
-               /* Disconnect and send a 'FIN+' or 'FIN-' message to peer */
-               skb = __skb_dequeue(&sk->sk_receive_queue);
-               if (skb) {
-                       if (TIPC_SKB_CB(skb)->bytes_read) {
-                               kfree_skb(skb);
-                               goto restart;
-                       }
-                       tipc_sk_respond(sk, skb, TIPC_CONN_SHUTDOWN);
-               } else {
-                       skb = tipc_msg_create(TIPC_CRITICAL_IMPORTANCE,
-                                             TIPC_CONN_MSG, SHORT_H_SIZE,
-                                             0, dnode, onode, dport, oport,
-                                             TIPC_CONN_SHUTDOWN);
-                       if (skb)
-                               tipc_node_xmit_skb(net, skb, dnode, tsk->portid);
-               }
-               sock->state = SS_DISCONNECTING;
-               tipc_node_remove_conn(net, dnode, tsk->portid);
-               /* fall through */
-
-       case SS_DISCONNECTING:
+       __tipc_shutdown(sock, TIPC_CONN_SHUTDOWN);
+       sk->sk_shutdown = SEND_SHUTDOWN;
 
+       if (sk->sk_state == TIPC_DISCONNECTING) {
                /* Discard any unreceived messages */
                __skb_queue_purge(&sk->sk_receive_queue);
 
                /* Wake up anyone sleeping in poll */
                sk->sk_state_change(sk);
                res = 0;
-               break;
-
-       default:
+       } else {
                res = -ENOTCONN;
        }
 
@@ -2263,9 +2223,9 @@ static void tipc_sk_timeout(unsigned long data)
        peer_port = tsk_peer_port(tsk);
        peer_node = tsk_peer_node(tsk);
 
-       if (tsk->probing_state == TIPC_CONN_PROBING) {
+       if (tsk->probe_unacked) {
                if (!sock_owned_by_user(sk)) {
-                       sk->sk_socket->state = SS_DISCONNECTING;
+                       tipc_set_sk_state(sk, TIPC_DISCONNECTING);
                        tipc_node_remove_conn(sock_net(sk), tsk_peer_node(tsk),
                                              tsk_peer_port(tsk));
                        sk->sk_state_change(sk);
@@ -2281,7 +2241,7 @@ static void tipc_sk_timeout(unsigned long data)
        skb = tipc_msg_create(CONN_MANAGER, CONN_PROBE,
                              INT_H_SIZE, 0, peer_node, own_node,
                              peer_port, tsk->portid, TIPC_OK);
-       tsk->probing_state = TIPC_CONN_PROBING;
+       tsk->probe_unacked = true;
        sk_reset_timer(sk, &sk->sk_timer, jiffies + CONN_PROBING_INTERVAL);
        bh_unlock_sock(sk);
        if (skb)