some more : try to make read/write not break the build if the return value is not...
[obnox/wireshark/wip.git] / gtk / dcerpc_stat.c
index d6a4f82e4652d96392d2ce9438d2d7be6a696828..f4aa3c6ddb3585e42c0c747c70ee12e5b0a28b17 100644 (file)
@@ -1,10 +1,10 @@
 /* dcerpc_stat.c
  * dcerpc_stat   2002 Ronnie Sahlberg
  *
- * $Id: dcerpc_stat.c,v 1.16 2003/09/05 10:26:44 sahlberg Exp $
+ * $Id$
  *
- * Ethereal - Network traffic analyzer
- * By Gerald Combs <gerald@ethereal.com>
+ * Wireshark - Network traffic analyzer
+ * By Gerald Combs <gerald@wireshark.org>
  * Copyright 1998 Gerald Combs
  * 
  * This program is free software; you can redistribute it and/or
@@ -22,9 +22,9 @@
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
  */
 
-/* This module provides rpc call/reply SRT statistics to ethereal,
+/* This module provides rpc call/reply SRT statistics to Wireshark,
  * and displays them graphically.
- * It is only used by ethereal and not tethereal
+ * It is only used by Wireshark and not tshark
  *
  * It serves as an example on how to use the tap api.
  */
 # include "config.h"
 #endif
 
+#include <string.h>
+
 #include <gtk/gtk.h>
-#include "menu.h"
-#include "epan/packet_info.h"
-#include "epan/filesystem.h"
+
+#include <epan/packet_info.h>
+#include <epan/epan.h>
+
+#include <epan/stat_cmd_args.h>
+#include "../stat_menu.h"
+#include "gui_stat_menu.h"
 #include "simple_dialog.h"
 #include "dlg_utils.h"
-#include "ui_util.h"
-#include "tap.h"
+#include "gui_utils.h"
+#include <epan/tap.h>
 #include "../register.h"
-#include "packet-dcerpc.h"
+#include <epan/dissectors/packet-dcerpc.h>
 #include "../globals.h"
+#include "filter_dlg.h"
 #include "compat_macros.h"
 #include "service_response_time_table.h"
+#include "gtkglobals.h"
 
 
-extern GtkWidget   *main_display_filter_widget;
-
 /* used to keep track of the statistics for an entire program interface */
 typedef struct _rpcstat_t {
        GtkWidget *win;
        srt_stat_table srt_table;
-       char *prog;
+       const char *prog;
        e_uuid_t uuid;
        guint16 ver;
        int num_procedures;
@@ -79,22 +85,42 @@ uuid_equal(e_uuid_t *uuid1, e_uuid_t *uuid2)
        }
        return 1;
 }
-       
+
+static char *
+dcerpcstat_gen_title(rpcstat_t *rs)
+{
+       char *title;
+
+       title = g_strdup_printf("DCE-RPC Service Response Time statistics for %s major version %u: %s", rs->prog, rs->ver, cf_get_display_name(&cfile));
+       return title;
+}
 
 static void
-dcerpcstat_reset(rpcstat_t *rs)
+dcerpcstat_set_title(rpcstat_t *rs)
 {
-       char title_string[256];
-       reset_srt_table_data(&rs->srt_table);
+       char *title;
 
-       snprintf(title_string, 255, "DCE-RPC Service Response Time statistics for %s version %d.%d : %s", rs->prog, rs->ver&0xff, rs->ver>>8, get_basename(cfile.filename));
-       gtk_window_set_title(GTK_WINDOW(rs->win), title_string);
+       title = dcerpcstat_gen_title(rs);
+       gtk_window_set_title(GTK_WINDOW(rs->win), title);
+       g_free(title);
+}
+
+static void
+dcerpcstat_reset(void *rs_arg)
+{
+       rpcstat_t *rs = rs_arg;
+
+       reset_srt_table_data(&rs->srt_table);
+       dcerpcstat_set_title(rs);
 }
 
 
 static int
-dcerpcstat_packet(rpcstat_t *rs, packet_info *pinfo, epan_dissect_t *edt _U_, dcerpc_info *ri)
+dcerpcstat_packet(void *rs_arg, packet_info *pinfo, epan_dissect_t *edt _U_, const void *ri_arg)
 {
+       rpcstat_t *rs = rs_arg;
+       const dcerpc_info *ri = ri_arg;
+
        if(!ri->call_data){
                return 0;
        }
@@ -108,7 +134,7 @@ dcerpcstat_packet(rpcstat_t *rs, packet_info *pinfo, epan_dissect_t *edt _U_, dc
        }
 
        /* we are only interested in reply packets */
-       if(ri->request){
+       if(ri->ptype != PDU_RESP){
                return 0;
        }
 
@@ -126,8 +152,10 @@ dcerpcstat_packet(rpcstat_t *rs, packet_info *pinfo, epan_dissect_t *edt _U_, dc
 }
 
 static void
-dcerpcstat_draw(rpcstat_t *rs)
+dcerpcstat_draw(void *rs_arg)
 {
+       rpcstat_t *rs = rs_arg;
+
        draw_srt_table_data(&rs->srt_table);
 }
 
@@ -158,23 +186,39 @@ win_destroy_cb(GtkWindow *win _U_, gpointer data)
 /* When called, this function will create a new instance of gtk-dcerpcstat.
  */
 static void
-gtk_dcerpcstat_init(char *optarg)
+gtk_dcerpcstat_init(const char *optarg, void* userdata _U_)
 {
        rpcstat_t *rs;
        guint32 i, max_procs;
-       char title_string[256];
+       char *title_string;
        char filter_string[256];
        GtkWidget *vbox;
        GtkWidget *stat_label;
        GtkWidget *filter_label;
+       GtkWidget *bbox;
+       GtkWidget *close_bt;
        dcerpc_sub_dissector *procs;
        e_uuid_t uuid;
-       int d1,d2,d3,d40,d41,d42,d43,d44,d45,d46,d47;
+       guint d1,d2,d3,d40,d41,d42,d43,d44,d45,d46,d47;
        int major, minor;
+       guint16 ver;
        int pos=0;
-        char *filter=NULL;
+        const char *filter=NULL;
         GString *error_string;
-
+       int hf_opnum;
+
+       /*
+        * XXX - DCE RPC statistics are maintained only by major version,
+        * not by major and minor version, so the minor version number is
+        * ignored.
+        *
+        * Should we just stop supporting minor version numbers here?
+        * Or should we allow it to be omitted?  Or should we keep
+        * separate statistics for different minor version numbers,
+        * and allow the minor version number to be omitted, and
+        * report aggregate statistics for all minor version numbers
+        * if it's omitted?
+        */
        if(sscanf(optarg,"dcerpc,srt,%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x,%d.%d,%n", &d1,&d2,&d3,&d40,&d41,&d42,&d43,&d44,&d45,&d46,&d47,&major,&minor,&pos)==13){
                uuid.Data1=d1;
                uuid.Data2=d2;
@@ -193,41 +237,47 @@ gtk_dcerpcstat_init(char *optarg)
                        filter=NULL;
                }
        } else {
-               fprintf(stderr, "ethereal: invalid \"-z dcerpc,srt,<uuid>,<major version>.<minor version>[,<filter>]\" argument\n");
+               fprintf(stderr, "wireshark: invalid \"-z dcerpc,srt,<uuid>,<major version>.<minor version>[,<filter>]\" argument\n");
                exit(1);
        }
-
+       if (major < 0 || major > 65535) {
+               fprintf(stderr,"wireshark: dcerpcstat_init() Major version number %d is invalid - must be positive and <= 65535\n", major);
+               exit(1);
+       }
+       if (minor < 0 || minor > 65535) {
+               fprintf(stderr,"wireshark: dcerpcstat_init() Minor version number %d is invalid - must be positive and <= 65535\n", minor);
+               exit(1);
+       }
+       ver = major;
 
        rs=g_malloc(sizeof(rpcstat_t));
-       rs->prog=dcerpc_get_proto_name(&uuid, (minor<<8)|(major&0xff) );
+       rs->prog=dcerpc_get_proto_name(&uuid, ver);
        if(!rs->prog){
                g_free(rs);
-               fprintf(stderr,"ethereal: dcerpcstat_init() Protocol with uuid:%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x v%d.%d not supported\n",uuid.Data1,uuid.Data2,uuid.Data3,uuid.Data4[0],uuid.Data4[1],uuid.Data4[2],uuid.Data4[3],uuid.Data4[4],uuid.Data4[5],uuid.Data4[6],uuid.Data4[7],major,minor);
+               fprintf(stderr,"wireshark: dcerpcstat_init() Protocol with uuid:%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x v%u not supported\n",uuid.Data1,uuid.Data2,uuid.Data3,uuid.Data4[0],uuid.Data4[1],uuid.Data4[2],uuid.Data4[3],uuid.Data4[4],uuid.Data4[5],uuid.Data4[6],uuid.Data4[7],ver);
                exit(1);
        }
-       procs=dcerpc_get_proto_sub_dissector(&uuid, (minor<<8)|(major&0xff) );
+       hf_opnum=dcerpc_get_proto_hf_opnum(&uuid, ver);
+       procs=dcerpc_get_proto_sub_dissector(&uuid, ver);
        rs->uuid=uuid;
-       rs->ver=(minor<<8)|(major&0xff);
+       rs->ver=ver;
 
-       rs->win=gtk_window_new(GTK_WINDOW_TOPLEVEL);
+       rs->win=window_new(GTK_WINDOW_TOPLEVEL, "dcerpc-stat");
+       dcerpcstat_set_title(rs);
        gtk_window_set_default_size(GTK_WINDOW(rs->win), 550, 400);
-       snprintf(title_string, 255, "DCE-RPC Service Response Time statistics for %s version %d.%d : %s", rs->prog, rs->ver&0xff, rs->ver>>8, get_basename(cfile.filename));
-       gtk_window_set_title(GTK_WINDOW(rs->win), title_string);
-       SIGNAL_CONNECT(rs->win, "destroy", win_destroy_cb, rs);
 
-       vbox=gtk_vbox_new(FALSE, 0);
+       vbox=gtk_vbox_new(FALSE, 3);
        gtk_container_add(GTK_CONTAINER(rs->win), vbox);
-       gtk_container_set_border_width(GTK_CONTAINER(vbox), 10);
-       gtk_widget_show(vbox);
+       gtk_container_set_border_width(GTK_CONTAINER(vbox), 12);
 
+       title_string=dcerpcstat_gen_title(rs);
        stat_label=gtk_label_new(title_string);
+       g_free(title_string);
        gtk_box_pack_start(GTK_BOX(vbox), stat_label, FALSE, FALSE, 0);
-       gtk_widget_show(stat_label);
 
-       snprintf(filter_string,255,"Filter:%s",filter?filter:"");
+       g_snprintf(filter_string,255,"Filter:%s",filter?filter:"");
        filter_label=gtk_label_new(filter_string);
        gtk_box_pack_start(GTK_BOX(vbox), filter_label, FALSE, FALSE, 0);
-       gtk_widget_show(filter_label);
 
        for(i=0,max_procs=0;procs[i].name;i++){
                if(procs[i].num>max_procs){
@@ -237,13 +287,17 @@ gtk_dcerpcstat_init(char *optarg)
        rs->num_procedures=max_procs+1;
 
        /* We must display TOP LEVEL Widget before calling init_srt_table() */
-       gtk_widget_show(rs->win);
+       gtk_widget_show_all(rs->win);
 
-       init_srt_table(&rs->srt_table, max_procs+1, vbox, NULL);
+       if(hf_opnum!=-1){
+               init_srt_table(&rs->srt_table, max_procs+1, vbox, proto_registrar_get_nth(hf_opnum)->abbrev);
+       } else {
+               init_srt_table(&rs->srt_table, max_procs+1, vbox, NULL);
+       }
 
                for(i=0;i<(max_procs+1);i++){
                int j;
-               char *proc_name;
+               const char *proc_name;
 
                proc_name="unknown";
                for(j=0;procs[j].name;j++){
@@ -256,32 +310,40 @@ gtk_dcerpcstat_init(char *optarg)
        }
 
 
-       error_string=register_tap_listener("dcerpc", rs, filter, (void*)dcerpcstat_reset, (void*)dcerpcstat_packet, (void*)dcerpcstat_draw);
+       error_string=register_tap_listener("dcerpc", rs, filter, dcerpcstat_reset, dcerpcstat_packet, dcerpcstat_draw);
        if(error_string){
                /* error, we failed to attach to the tap. clean up */
-               simple_dialog(ESD_TYPE_WARN, NULL, error_string->str);
+               simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK, error_string->str);
                g_string_free(error_string, TRUE);
                free_srt_table_data(&rs->srt_table);
                g_free(rs);
                return;
        }
 
+       /* Button row. */
+       bbox = dlg_button_row_new(GTK_STOCK_CLOSE, NULL);
+       gtk_box_pack_end(GTK_BOX(vbox), bbox, FALSE, FALSE, 0);
+
+       close_bt = OBJECT_GET_DATA(bbox, GTK_STOCK_CLOSE);
+       window_set_cancel_button(rs->win, close_bt, window_cancel_button_cb);
+
+       SIGNAL_CONNECT(rs->win, "delete_event", window_delete_event_cb, NULL);
+       SIGNAL_CONNECT(rs->win, "destroy", win_destroy_cb, rs);
 
        gtk_widget_show_all(rs->win);
-       redissect_packets(&cfile);
+       window_present(rs->win);
+
+       cf_retap_packets(&cfile, FALSE);
 }
 
 
 
 static e_uuid_t *dcerpc_uuid_program=NULL;
 static guint16 dcerpc_version;
-static GtkWidget *dlg=NULL, *dlg_box;
-static GtkWidget *prog_box;
-static GtkWidget *prog_label, *prog_opt, *prog_menu;
-static GtkWidget *vers_label, *vers_opt, *vers_menu;
-static GtkWidget *filter_box;
-static GtkWidget *filter_label, *filter_entry;
-static GtkWidget *start_button;
+static GtkWidget *dlg=NULL;
+static GtkWidget *prog_menu;
+static GtkWidget *vers_opt, *vers_menu;
+static GtkWidget *filter_entry;
 static dcerpc_uuid_key *current_uuid_key=NULL;
 static dcerpc_uuid_value *current_uuid_value=NULL;
 static dcerpc_uuid_key *new_uuid_key=NULL;
@@ -291,18 +353,26 @@ static dcerpc_uuid_value *new_uuid_value=NULL;
 static void
 dcerpcstat_start_button_clicked(GtkWidget *item _U_, gpointer data _U_)
 {
-       char *filter;
-       char str[256];
-
-       filter=(char *)gtk_entry_get_text(GTK_ENTRY(filter_entry));
-       if(filter[0]==0){
-               sprintf(str, "dcerpc,srt,%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x,%d.%d",dcerpc_uuid_program->Data1,dcerpc_uuid_program->Data2,dcerpc_uuid_program->Data3,dcerpc_uuid_program->Data4[0],dcerpc_uuid_program->Data4[1],dcerpc_uuid_program->Data4[2],dcerpc_uuid_program->Data4[3],dcerpc_uuid_program->Data4[4],dcerpc_uuid_program->Data4[5],dcerpc_uuid_program->Data4[6],dcerpc_uuid_program->Data4[7],dcerpc_version&0xff,dcerpc_version>>8);
-
-       } else {
-               sprintf(str, "dcerpc,srt,%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x,%d.%d,%s",dcerpc_uuid_program->Data1,dcerpc_uuid_program->Data2,dcerpc_uuid_program->Data3,dcerpc_uuid_program->Data4[0],dcerpc_uuid_program->Data4[1],dcerpc_uuid_program->Data4[2],dcerpc_uuid_program->Data4[3],dcerpc_uuid_program->Data4[4],dcerpc_uuid_program->Data4[5],dcerpc_uuid_program->Data4[6],dcerpc_uuid_program->Data4[7],dcerpc_version&0xff,dcerpc_version>>8, filter);
+       GString *str;
+       const char *filter;
+
+       str = g_string_new("dcerpc,srt");
+       g_string_sprintfa(str,
+           ",%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x,%u.%u",
+           dcerpc_uuid_program->Data1, dcerpc_uuid_program->Data2,
+           dcerpc_uuid_program->Data3,
+           dcerpc_uuid_program->Data4[0], dcerpc_uuid_program->Data4[1],
+           dcerpc_uuid_program->Data4[2], dcerpc_uuid_program->Data4[3],
+           dcerpc_uuid_program->Data4[4], dcerpc_uuid_program->Data4[5],
+           dcerpc_uuid_program->Data4[6], dcerpc_uuid_program->Data4[7],
+           dcerpc_version, 0);
+       filter=gtk_entry_get_text(GTK_ENTRY(filter_entry));
+       if(filter[0]!=0){
+               g_string_sprintfa(str, ",%s", filter);
        }
 
-       gtk_dcerpcstat_init(str);
+       gtk_dcerpcstat_init(str->str,NULL);
+       g_string_free(str, TRUE);
 }
 
 
@@ -328,7 +398,7 @@ dcerpcstat_find_vers(gpointer *key, gpointer *value _U_, gpointer *user_data _U_
                return NULL;
        }
 
-       sprintf(vs,"%d.%d",k->ver&0xff,k->ver>>8);
+       g_snprintf(vs, 5, "%u",k->ver);
        menu_item=gtk_menu_item_new_with_label(vs);
        SIGNAL_CONNECT(menu_item, "activate", dcerpcstat_version_select,
                        ((int)k->ver));
@@ -359,16 +429,51 @@ dcerpcstat_program_select(GtkWidget *item _U_, gpointer key)
 }
 
 
+static GtkWidget *program_submenu_menu;
+static GtkWidget *program_submenu_item;
+static GtkWidget *program_submenu_label;
+static int program_subitem_index;
+static const char *first_menu_name;
 static void 
 dcerpcstat_add_program_to_menu(dcerpc_uuid_key *k, dcerpc_uuid_value *v)
 {
        GtkWidget *program_menu_item;
+       GtkWidget *box;
+       char str[64];
+
+       switch(program_subitem_index%15){
+       case 0:
+
+               first_menu_name=v->name;
+               g_snprintf(str,63,"%s ...",v->name);
+               program_submenu_item=gtk_menu_item_new();
+               box=gtk_hbox_new(TRUE,0);
+               gtk_container_add(GTK_CONTAINER(program_submenu_item), box);
+               
+               program_submenu_label=gtk_label_new(str);
+               gtk_box_pack_start(GTK_BOX(box), program_submenu_label, TRUE, TRUE, 0);
+               gtk_widget_show(program_submenu_label);
+               gtk_widget_show(box);
+
+               gtk_menu_append(GTK_MENU(prog_menu), program_submenu_item);
+               gtk_widget_show(program_submenu_item);
+
+               program_submenu_menu=gtk_menu_new();
+               gtk_menu_item_set_submenu(GTK_MENU_ITEM(program_submenu_item), program_submenu_menu);
+               break;
+       case 14:
+               g_snprintf(str,63,"%s - %s",first_menu_name,v->name);
+               gtk_label_set_text(GTK_LABEL(program_submenu_label), str);
+               break;
+/*qqq*/
+       }
+       program_subitem_index++;                
 
        program_menu_item=gtk_menu_item_new_with_label(v->name);
        SIGNAL_CONNECT(program_menu_item, "activate", dcerpcstat_program_select, k);
 
        gtk_widget_show(program_menu_item);
-       gtk_menu_append(GTK_MENU(prog_menu), program_menu_item);
+       gtk_menu_append(GTK_MENU(program_submenu_menu), program_menu_item);
 
        if(!dcerpc_uuid_program){
                dcerpc_uuid_program=&k->uuid;
@@ -433,18 +538,21 @@ dlg_destroy_cb(void)
 }
 
 
-static void
-dlg_cancel_cb(GtkWidget *cancel_bt _U_, gpointer parent_w)
-{
-       gtk_widget_destroy(GTK_WIDGET(parent_w));
-}
-
-
 static void
 gtk_dcerpcstat_cb(GtkWidget *w _U_, gpointer d _U_)
 {
-       GtkWidget *bbox, *cancel_button;
-       char *filter;
+       GtkWidget *dlg_box;
+       GtkWidget *prog_box, *prog_label, *prog_opt;
+       GtkWidget *vers_label;
+       GtkWidget *filter_box, *filter_bt;
+       GtkWidget *bbox, *start_button, *cancel_button;
+       const char *filter;
+       static construct_args_t args = {
+         "Service Response Time Statistics Filter",
+         FALSE,
+         FALSE,
+      FALSE
+       };
 
        /* if the window is already open, bring it to front and
           un-minimize it, as necessary */
@@ -453,14 +561,17 @@ gtk_dcerpcstat_cb(GtkWidget *w _U_, gpointer d _U_)
                return;
        }
 
-       dlg=dlg_window_new("Ethereal: DCE-RPC SRT Statistics");
-       SIGNAL_CONNECT(dlg, "destroy", dlg_destroy_cb, NULL);
-       dlg_box=gtk_vbox_new(FALSE, 0);
+       dlg=dlg_window_new("Wireshark: Compute DCE-RPC SRT statistics");
+       gtk_window_set_default_size(GTK_WINDOW(dlg), 400, -1);
+
+       dlg_box=gtk_vbox_new(FALSE, 10);
+       gtk_container_border_width(GTK_CONTAINER(dlg_box), 10);
        gtk_container_add(GTK_CONTAINER(dlg), dlg_box);
        gtk_widget_show(dlg_box);
 
+       /* Program box */
+       prog_box=gtk_hbox_new(FALSE, 3);
 
-       prog_box=gtk_hbox_new(FALSE, 10);
        /* Program label */
        gtk_container_set_border_width(GTK_CONTAINER(prog_box), 10);
        prog_label=gtk_label_new("Program:");
@@ -472,6 +583,10 @@ gtk_dcerpcstat_cb(GtkWidget *w _U_, gpointer d _U_)
        prog_menu=gtk_menu_new();
        current_uuid_key=NULL;
        current_uuid_value=NULL;
+/*qqq*/
+       program_submenu_item=NULL;
+       program_submenu_menu=NULL;
+       program_subitem_index=0;
        do {
                new_uuid_key=NULL;
                new_uuid_value=NULL;
@@ -483,7 +598,6 @@ gtk_dcerpcstat_cb(GtkWidget *w _U_, gpointer d _U_)
                current_uuid_value=new_uuid_value;
        } while(new_uuid_key!=NULL);
 
-
        gtk_option_menu_set_menu(GTK_OPTION_MENU(prog_opt), prog_menu);
        gtk_box_pack_start(GTK_BOX(prog_box), prog_opt, TRUE, TRUE, 0);
        gtk_widget_show(prog_opt);
@@ -506,17 +620,19 @@ gtk_dcerpcstat_cb(GtkWidget *w _U_, gpointer d _U_)
        gtk_box_pack_start(GTK_BOX(dlg_box), prog_box, TRUE, TRUE, 0);
        gtk_widget_show(prog_box);
 
+       /* Filter box */
+       filter_box=gtk_hbox_new(FALSE, 3);
 
-       /* filter box */
-       filter_box=gtk_hbox_new(FALSE, 10);
        /* Filter label */
-       gtk_container_set_border_width(GTK_CONTAINER(filter_box), 10);
-       filter_label=gtk_label_new("Filter:");
-       gtk_box_pack_start(GTK_BOX(filter_box), filter_label, FALSE, FALSE, 0);
-       gtk_widget_show(filter_label);
-
-       filter_entry=gtk_entry_new_with_max_length(250);
-       gtk_box_pack_start(GTK_BOX(filter_box), filter_entry, FALSE, FALSE, 0);
+       filter_bt=BUTTON_NEW_FROM_STOCK(WIRESHARK_STOCK_DISPLAY_FILTER_ENTRY);
+       SIGNAL_CONNECT(filter_bt, "clicked", display_filter_construct_cb, &args);
+       gtk_box_pack_start(GTK_BOX(filter_box), filter_bt, FALSE, FALSE, 0);
+       gtk_widget_show(filter_bt);
+
+       /* Filter entry */
+       filter_entry=gtk_entry_new();
+    SIGNAL_CONNECT(filter_entry, "changed", filter_te_syntax_check_cb, NULL);
+       gtk_box_pack_start(GTK_BOX(filter_box), filter_entry, TRUE, TRUE, 0);
        filter=gtk_entry_get_text(GTK_ENTRY(main_display_filter_widget));
        if(filter){
                gtk_entry_set_text(GTK_ENTRY(filter_entry), filter);
@@ -526,31 +642,22 @@ gtk_dcerpcstat_cb(GtkWidget *w _U_, gpointer d _U_)
        gtk_box_pack_start(GTK_BOX(dlg_box), filter_box, TRUE, TRUE, 0);
        gtk_widget_show(filter_box);
 
+       OBJECT_SET_DATA(filter_bt, E_FILT_TE_PTR_KEY, filter_entry);
 
-       bbox=gtk_hbutton_box_new();
-       gtk_button_box_set_layout (GTK_BUTTON_BOX (bbox), GTK_BUTTONBOX_END);
-       gtk_button_box_set_spacing(GTK_BUTTON_BOX(bbox), 5);
-       gtk_container_add(GTK_CONTAINER(dlg_box), bbox);
-       gtk_widget_show(bbox);
+       /* button box */
+    bbox = dlg_button_row_new(WIRESHARK_STOCK_CREATE_STAT, GTK_STOCK_CANCEL, NULL);
+       gtk_box_pack_start(GTK_BOX(dlg_box), bbox, FALSE, FALSE, 0);
+    gtk_widget_show(bbox);
 
-       /* the start button */
-       start_button=gtk_button_new_with_label("Create Stat");
+    start_button = OBJECT_GET_DATA(bbox, WIRESHARK_STOCK_CREATE_STAT);
        SIGNAL_CONNECT_OBJECT(start_button, "clicked", 
                               dcerpcstat_start_button_clicked, NULL);
-       GTK_WIDGET_SET_FLAGS(start_button, GTK_CAN_DEFAULT);
-       gtk_box_pack_start(GTK_BOX(bbox), start_button, TRUE, TRUE, 0);
-       gtk_widget_grab_default(start_button);
-       gtk_widget_show(start_button);
-
-#if GTK_MAJOR_VERSION < 2
-       cancel_button=gtk_button_new_with_label("Cancel");
-#else
-       cancel_button=gtk_button_new_from_stock(GTK_STOCK_CANCEL);
-#endif
-       SIGNAL_CONNECT(cancel_button, "clicked", dlg_cancel_cb, dlg);
-       GTK_WIDGET_SET_FLAGS(cancel_button, GTK_CAN_DEFAULT);
-       gtk_box_pack_start(GTK_BOX(bbox), cancel_button, TRUE, TRUE, 0);
-       gtk_widget_show(cancel_button);
+
+    cancel_button = OBJECT_GET_DATA(bbox, GTK_STOCK_CANCEL);
+    window_set_cancel_button(dlg, cancel_button, window_cancel_button_cb);
+
+    SIGNAL_CONNECT(dlg, "delete_event", window_delete_event_cb, NULL);
+       SIGNAL_CONNECT(dlg, "destroy", dlg_destroy_cb, NULL);
 
        /* Catch the "activate" signal on the filter text entry, so that
           if the user types Return there, we act as if the "Create Stat"
@@ -559,25 +666,20 @@ gtk_dcerpcstat_cb(GtkWidget *w _U_, gpointer d _U_)
           focus. */
        dlg_set_activate(filter_entry, start_button);
 
-       /* Catch the "key_press_event" signal in the window, so that we can
-          catch the ESC key being pressed and act as if the "Cancel" button
-          had been selected. */
-       dlg_set_cancel(dlg, cancel_button);
+    gtk_widget_grab_default(start_button );
 
        /* Give the initial focus to the "Filter" entry box. */
        gtk_widget_grab_focus(filter_entry);
 
        gtk_widget_show_all(dlg);
+    window_present(dlg);
 }
 
 void
 register_tap_listener_gtkdcerpcstat(void)
 {
-       register_ethereal_tap("dcerpc,srt,", gtk_dcerpcstat_init);
-}
+       register_stat_cmd_arg("dcerpc,srt,", gtk_dcerpcstat_init,NULL);
 
-void
-register_tap_menu_gtkdcerpcstat(void)
-{
-       register_tap_menu_item("Service Response Time/DCE-RPC", gtk_dcerpcstat_cb);
+       register_stat_menu_item("DCE-RPC...", REGISTER_STAT_GROUP_RESPONSE_TIME,
+           gtk_dcerpcstat_cb, NULL, NULL, NULL);
 }