bugfix to a bug reported by Ian Schorr:
[obnox/wireshark/wip.git] / file.c
diff --git a/file.c b/file.c
index ded562f73fc7973115fabe43c67fb787c644a3d1..24f46b810061462e73c2090c37bdfa3c3e5bd84f 100644 (file)
--- a/file.c
+++ b/file.c
@@ -1,7 +1,7 @@
 /* file.c
  * File I/O routines
  *
- * $Id: file.c,v 1.376 2004/04/20 22:34:08 ulfl Exp $
+ * $Id: file.c,v 1.389 2004/07/08 11:07:29 guy Exp $
  *
  * Ethereal - Network traffic analyzer
  * By Gerald Combs <gerald@ethereal.com>
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
  */
 
+/* With MSVC and a libethereal.dll this file needs to import some variables 
+   in a special way. Therefore _NEED_VAR_IMPORT_ is defined. */
+#define _NEED_VAR_IMPORT_
+
 #ifdef HAVE_CONFIG_H
 # include "config.h"
 #endif
 #include "tap_dfilter_dlg.h"
 #include "packet-data.h"
 
+/* Win32 needs the O_BINARY flag for open() */
+#ifndef O_BINARY
+#define O_BINARY       0
+#endif
+
 #ifdef HAVE_LIBPCAP
 gboolean auto_scroll_live;
 #endif
@@ -131,15 +140,6 @@ static   gboolean copy_binary_file(char *from_filename, char *to_filename);
    XXX - is this the right number? */
 #define        FRAME_DATA_CHUNK_SIZE   1024
 
-typedef struct {
-       int             level;
-       FILE            *fh;
-       GSList          *src_list;
-       gboolean        print_all_levels;
-       gboolean        print_hex_for_data;
-       char_enc        encoding;
-       gint            format;         /* text or PostScript */
-} print_data;
 
 int
 cf_open(char *fname, gboolean is_tempfile, capture_file *cf)
@@ -288,6 +288,8 @@ cf_close(capture_file *cf)
   set_menus_for_capture_in_progress(FALSE);
   set_menus_for_selected_tree_row(cf);
 
+  reset_tap_listeners();
+
   /* We have no file open. */
   cf->state = FILE_CLOSED;
 }
@@ -381,10 +383,6 @@ cf_read(capture_file *cf)
      bump that value by this amount. */
   progbar_quantum = cf->f_len/N_PROGBAR_UPDATES;
 
-#ifndef O_BINARY
-#define O_BINARY       0
-#endif
-
   packet_list_freeze();
 
   stop_flag = FALSE;
@@ -490,7 +488,10 @@ cf_read(capture_file *cf)
     switch (err) {
 
     case WTAP_ERR_UNSUPPORTED_ENCAP:
-      errmsg = "The capture file is for a network type that Ethereal doesn't support.";
+      snprintf(errmsg_errno, sizeof(errmsg_errno),
+               "The capture file has a packet with a network type that Ethereal doesn't support.\n(%s)",
+               err_info);
+      errmsg = errmsg_errno;
       break;
 
     case WTAP_ERR_CANT_READ:
@@ -988,13 +989,18 @@ filter_packets(capture_file *cf, gchar *dftext, gboolean force)
     dftext = g_strdup(dftext);
     if (!dfilter_compile(dftext, &dfcode)) {
       /* The attempt failed; report an error. */
+      gchar *safe_dftext = simple_dialog_format_message(dftext);
+      gchar *safe_dfilter_error_msg = simple_dialog_format_message(
+         dfilter_error_msg);
       simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK, 
           "%s%s%s\n"
           "\n"
-          "The display filter \"%s\" is not a valid display filter.\n"
+          "The following display filter is not a valid display filter:\n%s\n"
           "See the help for a description of the display filter syntax.",
-          simple_dialog_primary_start(), dfilter_error_msg,
-          simple_dialog_primary_end(), dftext);
+          simple_dialog_primary_start(), safe_dfilter_error_msg,
+          simple_dialog_primary_end(), safe_dftext);
+      g_free(safe_dfilter_error_msg);
+      g_free(safe_dftext);
       g_free(dftext);
       return FALSE;
     }
@@ -1419,6 +1425,7 @@ process_specified_packets(capture_file *cf, packet_range_t *range,
       ret = PSP_FAILED;
       break;
     }
+    /* Process the packet */
     if (!callback(cf, fdata, &pseudo_header, pd, callback_args)) {
       /* Callback failed.  We assume it reported the error appropriately. */
       ret = PSP_FAILED;
@@ -1491,6 +1498,7 @@ typedef struct {
   gboolean      print_header_line;
   char         *header_line_buf;
   int           header_line_buf_len;
+  gboolean      print_formfeed;
   gboolean      print_separator;
   char         *line_buf;
   int           line_buf_len;
@@ -1511,17 +1519,27 @@ print_packet(capture_file *cf, frame_data *fdata,
   int             cp_off;
   gboolean        proto_tree_needed;
 
+  /* Create the protocol tree, and make it visible, if we're printing
+     the dissection or the hex data.
+     XXX - do we need it if we're just printing the hex data? */
   proto_tree_needed = 
       args->print_args->print_dissections != print_dissections_none || args->print_args->print_hex;
-
-  /* Fill in the column information, but don't bother creating
-     the logical protocol tree. */
   edt = epan_dissect_new(proto_tree_needed, proto_tree_needed);
-  epan_dissect_run(edt, pseudo_header, pd, fdata, &cf->cinfo);
-  epan_dissect_fill_in_columns(edt);
 
-  if (args->print_separator)
-    print_line(args->print_fh, 0, args->print_args->format, "");
+  /* Fill in the column information if we're printing the summary
+     information. */
+  if (args->print_args->print_summary) {
+    epan_dissect_run(edt, pseudo_header, pd, fdata, &cf->cinfo);
+    epan_dissect_fill_in_columns(edt);
+  } else
+    epan_dissect_run(edt, pseudo_header, pd, fdata, NULL);
+
+  if (args->print_formfeed) {
+    print_formfeed(args->print_fh, args->print_args->format);
+  } else {
+      if (args->print_separator)
+        print_line(args->print_fh, 0, args->print_args->format, "");
+  }
 
   if (args->print_args->print_summary) {
     if (args->print_header_line) {
@@ -1557,6 +1575,9 @@ print_packet(capture_file *cf, frame_data *fdata,
         *cp++ = ' ';
     }
     *cp = '\0';
+
+    print_packet_header(args->print_fh, args->print_args->format, fdata->num, args->line_buf);
+
     print_line(args->print_fh, 0, args->print_args->format, args->line_buf);
   } /* if (print_summary) */
   
@@ -1589,6 +1610,11 @@ print_packet(capture_file *cf, frame_data *fdata,
 
   epan_dissect_free(edt);
 
+  /* do we want to have a formfeed between each packet from now on? */
+  if(args->print_args->print_formfeed) {
+    args->print_formfeed = TRUE;
+  }
+
   return !ferror(args->print_fh);
 }
 
@@ -1604,8 +1630,13 @@ print_packets(capture_file *cf, print_args_t *print_args)
   int         line_len;
   psp_return_t ret;
 
-  callback_args.print_fh = open_print_dest(print_args->to_file,
-                                           print_args->dest);
+  if(print_args->to_file) {
+      callback_args.print_fh = open_print_dest(print_args->to_file,
+                                               print_args->file);
+  } else {
+      callback_args.print_fh = open_print_dest(print_args->to_file,
+                                               print_args->cmd);
+  }
   if (callback_args.print_fh == NULL)
     return PP_OPEN_ERROR;      /* attempt to open destination failed */
 
@@ -1619,6 +1650,7 @@ print_packets(capture_file *cf, print_args_t *print_args)
   callback_args.print_header_line = TRUE;
   callback_args.header_line_buf = NULL;
   callback_args.header_line_buf_len = 256;
+  callback_args.print_formfeed = FALSE;
   callback_args.print_separator = FALSE;
   callback_args.line_buf = NULL;
   callback_args.line_buf_len = 256;
@@ -1723,11 +1755,152 @@ print_packets(capture_file *cf, print_args_t *print_args)
     return PP_WRITE_ERROR;
   }
 
+  /* XXX - check for an error */
   close_print_dest(print_args->to_file, callback_args.print_fh);
 
   return PP_OK;
 }
 
+static gboolean
+write_pdml_packet(capture_file *cf _U_, frame_data *fdata,
+                  union wtap_pseudo_header *pseudo_header, const guint8 *pd,
+                 void *argsp)
+{
+  FILE *fh = argsp;
+  epan_dissect_t *edt;
+
+  /* Create the protocol tree, but don't fill in the column information. */
+  edt = epan_dissect_new(TRUE, TRUE);
+  epan_dissect_run(edt, pseudo_header, pd, fdata, NULL);
+
+  /* Write out the information in that tree. */
+  proto_tree_write_pdml(edt, fh);
+
+  epan_dissect_free(edt);
+
+  return !ferror(fh);
+}
+
+pp_return_t
+write_pdml_packets(capture_file *cf, print_args_t *print_args)
+{
+  FILE        *fh;
+  psp_return_t ret;
+
+  fh = fopen(print_args->file, "w");
+  if (fh == NULL)
+    return PP_OPEN_ERROR;      /* attempt to open destination failed */
+
+  write_pdml_preamble(fh);
+  if (ferror(fh)) {
+    fclose(fh);
+    return PP_WRITE_ERROR;
+  }
+
+  /* Iterate through the list of packets, printing the packets we were
+     told to print. */
+  ret = process_specified_packets(cf, &print_args->range, "Writing PDML",
+                                  "selected packets", write_pdml_packet,
+                                  fh);
+
+  switch (ret) {
+
+  case PSP_FINISHED:
+    /* Completed successfully. */
+    break;
+
+  case PSP_STOPPED:
+    /* Well, the user decided to abort the printing. */
+    break;
+
+  case PSP_FAILED:
+    /* Error while printing. */
+    fclose(fh);
+    return PP_WRITE_ERROR;
+  }
+
+  write_pdml_finale(fh);
+  if (ferror(fh)) {
+    fclose(fh);
+    return PP_WRITE_ERROR;
+  }
+
+  /* XXX - check for an error */
+  fclose(fh);
+
+  return PP_OK;
+}
+
+static gboolean
+write_psml_packet(capture_file *cf, frame_data *fdata,
+                  union wtap_pseudo_header *pseudo_header, const guint8 *pd,
+                 void *argsp)
+{
+  FILE *fh = argsp;
+  epan_dissect_t *edt;
+
+  /* Fill in the column information, but don't create the protocol tree. */
+  edt = epan_dissect_new(FALSE, FALSE);
+  epan_dissect_run(edt, pseudo_header, pd, fdata, &cf->cinfo);
+
+  /* Write out the information in that tree. */
+  proto_tree_write_psml(edt, fh);
+
+  epan_dissect_free(edt);
+
+  return !ferror(fh);
+}
+
+pp_return_t
+write_psml_packets(capture_file *cf, print_args_t *print_args)
+{
+  FILE        *fh;
+  psp_return_t ret;
+
+  fh = fopen(print_args->file, "w");
+  if (fh == NULL)
+    return PP_OPEN_ERROR;      /* attempt to open destination failed */
+
+  write_psml_preamble(fh);
+  if (ferror(fh)) {
+    fclose(fh);
+    return PP_WRITE_ERROR;
+  }
+
+  /* Iterate through the list of packets, printing the packets we were
+     told to print. */
+  ret = process_specified_packets(cf, &print_args->range, "Writing PSML",
+                                  "selected packets", write_psml_packet,
+                                  fh);
+
+  switch (ret) {
+
+  case PSP_FINISHED:
+    /* Completed successfully. */
+    break;
+
+  case PSP_STOPPED:
+    /* Well, the user decided to abort the printing. */
+    break;
+
+  case PSP_FAILED:
+    /* Error while printing. */
+    fclose(fh);
+    return PP_WRITE_ERROR;
+  }
+
+  write_psml_finale(fh);
+  if (ferror(fh)) {
+    fclose(fh);
+    return PP_WRITE_ERROR;
+  }
+
+  /* XXX - check for an error */
+  fclose(fh);
+
+  return PP_OK;
+}
+
 /* Scan through the packet list and change all columns that use the
    "command-line-specified" time stamp format to use the current
    value of that format. */
@@ -1947,7 +2120,7 @@ match_subtree_text(proto_node *node, gpointer data)
   }
 
   /* Don't match invisible entries. */
-  if (!fi->visible)
+  if (PROTO_ITEM_IS_HIDDEN(node))
     return;
 
   /* was a free format label produced? */
@@ -2958,8 +3131,12 @@ cf_read_error_message(int err, gchar *err_info)
 
   switch (err) {
 
-  case WTAP_ERR_UNSUPPORTED:
   case WTAP_ERR_UNSUPPORTED_ENCAP:
+      snprintf(errmsg_errno, sizeof(errmsg_errno),
+               "The file \"%%s\" has a packet with a network type that Ethereal doesn't support.\n(%s)",
+               err_info);
+      break;
+
   case WTAP_ERR_BAD_RECORD:
     snprintf(errmsg_errno, sizeof(errmsg_errno),
             "An error occurred while reading from the file \"%%s\": %s.\n(%s)",