staging: greybus: fix symbolic permission coding style issues

[sfrench/cifs-2.6.git] / drivers / staging / greybus / svc.c

diff --git a/drivers/staging/greybus/svc.c b/drivers/staging/greybus/svc.c
index 8779270cadc1d4c86c21b8ac8ba08c96356fc564..516f827e5ed9aea6cef086ffe10308236e4218fa 100644 (file)
--- a/drivers/staging/greybus/svc.c
+++ b/drivers/staging/greybus/svc.c
@@ -518,85 +518,6 @@ void gb_svc_connection_destroy(struct gb_svc *svc, u8 intf1_id, u16 cport1_id,
        }
 }
 
-int gb_svc_timesync_enable(struct gb_svc *svc, u8 count, u64 frame_time,
-                          u32 strobe_delay, u32 refclk)
-{
-       struct gb_connection *connection = svc->connection;
-       struct gb_svc_timesync_enable_request request;
-
-       request.count = count;
-       request.frame_time = cpu_to_le64(frame_time);
-       request.strobe_delay = cpu_to_le32(strobe_delay);
-       request.refclk = cpu_to_le32(refclk);
-       return gb_operation_sync(connection,
-                                GB_SVC_TYPE_TIMESYNC_ENABLE,
-                                &request, sizeof(request), NULL, 0);
-}
-
-int gb_svc_timesync_disable(struct gb_svc *svc)
-{
-       struct gb_connection *connection = svc->connection;
-
-       return gb_operation_sync(connection,
-                                GB_SVC_TYPE_TIMESYNC_DISABLE,
-                                NULL, 0, NULL, 0);
-}
-
-int gb_svc_timesync_authoritative(struct gb_svc *svc, u64 *frame_time)
-{
-       struct gb_connection *connection = svc->connection;
-       struct gb_svc_timesync_authoritative_response response;
-       int ret, i;
-
-       ret = gb_operation_sync(connection,
-                               GB_SVC_TYPE_TIMESYNC_AUTHORITATIVE, NULL, 0,
-                               &response, sizeof(response));
-       if (ret < 0)
-               return ret;
-
-       for (i = 0; i < GB_TIMESYNC_MAX_STROBES; i++)
-               frame_time[i] = le64_to_cpu(response.frame_time[i]);
-       return 0;
-}
-
-int gb_svc_timesync_ping(struct gb_svc *svc, u64 *frame_time)
-{
-       struct gb_connection *connection = svc->connection;
-       struct gb_svc_timesync_ping_response response;
-       int ret;
-
-       ret = gb_operation_sync(connection,
-                               GB_SVC_TYPE_TIMESYNC_PING,
-                               NULL, 0,
-                               &response, sizeof(response));
-       if (ret < 0)
-               return ret;
-
-       *frame_time = le64_to_cpu(response.frame_time);
-       return 0;
-}
-
-int gb_svc_timesync_wake_pins_acquire(struct gb_svc *svc, u32 strobe_mask)
-{
-       struct gb_connection *connection = svc->connection;
-       struct gb_svc_timesync_wake_pins_acquire_request request;
-
-       request.strobe_mask = cpu_to_le32(strobe_mask);
-       return gb_operation_sync(connection,
-                                GB_SVC_TYPE_TIMESYNC_WAKE_PINS_ACQUIRE,
-                                &request, sizeof(request),
-                                NULL, 0);
-}
-
-int gb_svc_timesync_wake_pins_release(struct gb_svc *svc)
-{
-       struct gb_connection *connection = svc->connection;
-
-       return gb_operation_sync(connection,
-                                GB_SVC_TYPE_TIMESYNC_WAKE_PINS_RELEASE,
-                                NULL, 0, NULL, 0);
-}
-
 /* Creates bi-directional routes between the devices */
 int gb_svc_route_create(struct gb_svc *svc, u8 intf1_id, u8 dev1_id,
                               u8 intf2_id, u8 dev2_id)
@@ -757,7 +678,8 @@ static int gb_svc_version_request(struct gb_operation *op)
 static ssize_t pwr_debugfs_voltage_read(struct file *file, char __user *buf,
                                        size_t len, loff_t *offset)
 {
-       struct svc_debugfs_pwrmon_rail *pwrmon_rails = file_inode(file)->i_private;
+       struct svc_debugfs_pwrmon_rail *pwrmon_rails =
+               file_inode(file)->i_private;
        struct gb_svc *svc = pwrmon_rails->svc;
        int ret, desc;
        u32 value;
@@ -780,7 +702,8 @@ static ssize_t pwr_debugfs_voltage_read(struct file *file, char __user *buf,
 static ssize_t pwr_debugfs_current_read(struct file *file, char __user *buf,
                                        size_t len, loff_t *offset)
 {
-       struct svc_debugfs_pwrmon_rail *pwrmon_rails = file_inode(file)->i_private;
+       struct svc_debugfs_pwrmon_rail *pwrmon_rails =
+               file_inode(file)->i_private;
        struct gb_svc *svc = pwrmon_rails->svc;
        int ret, desc;
        u32 value;
@@ -803,7 +726,8 @@ static ssize_t pwr_debugfs_current_read(struct file *file, char __user *buf,
 static ssize_t pwr_debugfs_power_read(struct file *file, char __user *buf,
                                      size_t len, loff_t *offset)
 {
-       struct svc_debugfs_pwrmon_rail *pwrmon_rails = file_inode(file)->i_private;
+       struct svc_debugfs_pwrmon_rail *pwrmon_rails =
+               file_inode(file)->i_private;
        struct gb_svc *svc = pwrmon_rails->svc;
        int ret, desc;
        u32 value;
@@ -879,11 +803,11 @@ static void gb_svc_pwrmon_debugfs_init(struct gb_svc *svc)
                rail->svc = svc;
 
                dir = debugfs_create_dir(fname, dent);
-               debugfs_create_file("voltage_now", S_IRUGO, dir, rail,
+               debugfs_create_file("voltage_now", 0444, dir, rail,
                                    &pwrmon_debugfs_voltage_fops);
-               debugfs_create_file("current_now", S_IRUGO, dir, rail,
+               debugfs_create_file("current_now", 0444, dir, rail,
                                    &pwrmon_debugfs_current_fops);
-               debugfs_create_file("power_now", S_IRUGO, dir, rail,
+               debugfs_create_file("power_now", 0444, dir, rail,
                                    &pwrmon_debugfs_power_fops);
        }
 
@@ -945,13 +869,6 @@ static int gb_svc_hello(struct gb_operation *op)
 
        gb_svc_debugfs_init(svc);
 
-       ret = gb_timesync_svc_add(svc);
-       if (ret) {
-               dev_err(&svc->dev, "failed to add SVC to timesync: %d\n", ret);
-               gb_svc_debugfs_exit(svc);
-               goto err_unregister_device;
-       }
-
        return gb_svc_queue_deferred_request(op);
 
 err_unregister_device:
@@ -1010,14 +927,15 @@ static void gb_svc_process_hello_deferred(struct gb_operation *operation)
         * Power Mode Changes is resolved.
         */
        ret = gb_svc_intf_set_power_mode(svc, svc->ap_intf_id,
-                                       GB_SVC_UNIPRO_HS_SERIES_A,
-                                       GB_SVC_UNIPRO_SLOW_AUTO_MODE,
-                                       2, 1,
-                                       GB_SVC_SMALL_AMPLITUDE, GB_SVC_NO_DE_EMPHASIS,
-                                       GB_SVC_UNIPRO_SLOW_AUTO_MODE,
-                                       2, 1,
-                                       0, 0,
-                                       NULL, NULL);
+                                        GB_SVC_UNIPRO_HS_SERIES_A,
+                                        GB_SVC_UNIPRO_SLOW_AUTO_MODE,
+                                        2, 1,
+                                        GB_SVC_SMALL_AMPLITUDE,
+                                        GB_SVC_NO_DE_EMPHASIS,
+                                        GB_SVC_UNIPRO_SLOW_AUTO_MODE,
+                                        2, 1,
+                                        0, 0,
+                                        NULL, NULL);
 
        if (ret)
                dev_warn(&svc->dev,
@@ -1467,7 +1385,6 @@ void gb_svc_del(struct gb_svc *svc)
         * The SVC device may have been registered from the request handler.
         */
        if (device_is_registered(&svc->dev)) {
-               gb_timesync_svc_remove(svc);
                gb_svc_debugfs_exit(svc);
                gb_svc_watchdog_destroy(svc);
                device_del(&svc->dev);