Merge ARM fixes
[sfrench/cifs-2.6.git] / drivers / acpi / processor_perflib.c
index 8bd7500c6121dda5ec58074d809bff3b212291ea..2f2e7964226dcc59840cec2b0e1942a251d64880 100644 (file)
 
 #define ACPI_PROCESSOR_COMPONENT       0x01000000
 #define ACPI_PROCESSOR_CLASS           "processor"
-#define ACPI_PROCESSOR_DRIVER_NAME     "ACPI Processor Driver"
 #define ACPI_PROCESSOR_FILE_PERFORMANCE        "performance"
 #define _COMPONENT             ACPI_PROCESSOR_COMPONENT
-ACPI_MODULE_NAME("acpi_processor")
+ACPI_MODULE_NAME("processor_perflib");
 
 static DEFINE_MUTEX(performance_mutex);
 
@@ -83,10 +82,8 @@ static int acpi_processor_ppc_notifier(struct notifier_block *nb,
                goto out;
 
        ppc = (unsigned int)pr->performance_platform_limit;
-       if (!ppc)
-               goto out;
 
-       if (ppc > pr->performance->state_count)
+       if (ppc >= pr->performance->state_count)
                goto out;
 
        cpufreq_verify_within_limits(policy, 0,
@@ -108,10 +105,9 @@ static int acpi_processor_get_platform_limit(struct acpi_processor *pr)
        acpi_status status = 0;
        unsigned long ppc = 0;
 
-       ACPI_FUNCTION_TRACE("acpi_processor_get_platform_limit");
 
        if (!pr)
-               return_VALUE(-EINVAL);
+               return -EINVAL;
 
        /*
         * _PPC indicates the maximum state currently supported by the platform
@@ -124,12 +120,12 @@ static int acpi_processor_get_platform_limit(struct acpi_processor *pr)
 
        if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
                ACPI_EXCEPTION((AE_INFO, status, "Evaluating _PPC"));
-               return_VALUE(-ENODEV);
+               return -ENODEV;
        }
 
        pr->performance_platform_limit = (int)ppc;
 
-       return_VALUE(0);
+       return 0;
 }
 
 int acpi_processor_ppc_has_changed(struct acpi_processor *pr)
@@ -168,12 +164,11 @@ static int acpi_processor_get_performance_control(struct acpi_processor *pr)
        union acpi_object *pct = NULL;
        union acpi_object obj = { 0 };
 
-       ACPI_FUNCTION_TRACE("acpi_processor_get_performance_control");
 
        status = acpi_evaluate_object(pr->handle, "_PCT", NULL, &buffer);
        if (ACPI_FAILURE(status)) {
                ACPI_EXCEPTION((AE_INFO, status, "Evaluating _PCT"));
-               return_VALUE(-ENODEV);
+               return -ENODEV;
        }
 
        pct = (union acpi_object *)buffer.pointer;
@@ -218,9 +213,9 @@ static int acpi_processor_get_performance_control(struct acpi_processor *pr)
               sizeof(struct acpi_pct_register));
 
       end:
-       acpi_os_free(buffer.pointer);
+       kfree(buffer.pointer);
 
-       return_VALUE(result);
+       return result;
 }
 
 static int acpi_processor_get_performance_states(struct acpi_processor *pr)
@@ -233,15 +228,14 @@ static int acpi_processor_get_performance_states(struct acpi_processor *pr)
        union acpi_object *pss = NULL;
        int i;
 
-       ACPI_FUNCTION_TRACE("acpi_processor_get_performance_states");
 
        status = acpi_evaluate_object(pr->handle, "_PSS", NULL, &buffer);
        if (ACPI_FAILURE(status)) {
                ACPI_EXCEPTION((AE_INFO, status, "Evaluating _PSS"));
-               return_VALUE(-ENODEV);
+               return -ENODEV;
        }
 
-       pss = (union acpi_object *)buffer.pointer;
+       pss = buffer.pointer;
        if (!pss || (pss->type != ACPI_TYPE_PACKAGE)) {
                printk(KERN_ERR PREFIX "Invalid _PSS data\n");
                result = -EFAULT;
@@ -297,9 +291,9 @@ static int acpi_processor_get_performance_states(struct acpi_processor *pr)
        }
 
       end:
-       acpi_os_free(buffer.pointer);
+       kfree(buffer.pointer);
 
-       return_VALUE(result);
+       return result;
 }
 
 static int acpi_processor_get_performance_info(struct acpi_processor *pr)
@@ -308,31 +302,26 @@ static int acpi_processor_get_performance_info(struct acpi_processor *pr)
        acpi_status status = AE_OK;
        acpi_handle handle = NULL;
 
-       ACPI_FUNCTION_TRACE("acpi_processor_get_performance_info");
 
        if (!pr || !pr->performance || !pr->handle)
-               return_VALUE(-EINVAL);
+               return -EINVAL;
 
        status = acpi_get_handle(pr->handle, "_PCT", &handle);
        if (ACPI_FAILURE(status)) {
                ACPI_DEBUG_PRINT((ACPI_DB_INFO,
                                  "ACPI-based processor performance control unavailable\n"));
-               return_VALUE(-ENODEV);
+               return -ENODEV;
        }
 
        result = acpi_processor_get_performance_control(pr);
        if (result)
-               return_VALUE(result);
+               return result;
 
        result = acpi_processor_get_performance_states(pr);
        if (result)
-               return_VALUE(result);
-
-       result = acpi_processor_get_platform_limit(pr);
-       if (result)
-               return_VALUE(result);
+               return result;
 
-       return_VALUE(0);
+       return 0;
 }
 
 int acpi_processor_notify_smm(struct module *calling_module)
@@ -340,13 +329,12 @@ int acpi_processor_notify_smm(struct module *calling_module)
        acpi_status status;
        static int is_done = 0;
 
-       ACPI_FUNCTION_TRACE("acpi_processor_notify_smm");
 
        if (!(acpi_processor_ppc_status & PPC_REGISTERED))
-               return_VALUE(-EBUSY);
+               return -EBUSY;
 
        if (!try_module_get(calling_module))
-               return_VALUE(-EINVAL);
+               return -EINVAL;
 
        /* is_done is set to negative if an error occured,
         * and to postitive if _no_ error occured, but SMM
@@ -355,41 +343,34 @@ int acpi_processor_notify_smm(struct module *calling_module)
         */
        if (is_done > 0) {
                module_put(calling_module);
-               return_VALUE(0);
+               return 0;
        } else if (is_done < 0) {
                module_put(calling_module);
-               return_VALUE(is_done);
+               return is_done;
        }
 
        is_done = -EIO;
 
-       /* Can't write pstate_cnt to smi_cmd if either value is zero */
-       if ((!acpi_fadt.smi_cmd) || (!acpi_fadt.pstate_cnt)) {
-               ACPI_DEBUG_PRINT((ACPI_DB_INFO, "No SMI port or pstate_cnt\n"));
+       /* Can't write pstate_control to smi_command if either value is zero */
+       if ((!acpi_gbl_FADT.smi_command) || (!acpi_gbl_FADT.pstate_control)) {
+               ACPI_DEBUG_PRINT((ACPI_DB_INFO, "No SMI port or pstate_control\n"));
                module_put(calling_module);
-               return_VALUE(0);
+               return 0;
        }
 
        ACPI_DEBUG_PRINT((ACPI_DB_INFO,
-                         "Writing pstate_cnt [0x%x] to smi_cmd [0x%x]\n",
-                         acpi_fadt.pstate_cnt, acpi_fadt.smi_cmd));
-
-       /* FADT v1 doesn't support pstate_cnt, many BIOS vendors use
-        * it anyway, so we need to support it... */
-       if (acpi_fadt_is_v1) {
-               ACPI_DEBUG_PRINT((ACPI_DB_INFO,
-                                 "Using v1.0 FADT reserved value for pstate_cnt\n"));
-       }
+                         "Writing pstate_control [0x%x] to smi_command [0x%x]\n",
+                         acpi_gbl_FADT.pstate_control, acpi_gbl_FADT.smi_command));
 
-       status = acpi_os_write_port(acpi_fadt.smi_cmd,
-                                   (u32) acpi_fadt.pstate_cnt, 8);
+       status = acpi_os_write_port(acpi_gbl_FADT.smi_command,
+                                   (u32) acpi_gbl_FADT.pstate_control, 8);
        if (ACPI_FAILURE(status)) {
                ACPI_EXCEPTION((AE_INFO, status,
-                               "Failed to write pstate_cnt [0x%x] to "
-                               "smi_cmd [0x%x]", acpi_fadt.pstate_cnt,
-                               acpi_fadt.smi_cmd));
+                               "Failed to write pstate_control [0x%x] to "
+                               "smi_command [0x%x]", acpi_gbl_FADT.pstate_control,
+                               acpi_gbl_FADT.smi_command));
                module_put(calling_module);
-               return_VALUE(status);
+               return status;
        }
 
        /* Success. If there's no _PPC, we need to fear nothing, so
@@ -399,7 +380,7 @@ int acpi_processor_notify_smm(struct module *calling_module)
        if (!(acpi_processor_ppc_status & PPC_IN_USE))
                module_put(calling_module);
 
-       return_VALUE(0);
+       return 0;
 }
 
 EXPORT_SYMBOL(acpi_processor_notify_smm);
@@ -417,10 +398,9 @@ static struct file_operations acpi_processor_perf_fops = {
 
 static int acpi_processor_perf_seq_show(struct seq_file *seq, void *offset)
 {
-       struct acpi_processor *pr = (struct acpi_processor *)seq->private;
+       struct acpi_processor *pr = seq->private;
        int i;
 
-       ACPI_FUNCTION_TRACE("acpi_processor_perf_seq_show");
 
        if (!pr)
                goto end;
@@ -444,7 +424,7 @@ static int acpi_processor_perf_seq_show(struct seq_file *seq, void *offset)
                           (u32) pr->performance->states[i].transition_latency);
 
       end:
-       return_VALUE(0);
+       return 0;
 }
 
 static int acpi_processor_perf_open_fs(struct inode *inode, struct file *file)
@@ -459,30 +439,29 @@ acpi_processor_write_performance(struct file *file,
                                 size_t count, loff_t * data)
 {
        int result = 0;
-       struct seq_file *m = (struct seq_file *)file->private_data;
-       struct acpi_processor *pr = (struct acpi_processor *)m->private;
+       struct seq_file *m = file->private_data;
+       struct acpi_processor *pr = m->private;
        struct acpi_processor_performance *perf;
        char state_string[12] = { '\0' };
        unsigned int new_state = 0;
        struct cpufreq_policy policy;
 
-       ACPI_FUNCTION_TRACE("acpi_processor_write_performance");
 
        if (!pr || (count > sizeof(state_string) - 1))
-               return_VALUE(-EINVAL);
+               return -EINVAL;
 
        perf = pr->performance;
        if (!perf)
-               return_VALUE(-EINVAL);
+               return -EINVAL;
 
        if (copy_from_user(state_string, buffer, count))
-               return_VALUE(-EFAULT);
+               return -EFAULT;
 
        state_string[count] = '\0';
        new_state = simple_strtoul(state_string, NULL, 0);
 
        if (new_state >= perf->state_count)
-               return_VALUE(-EINVAL);
+               return -EINVAL;
 
        cpufreq_get_policy(&policy, pr->id);
 
@@ -492,9 +471,9 @@ acpi_processor_write_performance(struct file *file,
 
        result = cpufreq_set_policy(&policy);
        if (result)
-               return_VALUE(result);
+               return result;
 
-       return_VALUE(count);
+       return count;
 }
 
 static void acpi_cpufreq_add_file(struct acpi_processor *pr)
@@ -502,10 +481,9 @@ static void acpi_cpufreq_add_file(struct acpi_processor *pr)
        struct proc_dir_entry *entry = NULL;
        struct acpi_device *device = NULL;
 
-       ACPI_FUNCTION_TRACE("acpi_cpufreq_addfile");
 
        if (acpi_bus_get_device(pr->handle, &device))
-               return_VOID;
+               return;
 
        /* add file 'performance' [R/W] */
        entry = create_proc_entry(ACPI_PROCESSOR_FILE_PERFORMANCE,
@@ -517,23 +495,22 @@ static void acpi_cpufreq_add_file(struct acpi_processor *pr)
                entry->data = acpi_driver_data(device);
                entry->owner = THIS_MODULE;
        }
-       return_VOID;
+       return;
 }
 
 static void acpi_cpufreq_remove_file(struct acpi_processor *pr)
 {
        struct acpi_device *device = NULL;
 
-       ACPI_FUNCTION_TRACE("acpi_cpufreq_addfile");
 
        if (acpi_bus_get_device(pr->handle, &device))
-               return_VOID;
+               return;
 
        /* remove file 'performance' */
        remove_proc_entry(ACPI_PROCESSOR_FILE_PERFORMANCE,
                          acpi_device_dir(device));
 
-       return_VOID;
+       return;
 }
 
 #else
@@ -562,7 +539,7 @@ static int acpi_processor_get_psd(struct acpi_processor     *pr)
                return -ENODEV;
        }
 
-       psd = (union acpi_object *) buffer.pointer;
+       psd = buffer.pointer;
        if (!psd || (psd->type != ACPI_TYPE_PACKAGE)) {
                ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid _PSD data\n"));
                result = -EFAULT;
@@ -601,7 +578,7 @@ static int acpi_processor_get_psd(struct acpi_processor     *pr)
        }
 
 end:
-       acpi_os_free(buffer.pointer);
+       kfree(buffer.pointer);
        return result;
 }
 
@@ -691,12 +668,12 @@ int acpi_processor_preregister_performance(
                /* Validate the Domain info */
                count_target = pdomain->num_processors;
                count = 1;
-               if (pdomain->coord_type == DOMAIN_COORD_TYPE_SW_ALL ||
-                   pdomain->coord_type == DOMAIN_COORD_TYPE_HW_ALL) {
+               if (pdomain->coord_type == DOMAIN_COORD_TYPE_SW_ALL)
                        pr->performance->shared_type = CPUFREQ_SHARED_TYPE_ALL;
-               } else if (pdomain->coord_type == DOMAIN_COORD_TYPE_SW_ANY) {
+               else if (pdomain->coord_type == DOMAIN_COORD_TYPE_HW_ALL)
+                       pr->performance->shared_type = CPUFREQ_SHARED_TYPE_HW;
+               else if (pdomain->coord_type == DOMAIN_COORD_TYPE_SW_ANY)
                        pr->performance->shared_type = CPUFREQ_SHARED_TYPE_ANY;
-               }
 
                for_each_possible_cpu(j) {
                        if (i == j)
@@ -747,10 +724,6 @@ int acpi_processor_preregister_performance(
        }
 
 err_ret:
-       if (retval) {
-               ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Error while parsing _PSD domain information. Assuming no coordination\n"));
-       }
-
        for_each_possible_cpu(i) {
                pr = processors[i];
                if (!pr || !pr->performance)
@@ -777,22 +750,21 @@ acpi_processor_register_performance(struct acpi_processor_performance
 {
        struct acpi_processor *pr;
 
-       ACPI_FUNCTION_TRACE("acpi_processor_register_performance");
 
        if (!(acpi_processor_ppc_status & PPC_REGISTERED))
-               return_VALUE(-EINVAL);
+               return -EINVAL;
 
        mutex_lock(&performance_mutex);
 
        pr = processors[cpu];
        if (!pr) {
                mutex_unlock(&performance_mutex);
-               return_VALUE(-ENODEV);
+               return -ENODEV;
        }
 
        if (pr->performance) {
                mutex_unlock(&performance_mutex);
-               return_VALUE(-EBUSY);
+               return -EBUSY;
        }
 
        WARN_ON(!performance);
@@ -802,13 +774,13 @@ acpi_processor_register_performance(struct acpi_processor_performance
        if (acpi_processor_get_performance_info(pr)) {
                pr->performance = NULL;
                mutex_unlock(&performance_mutex);
-               return_VALUE(-EIO);
+               return -EIO;
        }
 
        acpi_cpufreq_add_file(pr);
 
        mutex_unlock(&performance_mutex);
-       return_VALUE(0);
+       return 0;
 }
 
 EXPORT_SYMBOL(acpi_processor_register_performance);
@@ -819,14 +791,13 @@ acpi_processor_unregister_performance(struct acpi_processor_performance
 {
        struct acpi_processor *pr;
 
-       ACPI_FUNCTION_TRACE("acpi_processor_unregister_performance");
 
        mutex_lock(&performance_mutex);
 
        pr = processors[cpu];
        if (!pr) {
                mutex_unlock(&performance_mutex);
-               return_VOID;
+               return;
        }
 
        if (pr->performance)
@@ -837,7 +808,7 @@ acpi_processor_unregister_performance(struct acpi_processor_performance
 
        mutex_unlock(&performance_mutex);
 
-       return_VOID;
+       return;
 }
 
 EXPORT_SYMBOL(acpi_processor_unregister_performance);