Fix Coverity CID's 1339 and 1340: UNUSED_VALUE.
[obnox/wireshark/wip.git] / capture.c
index ba5d6616f23218aea3ed58c8eb1d23c98a26459f..22bab8dd94b53a246ae6843af4b578e1b703c499 100644 (file)
--- a/capture.c
+++ b/capture.c
 #include <unistd.h>
 #endif
 
-#include <stdlib.h>
+#include <stdio.h>
 #include <string.h>
-#include <ctype.h>
-
-#ifdef HAVE_FCNTL_H
-#include <fcntl.h>
-#endif
-
-#ifdef HAVE_SYS_TYPES_H
-#include <sys/types.h>
-#endif
-
-#ifdef HAVE_NETINET_IN_H
-#include <netinet/in.h>
-#endif
-
-#ifdef HAVE_NETDB_H
-#include <netdb.h>
-#endif
-
-#ifdef HAVE_ARPA_INET_H
-#include <arpa/inet.h>
-#endif
-
-#ifdef HAVE_SYS_SOCKET_H
-#include <sys/socket.h>         /* needed to define AF_ values on UNIX */
-#endif
-
-#ifdef HAVE_WINSOCK2_H
-#include <winsock2.h>           /* needed to define AF_ values on Windows */
-#endif
-
-#ifdef NEED_INET_V6DEFS_H
-# include "inet_v6defs.h"
-#endif
-
-#include <signal.h>
-#include <errno.h>
 
 #include <glib.h>
 
 #include <epan/dfilter/dfilter.h>
 #include "file.h"
 #include "capture.h"
+#include "capture_ifinfo.h"
 #include "capture_sync.h"
 #include "capture_info.h"
 #include "capture_ui_utils.h"
 #include "util.h"
 #include "capture-pcap-util.h"
-#include "alert_box.h"
 #include "simple_dialog.h"
 #include <epan/prefs.h>
 
@@ -169,16 +133,48 @@ gboolean
 capture_start(capture_options *capture_opts)
 {
   gboolean ret;
+  guint i;
+  GString *source = g_string_new("");
 
+  if (capture_opts->state != CAPTURE_STOPPED)
+    return FALSE;
+  capture_opts->state = CAPTURE_PREPARING;
 
   /* close the currently loaded capture file */
   cf_close(capture_opts->cf);
 
-  g_assert(capture_opts->state == CAPTURE_STOPPED);
-  capture_opts->state = CAPTURE_PREPARING;
-
   g_log(LOG_DOMAIN_CAPTURE, G_LOG_LEVEL_MESSAGE, "Capture Start ...");
 
+#ifdef _WIN32
+  if (capture_opts->ifaces->len < 2) {
+#else
+  if (capture_opts->ifaces->len < 4) {
+#endif
+    for (i = 0; i < capture_opts->ifaces->len; i++) {
+      interface_options interface_opts;
+
+      interface_opts = g_array_index(capture_opts->ifaces, interface_options, i);
+      if (i > 0) {
+          if (capture_opts->ifaces->len > 2) {
+              g_string_append_printf(source, ",");
+          }
+          g_string_append_printf(source, " ");
+          if (i == capture_opts->ifaces->len - 1) {
+              g_string_append_printf(source, "and ");
+          }
+      }
+      g_string_append_printf(source, "%s", get_iface_description_for_interface(capture_opts, i));
+      if ((interface_opts.cfilter != NULL) &&
+          (strlen(interface_opts.cfilter) > 0)) {
+        g_string_append_printf(source, " (%s)", interface_opts.cfilter);
+      }
+    }
+  } else {
+    g_string_append_printf(source, "%u interfaces", capture_opts->ifaces->len);
+  }
+  cf_set_tempfile_source(capture_opts->cf, source->str);
+  g_string_free(source, TRUE);
+
   /* try to start the capture child process */
   ret = sync_pipe_start(capture_opts);
   if(!ret) {
@@ -245,13 +241,12 @@ guint32 drops)
 {
   int err;
 
-
   /* Capture succeeded; attempt to open the capture file. */
   if (cf_open(capture_opts->cf, capture_opts->save_file, is_tempfile, &err) != CF_OK) {
     /* We're not doing a capture any more, so we don't have a save file. */
     return FALSE;
   }
-
+  
   /* Set the read filter to NULL. */
   /* XXX - this is odd here; try to put it somewhere where it fits better */
   cf_set_rfcode(capture_opts->cf, NULL);
@@ -289,7 +284,7 @@ guint32 drops)
   }
 
   /* read in the packet data */
-  switch (cf_read(capture_opts->cf)) {
+  switch (cf_read(capture_opts->cf, FALSE)) {
 
   case CF_READ_OK:
   case CF_READ_ERROR:
@@ -337,7 +332,6 @@ capture_input_new_file(capture_options *capture_opts, gchar *new_file)
   gboolean is_tempfile;
   int  err;
 
-
   if(capture_opts->state == CAPTURE_PREPARING) {
     g_log(LOG_DOMAIN_CAPTURE, G_LOG_LEVEL_MESSAGE, "Capture started!");
   }
@@ -430,6 +424,7 @@ capture_input_new_packets(capture_options *capture_opts, int to_read)
     /* increase the capture file packet counter by the number of incoming packets */
     cf_set_packet_count(capture_opts->cf,
         cf_get_packet_count(capture_opts->cf) + to_read);
+    cf_fake_continue_tail(capture_opts->cf);
 
     capture_callback_invoke(capture_cb_capture_fixed_continue, capture_opts);
   }
@@ -498,20 +493,27 @@ capture_input_error_message(capture_options *capture_opts, char *error_msg, char
    capture filter when starting/running the capture.
  */
 void
-capture_input_cfilter_error_message(capture_options *capture_opts, char *error_message)
+capture_input_cfilter_error_message(capture_options *capture_opts, guint i, char *error_message)
 {
-  dfilter_t   *rfcode = NULL;
-  gchar *safe_cfilter = simple_dialog_format_message(capture_opts->cfilter);
-  gchar *safe_cfilter_error_msg = simple_dialog_format_message(error_message);
+  dfilter_t *rfcode = NULL;
+  gchar *safe_cfilter;
+  gchar *safe_descr;
+  gchar *safe_cfilter_error_msg;
+  interface_options interface_opts;
 
   g_log(LOG_DOMAIN_CAPTURE, G_LOG_LEVEL_MESSAGE, "Capture filter error message from child: \"%s\"", error_message);
 
   g_assert(capture_opts->state == CAPTURE_PREPARING || capture_opts->state == CAPTURE_RUNNING);
+  g_assert(i < capture_opts->ifaces->len);
 
+  interface_opts = g_array_index(capture_opts->ifaces, interface_options, i);
+  safe_cfilter = simple_dialog_format_message(interface_opts.cfilter);
+  safe_descr = simple_dialog_format_message(interface_opts.descr);
+  safe_cfilter_error_msg = simple_dialog_format_message(error_message);
   /* Did the user try a display filter? */
-  if (dfilter_compile(capture_opts->cfilter, &rfcode) && rfcode != NULL) {
+  if (dfilter_compile(interface_opts.cfilter, &rfcode) && rfcode != NULL) {
     simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK,
-      "%sInvalid capture filter: \"%s\"!%s\n"
+      "%sInvalid capture filter \"%s\" for interface %s!%s\n"
       "\n"
       "That string looks like a valid display filter; however, it isn't a valid\n"
       "capture filter (%s).\n"
@@ -520,19 +522,20 @@ capture_input_cfilter_error_message(capture_options *capture_opts, char *error_m
       "so you can't use most display filter expressions as capture filters.\n"
       "\n"
       "See the User's Guide for a description of the capture filter syntax.",
-      simple_dialog_primary_start(), safe_cfilter,
+      simple_dialog_primary_start(), safe_cfilter, safe_descr,
       simple_dialog_primary_end(), safe_cfilter_error_msg);
       dfilter_free(rfcode);
   } else {
     simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK,
-      "%sInvalid capture filter: \"%s\"!%s\n"
+      "%sInvalid capture filter \"%s\" for interface %s!%s\n"
       "\n"
       "That string isn't a valid capture filter (%s).\n"
       "See the User's Guide for a description of the capture filter syntax.",
-      simple_dialog_primary_start(), safe_cfilter,
+      simple_dialog_primary_start(), safe_cfilter, safe_descr,
       simple_dialog_primary_end(), safe_cfilter_error_msg);
   }
   g_free(safe_cfilter_error_msg);
+  g_free(safe_descr);
   g_free(safe_cfilter);
 
   /* the capture child will close the sync_pipe if required, nothing to do for now */
@@ -541,7 +544,7 @@ capture_input_cfilter_error_message(capture_options *capture_opts, char *error_m
 
 /* capture child closed its side of the pipe, do the required cleanup */
 void
-capture_input_closed(capture_options *capture_opts)
+capture_input_closed(capture_options *capture_opts, gchar *msg)
 {
     int  err;
     int  packet_count_save;
@@ -549,6 +552,9 @@ capture_input_closed(capture_options *capture_opts)
     g_log(LOG_DOMAIN_CAPTURE, G_LOG_LEVEL_MESSAGE, "Capture stopped!");
     g_assert(capture_opts->state == CAPTURE_PREPARING || capture_opts->state == CAPTURE_RUNNING);
 
+    if (msg != NULL)
+        simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK, "%s", msg);
+
     /* if we didn't start the capture, do a fake start. */
     /* (happens if we got an error message - we won't get a filename then). */
     if(capture_opts->state == CAPTURE_PREPARING) {
@@ -560,16 +566,16 @@ capture_input_closed(capture_options *capture_opts)
     }
 
     if(capture_opts->real_time_mode) {
-       cf_read_status_t status;
+        cf_read_status_t status;
 
         /* Read what remains of the capture file. */
         status = cf_finish_tail(capture_opts->cf, &err);
 
         /* XXX: If -Q (quit-after-cap) then cf->count clr'd below so save it first */
-       packet_count_save = cf_get_packet_count(capture_opts->cf);
+        packet_count_save = cf_get_packet_count(capture_opts->cf);
         /* Tell the GUI we are not doing a capture any more.
-                  Must be done after the cf_finish_tail(), so file lengths are 
-                   correctly displayed */
+           Must be done after the cf_finish_tail(), so file lengths are 
+           correctly displayed */
         capture_callback_invoke(capture_cb_capture_update_finished, capture_opts);
 
         /* Finish the capture. */
@@ -607,6 +613,7 @@ capture_input_closed(capture_options *capture_opts)
           /* Exit by leaving the main loop, so that any quit functions
              we registered get called. */
           main_window_quit();
+         break;
         }
 
     } else {
@@ -652,163 +659,6 @@ capture_input_closed(capture_options *capture_opts)
     }
 }
 
-/**
- * Fetch the interface list from a child process (dumpcap).
- *
- * @return A GList containing if_info_t structs if successful, NULL (with err and possibly err_str set) otherwise.
- *
- */
-
-/* XXX - We parse simple text output to get our interface list.  Should
- * we use "real" data serialization instead, e.g. via XML? */
-GList *
-capture_interface_list(int *err, char **err_str)
-{
-    GList     *if_list = NULL;
-    int        i, j;
-    gchar     *msg;
-    gchar    **raw_list, **if_parts, **addr_parts;
-    gchar     *name;
-    if_info_t *if_info;
-    if_addr_t *if_addr;
-
-    g_log(LOG_DOMAIN_CAPTURE, G_LOG_LEVEL_MESSAGE, "Capture Interface List ...");
-
-    /* Try to get our interface list */
-    *err = sync_interface_list_open(&msg);
-    if (*err != 0) {
-        g_log(LOG_DOMAIN_CAPTURE, G_LOG_LEVEL_MESSAGE, "Capture Interface List failed!");
-        if (err_str) {
-            *err_str = msg;
-        } else {
-            g_free(msg);
-        }
-        return NULL;
-    }
-
-    /* Split our lines */
-#ifdef _WIN32
-    raw_list = g_strsplit(msg, "\r\n", 0);
-#else
-    raw_list = g_strsplit(msg, "\n", 0);
-#endif
-    g_free(msg);
-
-    for (i = 0; raw_list[i] != NULL; i++) {
-        if_parts = g_strsplit(raw_list[i], "\t", 4);
-        if (if_parts[0] == NULL || if_parts[1] == NULL || if_parts[2] == NULL ||
-                if_parts[3] == NULL) {
-            g_strfreev(if_parts);
-            continue;
-        }
-
-        /* Number followed by the name, e.g "1. eth0" */
-        name = strchr(if_parts[0], ' ');
-        if (name) {
-            name++;
-        } else {
-            g_strfreev(if_parts);
-            continue;
-        }
-
-        if_info = g_malloc0(sizeof(if_info_t));
-        if_info->name = g_strdup(name);
-        if (strlen(if_parts[1]) > 0)
-            if_info->description = g_strdup(if_parts[1]);
-        addr_parts = g_strsplit(if_parts[2], ",", 0);
-        for (j = 0; addr_parts[j] != NULL; j++) {
-            if_addr = g_malloc0(sizeof(if_addr_t));
-            if (inet_pton(AF_INET, addr_parts[j], &if_addr->ip_addr.ip4_addr)) {
-                if_addr->type = AT_IPv4;
-            } else if (inet_pton(AF_INET6, addr_parts[j],
-                    &if_addr->ip_addr.ip6_addr)) {
-                if_addr->type = AT_IPv6;
-            } else {
-                g_free(if_addr);
-                if_addr = NULL;
-            }
-            if (if_addr) {
-                if_info->ip_addr = g_slist_append(if_info->ip_addr, if_addr);
-            }
-        }
-        if (strcmp(if_parts[3], "loopback") == 0)
-            if_info->loopback = TRUE;
-        g_strfreev(if_parts);
-        g_strfreev(addr_parts);
-        if_list = g_list_append(if_list, if_info);
-    }
-    g_strfreev(raw_list);
-
-    /* Check to see if we built a list */
-    if (if_list == NULL) {
-        *err = NO_INTERFACES_FOUND;
-        if (err_str)
-            *err_str = g_strdup("No interfaces found");
-    }
-    return if_list;
-}
-
-/* XXX - We parse simple text output to get our interface list.  Should
- * we use "real" data serialization instead, e.g. via XML? */
-GList *
-capture_pcap_linktype_list(const gchar *ifname, char **err_str)
-{
-    GList     *linktype_list = NULL;
-    int        err, i;
-    gchar     *msg;
-    gchar    **raw_list, **lt_parts;
-    data_link_info_t *data_link_info;
-
-    g_log(LOG_DOMAIN_CAPTURE, G_LOG_LEVEL_MESSAGE, "Capture Interface List ...");
-
-    /* Try to get our interface list */
-    err = sync_linktype_list_open(ifname, &msg);
-    if (err != 0) {
-        g_log(LOG_DOMAIN_CAPTURE, G_LOG_LEVEL_MESSAGE, "Capture Interface List failed!");
-        if (err_str) {
-            *err_str = msg;
-        } else {
-            g_free(msg);
-        }
-        return NULL;
-    }
-
-    /* Split our lines */
-#ifdef _WIN32
-    raw_list = g_strsplit(msg, "\r\n", 0);
-#else
-    raw_list = g_strsplit(msg, "\n", 0);
-#endif
-    g_free(msg);
-
-    for (i = 0; raw_list[i] != NULL; i++) {
-        /* ...and what if the interface name has a tab in it, Mr. Clever Programmer? */
-        lt_parts = g_strsplit(raw_list[i], "\t", 3);
-        if (lt_parts[0] == NULL || lt_parts[1] == NULL || lt_parts[2] == NULL) {
-            g_strfreev(lt_parts);
-            continue;
-        }
-
-        data_link_info = g_malloc(sizeof (data_link_info_t));
-        data_link_info->dlt = (int) strtol(lt_parts[0], NULL, 10);
-        data_link_info->name = g_strdup(lt_parts[1]);
-        if (strcmp(lt_parts[2], "(not supported)") != 0)
-            data_link_info->description = g_strdup(lt_parts[2]);
-        else
-            data_link_info->description = NULL;
-
-        linktype_list = g_list_append(linktype_list, data_link_info);
-    }
-    g_strfreev(raw_list);
-
-    /* Check to see if we built a list */
-    if (linktype_list == NULL) {
-        if (err_str)
-            *err_str = NULL;
-    }
-    return linktype_list;
-}
-
 if_stat_cache_t *
 capture_stat_start(GList *if_list) {
     int stat_fd, fork_child;
@@ -825,12 +675,12 @@ capture_stat_start(GList *if_list) {
      *
      * This means that
      *
-     * 1) this might fail if you run out of BPF devices
+     *    1) this might fail if you run out of BPF devices
      *
      * and
      *
-     * 2) opening every interface could leave too few BPF devices
-     *    for *other* programs.
+     *    2) opening every interface could leave too few BPF devices
+     *       for *other* programs.
      *
      * It also means the system could end up getting a lot of traffic
      * that it has to pass through the networking stack and capture
@@ -846,9 +696,11 @@ capture_stat_start(GList *if_list) {
         /* Initialize the cache */
         for (if_entry = if_list; if_entry != NULL; if_entry = g_list_next(if_entry)) {
             if_info = if_entry->data;
-            sc_item = g_malloc0(sizeof(if_stat_cache_item_t));
-            sc_item->name = g_strdup(if_info->name);
-            sc->cache_list = g_list_append(sc->cache_list, sc_item);
+            if (if_info) {
+                sc_item = g_malloc0(sizeof(if_stat_cache_item_t));
+                sc_item->name = g_strdup(if_info->name);
+                sc->cache_list = g_list_append(sc->cache_list, sc_item);
+            }
         }
     }
     return sc;
@@ -909,12 +761,17 @@ void
 capture_stat_stop(if_stat_cache_t *sc) {
     GList *sc_entry;
     if_stat_cache_item_t *sc_item;
+    int ret;
     gchar *msg;
 
     if (!sc)
         return;
 
-    sync_interface_stats_close(&sc->stat_fd, &sc->fork_child, &msg);
+    ret = sync_interface_stats_close(&sc->stat_fd, &sc->fork_child, &msg);
+    if (ret == -1) {
+        /* XXX - report failure? */
+        g_free(msg);
+    }
 
     for (sc_entry = sc->cache_list; sc_entry != NULL; sc_entry = g_list_next(sc_entry)) {
         sc_item = sc_entry->data;