From: Jelmer Vernooij <jelmer@samba.org>
Date: Wed, 31 Mar 2010 01:15:24 +0000 (+0200)
Subject: samba_external: Simplify script to find missing external packages; include subunit... 
X-Git-Url: http://git.samba.org/idra/samba.git/?p=idra%2Fsamba.git;a=commitdiff_plain;h=e4af3afd7ae3e39218b42a42d39c2ec10be9a642

samba_external: Simplify script to find missing external packages; include subunit and testtools as well.
---

diff --git a/source4/scripting/python/samba_external/missing.py b/source4/scripting/python/samba_external/missing.py
index 50bda65a210..082afd83971 100755
--- a/source4/scripting/python/samba_external/missing.py
+++ b/source4/scripting/python/samba_external/missing.py
@@ -2,11 +2,17 @@
 
 # work out what python external libraries we need to install
 
+external_libs = {
+    "dns.resolver": "dnspython", 
+    "subunit": "subunit",
+    "testtools": "testtools"}
+
 list = []
 
-try:
-    import dns.resolver
-except:
-    list.append("dnspython")
+for module, package in external_libs.iteritems():
+    try:
+        __import__(module)
+    except ImportError:
+        list.append(package)
 
 print ' '.join(list)