py_security: Fix comparison between two dom_sid objects

[idra/samba.git] / source4 / librpc / ndr / py_security.c

diff --git a/source4/librpc/ndr/py_security.c b/source4/librpc/ndr/py_security.c
index 2d038cfcca8d06695c040fa8c698ffa101c41488..7f79796ea261a480e474b2dfb6f94634d5bd5747 100644 (file)
--- a/source4/librpc/ndr/py_security.c
+++ b/source4/librpc/ndr/py_security.c
@@ -72,11 +72,19 @@ static PyObject *py_dom_sid_split(PyObject *py_self, PyObject *args)
 static int py_dom_sid_cmp(PyObject *py_self, PyObject *py_other)
 {
        struct dom_sid *self = pytalloc_get_ptr(py_self), *other;
 static int py_dom_sid_cmp(PyObject *py_self, PyObject *py_other)
 {
        struct dom_sid *self = pytalloc_get_ptr(py_self), *other;

+       int val;
+

        other = pytalloc_get_ptr(py_other);
        if (other == NULL)
                return -1;
 
        other = pytalloc_get_ptr(py_other);
        if (other == NULL)
                return -1;
 

-       return dom_sid_compare(self, other);
+       val =  dom_sid_compare(self, other);
+       if (val > 0) {
+               return 1;
+       } else if (val < 0) {
+               return -1;
+       }
+       return 0;

 }
 
 static PyObject *py_dom_sid_str(PyObject *py_self)
 }
 
 static PyObject *py_dom_sid_str(PyObject *py_self)