s3: modules: gluster. Fix the error I made in preventing talloc leaks from a function.
authorJeremy Allison <jra@samba.org>
Tue, 10 Nov 2020 18:18:18 +0000 (10:18 -0800)
committerKarolin Seeger <kseeger@samba.org>
Thu, 19 Nov 2020 12:39:01 +0000 (12:39 +0000)
commita6782e760460d598709481b435fee209dae60de3
tree431dc7c46e06b50ccdc0de2242480250b8a472d0
parent8136ade13f8236ea10f5a2b59b5cb117f3298d76
s3: modules: gluster. Fix the error I made in preventing talloc leaks from a function.

file_lines_parse() plays horrible tricks with
the passed-in talloc pointers and the hierarcy
which makes freeing hard to get right.

As we know mem_ctx is freed by the caller, after
calling file_lines_parse don't free on exit and let the caller
handle it. This violates good Samba coding practice
but we know we're not leaking here.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14486

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Wed Nov 11 15:02:27 UTC 2020 on sn-devel-184

(cherry picked from commit 457b49c67803dd95abc8502c2a410fac273f6fba)
source3/modules/vfs_glusterfs.c