dsdb-acl: attr is not optional to acl_check_access_on_attribute()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 2685a4ed6681b1a20fb26087867737ecbf8fad73)

dsdb-acl: dsdb_attribute_by_lDAPDisplayName() is needed for all attributes

"clearTextPassword" is the only exception.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit d695b8abc7a2e4f7e1853d0c61fe0c03fc786111)

dsdb-acl: introduce a 'el' helper variable to acl_modify()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit ddfb8fe89c493c485250d59868312614c79a9cc1)

dsdb-acl: introduce a 'msg' helper variable to acl_modify()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 71b856a3f08fbd095833c27c59d7ed382be70d2a)

dsdb-schema: make sure we build [system]PossibleInferiors completely

Otherwise callers like dsdb_schema_copy_shallow() will corrupt the
talloc hierarchie.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit c2853f55fc603d4875bb1e50a1cbf409df0421ea)

dsdb-schema: make sure use clean caches in schema_inferiors.c

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 1f673bf9209405dfa2593859bbc45d1c6dc2a960)

dsdb-schema: make schema_subclasses_order_recurse() static

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit c4b9ee255814b8121d13e33cd9b0cd7c093d736c)

dsdb-acl: calculate sDRightsEffective based on "nTSecurityDescriptor"

acl_check_access_on_attribute should never be called with attr=NULL
because we don't check access on an attribute in that case

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Matthieu Patou <mat@matws.net>
Autobuild-User(master): Matthieu Patou <mat@samba.org>
Autobuild-Date(master): Thu Jan 17 11:21:10 CET 2013 on sn-devel-104
(cherry picked from commit 6a1025551eb5b343ec996ae0c642d542162e8910)

dsdb-acl: add helper variable 'ldb' in acl_sDRightsEffective

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Matthieu Patou <mat@matws.net>
(cherry picked from commit ccf577da14194f5f3377226bcdb7e69b62a94851)

libcli/security: don't look at the inherited type in get_ace_object_type()

The inherited_type is only used to decide if aces should be inherited
effectively or not (INHERIT_ONLY) for the specified object.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Matthieu Patou <mat@matws.net>
(cherry picked from commit 629ce2a1ba392f2e8b632752c583843777471378)

dsdb-acl: fix the order of special and system checks

First we check for a special dn, then for system access.
All allocations happen after this checks in order to avoid
allocations we won't use.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Matthieu Patou <mat@matws.net>
(cherry picked from commit 70460605c6132ffbc6be825c24f188674c0ac979)

dsdb-acl: Do not apply ACL on special DNs to hide attributes that the user shouldn't see

This fix frequent reindexing when using python script with a
user that is not system.
The reindexing is caused by ACL module hidding (removing) attributes in
the search request for all attributes in dn=@ATTRIBUTES and because
dsdb_schema_set_indices_and_attributes checks that the list of
attributes that it just calculated from the schema is the same as the
list written in @ATTRIBUTES, if not the list is replaced and a
reindexing is triggered.

Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit a0c59b4da1c5d8637c92e65c7cf54bb82bc8fca5)

dsdb-acl: talloc_free the private context when we pass to the next module

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Matthieu Patou <mat@matws.net>
(cherry picked from commit 961a1fbbbccb7fbb14634ec230985f3fd000b050)

dsdb-acl: don't call dsdb_user_password_support() if we don't use the result

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Matthieu Patou <mat@matws.net>
(cherry picked from commit 947985b259ac05e95d65be19c67f384579a797ce)

dsdb-acl: give error string if we can not obtain the schema

Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 5812eb3c1deac51891f01338b4771b1e397dc24d)

BUG 9474: Downgrade v4 printer driver requests to v3.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Jan 21 16:11:02 CET 2013 on sn-devel-104
(cherry picked from commit 58fadf2f48a2a409b4ee98fdc0166c7f801a7629)

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Wed Jan 23 10:54:31 CET 2013 on sn-devel-104

spoolss: add SPOOLSS_DRIVER_VERSION_2012 (4) define to IDL.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 638ed90620e3c6a35ef56a11c612c13d6b7d6ff5)

BUG 9378: Add extra attributes for AD printer publishing.

Currently attempting to publish a printer in AD fails with "Object class
violation", due to a number of missing attributes in the LDAP request.

Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jan 18 17:27:35 CET 2013 on sn-devel-104

printing: Remove invalid free from error path.

Reviewed-by: Andreas Schneider <asn@samba.org>

BUG 9574: Fix a possible null pointer dereference in spoolss.

If the the client enumerates the printers and didn't specify a
servername we have a null pointer dereference, so the process serving
the connection crashes.

Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Jan 21 13:30:11 CET 2013 on sn-devel-104
(cherry picked from commit c38fb0b106b62e42a5b75b1c78386bb8912c7d7e)

s3-rpc_server: Fix a possible null pointer dereference.

This variable can be set to NULL in an earlier function call.

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
(cherry picked from commit 72e02c73b64f1ff56b2d53ec63d68486a4f1ff90)

samr: Fix bug 9541, make use of posix_openpt

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Mon Jan 21 13:00:07 CET 2013 on sn-devel-104

samr: Split up an assignment from an if condition

docs: document the command line options in dbwrap_tool(1)

Related to bug #9568.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit d67911bafc0d098e67c8ad8d9b4bc49f184ff832)

docs: add popt.common.samba.server and popt.common.samba.client entities

These are comprised by the popt.common.samba entity and the stdarg.server.debug
or the stdarg.client.debut entity, respectively.
The difference is only in the default value of the debug level setting.

Related to bug #9568.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 2d30e5deaf731839402b47751683d2c0e32d2bc7)

docs: fix the stdarg.configfile entity to print a "=" sign after the long option

This makes the appearance equal to the other options like --debuglevel or
--log-basename.

Related to bug #9568.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 2ab3a96d262f60d26a8cd16dded3296889ab7f3f)

docs: use the stdarg.option entity in the popt.common.samba entity

Related to bug #9568.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit e3db3db784085bb2fedbf3063154b7cd77630e59)

docs: add an entity stdarg.option for the "--option" command line parameter

Related to bug #9568.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit c9b95eb205abbdb77960eb0419937512358f7e64)

build(waf): docs-xml: build new dbwrap_tool.8 manual page (fix bug #9568 [2/2])

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit b7a091ecf48963e2a0d1757d0faf131ad8d940fa)

docs-xml: add dbwrap_tool.1 manual page (fix bug #9568 [1/2])

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 8d6104f02d9ab879efe7867fec53cbe5cc408ded)

nsswitch: Fix two bitfield constants being the same.

WBFLAG_PAM_AUTH_PAC and WBFLAG_BIG_NTLMV2_BLOB
are the same causing errors in NTLMv2 authentication.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
The last 2 patches address bug #9575 - Duplicate flags defined in the winbindd
protocol.

Sort winbind request flags. Ira saw we have a duplicate.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed by: Ira Cooper <ira@wakeful.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

vfs: Fix compilation of solaris ACL module

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 26bae894f2ae898c51535dda14060ecf4786c6ec)

Fix bug #9564 - error too few arguments in function
`solarisacl_sys_acl_get_file`.

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Fri Jan 18 11:25:36 CET 2013 on sn-devel-104

wafsamba: use additional xml catalog file (bug #9512)

Add additional "/usr/local/share/xml/catalog" catalog file
platforms (used by freebsd).
Fix manual page build on freebsd.

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit d61d2af3727a19cc4ddc88ec2faa8aafff9c7422)

ntlm_auth(1): fix format and make examples visible (bug #9569)

"<example>" is no child of "<para>". So these examples were not visible.
Using a varlist instead may be not the best way but it does look nice.

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit cabc89a1e72fc95300d4b6f8d480a7d666221b8b)

Fix bug 9550 - sigprocmask does not work on FreeBSD to stop further signals in a signal handler

Mask off signals the correct way from the signal handler.

Signed-off-by: Jeremy Allison <jra@samba.org>
The last 5 patches address bug #9550 - sigprocmask does not work on FreeBSD to
stop further signals in a signal handler.

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Thu Jan 17 21:35:23 CET 2013 on sn-devel-104

Include sys/ucontext.h if available.

Signed-off-by: Jeremy Allison <jra@samba.org>

Add ucontext configure autoconf checks.

Signed-off-by: Jeremy Allison <jra@samba.org>

Add ucontext configure waf checks.

Signed-off-by: Jeremy Allison <jra@samba.org>

Add missing check for sys/wait.h

Signed-off-by: Jeremy Allison <jra@samba.org>

configure: Fix bug 9546, aio_suspend detection on FreeBSD

NULL is not defined without some includes

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Wed Jan 16 11:48:16 CET 2013 on sn-devel-104

smbd: Fix bug 9544, part 2

Plug in async pwrite

smbd: Fix bug 9544, part 1

Adapt the sync function names

smbd: Always compile vfs_commit

There's no reason not to

Fix bug 9548: Correctly detect O_DIRECT

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Tue Jan 15 13:57:56 CET 2013 on sn-devel-104

VERSION: Bump version number up to 4.0.2.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Merge tag 'samba-4.0.1' into v4-0-test

samba: tag release samba-4.0.1

selftest: show that Samba honours "write list" and valid users

Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
The last 19 patches address bug #9518 - conn->share_access appears not be be
reset between users.

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Mon Jan 14 20:44:40 CET 2013 on sn-devel-104

VERSION: Bump version number up to 4.0.1. (CVE-2013-0172)

Signed-off-by: Stefan Metzmacher <metze@samba.org>

WHATSNEW: Update release notes for Samba 4.0.1. (CVE-2013-0172)

Signed-off-by: Stefan Metzmacher <metze@samba.org>

dsdb: Add test for modification of two attributes, one permitted, one denied (bug #9554 - CVE-2013-0172)

Reviewed-by: Stefan Metzmacher <metze@samba.org>

dsdb-acl: Run sec_access_check_ds on each attribute proposed to modify (bug #9554 - CVE-2013-0172)

This seems inefficient, but is needed for correctness.  The
alternative might be to have the sec_access_check_ds code confirm that
*all* of the nodes in the object tree have been cleared to
node->remaining_bits == 0.

Otherwise, I fear that write access to one attribute will become write
access to all attributes.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

libcli/security: Ensure to fill in remaining_access for the initial case (bug #9554 - CVE-2013-0172)

It is critically important that we initialise this element as otherwise
all access is permitted.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>

Fixup the change_to_user_by_session() case as called from become_user_by_session()

Use inside source3/printing/nt_printing.c:get_correct_cversion().

Allow check_user_ok() to be called with vuid==UID_FIELD_INVALID.
All this should do is throw away one entry in the vuid cache.

Signed-off-by: Jeremy Allison <jra@samba.org>

Move create_share_access_mask() from smbd/service.c to smbd/uid.c

Make it static. Only called from uid.c now.

Signed-off-by: Jeremy Allison <jra@samba.org>

Fix bug #9518 - conn->share_access appears not be be reset between users.

Ensure make_connection_snum() uses the same logic as check_user_ok()
to decide if a user can access a share.

Signed-off-by: Jeremy Allison <jra@samba.org>

Factor code out of check_user_ok() into a call to check_user_share_access().

Signed-off-by: Jeremy Allison <jra@samba.org>

Initialize stack variables. Prelude to factoring out calls to check_user_share_access().

Signed-off-by: Jeremy Allison <jra@samba.org>

Add check_user_share_access()

This factors out the share security and read_only flag
setting code so this can be called from both make_connection_snum()
as well as check_user_ok(). Gives a consistent share security
check function.

Signed-off-by: Jeremy Allison <jra@samba.org>

Correctly setup the conn->share_access based on the current user token.

Also use this to set conn->read_only. Cache the share_access
so we only evaluate this once per new user access on this share.

Signed-off-by: Jeremy Allison <jra@samba.org>

Add parallel cache for share_access entries, one per connection struct.

Needed as we cannot change the VFS ABI for 4.0.x, but need to add the
equivalent of 'uint32_t share_access' to the struct vuid_cache referenced
in connection_struct.

Exports 2 accessor functions - lifetime managed by talloc on the conn
struct list.

Signed-off-by: Jeremy Allison <jra@samba.org>

Change API for create_share_access_mask() - remove conn struct.

Eventually this will be indepentent of conn, just pass in the
readonly flag.

Signed-off-by: Jeremy Allison <jra@samba.org>

Change API for create_share_access_mask() to pass in the token.

Don't automatically use the one from conn->session_info->security_token.

Signed-off-by: Jeremy Allison <jra@samba.org>

Fix API for create_share_access_mask().

Return the uint32_t share_access rather than directly
changing the conn struct.

Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 33167c070c085b30569317666a3fca079d970321)

Remove static from create_share_access_mask().

Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 48187220ff47efe70616361fcef1a794aef765b4)

Remove unneeded variable "const struct auth_session_info *session_info"

Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 5a3cda176f5eecd65b289c74132b0126357c5ef0)

Remove dead code now vuser can no longer be NULL.

Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit d35ba04e25eb3c396f791ea80c0ebb74543d4005)

Remove the second set of {} braces, no longer needed. (cherry picked from commit ed0a34d163f777b2a0d4a2b358b7fb1b170d7686)

Remove one set of enclosing {} braces, no longer needed.

Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit d64ea67c78a5b09559971ff6953cd67feb2b1ec2)

Move the definition of struct vuid_cache_entry *ent outside blocks.

Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 092c9517acf5a4b11577ef7b5f1d645e5e463f6d)

Start to tidy-up check_user_ok().

Now we have removed "security=share" we cannot be
called with vuid == UID_FIELD_INVALID.

Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f0450e0d80c2ff56c4834b2f1271a7f84132ca5b)

s3:smb2_negprot: set the 'remote_proto' value (bug #9499)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 5d721de7fdc250c6cb423c553134dd687590c1a0)

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Fri Jan 11 18:01:07 CET 2013 on sn-devel-104

smb.conf(5): update list of available protocols (bug #9552)

Update protocol listing in variable substitution list.

Signed-off-by: Bjoern Baumbach <bb@sernet.de>
Reviewed by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan  9 21:22:18 CET 2013 on sn-devel-104
(cherry picked from commit 313da9dc7d8cb16f943ea7bde1c1d7bf8f02c0f0)

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Fri Jan 11 12:26:50 CET 2013 on sn-devel-104

samba_dnsupdate: set KRB5_CONFIG for nsupdate command (bug #9517)

Let nslookup use krb5.conf, which is set in our KRB5_CONFIG.

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 4d1fd0b7daa089bd8863f0efcaf258bf30192c29)

s4:drsuapi: try to behave more like windows for usn order (bug #9508)

We don't behave completely like a Windows server, but it's much more
identical than before.

The partition head is always the first object followed by the rest
sorted by uSNChanged.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Jan  1 21:09:42 CET 2013 on sn-devel-104
(cherry picked from commit f77bfed088b93f3ed0f00d0c172ad495c6c2b09b)

s4:drsuapi: make use of LDB_TYPESAFE_QSORT() and pass getnc_state

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 16aef75c4f83c114206aa7637fedc9c2c2486877)

s4:drsuapi: make sure we report the meta data from the cycle start (bug #9508)

We should build the final highwatermark and uptodatevector of
a replication cycle at the start of the cycle. Before we
search for the currently missing objects.

Otherwise we risk that some objects get lost.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 88833b089a90e8f685d15b508f2e4615afb3a16f)

s4:drsuapi: check the source_dsa_invocation_id (bug #9508)

The given highwatermark is only valid relative to the
specified source_dsa_invocation_id.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 1f89d641d09ef983f6a5055bb75099dc0ce57aa8)

s4:drsuapi: make sure we never return the same highwatermark twice in a replication cycle (bug #9508)

If the highwatermark given by the client is not the one we expect,
we need to start a new replication cycle. Otherwise the destination dsa
skips objects and linked attribute values.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 91f7f2c04fd00e281b0755a331ca632a4905e3b5)

s4:drsuapi: add drsuapi_DsReplicaHighWaterMark_cmp()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 7e511b58318cef1b325a8191685ee156a7fc0cb7)

s4:drsuapi: always use the current uptodateness_vector

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 02de5b140cfe6ea31e0686e5f0ff726a22153020)

s4:drsuapi: avoid a ldb_dn_copy() and use talloc_move() instead

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 025c6d62f3c1b0f760aaacb7b3960135319031da)

s4:drsuapi: remove unused 'highest_usn' from drsuapi_getncchanges_state

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 30be17bc5d6b3cf2ee0aef6663af78b153b2ab9a)

s4:drsuapi: move struct drsuapi_getncchanges_state to the top of getncchanges.c

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 551bb2ccea6a1d82dbe0d4a21c19a8d8bd13ccbc)

s4:dsdb/drepl: update the source_dsa_obj/invocation_id in repsFrom

The highwatermark is relative to the source_dsa_invocation_id.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 2e9b06412b09163d4b851135ef509d73bb6d61fc)

s4:dsdb/common: use 01.01.1970 as last_sync_success for our entry in the uptodatevector

This matches a Windows 2008R2 and 2012 server.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit e7a26d02413005294180a1d9cd4c90d4ac4d9733)

s4:dsdb/common: use LDB_SEQ_HIGHEST_SEQ for our entry in the uptodatevector

We should use the global highestCommittedUSN, not the per partition value.

This matches a Windows 2008R2 and 2012 server.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 81fa179b155a62f2f652fbb1fc4978c9f6eb5462)

s4:dsdb/repl_meta_data: don't merge highwatermark and uptodatevector (bug #9508)

We should not do any magic regarding the highwatermark we got from
the source dsa. We need to treat it as opaque and not try to be smart
and merge it into the uptodatevector.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 5ecbc892b5226d3d31da2c62ae5261a8d8a73072)

s4:dsdb/repl_meta_data: also update the last_sync_success in replUpToDateVector

This matches Windows 2008R2 and Windows 2012.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit ad43bb6086a7dbf48b405d0372ae85d2244384d9)

s4:dsdb/repl_meta_data: store the last results and timestamps in the repsFrom

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 634f8cf7c43bd60507d842d35cf46c0017e34dce)

s4:dsdb/repl_meta_data: always treat the highwatermark as opaque (bug #9508)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit a37f46a9a83a03157276485eb583649b36fb6ee1)

s4:scripting/python: always treat the highwatermark as opaque (bug #9508)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 257ae5443631e645842cfcc9c1cedce6c41d5afa)

s4:lib/messaging: terminate the irpc_servers_byname() result with server_id_set_disconnected() (bug #9540)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 8d9a77f8646cd26371dc2ec1d3ed52730ac19eb9)

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Thu Jan 10 11:46:05 CET 2013 on sn-devel-104

smbd: Fix bug 9549 -- Memleak in the async echo handler

Reviewed by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jan  8 23:30:41 CET 2013 on sn-devel-104
(cherry picked from commit 3d5c534f0cc7c6e3eead7462eef4a178c7035857)

docs: Fix typo in vfs_tsmsm.8.xml.

Reviewed-by: Karolin Seeger <kseeger@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Wed Jan  2 12:12:12 CET 2013 on sn-devel-104
(cherry picked from commit 6cb7c4f45e1657245443c3bcc6dab219e5f1d9b5)

Fix bug #9530 - Typo in vfs_tsmsm.8.xml.

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Wed Jan  2 14:25:40 CET 2013 on sn-devel-104

docs: Remove superfluous bracket.

Reviewed-by: Karolin Seeger <kseeger@samba.org>
(cherry picked from commit ab43e2db64ae3ef387ceb0e7e6a6f82c9e6d301d)

Fix bug 9528 - Superfluous bracket in samba.8.xml.

Fix bug #9196 - defer_open is triggered multiple times on the same request.

get_deferred_open_message_state_smb2() is buggy in that it is checking
the wrong things to determine if an open is in the deferred state.

It checks if (smb2req->async_te == NULL) which is incorrect,
as we're not always async in a deferred open - remove this.

It should check instead state->open_was_deferred as this
is explicity set to 'true' when an open is going deferred,
so add this check.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Dec 18 14:19:13 CET 2012 on sn-devel-104
(cherry picked from commit 2148d86c7a2facd6e128b753aef98722843af3e1)

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Wed Jan  2 12:18:40 CET 2013 on sn-devel-104

VERSION: Bump version number up to 4.0.1.

And re-enable git snapshots.

Karolin

VERSION: Bump version number up to 4.0.0.

And disable git snapshots.

Karolin

WHATSNEW: Update changes since rc6.

Karolin