tridge/samba.git
11 years agos4-dsdb: use ldb_operr() in the dsdb code ldb-error
Andrew Tridgell [Tue, 6 Jul 2010 03:21:54 +0000 (13:21 +1000)]
s4-dsdb: use ldb_operr() in the dsdb code

this replaces "return LDB_ERR_OPERATIONS_ERROR" with "return ldb_operr(ldb)"
in places in the dsdb code where we don't already explicitly set an
error string. This should make is much easier to track down dsdb
module bugs that result in an operations error.

11 years agos4-ldb: added ldb_error() and ldb_operr()
Andrew Tridgell [Tue, 6 Jul 2010 03:20:19 +0000 (13:20 +1000)]
s4-ldb: added ldb_error() and ldb_operr()

These will be used to help avoid the problem we have with hundreds of
places that do "return LDB_ERR_OPERATIONS_ERROR" without an
explanation. It is very difficult to track down ldb errors which don't
have any explanation.

By replacing "return LDB_ERR_OPERATIONS_ERROR;" with "return ldb_operr(ldb);"
we at least get a file:line message in the ldb error string. It isn't
an ideal error message, but it is much better than just "operations
error"

This change also makes ldb_oom() return the error code
(LDB_ERR_OPERATIONS_ERROR) so you can do:

  return ldb_oom(ldb);

instead of:

  ldb_oom(ldb);
  return LDB_ERR_OPERATIONS_ERROR;

11 years agoChanged passwords.py to use the correct account as acl checks now pass.
Nadezhda Ivanova [Sun, 4 Jul 2010 21:20:37 +0000 (00:20 +0300)]
Changed passwords.py to use the correct account as acl checks now pass.

11 years agos4-dsdb: Implementation of User-Change-Password and User-Force-Password-Change
Nadezhda Ivanova [Sun, 4 Jul 2010 21:17:38 +0000 (00:17 +0300)]
s4-dsdb: Implementation of User-Change-Password and User-Force-Password-Change

    These CARs need to be checked on password change and password reset operations.
    Apparently the password attributes are not influenced by Write Property.
    Single detele operations and modifications of dBCSPwd are let through to the
    password_hash module. This is determined experimentally.

11 years agos4:subtree_rename LDB module - Cosmetic fixes
Matthias Dieter Wallnöfer [Sun, 4 Jul 2010 08:41:17 +0000 (10:41 +0200)]
s4:subtree_rename LDB module - Cosmetic fixes

11 years agos4:subtree_delete LDB module - fix comments and add my copyright
Matthias Dieter Wallnöfer [Sun, 4 Jul 2010 08:23:41 +0000 (10:23 +0200)]
s4:subtree_delete LDB module - fix comments and add my copyright

(I've introduced the subtree delete mechanism)

11 years agos4:wb_cmd_list_groups.c - don't crash when we don't get any group at all
Matthias Dieter Wallnöfer [Sun, 4 Jul 2010 19:22:28 +0000 (21:22 +0200)]
s4:wb_cmd_list_groups.c - don't crash when we don't get any group at all

11 years agos4:wb_cmd_list_groups.c - indentation and comment fixes
Matthias Dieter Wallnöfer [Sun, 4 Jul 2010 19:19:36 +0000 (21:19 +0200)]
s4:wb_cmd_list_groups.c - indentation and comment fixes

11 years agos4:libnet - add missing "talloc_free"s for "c" contexts on "recv" operations
Matthias Dieter Wallnöfer [Sun, 4 Jul 2010 18:04:28 +0000 (20:04 +0200)]
s4:libnet - add missing "talloc_free"s for "c" contexts on "recv" operations

11 years agos3: Remove an unused variable -- thanks, metze!
Volker Lendecke [Sun, 4 Jul 2010 18:04:55 +0000 (20:04 +0200)]
s3: Remove an unused variable -- thanks, metze!

11 years agos3: Remove unused msg_flags from connections.tdb
Volker Lendecke [Sun, 4 Jul 2010 18:45:43 +0000 (20:45 +0200)]
s3: Remove unused msg_flags from connections.tdb

This breaks rolling code upgrade!

11 years agos3: Replace register_message_flags() with serverid_register_msg_flags()
Volker Lendecke [Sun, 4 Jul 2010 18:40:46 +0000 (20:40 +0200)]
s3: Replace register_message_flags() with serverid_register_msg_flags()

message_send_all is now done by walking the serverid.tdb, not the
connections.tdb anymore.

Günther, Simo, please check!

11 years agos3: Use msg_ctx->id in messaging
Volker Lendecke [Sun, 4 Jul 2010 14:41:51 +0000 (16:41 +0200)]
s3: Use msg_ctx->id in messaging

This removes some references to procid_self() deep inside the code

11 years agos3: Pass the new server_id through reinit_after_fork
Volker Lendecke [Sun, 4 Jul 2010 14:28:13 +0000 (16:28 +0200)]
s3: Pass the new server_id through reinit_after_fork

11 years agos3: Re-initialize the server_id in messaging_reinit
Volker Lendecke [Sun, 4 Jul 2010 14:18:12 +0000 (16:18 +0200)]
s3: Re-initialize the server_id in messaging_reinit

11 years agos3: Fix some type-punned warnings
Volker Lendecke [Sun, 4 Jul 2010 14:09:09 +0000 (16:09 +0200)]
s3: Fix some type-punned warnings

11 years agos3: Fix some nested extern warnings
Volker Lendecke [Sun, 4 Jul 2010 14:08:59 +0000 (16:08 +0200)]
s3: Fix some nested extern warnings

11 years agos3: Remove serverid_[de]register_self
Volker Lendecke [Sun, 4 Jul 2010 14:08:03 +0000 (16:08 +0200)]
s3: Remove serverid_[de]register_self

This removes some deep references to procid_self()

11 years agos3: ALWAYS run make test before checkin ....
Volker Lendecke [Sun, 4 Jul 2010 12:59:23 +0000 (14:59 +0200)]
s3: ALWAYS run make test before checkin ....

11 years agos3: Slight reshaping of server_exists_parse
Volker Lendecke [Sun, 4 Jul 2010 12:35:05 +0000 (14:35 +0200)]
s3: Slight reshaping of server_exists_parse

Doing a copy and then do the compare is a bit pointless, use memcmp

11 years agos3: Don't attempt to deregister from serverid twice
Volker Lendecke [Sun, 4 Jul 2010 11:46:48 +0000 (13:46 +0200)]
s3: Don't attempt to deregister from serverid twice

The parent has to take care of crashed child processes anyway, so we don't have
to clean up in the child

11 years agos3: Fix bug 7338, smbget skips leading slash when using a custom outputfile
Volker Lendecke [Sun, 4 Jul 2010 09:32:50 +0000 (11:32 +0200)]
s3: Fix bug 7338, smbget skips leading slash when using a custom outputfile

11 years agos3: Fix some nonempty blank lines
Volker Lendecke [Sun, 4 Jul 2010 09:02:21 +0000 (11:02 +0200)]
s3: Fix some nonempty blank lines

11 years agos3: Fix bug 7336: Enable idmap_passdb module build as shared
Volker Lendecke [Sun, 4 Jul 2010 08:01:42 +0000 (10:01 +0200)]
s3: Fix bug 7336: Enable idmap_passdb module build as shared

11 years agowbinfo: Fix error messages
Volker Lendecke [Sat, 3 Jul 2010 20:41:23 +0000 (22:41 +0200)]
wbinfo: Fix error messages

11 years agos4:torture/rpc/samlogon.c - strip trailing whitespaces
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 19:09:06 +0000 (21:09 +0200)]
s4:torture/rpc/samlogon.c - strip trailing whitespaces

11 years agos4:torture/rpc/samlogon.c - provide a function which sets and afterwards resets the...
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 19:04:47 +0000 (21:04 +0200)]
s4:torture/rpc/samlogon.c - provide a function which sets and afterwards resets the minimum password age

This is needed since we on s4 do now use the Windows Server standard of 1 day.

11 years agos4:kinit blackbox test - set/reset also here the "minPwdAge"
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 13:52:00 +0000 (15:52 +0200)]
s4:kinit blackbox test - set/reset also here the "minPwdAge"

11 years agos4:dsdb/tests/python/ldap_schema.py - remove a now useless "schemaUpdateNow" request
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 13:37:45 +0000 (15:37 +0200)]
s4:dsdb/tests/python/ldap_schema.py - remove a now useless "schemaUpdateNow" request

"schemaUpdateNow" on s4 is now a non-op and therefore not strictly needed anymore.

11 years agos4:urgent_replication.py test - remove unneeded "relax" control parameters
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 12:52:18 +0000 (14:52 +0200)]
s4:urgent_replication.py test - remove unneeded "relax" control parameters

11 years agos4:schema_load LDB module - fix a segfault condition on schema refresh
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 12:33:23 +0000 (14:33 +0200)]
s4:schema_load LDB module - fix a segfault condition on schema refresh

The schema refresh operation itself starts requests from the top of the LDB
modules stack (see call "dsdb_schema_set_attributes" - search operations).
This doesn't work well when these do perform "dsdb_get_schema" calls. Since the
new schema isn't marked as "refreshed" atm (but in fact it still is - we didn't
terminate the reload/refresh yet) we could perform other calls to
"dsdb_schema_refresh" and run into serious trouble (segfault).

11 years agos4:schema_set.c - Fix a comment
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 12:07:44 +0000 (14:07 +0200)]
s4:schema_set.c - Fix a comment

11 years agos4:dsdb_schema_set_attributes - remove unneeded filter criterias
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 12:05:04 +0000 (14:05 +0200)]
s4:dsdb_schema_set_attributes - remove unneeded filter criterias

We already choose the right entry by specifying the right basedn with scope
"LDB_SCOPE_BASE".

11 years agos4:dsdb_module_load_partition_usn - check for "res->count" equal/unequal to 1
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 10:47:46 +0000 (12:47 +0200)]
s4:dsdb_module_load_partition_usn - check for "res->count" equal/unequal to 1

11 years agos4:schema_set.c - fix typo
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 10:36:34 +0000 (12:36 +0200)]
s4:schema_set.c - fix typo

11 years agos4:schema_load.c - jump to "failed" on an error condition
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 10:35:16 +0000 (12:35 +0200)]
s4:schema_load.c - jump to "failed" on an error condition

11 years agos4:setup/provision_basedn_modify.ldif - set "minPwdAge" to the right value
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 08:56:14 +0000 (10:56 +0200)]
s4:setup/provision_basedn_modify.ldif - set "minPwdAge" to the right value

Now we should have fixed all password related tests to cooperate with this value

11 years agos4:pwsettings net utility - change also here the "minPwdAge" to be the real default
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 09:27:20 +0000 (11:27 +0200)]
s4:pwsettings net utility - change also here the "minPwdAge" to be the real default

Which is one day.

11 years agos4:blackbox/test_passwords.sh - perform also here the adaptions for "minPwdAge" != 0
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 09:23:39 +0000 (11:23 +0200)]
s4:blackbox/test_passwords.sh - perform also here the adaptions for "minPwdAge" != 0

11 years agos4:dsdb/tests/passwords.py - set and reset the "minPwdAge" properly
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 09:07:10 +0000 (11:07 +0200)]
s4:dsdb/tests/passwords.py - set and reset the "minPwdAge" properly

After a patch proposal of Nadya and some reflection I think that it's really
worth to change all tests which need a "0" "minPwdAge" to set it manually and
reset the default afterwards.

So we can finally introduce the default "minPwdAge" on provision.

Patch proposal by: Nadya Ivanova

11 years agoTests for user-change-password and force-password-change access rights
Nadezhda Ivanova [Fri, 2 Jul 2010 13:38:05 +0000 (16:38 +0300)]
Tests for user-change-password and force-password-change access rights

11 years agos3-net: forgot to set type in winreg getvalue operation.
Günther Deschner [Fri, 2 Jul 2010 11:08:00 +0000 (13:08 +0200)]
s3-net: forgot to set type in winreg getvalue operation.

Guenther

11 years agos4/schema: remove unnecessary deletion of dsdb_schema cached pointer
Anatoliy Atanasov [Fri, 2 Jul 2010 08:39:39 +0000 (11:39 +0300)]
s4/schema: remove unnecessary deletion of dsdb_schema cached pointer

This is needed so we can find and free old schemas based using
the cached pointer

11 years agos3-registry: remove 2 byte winreg type limitation.
Günther Deschner [Thu, 1 Jul 2010 09:22:20 +0000 (11:22 +0200)]
s3-registry: remove 2 byte winreg type limitation.

We already pull and push 4 byte winreg type in the registry.tdb, we were just
not using full 4 bytes within the reg_object functions.

With this change we finally pass the set extended value torture test.

Guenther

11 years agos3-registry: allow to read NULL entries (that we allow to store) back from the tdb.
Günther Deschner [Thu, 1 Jul 2010 13:50:58 +0000 (15:50 +0200)]
s3-registry: allow to read NULL entries (that we allow to store) back from the tdb.

Guenther

11 years agos4-smbtorture: enable extended SetValue test against Samba3.
Günther Deschner [Thu, 1 Jul 2010 01:04:39 +0000 (03:04 +0200)]
s4-smbtorture: enable extended SetValue test against Samba3.

Guenther

11 years agos3-registry: remove unused reg_util_marshalling code.
Günther Deschner [Thu, 1 Jul 2010 00:57:19 +0000 (02:57 +0200)]
s3-registry: remove unused reg_util_marshalling code.

Guenther

11 years agos3-registry: avoid using registry_value union.
Günther Deschner [Tue, 29 Jun 2010 14:13:15 +0000 (16:13 +0200)]
s3-registry: avoid using registry_value union.

Just pull and push data as is.

Guenther

11 years agos4-ldb: fixed error handling in openldap backend
Andrew Tridgell [Fri, 2 Jul 2010 01:39:28 +0000 (11:39 +1000)]
s4-ldb: fixed error handling in openldap backend

fixed several bugs in error handling. the ldb context was used without
being initialised in the error paths, and several error paths did not
set an ldb error string.

11 years agos4-ldb: fixed the parsing of references in the openldap backend
Andrew Tridgell [Fri, 2 Jul 2010 01:37:50 +0000 (11:37 +1000)]
s4-ldb: fixed the parsing of references in the openldap backend

We need to use ldap_parse_reference() not ldap_parse_result()

11 years agos4-dsdb: fixed use after free of sasl mechanisms opaque
Andrew Tridgell [Wed, 30 Jun 2010 03:49:05 +0000 (13:49 +1000)]
s4-dsdb: fixed use after free of sasl mechanisms opaque

the supportedSASLMechanisms opaque must live for at least as long as
the ldb, or we can crash when the first connection is torn down

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-dsdb: fixed spelling of supportedSASLMechanisms
Andrew Tridgell [Wed, 30 Jun 2010 03:47:29 +0000 (13:47 +1000)]
s4-dsdb: fixed spelling of supportedSASLMechanisms

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4:dsdb Ensure we free old schema copies
Andrew Bartlett [Wed, 30 Jun 2010 13:25:32 +0000 (23:25 +1000)]
s4:dsdb Ensure we free old schema copies

It was reported by aatanasov that we kept around one whole schema per
modification made.  This does not fix that, but I hope moves us closer
to a fix

The most important part of the fix is that:

- if (schema_out != schema_in) {
- talloc_unlink(schema_in, ldb);
- }

was the wrong way around.  This is now handled in the schema_set calls.

Andrew Bartlett

11 years agos4/dsdb: Assert DSDB_FLAG_*_MODULE is always passed in function call
Kamen Mazdrashki [Thu, 1 Jul 2010 20:47:02 +0000 (23:47 +0300)]
s4/dsdb: Assert DSDB_FLAG_*_MODULE is always passed in function call

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4-source4/dsdb/samdb/ldb_modules/util.c Use DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:29:05 +0000 (21:29 +0300)]
s4-source4/dsdb/samdb/ldb_modules/util.c Use DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4-source4/dsdb/samdb/ldb_modules/subtree_delete.c: Use DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:28:46 +0000 (21:28 +0300)]
s4-source4/dsdb/samdb/ldb_modules/subtree_delete.c: Use DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4-source4/dsdb/samdb/ldb_modules/schema_load.c: Use DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:28:30 +0000 (21:28 +0300)]
s4-source4/dsdb/samdb/ldb_modules/schema_load.c: Use DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4-source4/dsdb/samdb/ldb_modules/samldb.c: Use DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:28:10 +0000 (21:28 +0300)]
s4-source4/dsdb/samdb/ldb_modules/samldb.c: Use DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4-source4/dsdb/samdb/ldb_modules/samba3sid.c: Use DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:27:51 +0000 (21:27 +0300)]
s4-source4/dsdb/samdb/ldb_modules/samba3sid.c: Use DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4-source4/dsdb/samdb/ldb_modules/rootdse.c: Use DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:27:32 +0000 (21:27 +0300)]
s4-source4/dsdb/samdb/ldb_modules/rootdse.c: Use DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4-source4/dsdb/samdb/ldb_modules/ridalloc.c: Use DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:26:53 +0000 (21:26 +0300)]
s4-source4/dsdb/samdb/ldb_modules/ridalloc.c: Use DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4-source4/dsdb/samdb/ldb_modules/repl_meta_data.c: Use DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:26:07 +0000 (21:26 +0300)]
s4-source4/dsdb/samdb/ldb_modules/repl_meta_data.c: Use DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4-dsdb/samdb/ldb_modules/linked_attributes.c: make use of DSDB_FLAG_NEXT_MODULE...
Kamen Mazdrashki [Mon, 28 Jun 2010 18:25:28 +0000 (21:25 +0300)]
s4-dsdb/samdb/ldb_modules/linked_attributes.c: make use of DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4/dsdb: Add DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:07:51 +0000 (21:07 +0300)]
s4/dsdb: Add DSDB_FLAG_NEXT_MODULE flag

Although it is not currently used in implementation,
my intention is for callers to clearly state what
action they want to execute.

Currently when a caller wants to pass the call to the next
module in the chain, this flag is either omitted or 0 is used
(which is somewhat hacky, isn't it)

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos3:auth Fix switch statement referencing a uninitialized variable
Simo Sorce [Thu, 1 Jul 2010 21:47:46 +0000 (17:47 -0400)]
s3:auth Fix switch statement referencing a uninitialized variable

Looking at the original commit (9a747d500fad699038ecf75615c680a9fd9e4cc7)
this seem the right solution.

Andrew please check.

11 years agos3-nss_info: only include nss_info.h where needed.
Günther Deschner [Wed, 30 Jun 2010 22:44:15 +0000 (00:44 +0200)]
s3-nss_info: only include nss_info.h where needed.

Guenther

11 years agos3-libads: move ldap posix schema defines to their own header file.
Günther Deschner [Wed, 30 Jun 2010 21:48:34 +0000 (23:48 +0200)]
s3-libads: move ldap posix schema defines to their own header file.

Guenther

11 years agos3-libads: move spnego defines to their appropriate header file.
Günther Deschner [Wed, 30 Jun 2010 21:47:03 +0000 (23:47 +0200)]
s3-libads: move spnego defines to their appropriate header file.

Guenther

11 years agos3-libads: only include libds flags where needed.
Günther Deschner [Wed, 30 Jun 2010 21:38:57 +0000 (23:38 +0200)]
s3-libads: only include libds flags where needed.

Guenther

11 years agos3-libads: move keytab macros out of ads.h.
Günther Deschner [Wed, 30 Jun 2010 21:20:22 +0000 (23:20 +0200)]
s3-libads: move keytab macros out of ads.h.

Guenther

11 years agos3-libads: move ads_dns out of main includes.
Günther Deschner [Wed, 30 Jun 2010 20:36:40 +0000 (22:36 +0200)]
s3-libads: move ads_dns out of main includes.

Guenther

11 years agos3-libads: move ads_status to a separate header file.
Günther Deschner [Mon, 31 May 2010 10:51:58 +0000 (12:51 +0200)]
s3-libads: move ads_status to a separate header file.

Guenther

11 years agos3-libads: move ads_protos.h to ads_ldap_protos.h.
Günther Deschner [Mon, 31 May 2010 10:51:29 +0000 (12:51 +0200)]
s3-libads: move ads_protos.h to ads_ldap_protos.h.

Guenther

11 years agos3-waf: fix the build after smbd/change_trust_pw.c removal.
Günther Deschner [Thu, 1 Jul 2010 21:15:13 +0000 (23:15 +0200)]
s3-waf: fix the build after smbd/change_trust_pw.c removal.

Guenther

11 years agotdb: fix the build on mac os x 10.6.4.
Günther Deschner [Thu, 3 Jun 2010 17:05:43 +0000 (19:05 +0200)]
tdb: fix the build on mac os x 10.6.4.

Guenther

11 years agos3-libnet_join: small IDL enhancement.
Günther Deschner [Wed, 30 Jun 2010 23:19:39 +0000 (01:19 +0200)]
s3-libnet_join: small IDL enhancement.

Guenther

11 years agos3-libads: use shared well known guids.
Günther Deschner [Wed, 30 Jun 2010 21:09:05 +0000 (23:09 +0200)]
s3-libads: use shared well known guids.

Guenther

11 years agos3-libads: move KRB5_ENV_CCNAME to separate header krb5_env.h.
Günther Deschner [Wed, 30 Jun 2010 20:32:00 +0000 (22:32 +0200)]
s3-libads: move KRB5_ENV_CCNAME to separate header krb5_env.h.

Guenther

11 years agos4:dsdb/tests/python/passwords.py - add the right result codes for user password...
Matthias Dieter Wallnöfer [Thu, 1 Jul 2010 15:23:01 +0000 (17:23 +0200)]
s4:dsdb/tests/python/passwords.py - add the right result codes for user password changes

They will be enabled once the ACL modules supports it. It was my fault to not
import them earlier.

11 years agos4:lib/registry/ldb.c - free some "msg" objects earlier through explicit "talloc_free"s
Matthias Dieter Wallnöfer [Thu, 1 Jul 2010 14:35:12 +0000 (16:35 +0200)]
s4:lib/registry/ldb.c - free some "msg" objects earlier through explicit "talloc_free"s

No other functional change

11 years agos4:registry - move some common constraint checks to the "local" backend
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 14:10:32 +0000 (16:10 +0200)]
s4:registry - move some common constraint checks to the "local" backend

They should also be enforced when we don't use "ldb".

11 years agos4:lib/registry/tests/registry.c - test recursive key generation
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 16:27:49 +0000 (18:27 +0200)]
s4:lib/registry/tests/registry.c - test recursive key generation

11 years agos4:registry - on key add operations we have to handle with paths not always only...
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 16:08:47 +0000 (18:08 +0200)]
s4:registry - on key add operations we have to handle with paths not always only a name

Recursive key generations are allowed.

11 years agos4:lib/registry/local.c - support recursive key generation
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 13:45:37 +0000 (15:45 +0200)]
s4:lib/registry/local.c - support recursive key generation

Code taken from "local_open_key".

11 years agos4:lib/registry/ldb.c - refactor "reg_path_to_ldb"
Matthias Dieter Wallnöfer [Thu, 24 Jun 2010 19:12:19 +0000 (21:12 +0200)]
s4:lib/registry/ldb.c - refactor "reg_path_to_ldb"

This makes it easier to understand and would also support splitting in more
DN components.

11 years agos4:lib/registry/ldb.c - use "ldb_path" rather than "ldap_path" as LDB key varibale...
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 15:37:45 +0000 (17:37 +0200)]
s4:lib/registry/ldb.c - use "ldb_path" rather than "ldap_path" as LDB key varibale identifiers

11 years agos4:lib/registry/ldb.c - "ldb_add_key" - fix talloc handling
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 13:52:19 +0000 (15:52 +0200)]
s4:lib/registry/ldb.c - "ldb_add_key" - fix talloc handling

- free "msg" when possible
- prevent "talloc_strdup"s where not necessary

11 years agos3-printing: Fix Bug #7541, %D in "printer admin" causing smbd crash.
Günther Deschner [Thu, 1 Jul 2010 11:46:55 +0000 (13:46 +0200)]
s3-printing: Fix Bug #7541, %D in "printer admin" causing smbd crash.

Guenther

11 years agos3-registry: fix malloc/talloc mismatch upon free in reg_enumvalue().
Günther Deschner [Wed, 30 Jun 2010 23:22:11 +0000 (01:22 +0200)]
s3-registry: fix malloc/talloc mismatch upon free in reg_enumvalue().

Guenther

11 years agos4-smbtorture: in extended setvalue winreg test, reduce max random buffer length...
Günther Deschner [Wed, 30 Jun 2010 15:13:42 +0000 (17:13 +0200)]
s4-smbtorture: in extended setvalue winreg test, reduce max random buffer length to 16 bytes.

Guenther

11 years agos3-docs: try to make "default case" explanation a little clearer.
Günther Deschner [Wed, 30 Jun 2010 11:25:28 +0000 (13:25 +0200)]
s3-docs: try to make "default case" explanation a little clearer.

Guenther

11 years agos3-libsmb: move change_trust_account_password out of smbd into libsmb.
Günther Deschner [Wed, 30 Jun 2010 10:10:55 +0000 (12:10 +0200)]
s3-libsmb: move change_trust_account_password out of smbd into libsmb.

Guenther

11 years agos4-smbtorture: enable QueryMultipleValues{2} torture tests against samba3.
Günther Deschner [Wed, 30 Jun 2010 00:07:15 +0000 (02:07 +0200)]
s4-smbtorture: enable QueryMultipleValues{2} torture tests against samba3.

Guenther

11 years agos3-winreg: implement _winreg_QueryMultipleValues().
Günther Deschner [Wed, 30 Jun 2010 14:31:46 +0000 (16:31 +0200)]
s3-winreg: implement _winreg_QueryMultipleValues().

Guenther

11 years agos3-winreg: implement _winreg_QueryMultipleValues2().
Günther Deschner [Wed, 30 Jun 2010 00:03:27 +0000 (02:03 +0200)]
s3-winreg: implement _winreg_QueryMultipleValues2().

Guenther

11 years agos3-registry: add reg_querymultiplevalues() to reg_api.
Günther Deschner [Wed, 30 Jun 2010 00:02:43 +0000 (02:02 +0200)]
s3-registry: add reg_querymultiplevalues() to reg_api.

Guenther

11 years agos4-smbtorture: add some more multiple_values_tests to RPC-WINREG.
Günther Deschner [Wed, 30 Jun 2010 15:13:14 +0000 (17:13 +0200)]
s4-smbtorture: add some more multiple_values_tests to RPC-WINREG.

Guenther

11 years agos4:dsdb: move dsdb python tests from lib/ldb/ to dsdb/
Stefan Metzmacher [Wed, 30 Jun 2010 09:09:10 +0000 (11:09 +0200)]
s4:dsdb: move dsdb python tests from lib/ldb/ to dsdb/

metze

11 years agos4:ldb/python: make it possible to run tests standalone
Stefan Metzmacher [Wed, 30 Jun 2010 08:57:37 +0000 (10:57 +0200)]
s4:ldb/python: make it possible to run tests standalone

metze

11 years agolibcli: Fixed a build warning for a missing prototype.
Andreas Schneider [Wed, 30 Jun 2010 08:19:07 +0000 (10:19 +0200)]
libcli: Fixed a build warning for a missing prototype.