s3-winbindd_ads: prevent negative GM/ cache entries due to broken connections
authorMichael Adam <obnox@samba.org>
Thu, 20 Nov 2008 15:57:44 +0000 (16:57 +0100)
committerMichael Adam <obnox@samba.org>
Fri, 21 Nov 2008 22:32:29 +0000 (23:32 +0100)
The ads lookup_groupmem() function calls lda_lookupsids to resolve sids
to names. This is tried only once. So in case the connection was broken,
e.g. closed by the server (without a reset packet), there will be an empty
GM/ cache entry for the requested group which will prevent proper working
of access checks among other checks for the expiry period.

This patch works around this problem by retrying once if the lsa_lookupsids
call fails, re-establishing the dc-connection, as we already do in many other
places (e.g. the winbindd retry methods for the rpc layer).

Michael

source3/winbindd/winbindd_ads.c

index 18cc1cbd038186fff12aa879173f74fb276c583b..94a24278eb0984234238eeff16b27eb292a479d1 100644 (file)
@@ -1081,6 +1081,29 @@ static NTSTATUS lookup_groupmem(struct winbindd_domain *domain,
                                                &names_nocache,
                                                &name_types_nocache);
 
                                                &names_nocache,
                                                &name_types_nocache);
 
+               if (!(NT_STATUS_IS_OK(status) ||
+                     NT_STATUS_EQUAL(status, STATUS_SOME_UNMAPPED) ||
+                     NT_STATUS_EQUAL(status, NT_STATUS_NONE_MAPPED)))
+               {
+                       DEBUG(1, ("lsa_lookupsids call failed with %s "
+                                 "- retrying...\n", nt_errstr(status)));
+
+                       status = cm_connect_lsa(domain, tmp_ctx, &cli,
+                                               &lsa_policy);
+
+                       if (!NT_STATUS_IS_OK(status)) {
+                               goto done;
+                       }
+
+                       status = rpccli_lsa_lookup_sids(cli, tmp_ctx,
+                                                       &lsa_policy,
+                                                       num_nocache,
+                                                       sid_mem_nocache,
+                                                       &domains_nocache,
+                                                       &names_nocache,
+                                                       &name_types_nocache);
+               }
+
                if (NT_STATUS_IS_OK(status) ||
                    NT_STATUS_EQUAL(status, STATUS_SOME_UNMAPPED))
                {
                if (NT_STATUS_IS_OK(status) ||
                    NT_STATUS_EQUAL(status, STATUS_SOME_UNMAPPED))
                {