samba-tool drs showrepl: correctly report failing repsFrom
authorAndrew Bartlett <abartlet@samba.org>
Tue, 3 Jul 2018 23:45:14 +0000 (11:45 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Wed, 4 Jul 2018 02:43:39 +0000 (04:43 +0200)
Hopefully this fixes the flapping test.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Wed Jul  4 04:43:39 CEST 2018 on sn-devel-144

python/samba/netcmd/drs.py

index 664a710179a8cf4edec571920fac053e1214a1a9..b8793b7660695d3c906542468c6250eac307bf03 100644 (file)
@@ -229,7 +229,7 @@ class cmd_drs_showrepl(Command):
                 if rep['is deleted']:
                     continue
                 if rep["consecutive failures"] != 0 or rep["last success"] == 0:
-                    failing_repsto.append(rep)
+                    failing_repsfrom.append(rep)
 
         if failing_repsto or failing_repsfrom:
             self.message(colour.c_RED("There are failing connections"))