From facd6f2daf6df0f9c82bcbe36946507736e9648c Mon Sep 17 00:00:00 2001 From: Aliaksei Karaliou Date: Fri, 21 Dec 2018 16:47:00 +0300 Subject: [PATCH] s4:torture:base:bench-readwrite: fix uninitialized memory causing segfault Allocation of 'struct smb_composite_connect' happens without zeroing so that smb_composite_connect_send() thinks that connection already exists and fails on its handling. Signed-off-by: Aliaksei Karaliou Reviewed-by: Douglas Bagnall Reviewed-by: Jeremy Allison --- source4/torture/basic/misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source4/torture/basic/misc.c b/source4/torture/basic/misc.c index 25ae4560de8..8b187f8ddd4 100644 --- a/source4/torture/basic/misc.c +++ b/source4/torture/basic/misc.c @@ -931,8 +931,8 @@ bool run_benchrw(struct torture_context *tctx) switch (state[i]->mode){ /*open multiple connections with the same userid */ case START: - smb_con = talloc( - tctx,struct smb_composite_connect) ; + smb_con = talloc_zero( + tctx,struct smb_composite_connect); state[i]->req_params=smb_con; state[i]->mode=OPEN_CONNECTION; req1 = torture_connect_async( -- 2.34.1