From f164e81e8b268ccab6c51c966b569dd06106caa2 Mon Sep 17 00:00:00 2001 From: "Jose A. Rivera" Date: Mon, 3 Mar 2014 11:52:46 +0530 Subject: [PATCH] lib/popt: Patch memory leak in popthelp.c Memory created as "t" was not being free'd. Change-Id: I5f6e20acc6c440a1cd9908aed7a90de2000f22f8 Coverity-Id: 240599 Coverity-Id: 240600 Signed-off-by: Jose A. Rivera Reviewed-by: Jeremy Allison Reviewed-by: Ira Cooper --- lib/popt/popthelp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/popt/popthelp.c b/lib/popt/popthelp.c index 0ed355a18d7..4e2a1a56ced 100644 --- a/lib/popt/popthelp.c +++ b/lib/popt/popthelp.c @@ -253,8 +253,8 @@ static void singleOptionHelp(FILE * fp, int maxLeftCol, } *te++ = ' '; strcpy(te, defs); - defs = (char *)_free(defs); } + defs = (char *)_free(defs); defs = t; } } @@ -326,7 +326,7 @@ static void singleOptionHelp(FILE * fp, int maxLeftCol, left = (char *)_free(left); if (defs) { - help = defs; defs = NULL; + help = defs; } helpLength = strlen(help); -- 2.34.1