From e8d431250edebf96c1d80aacf2f676c93da907f4 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Fri, 12 May 2017 16:04:02 +0200 Subject: [PATCH] s4:ldap_server: avoid pointless check arround LDAP_INVALID_CREDENTIALS Signed-off-by: Stefan Metzmacher Reviewed-by: Andrew Bartlett --- source4/ldap_server/ldap_bind.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/source4/ldap_server/ldap_bind.c b/source4/ldap_server/ldap_bind.c index e36cb1cebf6..06b52fe9510 100644 --- a/source4/ldap_server/ldap_bind.c +++ b/source4/ldap_server/ldap_bind.c @@ -428,11 +428,9 @@ static NTSTATUS ldapsrv_BindSASL(struct ldapsrv_call *call) if (!NT_STATUS_IS_OK(status)) { status = nt_status_squash(status); - if (result == 0) { - result = LDAP_INVALID_CREDENTIALS; - errstr = ldapsrv_bind_error_msg(reply, HRES_SEC_E_LOGON_DENIED, - 0x0C0904DC, status); - } + result = LDAP_INVALID_CREDENTIALS; + errstr = ldapsrv_bind_error_msg(reply, HRES_SEC_E_LOGON_DENIED, + 0x0C0904DC, status); talloc_unlink(conn, conn->gensec); conn->gensec = NULL; goto do_reply; -- 2.34.1