From d0ef97f74b61f0441b078845d0637f5dad3e2e16 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Thu, 7 Jan 2010 10:43:23 +0100 Subject: [PATCH] s3:ntlmssp: use a 'bool ok' variable to make the code more readable MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit metze Signed-off-by: Günther Deschner --- source3/libsmb/ntlmssp_sign.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/source3/libsmb/ntlmssp_sign.c b/source3/libsmb/ntlmssp_sign.c index 37bb0efdeb3..9c7bc241e14 100644 --- a/source3/libsmb/ntlmssp_sign.c +++ b/source3/libsmb/ntlmssp_sign.c @@ -125,10 +125,16 @@ static NTSTATUS ntlmssp_make_packet_signature(struct ntlmssp_state *ntlmssp_stat dump_data_pw("ntlmssp v2 sig ", sig->data, sig->length); } else { + bool ok; uint32_t crc; crc = crc32_calc_buffer(data, length); - if (!msrpc_gen(ntlmssp_state, sig, "dddd", NTLMSSP_SIGN_VERSION, 0, crc, ntlmssp_state->ntlmv1_seq_num)) { + + ok = msrpc_gen(ntlmssp_state, + sig, "dddd", + NTLMSSP_SIGN_VERSION, 0, crc, + ntlmssp_state->ntlmv1_seq_num); + if (!ok) { return NT_STATUS_NO_MEMORY; } @@ -285,10 +291,16 @@ NTSTATUS ntlmssp_seal_packet(struct ntlmssp_state *ntlmssp_state, sig->data+4, 8); } } else { + bool ok; uint32_t crc; crc = crc32_calc_buffer(data, length); - if (!msrpc_gen(ntlmssp_state, sig, "dddd", NTLMSSP_SIGN_VERSION, 0, crc, ntlmssp_state->ntlmv1_seq_num)) { + + ok = msrpc_gen(ntlmssp_state, + sig, "dddd", + NTLMSSP_SIGN_VERSION, 0, crc, + ntlmssp_state->ntlmv1_seq_num); + if (!ok) { return NT_STATUS_NO_MEMORY; } -- 2.34.1