From aec07b8b60ff9589a3c84eef6adeca464e6c01f6 Mon Sep 17 00:00:00 2001 From: "Jose A. Rivera" Date: Wed, 3 Feb 2016 20:58:19 -0600 Subject: [PATCH] s3:smbd:open: Skip redundant call to file_set_dosmode when creating a new file. Signed-off-by: Jose A. Rivera Pair-programmed-with: Ira Cooper Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Fri Feb 5 04:37:43 CET 2016 on sn-devel-144 --- source3/smbd/open.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source3/smbd/open.c b/source3/smbd/open.c index ed0594b1756..fa817e44563 100644 --- a/source3/smbd/open.c +++ b/source3/smbd/open.c @@ -3169,8 +3169,8 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn, } if (info != FILE_WAS_OPENED) { - /* Files should be initially set as archive */ - if (lp_map_archive(SNUM(conn)) || + /* Overwritten files should be initially set as archive */ + if ((info == FILE_WAS_OVERWRITTEN && lp_map_archive(SNUM(conn))) || lp_store_dos_attributes(SNUM(conn))) { if (!posix_open) { if (file_set_dosmode(conn, smb_fname, -- 2.34.1