From 8b92539997a9df8e0d217790fd82fc8f59ea50cc Mon Sep 17 00:00:00 2001 From: Noel Power Date: Tue, 18 Jun 2019 10:42:06 +0000 Subject: [PATCH] lib/krb5_wrap: clang: Fix warning: Call to function 'mktemp' is insecure Fixes: lib/krb5_wrap/krb5_samba.c:2012:2: warning: Call to function 'mktemp' is insecure as it always creates or uses insecure temporary file. Use 'mkstemp' instead <--[clang] mktemp(tmp_name); ^~~~~~ Signed-off-by: Noel Power Reviewed-by: Gary Lockyer --- lib/krb5_wrap/krb5_samba.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/krb5_wrap/krb5_samba.c b/lib/krb5_wrap/krb5_samba.c index 344a26cdb6c..eac86e6754b 100644 --- a/lib/krb5_wrap/krb5_samba.c +++ b/lib/krb5_wrap/krb5_samba.c @@ -2009,7 +2009,7 @@ krb5_error_code smb_krb5_kinit_keyblock_ccache(krb5_context ctx, memcpy(tmp_name, SMB_CREDS_KEYTAB, sizeof(SMB_CREDS_KEYTAB)); mask = umask(S_IRWXO | S_IRWXG); - mktemp(tmp_name); + mkstemp(tmp_name); umask(mask); if (tmp_name[0] == 0) { return KRB5_KT_BADNAME; -- 2.34.1